Re: [Qemu-devel] [PATCH] virtio-9p: fix QEMU build break

2011-10-11 Thread Zhi Yong Wu
On Tue, Oct 11, 2011 at 12:49 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Mon, 10 Oct 2011 22:05:21 +0530, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Mon, 10 Oct 2011 18:30:28 +0800, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: qemu build break due to the

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-11 Thread Zhi Yong Wu
On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). They should go through bdrv_co_do_readv() and bdrv_co_do_writev() instead in order to unify request processing code across sync, aio, and

Re: [Qemu-devel] [PATCH 6/6] block: switch bdrv_aio_writev() to coroutines

2011-10-11 Thread Zhi Yong Wu
On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: More sync, aio, and coroutine unification.  Make bdrv_aio_writev() go through coroutine request processing. Remove the dirty block callback mechanism which was needed only for aio processing and can be done

Re: [Qemu-devel] [PATCH 0/6] block: do request processing in a coroutine

2011-10-11 Thread Zhi Yong Wu
On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Block layer features like dirty block tracing, I/O throttling, and live block copy are forced to duplicate code due to the three different interfaces: synchronous, asynchronous, and coroutines. Since there are

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-11 Thread Jan Kiszka
On 2011-10-11 04:20, Wen Congyang wrote: The other reason why it would be good, is that we would then have a clearly defined standard QEMU dump format, instead of libvirt dump format for QEMU A core file would be that format - for direct gdb processing. No proprietary re-inventions please.

Re: [Qemu-devel] [PATCH 0/2] usb-ohci: fixes to allow usb-net to work

2011-10-11 Thread Gerd Hoffmann
On 10/10/11 18:44, Peter Maydell wrote: On 14 September 2011 18:48, Peter Maydellpeter.mayd...@linaro.org wrote: This patchset contains a couple of fixes to usb-ohci which I had to make in the course of getting usb-net to work on the Beagle (which uses OHCI rather than UHCI). The main one is

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-11 Thread Wen Congyang
At 10/11/2011 02:58 PM, Jan Kiszka Write: On 2011-10-11 04:20, Wen Congyang wrote: The other reason why it would be good, is that we would then have a clearly defined standard QEMU dump format, instead of libvirt dump format for QEMU A core file would be that format - for direct gdb

[Qemu-devel] [PATCH v2] Sort the help info shown in monitor at runtime

2011-10-11 Thread Wayne Xia
Introduced two queues to save sorted command list in it. As a result, command help and help info would show a more friendly sorted command list. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the command list is sorted. v2: write sorted command list

Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor

2011-10-11 Thread Wayne Xia
于 2011-10-4 21:55, Luiz Capitulino 写道: On Wed, 28 Sep 2011 10:16:19 +0100 Stefan Hajnoczistefa...@gmail.com wrote: On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xiaxiaw...@linux.vnet.ibm.com wrote: During my test, I found it inconvenient when I type help or help info, because the information was

[Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-11 Thread Paolo Bonzini
This patch adds more valid transitions to the table, and avoids that the VM remains stuck in RSTATE_SAVEVM state when savevm is done on a paused virtual machine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- savevm.c |9 +++-- vl.c |5 + 2 files changed, 12

Re: [Qemu-devel] [BUG] USB assertion triggers in usb_packet_complete()

2011-10-11 Thread Thomas Huth
Am Mon, 10 Oct 2011 15:03:41 +0200 schrieb Thomas Huth th...@linux.vnet.ibm.com: I am currently facing a problem when running QEMU (up-to-date git version) with OHCI and a lot of virtual USB devices. The emulator dies with the following assertion: qemu-system-arm: hw/usb.c:337:

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

2011-10-11 Thread Kevin Wolf
Am 10.10.2011 22:25, schrieb Luiz Capitulino: On Mon, 10 Oct 2011 19:30:32 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.09.2011 22:43, schrieb Luiz Capitulino: This series adds support to the block layer to keep track of devices' I/O status. That information is also made available in QMP

[Qemu-devel] [PATCH] remove hpet.h

2011-10-11 Thread Paolo Bonzini
It is unused since the HPET and RTC timers were removed (commit 25f3151, 2011-05-31). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hpet.h | 22 -- 1 files changed, 0 insertions(+), 22 deletions(-) delete mode 100644 hpet.h diff --git a/hpet.h b/hpet.h deleted file

Re: [Qemu-devel] [PATCH 00/15] NBD server improvements

2011-10-11 Thread Paolo Bonzini
On 10/10/2011 11:37 AM, Paolo Bonzini wrote: This series adds asynchronous operation support for the NBD server. The first 9 patches are a general refactoring that can be applied now. The others require the main loop in tools series. They also need rebasing after the QMP changes. Kevin, is it

[Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Daniel P. Berrange
On Mon, Oct 10, 2011 at 09:01:52PM +0200, Alexander Graf wrote: On 10.10.2011, at 20:53, Anthony Liguori wrote: On 10/10/2011 12:08 PM, Daniel P. Berrange wrote: With the attached patches applied to QEMU and SeaBios, the attached systemtap script can be used to debug timings in QEMU

Re: [Qemu-devel] Hang when using 9p mounts after last Seabios update

2011-10-11 Thread Daniel P. Berrange
On Sat, Oct 01, 2011 at 12:50:43PM -0400, Kevin O'Connor wrote: On Thu, Sep 22, 2011 at 12:45:11PM +0100, Daniel P. Berrange wrote: On 0.14, 0.15 releaes, this all works just fine. On current GIT master, the guest OS will hang during boot. [...] To reproduce this you will need my custom

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Richard W.M. Jones
On Tue, Oct 11, 2011 at 09:23:15AM +0100, Daniel P. Berrange wrote: - libguestfs directly boots its appliance using the regular host's kernel image and a custom built initrd image. The initrd does not contain the entire appliance, just enough to boot up and dynamically read files in

Re: [Qemu-devel] [PATCH 07/11] audio/spice: add support for volume control

2011-10-11 Thread Gerd Hoffmann
Hi, +#else +#warning Spice playback volume unsupported +#endif +#else +#warning Spice record volume unsupported +#endif One warning is enougth. But given that qemu builds with -Werror by default printing a warning just because of an older spice-server version is a bad idea IMHO. @@

Re: [Qemu-devel] [PATCH 00/11] RFC: apply volume on client stream

2011-10-11 Thread Gerd Hoffmann
On 09/21/11 18:10, Marc-André Lureau wrote: Hi, The qemu volume control experience could be improved. Without mixemu, the volume control has no effect. A volume applet will just feel broken (except in some cases where software volume is applied on guest side, with HDA/Windows7 for example).

Re: [Qemu-devel] Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/10/2011 09:01 PM, Alexander Graf wrote: For example, one execution of QEMU produced the following log: $ stap qemu-timing.stp 0.000 Start 0.036 Run 0.038 BIOS post 0.180 BIOS int 19 0.181 BIOS boot OS 0.181 LinuxBoot copy kernel 1.371 LinuxBoot copy

Re: [Qemu-devel] [PATCH v2] Sort the help info shown in monitor at runtime

2011-10-11 Thread Markus Armbruster
Wayne Xia xiaw...@linux.vnet.ibm.com writes: Introduced two queues to save sorted command list in it. As a result, command help and help info would show a more friendly sorted command list. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ...

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 10:23 AM, Daniel P. Berrange wrote: - Application sandbox, directly boots the regular host's kernel and a custom initrd image. The initrd does not contain any files except for the 9p kernel modules and a custom init binary, which mounts the guest root FS from a 9p

Re: [Qemu-devel] Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2011 at 11:08:33AM +0200, Avi Kivity wrote: On 10/10/2011 09:01 PM, Alexander Graf wrote: For example, one execution of QEMU produced the following log: $ stap qemu-timing.stp 0.000 Start 0.036 Run 0.038 BIOS post 0.180 BIOS int 19 0.181 BIOS

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Alexander Graf
On 11.10.2011, at 11:15, Avi Kivity wrote: On 10/11/2011 10:23 AM, Daniel P. Berrange wrote: - Application sandbox, directly boots the regular host's kernel and a custom initrd image. The initrd does not contain any files except for the 9p kernel modules and a custom init binary,

Re: [Qemu-devel] [PATCH RFC] qemu-file: output data directly if possible

2011-10-11 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 10, 2011 at 09:42:51AM +0200, Paolo Bonzini wrote: On 10/10/2011 01:56 AM, Michael S. Tsirkin wrote: qemu file currently always buffers up data before writing it out. At least for memory this is probably not a good idea: writing out to

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:19 AM, Alexander Graf wrote: Of this, 1.4 seconds is the time required by LinuxBoot to copy the kernel+initrd. If I used an uncompressed initrd, which I really want to, to avoid decompression overhead, this increases to ~1.7 seconds. So the LinuxBoot ROM is ~60% of

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2011 at 11:15:05AM +0200, Avi Kivity wrote: On 10/11/2011 10:23 AM, Daniel P. Berrange wrote: - Application sandbox, directly boots the regular host's kernel and a custom initrd image. The initrd does not contain any files except for the 9p kernel modules and a custom

Re: [Qemu-devel] Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:18 AM, Daniel P. Berrange wrote: The rep/ins implementation is still slow, optimizing it can help. What does 'perf top' say when running this workload? To ensure it only recorded the LinuxBoot code, I created a 100 MB kernel image which takes approx 30 seconds to copy.

[Qemu-devel] console: Properly switch consoles for screen dumps breaks qxl screen dump

2011-10-11 Thread Alon Levy
Hi Jan, I've recently found the $SUBJECT, it's commit f81bdefb63243e82d16ce49332f7cf74d10b8f27. I'd like to fix it without breaking anything, can you provide me with the test that your original patch fixed? Alon p.s. for a simple command line with a single console (not even sure how to

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Alexander Graf
On 11.10.2011, at 11:26, Avi Kivity wrote: On 10/11/2011 11:19 AM, Alexander Graf wrote: Of this, 1.4 seconds is the time required by LinuxBoot to copy the kernel+initrd. If I used an uncompressed initrd, which I really want to, to avoid decompression overhead, this increases to ~1.7

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:27 AM, Daniel P. Berrange wrote: One thing we can do is boot a guest and immediately snapshot it, before it runs any application specific code. Subsequent invocations will MAP_PRIVATE the memory image and COW their way. This avoids the kernel initialization time as

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2011 at 11:39:36AM +0200, Avi Kivity wrote: On 10/11/2011 11:27 AM, Daniel P. Berrange wrote: For comparison I also did a test building a bootable ISO using ISOLinux. This required 700 ms for the boot time, which is appoximately 1/2 the time reqiured for direct

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:38 AM, Alexander Graf wrote: and gets you in a pretty bizarre state when doing updates of your host files, since then you have 2 different paths: full boot and restore. That's yet another potential source for bugs. Typically you'd check the timestamps to make sure you're

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:49 AM, Daniel P. Berrange wrote: On Tue, Oct 11, 2011 at 11:39:36AM +0200, Avi Kivity wrote: On 10/11/2011 11:27 AM, Daniel P. Berrange wrote: For comparison I also did a test building a bootable ISO using ISOLinux. This required 700 ms for the boot time, which is

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Gleb Natapov
On Tue, Oct 11, 2011 at 11:26:14AM +0200, Avi Kivity wrote: rep/ins is exactly like dma+wait for this use case: provide an address, get a memory image in return. There's no need to add another interface, we should just optimize the existing one. rep/ins cannot be optimized to be as efficient

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:50 AM, Gleb Natapov wrote: On Tue, Oct 11, 2011 at 11:26:14AM +0200, Avi Kivity wrote: rep/ins is exactly like dma+wait for this use case: provide an address, get a memory image in return. There's no need to add another interface, we should just optimize the existing one.

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Gleb Natapov
On Tue, Oct 11, 2011 at 11:49:16AM +0200, Avi Kivity wrote: Whatever we do, the interface will never be as fast as DMA. We will always have to do sanity / permission checks for every IO operation, can batch up only so many IO requests and in QEMU again have to call our callbacks in a loop.

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Avi Kivity
On 10/11/2011 11:56 AM, Gleb Natapov wrote: On Tue, Oct 11, 2011 at 11:49:16AM +0200, Avi Kivity wrote: Whatever we do, the interface will never be as fast as DMA. We will always have to do sanity / permission checks for every IO operation, can batch up only so many IO requests and in QEMU

[Qemu-devel] [PATCH v4 00/36] Migration errors cleanup (the integrated version)

2011-10-11 Thread Juan Quintela
Hi v4: - rebase on top of new qemu and new migration-errors series - integrate back erros cleanup series - s/MIG_STATE_NONE/MIG_STATE_SETUP/ (Orit suggestion) - s/migrate_create_state/migrate_new/ (Anthony suggestion) - Add migrate_get_current() accessor. - make has_error contain the errno

[Qemu-devel] [PATCH 03/36] migration: Check that migration is active before cancel it

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 7fd6c23..71b8aad 100644 --- a/migration.c +++ b/migration.c @@ -133,9 +133,9 @@ int do_migrate_cancel(Monitor *mon, const

[Qemu-devel] [PATCH 01/36] ds1225y: Use stdio instead of QEMUFile

2011-10-11 Thread Juan Quintela
QEMUFile * is only intended for migration nowadays. Using it for anything else just adds pain and a layer of buffers for no good reason. Signed-off-by: Juan Quintela quint...@redhat.com --- hw/ds1225y.c | 28 1 files changed, 16 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH 11/36] migration: change has_error to contain errno values

2011-10-11 Thread Juan Quintela
We normally already have an errno value. When not, abuse EINVAL. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c |2 +- block-migration.c |6 +++--- buffered_file.c |4 ++-- hw/hw.h |2 +- migration.c |2 +- savevm.c |8

[Qemu-devel] [PATCH 12/36] migration: rename qemu_file_has_error to qemu_file_get_error

2011-10-11 Thread Juan Quintela
Now the function returned errno, so it is better the new name. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c |2 +- block-migration.c |8 buffered_file.c | 14 +++--- hw/hw.h |2 +- migration.c |2 +- savevm.c

[Qemu-devel] [PATCH 22/36] migration: Introduce MIG_STATE_SETUP

2011-10-11 Thread Juan Quintela
Use MIG_STATE_ACTIVE only when migration has really started. Use this new state to setup migration parameters. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |6 +- migration.h | 11 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 28/36] migration: Move exported functions to the end of the file

2011-10-11 Thread Juan Quintela
This means we can remove the two forward declarations. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- migration.c | 187 +-- 1 files changed, 91 insertions(+), 96 deletions(-) diff

[Qemu-devel] [PATCH 34/36] migration: Don't use callback on file defining it

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index f6b2288..bd3aa3a 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -58,7

[Qemu-devel] [PATCH 35/36] migration: propagate error correctly

2011-10-11 Thread Juan Quintela
unix and tcp outgoing migration have error values, but didn't returned it. Make them return the error. Notice that EINPROGRESS EWOULDBLOCK are not considered errors as call will be retry later. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com

[Qemu-devel] [PATCH 36/36] migration: make migration-{tcp, unix} consistent

2011-10-11 Thread Juan Quintela
Files are almost identical in functionality, just remove the differences that make no sense. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- migration-tcp.c | 15 ++- migration-unix.c | 46

[Qemu-devel] [PATCH 17/36] migration: Fold MigrationState into FdMigrationState

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 10 +- migration-unix.c | 10 +- migration.c | 14 ++ migration.h

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2011 at 11:50:01AM +0200, Avi Kivity wrote: On 10/11/2011 11:49 AM, Daniel P. Berrange wrote: On Tue, Oct 11, 2011 at 11:39:36AM +0200, Avi Kivity wrote: On 10/11/2011 11:27 AM, Daniel P. Berrange wrote: For comparison I also did a test building a bootable ISO using

[Qemu-devel] [PATCH 07/36] buffered_file: Use right opaque

2011-10-11 Thread Juan Quintela
buffered_close 's' variable is of type QEMUFileBuffered, and wait_for_unfreeze() expect to receive a MigrationState, that 'coincidentaly' is s-opaque. Signed-off-by: Juan Quintela quint...@redhat.com --- buffered_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 06/36] migration: If there is one error, it makes no sense to continue

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- buffered_file.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 486af57..bcdf04f 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -193,9 +193,9 @@ static int

[Qemu-devel] [PATCH 18/36] migration: Rename FdMigrationState MigrationState

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 12 ++-- migration-unix.c | 12 ++-- migration.c | 34

[Qemu-devel] [PATCH 10/36] migration: set error if select return one error

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 090c925..56c2b1c 100644 --- a/migration.c +++ b/migration.c @@ -457,6 +457,10 @@ void migrate_fd_wait_for_unfreeze(void

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Gleb Natapov
On Tue, Oct 11, 2011 at 11:59:45AM +0200, Avi Kivity wrote: On 10/11/2011 11:56 AM, Gleb Natapov wrote: On Tue, Oct 11, 2011 at 11:49:16AM +0200, Avi Kivity wrote: Whatever we do, the interface will never be as fast as DMA. We will always have to do sanity / permission checks for every IO

[Qemu-devel] [PATCH 08/36] buffered_file: reuse QEMUFile has_error field

2011-10-11 Thread Juan Quintela
Instead of having two has_error fields in QEMUFile QEMUBufferedFile, reuse the 1st one. Notice that the one in buffered_file is only set after a file operation. Signed-off-by: Juan Quintela quint...@redhat.com --- buffered_file.c | 17 - 1 files changed, 8 insertions(+), 9

[Qemu-devel] [PATCH 26/36] migration: Remove get_status() accessor

2011-10-11 Thread Juan Quintela
It is only used inside migration.c, and fields on that struct are accessed all around the place on that file. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 16 +--- migration.h |1 - 2 files changed, 5 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 27/36] migration: Remove migration cancel() callback

2011-10-11 Thread Juan Quintela
It is used only in one place Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |9 - migration.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 0b7ffa7..33e89a2 100644 --- a/migration.c +++ b/migration.c @@

[Qemu-devel] [PATCH -V2 01/13] hw/9pfs: Use ioeventfd for 9p

2011-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With ioeventfd: [root@qemu-img-64 storage]# dd if=/dev/zero of=/storage/testx bs=8k count=131072 oflag=direct 131072+0 records in 131072+0 records out 1073741824 bytes (1.1 GB) copied, 26.767 s, 40.1 MB/s Without: [root@qemu-img-64

[Qemu-devel] [PATCH -V2 08/13] hw/9pfs: Add st_gen support in getattr reply

2011-10-11 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora ha...@linux.vnet.ibm.com This patch use file system specific ioctl for getting i_generation value. Not all file system support the ioctl. So we add an export specific extended operation and assign right callback for the file system that support i_generation ioctl [M.

[Qemu-devel] [PATCH -V2 09/13] hw/9pfs: Add st_gen support for handle based fs driver

2011-10-11 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora ha...@linux.vnet.ibm.com Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-handle.c | 51 1 files changed, 51 insertions(+), 0

[Qemu-devel] [PATCH -V2 11/13] hw/9pfs: Remove virtio-9p-debug.* infra to be replaced by Qemu Tracing.

2011-10-11 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora ha...@linux.vnet.ibm.com Removing the existing debug infrastrucure as proposed to be replaced by Qemu Tracing infrastructure. Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar

[Qemu-devel] [PATCH -V2 12/13] scripts: Simpletrace log analysis script for pretty-printing 9p log.

2011-10-11 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora ha...@linux.vnet.ibm.com This python script allows to pretty print 9p simpletrace logs and can be further enhanced to filter 9p logs based on command line arguments. Sample output: TGETATTR (tag = 1 , fid = 0 , request_mask = 0x7ff ) RGETATTR (tag = 1 , result_mask =

[Qemu-devel] [PATCH -V2 03/13] qemu-options.hx: Update virtfs command documentation

2011-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Clarify the virtfs option better Updates from:Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- qemu-options.hx | 119 --- 1 files

[Qemu-devel] [PATCH 16/36] migration: Use FdMigrationState instead of MigrationState when possible

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- migration.c | 34 -- migration.h | 16 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/migration.c b/migration.c index

[Qemu-devel] [PATCH 14/36] migration: use qemu_file_get_error() return value when possible

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c |6 -- block-migration.c |7 --- buffered_file.c | 13 - savevm.c |4 ++-- 4 files changed, 18 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index

[Qemu-devel] [PATCH 23/36] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/migration.c b/migration.c index a01bf4f..432afe6 100644 --- a/migration.c +++ b/migration.c @@ -372,23 +372,22 @@ static void

[Qemu-devel] [PATCH 09/36] migration: don't write when migration is not active

2011-10-11 Thread Juan Quintela
If migration is not active, just ignore writes. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 7ac1fc2..090c925 100644 --- a/migration.c +++ b/migration.c @@ -323,6

[Qemu-devel] [PATCH -V2 05/13] virtio-9p: Use 9P specific Lock constants

2011-10-11 Thread Aneesh Kumar K.V
From: M. Mohan Kumar mo...@in.ibm.com Use 9P specific lock constants instead of arch specific lock constants. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p.c |2 +- hw/9pfs/virtio-9p.h |5 + 2

[Qemu-devel] [PATCH -V2 04/13] hw/9pfs: Fix build error on platform that don't support futimens

2011-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Also don't do glibc version check to find handle support. Instead do handle syscall support in configure. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- configure | 16 +

[Qemu-devel] [PATCH 02/36] migration: simplify state assignmente

2011-10-11 Thread Juan Quintela
Once there, make sure that if we already know that there is one error, just call migration_fd_cleanup() with the ERROR state. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/migration.c

[Qemu-devel] [PATCH 05/36] migration: add error handling to migrate_fd_put_notify().

2011-10-11 Thread Juan Quintela
From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in case of error.

[Qemu-devel] [PATCH 31/36] migration: Pass MigrationState in migration notifiers

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/migration.c b/migration.c index 4f308ce..6129cb5 100644 --- a/migration.c +++ b/migration.c @@ -222,7 +222,7 @@ void migrate_fd_error(MigrationState *s)

[Qemu-devel] [PATCH 33/36] migration: Make state definitions local

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |8 migration.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/migration.c b/migration.c index c4e2ba6..e9237f3 100644 --- a/migration.c +++ b/migration.c @@ -31,6 +31,14 @@ do { }

[Qemu-devel] [PATCH 15/36] migration: Make *start_outgoing_migration return FdMigrationState

2011-10-11 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration-exec.c |4 ++-- migration-fd.c |4 ++-- migration-tcp.c |4 ++-- migration-unix.c |4 ++-- migration.c |4 ++-- migration.h |8 6 files changed, 14 insertions(+), 14 deletions(-) diff

[Qemu-devel] [PATCH -V2 07/13] hw/9pfs: Add open flag mapping

2011-10-11 Thread Aneesh Kumar K.V
From: M. Mohan Kumar mo...@in.ibm.com Some of the flags are OS/arch dependent we need to use 9P defined value on wire, Based on the original patch from Venkateswararao Jujjuri jv...@linux.vnet.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH V2 00/13] VirtFS update

2011-10-11 Thread Aneesh Kumar K.V
Pending patches in VirtFS tree for which i will be sending a pull request after this review. -aneesh

[Qemu-devel] [PATCH 24/36] migration: Introduce migrate_fd_completed() for consistency

2011-10-11 Thread Juan Quintela
This function is a bit different of the others that change the state, in the sense that if migrate_fd_cleanup() returns an error, it set the status to error, not completed. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 20 +--- 1 files changed, 13

[Qemu-devel] [PATCH -V2 06/13] hw/9pfs: Ensure an error is reported to user if 9pfs mount tag is too long

2011-10-11 Thread Aneesh Kumar K.V
From: Daniel P. Berrange berra...@redhat.com If the 9pfs mount tag is longer than MAX_TAG_LEN bytes, rather than silently truncating the tag which will likely break the guest OS, report an immediate error and exit QEMU * hw/9pfs/virtio-9p-device.c: Report error exit if mount tag is too long

Re: [Qemu-devel] [Spice-devel] viewing continuous guest virtual memory as continuous in qemu

2011-10-11 Thread Gerd Hoffmann
Hi, AFAIU this works only when the guest allocates a continuous range of physical pages. This is a large requirement from the guest, which I'd like to drop. Is it? The world is moving to huge pages, with all the stuff needed for it like moving around userspace pages to compact memory and

[Qemu-devel] [PATCH 30/36] migration: Use bandwidth_limit directly

2011-10-11 Thread Juan Quintela
Now that current_migration always exist, there is no reason for max_throotle variable. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/migration.c b/migration.c index 8422ec3..4f308ce 100644

[Qemu-devel] [PATCH 13/36] savevm: Rename has_error to last_error field

2011-10-11 Thread Juan Quintela
Now the field contains the last error name, so rename acordingly. Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index c037eb3..69a2ccd 100644 --- a/savevm.c +++ b/savevm.c

[Qemu-devel] [PATCH 01/13] remove unused function

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mac_dbdma.c |5 - hw/mac_dbdma.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index 5affdd1..1791ec1 100644 --- a/hw/mac_dbdma.c +++ b/hw/mac_dbdma.c @@ -661,11 +661,6 @@

[Qemu-devel] [PATCH -V2 13/13] hw/9pfs: Use fs driver specific lstat

2011-10-11 Thread Aneesh Kumar K.V
From: M. Mohan Kumar mo...@in.ibm.com Use file system driver specific lstat instead of generic lstat. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-device.c | 33 +++-- 1 files

[Qemu-devel] [PATCH 06/13] qemu-timer: do not refer to runstate_is_running()

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |1 + qemu-timer.c |5 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 986c900..64b6943 100644 --- a/cpus.c +++ b/cpus.c @@ -1059,6 +1059,7 @@ void pause_all_vcpus(void) {

[Qemu-devel] [PATCH 08/13] qemu-timer: move more stuff out of qemu-timer.c

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 35 --- qemu-timer.h |2 ++ savevm.c | 25 + vl.c |1 + 4 files changed, 32 insertions(+), 31 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c

[Qemu-devel] [PATCH 05/13] qemu-timer: move icount to cpus.c

2011-10-11 Thread Paolo Bonzini
None of this is needed by tools, and most of it can even be made static inside cpus.c. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c| 295 + exec-all.h| 14 +++ exec.c|3 - qemu-common.h |4 +

[Qemu-devel] [PATCH 10/13] create main-loop.h

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- async.c |1 + cpus.c|7 + cpus.h|1 - main-loop.h | 73 + qemu-char.h | 12 + qemu-common.h | 11 sysemu.h |3 +-

[Qemu-devel] [PATCH -V2 10/13] hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-11 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora ha...@linux.vnet.ibm.com Plan is to replace the existing debug infrastructure with Qemu tracing infrastructure so that user can dynamically enable/disable trace events and therefore a meaningful trace log can be generated which can be further filtered using an analysis

[Qemu-devel] [PATCH 07/13] qemu-timer: use atexit for quit_timers

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 15 --- qemu-timer.h |1 - vl.c |1 - 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index d8507e3..7fa81e1 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@

Re: [Qemu-devel] KVM call agenda for October 11th

2011-10-11 Thread Paolo Bonzini
On 10/10/2011 01:35 PM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. Planning the feature freeze: - what is left to merge? - test day? Paolo

[Qemu-devel] [PATCH 32/36] migration: Export a function that tells if the migration has finished correctly

2011-10-11 Thread Juan Quintela
This will allow us to hide the state values. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |4 ++-- migration.h |2 +- ui/spice-core.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index 6129cb5..c4e2ba6

[Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-11 Thread Juan Quintela
We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed migration (it can't be a sucessful one, otherwise

[Qemu-devel] [PATCH -V2 02/13] hw/9pfs: Add new virtfs option cache=writethrough to skip host page cache

2011-10-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com cache=writethrough implies the file are opened in the host with O_SYNC open flag Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- fsdev/file-op-9p.h |4 fsdev/qemu-fsdev.c | 10 --

[Qemu-devel] [PATCH 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+), 76 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index acf7a15..e2551f3 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@

[Qemu-devel] [PATCH 21/36] migration: move migrate_new to do_migrate

2011-10-11 Thread Juan Quintela
Once there, remove all parameters that don't need to be passed to *start_outgoing_migration() functions Signed-off-by: Juan Quintela quint...@redhat.com --- migration-exec.c | 19 +-- migration-fd.c | 22 ++ migration-tcp.c | 22 +++---

[Qemu-devel] [PATCH 11/13] create main-loop.c

2011-10-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.objs|2 +- cpus.c | 188 + cpus.h |1 + main-loop.c | 494 ++ os-win32.c | 123 -- qemu-os-posix.h |

Re: [Qemu-devel] KVM call agenda for October 11th

2011-10-11 Thread Avi Kivity
On 10/10/2011 01:35 PM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. Subsections, version numbers, migration to older releases. -- error compiling committee.c: too many arguments to function

[Qemu-devel] [PATCH 12/13] Revert to a hand-made select loop

2011-10-11 Thread Paolo Bonzini
This reverts commit c82dc29a9112f34e0a51cad9a412cf6d9d05dfb2 and 4d88a2ac8643265108ef1fb47ceee5d7b28e19f2. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- iohandler.c | 54 +- 1 files changed, 1 insertions(+), 53 deletions(-) diff --git

[Qemu-devel] [PATCH 04/36] migration: return real error code

2011-10-11 Thread Juan Quintela
make functions propagate errno, instead of just using -EIO. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |6 +- savevm.c| 33 +++-- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/migration.c b/migration.c index

  1   2   >