Re: [Qemu-devel] [PATCH] qom: fix refcounting in object_property_del_child()

2012-05-11 Thread Paolo Bonzini
Il 11/05/2012 04:15, Amos Kong ha scritto: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. object_ref() is called in object_property_add_child(), but we don't unref it in object_property_del_child(). | (qemu)

Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address

2012-05-11 Thread Amos Kong
On 05/11/2012 02:12 AM, Michael Roth wrote: On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote: On 05/10/2012 10:27 AM, Amos Kong wrote: Those patches updated help functions in qemu-socket.c, and used them in migrate-tcp.c to supporting IPv6 migration. --- Amos Kong (4):

Re: [Qemu-devel] [PATCH next v2 37/74] arm_boot: Pass ARMCPU to do_cpu_reset()

2012-05-11 Thread Peter Maydell
On 10 May 2012 23:40, Andreas Färber afaer...@suse.de wrote: Am 10.05.2012 23:41, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Allows us to use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de ---  hw/arm_boot.c

[Qemu-devel] [PATCH] qemu/xendisk: set maximum number of grants to be used

2012-05-11 Thread Jan Beulich
Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit. Signed-off-by: Jan Beulich jbeul...@suse.com --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -536,6 +536,10 @@ static void

[Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature

2012-05-11 Thread Michael S. Tsirkin
Whitelist kvm pv eoi feature. The feature is enabled with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Sending a copy to kernel list as this is needed to test the pv eoi feature recently submitted. target-i386/cpuid.c |2 +- 1 files

[Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Alexey Kardashevskiy
Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability may already exist and adding new capability into the beginning of the linked list may create a loop. For

[Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Alexey Kardashevskiy
Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability may already exist and adding new capability into the beginning of the linked list may create a loop. For

Re: [Qemu-devel] [PATCH v2 03/10] xhci: Fix reset of MSI function

2012-05-11 Thread Gerd Hoffmann
On 05/10/12 22:08, Jan Kiszka wrote: Call msi_reset on device reset as still required by the core. Note: msi on xhci is disabled by default (and also broken as far I know). +static void xhci_reset(void *opaque) +{ +XHCIState *xhci = opaque; + if (xhci-msi) +

Re: [Qemu-devel] [SeaBIOS] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables

2012-05-11 Thread Gleb Natapov
On Fri, May 11, 2012 at 01:46:17AM +0800, Jiang Liu wrote: On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote: On 05/09/2012 03:24 PM, Amos Kong wrote: --- src/ssdt-pcihp.dsl | 17 src/ssdt-pcihp.hex | 8869

[Qemu-devel] [PATCH 0/1] ISCSI: Only set read-event if we have i/o in flight

2012-05-11 Thread Ronnie Sahlberg
List, Kevin Please find a small patch to the iscsi driver to only set the fd handler for read events IF we have i/o in flight and we are thus waiting for replies coming back from the target. There are situations where qemu_aio_set_fd_handler(fd, read_callback, ... will invoke the

[Qemu-devel] [PATCH] ISCSI: Only set up the read-event if we are actually waiting for data to come back in from the target.

2012-05-11 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d37c4ee..989b5e9 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -105,7 +105,9 @@ iscsi_set_events(IscsiLun

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Alexander Graf
On 11.05.2012, at 08:45, Alexey Kardashevskiy wrote: Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability may already exist and adding new capability

Re: [Qemu-devel] [PATCH for-1.1] target-mips: Remove commented-out function declaration

2012-05-11 Thread Andreas Färber
Am 06.05.2012 10:30, schrieb Stefan Weil: Am 05.05.2012 13:40, schrieb Andreas Färber: There is no function cpu_mips_get_clock(), so drop it. Signed-off-by: Andreas Färberafaer...@suse.de Cc: Stefan Weils...@weilnetz.de --- target-mips/cpu.h |1 - 1 files changed, 0 insertions(+), 1

Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and store ARMCPU

2012-05-11 Thread Peter Maydell
On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Also use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de The pxa2xx stuff is probably going to clash with the cp15 rework, but I guess we'll sort that out when one or the other of these

Re: [Qemu-devel] [PATCH next v2 35/74] armv7m: Use cpu_arm_init() to obtain ARMCPU

2012-05-11 Thread Peter Maydell
On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Needed for armv7m_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Peter Maydell peter.mayd...@linaro.org I'd have preferred it if you hadn't made the style change from if (!foo) to if (foo == NULL), incidentally,

Re: [Qemu-devel] [PATCH next v2 36/74] armv7m: Pass ARMCPU to armv7m_reset()

2012-05-11 Thread Peter Maydell
On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Allows us to use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-11 Thread Peter Maydell
On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber afaer...@suse.de ---  linux-user/main.c    |    2 +-  linux-user/syscall.c |    2 +-  2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and store ARMCPU

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:16, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Also use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de The pxa2xx stuff is probably going to clash with the cp15 rework, but I guess we'll

Re: [Qemu-devel] [PATCH next v2 01/74] target-arm: Use cpu_reset() in cpu_arm_init()

2012-05-11 Thread Peter Maydell
On 10 May 2012 01:13, Andreas Färber afaer...@suse.de wrote: Commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a (target-arm: Move reset handling to arm_cpu_reset) QOM'ified CPU reset. Complete it by replacing cpu_state_reset() with cpu_reset(). Signed-off-by: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber afaer...@suse.de --- linux-user/main.c|2 +- linux-user/syscall.c |2 +- 2 files changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH] ISCSI: Only set up the read-event if we are actually waiting for data to come back in from the target.

2012-05-11 Thread Paolo Bonzini
Il 11/05/2012 12:22, Ronnie Sahlberg ha scritto: Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d37c4ee..989b5e9 100644 --- a/block/iscsi.c +++

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-11 Thread Alexander Graf
On 11.05.2012, at 13:26, Andreas Färber wrote: Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber afaer...@suse.de --- linux-user/main.c|2 +-

Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-05-11 Thread Paolo Bonzini
Il 10/05/2012 22:58, Jan Kiszka ha scritto: Otherwise, non-string properties without a legacy counterpart are missed. Also fix error propagation in object_property_print itself, otherwise pointer properties are printed as null. Signed-off-by: Paolo Bonzinipbonz...@redhat.com

Re: [Qemu-devel] [PATCH next v2 64/74] mips_jazz: Use cpu_mips_init() to obtain MIPSCPU

2012-05-11 Thread Andreas Färber
Am 10.05.2012 02:14, schrieb Andreas Färber: Needed for main_cpu_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Got to forget something: Acked-by: Hervé Poussineau hpous...@reactos.org Depends on the target-mips patch though, so need a review of that from someone first. Andreas

Re: [Qemu-devel] [PATCH next v2 65/74] mips_jazz: Pass MIPSCPU to main_cpu_reset()

2012-05-11 Thread Andreas Färber
Am 10.05.2012 02:14, schrieb Andreas Färber: Allows us to use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Forgot: Acked-by: Hervé Poussineau hpous...@reactos.org /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-11 Thread Peter Maydell
On 11 May 2012 12:28, Alexander Graf ag...@suse.de wrote: On 11.05.2012, at 13:26, Andreas Färber wrote: Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:28, schrieb Alexander Graf: On 11.05.2012, at 13:26, Andreas Färber wrote: Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 20d2a74..539af3f 100644 ---

Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:28, schrieb Paolo Bonzini: Il 10/05/2012 22:58, Jan Kiszka ha scritto: Otherwise, non-string properties without a legacy counterpart are missed. Also fix error propagation in object_property_print itself, otherwise pointer properties are printed as null. Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH for-1.1] target-i386: Defer MCE init

2012-05-11 Thread Andreas Färber
Am 10.05.2012 21:14, schrieb Igor Mammedov: - Original Message - From: Andreas Färber afaer...@suse.de To: qemu-devel@nongnu.org Cc: Eduardo Habkost ehabk...@redhat.com, Michael Roth mdr...@linux.vnet.ibm.com, Anthony Liguori anth...@codemonkey.ws, Paolo Bonzini pbonz...@redhat.com,

Re: [Qemu-devel] [PATCH next v2 01/74] target-arm: Use cpu_reset() in cpu_arm_init()

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:24, schrieb Peter Maydell: On 10 May 2012 01:13, Andreas Färber afaer...@suse.de wrote: Commit 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a (target-arm: Move reset handling to arm_cpu_reset) QOM'ified CPU reset. Complete it by replacing cpu_state_reset() with cpu_reset().

Re: [Qemu-devel] [PATCH] ISCSI: Only set up the read-event if we are actually waiting for data to come back in from the target.

2012-05-11 Thread ronnie sahlberg
On Fri, May 11, 2012 at 9:27 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/05/2012 12:22, Ronnie Sahlberg ha scritto: Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com ---  block/iscsi.c |    4 +++-  1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/iscsi.c

Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and store ARMCPU

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:16, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Also use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de The pxa2xx stuff is probably going to clash with the cp15 rework, but I guess we'll

Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address

2012-05-11 Thread Eric Blake
[adding libvirt] On 05/11/2012 12:46 AM, Amos Kong wrote: On 05/11/2012 02:12 AM, Michael Roth wrote: On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote: On 05/10/2012 10:27 AM, Amos Kong wrote: Those patches updated help functions in qemu-socket.c, and used them in migrate-tcp.c to

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Alexey Kardashevskiy
11.05.2012 20:52, Alexander Graf написал: On 11.05.2012, at 08:45, Alexey Kardashevskiy wrote: Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is being built by QEMU. In the case of VFIO the capability

Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature

2012-05-11 Thread Eric Blake
[adding libvirt, dropping kernel] On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote: Whitelist kvm pv eoi feature. The feature is enabled with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Sending a copy to kernel list as this is needed

Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s

2012-05-11 Thread Andreas Färber
Am 10.05.2012 23:38, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Fix tab indentations of comments, add braces, use cpu_reset(). Signed-off-by: Andreas Färber afaer...@suse.de --- hw/nseries.c |6 +++--- hw/omap.h |2 +- hw/omap1.c|

Re: [Qemu-devel] [PATCH v2 03/10] xhci: Fix reset of MSI function

2012-05-11 Thread Jan Kiszka
On 2012-05-11 05:16, Gerd Hoffmann wrote: On 05/10/12 22:08, Jan Kiszka wrote: Call msi_reset on device reset as still required by the core. Note: msi on xhci is disabled by default (and also broken as far I know). OK, then we can likely skip this patch for 1.1/stable. +static void

Re: [Qemu-devel] [PATCH v2 03/10] xhci: Fix reset of MSI function

2012-05-11 Thread Gerd Hoffmann
Hi, And can't we let the pci core handle it so we don't need ugly wrappers like this? That's what patches later in the series do. But Michael was preferring this approach for 1.1 and the cleanup for 1.2. Ah, ok, good. Yea, lets leave it alone for 1.1 and fix it properly in 1.2 cheers,

Re: [Qemu-devel] [PATCH next v2 35/74] armv7m: Use cpu_arm_init() to obtain ARMCPU

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:18, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Needed for armv7m_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Peter Maydell peter.mayd...@linaro.org Thanks, applied to qom-next:

Re: [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-11 Thread Eduardo Habkost
I just noticed it didn't get into -rc1 either. So, this is definitely not going to be in qemu-1.1, I guess? On Wed, May 02, 2012 at 01:07:24PM -0300, Eduardo Habkost wrote: Changes v2 - v3: - Actually change 'defconfig' type declaration to bool - Rebase against latest qemu.git (commit

Re: [Qemu-devel] [PATCH next v2 36/74] armv7m: Pass ARMCPU to armv7m_reset()

2012-05-11 Thread Andreas Färber
Am 11.05.2012 13:19, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Allows us to use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Peter Maydell peter.mayd...@linaro.org Thanks, applied to qom-next:

Re: [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-11 Thread Anthony Liguori
On 05/11/2012 08:34 AM, Eduardo Habkost wrote: I just noticed it didn't get into -rc1 either. So, this is definitely not going to be in qemu-1.1, I guess? I've got this applied and am testing it right now for -rc2. Regards, Anthony Liguori On Wed, May 02, 2012 at 01:07:24PM -0300,

Re: [Qemu-devel] [PATCH next v2 37/74] arm_boot: Pass ARMCPU to do_cpu_reset()

2012-05-11 Thread Andreas Färber
Am 11.05.2012 09:17, schrieb Peter Maydell: On 10 May 2012 23:40, Andreas Färber afaer...@suse.de wrote: Am 10.05.2012 23:41, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber afaer...@suse.de wrote: Allows us to use cpu_reset() in place of cpu_state_reset(). Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-11 Thread Eduardo Habkost
On Fri, May 11, 2012 at 08:37:33AM -0500, Anthony Liguori wrote: On 05/11/2012 08:34 AM, Eduardo Habkost wrote: I just noticed it didn't get into -rc1 either. So, this is definitely not going to be in qemu-1.1, I guess? I've got this applied and am testing it right now for -rc2. Awesome.

Re: [Qemu-devel] [PATCH qemu v3 0/6] -no-user-config option, move CPU models to /usr/share

2012-05-11 Thread Jiri Denemark
On Fri, May 11, 2012 at 08:37:33 -0500, Anthony Liguori wrote: On 05/11/2012 08:34 AM, Eduardo Habkost wrote: I just noticed it didn't get into -rc1 either. So, this is definitely not going to be in qemu-1.1, I guess? I've got this applied and am testing it right now for -rc2. Oh,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2012-05-11 Thread Alexander Graf
On 06.11.2011, at 14:54, Jan Kiszka wrote: On 2011-08-24 23:38, Alexander Graf wrote: On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool would be doing and what he expects from it. Basically he wants a small and simple tool he and other developers can run to try out and see

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-11 Thread Jiang Liu
On 05/11/2012 08:24 AM, Amos Kong wrote: On 05/11/2012 07:54 AM, Amos Kong wrote: On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c

Re: [Qemu-devel] [PATCH 07/21] qdev: fix -device foo,?

2012-05-11 Thread Andreas Färber
Am 02.05.2012 13:30, schrieb Paolo Bonzini: Since most property types do not have a parse property now, this was broken. Fix it by looking at the setter instead. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Acked-by: Andreas Färber

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2012-05-11 Thread Jan Kiszka
On 2012-05-11 10:42, Alexander Graf wrote: On 06.11.2011, at 14:54, Jan Kiszka wrote: On 2011-08-24 23:38, Alexander Graf wrote: On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool would be doing and what he expects from it. Basically he wants a small and simple tool he

Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-05-11 Thread Andreas Färber
Am 03.04.2012 15:05, schrieb Paolo Bonzini: Il 03/04/2012 14:28, Jan Kiszka ha scritto: if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { value = object_property_get_str(OBJECT(dev), legacy_name, err); This is not a criticism on this patch, but I'd like to

Re: [Qemu-devel] [RFC PATCH] qemu pci: pci_add_capability enhancement to prevent damaging config space

2012-05-11 Thread Alexander Graf
On 11.05.2012, at 14:47, Alexey Kardashevskiy wrote: 11.05.2012 20:52, Alexander Graf написал: On 11.05.2012, at 08:45, Alexey Kardashevskiy wrote: Normally the pci_add_capability is called on devices to add new capability. This is ok for emulated devices which capabilities list is

Re: [Qemu-devel] [Xen-devel] [PATCH] qemu/xendisk: set maximum number of grants to be used

2012-05-11 Thread Jan Beulich
On 11.05.12 at 09:19, Jan Beulich jbeul...@suse.com wrote: Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit. Signed-off-by: Jan Beulich jbeul...@suse.com ---

Re: [Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree

2012-05-11 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: Otherwise, non-string properties without a legacy counterpart are missed. Also fix error propagation in object_property_print itself. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev-monitor.c |2 +- qom/object.c |2 +-

[Qemu-devel] [PATCH] qcow2: Don't ignore failure to clear autoclear flags

2012-05-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3bae2d8..655799c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -300,7 +300,10 @@ static int qcow2_open(BlockDriverState

[Qemu-devel] [PATCH] xhci: Clean up reset function

2012-05-11 Thread Jan Kiszka
Properly register reset function via the device class. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Broken out from the MSI series where I will no longer touch xhci. hw/usb/hcd-xhci.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c

[Qemu-devel] [PATCH v3 0/8] msi: Refactorings and reset fixes

2012-05-11 Thread Jan Kiszka
v3 is v2 - xhci changes as MSI is instable there anyway. So, only patches 1 and 2 are for 1.1/stable now. CC: Alexander Graf ag...@suse.de CC: Gerd Hoffmann kra...@redhat.com CC: Isaku Yamahata yamah...@valinux.co.jp CC: qemu-sta...@nongnu.org Jan Kiszka (8): ahci: Fix reset of MSI function

[Qemu-devel] [PATCH v3 2/8] intel-hda: Fix reset of MSI function

2012-05-11 Thread Jan Kiszka
Call msi_reset on device reset as still required by the core. CC: Gerd Hoffmann kra...@redhat.com CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/intel-hda.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/intel-hda.c

[Qemu-devel] [PATCH v3 8/8] msi: Use msi/msix_present more consistently

2012-05-11 Thread Jan Kiszka
Replace some open-coded msi/msix_present checks. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/msi.c |2 +- hw/msix.c | 13 - 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 556c7c4..5233204 100644 --- a/hw/msi.c +++

Re: [Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree

2012-05-11 Thread Paolo Bonzini
Il 11/05/2012 16:20, Andreas Färber ha scritto: char *string = NULL; mo = string_output_visitor_new(); -object_property_get(obj, string_output_get_visitor(mo), name, NULL); +object_property_get(obj, string_output_get_visitor(mo), name, errp); If we do error checking we

Re: [Qemu-devel] [PATCH] qom: fix refcounting in object_property_del_child()

2012-05-11 Thread Amos Kong
On 05/11/2012 02:42 PM, Paolo Bonzini wrote: Il 11/05/2012 04:15, Amos Kong ha scritto: Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. object_ref() is called in object_property_add_child(), but we don't unref it in

[Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-11 Thread Amos Kong
The whole PCI slot should be removed once. Currently only one func is cleaned in pci_unplug_device(), if you try to remove a single func by monitor cmd. Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del

Re: [Qemu-devel] [PATCH] xhci: Clean up reset function

2012-05-11 Thread Gerd Hoffmann
On 05/11/12 16:36, Jan Kiszka wrote: Properly register reset function via the device class. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 02/24] qom: add object_child_foreach

2012-05-11 Thread Andreas Färber
Am 12.04.2012 18:03, schrieb Andreas Färber: Am 11.04.2012 23:30, schrieb Paolo Bonzini: A utility function that will be used to implement hierarchical realization. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- include/qemu/object.h

Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt

2012-05-11 Thread Gerd Hoffmann
On 05/08/12 14:06, Gerd Hoffmann wrote: Most important here is to update our internal endpoint state so we know the endpoint isn't in halted state any more. Without this usb-host tries to clear halt again with the next data transfer submitted. Doing this twice is (a) not correct and (b)

[Qemu-devel] [PATCH v3 5/8] msi: Invoke msi/msix_reset from PCI core

2012-05-11 Thread Jan Kiszka
There is no point in pushing this burden to the devices, they may rather forget to call them (like intel-hda, ahci, xhci did). Instead, reset functions are now called from pci_device_reset and pci_bridge_reset. They do nothing if MSI/MSI-X is not in use. CC: Alexander Graf ag...@suse.de CC: Gerd

Re: [Qemu-devel] [PATCH v5 0/7] add fixed-width visitors and serialization tests/fixes

2012-05-11 Thread Michael Roth
On Fri, May 11, 2012 at 03:22:15AM +0200, Andreas Färber wrote: Am 27.04.2012 22:21, schrieb Michael Roth: These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v5 Some of these were being carried as part of

[Qemu-devel] [RFC PATCH 0/2] Split fdd devices off the floppy controller

2012-05-11 Thread Markus Armbruster
This is probaly more about QOM than about floppy. It's not a working solution, yet. I'm posting it to give us something concrete to discuss. Based on Kevin's block branch, commit ad431215. Markus Armbruster (2): Un-inline fdctrl_init_isa() Split fdd devices off the floppy controller

[Qemu-devel] [RFC PATCH 1/2] Un-inline fdctrl_init_isa()

2012-05-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/fdc.c | 20 hw/fdc.h | 24 ++-- hw/ide/piix.c |3 ++- hw/isa.h |2 -- hw/pc_sysfw.c |1 + qemu-common.h |1 + 6 files changed, 26 insertions(+), 25 deletions(-)

[Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-11 Thread Markus Armbruster
For historical reasons, and unlike other block devices, our floppy devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller and the drive(s) in a single qdev. This makes them weird: we need -global to set up floppy drives, unlike every other optional device. This patch explores

Re: [Qemu-devel] [RFC PATCH 0/2] Split fdd devices off the floppy controller

2012-05-11 Thread Markus Armbruster
Forgot to cc: Paolo and Mike, apologies!

[Qemu-devel] [PATCH v3 3/8] ahci: Clean up reset functions

2012-05-11 Thread Jan Kiszka
Properly register reset functions via the device class. CC: Alexander Graf ag...@suse.de Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/ide/ahci.c | 25 +++-- hw/ide/ahci.h |2 +- hw/ide/ich.c | 10 -- 3 files changed, 20 insertions(+), 17

[Qemu-devel] [PATCH v3 6/8] msi: Guard msi/msix_write_config with msi_present

2012-05-11 Thread Jan Kiszka
Terminate msi/msix_write_config early if support is not enabled. This allows to remove checks at the caller site if MSI is optional. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/msi.c |3 ++- hw/msix.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 1/8] ahci: Fix reset of MSI function

2012-05-11 Thread Jan Kiszka
Call msi_reset on device reset as still required by the core. CC: Alexander Graf ag...@suse.de CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/ide/ich.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/ide/ich.c

[Qemu-devel] [PATCH v3 4/8] msi: Guard msi_reset with msi_present

2012-05-11 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/msi.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 5d6ceb6..b2903fc 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -191,6 +191,10 @@ void msi_reset(PCIDevice *dev) uint16_t flags;

[Qemu-devel] [PATCH v3 7/8] msi: Invoke msi/msix_write_config from PCI core

2012-05-11 Thread Jan Kiszka
Also this functions is better invoked by the core than by each and every device. This allows to drop the config_write callbacks from ich and intel-hda. CC: Alexander Graf ag...@suse.de CC: Gerd Hoffmann kra...@redhat.com CC: Isaku Yamahata yamah...@valinux.co.jp Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [SeaBIOS] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables

2012-05-11 Thread Jiang Liu
On 05/11/2012 06:14 PM, Gleb Natapov wrote: I'm not familiar with qemu:( On native OS, admin could trigger PCI device hotplug operations through /sys/bus/pci/slot/xx/power. Not sure whether that's needed for guest OS too. Why is it needed on physical HW? May be it is needed in a VM for the

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-11 Thread Peter Maydell
On 7 May 2012 12:38, Alexander Graf ag...@suse.de wrote: On 07.05.2012, at 13:32, Alexander Graf wrote: On 07.05.2012, at 12:37, Peter Maydell wrote: On 7 May 2012 10:30, Alexander Graf ag...@suse.de wrote: @@ -587,6 +587,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int

[Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2012-05-11 Thread Alexander Graf
On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool would be doing and what he expects from it. Basically he wants a small and simple tool he and other developers can run to try out and see if the kernel they just built actually works. Fortunately, QEMU can do that today already!

Re: [Qemu-devel] qemu/xendisk: properly update stats in ioreq_release()

2012-05-11 Thread Stefano Stabellini
On Thu, 10 May 2012, Jan Beulich wrote: While for the normal case (called from blk_send_response_all()) decrementing requests_finished is correct, doing so in the parse error case is wrong; requests_inflight needs to be decremented instead. Signed-off-by: Jan Beulich jbeul...@suse.com ---

[Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-11 Thread Alexander Graf
If we execute linux-user code that does the following: * A = mmap() * execute code in A * munmap(A) * B = mmap(), but mmap returns the same address as A * execute code in B we end up executing a stale cached tb that contains translated code from A, while we want new code from B. This

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-11 Thread Alexander Graf
On 11.05.2012, at 17:46, Peter Maydell wrote: On 7 May 2012 12:38, Alexander Graf ag...@suse.de wrote: On 07.05.2012, at 13:32, Alexander Graf wrote: On 07.05.2012, at 12:37, Peter Maydell wrote: On 7 May 2012 10:30, Alexander Graf ag...@suse.de wrote: @@ -587,6 +587,7 @@ abi_long

Re: [Qemu-devel] [PATCH 2/7] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Luiz Capitulino
On Fri, 27 Apr 2012 15:21:18 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to

Re: [Qemu-devel] [PATCH v3 4/8] pc: Enable MSI support at APIC level

2012-05-11 Thread Stefano Stabellini
On Thu, 10 May 2012, Jan Kiszka wrote: Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. CC: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH] linux-user: Fix stale tbs after mmap

2012-05-11 Thread Peter Maydell
On 11 May 2012 09:40, Alexander Graf ag...@suse.de wrote: If we execute linux-user code that does the following:  * A = mmap()  * execute code in A  * munmap(A)  * B = mmap(), but mmap returns the same address as A  * execute code in B we end up executing a stale cached tb that contains

Re: [Qemu-devel] [PATCH next v2 41/74] target-lm32: Let cpu_lm32_init() return LM32CPU

2012-05-11 Thread Michael Walle
Make the include paths for cpu-qom.h consistent to allow using LM32CPU in cpu.h. Turn cpu_init macro into a static inline function returning CPULM32State for backwards compatibility. Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Michael Walle mich...@walle.cc -- Michael

Re: [Qemu-devel] [PATCH 4/7] qapi: String visitor, use %f represenation for floats

2012-05-11 Thread Luiz Capitulino
On Fri, 27 Apr 2012 15:21:20 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it 6 uses significant figures instead of 6 decimal

Re: [Qemu-devel] [PATCH 2/7] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Michael Roth
On Fri, May 11, 2012 at 01:22:33PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:18 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor

Re: [Qemu-devel] [Xen-devel] [PATCH] qemu/xendisk: set maximum number of grants to be used

2012-05-11 Thread Stefano Stabellini
On Fri, 11 May 2012, Jan Beulich wrote: On 11.05.12 at 09:19, Jan Beulich jbeul...@suse.com wrote: Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit. Signed-off-by:

Re: [Qemu-devel] [PATCH 2/7] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Andreas Färber
Am 11.05.2012 19:04, schrieb Michael Roth: On Fri, May 11, 2012 at 01:22:33PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:18 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: JSON numbers can be interpreted as either integers or floating point values depending on their

Re: [Qemu-devel] [PATCH 4/7] qapi: String visitor, use %f represenation for floats

2012-05-11 Thread Michael Roth
On Fri, May 11, 2012 at 01:34:01PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:20 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes

Re: [Qemu-devel] [PATCH 2/7] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Michael Roth
On Fri, May 11, 2012 at 07:16:18PM +0200, Andreas Färber wrote: Am 11.05.2012 19:04, schrieb Michael Roth: On Fri, May 11, 2012 at 01:22:33PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:18 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: JSON numbers can be interpreted as

[Qemu-devel] [PATCH 1.1] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH 4/7] qapi: String visitor, use %f represenation for floats

2012-05-11 Thread Andreas Färber
Am 11.05.2012 19:32, schrieb Michael Roth: On Fri, May 11, 2012 at 01:34:01PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:20 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are

Re: [Qemu-devel] [PATCH 1.1] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Andreas Färber
Am 11.05.2012 19:43, schrieb Michael Roth: JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by:

Re: [Qemu-devel] [SeaBIOS] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables

2012-05-11 Thread Gleb Natapov
On Fri, May 11, 2012 at 11:44:02PM +0800, Jiang Liu wrote: On 05/11/2012 06:14 PM, Gleb Natapov wrote: I'm not familiar with qemu:( On native OS, admin could trigger PCI device hotplug operations through /sys/bus/pci/slot/xx/power. Not sure whether that's needed for guest OS too.

[Qemu-devel] [PATCH 3/3] qcow2: Support for fixing refcount inconsistencies

2012-05-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-refcount.c | 27 +-- block/qcow2.c |6 +- block/qcow2.h |3 ++- 3 files changed, 28 insertions(+), 8 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index

Re: [Qemu-devel] [PATCH 2/7] qapi: QMP input visitor, handle floats parsed as ints

2012-05-11 Thread Luiz Capitulino
On Fri, 11 May 2012 12:04:47 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Fri, May 11, 2012 at 01:22:33PM -0300, Luiz Capitulino wrote: On Fri, 27 Apr 2012 15:21:18 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: JSON numbers can be interpreted as either integers or

Re: [Qemu-devel] PCI: Hot-removing a virtio-blk causes guest panic

2012-05-11 Thread Michael S. Tsirkin
On Fri, May 11, 2012 at 12:37:49PM +0800, Amos Kong wrote: good: 3.3.0 guest kernel qemu-kvm-rhel6 guest panic: 3.3.0 guest kernel qemu-upstream (contains fix [1]) I didn't change anything of guest kernel, It seems a bug of qemu-upstream. [1]

[Qemu-devel] [PATCH 1/3] qemu-img check -r for repairing images

2012-05-11 Thread Kevin Wolf
The QED block driver already provides the functionality to not only detect inconsistencies in images, but also fix them. However, this functionality cannot be manually invoked with qemu-img, but the check happens only automatically during bdrv_open(). This adds a -r switch to qemu-img check that

[Qemu-devel] [PATCH block-next 0/3] qemu-img check/qcow2: Allow fixing refcounts

2012-05-11 Thread Kevin Wolf
A prerequisite for a QED mode in qcow2, which doesn't update the refcount table except on clean shutdown, is that refcounts can be repaired when the image is opened the next time after a crash. This series adds a qemu-img check option that doesn't only check, but also tries to fix the errors that

  1   2   >