Re: [Qemu-devel] [PATCH 2/2 v2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-09-07 Thread Michael S. Tsirkin
On Tue, Sep 04, 2012 at 04:22:46PM -0400, Jason Baron wrote: On Fri, Aug 31, 2012 at 11:43:31AM -0400, Jason Baron wrote: On Fri, Aug 31, 2012 at 06:35:13PM +0300, Michael S. Tsirkin wrote: On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: On Fri, Aug 31, 2012 at 11:42:27AM

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 to support the upstream tcm_vhost host virtualized target driver now available in v3.6-rc

Re: [Qemu-devel] [RFC-v3 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-09-07 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:09PM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The

[Qemu-devel] [PULL] pci minor tweaks

2012-09-07 Thread Michael S. Tsirkin
The following changes since commit 6e4c0d1f03d6ab407509c32fab7cb4b8230f57ff: hw/pl110: Fix spelling of 'palette' (2012-09-06 17:04:33 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 I rebased on top of 1.2 and put this in my tree:

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 I rebased on

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 09:32:37AM +0300, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, This is the

Re: [Qemu-devel] [PATCH] smbios: convert to use QemuOpts

2012-09-07 Thread Markus Armbruster
Hello, this is your friendly remote compile service. Anthony Liguori aligu...@us.ibm.com writes: Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- arch_init.c | 10 +- arch_init.h |2 +- hw/smbios.c | 53 +++--

[Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch:

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-07 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 09:37 +0300, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 09:32:37AM +0300, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: From: Nicholas

[Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch starts and stops vhost as the virtio device transitions through its status phases. Vhost can only be started once the guest reports its driver has successfully initialized, which means the virtqueues have been set up by the guest. v3:

[Qemu-devel] [PATCH 1/5] monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch renames+moves the net_handle_fd_param() caller used to obtain a file descriptor from either qemu_parse_fd() (the normal case) or from monitor_get_fd() (migration case) into a generically prefixed monitor_handle_fd_param() to be used by

[Qemu-devel] [PATCH 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-09-07 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The virtio-scsi emulated device will make use of vhost-scsi to process virtio-scsi

[Qemu-devel] [PATCH 2/5] vhost: Pass device path to vhost_dev_init()

2012-09-07 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The path to /dev/vhost-net is currently hardcoded in vhost_dev_init(). This needs to be changed so that /dev/vhost-scsi can be used. Pass in the device path instead of hardcoding it. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc:

[Qemu-devel] [PATCH 5/5] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-09-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This QEMU patch sets VirtIOSCSIConfig-max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 01:15, Scott Wood scottw...@freescale.com wrote: On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 15, 2012 6:59 AM To: Bhushan Bharat-R65777 Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org;

[Qemu-devel] [PATCH 1/3] set the readonly property of rom memory region in pc

2012-09-07 Thread Liu Sheng
make sure the memory regions of rom in pc have readonly property, prepare for plug these memory to kvm as readonly memory slots. Signed-off-by: Liu Sheng liush...@linux.vnet.ibm.com --- hw/pc.c |1 + hw/pci.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c

[Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel

2012-09-07 Thread Liu Sheng
updated the head file from kernel for readonly memory feature. Signed-off-by: Liu Sheng liush...@linux.vnet.ibm.com --- linux-headers/asm-x86/kvm.h |1 + linux-headers/linux/kvm.h | 16 +--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 0/3] support kvm readonly memory slot in qemu

2012-09-07 Thread Liu Sheng
This patch set make the readonly memory in qemu really readonly, using readonly memory slots feature in kvm, to make qemu-kvm safer. Memory regions with readonly property would be plug into kvm as readonly memory slots. This patch set depends on the last patch Introduce write_readonly_mem in

[Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu

2012-09-07 Thread Liu Sheng
as readonly memory is support in kvm, this patch supports this feature in qemu, mainly pluging the memory region with KVM_MEM_READONLY flag to kvm. this can be tested by a kernel module from the author of kvm readonly memory slot: static int rom_tester_probe(struct pci_dev *dev, const struct

Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-07 Thread Markus Armbruster
Some overlap with what I'm working on, but since you have code to show, and I don't, I'll review yours as if mine didn't exist. Dong Xu Wang wdon...@linux.vnet.ibm.com writes: QEMU now has QEMUOptionParameter and QemuOpts to parse parameters, so we can remove one safely. This RFC removed

Re: [Qemu-devel] [PATCH] target-cris: Fix buffer overflow

2012-09-07 Thread Edgar E. Iglesias
On Tue, Sep 04, 2012 at 07:45:52AM +0200, Stefan Weil wrote: Report from smatch: target-cris/translate.c:3464 cpu_dump_state(32) error: buffer overflow 'env-sregs' 4 = 255 sregs is declared 'uint32_t sregs[4][16]', so the first index must be less than 4. Hi Stefan, I think it would be

Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel

2012-09-07 Thread Jan Kiszka
On 2012-09-07 10:26, Liu Sheng wrote: updated the head file from kernel for readonly memory feature. Signed-off-by: Liu Sheng liush...@linux.vnet.ibm.com --- linux-headers/asm-x86/kvm.h |1 + linux-headers/linux/kvm.h | 16 +--- 2 files changed, 14 insertions(+), 3

Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu

2012-09-07 Thread Jan Kiszka
On 2012-09-07 10:26, Liu Sheng wrote: as readonly memory is support in kvm, this patch supports this feature in qemu, mainly pluging the memory region with KVM_MEM_READONLY flag to kvm. this can be tested by a kernel module from the author of kvm readonly memory slot: static int

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2012 at 08:54:02AM +0530, Bharata B Rao wrote: On Thu, Sep 06, 2012 at 04:47:17PM +0100, Daniel P. Berrange wrote: IMHO this is all gross. URIs already have a well defined way to provide multiple parameters, dealing with escaping of special characters. ie query parameters.

Re: [Qemu-devel] [PATCH for-1.2 v2 0/5] target-ppc: MAINTAINERS additions

2012-09-07 Thread Edgar E. Iglesias
On Wed, Aug 29, 2012 at 05:51:09PM +0200, Andreas Färber wrote: Am 22.08.2012 17:48, schrieb Andreas Färber: Hi Alex, Here's an updated and squashed series adding some MAINTAINERS sections for ppc machines and their devices. Based on Peter's suggestion the machines are no longer

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 05:24, Bharata B Rao ha scritto: gluster:///volname/image?transport=unixsockpath=/path/to/unix/sock ^why 3 /// here ? volname is not a path, but image is. Because the host is the local computer, i.e. empty.

Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel

2012-09-07 Thread Xiao Guangrong
Hi Jan, Thanks for your review. On 09/07/2012 04:49 PM, Jan Kiszka wrote: +#ifdef __KVM_HAVE_READONLY_MEM +__u8 write_readonly_mem; +#endif } mmio; /* KVM_EXIT_HYPERCALL */ struct { @@ -618,6 +625,9 @@ struct kvm_ppc_smmu_info {

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Kevin Wolf
Am 07.09.2012 11:36, schrieb Paolo Bonzini: Il 07/09/2012 05:24, Bharata B Rao ha scritto: gluster:///volname/image?transport=unixsockpath=/path/to/unix/sock ^why 3 /// here ? volname is not a path, but image is. Because the host is the local computer, i.e. empty.

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Kevin Wolf
Am 06.09.2012 17:47, schrieb Daniel P. Berrange: On Thu, Sep 06, 2012 at 09:10:04PM +0530, Bharata B Rao wrote: On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote: On 08/14/2012 12:58 PM, Kevin Wolf wrote: While we are at this, let me bring out another issue. Gluster supports 3

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2012 at 12:00:50PM +0200, Kevin Wolf wrote: Am 06.09.2012 17:47, schrieb Daniel P. Berrange: On Thu, Sep 06, 2012 at 09:10:04PM +0530, Bharata B Rao wrote: On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote: On 08/14/2012 12:58 PM, Kevin Wolf wrote: While we are

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 12:03, Daniel P. Berrange ha scritto: I think doing it the other way round would be more logical: gluster+unix:///path/to/unix/sock?image=volname/image This way you have the socket first, which you also must open first. Having it as a parameter without which you can't

Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel

2012-09-07 Thread Jan Kiszka
On 2012-09-07 11:39, Xiao Guangrong wrote: Hi Jan, Thanks for your review. On 09/07/2012 04:49 PM, Jan Kiszka wrote: +#ifdef __KVM_HAVE_READONLY_MEM + __u8 write_readonly_mem; +#endif } mmio; /* KVM_EXIT_HYPERCALL */ struct { @@

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-07 Thread Kevin Wolf
Am 06.09.2012 16:59, schrieb Jeff Cody: On 09/06/2012 09:23 AM, Kevin Wolf wrote: Am 30.08.2012 20:47, schrieb Jeff Cody: Add bdrv_find_child(), and bdrv_delete_intermediate(). bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image chain, find the image

Re: [Qemu-devel] [PATCH 0/8] fdc: fix FD_SR0_SEEK flag + implement VERIFY

2012-09-07 Thread Kevin Wolf
Am 06.09.2012 21:17, schrieb Hervé Poussineau: Attached patches have 3 goals: - patches 1-4 fix the NT 3.1 floppy driver problem. - patches 5-6 implement the VERIFY command - patches 7-8 are some simple cleanup Any specific reason for resending and reordering my patches? They are already

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-07 Thread Kevin Wolf
Am 06.09.2012 17:34, schrieb Corey Bryant: On 09/06/2012 05:23 AM, Kevin Wolf wrote: Am 05.09.2012 18:43, schrieb Jeff Cody: +} + +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK; +#ifdef O_NOATIME +fcntl_flags |= O_NOATIME; +#endif +if ((raw_s-open_flags

Re: [Qemu-devel] [PATCH 7/8] tcg/optimize: add constant folding for setcond

2012-09-07 Thread Aurelien Jarno
On Thu, Sep 06, 2012 at 09:40:57AM -0700, Richard Henderson wrote: On 09/06/2012 08:00 AM, Aurelien Jarno wrote: Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 79 1 file changed, 79 insertions(+)

Re: [Qemu-devel] [PATCH 0/8] Improve TCG optimizer

2012-09-07 Thread Aurelien Jarno
On Thu, Sep 06, 2012 at 09:43:08AM -0700, Richard Henderson wrote: On 09/06/2012 08:00 AM, Aurelien Jarno wrote: This patch series improves the TCG optimizer, based on patterns found while executing various guest. The brcond ad setcond constant folding are useful especially useful when they

Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-07 Thread Kevin Wolf
Am 07.09.2012 10:42, schrieb Markus Armbruster: @@ -1628,51 +1625,6 @@ static int qcow2_load_vmstate(BlockDriverState *bs, uint8_t *buf, return ret; } -static QEMUOptionParameter qcow2_create_options[] = { -{ -.name = BLOCK_OPT_SIZE, -.type = OPT_SIZE, -

[Qemu-devel] [PULL for usb-next]: Add support for live-migration to usb-redir

2012-09-07 Thread Hans de Goede
Hi Gerd, I'm very happy to present to you a pull-request for usb-redir live-migration support. I've tested this combined with Spice seamless migration, and it can successful: 1) migrate a vm while running dd if=/dev/zero of=/dev/sdb1 bs=32K inside the guest with sdb being a redirect USB-2 mass

Re: [Qemu-devel] [PATCH 0/8] Improve TCG optimizer

2012-09-07 Thread Peter Maydell
On 6 September 2012 16:00, Aurelien Jarno aurel...@aurel32.net wrote: This patch series improves the TCG optimizer, based on patterns found while executing various guest. The brcond ad setcond constant folding are useful especially useful when they are used to avoid some argument values (e.g.

[Qemu-devel] qemu 1.2 : lsi controller + scsi-block don't boot.

2012-09-07 Thread Alexandre DERUMIER
Hi, I'm trying to boot scsi-block device with lsi controller, and it doesn't boot. (don't find devices). lsi + scsi-block : don't boot lsi + scsi-hd : boot virtio-scsi + scsi-block : boot Regards, Alexandre Derumier

Re: [Qemu-devel] [PATCH v2] ahci: properly reset PxCMD on HBA reset

2012-09-07 Thread Kevin Wolf
Am 05.09.2012 05:28, schrieb Alexander Graf: On 04.09.2012, at 16:08, Jason Baron wrote: While testing q35, I found that windows 7 (specifically, windows 7 ultimate with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. The failure message is: 'A required cd/dvd

Re: [Qemu-devel] [PATCH 0/8] Improve TCG optimizer

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 01:34:10PM +0100, Peter Maydell wrote: On 6 September 2012 16:00, Aurelien Jarno aurel...@aurel32.net wrote: This patch series improves the TCG optimizer, based on patterns found while executing various guest. The brcond ad setcond constant folding are useful

Re: [Qemu-devel] [PATCH] smbios: convert to use QemuOpts

2012-09-07 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Hello, this is your friendly remote compile service. dirty tree + git-send-email == FAIL Sorry for the noise. At any rate, I've abandoned this patch and picked up Paolo's tree. I'll post the full series this afternoon. I'm still playing around

Re: [Qemu-devel] [PATCH v3] block: output more error messages if failed to create temporary snapshot

2012-09-07 Thread Kevin Wolf
Am 05.09.2012 15:24, schrieb riegama...@gmail.com: From: Dunrong Huang riegama...@gmail.com If we failed to create temporary snapshot, the error message did not match with the error, for example: $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot

Re: [Qemu-devel] [PATCH V8 0/2] Add JSON output to qemu-img info

2012-09-07 Thread Kevin Wolf
Am 05.09.2012 13:09, schrieb Benoît Canet: This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the

[Qemu-devel] [PATCH v2 2/9] tcg/optimize: split expression simplification

2012-09-07 Thread Aurelien Jarno
Split expression simplification in multiple parts so that a given op can appear multiple times. This patch should not change anything. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 14 +- 1 file changed, 13

[Qemu-devel] [PATCH v2 9/9] tcg/optimize: fix if/else/break coding style

2012-09-07 Thread Aurelien Jarno
optimizer.c contains some cases were the break is appearing in both the if and the else parts. Fix that by moving it to the outer part. Also move some common code there. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 34 +++--- 1 file

[Qemu-devel] [PATCH v2 5/9] tcg/optimize: simplify shift/rot r, 0, a = movi r, 0 cases

2012-09-07 Thread Aurelien Jarno
shift/rot r, 0, a is equivalent to movi r, 0. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 20 1 file changed, 20 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index c12cb2b..1698ba3

[Qemu-devel] [PATCH v2 7/9] tcg/optimize: add constant folding for setcond

2012-09-07 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 81 1 file changed, 81 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7debc8a..1cb1f36 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -267,6

[Qemu-devel] [PATCH v2 4/9] tcg/optimize: simplify and r, a, 0 cases

2012-09-07 Thread Aurelien Jarno
and r, a, 0 is equivalent to a movi r, 0. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c |1 + 1 file changed, 1 insertion(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0db849e..c12cb2b 100644 ---

[Qemu-devel] [PATCH v2 8/9] tcg/optimize: add constant folding for brcond

2012-09-07 Thread Aurelien Jarno
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1cb1f36..156e8d9 100644 ---

[Qemu-devel] [PATCH v2 6/9] tcg/optimize: swap brcond/setcond arguments when possible

2012-09-07 Thread Aurelien Jarno
brcond and setcond ops are not commutative, but it's easy to compute the new condition after swapping the arguments. Try to always put the constant argument in second position like for commutative ops, to help backends to generate better code. Reviewed-by: Richard Henderson r...@twiddle.net

[Qemu-devel] [PATCH v2 0/9] Improve TCG optimizer

2012-09-07 Thread Aurelien Jarno
This patch series improves the TCG optimizer, based on patterns found while executing various guest. The brcond ad setcond constant folding are useful especially useful when they are used to avoid some argument values (e.g. division by 0), and thus can be optimized when this argument is a

[Qemu-devel] [PATCH v2 1/9] tcg: improve profiler

2012-09-07 Thread Aurelien Jarno
Now that there are two passes of optimization (optimize.c, liveness) there is no point of outputing the statistics of the liveness part only. Update the code to take into account both optimizations. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/tcg.c | 12 +++- tcg/tcg.h |

[Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists

2012-09-07 Thread Peter Maydell
Reject attempts to add a property to an object if one of that name already exists. This is always a bug in the caller; this is merely diagnosing it gracefully rather than behaving oddly later. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Changes v1-v2: * use abort() rather than

[Qemu-devel] [PATCH v2 3/9] tcg/optimize: simplify or/xor r, a, 0 cases

2012-09-07 Thread Aurelien Jarno
or/xor r, a, 0 is equivalent to a mov r, a. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- tcg/optimize.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 63f970d..0db849e 100644 ---

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-07 Thread Aurelien Jarno
On Wed, Sep 05, 2012 at 03:11:13PM +0200, Kevin Wolf wrote: Am 05.09.2012 14:56, schrieb Henning Schild: Find a hopefully proper patch attached. Take it or leave it. Signed-off-by: Henning Schild henn...@hennsch.de Reviewed-by: Kevin Wolf kw...@redhat.com Aurelien, I think in the

Re: [Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists

2012-09-07 Thread Andreas Färber
Am 07.09.2012 15:55, schrieb Peter Maydell: Reject attempts to add a property to an object if one of that name already exists. This is always a bug in the caller; this is merely diagnosing it gracefully rather than behaving oddly later. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-07 Thread Corey Bryant
On 09/07/2012 06:40 AM, Kevin Wolf wrote: Am 06.09.2012 17:34, schrieb Corey Bryant: On 09/06/2012 05:23 AM, Kevin Wolf wrote: Am 05.09.2012 18:43, schrieb Jeff Cody: +} + +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK; +#ifdef O_NOATIME +fcntl_flags |= O_NOATIME; +#endif

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-07 Thread Andreas Färber
Am 07.09.2012 06:26, schrieb Alexander Graf: Quoting Richard Henderson r...@twiddle.net: On 09/06/2012 11:42 AM, Alexander Graf wrote: Richard, while at it, could you please check the s390x tcg target? Running any target on there seems to break in the TLB code for me. I did successfully

[Qemu-devel] [Bug 1044727] Re: -kernel does not work for multiboot ELF kernels

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: New = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1044727 Title: -kernel does not work for multiboot ELF kernels Status in QEMU: Fix Committed

[Qemu-devel] [Bug 948675] Re: QEMU is crashing when called with -vga none

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/948675 Title: QEMU is crashing when called with -vga none Status in QEMU: Fix

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584121 Title: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv) Status in

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Edgar E. Iglesias
On Fri, Sep 07, 2012 at 04:18:41PM +0200, Aurelien Jarno wrote: On Sun, Sep 02, 2012 at 05:33:47PM +, Blue Swirl wrote: Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl blauwir...@gmail.com --- configure

Re: [Qemu-devel] [PATCH] configure: fix seccomp check

2012-09-07 Thread Andreas Färber
Am 06.09.2012 22:40, schrieb Yann E. MORIN: Currently, if libseccomp is missing but the user explicitly requested seccomp support using --enable-seccomp, configure silently ignores the situation and disables seccomp support. This is unlike all other tests that explicitly fail in such

[Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022331 Title: -cpu ? causes confusion when directory has 1-character length

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/musicpal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:30:51PM +0200, Andreas Färber wrote: Am 07.09.2012 06:26, schrieb Alexander Graf: Quoting Richard Henderson r...@twiddle.net: On 09/06/2012 11:42 AM, Alexander Graf wrote: Richard, while at it, could you please check the s390x tcg target? Running any target

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dumps core or exits Status in

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/962880 Title: having a tr_TR.UTF-8 locale creates problems during compile Status in

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:40:03PM +0200, Edgar E. Iglesias wrote: On Fri, Sep 07, 2012 at 04:18:41PM +0200, Aurelien Jarno wrote: On Sun, Sep 02, 2012 at 05:33:47PM +, Blue Swirl wrote: Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode.

Re: [Qemu-devel] qemu 1.2 : lsi controller + scsi-block don't boot.

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 14:35, Alexandre DERUMIER ha scritto: I'm trying to boot scsi-block device with lsi controller, and it doesn't boot. (don't find devices). lsi + scsi-block : don't boot lsi + scsi-hd : boot virtio-scsi + scsi-block : boot The LSI driver in SeaBIOS is really a best

Re: [Qemu-devel] qemu 1.2 : lsi controller + scsi-block don't boot.

2012-09-07 Thread Alexandre DERUMIER
Thanks, But Why does it work with lsi + scsi-hd and not scsi-block? For now I'll use scsi-hd for these (very old) guests, it's not a problem. - Mail original - De: Paolo Bonzini pbonz...@redhat.com À: Alexandre DERUMIER aderum...@odiso.com Cc: qemu-devel@nongnu.org Envoyé: Vendredi 7

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Jan Kiszka
On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka jan.kis...@web.de --- hw/musicpal.c |4 ++-- 1 files

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Aurelien Jarno
On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: The lan9118 emulation tries to compute the multicast index by calling directly the crc32() function from zlib, but fails to get the correct result. Use the common compute_mcast_idx() function instead, which gives the correct

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Peter Maydell
On 7 September 2012 15:56, Aurelien Jarno aurel...@aurel32.net wrote: On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: The lan9118 emulation tries to compute the multicast index by calling directly the crc32() function from zlib, but fails to get the correct result. Use the

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Bharata B Rao
On Thu, Sep 06, 2012 at 12:29:30PM +0200, Kevin Wolf wrote: Am 06.09.2012 12:18, schrieb Paolo Bonzini: Il 06/09/2012 12:07, Kevin Wolf ha scritto: The AIOCB is already invalid at the time the callback is entered, so we could release it before the call. However, not all implementation of

[Qemu-devel] [PATCH] pflash_cfi01: fix vendor specific extended query

2012-09-07 Thread Aurelien Jarno
pflash_cfi01 announces a version number of 1.1, which implies Protection Register Information and Burst Read information sections, which are not provided. Decrease the version number to 1.0 so that only the Protection Register Information section is needed. Set the number of protection fields

[Qemu-devel] [PATCH] target-sparc: fix fcmp{s, d, q} instructions wrt exception

2012-09-07 Thread Aurelien Jarno
fcmp{s,d,q} instructions are supposed to ignore quiet NaN (contrary to the fcmpe{s,d,q} instructions), but the current code is wrongly setting the NV exception in that case. Moreover the current code is duplicated: first the arguments are checked for NaN to generate an exception, and later in case

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-07 Thread Jeff Cody
On 09/07/2012 06:19 AM, Kevin Wolf wrote: Am 06.09.2012 16:59, schrieb Jeff Cody: On 09/06/2012 09:23 AM, Kevin Wolf wrote: Am 30.08.2012 20:47, schrieb Jeff Cody: Add bdrv_find_child(), and bdrv_delete_intermediate(). bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 15:53, Jan Kiszka jan.kis...@web.de wrote: On 2012-09-07 16:41, Peter Maydell wrote: On 7 September 2012 00:03, Jan Kiszka jan.kis...@web.de wrote: +pflash_cfi02_register(0x1-MP_FLASH_SIZE_MAX, NULL, I don't think this will compile on a 32 bit system, will

[Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The g3beige machine always add a video card, even when the -vga none is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- hw/ppc_oldworld.c |4 +++- 1 file changed, 3

[Qemu-devel] [PATCH 1/3] sun4u: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The sun4u machine always add a video card, even when -vga none is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- hw/sun4u.c |4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PATCH 3/3] mac99: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The mac99 machine always add a video card, even when the -vga none is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- hw/ppc_newworld.c |4 +++- 1 file changed, 3

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:04:16PM +0100, Peter Maydell wrote: On 7 September 2012 15:56, Aurelien Jarno aurel...@aurel32.net wrote: On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: The lan9118 emulation tries to compute the multicast index by calling directly the crc32()

[Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Paolo Bonzini
Il 27/08/2012 17:00, Paolo Bonzini ha scritto: The part where I need a second opinion and/or ack is patch 12 and 13. They fix the case of a disk being unplugged while NBD export is active. To do this I add a NotifierList to a BlockDriverState. Does this look okay, or is it too ad hoc?

Re: [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-09-07 Thread Jeff Cody
On 09/06/2012 05:16 PM, Eric Blake wrote: On 09/06/2012 02:37 PM, Jeff Cody wrote: On 09/06/2012 10:00 AM, Kevin Wolf wrote: Am 30.08.2012 20:47, schrieb Jeff Cody: This adds the live commit coroutine. This iteration focuses on the commit only below the active layer, and not the active layer

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org ---

[Qemu-devel] Linux KVM, Windows 7 guest choppy sound

2012-09-07 Thread Erik Lotspeich
Hi, I apologize if this isn't the right venue for this message, but this mailing list seems a bit more active than qemu-discuss. Background: I am running OpenSUSE 12.1. I fixed audio issues in VM guests by setting the following in qemu.conf: vnc_allow_host_audio = 1 I also set user= and group=

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Kevin Wolf
Am 07.09.2012 17:50, schrieb Paolo Bonzini: Il 27/08/2012 17:00, Paolo Bonzini ha scritto: The part where I need a second opinion and/or ack is patch 12 and 13. They fix the case of a disk being unplugged while NBD export is active. To do this I add a NotifierList to a BlockDriverState.

[Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Juan Quintela
Hi here is v2 of the migration thread series. There is still some issues with locking in the error paths (they are at 54 patches now). Changes from v1: - migration stats series are included - migration bitmap sync trace-events to know how long it takes - file-last_error use almost removed

Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-07 Thread Paolo Bonzini
Il 30/08/2012 20:47, Jeff Cody ha scritto: @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { [IF_SCSI] = 7, }; +static void block_job_cb(void *opaque, int ret); + /* * We automatically delete the drive when a device using it gets * unplugged. Questionable feature,

Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 18:23, Juan Quintela ha scritto: Hi here is v2 of the migration thread series. There is still some issues with locking in the error paths (they are at 54 patches now). Changes from v1: - migration stats series are included - migration bitmap sync trace-events to know how

Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 19:04, Jeff Cody ha scritto: On 09/07/2012 12:27 PM, Paolo Bonzini wrote: Il 30/08/2012 20:47, Jeff Cody ha scritto: @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { [IF_SCSI] = 7, }; +static void block_job_cb(void *opaque, int ret); + /* * We

Re: [Qemu-devel] [PULL for usb-next]: Add support for live-migration to usb-redir

2012-09-07 Thread Hans de Goede
Hi, On 09/07/2012 01:47 PM, Hans de Goede wrote: Hi Gerd, I'm very happy to present to you a pull-request for usb-redir live-migration support. I've tested this combined with Spice seamless migration, and it can successful: 1) migrate a vm while running dd if=/dev/zero of=/dev/sdb1 bs=32K

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-07 Thread Scott Wood
On 09/07/2012 03:08 AM, Alexander Graf wrote: On 07.09.2012, at 01:15, Scott Wood scottw...@freescale.com wrote: On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 15, 2012 6:59 AM To: Bhushan Bharat-R65777

[Qemu-devel] [PULL for usb-next]: Add support for live-migration to usb-redir (v2)

2012-09-07 Thread Hans de Goede
Hi Gerd, I'm very happy to present to you a pull-request for usb-redir live-migration support. I've tested this combined with Spice seamless migration, and it can successful: 1) migrate a vm while running dd if=/dev/zero of=/dev/sdb1 bs=32K inside the guest with sdb being a redirect USB-2 mass

[Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities pre/post migrate

2012-09-07 Thread Hans de Goede
The recent introduction of set_client_capabilities has broken (seamless) migration by trying to call qxl_send_events pre (seamless incoming) and post (*) migration, triggering the following assert: qxl_send_events: Assertion `qemu_spice_display_is_running(d-ssd)' failed. The solution is easy, pre

  1   2   >