[Qemu-devel] buildbot failure in qemu on xen41

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder xen41 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen41/builds/172 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

Re: [Qemu-devel] buildbot failure in qemu on xen41

2012-11-02 Thread Stefan Hajnoczi
Anthony, your buildslave is missing a package: ERROR: pixman not present. Your options: (1) Prefered: Install the pixman devel package (any recent distro should have packages as Xorg needs pixman too). (2) Fetch the pixman submodule, using: git submodule update --init pixman On Fr

[Qemu-devel] [PATCH] Fix spelling (prefered -> preferred)

2012-11-02 Thread Stefan Weil
Signed-off-by: Stefan Weil --- configure |2 +- net/tap-win32.c |7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 79701ea..860859b 100755 --- a/configure +++ b/configure @@ -2115,7 +2115,7 @@ if test "$pixman" = "system"; then el

Re: [Qemu-devel] [PATCH v3] correct error message qemu-img reported

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 6:11 AM, liguang wrote: > diff --git a/qemu-img.c b/qemu-img.c > index b41e670..d4ea800 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -337,10 +337,15 @@ static int img_create(int argc, char **argv) > > /* Get image size, if specified */ > if (optind < argc) { >

Re: [Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-02 Thread Stefan Hajnoczi
Corey, any ideas here? LINK qemu-ga Undefined symbols: "_monitor_get_fd", referenced from: _socket_connect in qemu-sockets.o _socket_listen in qemu-sockets.o "_monitor_fdset_dup_fd_find", referenced from: _qemu_close in osdep.o "_sem_timedwait", referenced from: _q

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki wrote: > Can live migration of QEMU include previous snapshot images? > I want to roll back to a previous snapshot image on another machine > after live migration. > > I was thinking Block Migration bring the snapshot images of QCOW2, but > Block Mig

Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx & txt updates

2012-11-02 Thread Jan Kiszka
On 2012-11-01 14:04, Gerd Hoffmann wrote: > Stop abusing displaysurface fields for text mode displays. > (bpp = 0, width = cols, height = lines). > > Add flags to displaystate indicating whenever text mode display > (curses) or gfx mode displays (sdl, vnc, ...) are present. > > Add separate displ

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Jan Kiszka
On 2012-10-31 16:30, Paolo Bonzini wrote: > Otherwise, chardevs will not be able to create a bottom half as soon > as that will require an AioContext. > > Signed-off-by: Paolo Bonzini > --- > vl.c | 12 ++-- > 1 file modificato, 6 inserzioni(+), 6 rimozioni(-) > > diff --git a/vl.c b/vl

[Qemu-devel] [PATCH] Fix comments (adress -> address, layed -> laid, wierd -> weird)

2012-11-02 Thread Stefan Weil
Remove also a duplicated 'the'. Signed-off-by: Stefan Weil --- slirp/ip_icmp.c |2 +- tcg/tcg.h |4 ++-- uri.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index d571fd0..9f1cb08 100644 --- a/slirp/ip_icmp.c

Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs

2012-11-02 Thread Gerd Hoffmann
Hi, > +static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr, > + uint32_t *buf, size_t len) > +{ > +int i; > + > +for (i = 0; i < (len / sizeof(uint32_t)); i++) { > +buf[i] = cpu_to_le32(buf[i]); > +} > +pci_dma_wri

[Qemu-devel] [PATCH] s390x: Spelling fixes (endianess -> endianness, occured -> occurred)

2012-11-02 Thread Stefan Weil
Replace also "write into" by "write to". Signed-off-by: Stefan Weil --- I think "write to" is better, but I am not sure about this, so please wait until a native speaker has reviewed that patch. Regards Stefan Weil hw/s390x/sclp.h|4 ++-- hw/s390x/sclpconsole.c |4 ++-- 2 file

Re: [Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 3:10 AM, Lei Li wrote: > On 11/01/2012 05:42 PM, Stefan Hajnoczi wrote: >> >> On Thu, Nov 1, 2012 at 8:48 AM, Lei Li wrote: >>> >>> netdev_del assume that remove host network device. >>> However, when try to remove a non-host network device >>> by netdev_del, it will cause

[Qemu-devel] [PATCH] xenfb: fix build breakage caused by console cleanup series

2012-11-02 Thread Gerd Hoffmann
Console cleanup series renamed dpy_resize and dpy_update all over the tree, but hw/xenfb.c was forgotten. Update it too so it builds again. Reported-by: Jan Kiszka Signed-off-by: Gerd Hoffmann --- hw/xenfb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xenfb.c

[Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-11-02 Thread Gerd Hoffmann
-- Forwarded message -- From: Date: 2012/10/30 Subject: buildbot failure in qemu on fedora-default To: kraxel...@gmail.com The Buildbot has detected a failed build on builder fedora-default while building qemu. Full details are available at: http://www.kraxel.org/bb/builders/fe

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-02 Thread Jan Kiszka
On 2012-11-02 01:52, liu ping fan wrote: > On Fri, Nov 2, 2012 at 2:44 AM, Jan Kiszka wrote: >> On 2012-11-01 16:45, Avi Kivity wrote: >>> On 10/29/2012 11:46 AM, liu ping fan wrote: On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity wrote: > On 10/29/2012 01:48 AM, Liu Ping Fan wrote: >> F

[Qemu-devel] buildbot failure in qemu on xen40

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder xen40 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen40/builds/174 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Stefan, From: Stefan Hajnoczi Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 2 Nov 2012 08:19:15 +0100 > On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki wrote: > > Can live migration of QEMU include previous snapshot images? > > I want to roll back to

Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs

2012-11-02 Thread David Gibson
On Fri, Nov 02, 2012 at 08:31:23AM +0100, Gerd Hoffmann wrote: > Hi, > > > +static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr, > > + uint32_t *buf, size_t len) > > +{ > > +int i; > > + > > +for (i = 0; i < (len / sizeof(uint32_t

Re: [Qemu-devel] [PATCH] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Kevin Wolf
Am 01.11.2012 12:30, schrieb Nicholas Thomas: > On Wed, 2012-10-31 at 17:44 +0100, Kevin Wolf wrote: >> Am 31.10.2012 15:33, schrieb Paolo Bonzini: >>> Il 31/10/2012 15:01, n...@bytemark.co.uk ha scritto: From: Nick Thomas To do this, we start a qemu-nbd process at _make_test_img an

[Qemu-devel] [PATCH 1/7] hw/qxl: guest bug on primary create with stride %4 != 0

2012-11-02 Thread Gerd Hoffmann
From: Alon Levy Due to usage of pixman for rendering on all spice surfaces we have pixman's requirement that the stride be word aligned. A guest not honoring that can crash spice and qemu with it due to failure to create a surface (in spice-server). Avoid this early on in primary surface creation

[Qemu-devel] [PATCH 5/7] spice: switch to pixman

2012-11-02 Thread Gerd Hoffmann
Switch over spice-display.c to use the pixman library instead of the home-grown pflib bits. Signed-off-by: Gerd Hoffmann --- console.h |5 + qemu-pixman.c | 13 + qemu-pixman.h |2 ++ ui/spice-display.c | 51 ++---

[Qemu-devel] [PATCH 4/7] qxl: call dpy_gfx_resize when entering vga mode

2012-11-02 Thread Gerd Hoffmann
When entering vga mode the display size likely changes, notify all displaychangelisteners about this. Probably went unnoticed for a while as one if the first things the guest does after leaving qxl native mode and entering qxl vga mode is to set the vga video mode. But there is still a small wind

[Qemu-devel] [PATCH 7/7] spice: fix initialization order

2012-11-02 Thread Gerd Hoffmann
Register displaychangelistener last, after spice is fully initialized, otherwise we may hit NULL pointer dereferences when qemu starts calling our callbacks. Commit e250d949feb1334828f27f0d145c35f29c4b7639 triggers this bug. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 10 --

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 08:26, Jan Kiszka ha scritto: > Can we move os_daemonize before that, or what are its dependencies? I > have an increasingly bad feeling about this code shuffling. Moving os_daemonize too early ruins error messages. I would just pull qemu_mutex_lock_iothread later, even just before

Re: [Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 08:45, Gerd Hoffmann ha scritto: > CCfsdev/virtfs-proxy-helper.o > fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’: > fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of > ‘setfsgid’, declared with attribute warn_unused_result > [-Werror=unused-result] > fsd

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Amit Shah
On (Thu) 01 Nov 2012 [18:07:21], Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add parameters

[Qemu-devel] compile failure on macos: "only weak aliases are supported on darwin"

2012-11-02 Thread Peter Maydell
Building on MacOS with clang has broken: qmp.c:474:1: error: only weak aliases are supported on darwin QEMU_WEAK_ALIAS(arch_query_cpu_definitions, default_arch_query_cpu_definitions); ^ ./compiler.h:54:54: note: expanded from macro 'QEMU_WEAK_ALIAS' typeof(oldname) newname __attribute__((w

[Qemu-devel] [PULL 0/7] spice patch queue

2012-11-02 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue. It carries some qxl bugfixes, switches spice-display over to pixman, drops the obsolete pflib bits and fixes some fallout from the console cleanup patch series. please pull, Gerd The following changes since commit 4ba79505f43bd0ace35c3fe42197eb02e7e0478

[Qemu-devel] [PATCH 6/7] pflib: unused, remove it.

2012-11-02 Thread Gerd Hoffmann
Replaced by pixman library. Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 - pflib.c | 215 - pflib.h | 20 - 3 files changed, 0 insertions(+), 236 deletions(-) delete mode 100644 pflib.c delete mode 100644 pfli

[Qemu-devel] [PATCH 3/7] qxl: fix cursor reset

2012-11-02 Thread Gerd Hoffmann
When resetting the qxl cursor notify the qemu displaystate too. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index f19451b..063970d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -293,6 +293,10 @@ void qxl_spic

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add parameters

[Qemu-devel] [PATCH 2/7] hw/qxl: qxl_send_events: nop if stopped

2012-11-02 Thread Gerd Hoffmann
From: Alon Levy Added a trace point for easy logging. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972 Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 +++- trace-events |1 + 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/qxl.

[Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread nick
From: Nick Thomas To do this, we start a qemu-nbd process at _make_test_img and kill it in _cleanup_test_img. $TEST_IMG is changed to point at the TCP server. We also remove the checks for existence of binaries from common.config - they're duplicated in common, and we can make the qemu-nbd check

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 9:24 AM, Kuniyasu Suzaki wrote: > > Hello Stefan, > > From: Stefan Hajnoczi > Subject: Re: [Qemu-devel] live migration which includes previos snapshot > Date: Fri, 2 Nov 2012 08:19:15 +0100 > >> On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki wrote: >> > Can live migration

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Jan Kiszka
On 2012-11-02 10:55, Paolo Bonzini wrote: > Il 02/11/2012 08:26, Jan Kiszka ha scritto: >> Can we move os_daemonize before that, or what are its dependencies? I >> have an increasingly bad feeling about this code shuffling. > > Moving os_daemonize too early ruins error messages. I would just > pu

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-02 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 12:31 PM, Michael S. Tsirkin wrote: > On Thu, Nov 01, 2012 at 10:53:52AM +0100, Stefan Hajnoczi wrote: >> On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote: >> > On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote: >> > > On Wed, Oct 31, 2012 at

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-02 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 2:49 PM, Stefan Hajnoczi wrote: > Laine: Please try this out and see if it works for your use case. Waiting for your feedback before I prepare a final patch that can go into QEMU. There's no time pressure from my side to get this feature in so take as much time as you nee

Re: [Qemu-devel] compile failure on macos: "only weak aliases are supported on darwin"

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 10:54, Peter Maydell ha scritto: > Building on MacOS with clang has broken: > > qmp.c:474:1: error: only weak aliases are supported on darwin > QEMU_WEAK_ALIAS(arch_query_cpu_definitions, > default_arch_query_cpu_definitions); > ^ > ./compiler.h:54:54: note: expanded from macro 'QEM

Re: [Qemu-devel] [patch v5 7/8] memory: introduce tls context to record nested dma

2012-11-02 Thread Jan Kiszka
On 2012-10-29 00:48, Liu Ping Fan wrote: > Signed-off-by: Liu Ping Fan > --- > cpus.c|3 ++ > exec.c| 58 > + > qemu-thread.h |8 +++ > vl.c |1 + > 4 files changed, 70 insertions(+), 0 deletions(-

Re: [Qemu-devel] compile failure on macos: "only weak aliases are supported on darwin"

2012-11-02 Thread Peter Maydell
On 2 November 2012 11:39, Paolo Bonzini wrote: > Il 02/11/2012 10:54, Peter Maydell ha scritto: >> Looks like commit 67d223be is the culprit (and QEMU_WEAK_ALIAS >> isn't actually generated weak aliases?) > > It's a bad error message. It should be "only weakref aliases are > supported on Darwin",

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-02 Thread Juan Quintela
David Gibson wrote: > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: >> On 10/31/2012 05:43 AM, David Gibson wrote: >> > The code for migrating (or savevm-ing) memory pages starts off by creating >> > a dirty bitmap and filling it with 1s. Except, actually, because bit >> > addre

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 11:32, Jan Kiszka ha scritto: > On 2012-11-02 10:55, Paolo Bonzini wrote: >> Il 02/11/2012 08:26, Jan Kiszka ha scritto: >>> Can we move os_daemonize before that, or what are its dependencies? I >>> have an increasingly bad feeling about this code shuffling. >> >> Moving os_daemonize

Re: [Qemu-devel] [PATCH v7 1/3] hw: introduce standard SD host controller

2012-11-02 Thread Igor Mitsyanko
On 11/02/2012 06:21 AM, Peter Crosthwaite wrote: On Fri, Nov 2, 2012 at 3:21 AM, Igor Mitsyanko wrote: Hi, Peter, I did some testing and noticed significant performance reduction compared to previous version without transfer_timer. For read operation: Testcase (count x blocksize) previou

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Vasilis Liaskovitis
On Thu, Nov 01, 2012 at 02:30:35PM +0100, Gerd Hoffmann wrote: > On 10/19/12 12:35, Vasilis Liaskovitis wrote: > > Hi, > > > > On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: > >> This patchs adds a frame buffer driver for (virtual/emulated) vga cards > >> implementing the bochs dis

[Qemu-devel] qemu.org DNS is down, use 140.211.15.109

2012-11-02 Thread Stefan Hajnoczi
The DNS for qemu.org is down. Please use the IP address 140.211.15.109 directly in the meantime or add it to your /etc/hosts so you can continue to use the domain name: echo '140.211.15.109 qemu.org wiki.qemu.org git.qemu.org' >>/etc/hosts Stefan

[Qemu-devel] [PATCH trace] Avoid all systemtap reserved words

2012-11-02 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Over time various systemtap reserved words have been blacklisted in the trace backend generator. The list is not complete though, so there is continued risk of problems in the future. Preempt such problems by specifying the full list of systemtap keywords listed in its

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Orit Wasserman
On 11/02/2012 05:10 AM, David Gibson wrote: > Asking for some advice on the list. > > I have prorotype savevm and migration support ready for the pseries > machine. They seem to work under simple circumstances (idle guest). > To test them more extensively I've been attempting to perform live > mi

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: > @@ -197,12 +198,14 @@ testlist options > IMGPROTO=rbd > xpand=false > ;; > - > -sheepdog) > IMGPROTO=sheepdog > xpand=false > ;; > - > +-nbd) > +IMGPROTO=nbd > +

[Qemu-devel] [PATCH v3] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Nicholas Thomas
From: n...@bytemark.co.uk To: qemu-devel@nongnu.org Cc: pbonz...@redhat.com, kw...@redhat.com, Nick Thomas Subject: [PATCH v3] tests: allow qemu-iotests to be run against nbd backend Date: Fri, 2 Nov 2012 10:28:06 + From: Nick Thomas To do this, we start a qemu-nbd process at _make_test_im

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Nicholas Thomas
On Fri, 2012-11-02 at 13:41 +0100, Paolo Bonzini wrote: > Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: > > @@ -197,12 +198,14 @@ testlist options > > IMGPROTO=rbd > > xpand=false > > ;; > > - > > -sheepdog) > > IMGPROTO=sheepdog > > xpand=false >

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 04:10, David Gibson ha scritto: > Asking for some advice on the list. > > I have prorotype savevm and migration support ready for the pseries > machine. They seem to work under simple circumstances (idle guest). > To test them more extensively I've been attempting to perform live >

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Juan Quintela
David Gibson wrote: > Asking for some advice on the list. > > I have prorotype savevm and migration support ready for the pseries > machine. They seem to work under simple circumstances (idle guest). > To test them more extensively I've been attempting to perform live > migrations (just over tcp-

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Eric Blake
On 11/02/2012 04:30 AM, Stefan Hajnoczi wrote: > II. If you want to use internal snapshots in a single qcow2 file, you > will need to modify QEMU code more: > 1. Implement BlockDriverState snapshot slave support so a qcow2 > snapshot can be read-only accessed as a BlockDriverState while the > mast

[Qemu-devel] [PATCH 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin we

[Qemu-devel] [PATCH 4/5] vl: unify calls to init_timer_alarm

2012-11-02 Thread Paolo Bonzini
init_timer_alarm was being called twice. This is not needed. Signed-off-by: Paolo Bonzini --- main-loop.c | 5 - vl.c| 5 - 2 file modificati, 4 inserzioni(+), 6 rimozioni(-) diff --git a/main-loop.c b/main-loop.c index e43c7c8..234a313 100644 --- a/main-loop.c +++ b/main-loop.

[Qemu-devel] [PATCH 1/5] compiler: support Darwin weak references

2012-11-02 Thread Paolo Bonzini
Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. Signed-off-by: Paolo Bonzini --- compiler.h | 9 - osdep.c| 56

[Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini --- qemu-thread-posix.c | 74 + qemu-thread-posix.h | 6 + 2 file modificati, 80 inserzioni(+) diff --git a/qemu-thread-posix.c b/q

[Qemu-devel] [PATCH 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

[Qemu-devel] [PATCH 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 15 ++- 1 file modificato, 14 inserzioni(+). 1 rimozione(-) diff --git a/qemu-timer.c b/qemu-timer.c index f3426c9..1d876

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Gerd Hoffmann
>> Only with bochsfb or with vesafb (+ fbdev xorg driver) too? > > vt-switching with vesafb/X11 works fine on a grml 64-bit image. However, xorg > uses vesa driver in this case, not fbdev (fbdev / fbdevhw xorg modules are > initially loaded but then unloaded). X11 uses 1280x768 and vesafb uses >

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 13:41, schrieb Paolo Bonzini: > Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: >> @@ -197,12 +198,14 @@ testlist options >> IMGPROTO=rbd >> xpand=false >> ;; >> - >> -sheepdog) >> IMGPROTO=sheepdog >> xpand=false >> ;; >

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino wrote: > By adding error propagation to bdrv_img_create() we improve error reporting > in qmp_transaction() and simplify qemu-img.c:img_create() a bit. > > Please, check individual patches for details. Kevin, is this in your review queue?

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 14:25, schrieb Luiz Capitulino: > On Fri, 19 Oct 2012 11:27:59 -0300 > Luiz Capitulino wrote: > >> By adding error propagation to bdrv_img_create() we improve error reporting >> in qmp_transaction() and simplify qemu-img.c:img_create() a bit. >> >> Please, check individual patches f

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 02 Nov 2012 14:40:03 +0100 Kevin Wolf wrote: > Am 02.11.2012 14:25, schrieb Luiz Capitulino: > > On Fri, 19 Oct 2012 11:27:59 -0300 > > Luiz Capitulino wrote: > > > >> By adding error propagation to bdrv_img_create() we improve error reporting > >> in qmp_transaction() and simplify qemu

Re: [Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-02 Thread Corey Bryant
On 11/02/2012 03:17 AM, Stefan Hajnoczi wrote: Corey, any ideas here? My guess for the majority of these is that monitor.o is not being linked with osdep.o for MacOSX. Is this a nightly build that would have been successful earlier in the week? Also do you know if (and perhaps how) I ca

Re: [Qemu-devel] [PATCH 1/5] compiler: support Darwin weak references

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini wrote: > Weakrefs only tell you if the symbol was defined elsewhere, so you > need a further check at runtime to pick the default definition > when needed. > > This could be automated by the compiler, but it does not do it. clang doesn't error out anymore,

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2: Adding

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini wrote: > +#if defined(__OpenBSD__) || defined(__APPLE__) || defined(__NetBSD__) > +struct timespec ts; > +clock_gettime(CLOCK_REALTIME, &ts); qemu-thread-posix.c:198:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99

[Qemu-devel] First 9 + 1/2 years of QEMU dev history animated

2012-11-02 Thread Daniel P. Berrange
While I was generating an animation of libvirt dev history[1] using gource, I also took the time to generate one showing the first 9+1/2 years of QEMU's dev history. https://www.youtube.com/watch?v=IujBYP7cw8E I see QEMU has its 10th birthday coming up early next year on Feb 18, 2013, assuming

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > On 11/01/2012 05:43 PM, Paul Moore wrote: > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > >> According to the bug 855162[0] - there's the need of adding new syscalls > >> to the whitelist whenn using Qemu with Libvir

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 12:29:37 AM Eduardo Otubo wrote: > On Thu, Nov 01, 2012 at 05:43:03PM -0400, Paul Moore wrote: > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > > > According to the bug 855162[0] - there's the need of adding new syscalls > > > to the whitelist whenn u

Re: [Qemu-devel] RBD trim / unmap support?

2012-11-02 Thread Stefan Priebe - Profihost AG
Hello qemu list, i cc you as i'm not sure where the problem is. When i use scsi-hd with discard_granularity the discard works fine on target size but the client print these - immediatly after sending discard / trim commands with mkfs.btrfs. [ 75.076895] sd 2:0:0:4: [sdc] [ 75.078353] Resu

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: > On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > > On 11/01/2012 05:43 PM, Paul Moore wrote: > > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > > >> According to the bug 855162[0] - there's the need of add

[Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin we

[Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references

2012-11-02 Thread Paolo Bonzini
Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. Signed-off-by: Paolo Bonzini --- v1->v2: add unused attribute compiler.h |

[Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini --- v1->v2: extract compute_abs_deadline and use it qemu-thread-posix.c | 92 +++-- qemu-thread-posix.h | 6 2 file modificati

[Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 14 ++ 1 file modificato, 14 inserzioni(+) diff --git a/qemu-timer.c b/qemu-timer.c index f3426c9..7b2217a 100644 --- a/q

Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx & txt updates

2012-11-02 Thread Peter Maydell
On 2 November 2012 08:20, Jan Kiszka wrote: > On 2012-11-01 14:04, Gerd Hoffmann wrote: >> Stop abusing displaysurface fields for text mode displays. >> (bpp = 0, width = cols, height = lines). >> >> Add flags to displaystate indicating whenever text mode display >> (curses) or gfx mode displays (

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Michael S. Tsirkin
On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > a regression in virtio-net performance because it looks > > into the ring aggressively while we really onl

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: > On 11/02/2012 10:38 AM, Paul Moore wrote: > > On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: > >> On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > >>> On 11/01/2012 05:43 PM, Paul Moore wrote: > On Tuesday

Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > Using appropriate types for variables is a good thing :). All users > simply do sizeof(MyType) and the value is passed to a memory allocator, > it should be size_t. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-aio.h | 2 +- > 1 file changed,

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > AIO control blocks are frequently acquired and released because each aio > request involves at least one AIOCB. Therefore, we pool them to avoid > heap allocation overhead. > > The problem with the freelist approach in AIOPool is thread-safety.

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:46 AM, Paul Moore wrote: On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Pa

Re: [Qemu-devel] [PATCH v2 3/3] aio: rename AIOPool to AIOCBInfo

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > Now that AIOPool no longer keeps a freelist, it isn't really a "pool" > anymore. Rename it to AIOCBInfo and make it const since it no longer > needs to be modified. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 22 +++--

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
Il 30/10/2012 19:21, Jan Kiszka ha scritto: > > > Aren't we still dependent on the order of processing? If the APIC is > > > restored after the device, won't we get the same problem? > > > > Strictly speaking yes, but CPUs and APICs are always the first devices > > to be saved. > Hmm, thinking ab

[Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Peter Maydell
Commit a93a4a2 changed the names of some fields in DisplayChangeListener and broke compilation of the cocoa UI. Update to the new names. Signed-off-by: Peter Maydell --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 2383646..87d2

[Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Gerd Hoffmann
On 11/02/12 15:54, Peter Maydell wrote: > Commit a93a4a2 changed the names of some fields in DisplayChangeListener > and broke compilation of the cocoa UI. Update to the new names. > > Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Jan Kiszka
On 2012-11-02 15:53, Paolo Bonzini wrote: > Il 30/10/2012 19:21, Jan Kiszka ha scritto: Aren't we still dependent on the order of processing? If the APIC is restored after the device, won't we get the same problem? >>> >>> Strictly speaking yes, but CPUs and APICs are always the first de

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 8551

Re: [Qemu-devel] [PATCH v2 35/39] raw: merge posix-aio-compat.c into block/raw-posix.c

2012-11-02 Thread Peter Maydell
On 31 October 2012 16:30, Paolo Bonzini wrote: > Making the qemu_paiocb specific to raw devices will let us access members > of the BDRVRawState arbitrarily. > > Signed-off-by: Paolo Bonzini clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: un

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Eric, From: Eric Blake Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 02 Nov 2012 07:12:21 -0600 > On 11/02/2012 04:30 AM, Stefan Hajnoczi wrote: > > > II. If you want to use internal snapshots in a single qcow2 file, you > > will need to modify QEMU

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Andreas Färber
Am 02.11.2012 15:54, schrieb Peter Maydell: > Commit a93a4a2 changed the names of some fields in DisplayChangeListener > and broke compilation of the cocoa UI. Update to the new names. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Peter, you didn't cc me - through whose queue is

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Gerd Hoffmann
Hi, > I think deferring IRQ events to the point when the complete vmstate is > loaded is the cleaner and more robust approach. Agree. Just schedule a bh in post_load. See also a229c0535bd336efaec786dd6e352a54e0a8187d cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Peter Maydell
On 2 November 2012 15:43, Paolo Bonzini wrote: > Three fixes: 1) Darwin does not support weak aliases, use weak > references instead. 2) Darwin, NetBSD and OpenBSD do not have > sem_timedwait, implement counting semaphores with a mutex and > cv there. 3) Daemonize was broken, fixes are in patche

[Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm

2012-11-02 Thread Paolo Bonzini
init_timer_alarm was being called twice. This is not needed. Signed-off-by: Paolo Bonzini --- main-loop.c | 5 - vl.c| 5 - 2 file modificati, 4 inserzioni(+), 6 rimozioni(-) diff --git a/main-loop.c b/main-loop.c index e43c7c8..234a313 100644 --- a/main-loop.c +++ b/main-loop.

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
> Hi, > > > I think deferring IRQ events to the point when the complete vmstate > > is > > loaded is the cleaner and more robust approach. > > Agree. Just schedule a bh in post_load. > See also a229c0535bd336efaec786dd6e352a54e0a8187d No, it cannot a bh. Right now incoming migration is blockin

[Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl

2012-11-02 Thread Paolo Bonzini
clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: unused function paio_ioctl [-Wunused-function] static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd, ^ 1 warning generated. because the only use of paio_ioctl

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Gerd Hoffmann
On 11/02/12 16:13, Paolo Bonzini wrote: >> Hi, >> >>> I think deferring IRQ events to the point when the complete vmstate >>> is >>> loaded is the cleaner and more robust approach. >> >> Agree. Just schedule a bh in post_load. >> See also a229c0535bd336efaec786dd6e352a54e0a8187d > > No, it cannot

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Stefan, From: Stefan Hajnoczi Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 2 Nov 2012 11:30:25 +0100 > If you are forking the VM so that there will be two VMs running > simultaneously, then a single qcow2 file cannot be used. > > Here are two approa

  1   2   >