[Qemu-devel] [Bug 1078305] Re: source IP address of broadcast packets gets rewritten when using NAT

2012-11-14 Thread Pallinger Péter
Actually, the PREROUTING lines are not needed in the above script, sorry. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1078305 Title: source IP address of broadcast packets gets rewritten when

Re: [Qemu-devel] [PATCH 2/2] block: Avoid second open for format probing

2012-11-14 Thread Stefan Hajnoczi
On Tue, Nov 13, 2012 at 03:14:55PM +0100, Kevin Wolf wrote: @@ -691,12 +685,15 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, /* Open the image, either directly or using a protocol */ if (drv-bdrv_file_open) { +if (file != NULL) { +

Re: [Qemu-devel] [PATCH] usb: Fix (another) bug in usb_packet_map() for IOMMU handling

2012-11-14 Thread Gerd Hoffmann
On 11/14/12 06:23, David Gibson wrote: Elements in qemu SGLists can cross IOMMU page boundaries. So, in commit 39c138c8420f51a7da7b35233a8d7400a0b589ac usb: Fix usb_packet_map() in the presence of IOMMUs, I changed usb_packet_map() to split up each SGList element on IOMMU page boundaries and

Re: [Qemu-devel] [PATCH 2/6] pixman: pass tools to configure

2012-11-14 Thread Gerd Hoffmann
Hi, An alternate solution (which works in my build environment) is passing --host=... (value derived from QEMU cross_prefix) to the pixman configure. Sounds reasonable, I'll try. +nm=${AR-${cross_prefix}nm} NM instead of AR? RANLIB instead of LD? Indeed. /me wonders why the test

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-14 Thread Stefan Hajnoczi
On Wed, Nov 14, 2012 at 11:50:06AM +0800, Wenchao Xia wrote: In order to resolve OOM issue, I am trying wrap all APIs using sunrpc, need some suggestion before coding. Is the client/server approach really necessary or can you write a library that invokes qemu-nbd/qemu-img? If there is a

Re: [Qemu-devel] [PATCH 2/2] block: Avoid second open for format probing

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 09:32, Stefan Hajnoczi ha scritto: On Tue, Nov 13, 2012 at 03:14:55PM +0100, Kevin Wolf wrote: @@ -691,12 +685,15 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, /* Open the image, either directly or using a protocol */ if

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 04:50, Wenchao Xia ha scritto: There are some different way to implement, not sure which would be better: 1 keep client as thin as possible, client stores opaque pointer used in server side, for eg, QBlockContext *ctx, client only get a pointer pointing to the address where

Re: [Qemu-devel] [PATCH 2/2] block: Avoid second open for format probing

2012-11-14 Thread Kevin Wolf
Am 14.11.2012 09:32, schrieb Stefan Hajnoczi: On Tue, Nov 13, 2012 at 03:14:55PM +0100, Kevin Wolf wrote: @@ -691,12 +685,15 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, /* Open the image, either directly or using a protocol */ if

Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path

2012-11-14 Thread Gerd Hoffmann
On 11/13/12 18:57, Stefan Weil wrote: Am 13.11.2012 09:42, schrieb Gerd Hoffmann: Needed to make sure the (generated) pixman-version.h file is found. Based on a patch from Blue Swirl. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |6 +++--- 1 files changed, 3

[Qemu-devel] [Bug 1078305] Re: source IP address of broadcast packets gets rewritten when using NAT

2012-11-14 Thread Pallinger Péter
Ok, I srewed up the iptables rules a little, so this is a working workaround script: IFACE=$(route -n | grep '^0.0.0.0 ' | sed 's/.* //g') main_broadcast_addr=$(ip -4 addr show $IFACE | grep 'inet .* brd ' | sed 's/.* brd //;s/\([0-9.]*\).*/\1/') iptables -t nat -A OUTPUT -d 255.255.255.255 -p

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-14 Thread liu ping fan
On Tue, Nov 13, 2012 at 6:11 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/11/2012 06:38, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com If out of global lock, we will be challenged by SMP in low level, so need atomic ops. This file is a wrapper of

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 10:38, liu ping fan ha scritto: On Tue, Nov 13, 2012 at 6:11 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/11/2012 06:38, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com If out of global lock, we will be challenged by SMP in low level, so need

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-14 Thread Wenchao Xia
On Wed, Nov 14, 2012 at 11:50:06AM +0800, Wenchao Xia wrote: In order to resolve OOM issue, I am trying wrap all APIs using sunrpc, need some suggestion before coding. Is the client/server approach really necessary or can you write a library that invokes qemu-nbd/qemu-img? If there is a

Re: [Qemu-devel] Migration To-do list

2012-11-14 Thread Hudzia, Benoit
Inline -Original Message- From: Isaku Yamahata [mailto:yamah...@valinux.co.jp] Sent: 14 November 2012 02:23 To: Hudzia, Benoit Cc: quint...@redhat.com; qemu-devel qemu-devel; Orit Wasserman; chegu_vi...@hp.com; Michael Roth Subject: Re: Migration To-do list On Tue, Nov 13, 2012

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-14 Thread Wenchao Xia
Il 14/11/2012 04:50, Wenchao Xia ha scritto: There are some different way to implement, not sure which would be better: 1 keep client as thin as possible, client stores opaque pointer used in server side, for eg, QBlockContext *ctx, client only get a pointer pointing to the address

Re: [Qemu-devel] [RFC] libqblock OOM issue

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 10:55, Wenchao Xia ha scritto: In order to resolve OOM issue, I am trying wrap all APIs using sunrpc, need some suggestion before coding. Is the client/server approach really necessary or can you write a library that invokes qemu-nbd/qemu-img? If there is a startup cost

[Qemu-devel] [PATCH] [RfC] add secondary stdvga variant

2012-11-14 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. --- docs/specs/standard-vga.txt | 13 +++-- hw/vga-pci.c| 62

[Qemu-devel] [PATCH] [RfC] add secondary stdvga variant

2012-11-14 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. --- docs/specs/standard-vga.txt | 13 +++-- hw/vga-pci.c| 62

[Qemu-devel] Adding another debug protocol

2012-11-14 Thread Peter Cheung
Dear AllI am going to add another debugger server into QEMU, so i need to1) create another socket server, similar than gdbserver, to receive the command from debugger2) add another option, such as --start-debugger-server to start the socket server. After I work out the whole thing, how can

Re: [Qemu-devel] Adding another debug protocol

2012-11-14 Thread Peter Maydell
On 14 November 2012 10:45, Peter Cheung mcheun...@hotmail.com wrote: Dear All I am going to add another debugger server into QEMU, so i need to 1) create another socket server, similar than gdbserver, to receive the command from debugger 2) add another option, such as

Re: [Qemu-devel] Migration To-do list

2012-11-14 Thread Orit Wasserman
On 11/14/2012 04:23 AM, Isaku Yamahata wrote: On Tue, Nov 13, 2012 at 05:46:13PM +, Hudzia, Benoit wrote: Hi, One concept we have been playing around in the context of and hybrid and post copy and might make sense if you are orienting your effort toward RDMA / Post copy is to move

[Qemu-devel] [Bug 1078305] Re: source IP address of broadcast packets gets rewritten when using NAT

2012-11-14 Thread Paolo Bonzini
NAT networking is provided by libvirt, changing the package. ** Project changed: qemu = libvirt (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1078305 Title: source IP address of

Re: [Qemu-devel] [PATCH 04/24] move qemu_irq typedef out of cpu-common.h

2012-11-14 Thread Eduardo Habkost
On Wed, Nov 14, 2012 at 01:03:46AM +0100, Andreas Färber wrote: Am 09.11.2012 15:56, schrieb Eduardo Habkost: From: Igor Mammedov imamm...@redhat.com it's necessary for making CPU child of DEVICE without causing circular header deps. Signed-off-by: Igor Mammedov imamm...@redhat.com

Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path

2012-11-14 Thread Gerd Hoffmann
On 11/14/12 09:40, Gerd Hoffmann wrote: + pixman_cflags=-I${source_path}/pixman/pixman -I$(pwd)/pixman/pixman + pixman_libs=-L$(pwd)/pixman/pixman/.libs -lpixman-1 I'd prefer \$(BUILD_DIR) instead of $(pwd) for cflags and libs because it allows moving the build directory. It isn't

Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early

2012-11-14 Thread Gerd Hoffmann
On 11/13/12 19:41, Johnson, Eric wrote: It's OK to add. Signed-off-by: Eric Johnson er...@mips.com Updated patch. I wasn't sure how to submit a patch to an unsubmitted patch. As usual: git commit -s + git format-patch + git send-email, especially as this one stands on its own and has no

[Qemu-devel] [PULL v2 0/7] pixman build fixes

2012-11-14 Thread Gerd Hoffmann
Hi, This patch series fixes the build issues with the internal pixman submodule. It also adds licensing info to the qemu-pixman.[ch] files. v2 improves things a bit based on comments from Stefan Weil, fixes some tyops found by Peter Maydell and adds a patch which also cleans up the pixman

[Qemu-devel] [PATCH 3/7] pixman: disable gtk

2012-11-14 Thread Gerd Hoffmann
gtk is only needed to build test cases. Disable it to simplify the build. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index ff2c16d..e68bb8f 100644 --- a/Makefile +++ b/Makefile @@

[Qemu-devel] [PATCH 1/7] pixman: add output dir to include path

2012-11-14 Thread Gerd Hoffmann
Needed to make sure the (generated) pixman-version.h file is found. Based on a patch from Blue Swirl. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 7290f50..e6fe4f8

[Qemu-devel] [PATCH 2/7] pixman: set --host for cross builds

2012-11-14 Thread Gerd Hoffmann
Set --host when calling pixman configure while doing cross builds so pixman's autoconf picks up the cross build tools correctly. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |2 +- configure |5 + 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Makefile

[Qemu-devel] [PATCH 5/7] pixman: build internal version early

2012-11-14 Thread Gerd Hoffmann
Signed-off-by: Eric Johnson er...@mips.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 0a241eb..f847ee2 100755 --- a/configure +++ b/configure @@ -3956,9 +3956,6 @@ if test

[Qemu-devel] [PATCH 4/7] pixman: pass cflags, add -fPIC

2012-11-14 Thread Gerd Hoffmann
Pass on CFLAGS to the pixman configure script. Add -fPIC to the cflags, needed to make the final link succeed. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e68bb8f..4538b87 100644

[Qemu-devel] [PATCH 7/7] pixman: cleanup properly on make distclean

2012-11-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 4538b87..81c660f 100644 --- a/Makefile +++ b/Makefile @@ -278,6 +278,7 @@ distclean: clean for d in $(TARGET_DIRS) $(QEMULIBS); do

[Qemu-devel] [PATCH 6/7] pixman: add licensing info

2012-11-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-pixman.c |5 + qemu-pixman.h |5 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/qemu-pixman.c b/qemu-pixman.c index 7547ed7..063b52d 100644 --- a/qemu-pixman.c +++ b/qemu-pixman.c @@ -1,3 +1,8 @@ +/* + *

[Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-14 Thread Alon Levy
Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c | 54

[Qemu-devel] [PATCH 0/2] 'make test' build fixes

2012-11-14 Thread Cornelia Huck
Hi, I've tried to make 'make test' at least build on an s390 host (not that it does anything interesting yet...) by changing the compiler for a test that's supposed to be architecture agnostic and doing some whitespace fixes in find-in-path. Build tested on Linux/s390 and Linux/x86. Cornelia

[Qemu-devel] [PATCH 2/2] rules.mak: Fix find-in-path

2012-11-14 Thread Cornelia Huck
Whitespace needs to be stripped before building the path and in the end to ensure we really get an empty string. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- rules.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules.mak b/rules.mak index

[Qemu-devel] [PATCH 1/2] tests/tcg: test_path is not i386 only

2012-11-14 Thread Cornelia Huck
test_path is supposed to be run for all architectures, so it should use the main compiler instead of the i386 compiler. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- tests/tcg/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/Makefile

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 14:09, Alon Levy ha scritto: Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c

Re: [Qemu-devel] [PATCH 05/24] qdev: split up header so it can be used in cpu.h

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: From: Anthony Liguori aligu...@us.ibm.com Header file dependency is a frickin' nightmare right now. cpu.h tends to get included in our 'include everything' header files but qdev also needs to include those headers mainly for qdev-properties

Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: module.h is where machine_init() is defined, but qemu-fsdev-dummy.c doesn't include it. The header is probably being included by accident because some other headers are including qemu-common.h, but those headers should eventually stop including

[Qemu-devel] [RFC PATCH v4 1/3] use image_file_reset to reload initrd image

2012-11-14 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 39 +++ hw/loader.h |7 +++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index ba01ca6..a8a0a09 100644 --- a/hw/loader.c +++

[Qemu-devel] [RFC PATCH v4 3/3] use elf_reset to reload elf image

2012-11-14 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- elf.h| 10 ++ hw/elf_ops.h | 101 ++ 2 files changed, 111 insertions(+), 0 deletions(-) diff --git a/elf.h b/elf.h index a21ea53..335f1af 100644 --- a/elf.h +++ b/elf.h

[Qemu-devel] [RFC PATCH v4 0/3] reload kernel/initrd/elf images when reset

2012-11-14 Thread Olivia Yin
The current model of loader copy rom blobs and kept in memory until a reset occurs and waste host memory. This serial of patches uses private reset handlers to load from hard disk on reset, which could make loader framework more dynamic and reduce the memory consumption of QEMU process.

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-11-14 Thread Serge Hallyn
Can someone go ahead and follow up on comment #6? (Marking incomplete in the meantime) I'll mark as affecting the QEMU project since it has been confirmed against 1.2.0 per comment #4. ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided = Medium ** Changed in: qemu-kvm (Ubuntu)

Re: [Qemu-devel] [PATCH 08/24] vnc-palette.h: include stdbool.h

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: stdbool.h is needed for the 'bool' type, used in the header. The header is probably being included by accident because some other headers are including qemu-common.h, but those headers should eventually stop including qemu-common.h.

Re: [Qemu-devel] [PATCH 09/24] ui/vnc-pallete.c: include headers it needs

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: Include: - glib.h for g_malloc0() - string.h for memset() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including

[Qemu-devel] [PATCH] mips/malta: fix CBUS UART interrupt pin

2012-11-14 Thread Aurelien Jarno
According to the MIPS Malta Developement Platform User's Manual, the i8259 interrupt controller is supposed to be connected to the hardware IRQ0, and the CBUS UART to the hardware interrupt 2. In QEMU they are both connected to hardware interrupt 0, the CBUS UART interrupt being wrong. This patch

Re: [Qemu-devel] Adding another debug protocol

2012-11-14 Thread Peter Cheung
Hi Cannot use gdb protocol, because it is slow.Also, the original gdb stub can dump out GDT/IDT/CR0 directly. Thanksfrom Peter Date: Wed, 14 Nov 2012 10:54:02 + From: peter.mayd...@linaro.org To: mcheun...@hotmail.com CC: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Adding another

Re: [Qemu-devel] [PATCH 10/24] qemu-config.h: include headers it needs

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: Include: - stdio.h for FILE - qemu-option.h for QemuOptsList Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including

[Qemu-devel] [RFC PATCH v4 2/3] use uimage_reset to reload uimage

2012-11-14 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 64 ++ 1 files changed, 46 insertions(+), 18 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index a8a0a09..1a909d0 100644 --- a/hw/loader.c +++ b/hw/loader.c @@

Re: [Qemu-devel] [PATCH] KVM: MMU: lazily drop large spte

2012-11-14 Thread Marcelo Tosatti
On Wed, Nov 14, 2012 at 12:33:50AM +0900, Takuya Yoshikawa wrote: Ccing live migration developers who should be interested in this work, On Mon, 12 Nov 2012 21:10:32 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: Do not

[Qemu-devel] [PATCH] usb-host: scan for usb devices when the vm starts

2012-11-14 Thread Gerd Hoffmann
Commit a844ed842d9a9d929645c09ae0f52f753d7a02e0 leads to usb-host detecting devices not right after qemu startup because the guest isn't running yet. Instead they are found on the first of the regular usb device poll runs. Which is too late for seabios to see them, so booting from usb sticks

Re: [Qemu-devel] Adding another debug protocol

2012-11-14 Thread Jan Kiszka
On 2012-11-14 15:40, Peter Cheung wrote: Hi Cannot use gdb protocol, because it is slow. For any practical purpose I came across so far while debugging guest kernels, that is not true when running against QEMU. Sure, if you want to dump gigabytes of RAM this way, it will be a bottleneck. But

Re: [Qemu-devel] [PATCH 06/30] migration: stop all cpus correctly

2012-11-14 Thread Paolo Bonzini
Il 12/11/2012 12:44, Paolo Bonzini ha scritto: @@ -339,7 +351,11 @@ void migrate_fd_put_ready(MigrationState *s) DPRINTF(done iterating\n); start_time = qemu_get_clock_ms(rt_clock); qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); -

[Qemu-devel] [PATCH] osdep: Move qemu_{open,close}() prototypes

2012-11-14 Thread Andreas Färber
They are implemented in osdep.c, so keep the prototypes in osdep.h. Suggested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de Cc: Eduardo Habkost ehabk...@redhat.com --- osdep.h |3 +++ qemu-common.h |2 -- 2 Dateien geändert, 3 Zeilen

Re: [Qemu-devel] [PATCH 11/24] qapi/qmp-registry.c: include headers it needs

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: Include: - glib.h for g_malloc0() - string.h for strcmp() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h.

Re: [Qemu-devel] [PATCH] osdep: Move qemu_{open, close}() prototypes

2012-11-14 Thread Eduardo Habkost
On Wed, Nov 14, 2012 at 04:46:07PM +0100, Andreas Färber wrote: They are implemented in osdep.c, so keep the prototypes in osdep.h. Suggested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de Cc: Eduardo Habkost ehabk...@redhat.com Acked-by: Eduardo

Re: [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs

2012-11-14 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: Include: - errno.h for errno - unistd.h fcntl.h for fcntl() - qemu-stdio.h for qemu_open() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should

[Qemu-devel] [PATCH 00/10] ehci: various fixes

2012-11-14 Thread Hans de Goede
While working on moving usb-redir and usb-hid over to using async packet handling for their interrupt input endpoints. I've found and fixed quite a few ehci bugs. Unfortunately the moving to async for interrupt endpoints turns out to be a bad idea, as it causes issues for migration, an async

[Qemu-devel] [PATCH 09/10] ehci: writeback_async_complete_packet: verify qh and qtd

2012-11-14 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 13e9fd3..6d23af1 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -191,6 +191,7 @@ static int

[Qemu-devel] [PATCH 06/10] ehci: Verify guest does not change the token of inflight qtd-s

2012-11-14 Thread Hans de Goede
This is not allowed, except for clearing active on cancellation, so don't warn when the new token does not have its active bit set. This unifies the cancellation path for modified qtd-s, and prepares ehci_verify_qtd to be used ad an extra check inside ehci_writeback_async_complete_packet().

[Qemu-devel] [PATCH 07/10] ehci: Don't verify the next pointer for periodic qh-s

2012-11-14 Thread Hans de Goede
Windows-XP likes to play tricks with the next pointer for periodic qh-s, so far we were not hit by this as we never called fill_queue for periodic qh-s, but with the move to async packet handling for interrupt endpoints this becomes an issue. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[Qemu-devel] [PATCH 08/10] ehci: Move get / put_dwords upwards

2012-11-14 Thread Hans de Goede
No other changes. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 60 +++ 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index e83bdde..13e9fd3 100644 ---

Re: [Qemu-devel] [PULL 0/7] spice patch queue

2012-11-14 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, Here comes the spice patch queue. It carries some qxl bugfixes, switches spice-display over to pixman, drops the obsolete pflib bits and fixes some fallout from the console cleanup patch series. please pull, Gerd The following changes

Re: [Qemu-devel] [PULL 0/8] usb patch queue

2012-11-14 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, This is the usb patch queue. It cleans up the USBPacket error handling to have separate length and status fields which is needed to get some corner cases correct. While being at it it also makes status reporting identical for both sync and

[Qemu-devel] [PATCH 10/10] ehci: Verify qtd for async completed packets

2012-11-14 Thread Hans de Goede
Remove the short-circuiting of fetchqtd in fetchqh, so that the qtd gets properly verified before completing the transaction. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

Re: [Qemu-devel] [PULL 0/6] pixman build fixes

2012-11-14 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, This patch series fixes the build issues with the internal pixman submodule. It also adds licensing info to the qemu-pixman.[ch] files. please pull, Gerd The following changes since commit f5022a135e4309a54d433c69b2a056756b2d0d6b: aio:

Re: [Qemu-devel] [PULL 1.3 0/5] SCSI updates for 2012-11-12

2012-11-14 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Anthony, The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: tcg: properly check that op's output needs to be synced to memory (2012-11-11 16:06:46 +0100) are available in the git repository at:

Re: [Qemu-devel] [PULL 0/3] vfio-pci for 1.3-rc0

2012-11-14 Thread Anthony Liguori
Alex Williamson alex.william...@redhat.com writes: Hi Anthony, Please pull the tag below. I posted the linux-headers update separately on Oct-15; since it hasn't been applied and should be non-controversial, I include it again here. Thanks, Alex Pulled. Thanks. Regards, Anthony

Re: [Qemu-devel] Adding another debug protocol

2012-11-14 Thread Peter Cheung
hi Jan, you are the maintainer of the gdb server of qemu? I think if I can't create my debug protocol, it is not easy to adopt peter-bochs debugger to qemu, in peter-bochs, there are some features I think current gdb protocol doesn't care, such as profiling, kernel module monitoring, call graph

[Qemu-devel] [PATCH 01/10] ehci: Don't access packet after freeing it

2012-11-14 Thread Hans de Goede
ehci_state_writeback() will free the packet, so we should not access the packet after calling ehci_state_writeback(). Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/usb/hcd-ehci.c

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 17:25, Thanos Makatos ha scritto: We don't use qemu's VHD driver in XenServer. Instead, we use blktap2 to create a block device in dom0 serving the VHD file in question, and have qemu open that block device instead of the VHD file itself. Yes, the question is how you handle disks

Re: [Qemu-devel] Adding another debug protocol

2012-11-14 Thread Jan Kiszka
On 2012-11-14 17:28, Peter Cheung wrote: hi Jan, you are the maintainer of the gdb server of qemu? Not formally. I'm heavily using it for kernel debugging for a couple of years. Therefore, I'm fixing and enhancing it from time to time. I think if I can't create my debug protocol, it is not

[Qemu-devel] [PATCH 03/10] ehci: Better detection for qtd-s linked in circles

2012-11-14 Thread Hans de Goede
Windows links interrupt qtd-s in circles, which means that when interrupt endpoints return USB_RET_ASYNC, combined with the recent ehci: Retry to fill the queue while waiting for td completion patch, we keep adding the tds to the queue over and over again, as we detect the circle from fill_queue,

[Qemu-devel] [PATCH 05/10] ehci: Add ehci_verify_qh and ehci_verify_qtd helper functions

2012-11-14 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 45 - 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 7772c33..a694346 100644 --- a/hw/usb/hcd-ehci.c +++

[Qemu-devel] [PATCH v5 22/24] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-11-14 Thread Eduardo Habkost
This separates the qdev properties code in two parts: - qdev-properties.c, that contains most of the qdev properties code; - qdev-properties-system.c for code specific for qemu-system-*, containing: - Property types: drive, chr, netdev, vlan, that depend on code that won't be included

[Qemu-devel] [PATCH 02/10] ehci: Fixup q-qtdaddr after cancelling an already completed packet

2012-11-14 Thread Hans de Goede
This avoids the q-qtdaddr == p-qtdaddr asserts we have triggering, when a queue contains multiple completed packages when we cancel the queue. I triggered this with windows7 + async interrupt endpoint handling (*) + not detecting circles in ehci_fill_queue() properly, which makes the qtd

[Qemu-devel] [PATCH 04/10] ehci: Add a ehci_writeback_async_complete_packet helper function

2012-11-14 Thread Hans de Goede
Also drop the warning printf, which was there mainly because this was an untested code path (as the previous bug fixes to it show), but that no longer is the case now :) Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 28 +--- 1 file changed, 17

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-14 Thread Serge Hallyn
Thanks, Paul, I'll cherrypick commit c8969eded252058e90e91f12f75f32aceae46ec9 into the ubuntu packages -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077838 Title: qemu-nbd -r -c taints device for

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-14 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu) Assignee: (unassigned) = Serge Hallyn (serge-hallyn) ** Changed in: qemu-kvm (Ubuntu) Status: Triaged = In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/2] x86/cpu: name new CPUID bits

2012-11-14 Thread Eduardo Habkost
On Fri, Nov 02, 2012 at 09:21:26AM -0400, Boris Ostrovsky wrote: From: Andre Przywara o...@andrep.de Update QEMU's knowledge of CPUID bit names. This allows to enable/disable those new features on QEMU's command line when using KVM and prepares future feature enablement in QEMU. This adds

Re: [Qemu-devel] [PATCH 2/2] x86/cpu: add new Opteron CPU model

2012-11-14 Thread Eduardo Habkost
On Fri, Nov 02, 2012 at 09:21:38AM -0400, Boris Ostrovsky wrote: From: Andre Przywara o...@andrep.de Add a new base CPU model called Opteron_G5 to model the latest Opteron CPUs. This increases the model value and model numbers and adds TBM, F16C and FMA over the latest G4 model.

[Qemu-devel] [PATCH 2/3] target-i386: cpu: add new Opteron CPU model

2012-11-14 Thread Eduardo Habkost
From: Andre Przywara o...@andrep.de Add a new base CPU model called Opteron_G5 to model the latest Opteron CPUs. This increases the model value and model numbers and adds TBM, F16C and FMA over the latest G4 model. Signed-off-by: Andre Przywara o...@andrep.de Signed-off-by: Boris Ostrovsky

Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early

2012-11-14 Thread Johnson, Eric
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, November 14, 2012 4:42 AM [...] On 11/13/12 19:41, Johnson, Eric wrote: [...] I wasn't sure how to submit a patch to an unsubmitted patch. As usual: git commit -s + git format-patch + git

[Qemu-devel] [PATCH 0/3] Opteron_G5 and Haswell CPU models

2012-11-14 Thread Eduardo Habkost
I'm resending the patches sent by Boris Ostrovsky previously, as it has to be rebased against latest qemu.git, and to add a new Haswell CPU model too. Andre Przywara (2): target-i386: cpu: name new CPUID bits target-i386: cpu: add new Opteron CPU model Eduardo Habkost (1): target-i386: add

[Qemu-devel] [PATCH 3/3] target-i386: add Haswell CPU model

2012-11-14 Thread Eduardo Habkost
Features added to the model, in relation to SandyBridge: fma CPUID[1].ECX[12] pcid CPUID[1].ECX[17] movbe CPUID[1].ECX[22] fsgsbase CPUID[EAX=7,ECX=0].EBX[0] bmi1 CPUID[EAX=7,ECX=0].EBX[3] hle CPUID[EAX=7,ECX=0].EBX[4] avx2 CPUID[EAX=7,ECX=0].EBX[5] smep

[Qemu-devel] [PATCH 22/26] fdc: fix typo in zero constant

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index a197c48..de8778b 100644 --- a/hw/fdc.c +++

[Qemu-devel] [PATCH 04/26] MAINTAINERS: add Stefan Hajnoczi as block and virtio-blk co-maintainer

2012-11-14 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Kevin has requested co-maintainership to give him more time to write code. We will alternate patch review duties on a weekly basis. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- MAINTAINERS |2 ++

[Qemu-devel] [PATCH 14/26] fdc: use status0 field instead of a local variable

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/fdc.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 3585220..7e4b0ce

[Qemu-devel] [PATCH 10/26] fdc: Remove status0 parameter from fdctrl_set_fifo()

2012-11-14 Thread Kevin Wolf
It decided whether an interrupt is triggered. Only one caller made use of this functionality, so move the code there. In this one caller, the interrupt must actually be triggered unconditionally, like it was before commit 2fee0088. For example, a successful read without an implied seek can result

[Qemu-devel] [PATCH 09/26] aio: rename AIOPool to AIOCBInfo

2012-11-14 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Now that AIOPool no longer keeps a freelist, it isn't really a pool anymore. Rename it to AIOCBInfo and make it const since it no longer needs to be modified. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH 23/26] fdc: remove last usage of FD_STATE_SEEK

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org Replace it by directly setting FD_SR0_SEEK if required Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/fdc.c | 12 ++-- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 07/26] aio: switch aiocb_size type int - size_t

2012-11-14 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Using appropriate types for variables is a good thing :). All users simply do sizeof(MyType) and the value is passed to a memory allocator, it should be size_t. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Paolo Bonzini

[Qemu-devel] [PATCH 15/26] fdc: fix FD_SR0_SEEK for non-DMA transfers and multi sectors transfers

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org On non-DMA transfers, fdctrl_stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_seek_to_next_sect() has this information because it performs the seek itself. Signed-off-by: Hervé

[Qemu-devel] [PATCH 11/26] fdc-test: split test_media_change() test, so insert part can be reused

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/fdc-test.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index

[Qemu-devel] [PATCH 25/26] megasas: Use bdrv_drain_all instead of qemu_aio_flush

2012-11-14 Thread Kevin Wolf
Calling qemu_aio_flush() directly can hang when combined with I/O throttling. Signed-off-by: Kevin Wolf kw...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com --- hw/megasas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index

[Qemu-devel] [PATCH 24/26] vmdk: Fix data corruption bug in WRITE and READ handling

2012-11-14 Thread Kevin Wolf
From: Gerhard Wiesinger li...@wiesinger.com Fixed a MAJOR BUG in VMDK files on file boundaries on reads and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! Triggered for example with the following VMDK file (partly listed): RW 4193792 FLAT XP-W1-f001.vmdk 0 RW 2097664 FLAT

[Qemu-devel] [PATCH 21/26] fdc: remove double affectation of FD_MSR_CMDBUSY flag

2012-11-14 Thread Kevin Wolf
From: Hervé Poussineau hpous...@reactos.org FD_MSR_CMDBUSY flag is already set in fdctrl_write_data(), just before calling the command handler (fdctrl_start_transfer() here). Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/fdc.c |2 +-

[Qemu-devel] [PATCH 18/26] fdc-test: Check READ ID

2012-11-14 Thread Kevin Wolf
ST0 shouldn't include 0x20 (FD_SR0_SEEK) after READ ID. Signed-off-by: Kevin Wolf kw...@redhat.com Tested-by: Hervé Poussineau hpous...@reactos.org --- tests/fdc-test.c | 66 ++ 1 files changed, 66 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-14 Thread Thanos Makatos
We don't use qemu's VHD driver in XenServer. Instead, we use blktap2 to create a block device in dom0 serving the VHD file in question, and have qemu open that block device instead of the VHD file itself. -Original Message- From: Stefano Stabellini

  1   2   >