Re: [Qemu-devel] broken incoming migration

2013-06-05 Thread Peter Lieven
Am 05.06.2013 um 05:37 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 06/05/2013 05:15 AM, Peter Lieven wrote: Am 04.06.2013 um 17:17 schrieb Paolo Bonzini pbonz...@redhat.com: Il 04/06/2013 16:48, Peter Lieven ha scritto: Still using 3.2, but strange enough the above example is also

Re: [Qemu-devel] [snabb-devel:327] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-05 Thread Luke Gorrie
On 4 June 2013 14:56, Michael S. Tsirkin m...@redhat.com wrote: That would mean making snabb switch part of QEMU. Just curious - not suggesting that this is practical - but what would that mean? Is the important thing to keep all device implementations in the same source tree so that QEMU

[Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

2013-06-05 Thread Amos Kong
The MAX_VLAN is 4096, currently the vlan filter table has 512 (4096 3) entries, it's wrong. One entry in vlan filter table can indicate 32(1 5) vlans, so the table should have 128 (4096 5) entries. Signed-off-by: Amos Kong ak...@redhat.com --- btw, it would be simple to use an uint32 number

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/04/2013 01:24 PM, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 04/06/2013 18:37, Markus Armbruster ha scritto: I figure the bit that can't be resolved now is letting the user switch off stop on error safely before a

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-06-05 Thread Amos Kong
On Wed, May 29, 2013 at 01:31:12PM +0800, Jason Wang wrote: On 05/16/2013 07:07 PM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx

Re: [Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

2013-06-05 Thread Amos Kong
On Wed, Jun 05, 2013 at 02:13:48PM +0800, Amos Kong wrote: The MAX_VLAN is 4096, currently the vlan filter table has 512 (4096 3) entries, it's wrong. One entry in vlan filter table can indicate 32(1 5) vlans, so the table should have 128 (4096 5) entries. Signed-off-by: Amos Kong

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-05 Thread Dunrong Huang
On Wed, Jun 5, 2013 at 10:44 AM, Dunrong Huang riegama...@gmail.com wrote: On Wed, Jun 5, 2013 at 1:03 AM, Jordan Justen jljus...@gmail.com wrote: On Tue, Jun 4, 2013 at 1:26 AM, Dunrong Huang riegama...@gmail.com wrote: On Tue, Jun 4, 2013 at 3:51 PM, Gleb Natapov g...@redhat.com wrote:

[Qemu-devel] [PATCH] pseries: Support for in-kernel XICS interrupt controller

2013-06-05 Thread Alexey Kardashevskiy
From: David Gibson da...@gibson.dropbear.id.au Recent (host) kernels support emulating the PAPR defined XICS interrupt controller system within KVM. This patch allows qemu to initialize and configure the in-kernel XICS, and keep its state in sync with qemu's XICS state as necessary. This should

Re: [Qemu-devel] [PATCH 00/13 v2] pseries: savevm / migration support

2013-06-05 Thread Alexey Kardashevskiy
On 06/05/2013 11:59 AM, Alexey Kardashevskiy wrote: On 06/04/2013 10:42 PM, Andreas Färber wrote: Am 04.06.2013 14:20, schrieb Alexey Kardashevskiy: I still have to learn how to force git not to overwrite the original commit author :-/ Is there any way to tell the original creator in the

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-05 Thread Paolo Bonzini
Il 05/06/2013 06:53, Michael S. Tsirkin ha scritto: On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: +if (dev-msix_table || dev-msix_pba || dev-msix_entry_used) { +msix_free(dev); +} + dev-msix_table =

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 06:37:27PM +0200, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Fam Zheng
On Mon, 06/03 16:58, Stefan Hajnoczi wrote: Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop

Re: [Qemu-devel] [Qemu-stable] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-06-05 Thread Michael Tokarev
04.06.2013 18:23, Anthony Liguori wrote: Andreas Färber afaer...@suse.de writes: [] Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git MAINTAINERS has not been updated with stable branches and maintainers for some time. If not, I'd be willing to step up for security fixes

[Qemu-devel] [PATCH v2] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Stefan Hajnoczi
Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop -device virtio-blk-pci,drive=foo,id=virtio0,addr=4 2.

Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 02:47:26PM +0200, Stefan Hajnoczi wrote: Use qemu_del_nic() instead of qemu_del_net_client() to correctly free the entire NICState. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/net/vmxnet3.c | 2 +- 1

Re: [Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

2013-06-05 Thread Amos Kong
On Wed, Jun 05, 2013 at 03:21:30PM +0800, Amos Kong wrote: On Wed, Jun 05, 2013 at 02:13:48PM +0800, Amos Kong wrote: The MAX_VLAN is 4096, currently the vlan filter table has 512 (4096 3) entries, it's wrong. One entry in vlan filter table can indicate 32(1 5) vlans, so the table

Re: [Qemu-devel] [PATCH v2] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Kevin Wolf
Am 05.06.2013 um 10:33 hat Stefan Hajnoczi geschrieben: Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-06-05 Thread Claudio Fontana
On 04.06.2013 18:13, Peter Maydell wrote: On 4 June 2013 16:55, Claudio Fontana claudio.font...@huawei.com wrote: I'm trying to get this to run, in order to be able to test the aarch64 TCG User mode support I have under development. Does it work as a first pass with aarch64 put in the

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 02:18:40PM -0400, Corey Bryant wrote: Provides TPM NVRAM implementation that enables storing of TPM NVRAM data in a persistent image file. The block driver is used to read/write the drive image. This will enable, for example, an ecrypted QCOW2 image to be used to

Re: [Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-06-05 Thread David Gibson
On Wed, Jun 05, 2013 at 12:36:04PM +1000, Alexey Kardashevskiy wrote: On 06/04/2013 10:11 PM, David Gibson wrote: On Thu, May 30, 2013 at 07:26:10PM +1000, Alexey Kardashevskiy wrote: This adds a missing code to save CR (condition register) via kvm_arch_put_registers().

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize time, and memory_region_destroy at instance_finalize time. The general idea looks good. Could you please

Re: [Qemu-devel] [PATCH 12/13] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-06-05 Thread David Gibson
On Tue, Jun 04, 2013 at 10:21:04PM +1000, Alexey Kardashevskiy wrote: From: David Gibson da...@gibson.dropbear.id.au Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient in-kernel XICS for example. qemu is

Re: [Qemu-devel] [PATCH 1/2] Add Linux libnuma detection

2013-06-05 Thread Andreas Färber
Am 05.06.2013 05:58, schrieb Wanlong Gao: Add detection of libnuma (mostly contained in the numactl package) to the configure script. Currently this is Linux only, but can be extended later should the need for other interfaces come up. Can be enabled or disabled on the command line, default is

Re: [Qemu-devel] [PATCH 11/13] pseries: savevm support for PCI host bridge

2013-06-05 Thread David Gibson
On Tue, Jun 04, 2013 at 10:21:03PM +1000, Alexey Kardashevskiy wrote: Author: David Gibson da...@gibson.dropbear.id.au This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). I think the PCI cleanup patches I was working on need to go in

Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

2013-06-05 Thread David Gibson
On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote: On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote: [snip] +static int ics_post_load(void *opaque, int version_id) +{ +int i; +struct ics_state *ics = opaque; + +for (i = 0; i ics-nr_irqs; i++) {

Re: [Qemu-devel] [Qemu] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

2013-06-05 Thread Michael Tokarev
23.05.2013 02:38, Brad Smith wrote: Fix the build of the Gtk+ UI on *BSD systems. Can you please describe what exactly was broken on *BSD systems, -- which file(s) needs this additional termios.h include? I want to fix this properly, because now it isn't nitpicking, as you say, anymore -- after

[Qemu-devel] qemu openpty

2013-06-05 Thread Michael Tokarev
Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this issue. Here it is, from qemu-char.c: #ifdef

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 09:48:19AM +0200, Paolo Bonzini wrote: Il 05/06/2013 06:53, Michael S. Tsirkin ha scritto: On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: +if (dev-msix_table || dev-msix_pba ||

[Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-05 Thread Amos Kong
Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is changed in guest, then Libvirt query the rx-filter information by a monitor

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-05 Thread Daniel P. Berrange
On Wed, Jun 05, 2013 at 06:42:13PM +0800, Amos Kong wrote: Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is changed in

Re: [Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-06-05 Thread Alexey Kardashevskiy
On 05.06.2013 19:22, David Gibson wrote: I meant to post my pending patches at the end of last week, but was sidetracked by a minor injury :(. Sigh... What exactly are you going to post? PCI rework? Well until now the only thing I had in my ppc-next tree was the change of default

Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo

2013-06-05 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 09:28:59AM +0800, Wenchao Xia wrote: 于 2013-5-26 0:10, Eric Blake 写道: On 05/24/2013 10:24 PM, Wenchao Xia wrote: void bdrv_query_image_info(BlockDriverState *bs, ImageInfo **p_info, Error **errp) diff --git

Re: [Qemu-devel] [PATCH v2] linux-user: Allow getdents to be provided by getdents64

2013-06-05 Thread Claudio Fontana
On 04.06.2013 13:12, Peter Maydell wrote: Newer architectures may only implement the getdents64 syscall, not getdents. Provide an implementation of getdents in terms of getdents64 so that we can run getdents-using targets on a getdents64-only host. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 11/13] pseries: savevm support for PCI host bridge

2013-06-05 Thread Alexey Kardashevskiy
On 05.06.2013 20:00, David Gibson wrote: On Tue, Jun 04, 2013 at 10:21:03PM +1000, Alexey Kardashevskiy wrote: Author: David Gibson da...@gibson.dropbear.id.au This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). I think the PCI

Re: [Qemu-devel] [PATCH 12/13] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-06-05 Thread Alexey Kardashevskiy
On 05.06.2013 20:02, David Gibson wrote: On Tue, Jun 04, 2013 at 10:21:04PM +1000, Alexey Kardashevskiy wrote: From: David Gibson da...@gibson.dropbear.id.au Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 11:49:22AM +0100, Daniel P. Berrange wrote: On Wed, Jun 05, 2013 at 06:42:13PM +0800, Amos Kong wrote: Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance.

Re: [Qemu-devel] [PATCH V13 6/6] hmp: add parameters device and -v for info block

2013-06-05 Thread Stefan Hajnoczi
On Sat, May 25, 2013 at 12:24:46PM +0800, Wenchao Xia wrote: diff --git a/hmp.c b/hmp.c index 2aa832c..a590ace 100644 --- a/hmp.c +++ b/hmp.c @@ -279,10 +279,15 @@ void hmp_info_block(Monitor *mon, const QDict *qdict) { BlockInfoList *block_list, *info; ImageInfo *image_info; +

Re: [Qemu-devel] [PATCH V13 0/6] enhancement for qmp/hmp interfaces of block info

2013-06-05 Thread Stefan Hajnoczi
On Sat, May 25, 2013 at 12:24:40PM +0800, Wenchao Xia wrote: This serial let qmp interface show delaied info, including internal snapshot /backing chain on all block device at runtime, which helps management stack and human user, by retrieving exactly the same info of what qemu saws.

Re: [Qemu-devel] [PATCH v2] linux-user: Allow getdents to be provided by getdents64

2013-06-05 Thread Peter Maydell
On 5 June 2013 11:57, Claudio Fontana claudio.font...@huawei.com wrote: On 04.06.2013 13:12, Peter Maydell wrote: Newer architectures may only implement the getdents64 syscall, not getdents. Provide an implementation of getdents in terms of getdents64 so that we can run getdents-using targets

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize time, and memory_region_destroy at

Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

2013-06-05 Thread Alexey Kardashevskiy
On 05.06.2013 19:55, David Gibson wrote: On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote: On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote: [snip] +static int ics_post_load(void *opaque, int version_id) +{ +int i; +struct ics_state *ics = opaque; + +for

Re: [Qemu-devel] [PATCH 0/2] linux-user: Drop direct use of openat etc syscalls

2013-06-05 Thread Claudio Fontana
On 02.06.2013 00:35, Peter Maydell wrote: The linux-user syscall emulation layer currently supports the openat family of syscalls via two mechanisms: simply calling the corresponding libc functions, and making direct syscalls. Since glibc has supported these functions since at least glibc 2.5,

Re: [Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-06-05 Thread David Gibson
On Wed, Jun 05, 2013 at 08:54:38PM +1000, Alexey Kardashevskiy wrote: On 05.06.2013 19:22, David Gibson wrote: I meant to post my pending patches at the end of last week, but was sidetracked by a minor injury :(. Sigh... What exactly are you going to post? PCI rework? Well until

Re: [Qemu-devel] [PATCH v2] linux-user: Allow getdents to be provided by getdents64

2013-06-05 Thread Claudio Fontana
On 04.06.2013 13:12, Peter Maydell wrote: Newer architectures may only implement the getdents64 syscall, not getdents. Provide an implementation of getdents in terms of getdents64 so that we can run getdents-using targets on a getdents64-only host. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH V2] net: tap: fix NULL dereference when passing invalid parameters to tap

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 01:18:17PM +0800, Jason Wang wrote: This patch forbid the following invalid parameters to tap: 1) fd and vhostfds were specified but vhostfd were not specified 2) vhostfds were specified but fds were not specified 3) fds and vhostfd were specified For 1 and 2,

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Andreas Färber
Am 05.06.2013 12:28, schrieb Michael Tokarev: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about

Re: [Qemu-devel] [PATCH v2] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Stefan Hajnoczi
On Wed, Jun 05, 2013 at 11:00:32AM +0200, Kevin Wolf wrote: Am 05.06.2013 um 10:33 hat Stefan Hajnoczi geschrieben: Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize

Re: [Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

2013-06-05 Thread Stefan Hajnoczi
On Wed, Jun 05, 2013 at 02:13:48PM +0800, Amos Kong wrote: The MAX_VLAN is 4096, currently the vlan filter table has 512 (4096 3) entries, it's wrong. One entry in vlan filter table can indicate 32(1 5) vlans, so the table should have 128 (4096 5) entries. Signed-off-by: Amos Kong

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Peter Maydell
On 5 June 2013 12:10, Michael S. Tsirkin m...@redhat.com wrote: unrealize is not a word in english: The OED says: # unˈrealize, v. # trans. To make unreal; to deprive of reality. with the earliest citation from 1804. so if it seems like the best term (and it does make clear the pairing with

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-05 Thread Amos Kong
On Tue, Jun 04, 2013 at 10:15:41PM -0400, Luiz Capitulino wrote: [CC'ing Amos this time] On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan qiaonuo...@cn.fujitsu.com wrote: I haven't reviewed it yet, but we need introspection support before merging this. Hello Luiz, Is it

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 12:38:35PM +0100, Peter Maydell wrote: On 5 June 2013 12:10, Michael S. Tsirkin m...@redhat.com wrote: unrealize is not a word in english: The OED says: # unˈrealize, v. # trans. To make unreal; to deprive of reality. with the earliest citation from 1804. so

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote: Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug

[Qemu-devel] [BACKPORT qemu-xen 0/3] fixes for 4.3

2013-06-05 Thread Stefano Stabellini
Hi all, this patch series backports few fixes from QEMU to qemu-xen 4.3. The second patch avoid calling main_loop_wait with nonblocking set to 1, so that the select timeout is always as high as possible on Xen. The third patch fixes this PCI passthrough bug:

[Qemu-devel] [BACKPORT qemu-xen 1/3] xen: simplify xen_enabled

2013-06-05 Thread Stefano Stabellini
No need for preprocessor conditionals in xen_enabled: xen_allowed is always defined. upstream-commit-id: 49fa9881b2358e390e9e9466ddde74e995927efa Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff

[Qemu-devel] [BACKPORT qemu-xen 2/3] main_loop: do not set nonblocking if xen_enabled()

2013-06-05 Thread Stefano Stabellini
upstream-commit-id: a7d4207d378069a5bb3175a131e8fdedd39ef97d Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index a3ab384..5314f55 100644 --- a/vl.c +++ b/vl.c @@ -1763,7 +1763,7 @@

[Qemu-devel] [BACKPORT qemu-xen 3/3] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

2013-06-05 Thread Stefano Stabellini
We are currently setting the PCI hole to start at HVM_BELOW_4G_RAM_END, that is 0xf000. Start the PCI hole at 0xe000 instead, that is the same value used by pc_init1 and qemu-xen-traditional. upstream-commit-id: 9f24a8030a70ea4954b5b8c48f606012f086f65f Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 12:38:35PM +0100, Peter Maydell wrote: On 5 June 2013 12:10, Michael S. Tsirkin m...@redhat.com wrote: unrealize is not a word in english: The OED says: # unˈrealize, v. # trans. To make unreal; to deprive of reality. with the earliest citation from 1804. So

[Qemu-devel] [PATCH v2 01/16] qemu-io: Remove unused args_command

2013-06-05 Thread Kevin Wolf
The original intention seems to be something with handling multiple images at once, but this has never been implemented and the only function ever registered is implemented to make everything behave like a global command. Just do that unconditionally now. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v2 02/16] cutils: Support 'P' and 'E' suffixes in strtosz()

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/qemu-common.h | 2 ++ monitor.c | 8 qemu-img.c | 10 ++ tests/qemu-iotests/049.out | 8 util/cutils.c | 4 5

[Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor

2013-06-05 Thread Kevin Wolf
This is a prerequisite for some kind of tests. It involves reorganising the qemu-io code so that the command part can be separated and doesn't pollute the global namespace any more, so we can link it with qemu. v2: - Drop the QMP command, make it HMP only - Minor review comments like typos Kevin

[Qemu-devel] [PATCH v2 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix()

2013-06-05 Thread Kevin Wolf
No reason to implement the same thing multiple times. A nice side effect is that fractional numbers like 0.5M can be used in qemu-io now. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 37 - cmd.h | 1

[Qemu-devel] [PATCH v2 04/16] qemu-io: Handle cvtnum() errors in 'alloc'

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qemu-io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-io.c b/qemu-io.c index 8a719a8..b4f56fc 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -1596,7 +1596,10 @@ static int

[Qemu-devel] [PATCH v2 15/16] qemu-io: Use the qemu version for -V

2013-06-05 Thread Kevin Wolf
Always printing 0.0.1 and never updating the version number wasn't very useful. qemu-io is released with qemu, so using the same version number makes most sense. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 11/16] qemu-io: Move functions for registering and running commands

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 113 - cmd.h | 11 +--- qemu-io-cmds.c | 192 ++--- qemu-io.c | 10 +-- 4 files changed,

[Qemu-devel] [PATCH v2 10/16] qemu-io: Move qemu_strsep() to cutils.c

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 21 - include/qemu-common.h | 1 + util/cutils.c | 21 + 3 files changed, 22 insertions(+), 21 deletions(-) diff --git a/cmd.c b/cmd.c

[Qemu-devel] [PATCH v2 13/16] qemu-io: Move remaining helpers from cmd.c

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile | 2 +- cmd.c | 139 - cmd.h | 14 -- qemu-io-cmds.c | 104 ++ 4 files changed, 105 insertions(+), 154

[Qemu-devel] [PATCH v2 07/16] qemu-io: Factor out qemuio_command

2013-06-05 Thread Kevin Wolf
It's duplicated code. Move it to qemu-io-cmds.c because it's not dependent on any static data of the qemu-io tool. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 43 +-- cmd.h | 3 ++-

[Qemu-devel] [PATCH v2 09/16] qemu-io: Move 'quit' function

2013-06-05 Thread Kevin Wolf
This one only makes sense in the context of the qemu-io tool, so move it to qemu-io.c. Adapt coding style and register it like other commands. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 29 - cmd.h | 2 --

[Qemu-devel] [PATCH v2 14/16] qemu-io: Interface cleanup

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.h | 48 include/qemu-io.h | 46 ++ qemu-io-cmds.c| 14 +++--- qemu-io.c | 7 +++ 4 files changed, 56 insertions(+),

[Qemu-devel] [PATCH v2 08/16] qemu-io: Move 'help' function

2013-06-05 Thread Kevin Wolf
No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 79

[Qemu-devel] [PATCH v2 16/16] Make qemu-io commands available in HMP

2013-06-05 Thread Kevin Wolf
It was decided to not make this command available in QMP in order to make clear that this is not supposed to be a stable API and should be used only for testing and debugging purposes. Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile| 2 +- Makefile.objs | 1 + hmp-commands.hx

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:06, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote: Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all

Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

2013-06-05 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 05:27:25PM +0200, Kevin Wolf wrote: Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 6

Re: [Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-05 Thread Andreas Färber
Am 31.05.2013 15:33, schrieb Luiz Capitulino: On Thu, 30 May 2013 17:07:56 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de Nitpick alarm on. Very welcome :) --- include/qom/cpu.h | 10 ++

Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command

2013-06-05 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 05:27:27PM +0200, Kevin Wolf wrote: diff --git a/cmd.h b/cmd.h index ccf6336..d676408 100644 --- a/cmd.h +++ b/cmd.h @@ -59,7 +59,6 @@ int command(const cmdinfo_t *ci, int argc, char **argv); /* from input.h */ char **breakline(char *input, int *count); -void

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 02:23:03PM +0200, Andreas Färber wrote: Am 05.06.2013 14:06, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote: Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:

Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function

2013-06-05 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 05:27:28PM +0200, Kevin Wolf wrote: No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 79

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-05 Thread Eric Blake
On 06/04/2013 09:58 PM, Wanlong Gao wrote: Add monitor command mem-nodes to show the huge mapped memory nodes locations. Missing a QMP counterpart. Libvirt would probably like to use this command, and providing it HMP-only is not friendly. -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

2013-06-05 Thread Kevin Wolf
Am 05.06.2013 um 14:28 hat Stefan Hajnoczi geschrieben: On Tue, May 28, 2013 at 05:27:25PM +0200, Kevin Wolf wrote: Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io.

Re: [Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands

2013-06-05 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 05:27:31PM +0200, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 113 - cmd.h | 11 +--- qemu-io-cmds.c | 192 ++--- qemu-io.c |

Re: [Qemu-devel] [Qemu-stable] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-06-05 Thread Anthony Liguori
Michael Tokarev m...@tls.msk.ru writes: 04.06.2013 18:23, Anthony Liguori wrote: Andreas Färber afaer...@suse.de writes: [] Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git MAINTAINERS has not been updated with stable branches and maintainers for some time. If not, I'd

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:36, schrieb Michael S. Tsirkin: Anyway, my point was, when moving stuff out of exit, we should also change the signature to the new one - DeviceState* and (unused) Error**. Then we're getting closer to removing the old exit field, and at that point renaming individual hooks -

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len __attribute__((packed)); suspicious usage of packed

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Brad Smith
On 05/06/13 6:28 AM, Michael Tokarev wrote: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Brad Smith
On 05/06/13 6:28 AM, Michael Tokarev wrote: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

[Qemu-devel] [PATCH] cputlb: fix debug logs

2013-06-05 Thread Hervé Poussineau
'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2. Signed-off-by: Hervé Poussineau hpous...@reactos.org --- cputlb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cputlb.c b/cputlb.c index 8c8..1230e9e 100644 --- a/cputlb.c +++ b/cputlb.c

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-05 Thread Anthony Liguori
Wanlong Gao gaowanl...@cn.fujitsu.com writes: Add monitor command mem-nodes to show the huge mapped memory nodes locations. (qemu) info mem-nodes /proc/14132/fd/13: 2ac0-2aaaeac0: node0 /proc/14132/fd/13: 2aaaeac0-2aab2ac0: node1 /proc/14132/fd/14:

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:49, schrieb Richard Henderson: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len

Re: [Qemu-devel] [PATCH 00/16] Make qemu-io commands available in the monitor

2013-06-05 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 05:27:20PM +0200, Kevin Wolf wrote: This is a prerequisite for some kind of tests. It involves reorganising the qemu-io code so that the command part can be separated and doesn't pollute the global namespace any more, so we can link it with qemu. Kevin Wolf (16):

[Qemu-devel] [PATCH v2 05/16] qemu-io: Don't use global bs in command implementations

2013-06-05 Thread Kevin Wolf
Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cmd.c | 6 ++- cmd.h | 8 ++-

[Qemu-devel] [PATCH v2 12/16] qemu-io: Move command_loop() and friends

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- cmd.c | 139 -- cmd.h | 9 qemu-io.c | 139 ++ 3 files changed, 139 insertions(+), 148 deletions(-) diff --git

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Anthony Liguori
Michael Tokarev m...@tls.msk.ru writes: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
On 06/05/2013 06:02 AM, Andreas Färber wrote: So why can't you apply QEMU_PACKED to the whole struct? Because of the contradicting void* alignment attribute of the first field? Actually, that might work. I'll give it a shot on x86_64 and change all of the uses if it does work. r~

[Qemu-devel] [PULL 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-05 Thread Richard Henderson
Reviewing the tcg/aarch64 patch set, and comparing that to existing hosts made me remember that I've wanted to do this for quite some time. Now with two reviews, please pull. r~ The following changes since commit 8819c10b5d55d537d59a0ffd5d623f348fc36c47: Merge remote-tracking branch

[Qemu-devel] [PULL 2/2] tcg: Remove redundant tcg_target_init checks

2013-06-05 Thread Richard Henderson
We've got a compile-time check for the condition in exec/cpu-defs.h. Reviewed-by: Andreas Färber afaer...@suse.de Reviewed-by: liguang lig.f...@cn.fujitsu.com Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 6 -- tcg/i386/tcg-target.c | 6 --

Re: [Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-05 Thread Andreas Färber
Am 31.05.2013 15:48, schrieb Luiz Capitulino: On Thu, 30 May 2013 17:07:58 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Peter Maydell
On 5 June 2013 14:04, Richard Henderson r...@twiddle.net wrote: On 06/05/2013 06:02 AM, Andreas Färber wrote: So why can't you apply QEMU_PACKED to the whole struct? Because of the contradicting void* alignment attribute of the first field? Actually, that might work. I'll give it a shot on

Re: [Qemu-devel] [BACKPORT qemu-xen 0/3] fixes for 4.3

2013-06-05 Thread George Dunlap
On 05/06/13 13:07, Stefano Stabellini wrote: Hi all, this patch series backports few fixes from QEMU to qemu-xen 4.3. The second patch avoid calling main_loop_wait with nonblocking set to 1, so that the select timeout is always as high as possible on Xen. The third patch fixes this PCI

  1   2   3   >