[Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi-device plugged on the virtio-bus. Cc: qemu-sta...@nongnu.org Reported-by: Alexey Kardashevskiy

Re: [Qemu-devel] [Qemu-stable] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-06-12 Thread Stefan Hajnoczi
On Tue, Jun 11, 2013 at 05:59:31PM -0500, mdroth wrote: On Thu, May 30, 2013 at 04:14:46PM +0200, Stefan Hajnoczi wrote: I'm not sure why we check the mode only after invoking popen(3) but we need to close the file pointer. Spotted by Coverity. Cc: Juan Quintela quint...@redhat.com

Re: [Qemu-devel] [0/10] Clean up PCI code to allow for multiple root buses (v2)

2013-06-12 Thread Alexey Kardashevskiy
On 06/06/2013 08:01 PM, Michael S. Tsirkin wrote: On Thu, Jun 06, 2013 at 06:48:44PM +1000, David Gibson wrote: The current PCI subsystem has kind of half-hearted support for multiple independent root buses - aka PCI domains - in the form of the PCIHostBus structure and its domain field.

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-12 Thread Stefan Hajnoczi
On Mon, Jun 03, 2013 at 10:58:31AM +0200, Stefan Hajnoczi wrote: If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1) with error returns in the PCI device .init()

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader (tools/firmware/hvmloader/pci.c:pci_setup) and it looks like it already maps the PCI region to high memory if the PCI bar is 64-bit and the

[Qemu-devel] [PATCH 2/4] KVM: S390: Add dummy kvm_arch_init_irq_routing()

2013-06-12 Thread Alexey Kardashevskiy
The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports it). Provide a dummy function to satisfy this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-s390x/kvm.c |4 1 file

[Qemu-devel] [PATCH 3/4] KVM: PPC: Add dummy kvm_arch_init_irq_routing()

2013-06-12 Thread Alexey Kardashevskiy
From: Scott Wood scottw...@freescale.com The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports it). Provide a dummy function to satisfy this. Unlike x86, PPC does not have one default irqchip, so

[Qemu-devel] [PATCH 0/4 v2] header update request

2013-06-12 Thread Alexey Kardashevskiy
We need new headers for live migration and in-kernel interrupt controller support. However just copying new headers breaks at least PPC so dummy kvm_arch_init_irq_routing() is required as well. Changes since v1: * added dummy functions for ARM and S390 as they are supposed to get broken after

[Qemu-devel] [PATCH 1/4] KVM: ARM: Add dummy kvm_arch_init_irq_routing()

2013-06-12 Thread Alexey Kardashevskiy
The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports it). Provide a dummy function to satisfy this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-arm/kvm.c |4 1 file

[Qemu-devel] [PATCH 4/4] linux-headers: Update to v3.10-rc5

2013-06-12 Thread Alexey Kardashevskiy
This adds symbols required for PPC64 pseries platform features: 1. sPAPR live migration; 2. in-kernel XICS interrupt controller. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- linux-headers/asm-arm/kvm.h | 12 ++-- linux-headers/asm-mips/kvm.h | 138

Re: [Qemu-devel] how to do performance monitor for single VM?

2013-06-12 Thread Stefan Hajnoczi
On Tue, Jun 11, 2013 at 06:06:34PM +0800, Peter Cheung wrote: Dear AllMy name is Peter, i am working on a open source project called Pandora. It is a new admin console for openstack. http://peter.kingofcoders.com/?p=663How to do performance monitor for single VM? For public cloud

Re: [Qemu-devel] virtio-scsi and error handling

2013-06-12 Thread Stefan Hajnoczi
On Tue, Jun 11, 2013 at 01:41:38PM +0200, Hannes Reinecke wrote: I currently playing around with improving SCSI EH, optimizing command aborts and the like. And, supposing it to be a nice testbed, tried to make things work with virtio_scsi. However, looking at the code there I've found

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky evgeny.budilov...@ravellosystems.com --- block/vmdk.c | 28 +---

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky evgeny.budilov...@ravellosystems.com --- block/vmdk.c | 28 +---

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky evgeny.budilov...@ravellosystems.com --- block/vmdk.c | 28 +---

[Qemu-devel] [PATCH v2] s390: Implement dump-guest-memory support for target s390x

2013-06-12 Thread Jens Freimann
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com With this patch dump-guest-memory on s390 produces an ELF formatted, crash-readable dump. In order to implement this, the arch-specific part of dump-guest-memory was added: target-s390x/arch_dump.c contains the whole set of function for

[Qemu-devel] [PATCH v2] s390: support dump-guest-memory on s390

2013-06-12 Thread Jens Freimann
This patch is based on Andreas Färber's qom-cpu branch. Due to new cpu_paging_enabled and get_memory_mapping cpu hooks this patch is now smaller. v2-v3: - fix endian issues - tested on little-endian host Ekaterina Tumanova (1): s390: Implement dump-guest-memory support for target s390x

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Ian Campbell
On Wed, 2013-06-12 at 08:25 +0100, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader (tools/firmware/hvmloader/pci.c:pci_setup) and it looks like it already maps the PCI

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-12 Thread Gerd Hoffmann
On 06/11/13 08:12, Gerd Hoffmann wrote: Hi, +static QEMUCursor *ptr_cursor; +static pixman_image_t *ptr_image; +static intptr_refresh; +static intpx, py, pw, ph; +static intmx, my, mon; +

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-12 Thread Andreas Färber
Am 03.06.2013 15:11, schrieb Stefan Hajnoczi: On Mon, Jun 03, 2013 at 06:26:22AM -0600, Eric Blake wrote: On 06/03/2013 02:58 AM, Stefan Hajnoczi wrote: If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 10:31, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 08:25 +0100, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi-device plugged on

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Alexey Kardashevskiy
On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward

Re: [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

2013-06-12 Thread Andreas Färber
Am 10.06.2013 04:08, schrieb Anthony Liguori: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Sat, Jun 8, 2013 at 7:55 PM, Andreas Färber afaer...@suse.de wrote: Am 08.06.2013 04:22, schrieb Peter Crosthwaite: On Sat, Jun 8, 2013 at 4:18 AM, Andreas Färber afaer...@suse.de wrote:

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This fix a bug with scsi hotplug on

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] ivshmem: add missing error exit(2)

2013-06-12 Thread Michael Tokarev
12.06.2013 11:22, Stefan Hajnoczi wrote: diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index a19a6d6..5658f73 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -735,6 +735,7 @@ static int pci_ivshmem_init(PCIDevice *dev) if (s-shmobj == NULL) {

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Ian Campbell
On Wed, 2013-06-12 at 10:02 +0100, Jan Beulich wrote: On 12.06.13 at 10:31, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 08:25 +0100, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4 v2] header update request

2013-06-12 Thread Michael Tokarev
12.06.2013 11:26, Alexey Kardashevskiy wrote: We need new headers for live migration and in-kernel interrupt controller support. However just copying new headers breaks at least PPC so dummy kvm_arch_init_irq_routing() is required as well. Changes since v1: * added dummy functions for

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-12 Thread Michael Tokarev
05.06.2013 00:23, Alon Levy wrote: [PATCH 1/5] oslib-posix: add qemu_pipe_non_block [PATCH 2/5] use qemu_pipe_non_block [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference [PATCH 5/5] libcacard/vscclient.c: fix

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread George Dunlap
On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader (tools/firmware/hvmloader/pci.c:pci_setup) and it looks like it already maps the PCI region to high memory

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 11:22, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 10:02 +0100, Jan Beulich wrote: On 12.06.13 at 10:31, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 08:25 +0100, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 12:05, George Dunlap george.dun...@eu.citrix.com wrote: On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread George Dunlap
On 12/06/13 11:11, Jan Beulich wrote: On 12.06.13 at 12:05, George Dunlap george.dun...@eu.citrix.com wrote: On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Stefan Hajnoczi
On Wed, Jun 12, 2013 at 11:04:44AM +0300, Evgeny Budilovsky wrote: diff --git a/block/vmdk.c b/block/vmdk.c index 608daaf..1bc944b 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -719,27 +719,41 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags,

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Kevin Wolf
Am 12.06.2013 um 10:04 hat Evgeny Budilovsky geschrieben: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
On Wed, Jun 12, 2013 at 1:17 PM, Stefan Hajnoczi stefa...@redhat.comwrote: On Wed, Jun 12, 2013 at 11:04:44AM +0300, Evgeny Budilovsky wrote: diff --git a/block/vmdk.c b/block/vmdk.c index 608daaf..1bc944b 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -719,27 +719,41 @@ static int

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
On Wed, Jun 12, 2013 at 1:30 PM, Kevin Wolf kw...@redhat.com wrote: Am 12.06.2013 um 10:04 hat Evgeny Budilovsky geschrieben: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G

[Qemu-devel] [PATCH v2] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
the hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images. For example 500G vmdk splitted to 2G chunks. Signed-off-by: Evgeny Budilovsky evgeny.budilov...@ravellosystems.com --- block/vmdk.c | 27 --- 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-12 Thread Alon Levy
05.06.2013 00:23, Alon Levy wrote: [PATCH 1/5] oslib-posix: add qemu_pipe_non_block [PATCH 2/5] use qemu_pipe_non_block [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference [PATCH 5/5]

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Alexey Kardashevskiy
On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Ian Campbell
On Wed, 2013-06-12 at 11:07 +0100, Jan Beulich wrote: On 12.06.13 at 11:22, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 10:02 +0100, Jan Beulich wrote: On 12.06.13 at 10:31, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 08:25 +0100, Jan Beulich

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4 v2] header update request

2013-06-12 Thread Alexey Kardashevskiy
On 06/12/2013 07:27 PM, Michael Tokarev wrote: 12.06.2013 11:26, Alexey Kardashevskiy wrote: We need new headers for live migration and in-kernel interrupt controller support. However just copying new headers breaks at least PPC so dummy kvm_arch_init_irq_routing() is required as well.

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

2013-06-12 Thread Michael Tokarev
06.06.2013 01:22, Peter Maydell wrote: Personally I think a lot of the random rubbish in our .gitignore is bogus and should be removed. Basically anything that's an editor dropping or .patch or TAGS file or similar is a local workflow thing and should be dealt with by setting up a global

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2013 at 09:21:41PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200,

[Qemu-devel] [PATCH] console: Hook QemuConsoles into qom tree

2013-06-12 Thread Gerd Hoffmann
Put them named console[$index] below /backend, so you can list inspect them via QMP. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/console.c b/ui/console.c index 1a9ea93..07d4d63 100644 --- a/ui/console.c +++

[Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Add an optional device parameter to the screendump command. https://bugzilla.redhat.com/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx |6 +++--- hmp.c|3 ++- qapi-schema.json |4 +++- qmp-commands.hx |3 ++- ui/console.c

Re: [Qemu-devel] [PULL 0/1] target-arm queue

2013-06-12 Thread Peter Maydell
Ping! thanks -- PMM On 3 June 2013 15:14, Peter Maydell peter.mayd...@linaro.org wrote: Only one change in this pullreq, but I'm going away for a week and I think the bugfix is worth getting into master before then. Please pull. thanks -- PMM The following changes since commit

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 13:23, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 11:07 +0100, Jan Beulich wrote: As there's no accessible guest kernel command for HVM guests, did you mean to require the guest admin to put something on the command line manually? Yes, as a workaround

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Ian Campbell
On Wed, 2013-06-12 at 12:56 +0100, Jan Beulich wrote: On 12.06.13 at 13:23, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2013-06-12 at 11:07 +0100, Jan Beulich wrote: And then - this might cover Linux, but what about other OSes, namely Windows? True, I'm not sure if/how this

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths

2013-06-12 Thread Michael Tokarev
05.06.2013 00:23, Alon Levy wrote: --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -759,5 +763,6 @@ main( g_io_channel_unref(channel_socket); g_byte_array_unref(socket_to_send); +closesocket(sock); return 0; } This one isn't really needed, -- there's no

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Luiz Capitulino
On Wed, 12 Jun 2013 13:51:17 +0200 Gerd Hoffmann kra...@redhat.com wrote: Add an optional device parameter to the screendump command. https://bugzilla.redhat.com/show_bug.cgi?id=903910 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx |6 +++--- hmp.c|

[Qemu-devel] [PATCH] booke_ppc: limit booke timer to max when timeout overflow

2013-06-12 Thread Bharat Bhushan
Limit watchdog and fit timer to maximum timeout value which qemu timer can support (INT64_MAX). This maximum timeout will be hundreds of years, so limiting to max timeout is pretty safe. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- hw/ppc/ppc_booke.c | 24

[Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead

2013-06-12 Thread Michael Tokarev
The header slirp/slirp.h is an internal header for slirp, and main-loop.c does not use internals from there. Instead, it uses public functions (slirp_update_timeout(), slirp_pollfds_fill() etc) which are declared in qemu/libslirp.h. Including slirp/slirp.h is somewhat dangerous since it

Re: [Qemu-devel] [PATCH 1/3] vhost-scsi: fix k-set_guest_notifiers() NULL dereference

2013-06-12 Thread Paolo Bonzini
Il 11/06/2013 18:58, mdroth ha scritto: iscsi: reorganize iscsi_readcapacity_sync iscsi: simplify freeing of tasks scsi-disk: scsi-block device for scsi pass-through should not be remo… scsi-generic: check the return value of bdrv_aio_ioctl in execute_com… scsi-generic: fix sign extension of

Re: [Qemu-devel] fstrim and cache=none

2013-06-12 Thread Paolo Bonzini
Il 11/06/2013 19:18, Dusty Mabe ha scritto: On Tue, Jun 4, 2013 at 8:01 AM, Dusty Mabe dustym...@gmail.com wrote: On Tue, Jun 4, 2013 at 2:53 AM, Paolo Bonzini pbonz...@redhat.com wrote: Please attach the QEMU command line too. I'll try to reproduce. The command line is below (sorry it's

Re: [Qemu-devel] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 08:36, Michael Tokarev ha scritto: Including slirp/slirp.h is somewhat dangerous since it redefines errno on WIN32, so any file including it may misbehave wrt errno. Unfortunately libslirp isn't self-contained, it needs declaration of struct in_addr, which is provided by

Re: [Qemu-devel] [PATCH 8/9] kvm/openpic: in-kernel mpic support

2013-06-12 Thread Alexander Graf
On 01.05.2013, at 03:48, Scott Wood wrote: Enables support for the in-kernel MPIC that thas been merged into the KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex Graf (along with some other improvements). Note from Alex regarding kvm_irqchip_create(): On x86, one

Re: [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always

2013-06-12 Thread Alexander Graf
On 01.05.2013, at 03:48, Scott Wood wrote: From: Alexander Graf ag...@suse.de On PPC, we don't support MP state. So far it's not necessary and I'm not convinced yet that we really need to support it ever. However, the current idle logic in QEMU assumes that an in-kernel PIC also means

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Gerd Hoffmann
Hi, -{ 'command': 'screendump', 'data': {'filename': 'str'} } +{ 'command': 'screendump', 'data': {'filename': 'str', +'*device' : 'str'} } We can't add new optional parameters to QMP commands because it's currently impossible for mngt apps to discover

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-12 Thread Luiz Capitulino
On Wed, 12 Jun 2013 15:21:20 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, -{ 'command': 'screendump', 'data': {'filename': 'str'} } +{ 'command': 'screendump', 'data': {'filename': 'str', +'*device' : 'str'} } We can't add new optional

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 06:05, George Dunlap ha scritto: On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in hvmloader (tools/firmware/hvmloader/pci.c:pci_setup) and it looks

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 15:23, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/06/2013 06:05, George Dunlap ha scritto: On 12/06/13 08:25, Jan Beulich wrote: On 11.06.13 at 19:26, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I went through the code that maps the PCI MMIO regions in

Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest libfdt

2013-06-12 Thread Paolo Bonzini
Il 10/06/2013 22:13, Peter Crosthwaite ha scritto: Hi Hans, On Fri, Jun 7, 2013 at 12:39 AM, Hans de Goede hdego...@redhat.com wrote: We override libfdt_env.h with our own copy, and the latest libfdt expects libfdt_env.h to define fdt##_t types. This discussion is open on list, and

Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest libfdt

2013-06-12 Thread Peter Maydell
On 12 June 2013 14:55, Paolo Bonzini pbonz...@redhat.com wrote: Il 10/06/2013 22:13, Peter Crosthwaite ha scritto: Hi Hans, On Fri, Jun 7, 2013 at 12:39 AM, Hans de Goede hdego...@redhat.com wrote: We override libfdt_env.h with our own copy, and the latest libfdt expects libfdt_env.h to

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-12 Thread Paolo Bonzini
Il 08/06/2013 22:53, Benjamin Herrenschmidt ha scritto: On Sun, 2013-06-09 at 10:16 +0800, Wenchao Xia wrote: If an page was not received and destination knows that page should exist according to total size, fill it with zero at destination, would it solve the problem? The easiest way to

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 09:49, Jan Beulich ha scritto: #3 should be possible or even the default (would need to check), but #4 is probably a bit harder to do. Perhaps you can use a magic I/O port for the xen platform PV driver, but if you can simply use two PCI windows it would be much simpler because

Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest libfdt

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 10:01, Peter Maydell ha scritto: [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h CCing the crowd. F19, F20 and EPEL6 will all distribute libfdt_env.h by the time 1.6 is out. If this patch is not qemu-stable material, you have my ack too. For clarity, by this patch

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-12 Thread Alexey Kardashevskiy
On 06/12/2013 09:52 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 09:21:41PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-12 Thread Benjamin Herrenschmidt
On Wed, 2013-06-12 at 10:00 -0400, Paolo Bonzini wrote: The only bug we have is not a performance bug related to compression; it's that writing zero pages breaks overcommit. Let's fix that, and only that. Right, do we have a way to madvise throw away these instead ? Or do we have a way to

Re: [Qemu-devel] [PATCH v2] allow reading variable size vmdk descriptor files

2013-06-12 Thread Stefan Hajnoczi
On Wed, Jun 12, 2013 at 02:06:30PM +0300, Evgeny Budilovsky wrote: @@ -719,27 +719,40 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags, int64_t desc_offset) { int ret; -char buf[2048]; +char *buf = NULL; char ct[128];

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Jan Beulich
On 12.06.13 at 16:02, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/06/2013 09:49, Jan Beulich ha scritto: #3 should be possible or even the default (would need to check), but #4 is probably a bit harder to do. Perhaps you can use a magic I/O port for the xen platform PV driver, but if you

[Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X

2013-06-12 Thread Kevin Wolf
The raw-posix driver has code to provide a /dev/cdrom on OS X even though it doesn't really exist. However, since commit c66a6157 the real filename is dismissed after finding it, so opening /dev/cdrom fails. Put the filename back into the options QDict to make this work again. Cc:

[Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-12 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 13c0cc5..1e00bb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -430,6 +430,7 @@ F: hw/isa/pc87312.[hc] sPAPR M: David Gibson

Re: [Qemu-devel] [PATCH qom-cpu 47/59] spapr: Abstract spapr_fix_cpu_dt() with qemu_for_each_cpu()

2013-06-12 Thread Alexey Kardashevskiy
On 06/11/2013 08:12 PM, Andreas Färber wrote: Am 11.06.2013 04:43, schrieb David Gibson: On Sun, Jun 09, 2013 at 09:13:14PM +0200, Andreas F¦rber wrote: Signed-off-by: Andreas F¦rber afaer...@suse.de These days, spapr patches should be CCed to Alexey, instead of me. Please update

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

2013-06-12 Thread Laszlo Ersek
On 06/12/13 13:51, Michael Tokarev wrote: 06.06.2013 01:22, Peter Maydell wrote: Personally I think a lot of the random rubbish in our .gitignore is bogus and should be removed. Basically anything that's an editor dropping or .patch or TAGS file or similar is a local workflow thing and

Re: [Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-12 Thread Alexander Graf
On 12.06.2013, at 16:27, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 13c0cc5..1e00bb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -430,6 +430,7 @@

[Qemu-devel] Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin'

2013-06-12 Thread chandrashekar shastri
Hi All, Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin' Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5

[Qemu-devel] NMI watchdog issue

2013-06-12 Thread chandrashekar shastri
Hi All, We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5 virt-install : 0.600.3 I have followed the below steps to test the NMI watchdog feature

Re: [Qemu-devel] [PATCH v2] allow reading variable size vmdk descriptor files

2013-06-12 Thread Kevin Wolf
Am 12.06.2013 um 13:06 hat Evgeny Budilovsky geschrieben: the hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images. For example 500G vmdk splitted to 2G chunks. Signed-off-by: Evgeny Budilovsky

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread George Dunlap
On 12/06/13 15:19, Jan Beulich wrote: On 12.06.13 at 16:02, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/06/2013 09:49, Jan Beulich ha scritto: #3 should be possible or even the default (would need to check), but #4 is probably a bit harder to do. Perhaps you can use a magic I/O port for

[Qemu-devel] [PULL 02/13] linux-user: Drop direct use of openat etc syscalls

2013-06-12 Thread Peter Maydell
The linux-user syscall emulation layer currently supports the openat family of syscalls via two mechanisms: simply calling the corresponding libc functions, and making direct syscalls. Since glibc has supported these functions since at least glibc 2.5, there's no real need to retain the

[Qemu-devel] [PULL 00/13] tcg-aarch64 queue

2013-06-12 Thread Peter Maydell
Hi. Since the aarch64 patches have been on the list for a while and have got code review but haven't been committed, I thought I'd just organise them into a pullrequest for easy committal. This pullreq includes the couple of linux-user patches which are a prereq for the linux-user code to compile

[Qemu-devel] [PULL 03/13] configure: Drop CONFIG_ATFILE test

2013-06-12 Thread Peter Maydell
Nobody uses the CONFIG_ATFILE test now, so just drop it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net Tested-by: Claudio Fontana claudio.font...@huawei.com Message-id: 1370126121-22975-3-git-send-email-peter.mayd...@linaro.org ---

[Qemu-devel] [PULL 10/13] user-exec.c: aarch64 initial implementation of cpu_signal_handler

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id: 51af4028.5030...@huawei.com Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 12/13] configure: permit compilation on arm aarch64

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com support compiling on aarch64. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Message-id: 51a5c5ed.90...@huawei.com Signed-off-by: Peter

[Qemu-devel] [PULL 07/13] tcg/aarch64: implement AND/TEST immediate pattern

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com add functions to AND/TEST registers with immediate patterns. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Message-id: 51ac9a0c.3090...@huawei.com Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 01/13] linux-user: Allow getdents to be provided by getdents64

2013-06-12 Thread Peter Maydell
Newer architectures may only implement the getdents64 syscall, not getdents. Provide an implementation of getdents in terms of getdents64 so that we can run getdents-using targets on a getdents64-only host. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 04/13] include/elf.h: add aarch64 ELF machine and relocs

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com we will use the 26bit relative relocs in the aarch64 tcg target. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Message-id:

[Qemu-devel] [PULL 13/13] MAINTAINERS: add tcg/aarch64 maintainer

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com Signed-off-by: Claudio Fontana claudio.font...@huawei.com Message-id: 51aca0b2.80...@huawei.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS

[Qemu-devel] [PULL 05/13] tcg/aarch64: implement new TCG target for aarch64

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com add preliminary support for TCG target aarch64. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id: 51a5c596.3090...@huawei.com

[Qemu-devel] [PULL 11/13] tcg/aarch64: implement user mode qemu ld/st

2013-06-12 Thread Peter Maydell
From: Jani Kokkonen jani.kokko...@huawei.com also put aarch64 in the list of archs that do not need an ldscript. Signed-off-by: Jani Kokkoken jani.kokko...@huawei.com Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter

[Qemu-devel] [PULL 06/13] tcg/aarch64: improve arith shifted regs operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com for arith operations, add SUBS, ANDS, ADDS and add a shift parameter so that all arith instructions can make use of shifted registers. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net

[Qemu-devel] [PULL 08/13] tcg/aarch64: implement byte swap operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com implement the optional byte swap operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Message-id: 51ac9a33.9050...@huawei.com Signed-off-by:

[Qemu-devel] [PULL 09/13] tcg/aarch64: implement sign/zero extend operations

2013-06-12 Thread Peter Maydell
From: Claudio Fontana claudio.font...@huawei.com implement the optional sign/zero extend operations with the dedicated aarch64 instructions. Signed-off-by: Claudio Fontana claudio.font...@huawei.com Reviewed-by: Richard Henderson r...@twiddle.net Message-id: 51ac9a58.40...@huawei.com

Re: [Qemu-devel] [0/10] Clean up PCI code to allow for multiple root buses (v2)

2013-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2013 at 05:18:46PM +1000, Alexey Kardashevskiy wrote: On 06/06/2013 08:01 PM, Michael S. Tsirkin wrote: On Thu, Jun 06, 2013 at 06:48:44PM +1000, David Gibson wrote: The current PCI subsystem has kind of half-hearted support for multiple independent root buses - aka PCI

Re: [Qemu-devel] [Qemu-ppc] broken incoming migration

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 10:11, Benjamin Herrenschmidt ha scritto: On Wed, 2013-06-12 at 10:00 -0400, Paolo Bonzini wrote: The only bug we have is not a performance bug related to compression; it's that writing zero pages breaks overcommit. Let's fix that, and only that. Right, do we have a way to

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-06-12 Thread mdroth
On Tue, May 21, 2013 at 05:32:57PM -0500, Michael Roth wrote: When this VMSD was introduced it's version fields were set to sizeof(I6300State), making them essentially random from build to build, version to version. To fix this, we lock in a high version id and low minimum version id to

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 11:25, George Dunlap ha scritto: If you have 4GB of RAM it will end at 0x14000 (or something like that) and that's where the 64-bit window starts. Of course if you have no RAM above the PCI hole, the 64-bit window will start at 0x1. So there's no provision whatsoever

Re: [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always

2013-06-12 Thread Scott Wood
On 06/12/2013 08:04:55 AM, Alexander Graf wrote: On 01.05.2013, at 03:48, Scott Wood wrote: From: Alexander Graf ag...@suse.de On PPC, we don't support MP state. So far it's not necessary and I'm not convinced yet that we really need to support it ever. However, the current idle logic in

Re: [Qemu-devel] virtio-scsi and error handling

2013-06-12 Thread Paolo Bonzini
Il 12/06/2013 03:56, Stefan Hajnoczi ha scritto: On Tue, Jun 11, 2013 at 01:41:38PM +0200, Hannes Reinecke wrote: I currently playing around with improving SCSI EH, optimizing command aborts and the like. And, supposing it to be a nice testbed, tried to make things work with virtio_scsi.

  1   2   >