[Qemu-devel] [PATCH] PPC: Add VSX to hflags

2013-12-18 Thread Alexander Graf
We generate different code depending on whether MSR_VSX is set or clear, so it needs to be part of our hflags too which indicate whether we're still in the same translation block cache bucket. Signed-off-by: Alexander Graf ag...@suse.de --- target-ppc/helper_regs.h | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-12-18 Thread Alexander Graf
On 06.11.2013, at 17:22, Juan Quintela quint...@redhat.com wrote: Paolo Bonzini pbonz...@redhat.com wrote: Il 06/11/2013 14:04, Juan Quintela ha scritto: We want to have all the functions that handle directly the dirty bitmap near. We will change it later. Please move it to exec.c

Re: [Qemu-devel] [PATCH uq/master] kvm: x86: Separately write feature control MSR on reset

2013-12-18 Thread Paolo Bonzini
Il 17/12/2013 20:05, Jan Kiszka ha scritto: If the guest is running in nested mode on system reset, clearing the feature MSR signals the kernel to leave this mode. Recent kernels processes this properly, but leave the VCPU state undefined behind. It is the job of userspace to bring it to a

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:03:24AM +0100, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the

Re: [Qemu-devel] [PATCH -V7 3/3] target-ppc: Fix page table lookup with kvm enabled

2013-12-18 Thread Alexander Graf
On 07.11.2013, at 15:31, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error

Re: [Qemu-devel] [PATCH -V2] kvm: Add a new machine property kvm_type

2013-12-18 Thread Alexander Graf
On 07.11.2013, at 15:27, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Targets like ppc64 support different typed of KVM, one which use hypervisor mode and the other which doesn't. Add a new machine property kvm_type that

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2013-12-18 Thread Michael S. Tsirkin
On Tue, Dec 17, 2013 at 06:56:06PM +0100, Gerd Hoffmann wrote: Hi, We need to change the way we reserve the mmconfig space though. Currently it is marked reserved in the e820 table. Having that overlap with the _CRS region makes windows quite unhappy, we tried that

Re: [Qemu-devel] [PATCH 07/38] memory: make cpu_physical_memory_is_dirty return bool

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 7 ++- include/exec/memory-internal.h | 8 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_get_dirty used only one flag

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: So cpu_physical_memory_get_dirty_flags is not needed anymore Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 2 insertions(+), 7

Re: [Qemu-devel] [PATCH 09/38] memory: set single dirty flags when possible

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 7 --- include/exec/memory-internal.h | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 10/38] memory: cpu_physical_memory_set_dirty_range() always dirty all flags

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: So remove the flag argument and do it directly. After this change, there is nothing else using cpu_physical_memory_set_dirty_flags() so remove it. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

Re: [Qemu-devel] [PATCH 11/38] memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Document it Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cputlb.c | 4 ++-- exec.c | 19 ++- include/exec/memory-internal.h | 40

Re: [Qemu-devel] [PATCH 12/38] memory: use bit 2 for migration

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: For historical reasons it was bit 3. Once there, create a constant to know the number of clients. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory.h | 3 ++- 1 file changed, 2

Re: [Qemu-devel] [PATCH 13/38] memory: make sure that client is always inside range

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 4 1 file changed, 4 insertions(+) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 15/38] memory: cpu_physical_memory_clear_dirty_flag() result is never used

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 14/38] memory: only resize dirty bitmap when memory size increases

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 9996da2..bed5c07 100644 --- a/exec.c +++

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing

Re: [Qemu-devel] [PATCH 16/38] bitmap: Add bitmap_zero_extend operation

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/qemu/bitmap.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index afdd257..1babd5d

Re: [Qemu-devel] [PATCH 17/38] memory: split dirty bitmap into three

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: After all the previous patches, spliting the bitmap gets direct. Note: For some reason, I have to move DIRTY_MEMORY_* definitions to the beginning of memory.h to make compilation work. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 12:18 PM, Daniel P. Berrange wrote: On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 19/38] memory: unfold cpu_physical_memory_set_dirty() in its only user

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag()

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 21/38] memory: make cpu_physical_memory_get_dirty() the main function

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: And make cpu_physical_memory_get_dirty_flag() to use it. It used to be the other way around. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 36

Re: [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Paolo Bonzini
Il 17/12/2013 20:38, Anthony Liguori ha scritto: On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 00:26, Anthony Liguori ha scritto: Sharing hot plug code is a good thing. Making hotplug a qdev-level concept seems like a bad thing to me. Can you

Re: [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:25 PM, Juan Quintela wrote: Now all functions use the same wording that bitops/bitmap operations Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 2 +- include/exec/memory-internal.h | 6 +++---

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Paolo Bonzini
Il 18/12/2013 11:24, Orit Wasserman ha scritto: For live migration we need the sync option (async ignores O_SYNC and O_DIRECT sadly), will it be supported? or will it be the default? Since this is bypassing the client kernel FS I/O layer question around support of things like

Re: [Qemu-devel] [qemu-kvm RHEL7 PATCH] Add support statement to -help output

2013-12-18 Thread Paolo Bonzini
Il 04/12/2013 19:42, Eduardo Habkost ha scritto: Bugzilla: 972773 Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272 Add support statement to -help output, reporting direct qemu-kvm usage as unsupported by Red Hat, and advising users to use libvirt instead.

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 11:00 schrieb Orit Wasserman owass...@redhat.com: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:11 PM, Peter Lieven wrote: Am 18.12.2013 um 11:00 schrieb Orit Wasserman owass...@redhat.com: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote:

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen: build on ARM

2013-12-18 Thread Ian Campbell
On Tue, 2013-12-17 at 17:31 +, Stefano Stabellini wrote: Collection of fixes to build QEMU with Xen support on ARM: - use xenstore_read_fe_uint64 to retrieve the page-ref (xenfb); - use xen_pfn_t instead of unsigned long in xenfb; - unsigned long/xenpfn_t in xen_remove_from_physmap; - add

[Qemu-devel] Enabling Travis for the QEMU Mirror?

2013-12-18 Thread Alex Bennée
Hi, Now we have a .travis.yml merged into master can we enable Travis to run in the QEMU mirror on github (https://github.com/qemu/qemu)? I'm happy to talk who ever controls that repo through the process but it's fairly simple. From the commit: This adds a build matrix definition for

Re: [Qemu-devel] Enabling Travis for the QEMU Mirror?

2013-12-18 Thread Peter Maydell
On 18 December 2013 11:32, Alex Bennée alex.ben...@linaro.org wrote: Now we have a .travis.yml merged into master can we enable Travis to run in the QEMU mirror on github (https://github.com/qemu/qemu)? I'm happy to talk who ever controls that repo through the process That would be Anthony, I

Re: [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: This operation is way faster than doing it bit by bit. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 16 ++-- 1 file changed, 6 insertions(+), 10

Re: [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We were setting a range of bits, so use bitmap_set(). Note: xen has always been wrong, and should have used start instead of addr from the beginning. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

Re: [Qemu-devel] [PATCH 27/38] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: All uses except one really want the other meaning. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cputlb.c | 3 ++- exec.c | 6 +++---

Re: [Qemu-devel] [PATCH 28/38] memory: make cpu_physical_memory_reset_dirty() take a length parameter

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We have an end parameter in all the callers, and this make it coherent with the rest of cpu_physical_memory_* functions, that also take a length parameter. Once here, move the start/end calculation to tlb_reset_dirty_range_all() as we don't need it

Re: [Qemu-devel] [PATCH 29/38] memory: cpu_physical_memory_set_dirty_tracking() should return void

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 10 -- 1 file changed, 4 insertions(+), 6

[Qemu-devel] sniffing traffic between virtual machines

2013-12-18 Thread Alexander Binun
Hello Friends, Thanks for your hints; they really helped us! We are trying to monitor the traffic (network packets etc) between VMs in KVM. We succeeded to get the address of the system call table (see http://syprog.blogspot.co.il/2011/10/hijack-linux-system-calls-part-iii.html) and

Re: [Qemu-devel] [PATCH 30/38] memory: split cpu_physical_memory_* functions to its own include

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: All the functions that use ram_addr_t should be here. Signed-off-by: Juan Quintela quint...@redhat.com --- cputlb.c | 1 + exec.c | 1 + include/exec/memory-internal.h | 76

Re: [Qemu-devel] Enabling Travis for the QEMU Mirror?

2013-12-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 18 December 2013 11:32, Alex Bennée alex.ben...@linaro.org wrote: Now we have a .travis.yml merged into master can we enable Travis to run in the QEMU mirror on github (https://github.com/qemu/qemu)? I'm happy to talk who ever controls that repo through

Re: [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We were clearing a range of bits, so use bitmap_clear(). Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH 31/38] memory: unfold memory_region_test_and_clear()

2013-12-18 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We are going to update the bitmap directly Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index e0acbc5..0e8c8b5 100644 ---

Re: [Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth

2013-12-18 Thread Alexander Graf
On 08.11.2013, at 23:18, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: On 08/11/13 03:20, Alexander Graf wrote: On 11.10.2013, at 12:53, Mark Cave-Aylandmark.cave-ayl...@ilande.co.uk wrote: OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI configuration space

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen: build on ARM

2013-12-18 Thread Stefano Stabellini
On Wed, 18 Dec 2013, Ian Campbell wrote: On Tue, 2013-12-17 at 17:31 +, Stefano Stabellini wrote: Collection of fixes to build QEMU with Xen support on ARM: - use xenstore_read_fe_uint64 to retrieve the page-ref (xenfb); - use xen_pfn_t instead of unsigned long in xenfb; - unsigned

Re: [Qemu-devel] [PATCH v2 0/5] Monitor commands for object-add/del

2013-12-18 Thread Igor Mammedov
On Tue, 17 Dec 2013 12:25:59 +0100 Paolo Bonzini pbonz...@redhat.com wrote: These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. v1-v2: fix mistyped underscores in qapi-schema.json Paolo Bonzini (5): rng:

Re: [Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups

2013-12-18 Thread Alexander Graf
On 17.12.2013, at 14:22, Jens Freimann jf...@linux.vnet.ibm.com wrote: Alex, this is mostly bugfixes and cleanup patches, except for Patch 4/8 which implements a SIGP order code for cpu start. Thanks, applied all to s390-next. Alex

Re: [Qemu-devel] [PATCH V7 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-12-18 Thread Stefan Hajnoczi
On Wed, Dec 18, 2013 at 10:13:40AM +0800, Wenchao Xia wrote: Hello, any comments? I hope to have a new year gift It's in the queue, I hope to review it this week.

[Qemu-devel] [PULL 0/8] s390 patch queue 2013-12-18

2013-12-18 Thread Alexander Graf
Hi Blue / Aurelien / Anthony, This is my current patch queue for s390. Please pull. Alex The following changes since commit f46e720a82ccdf1a521cf459448f3f96ed895d43: Laszlo Ersek (1): qemu_opts_parse(): always check return value are available in the git repository at:

[Qemu-devel] [PULL 1/8] s390x/kvm: Fix diagnose handling.

2013-12-18 Thread Alexander Graf
From: Cornelia Huck cornelia.h...@de.ibm.com The instruction intercept handler for diagnose used only the displacement when trying to calculate the function code. This is only correct for base 0, however; we need to perform a complete base/displacement address calculation and use bits 48-63 as

[Qemu-devel] [PULL 4/8] s390x/kvm: Fix coding style in handle_sigp()

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com To make scripts/checkpatch.pl happy for the following patches, the coding style in handle_sigp() has to be fixed first. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 2/8] s390x/kvm: Removed duplicated SIGP defines

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com The SIGP order defines are also available in cpu.h, so there is no need to re-define them in kvm.c. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 3/8] s390x/kvm: Removed s390_store_status stub

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com The SIGP order STORE STATUS AT ADDRESS will be handled in kernel space, so we do not need the stub in QEMU anymore. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 5/8] s390x/kvm: Implemented SIGP START

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com This patch adds the missing START order to the SIGP instruction handler. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com Signed-off-by:

[Qemu-devel] [PULL 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com If SIGP is called with an unknown order code, it has to return CC1 instead of CC3 and set the invalid order bit in the return status. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by:

[Qemu-devel] [PULL 8/8] s390x/ioinst: CHSC has to set a condition code

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com I missed to set the CC in the CHSC instruction when I refactored the CC setting in the IO instructions with the following commit: 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 s390/ioinst: Moved the CC setting to the IO instruction handlers

[Qemu-devel] [PULL 6/8] s390x/kvm: Simplified the calculation of the SIGP order code

2013-12-18 Thread Alexander Graf
From: Thomas Huth th...@linux.vnet.ibm.com We've already got a helper function for calculating the base/displacement of RS formatted instructions, so we can get rid of the manual calculation of the SIGP order code. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v2 3/3] device_tree: qemu_fdt_setprop: Fixup error reporting

2013-12-18 Thread Alexander Graf
On 11.11.2013, at 09:16, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com There are a mix of usages of the qemu_fdt_* API calls, some which wish to assert and abort QEMU on failure and some of which wish to do their own error handling. The latter in

Re: [Qemu-devel] [PATCH v4 resend] rdma: rename 'x-rdma' = 'rdma'

2013-12-18 Thread Eric Blake
On 12/17/2013 10:43 PM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com As far as we can tell, all known bugs have been fixed: 1. Parallel migrations are working 2. IPv6 migration is working 3. virt-test is working +++ b/qapi-schema.json @@ -671,10 +671,9

Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation

2013-12-18 Thread Stefan Hajnoczi
On Tue, Dec 17, 2013 at 05:33:37AM -0500, Jeff Cody wrote: If there is a dirty log file to be replayed in a VHDX image, it is replayed in .vhdx_open(). However, if the file is opened read-only, then a somewhat cryptic error message results. This adds a more helpful error message for the

Re: [Qemu-devel] [PATCH] target-ppc: remove MMUCFG SPR from POWER7/8 class

2013-12-18 Thread Alexander Graf
On 18.11.2013, at 09:29, Alexey Kardashevskiy a...@ozlabs.ru wrote: PowerISA 2.06/2.07 put MMUCFG SPR to E (embedded) category so remove it from POWER7/8 class as it is S (server) category. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru POWER7 inherited this from the other 64bit cores.

Re: [Qemu-devel] [PATCH V4] char: restore read callback on a reattached (hotplug) chardev

2013-12-18 Thread Gal Hammer
On 18/12/2013 07:35, Amit Shah wrote: As far as I could tell the pty backend doesn't suffer from this issue. That's why I didn't change anything there. pty_chr_update_read_handler() calls pty_chr_state(), which calls remove_fd_in_watch(). Yes, but the pty_chr_update_read_handler() isn't

[Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev

2013-12-18 Thread Gal Hammer
Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred from the host to the guest (e.g. via the virtio-serial port).

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Paolo Bonzini
Il 11/12/2013 12:04, Gal Hammer ha scritto: Michael, True, I haven't figure it out yet, but the current status is that recover from sleep doesn't work. As far as I can tell it could be either: 1. piix4_reset shouldn't be call on resume. 2. memory_region_set_enabled (called in

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-18 Thread Tom Musta
On 12/17/2013 7:52 AM, Peter Maydell wrote: On 17 December 2013 13:42, Alexander Graf ag...@suse.de wrote: Softfloat really isn't my area of expertise and I'd prefer to see these patches go in through a different tree :). Peter, do you want to take care of this patch and Add

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Paolo Bonzini
Il 11/12/2013 10:21, Gal Hammer ha scritto: Fix a bug that was introduced in commit c046e8c4. QEMU fails to resume from suspend mode (S3). Signed-off-by: Gal Hammer gham...@redhat.com --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/piix4.c

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 09:29:54AM +0100, Stefan Hajnoczi wrote: On Tue, Dec 10, 2013 at 10:23:41PM +, Alex Bennée wrote: stefa...@redhat.com writes: On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: 2013/11/15 Stefan Hajnoczi stefa...@gmail.com On Thu, Nov

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-18 Thread Peter Maydell
On 18 December 2013 14:21, Tom Musta tommu...@gmail.com wrote So it would seem to make the most sense to go back and do what I had done originally -- separate the softfloat fixes into their own patch set and make the VSX and P7 patches dependent on those. Agree? Yeah, that works. But really

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread ronnie sahlberg
On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman owass...@redhat.com wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for

Re: [Qemu-devel] [PATCH] qdev-monitor: device_add crashes on non-device driver name, fix

2013-12-18 Thread Markus Armbruster
Ping? arm...@redhat.com writes: From: Markus Armbruster arm...@redhat.com Watch this: $ upstream-qemu -nodefaults -S -display none -monitor stdio QEMU 1.7.50 monitor - type 'help' for more information (qemu) device_add rng-egd

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-18 Thread Markus Armbruster
Ping? arm...@redhat.com writes: From: Markus Armbruster arm...@redhat.com Obvious cleanups possible since we no longer have the special case of a non-qdevified controller. v2: * Dropped PATCH 1/10 ide: Break all non-qdevified controllers Andreas qdevified them since; thanks! * Series

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Gal Hammer
On 18/12/2013 16:19, Paolo Bonzini wrote: The PIIX spec says that during S3 the chipset provides Shadow registers for standard AT write only registers to save and restore system state information These are just for the 825x (DMA controller, PIC, PIT). We do not emulate them and our BIOS does

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Michael S. Tsirkin
On Wed, Dec 18, 2013 at 03:22:59PM +0100, Paolo Bonzini wrote: Il 11/12/2013 10:21, Gal Hammer ha scritto: Fix a bug that was introduced in commit c046e8c4. QEMU fails to resume from suspend mode (S3). Signed-off-by: Gal Hammer gham...@redhat.com --- hw/acpi/piix4.c | 1 - 1 file

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-18 Thread Tom Musta
On 12/18/2013 8:35 AM, Peter Maydell wrote: On 18 December 2013 14:21, Tom Musta tommu...@gmail.com wrote So it would seem to make the most sense to go back and do what I had done originally -- separate the softfloat fixes into their own patch set and make the VSX and P7 patches dependent on

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-18 Thread Andreas Färber
I had a brief look at this series. Dropping redundant fields certainly sounds good and after the lengthy QOM'ifications of IDE devices we seem to no longer break any devices, but whether to check for device or BlockDriverState sounds more like a block topic to me... Regards, Andreas Am

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 11:36:52 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 20:38, Anthony Liguori ha scritto: On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 00:26, Anthony Liguori ha scritto: Sharing hot plug code is a good thing.

Re: [Qemu-devel] [PATCH] qdev-monitor: device_add crashes on non-device driver name, fix

2013-12-18 Thread Andreas Färber
Am 18.12.2013 15:54, schrieb Markus Armbruster: Ping? Already queued on qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Sorry, did the patch processing offline on a train. ;) Thanks, Andreas arm...@redhat.com writes: From: Markus Armbruster arm...@redhat.com Watch this:

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-18 Thread Peter Maydell
On 18 December 2013 15:31, Tom Musta tommu...@gmail.com wrote: OK makes sense. I will fold the bug fix back into this series and re-publish. If you can keep all the softfloat patches in one PPC series and all at the beginning of the series that would also assist. thanks -- PMM

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Gal Hammer
On 18/12/2013 16:22, Paolo Bonzini wrote: Il 11/12/2013 10:21, Gal Hammer ha scritto: Fix a bug that was introduced in commit c046e8c4. QEMU fails to resume from suspend mode (S3). Signed-off-by: Gal Hammer gham...@redhat.com --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Paolo Bonzini
Il 18/12/2013 16:48, Igor Mammedov ha scritto: Hotplugging a device is a special case of plugging a device. If a bus or device only supports cold-plug, that can be done using bc-allow_hotplug = false or dc-hotpluggable = false. Do we need per instance ability to set hotpluggable property?

[Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function

2013-12-18 Thread Stefan Hajnoczi
Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8 (qdev: Drop misleading qdev_free() function). The qbus_free() function removes the child from the namespace and decrements the reference count. It does not, however, guarantee to free the child since the refcount may still be

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Paolo Bonzini
Il 18/12/2013 16:59, Gal Hammer ha scritto: Note this is not the APIC base address, that one is 80h on the ISA bridge (function 0). You're changing the behavior for 80h on the power management function, which is function 3. The register is PMBA—POWER MANAGEMENT BASE ADDRESS and it is indeed

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Michael S. Tsirkin
On Wed, Dec 18, 2013 at 04:48:09PM +0100, Igor Mammedov wrote: On Wed, 18 Dec 2013 11:36:52 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 20:38, Anthony Liguori ha scritto: On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 00:26,

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Marcel Apfelbaum
On Wed, 2013-12-18 at 17:22 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 03:22:59PM +0100, Paolo Bonzini wrote: Il 11/12/2013 10:21, Gal Hammer ha scritto: Fix a bug that was introduced in commit c046e8c4. QEMU fails to resume from suspend mode (S3). Signed-off-by: Gal

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Michael S. Tsirkin
On Wed, Dec 18, 2013 at 06:27:12PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 17:22 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 03:22:59PM +0100, Paolo Bonzini wrote: Il 11/12/2013 10:21, Gal Hammer ha scritto: Fix a bug that was introduced in commit c046e8c4. QEMU

Re: [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function

2013-12-18 Thread Andreas Färber
Am 18.12.2013 17:15, schrieb Stefan Hajnoczi: Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8 (qdev: Drop misleading qdev_free() function). The qbus_free() function removes the child from the namespace and decrements the reference count. It does not, however, guarantee to

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 18:26:07 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 18, 2013 at 04:48:09PM +0100, Igor Mammedov wrote: On Wed, 18 Dec 2013 11:36:52 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 17/12/2013 20:38, Anthony Liguori ha scritto: On Tue, Dec 17,

[Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr()

2013-12-18 Thread Stefan Hajnoczi
Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3). This simplifies the code since we no longer have to play games to distinguish NULL from using (null). gcc extension haters will also be happy that ?: was dropped. Suggested-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Paolo Bonzini
- Messaggio originale - Da: Michael S. Tsirkin m...@redhat.com A: marcel a marce...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com, Gal Hammer gham...@redhat.com, seab...@seabios.org, qemu-devel@nongnu.org Inviato: Mercoledì, 18 dicembre 2013 17:33:06 Oggetto: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 16:59:02 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 18/12/2013 16:48, Igor Mammedov ha scritto: Hotplugging a device is a special case of plugging a device. If a bus or device only supports cold-plug, that can be done using bc-allow_hotplug = false or

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Marcel Apfelbaum
On Wed, 2013-12-18 at 18:33 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 06:27:12PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 17:22 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 03:22:59PM +0100, Paolo Bonzini wrote: Il 11/12/2013 10:21, Gal Hammer ha

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Marcel Apfelbaum
On Wed, 2013-12-18 at 11:34 -0500, Paolo Bonzini wrote: - Messaggio originale - Da: Michael S. Tsirkin m...@redhat.com A: marcel a marce...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com, Gal Hammer gham...@redhat.com, seab...@seabios.org, qemu-devel@nongnu.org Inviato:

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-18 Thread Michael S. Tsirkin
On Wed, Dec 18, 2013 at 11:34:14AM -0500, Paolo Bonzini wrote: - Messaggio originale - Da: Michael S. Tsirkin m...@redhat.com A: marcel a marce...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com, Gal Hammer gham...@redhat.com, seab...@seabios.org, qemu-devel@nongnu.org

Re: [Qemu-devel] [PATCH v2 0/5] Monitor commands for object-add/del

2013-12-18 Thread Luiz Capitulino
On Tue, 17 Dec 2013 12:25:59 +0100 Paolo Bonzini pbonz...@redhat.com wrote: These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. v1-v2: fix mistyped underscores in qapi-schema.json Applied to the qmp branch,

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 15:42 schrieb ronnie sahlberg ronniesahlb...@gmail.com: On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman owass...@redhat.com wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013

[Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails

2013-12-18 Thread Corey Bryant
This fixes a bug where we weren't exiting if seccomp_init() failed. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index cf07869..b7c1253 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c

[Qemu-devel] [PULL 11/13] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-18 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com Add two commands that are the monitor counterparts of -object. The commands have the same Visitor-based implementation, but use different kinds of visitors so that the HMP command has a DWIM string-based syntax, while the QMP variant accepts a stricter

  1   2   3   >