Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema

2014-02-18 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 17/02/2014 23:30, Eric Blake ha scritto: | Oops - we lost the ## header before add_client. Sounds like a | followup patch might be called for, unless you are okay tweaking | the pull request. Yeah, I can do that with qemu-trivial. Paolo

Re: [Qemu-devel] [PATCH v20 18/26] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-02-18 Thread Chunyan Liu
2014-02-18 3:01 GMT+08:00 Eric Blake ebl...@redhat.com: On 02/11/2014 11:33 PM, Chunyan Liu wrote: sheepdog.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/sheepdog.c | 101

[Qemu-devel] [RFC PATCH v2 00/12] mc: fault tolerante through micro-checkpointing

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Changes since v1: 1. Re-based against Juan's improved migration_bitmap performance changes 2. Overhauled RDMA support to prepare for better usage of RDMA in other parts of the QEMU code base (such as storage). 3. Fix for netlink issues that failed to

[Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com We also later export these statistics over QMP for better monitoring of micro-checkpointing as the workload changes. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- arch_init.c | 34 -- 1 file changed, 28

[Qemu-devel] [RFC PATCH v2 07/12] mc: introduce additional QMP statistics for micro-checkpointing

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com MC provides a lot of new information, including the same RAM statistics that ordinary migration does, so we centralize a lot of that printing code into a common function so that the QMP printing statements don't get duplicated too much. We also introduce

[Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Wiki: http://wiki.qemu.org/Features/MicroCheckpointing Github: g...@github.com:hinesmr/qemu.git, 'mc' branch NOTE: This is a direct copy of the QEMU wiki page for the convenience of the review process. Since this series very much in flux, instead of

[Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com During micro-checkpointing, the VCPUs get repeatedly paused and resumed. We need to not freak out when the VM begins micro-checkpointing. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- cpus.c| 9 -

[Qemu-devel] [RFC PATCH v2 11/12] mc: introduce new capabilities to control micro-checkpointing

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com New capabilities include the use of RDMA acceleration, use of network buffering, and keepalive support, as documented in patch #1. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- qapi-schema.json | 36 +++- 1 file

[Qemu-devel] [RFC PATCH v2 08/12] mc: core logic

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This implements the core logic, all described in the first patch (docs/mc.txt). Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- migration-checkpoint.c | 1565 1 file changed, 1565 insertions(+)

[Qemu-devel] [RFC PATCH v2 04/12] mc: support custom page loading and copying

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Just as RDMA has custom routines for saving memory, this provides RDMA with custom routines for loading and copying memory as well. Micro-checkpointing needs this support to avoid modifying the arch_init.c as little as possible while stilling being able

[Qemu-devel] [RFC PATCH v2 09/12] mc: configure and makefile support

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Self-explanatory. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- Makefile.objs | 1 + configure | 45 + 2 files changed, 46 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index

[Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This patch sets up the initial changes to the migration state machine and prototypes to be used by the checkpointing code to interact with the state machine so that we can later handle failure and recovery scenarios. Signed-off-by: Michael R. Hines

[Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com This exposes a QMP command that allows the management software or policy to control the frequency of micro-checkpointing. Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- hmp-commands.hx | 16 +++- hmp.c| 6 ++ hmp.h

[Qemu-devel] [RFC PATCH v2 12/12] mc: activate and use MC if requested

2014-02-18 Thread mrhines
From: Michael R. Hines mrhi...@us.ibm.com Once the initial migration has completed, we kickoff the migration_thread, which never dies. Additionally, we register load/save functions for MC which allow us to inform the destination that we are requesting a micro-checkpointing session without needing

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-18 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 05:44:55PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: qtest_init() cannot use exec*p() to launch QEMU since the exec*p() functions take an argument array while qtest_init() takes char *extra_args. Therefore we execute /bin/sh -c

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 06:00:03PM +0100, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 17/02/2014 16:44, Stefan Hajnoczi ha scritto: } +static void sigabrt_handler(int signo) +{ +qtest_end(); +} + void qtest_quit(QTestState *s) { int

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 05:49:31PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: +/* Catch SIGABRT to clean up on g_assert() failure */ +sigact = (struct sigaction){ +.sa_handler = sigabrt_handler, +.sa_flags = SA_RESETHAND, +};

Re: [Qemu-devel] [PATCH v3 0/4] X86/KVM: enable Intel MPX for KVM

2014-02-18 Thread Paolo Bonzini
Il 22/01/2014 13:03, Paolo Bonzini ha scritto: Il 22/01/2014 06:29, Liu, Jinsong ha scritto: These patches are version 3 to enalbe Intel MPX for KVM. Version 1: * Add some Intel MPX definiation * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features enable/disable * vmx and msr

Re: [Qemu-devel] [RFC PATCH v2 00/12] mc: fault tolerante through micro-checkpointing

2014-02-18 Thread Li Guang
Hi, Michael this patch-set will break normal build(without --enable-mc): migration.c: In function ‘migrate_rdma_pin_all’: migration.c:564: error: ‘MIGRATION_CAPABILITY_X_RDMA_PIN_ALL’ undeclared (first use in this function) migration.c:564: error: for each function it appears in.) Thanks! Li

Re: [Qemu-devel] [PATCH v3 0/4] X86/KVM: enable Intel MPX for KVM

2014-02-18 Thread Liu, Jinsong
Paolo Bonzini wrote: Il 22/01/2014 13:03, Paolo Bonzini ha scritto: Il 22/01/2014 06:29, Liu, Jinsong ha scritto: These patches are version 3 to enalbe Intel MPX for KVM. Version 1: * Add some Intel MPX definiation * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features

Re: [Qemu-devel] [PATCH v2] RFC: Add blockdev-del QMP command

2014-02-18 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 12.02.2014 um 18:36 hat Ian Main geschrieben: This is the sister command to blockdev-add. In Fam's example he uses the drive_del HMP command to clean up but it would be much nicer to have a way to do this via QMP. Signed-off-by: Ian Main

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-02-18 Thread Peter Maydell
On 18 February 2014 00:36, Brad Smith b...@comstyle.com wrote: Just one issue... just curious why my last name is missing from the commit? Ah, we've run into a bug in patchwork. I downloaded your patch: http://patchwork.ozlabs.org/patch/299656/ but patchwork reconstructs patch mboxes from its

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Peter Maydell
On 18 February 2014 01:02, Andreas Färber afaer...@suse.de wrote: Shouldn't 1/3 and 3/3 be included in 1.7.1 as guest-triggerable bugs? There's no qemu-sta...@nongnu.org in the commit message. That's up to whoever maintains stable, I guess. I have no objection. thanks -- PMM

Re: [Qemu-devel] Cortex-M3: reading NVIC registers causes segfaults

2014-02-18 Thread Peter Maydell
On 18 February 2014 01:14, Andreas Färber afaer...@suse.de wrote: While first_cpu may help Andreas in his local copy for STM32, that assumption is not okay in general. The Vybrid VF6 has both a GIC and an NVIC, so our NVIC code should not make assumptions which CPU it can access. Do you mean

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-18 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Mon, Feb 17, 2014 at 05:44:55PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: qtest_init() cannot use exec*p() to launch QEMU since the exec*p() functions take an argument array while qtest_init() takes char

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Mon, Feb 17, 2014 at 05:49:31PM +0100, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: +/* Catch SIGABRT to clean up on g_assert() failure */ +sigact = (struct sigaction){ +.sa_handler = sigabrt_handler,

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

2014-02-18 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 11:58:11AM -0500, Vlad Yasevich wrote: On 02/17/2014 11:56 AM, Eric Blake wrote: On 02/17/2014 09:52 AM, Eric Blake wrote: On 02/16/2014 07:27 PM, Amos Kong wrote: Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't filter out VLAN-tagged

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Stefan Hajnoczi stefa...@redhat.com writes: The QEMU process stays running if the test case fails. This patch fixes the leak by installing a SIGABRT signal handler which invokes qtest_end(). In order to make that work for assertion failures

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Mon, Feb 17, 2014 at 06:00:03PM +0100, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 17/02/2014 16:44, Stefan Hajnoczi ha scritto: } +static void sigabrt_handler(int signo) +{ +qtest_end(); +} +

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 10:05, Stefan Hajnoczi ha scritto: SIGABRT is normally synchronous enough: it's sent by abort(). But of course, nothing stops the user from kill -ABRT. Or GLib from calling abort() in some place where an attempt to reenter it crashes burns. Not sure I'd care, but I'm pretty

[Qemu-devel] [PATCH v2 1/2] include/qemu/crc32c.h: Rename include guards to match filename

2014-02-18 Thread Will Newton
Signed-off-by: Will Newton will.new...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/crc32c.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/crc32c.h b/include/qemu/crc32c.h index 56d1c3b..dafb6a1 100644 ---

[Qemu-devel] [PATCH v2 0/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-18 Thread Will Newton
This series adds support for the AArch32 CRC32 instructions added in ARMv8. Will Newton (2): include/qemu/crc32c.h: Rename include guards to match filename target-arm: Add support for AArch32 ARMv8 CRC32 instructions configure | 2 +- include/qemu/crc32c.h | 4 ++--

[Qemu-devel] [PATCH v2 2/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-18 Thread Will Newton
Add support for AArch32 CRC32 and CRC32C instructions added in ARMv8. The CRC32-C implementation used is the built-in qemu implementation and The CRC-32 implementation is from zlib. This requires adding zlib to LIBS to ensure it is linked for the linux-user binary. Signed-off-by: Will Newton

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Andreas Färber
Am 18.02.2014 10:46, schrieb Peter Maydell: On 18 February 2014 01:02, Andreas Färber afaer...@suse.de wrote: Shouldn't 1/3 and 3/3 be included in 1.7.1 as guest-triggerable bugs? There's no qemu-sta...@nongnu.org in the commit message. That's up to whoever maintains stable, I guess. I have

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Daniel P. Berrange
On Tue, Feb 18, 2014 at 11:07:53AM +0100, Paolo Bonzini wrote: Il 18/02/2014 10:05, Stefan Hajnoczi ha scritto: SIGABRT is normally synchronous enough: it's sent by abort(). But of course, nothing stops the user from kill -ABRT. Or GLib from calling abort() in some place where an attempt

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-18 Thread Gerd Hoffmann
On Mo, 2014-02-17 at 15:33 -0500, Kevin O'Connor wrote: On Mon, Feb 17, 2014 at 11:09:48AM -0500, Gabriel L. Somlo wrote: On Fri, Feb 07, 2014 at 04:37:58PM +0100, Paolo Bonzini wrote: Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: On Wed, Feb 05, 2014 at 08:02:25PM -0500, Kevin O'Connor

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 11:17, Daniel P. Berrange ha scritto: Yes, SIGABRT is synchronous for all purposes. So the only danger is that g_string_free() or g_free() could fail while we're in g_assert(false). But they don't, which makes sense because they are totally unrelated to g_assert() and

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 11:05, Markus Armbruster ha scritto: Yes, SIGABRT is synchronous for all purposes. So the only danger is that g_string_free() or g_free() could fail while we're in g_assert(false). But they don't, which makes sense because they are totally unrelated to g_assert() and

Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage

2014-02-18 Thread Dr. David Alan Gilbert
* mrhi...@linux.vnet.ibm.com (mrhi...@linux.vnet.ibm.com) wrote: From: Michael R. Hines mrhi...@us.ibm.com We also later export these statistics over QMP for better monitoring of micro-checkpointing as the workload changes. snip @@ -548,9 +568,11 @@ static int ram_save_block(QEMUFile *f,

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Michael S. Tsirkin
On Tue, Feb 18, 2014 at 02:38:40AM +, Zhanghaoyu (A) wrote: Hi, all The VM will get stuck for a while(about 6s for a VM with 20GB memory) when attaching a pass-through PCI card to the non-pass-through VM for the first time. The reason is that the host will build the whole VT-d

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 11:38, Michael S. Tsirkin ha scritto: What if you detach and re-attach? Is it fast then? If yes this means the issue is COW breaking that occurs with get_user_pages, not translation as such. Try hugepages with prealloc - does it help? I agree it's either COW breaking or

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-18 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 18/02/2014 11:05, Markus Armbruster ha scritto: Yes, SIGABRT is synchronous for all purposes. So the only danger is that g_string_free() or g_free() could fail while we're in g_assert(false). But they don't, which makes sense because they are

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Michael S. Tsirkin
On Tue, Feb 18, 2014 at 11:42:19AM +0100, Paolo Bonzini wrote: Il 18/02/2014 11:38, Michael S. Tsirkin ha scritto: What if you detach and re-attach? Is it fast then? If yes this means the issue is COW breaking that occurs with get_user_pages, not translation as such. Try hugepages with

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Zhanghaoyu (A)
Hi, all The VM will get stuck for a while(about 6s for a VM with 20GB memory) when attaching a pass-through PCI card to the non-pass-through VM for the first time. The reason is that the host will build the whole VT-d GPA-HPA DMAR page-table, which needs a lot of time, and during this

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 11:51, Michael S. Tsirkin ha scritto: I agree it's either COW breaking or (similarly) locking pages that the guest hasn't touched yet. You can use prealloc or -rt mlock=on to avoid this problem. Paolo Or the new shared flag - IIRC shared VMAs don't do COW either. Only if

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Peter Maydell
On 18 February 2014 10:13, Andreas Färber afaer...@suse.de wrote: Am 18.02.2014 10:46, schrieb Peter Maydell: On 18 February 2014 01:02, Andreas Färber afaer...@suse.de wrote: Shouldn't 1/3 and 3/3 be included in 1.7.1 as guest-triggerable bugs? There's no qemu-sta...@nongnu.org in the commit

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

2014-02-18 Thread Igor Mammedov
On Mon, 17 Feb 2014 13:02:18 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Feb 17, 2014 at 11:33:23AM +0100, Igor Mammedov wrote: On Sun, 16 Feb 2014 17:53:45 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Michael S. Tsirkin
On Tue, Feb 18, 2014 at 12:05:19PM +0100, Paolo Bonzini wrote: Il 18/02/2014 11:51, Michael S. Tsirkin ha scritto: I agree it's either COW breaking or (similarly) locking pages that the guest hasn't touched yet. You can use prealloc or -rt mlock=on to avoid this problem. Paolo Or the

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 12:09, Peter Maydell ha scritto: No, we've had that topic before: It's your job as submitter and maintainer to flag that appropriately in the commit message, as per QEMU Summit 2012. I don't think this workflow works. I have no idea what stable's criteria are, and if you rely

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-18 Thread Zhanghaoyu (A)
What if you detach and re-attach? Is it fast then? If yes this means the issue is COW breaking that occurs with get_user_pages, not translation as such. Try hugepages with prealloc - does it help? I agree it's either COW breaking or (similarly) locking pages that the guest hasn't touched

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Peter Maydell
On 18 February 2014 11:16, Paolo Bonzini pbonz...@redhat.com wrote: Il 18/02/2014 12:09, Peter Maydell ha scritto: No, we've had that topic before: It's your job as submitter and maintainer to flag that appropriately in the commit message, as per QEMU Summit 2012. I don't think this

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Add support for AArch32ARMv8 CRC32 instructionss

2014-02-18 Thread Alex Bennée
will.new...@linaro.org writes: Add support for AArch32 CRC32 and CRC32C instructions added in ARMv8. The CRC32-C implementation used is the built-in qemu implementation and The CRC-32 implementation is from zlib. This requires adding zlib to LIBS to ensure it is linked for the linux-user

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 12:22, Peter Maydell ha scritto: There isn't really a standard criterion. It's up to each maintainer to be stricter or looser on what goes to stable. My criteria for ARM in the past has typically been there's a new release every three months, anything that got past the release

Re: [Qemu-devel] [RFC 0/9] generate dynamic _CRS for motherboard resources

2014-02-18 Thread Michael S. Tsirkin
On Tue, Feb 18, 2014 at 12:10:27PM +0100, Igor Mammedov wrote: On Mon, 17 Feb 2014 13:02:18 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Feb 17, 2014 at 11:33:23AM +0100, Igor Mammedov wrote: On Sun, 16 Feb 2014 17:53:45 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-18 Thread Kevin Wolf
Am 17.02.2014 um 18:12 hat Eric Blake geschrieben: On 02/17/2014 07:45 AM, Kevin Wolf wrote: Instead of making the backing file contents visible again after a discard request, set the zero flag if possible (i.e. on version = 3). Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH] block/iscsi: fix deadlock on scsi check condition

2014-02-18 Thread Peter Lieven
the retry logic was broken because the complete status of the task structure was not reset. this resulted in an infinite loop retrying the command over and over. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |9 - 1 file changed, 8

[Qemu-devel] [PATCH V18 02/12] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Create the structure holding the quorum settings and write the minimal block driver instanciation boilerplate. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 31 +++ 1

[Qemu-devel] [PATCH V18 08/12] quorum: Add quorum_invalidate_cache().

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net We really want that live migration works with quorum so implement quorum_invalidate_cache(). Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff

[Qemu-devel] [PATCH V18 03/12] quorum: Add quorum_aio_writev and its dependencies.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Writes are mirrored num_children times on num_children devices. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 103 + 1 file changed, 103 insertions(+) diff --git a/block/quorum.c

[Qemu-devel] [PATCH V18 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Quorum is a block filter mirroring writes to num_children children. For reads quorum reads each children and does a vote. If more than vote_threshold versions are identical the quorum is reached and this winning version is returned to the guest. So quorum

[Qemu-devel] [PATCH V18 09/12] quorum: Add quorum_co_flush().

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Makes a vote to select error if any. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 28 1 file changed, 28 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index d924055..1007dfc 100644 ---

[Qemu-devel] [PATCH V18 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net This is used to activate quorum snapshot. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/quorum.c b/block/quorum.c

[Qemu-devel] [PATCH V18 11/12] quorum: Add quorum_open() and quorum_close().

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Example of command line: -drive if=virtio,driver=quorum,\ children.0.file.filename=1.raw,\ children.0.node-name=1.raw,\ children.0.driver=raw,\ children.1.file.filename=2.raw,\ children.1.node-name=2.raw,\ children.1.driver=raw,\

[Qemu-devel] [PATCH V18 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net qemu_iovec_compare() will be used to compare IOs vectors in quorum blkverify mode. The patch extracts these functions in order to factorize the code. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com ---

[Qemu-devel] [PATCH V18 00/12] Quorum block filter

2014-02-18 Thread Benoît Canet
Hi, This is the latest version of the quorum block filter. Since the patch fixing the external_snapshot_prepare QDECREF(options) brain damage that I introduced earlier quorum works fine in every cases. in V18: Address all Max comments [Max] Fix sample quorum command line usage

[Qemu-devel] [PATCH V18 06/12] quorum: Add quorum mechanism.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net This patchset enables the core of the quorum mechanism. The num_children reads are compared to get the majority version and if this version exists more than threshold times the guest won't see the error at all. If a block is corrupted or if an error occurs

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-18 Thread Stefano Stabellini
On Thu, 13 Feb 2014, Peter Maydell wrote: On 10 February 2014 16:47, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 2b2449f7e467957778ca006904471b231dc0ac8e: Merge remote-tracking branch 'remotes/borntraeger/tags/kvm-s390-20140131' into staging (2014-02-04

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Alexander Graf
On 02/18/2014 12:22 PM, Peter Maydell wrote: On 18 February 2014 11:16, Paolo Bonzini pbonz...@redhat.com wrote: Il 18/02/2014 12:09, Peter Maydell ha scritto: No, we've had that topic before: It's your job as submitter and maintainer to flag that appropriately in the commit message, as per

[Qemu-devel] [PATCH V18 12/12] quorum: Add unit test.

2014-02-18 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/081 | 95 ++ tests/qemu-iotests/081.out | 34 + tests/qemu-iotests/group | 1 + 3 files changed, 130 insertions(+)

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 13:16, Stefano Stabellini ha scritto: It looks like that this series breaks disk unplug (hw/ide/piix.c:pci_piix3_xen_ide_unplug). I bisected it and the problem is caused by: commit 5e95494380ecf83c97d28f72134ab45e0cace8f9 Author: Igor Mammedov imamm...@redhat.com Date: Wed Feb

Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close().

2014-02-18 Thread Benoît Canet
The Tuesday 18 Feb 2014 à 12:06:57 (+0800), Fam Zheng wrote : On Thu, 02/13 10:09, Benoît Canet wrote: The Wednesday 12 Feb 2014 à 23:06:38 (+0100), Benoît Canet wrote : +static void quorum_close(BlockDriverState *bs) +{ +BDRVQuorumState *s = bs-opaque; +int i; + +

[Qemu-devel] [PATCH] kvm: fix kvm_set_migration_log() behavior

2014-02-18 Thread Vincent KHERBACHE
The test (!!(mem-flags KVM_MEM_LOG_DIRTY_PAGES) == enable) is wrong because the condition is valid when enable = 0 and current dirty log memory flag is set. As a consequence kvm_log_global_stop() does not stop the KVM dirty log tracking: kvm_set_migration_log(0) didn't do its job. So instead I

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Peter Maydell
On 18 February 2014 12:17, Alexander Graf ag...@suse.de wrote: On 02/18/2014 12:22 PM, Peter Maydell wrote: My criteria for ARM in the past has typically been there's a new release every three months, anything that got past the release testing process for release N is sufficiently

[Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased)

2014-02-18 Thread Greg Kurz
On Fri, 14 Feb 2014 12:59:49 +0100 Andreas Färber afaer...@suse.de wrote: Hi, [...] It might've helped if Rusty had actually used our scripts/get_maintainer.pl script to CC people. While Anthony seems to have reviewed some patches (usually Reviewed-by should be before the final

[Qemu-devel] [PATCH 3/8] hw/net/virtio-net: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/net/virtio-net.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

[Qemu-devel] [PATCH 6/8] hw/scsi/virtio-scsi: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/scsi/virtio-scsi.c | 33 + 1 file

[Qemu-devel] [PATCH 5/8] hw/block/virtio-blk: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/block/virtio-blk.c | 35 ++- 1 file

[Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au virtio data structures are defined as target endian, which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this. Meanwhile, create a hook for little endian ppc (and potentially ARM).

Re: [Qemu-devel] [PATCH] block/iscsi: fix deadlock on scsi check condition

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 13:08, Peter Lieven ha scritto: the retry logic was broken because the complete status of the task structure was not reset. this resulted in an infinite loop retrying the command over and over. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c

[Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains headers. [ ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ]

[Qemu-devel] [PATCH V18 05/12] quorum: Add quorum_aio_readv.

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Add code to do num_children reads in parallel and cleanup the structures afterwards. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 39 ++- 1 file changed, 38

[Qemu-devel] [PATCH 4/8] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/virtio/virtio-balloon.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Andreas Färber
Am 18.02.2014 12:16, schrieb Paolo Bonzini: Il 18/02/2014 12:09, Peter Maydell ha scritto: No, we've had that topic before: It's your job as submitter and maintainer to flag that appropriately in the commit message, as per QEMU Summit 2012. I don't think this workflow works. I have no

[Qemu-devel] [PATCH 7/8] hw/char/virtio-serial-bus: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
From: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Anthony Liguori aligu...@us.ibm.com --- hw/char/virtio-serial-bus.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH 8/8] hw/9pfs/virtio_9p_device: use virtio wrappers to access headers.

2014-02-18 Thread Greg Kurz
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p. Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-device.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-18 Thread Stefano Stabellini
On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 13:16, Stefano Stabellini ha scritto: It looks like that this series breaks disk unplug (hw/ide/piix.c:pci_piix3_xen_ide_unplug). I bisected it and the problem is caused by: commit 5e95494380ecf83c97d28f72134ab45e0cace8f9

Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing

2014-02-18 Thread Dr. David Alan Gilbert
* mrhi...@linux.vnet.ibm.com (mrhi...@linux.vnet.ibm.com) wrote: From: Michael R. Hines mrhi...@us.ibm.com Wiki: http://wiki.qemu.org/Features/MicroCheckpointing Github: g...@github.com:hinesmr/qemu.git, 'mc' branch NOTE: This is a direct copy of the QEMU wiki page for the convenience of

Re: [Qemu-devel] Fwd: Trying to write a new device / virtio-i2c ?

2014-02-18 Thread Alex David
2014-02-17 17:11 GMT+01:00 Paolo Bonzini pbonz...@redhat.com: Il 17/02/2014 16:33, Alex David ha scritto: If you need more than one bus, you need a new device exposing the I2C bus, besides the new sensor devices. USB-I2C could be one such device. So let me see if I understood

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Alexander Graf
On 02/18/2014 01:37 PM, Peter Maydell wrote: On 18 February 2014 12:17, Alexander Graf ag...@suse.de wrote: On 02/18/2014 12:22 PM, Peter Maydell wrote: My criteria for ARM in the past has typically been there's a new release every three months, anything that got past the release testing

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Andreas Färber
Am 18.02.2014 13:51, schrieb Alexander Graf: Traditionally what I've done is to reply to patches that I consider stable material and nag the maintainer about CCing it. After a while people got so afraid of my emails that they started doing the CC themselves :). But in case of the integrator

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Alexander Graf
On 02/18/2014 01:53 PM, Andreas Färber wrote: Am 18.02.2014 13:51, schrieb Alexander Graf: Traditionally what I've done is to reply to patches that I consider stable material and nag the maintainer about CCing it. After a while people got so afraid of my emails that they started doing the CC

Re: [Qemu-devel] [PATCH v4] qdev: Keep global allocation counter per bus

2014-02-18 Thread Andreas Färber
Am 18.02.2014 13:54, schrieb Markus Armbruster: Peter, can you merge this patch? v2 is from December 20, and the changes since then have been limited to the commit message. In case Peter doesn't want to take it directly: Andreas, would you be willing to take it through your tree? It's not

Re: [Qemu-devel] [PATCH v4] qdev: Keep global allocation counter per bus

2014-02-18 Thread Markus Armbruster
Peter, can you merge this patch? v2 is from December 20, and the changes since then have been limited to the commit message. In case Peter doesn't want to take it directly: Andreas, would you be willing to take it through your tree? It's not really QOM, but your tree is the closest fit I can

[Qemu-devel] [PATCH V18 07/12] quorum: Add quorum_getlength().

2014-02-18 Thread Benoît Canet
From: Benoît Canet ben...@irqsave.net Check that every bs file returns the same length. Otherwise, return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 26

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-18 Thread Peter Maydell
On 18 February 2014 12:44, Andreas Färber afaer...@suse.de wrote: What especially annoys me here is that Peter wants to play on Anthony's level on the project but is openly ignoring both our stable releases as a concept (we wouldn't need a release in the first place if we don't care about it

Re: [Qemu-devel] Fwd: Trying to write a new device / virtio-i2c ?

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 13:48, Alex David ha scritto: 2014-02-17 17:11 GMT+01:00 Paolo Bonzini pbonz...@redhat.com mailto:pbonz...@redhat.com: Il 17/02/2014 16:33, Alex David ha scritto: If you need more than one bus, you need a new device exposing the I2C bus,

Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access

2014-02-18 Thread Cornelia Huck
On Tue, 18 Feb 2014 13:38:54 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: From: Rusty Russell ru...@rustcorp.com.au This is based on a simpler patch by Anthony Liguouri, which only handled the vring accesses. We also need some drivers to access these helpers, eg. for data which contains

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-18 Thread Igor Mammedov
On Tue, 18 Feb 2014 12:45:29 + Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 18 Feb 2014, Paolo Bonzini wrote: Il 18/02/2014 13:16, Stefano Stabellini ha scritto: It looks like that this series breaks disk unplug (hw/ide/piix.c:pci_piix3_xen_ide_unplug). I

Re: [Qemu-devel] [PULL 00/20] acpi,pc,pci fixes and enhancements

2014-02-18 Thread Paolo Bonzini
Il 18/02/2014 13:45, Stefano Stabellini ha scritto: Disk unplug: hw/ide/piix.c:pci_piix3_xen_ide_unplug (see the beginning of the email :-P). It is called by hw/xen/xen_platform.c:platform_fixed_ioport_writew, in response to the guest writing to a magic ioport specifically to unplug the emulated

Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access

2014-02-18 Thread Greg Kurz
On Tue, 18 Feb 2014 14:08:35 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 18 Feb 2014 13:38:54 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: From: Rusty Russell ru...@rustcorp.com.au This is based on a simpler patch by Anthony Liguouri, which only handled the vring

  1   2   3   >