From: Gonglei arei.gong...@huawei.com
Set all static qdev properties' descriptions to object property's
description.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
v5 - v4:
1. add some improvements by Michael's suggtion, Thanks. (Michael)
2. add 'Reviewed-by' tag (Paolo, Michael, Eric)
v4 - v3:
1. rebase on qom-next tree (Andreas)
2. fix memory leak in PATCH 2, move object_property_set_description calling
in
From: Gonglei arei.gong...@huawei.com
Add a new description field to DevicePropertyInfo.
The descriptions can serve as documentation in the code,
and they can be used to provide better help. For example:
$./qemu-system-x86_64 -device virtio-blk-pci,?
Before this patch:
From: Gonglei arei.gong...@huawei.com
The descriptions can serve as documentation in the code,
and they can be used to provide better help.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Gonglei
From: Gonglei arei.gong...@huawei.com
The legacy_name is useless now, the better help
information provided by description field of property.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Gonglei
From: Gonglei arei.gong...@huawei.com
The descriptions can serve as documentation in the code,
and they can be used to provide better help.
Copy property descriptions when copying alias properties.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Markus
Copying stable and maintainers.
Chris Spiegel chris.spie...@cypherpath.com writes:
If an error occurs in bdrv_snapshot_delete_by_id_or_name(), err is
freed. If err is not set to NULL before calling
bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on
error, and will be
From: Gonglei arei.gong...@huawei.com
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/pci/pcie.c | 2 +-
1 file changed,
On 7 October 2014 05:02, Greg Bellows greg.bell...@linaro.org wrote:
Right, we need the macros to do string concatenation so they have to be
macros. That combination occurs 3 times from a quick look. I agree that it
may be cumbersome to try and invent a name.
Anything to do on this?
Make
On 7 October 2014 04:16, Greg Bellows greg.bell...@linaro.org wrote:
On 6 October 2014 10:53, Peter Maydell peter.mayd...@linaro.org wrote:
switch (excp_idx) {
case EXCP_FIQ:
-if (irq_can_hyp (env-cp15.hcr_el2 HCR_FMO)) {
-return true;
+if
On 7 October 2014 06:06, Greg Bellows greg.bell...@linaro.org wrote:
On 6 October 2014 11:19, Peter Maydell peter.mayd...@linaro.org wrote:
On 30 September 2014 22:49, Greg Bellows greg.bell...@linaro.org wrote:
From: Fabian Aggeler aggel...@ethz.ch
Prepare ARMCPRegInfo to support
On Tue, Sep 30, 2014 at 10:43:09AM +0800, Chen, Tiejun wrote:
On 2014/9/29 18:01, Michael S. Tsirkin wrote:
On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote:
On 2014/9/3 9:40, Kay, Allen M wrote:
-Original Message-
From: Chen, Tiejun
Sent: Monday, September 01, 2014
On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote:
**errp)
{
uint32_t value = 0;
XenHostPCIDevice hdev;
int r = 0, num;
r = xen_host_pci_device_get(hdev, 0, 0, 0x02, 0);
if (!r) {
value = hdev.device_id;
num =
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
From: Gonglei arei.gong...@huawei.com
Determine whether a given bootindex exists or not.
If exists, we report an error.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
bootdevice.c| 15 +++
include/sysemu/sysemu.h | 1 +
2
From: Gonglei arei.gong...@huawei.com
Introduce del_boot_device_path() to clean up fw_cfg content when
hot-unplugging a device that refers to a bootindex or update a
existent devcie's bootindex.
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Chenliang chenlian...@huawei.com
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Device should be removed from global boot list when
it is hot-unplugged.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
bootdevice.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bootdevice.c
[Quoted material edited somewhat to provide better context]
Paolo Bonzini pbonz...@redhat.com writes:
Il 02/10/2014 16:59, Markus Armbruster ha scritto:
Andreas Färber afaer...@suse.de writes:
Am 02.10.2014 um 16:21 schrieb Markus Armbruster:
Andreas Färber afaer...@suse.de writes:
Am
From: Gonglei arei.gong...@huawei.com
Since the bootindex property is a QOM property and not a qdev property
now, we must alias it explicitly for virtio-net-pci, as well as CCW and
s390-virtio.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Remove bootindexA/B form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
when we remove bootindex form qdev.property to qom.property,
we can use those functions set/get bootindex property for all
correlative devices. Meanwhile set the initial value of
bootindex to -1.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
At present, isa_ne2000 device does not support to boot
os,
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
Makefile.target | 2 +-
bootdevice.c| 142
include/sysemu/sysemu.h | 1 +
vl.c
From: Gonglei arei.gong...@huawei.com
On this way, we can assure the new bootindex take effect
during vm rebooting. Meanwhile set the initial value of
bootindex to -1.
Because ide devcies's unit property maybe
do not initialize when set_bootindex function is called,
so that we don't know its
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
* Cristian Klein (cristian.kl...@cs.umu.se) wrote:
On 04 Oct 2014, at 4:21 , Dr. David Alan Gilbert dgilb...@redhat.com wrote:
I've updated our github at:
https://github.com/orbitfp7/qemu/tree/wp3-postcopy
to have this version.
and it corresponds to the tag:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
At present, nvma cannot boot. However, it provides already
a bootindex property, so change bootindex to qom for nvma
device, but not call add_boot_device_path.
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/block/nvme.c | 44
From: Gonglei arei.gong...@huawei.com
Add the function of updating bootindex about fw_boot_order list
in add_boot_device_path(). We should delete the old one if a
device has existed in global fw_boot_order list.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann
From: Gonglei arei.gong...@huawei.com
When set a device's bootindex to -1, we remove it from global
fw_boot_order list.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
bootdevice.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/bootdevice.c
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
The function may be called by qmp command, we should
report error message to the caller.
Signed-off-by: Gonglei arei.gong...@huawei.com
---
bootdevice.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bootdevice.c b/bootdevice.c
index
From: Gonglei arei.gong...@huawei.com
Since the bootindex property is a QOM property and not a qdev property
now, we must alias it explicitly for virtio-blk-pci, as well as CCW and
s390-virtio.
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/s390x/s390-virtio-bus.c | 2 ++
From: Gonglei arei.gong...@huawei.com
On this way, we can assure the new bootindex take effect
during vm rebooting.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
bootdevice.c | 2 ++
hw/block/fdc.c | 3 ---
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Because usb-storage rely on scsi-disk which is created
in
From: Gonglei arei.gong...@huawei.com
We must assure that the changed bootindex can take effect
when guest is rebooted. So we introduce fw_cfg_machine_reset(),
which change the fw_cfg file's bootindex data using the new
global fw_boot_order list.
Signed-off-by: Chenliang chenlian...@huawei.com
From: Gonglei arei.gong...@huawei.com
Add a qom property with the same name 'bootindex',
when we remove it form qdev property, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by:
From: Gonglei arei.gong...@huawei.com
Changes since v10:
1. add handler for virtio-blk-pci/s390/ccw in PATCH 28.
2. add especial bootidnex setter/getter functions for usb-storage
device in PATCH 29.
3. add bootindex qom property for nvma and ne2k_isa devices,
avoid regrassion in PATCH
From: Gonglei arei.gong...@huawei.com
Remove bootindex form qdev property to qom, things will
continue to work just fine, and we can use qom features
which are not supported by qdev property.
Signed-off-by: Gonglei arei.gong...@huawei.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
---
On Mon, Oct 06, 2014 at 04:49:57PM +0200, Paolo Bonzini wrote:
Even though hw/i386/pc.c tries to compute a valid loading address for the
initrd, close to the top of RAM, this does not take into account other
data that is malloced into that memory by SeaBIOS.
Luckily we can easily look at the
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
+/* These are ORable flags */
... make them an enum.
OK, will do - I'd generally tended to avoid using enum for things
that were ORable where the combinations weren't themselves
On Fri, Oct 03, 2014 at 07:07:57PM +0200, Andrea Arcangeli wrote:
We run out of 32bits in vm_flags, noop change for 64bit archs.
Signed-off-by: Andrea Arcangeli aarca...@redhat.com
---
fs/proc/task_mmu.c | 4 ++--
include/linux/huge_mm.h | 4 ++--
include/linux/ksm.h | 4 ++--
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
+#ifndef WIN32
+if (rd) {
+how = SHUT_RD;
+}
+
+if (wr) {
+how = rd ? SHUT_RDWR : SHUT_WR;
+}
+
+#else
+/* Untested */
+if
Il 07/10/2014 10:01, Markus Armbruster ha scritto:
Automatic arrayification isn't about array-valued properties, it's a
convenience feature for creating a bunch of properties with a common
type, accessors and so forth, named in a peculiar way: foo[0],
foo[1], ...
The feature saves the
Il 07/10/2014 10:46, Michael S. Tsirkin ha scritto:
On Mon, Oct 06, 2014 at 04:49:57PM +0200, Paolo Bonzini wrote:
Even though hw/i386/pc.c tries to compute a valid loading address for the
initrd, close to the top of RAM, this does not take into account other
data that is malloced into that
Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto:
+if (exitcode LOADVM_EXITCODE_QUITPARENT) {
+DPRINTF(loadvm_handlers_state_main: End of loop with
QUITPARENT);
+exitcode = ~LOADVM_EXITCODE_QUITPARENT;
+exitcode = LOADVM_EXITCODE_QUITLOOP;
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto:
+if (exitcode LOADVM_EXITCODE_QUITPARENT) {
+DPRINTF(loadvm_handlers_state_main: End of loop with
QUITPARENT);
+exitcode = ~LOADVM_EXITCODE_QUITPARENT;
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
+mis-postcopy_ram_state);
+if (mis-postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) {
+/*
+ * Where a migration had postcopy enabled (and thus went
On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote:
MADV_USERFAULT is a new madvise flag that will set VM_USERFAULT in the
vma flags. Whenever VM_USERFAULT is set in an anonymous vma, if
userland touches a still unmapped virtual address, a sigbus signal is
sent instead of
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote:
MADV_USERFAULT is a new madvise flag that will set VM_USERFAULT in the
vma flags. Whenever VM_USERFAULT is set in an anonymous vma, if
userland touches a still unmapped
On Tue, Oct 07, 2014 at 11:46:04AM +0100, Dr. David Alan Gilbert wrote:
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote:
MADV_USERFAULT is a new madvise flag that will set VM_USERFAULT in the
vma flags. Whenever
From: Jens Freimann jf...@linux.vnet.ibm.com
Sync headers with 3.17-rc7
Acked-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
---
linux-headers/asm-mips/kvm_para.h |6 +-
From: David Hildenbrand d...@linux.vnet.ibm.com
Until now, when a s390 cpu was stopped or halted, the number of running
CPUs was tracked in a global variable. This was problematic for migration,
so Jason came up with a per-cpu running state.
As it turns out, we want to track the full logical
From: Thomas Huth th...@linux.vnet.ibm.com
This patch provides the cpu save information for dumps and later life
migration and enables migration of the CPU state. The code is based on
earlier work from Christian Borntraeger and Jason Herne.
Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com
Here's what I currently have on
git://github.com/cohuck/qemu s390-next
A headers update, cpu state handling in qemu and migration, and a
vhost-scsi-ccw bugfix. The gdb patch needs further discussion.
I plan to send a pull request later this week.
Cornelia Huck (1):
s390x/virtio-ccw: fix
From: David Hildenbrand d...@linux.vnet.ibm.com
This patch makes sure that halting a cpu and stopping a cpu are two different
things. Stopping a cpu will also set the cpu halted - this is needed for common
infrastructure to work (note that the stop and stopped flag cannot be used for
our purpose
From: David Hildenbrand d...@linux.vnet.ibm.com
We need to synchronize registers after a reset has been performed. The
current code does that in qemu_system_reset(), load_normal_reset() and
modified_clear_reset() for all vcpus. After SIGP (INITIAL) CPU RESET,
this needs to be done for the
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Tue, Oct 07, 2014 at 11:46:04AM +0100, Dr. David Alan Gilbert wrote:
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote:
MADV_USERFAULT is a new madvise flag that will
From: David Hildenbrand d...@linux.vnet.ibm.com
This patch reuses kvm_s390_reset_vcpu() to get rid of some CONFIG_KVM and
CONFIG_USER_ONLY ifdefs in cpu.c.
In order to get rid of CONFIG_USER_ONLY, kvm_s390_reset_vcpu() has to provide a
dummy implementation - the two definitions are moved to the
The vhost-scsi-ccw backend is of type VHostSCSICcw, not VirtIOSCSICcw.
This fixes a segfault when invoking
qemu-system-s390x -device vhost-scsi-ccw,?
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
---
hw/s390x/virtio-ccw.c |2 +-
On Mon, Sep 22, 2014 at 02:20:09PM +0300, Michael S. Tsirkin wrote:
On Fri, Sep 19, 2014 at 04:42:59PM +0800, zhanghailiang wrote:
On 2014/9/19 15:34, zhanghailiang wrote:
On 2014/9/19 7:17, Andrew Jones wrote:
Replace all the fprintf(stderr, ...) calls with error_report.
Also make sure
Il 07/10/2014 12:00, Dr. David Alan Gilbert ha scritto:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
+#ifndef WIN32
+if (rd) {
+how = SHUT_RD;
+}
+
+if (wr) {
+how = rd ? SHUT_RDWR : SHUT_WR;
+}
On Fri, Oct 03, 2014 at 07:08:00PM +0200, Andrea Arcangeli wrote:
There's one constraint enforced to allow this simplification: the
source pages passed to remap_anon_pages must be mapped only in one
vma, but this is not a limitation when used to handle userland page
faults with MADV_USERFAULT.
Il 07/10/2014 12:29, Dr. David Alan Gilbert ha scritto:
You mean something like this (untested) ?
if (mis-postcopy_ram_state != POSTCOPY_RAM_INCOMING_NONE) {
if (mis-postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) {
/*
* Where a migration had postcopy
From: David Hildenbrand d...@linux.vnet.ibm.com
Let QEMU propagate the cpu state to kvm. If kvm doesn't yet support it, it is
silently ignored as kvm will still handle the cpu state itself in that case.
The state is not synced back, thus kvm won't have a chance to actively modify
the cpu state.
Replace all the fprintf(stderr, ...) calls with error_report.
Also make sure exit() consistently uses the error code 1. A few calls
used -1. While at it cleanup some indentation in the printf argument
lists.
Signed-off-by: Andrew Jones drjo...@redhat.com
---
v3: fix indentation of printf
On Tue, Oct 07, 2014 at 12:01:02PM +0100, Dr. David Alan Gilbert wrote:
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Tue, Oct 07, 2014 at 11:46:04AM +0100, Dr. David Alan Gilbert wrote:
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
On Fri, Oct 03, 2014 at 07:07:58PM +0200,
* Paolo Bonzini (pbonz...@redhat.com) wrote:
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
+/*
+ * Don't break host-page chunks up with queue items
+ * so only unqueue if,
+ * a) The last item came from the queue anyway
+ * b)
On Mon, 6 Oct 2014 16:51:53 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
This makes it simpler to keep the SSDT byte-for-byte identical for a
given machine type, which is a goal we want to have for 2.2 and newer
types.
This is not tested well and is still missing update of make check
drive_del() has become a trivial wrapper around blk_unref(). Get rid
of it.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c| 9 ++---
device-hotplug.c | 3 ++-
hw/ide/piix.c | 4 +++-
include/sysemu/blockdev.h | 1 -
4 files changed, 7
The patch is big, but all it really does is replacing
dinfo-bdrv
by
blk_bs(blk_by_legacy_dinfo(dinfo))
The replacement is repetitive, but the conversion of device models to
BlockBackend is imminent, and will shorten it to just
blk_legacy_dinfo(dinfo).
Line wrapping muddies the waters
Creating an anonymous BDS can't fail. Make that obvious.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
block.c | 28
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
block-migration.c | 30 +++---
block.c | 9 -
blockdev.c
Commit 12c5674 turned it into a pointer to member blk.conf.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
hw/block/virtio-blk.c | 28
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
block/block-backend.c | 13 +
blockdev.c| 11 ---
BlockBackend's name space is separate only to keep the initial patches
simple. Time to merge the two.
Retain bdrv_find() and bdrv_get_device_name() for now, to keep this
series manageable.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
---
block.c
On BlockBackend destruction, unref its BlockDriverState. Replaces the
callers' unrefs.
This turns the pointer from BlockBackend to BlockDriverState into a
strong reference, managed with bdrv_ref() / bdrv_unref(). The
back-pointer remains weak.
Signed-off-by: Markus Armbruster arm...@redhat.com
My last attempt got bogged down because I tried to do a reasonably
complete job, and the complexity proved more than I could handle with
the limited amount of uninterrupted time available. This time, I'm
cutting BlockBackend off with an axe, leaving most of the work for
later.
Done in this
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its
Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use
blk_aio_discard() instead of bdrv_aio_discard().
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
hw/ide/core.c | 6 --
1 file
Make the BlockBackend own the DriveInfo. Change blockdev_init() to
return the BlockBackend instead of the DriveInfo.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 2 --
block/block-backend.c | 38
blockdev.c| 73
Much more command code needs conversion. I start with this one
because it's using bdrv_dev_* functions, which I'm about to lift into
BlockBackend.
While there, give bdrv_query_info() internal linkage.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet
This is consistent with how VirtIOFOOConf variables are named
elsewhere, and makes blk available for BlockBackend variables.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
---
hw/block/dataplane/virtio-blk.c | 33 ++-
Doesn't make a difference just yet, but it's the right thing to do.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
---
block/block-backend.c | 2 ++
1 file
Convenience function blk_new_with_bs() creates a BlockBackend with its
BlockDriverState. Callers have to unref both. The commit after next
will relieve them of the need to unref the BlockDriverState.
Complication: due to the silly way drive_del works, we need a way to
hide a BlockBackend, just
Move device model attachment / detachment and the BlockDevOps device
model callbacks and their wrappers from BlockDriverState to
BlockBackend.
Wrapper calls in block.c change from
bdrv_dev_FOO_cb(bs, ...)
to
if (bs-blk) {
bdrv_dev_FOO_cb(bs-blk, ...);
}
No change, because
device_name[] can become non-empty only in bdrv_new_root() and
bdrv_move_feature_fields(). The latter is used only to undo damage
done by bdrv_swap(). The former is called only by blk_new_with_bs().
Therefore, when a BlockDriverState's device_name[] is non-empty, then
it's been created with a
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Max Reitz mre...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
block/block-backend.c | 1 -
blockdev.c| 5 ++---
include/sysemu/blockdev.h | 1 -
3
1 - 100 of 208 matches
Mail list logo
