Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()'

2014-11-12 Thread Max Reitz
On 2014-11-12 at 08:05, SeokYeon Hwang wrote: Signed-off-by: SeokYeon Hwang syeon.hw...@samsung.com --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@

Re: [Qemu-devel] [PATCH v4] error: passing a negative value to an os_errno is wrong

2014-11-12 Thread Max Reitz
On 2014-11-12 at 08:08, SeokYeon Hwang wrote: Added 'assert(os_errno = 0)' in 'error_set_errno()'. Signed-off-by: SeokYeon Hwang syeon.hw...@samsung.com --- util/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/error.c b/util/error.c index 2ace0d8..6c9d995 100644 ---

Re: [Qemu-devel] [PATCH 1/3] chardev: Add -qmp-pretty

2014-11-12 Thread Max Reitz
On 2014-11-12 at 05:41, Eric Blake wrote: On 11/11/2014 06:34 AM, Max Reitz wrote: Add a command line option for adding a QMP monitor using pretty JSON formatting. Signed-off-by: Max Reitz mre...@redhat.com --- qemu-options.hx | 8 vl.c| 15 ++- 2 files

Re: [Qemu-devel] [PATCH 2/3] iotests: _filter_qmp for pretty JSON output

2014-11-12 Thread Max Reitz
On 2014-11-12 at 05:47, Eric Blake wrote: On 11/11/2014 06:34 AM, Max Reitz wrote: _filter_qmp should be able to correctly filter out the QMP version object for pretty JSON output. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/common.filter | 16 +++- 1 file

Re: [Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-12 Thread Shannon Zhao
On 2014/11/11 23:11, Pawel Moll wrote: On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net performance is not the best without vhost-net and irqfd

Re: [Qemu-devel] [PATCH 3/3] iotests: Use -qmp-pretty in 067

2014-11-12 Thread Max Reitz
On 2014-11-12 at 05:51, Eric Blake wrote: On 11/11/2014 06:34 AM, Max Reitz wrote: 067 invokes query-block, resulting in a reference output with really long lines (which may pose a problem in email patches and always poses a problem when the output changes, because it is hard to see what has

Re: [Qemu-devel] [PATCH 11/21] iotests: Prepare for refcount_width option

2014-11-12 Thread Max Reitz
On 2014-11-11 at 18:57, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Some tests do not work well with certain refcount widths (i.e. you cannot create internal snapshots with refcount_width=1), so make those widths unsupported. Furthermore, add another filter to _filter_img_create

Re: [Qemu-devel] [PATCH 12/21] qcow2: Allow creation with refcount order != 4

2014-11-12 Thread Max Reitz
On 2014-11-11 at 19:05, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a creation option to qcow2 for setting the refcount order of images to be created, and respect that option's value. This breaks some test outputs, fix them. Signed-off-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] [PATCH 14/21] qcow2: Use error_report() in qcow2_amend_options()

2014-11-12 Thread Max Reitz
On 2014-11-11 at 19:11, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2.c | 14 ++ tests/qemu-iotests/061.out | 14 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false)

2014-11-12 Thread Max Reitz
On 2014-11-11 at 19:12, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com Is it worth hoisting this one into 2.2 via the

Re: [Qemu-devel] [PATCH 05/21] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-11-12 Thread Max Reitz
On 2014-11-11 at 20:49, Eric Blake wrote: On 11/11/2014 09:18 AM, Max Reitz wrote: No, I was envisioning that we have a brand new image with one cluster allocated (cluster 1 has refcount 1), then 5 times in a row we do 'savevm' to take an internal snapshot. If I understand your code

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Frank Blaschka
On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: Am 11.11.2014 um 13:39 schrieb Frank Blaschka blasc...@linux.vnet.ibm.com: On Tue, Nov 11, 2014 at

Re: [Qemu-devel] [PATCH 21/21] iotests: Add test for different refcount widths

2014-11-12 Thread Max Reitz
On 2014-11-11 at 20:53, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Alexander Graf
On 12.11.14 09:49, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: Am 11.11.2014 um 13:39 schrieb Frank Blaschka blasc...@linux.vnet.ibm.com:

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Claudio Fontana
On 11.11.2014 16:29, Mark Rutland wrote: Hi, On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: On 6 November 2014 14:44, Peter Maydell peter.mayd...@linaro.org wrote: We need ACPI guest support in QEMU for AArch64 over here, with all features (including the ability to

Re: [Qemu-devel] [PATCH 17/21] qcow2: Use intermediate helper CB for amend

2014-11-12 Thread Max Reitz
On 2014-11-11 at 22:05, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: If there is more than one time-consuming operation to be performed for qcow2_amend_options(), we need an intermediate CB which coordinates the progress of the individual operations and passes the result to the

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 10:08, Alexander Graf wrote: On 12.11.14 09:49, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote: Am 11.11.2014 um 13:39

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Alexander Graf
On 12.11.14 10:11, Paolo Bonzini wrote: On 12/11/2014 10:08, Alexander Graf wrote: On 12.11.14 09:49, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-12 Thread Andrew Jones
On Tue, Nov 11, 2014 at 04:31:24PM -0200, Eduardo Habkost wrote: On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: [...] Below is a v2 I can post if it looks good to you. From: Andrew Jones drjo...@redhat.com Date: Fri, 7 Nov 2014 15:45:07 +0100 Subject: [PATCH v2] vl:

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Frank Blaschka
On Wed, Nov 12, 2014 at 10:08:19AM +0100, Alexander Graf wrote: On 12.11.14 09:49, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM +0100, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Alexander Graf
On 12.11.14 10:19, Frank Blaschka wrote: On Wed, Nov 12, 2014 at 10:08:19AM +0100, Alexander Graf wrote: On 12.11.14 09:49, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 04:24:24PM +0100, Alexander Graf wrote: On 11.11.14 15:08, Frank Blaschka wrote: On Tue, Nov 11, 2014 at 01:51:25PM

Re: [Qemu-devel] [PATCH v2 1/3] vl: Avoid unnecessary 'if' nesting

2014-11-12 Thread Andrew Jones
On Tue, Nov 11, 2014 at 04:50:54PM -0200, Eduardo Habkost wrote: Just a coding style change, to make other changes easier to review. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- vl.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c

[Qemu-devel] [PATCH v3] esp: Do not overwrite ESP_TCHI after reset

2014-11-12 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de After a reset ESP_TCHI should contain the unique ID of the chip. This value will be overwritten with the current tranfer count if the transfer count has previously been set. So we should always return the chip id if ESP_TCHI has never been written to.

Re: [Qemu-devel] [PATCH v2 3/3] vl: Don't silently change topology when all -smp options were set

2014-11-12 Thread Andrew Jones
On Tue, Nov 11, 2014 at 04:50:56PM -0200, Eduardo Habkost wrote: QEMU tries to change the threads option even if it was explicitly set in the command-line, and it shouldn't do that. The right thing to do when all options (cpus, sockets, cores, threds) are explicitly set is to sanity check

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 10:22, Alexander Graf wrote: Absolutely lets make an example for qemu running on BE and LE byte orderconfig space backing pci_default_read_config pcilg (with cpu_to_le) BE0x78563412 0x123456780x78563412 LE0x78563412

[Qemu-devel] [PATCH 2/4] exec: add wrapper for host pointer access

2014-11-12 Thread Michael S. Tsirkin
host pointer accesses force pointer math, let's add a wrapper to make them safer. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/exec/cpu-all.h | 5 + exec.c | 10 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 0/4] migration: fix CVE-2014-7840

2014-11-12 Thread Michael S. Tsirkin
This patchset fixes CVE-2014-7840: invalid migration stream can cause arbitrary qemu memory overwrite. First patch includes the minimal fix for the issue. Follow-up patches on top add extra checking to reduce the chance this kind of bug recurs. Note: these are already (tentatively-pending review)

[Qemu-devel] [PATCH 4/4] cpu: verify that block-host is set

2014-11-12 Thread Michael S. Tsirkin
If it isn't, access at an offset will cause memory corruption. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/exec/cpu-all.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 7c3a5e7..62f5581 100644 ---

[Qemu-devel] [PATCH 1/4] migration: fix parameter validation on ram load

2014-11-12 Thread Michael S. Tsirkin
During migration, the values read from migration stream during ram load are not validated. Especially offset in host_from_stream_offset() and also the length of the writes in the callers of said function. To fix this, we need to make sure that the [offset, offset + length] range fits into one of

[Qemu-devel] [PATCH 3/4] cpu: assert host pointer offset within block

2014-11-12 Thread Michael S. Tsirkin
Make accesses safer in case we missed some check somewhere. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/exec/cpu-all.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 9d8d408..7c3a5e7 100644 --- a/include/exec/cpu-all.h

Re: [Qemu-devel] [PATCH 1/4] migration: fix parameter validation on ram load

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 10:44, Michael S. Tsirkin wrote: During migration, the values read from migration stream during ram load are not validated. Especially offset in host_from_stream_offset() and also the length of the writes in the callers of said function. To fix this, we need to make sure that

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 05:15, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 424

[Qemu-devel] [Bug 1363641] Re: Build of v2.1.0 fails on armv7l due to undeclared __NR_select

2014-11-12 Thread Eduardo Otubo
This commit temporarily fixes this problem. http://git.qemu.org/?p=qemu.git;a=commit;h=4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 As soon as libseccomp makes a new release I'll update the dependency and hopefully it will be fixed with proper library support. -- You received this bug notification

Re: [Qemu-devel] [PATCH] virtio-scsi: dataplane: suppress guest notification

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 04:24, Ming Lei wrote: This patch uses vring_should_notify() to suppress guest notification, and looks notification frequency can be decreased from ~33K/sec to ~2K/sec in my test environment. Suggested-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Ming Lei

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
On Tue, Nov 11, 2014 at 09:33:12PM +, Christoffer Dall wrote: On Tue, Nov 11, 2014 at 04:48:07PM +, Mark Rutland wrote: Hi Christoffer, On Tue, Nov 11, 2014 at 04:31:01PM +, Christoffer Dall wrote: On Tue, Nov 11, 2014 at 03:29:33PM +, Mark Rutland wrote: Hi,

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Christoffer Dall
On Wed, Nov 12, 2014 at 10:38:54AM +, Mark Rutland wrote: On Tue, Nov 11, 2014 at 09:33:12PM +, Christoffer Dall wrote: On Tue, Nov 11, 2014 at 04:48:07PM +, Mark Rutland wrote: Hi Christoffer, On Tue, Nov 11, 2014 at 04:31:01PM +, Christoffer Dall wrote: On Tue,

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
On Wed, Nov 12, 2014 at 09:08:55AM +, Claudio Fontana wrote: On 11.11.2014 16:29, Mark Rutland wrote: Hi, On Thu, Nov 06, 2014 at 01:33:20PM +, Alexander Spyridakis wrote: On 6 November 2014 14:44, Peter Maydell peter.mayd...@linaro.org wrote: We need ACPI guest support in

[Qemu-devel] [PATCH] vhdx: fix g_try_malloc0 thinko

2014-11-12 Thread Paolo Bonzini
Spotted while looking at Coverity reports (though not found by Coverity itself). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2-snapshot.c | 2 +- block/vhdx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-snapshot.c

[Qemu-devel] [PATCH] target-i386: eliminate dead code and hoist common code out of if

2014-11-12 Thread Paolo Bonzini
ist != 0 is checked in the first if, so it cannot be true in the else if part. While at it, simplify the code and move the ESP alignment out of the conditionals. Reported by Coverity. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/seg_helper.c | 17 - 1 file

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
[...] We are currently suggesting adding an RDSP property to the chosen node in the tiny DT, but a command-line arguement like kexec proposed could be another option I guess, albeit not a very pretty one. I'm not sure what an RDSP command line property would have to do

Re: [Qemu-devel] [PATCH] vhdx: fix g_try_malloc0 thinko

2014-11-12 Thread Fam Zheng
On Wed, 11/12 11:59, Paolo Bonzini wrote: Spotted while looking at Coverity reports (though not found by Coverity itself). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2-snapshot.c | 2 +- block/vhdx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] vhdx: fix g_try_malloc0 thinko

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 12:09, Fam Zheng wrote: There is already: commit a011898d25b8a26a311d56dfe37e8d3a4374ec65 Author: Adelina Tuvenie adelinatuve...@gmail.com Date: Thu Sep 18 18:17:44 2014 +0300 block: allow creation of fixed vhdx images Oops, old checkout. Thanks, Paolo

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Arnd Bergmann
On Wednesday 12 November 2014 10:56:40 Mark Rutland wrote: On Wed, Nov 12, 2014 at 09:08:55AM +, Claudio Fontana wrote: On 11.11.2014 16:29, Mark Rutland wrote: I tend to mostly agree with this, we might look for alternative solutions for speeding up guest startup in the future but

Re: [Qemu-devel] [PATCH v6 07/10] qmp: Add support of dirty-bitmap sync mode for drive-backup

2014-11-12 Thread Vladimir Sementsov-Ogievskiy
@@ -317,7 +321,21 @@ static void coroutine_fn backup_run(void *opaque) if (alloced == 0) { continue; } +} else if (job-sync_mode == MIRROR_SYNC_MODE_DIRTY_BITMAP) { +int i, dirty = 0; +for (i =

[Qemu-devel] [PATCH] target-i386: fix Coverity complaints about overflows

2014-11-12 Thread Paolo Bonzini
sipi_vector is an int; it is shifted by 12 and passed as a 64-bit value, which makes Coverity think that we wanted (uint64_t)sipi_vector 12. But actually it must be between 0 and 255. Make this explicit. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/cpu.h | 2 +- 1 file

[Qemu-devel] [PATCH] apic: fix incorrect handling of ExtINT interrupts wrt processor priority

2014-11-12 Thread Paolo Bonzini
This fixes another failure with ExtINT, demonstrated by QNX. The failure mode is as follows: - IPI sent to cpu 0 (bit set in APIC irr) - IPI accepted by cpu 0 (bit cleared in irr, set in isr) - IPI sent to cpu 0 (bit set in both irr and isr) - PIC interrupt sent to cpu 0 The PIC interrupt causes

[Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq

2014-11-12 Thread Fam Zheng
The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading comment. Suggested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com --- include/hw/virtio/virtio-scsi.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 12:29, Fam Zheng wrote: The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading comment. Suggested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com --- include/hw/virtio/virtio-scsi.h | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PATCH] apic_common: migrate missing fields

2014-11-12 Thread Paolo Bonzini
From: Pavel Dovgalyuk pavel.dovga...@ispras.ru This patch adds missed sipi_vector and wait_for_sipi fields to a new subsection of the vmstate of the apic_common module. Saving and loading of these fields makes migration of the apic state deterministic. Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 12:34, Christoffer Dall wrote: AFAIU ACPI already has a method for doing this It's not defined in the spec. QEMU defines a bunch of registers to do that, and provides AML that works with those registers. While these registers can be separated from the ACPI code in QEMU... and

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 11:38, Mark Rutland wrote: I share your concern, but running another UEFI instance for Dom0 doesn't seem like a viable alternative either. Why is this a problem on ARM and not on x86 though? I believe that on x86 the fallback for !UEFI would be the e820 memory map, which

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
On Wed, Nov 12, 2014 at 11:48:27AM +, Paolo Bonzini wrote: On 12/11/2014 12:34, Christoffer Dall wrote: AFAIU ACPI already has a method for doing this It's not defined in the spec. QEMU defines a bunch of registers to do that, and provides AML that works with those registers. Huh?

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 13:18, Mark Rutland wrote: On Wed, Nov 12, 2014 at 11:48:27AM +, Paolo Bonzini wrote: On 12/11/2014 12:34, Christoffer Dall wrote: AFAIU ACPI already has a method for doing this It's not defined in the spec. QEMU defines a bunch of registers to do that, and provides AML

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Christoffer Dall
On Wed, Nov 12, 2014 at 1:27 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 12/11/2014 13:18, Mark Rutland wrote: On Wed, Nov 12, 2014 at 11:48:27AM +, Paolo Bonzini wrote: On 12/11/2014 12:34, Christoffer Dall wrote: AFAIU ACPI already has a method for doing this It's not defined in

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Peter Maydell
On 12 November 2014 12:50, Liviu Ionescu i...@livius.net wrote: On 12 Nov 2014, at 01:08, Peter Maydell peter.mayd...@linaro.org wrote: Cortex-M4 support would definitely be interesting. :-) any hints on what is missing for Cortex-M4 support? are all thumb instructions supported? the hard

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Arnd Bergmann
On Wednesday 12 November 2014 13:27:14 Paolo Bonzini wrote: On 12/11/2014 13:18, Mark Rutland wrote: On Wed, Nov 12, 2014 at 11:48:27AM +, Paolo Bonzini wrote: Perhaps you could treat it as a shared level-triggered interrupt in DT? I don't know. Putting an interrupt in DT is

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Christopher Covington
On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/11/2014 06:22 AM, Laszlo Ersek wrote: (Note: I'm not subscribed to either qemu-devel or the kexec list; please keep me CC'd.) QEMU is able to dump the

Re: [Qemu-devel] [PATCH 2/3] iotests: _filter_qmp for pretty JSON output

2014-11-12 Thread Eric Blake
On 11/12/2014 01:33 AM, Max Reitz wrote: +-e 's#^{QMP:.*}$#QMP_VERSION#' \ +-e 's#\\##g' | \ +while IFS='' read line; do +if [[ $line == 'QMP: {' ]]; then Good that this is a /bin/bash script and not /bin/sh :) Ah, right, yes, I just copied the

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Peter Maydell
On 12 November 2014 12:04, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Nov 12, 2014 at 11:52:22AM +, Paolo Bonzini wrote: SeaBIOS fishes out information from fw_cfg, and puts it in low memory. On ARM you could use DT binary blobs instead of fw_cfg, as proposed already (I don't

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 14:08, Arnd Bergmann wrote: Putting an interrupt in DT is trivial. The hard part is the rest of the interface, which so far there is no specification for. Have you looked at docs/specs/acpi_{cpu,mem}_hotplug.txt? Writing a DT binding for it is trivial too. Or are we talking

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Christopher Covington
On 11/12/2014 08:26 AM, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/11/2014 06:22 AM, Laszlo

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 14:27, Peter Maydell wrote: If somebody with more x86/ACPI knowledge could clarify what the dynamically-constructed parts of the tables are and whether they're likely to apply to use that would be good. I think they involved PCI in some way, but I don't have access to my irc

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Christoffer Dall
On Wed, Nov 12, 2014 at 02:03:01PM +0100, Arnd Bergmann wrote: On Wednesday 12 November 2014 12:34:01 Christoffer Dall wrote: On Wed, Nov 12, 2014 at 12:15:08PM +0100, Arnd Bergmann wrote: On Wednesday 12 November 2014 10:56:40 Mark Rutland wrote: For the features which ACPI

Re: [Qemu-devel] [PATCH] spice: do not require TCP ports

2014-11-12 Thread Gerd Hoffmann
On Di, 2014-11-11 at 13:39 +0100, Marc-André Lureau wrote: It is possible to use Spice server without TCP port. On local VM, qemu (and libvirt) can add new clients thanks to QMP add_client command. added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v1 00/15] android-console: Add console power command

2014-11-12 Thread Greg Bellows
Please disregard this patch review as it went to a broader audience than intended. If there is interest in this work then please let me know and I will be happy to point you to a Linaro git repository that can be monitored for future updates. Regards, Greg On 11 November 2014 18:25, Greg

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
On Wed, Nov 12, 2014 at 12:27:14PM +, Paolo Bonzini wrote: On 12/11/2014 13:18, Mark Rutland wrote: On Wed, Nov 12, 2014 at 11:48:27AM +, Paolo Bonzini wrote: On 12/11/2014 12:34, Christoffer Dall wrote: AFAIU ACPI already has a method for doing this It's not defined in

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Liviu Ionescu
On 12 Nov 2014, at 15:02, Peter Maydell peter.mayd...@linaro.org wrote: The instructions themselves are generally supported for the A profile cores, so getting that part right would mostly involve enabling those feature bits for the new M4 CPU class. ok The difficult bits are going to

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Peter Maydell
On 12 November 2014 13:43, Liviu Ionescu i...@livius.net wrote: all seem related to FP, which, for my priority list, comes second, after specific vendor system registers for the supported processors. my first priority is to make the emulator run the images generated by the project templates

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/12/2014 02:55 AM, Max Reitz wrote: On 2014-11-12 at 05:15, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Petr Tesarik
On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/11/2014 06:22 AM, Laszlo Ersek wrote: (Note: I'm not subscribed to

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Petr Tesarik
On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/11/2014 06:22 AM, Laszlo Ersek wrote: (Note: I'm not subscribed to either qemu-devel or the kexec list; please keep me CC'd.) QEMU is able to dump the guest's memory in KDUMP format (kdump-zlib,

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Julien Grall
Hi, On 12/11/2014 10:44, Christoffer Dall wrote: I'm not a fan of placing fundamentally required system description on the command line. It's fine for explicit overrides but I don't think it should be the default mechanism as that causes its own set of problems (who wants to fight with their

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Graeme Gregory
On Wed, Nov 12, 2014 at 11:07:22AM +, Mark Rutland wrote: [...] We are currently suggesting adding an RDSP property to the chosen node in the tiny DT, but a command-line arguement like kexec proposed could be another option I guess, albeit not a very pretty

Re: [Qemu-devel] State of ARM FIQ in Qemu

2014-11-12 Thread Tim Sander
Hi Greg Bad mode in data abort handler detected Internal error: Oops - bad mode: 0 [#1] PREEMPT SMP ARM Modules linked in: firq(O) ipv6 CPU: 0 PID: 103 Comm: systemd-udevd Tainted: G O 3.14.0 #1 task: bf2b9300 ti: bf362000 task.ti: bf362000 PC is at 0x1240 LR is at

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 14:41, Mark Rutland wrote: Writing a binding for the partiuclar device might be trivial. How this would fit with the DT model is more complicated, and needs to be specified. As far as I can see, those documents are quite strongly tied to x86 ACPI (they talk in terms of OSPM,

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Laszlo Ersek
On 11/12/14 14:26, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/11/2014 06:22 AM, Laszlo Ersek

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Mark Rutland
On Wed, Nov 12, 2014 at 01:59:30PM +, Paolo Bonzini wrote: On 12/11/2014 14:41, Mark Rutland wrote: Writing a binding for the partiuclar device might be trivial. How this would fit with the DT model is more complicated, and needs to be specified. As far as I can see, those documents

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as dirty, nuked the on-disk refcount, then rebuilt one using the in-memory refcounts?

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 15:19, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as dirty, nuked the on-disk refcount, then

Re: [Qemu-devel] Better Cortex-M support?

2014-11-12 Thread Liviu Ionescu
On 12 Nov 2014, at 15:51, Peter Maydell peter.mayd...@linaro.org wrote: ... I'd suggest looking at Alistair's patches on the list for supporting the netduino2, will certainly do. and I also plan to review the patches of Andre Bechus, available from https://github.com/beckus/qemu_stm32.

Re: [Qemu-devel] Starting X remotely

2014-11-12 Thread Nigel Horne
On 11/10/14 3:03 PM, Brian Jackson wrote: On Monday, November 10, 2014 09:42:45 AM Nigel Horne wrote: When I start any emulator remotely (i.e. I've logged into the host machine using 'ssh -Y'), I get this error and the guest console is unusable. All works well when I am logged in directly to

Re: [Qemu-devel] [PATCH 2/3] s390: implement pci instructions

2014-11-12 Thread Frank Blaschka
On Wed, Nov 12, 2014 at 10:36:03AM +0100, Paolo Bonzini wrote: On 12/11/2014 10:22, Alexander Graf wrote: Absolutely lets make an example for qemu running on BE and LE byte orderconfig space backing pci_default_read_config pcilg (with cpu_to_le) BE0x78563412

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Petr Tesarik
V Wed, 12 Nov 2014 08:28:54 -0500 Christopher Covington c...@codeaurora.org napsáno: On 11/12/2014 08:26 AM, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Laszlo Ersek
On 11/11/14 18:27, Christopher Covington wrote: On 11/11/2014 06:22 AM, Laszlo Ersek wrote: (Note: I'm not subscribed to either qemu-devel or the kexec list; please keep me CC'd.) QEMU is able to dump the guest's memory in KDUMP format (kdump-zlib, kdump-lzo, kdump-snappy) with the

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Laszlo Ersek
On 11/12/14 14:28, Christopher Covington wrote: On 11/12/2014 08:26 AM, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM, Petr Tesarik wrote: On Tue, 11 Nov 2014 12:27:44 -0500 Christopher Covington

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 15:10, Mark Rutland wrote: We can't just pick-and-mix portions of ACPI and state that it's specified and standard. But that's what you already do if you want to build ACPI tables from DT. You are already picking-and-mixing the variable portions of the ACPI tables and make a

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Christopher Covington
Thanks Petr and Laszlo for entertaining my questions. I've got one last one if you have the time. On 11/12/2014 09:10 AM, Laszlo Ersek wrote: On 11/12/14 14:26, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington c...@codeaurora.org wrote: On 11/12/2014 03:05 AM,

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Claudio Fontana
On 12.11.2014 14:27, Peter Maydell wrote: On 12 November 2014 12:04, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Nov 12, 2014 at 11:52:22AM +, Paolo Bonzini wrote: SeaBIOS fishes out information from fw_cfg, and puts it in low memory. On ARM you could use DT binary blobs instead of

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Laszlo Ersek
On 11/12/14 15:48, Christopher Covington wrote: Thanks Petr and Laszlo for entertaining my questions. I've got one last one if you have the time. On 11/12/2014 09:10 AM, Laszlo Ersek wrote: On 11/12/14 14:26, Petr Tesarik wrote: On Wed, 12 Nov 2014 08:18:04 -0500 Christopher Covington

[Qemu-devel] [PULL for-2.2 0/3] usb bugfixes for 2.2

2014-11-12 Thread Gerd Hoffmann
at: git://git.kraxel.org/qemu tags/pull-usb-20141112-1 for you to fetch changes up to 79ae25af1569a50a0ec799901a1bb280c088f121: usb-host: fix usb_host_speed_compat tyops (2014-11-12 15:27:23 +0100) usb bugfixes for 2.2

[Qemu-devel] [PULL for-2.2 1/3] Provide the missing LIBUSB_LOG_LEVEL_* for older libusb or FreeBSD. Providing just the needed value as a defined.

2014-11-12 Thread Gerd Hoffmann
From: Chris Johns chr...@rtems.org Signed-off-by: Chris Johns chr...@rtems.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/host-libusb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index d2d161b..032a0e4 100644 ---

[Qemu-devel] [PULL for-2.2 3/3] usb-host: fix usb_host_speed_compat tyops

2014-11-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Gonglei arei.gong...@huawei.com --- hw/usb/host-libusb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 032a0e4..a5f9dab 100644 --- a/hw/usb/host-libusb.c +++

[Qemu-devel] [PULL for-2.2 2/3] xhci: add sanity checks to xhci_lookup_uport

2014-11-12 Thread Gerd Hoffmann
Also catch xhci_lookup_uport failures in post_load. https://bugzilla.redhat.com/show_bug.cgi?id=1074219 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2930b72..9a942cf

[Qemu-devel] [PATCH] mips: Fix the 64-bit case for microMIPS MOVE16 and MOVEP

2014-11-12 Thread Maciej W. Rozycki
Fix microMIPS MOVE16 and MOVEP instructions on 64-bit processors by using register addition operations. This copies the approach taken with MIPS16 MOVE instructions (I8_MOV32R and I8_MOVR32 opcodes) and follows the observation that OPC_ADDU expands to tcg_gen_mov_tl whenever `rt' is 0 and `rs'

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Arnd Bergmann
On Wednesday 12 November 2014 16:01:14 Claudio Fontana wrote: Would the last step you mention allow for guests to start with an already existing PCI interrupt map and the BAR registers preprogrammed to point to somewhere sane? I ask because on OSv at the moment, the situation is that for

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Peter Maydell
On 12 November 2014 15:32, Arnd Bergmann a...@arndb.de wrote: On Wednesday 12 November 2014 16:01:14 Claudio Fontana wrote: Would the last step you mention allow for guests to start with an already existing PCI interrupt map and the BAR registers preprogrammed to point to somewhere sane? I

Re: [Qemu-devel] uniquely identifying KDUMP files that originate from QEMU

2014-11-12 Thread Christopher Covington
On 11/12/2014 10:03 AM, Laszlo Ersek wrote: On 11/12/14 15:48, Christopher Covington wrote: Thanks Petr and Laszlo for entertaining my questions. I've got one last one if you have the time. On 11/12/2014 09:10 AM, Laszlo Ersek wrote: On 11/12/14 14:26, Petr Tesarik wrote: On Wed, 12 Nov

[Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread Roger Pau Monne
This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Don't use batch mappings when using persistent grants, doing so prevents unmapping single grants (the whole area has to be unmapped at once). - Unmap persistent grants before switching to the closed state,

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 16:39, Peter Maydell wrote: Definitely, I think having the OS manually program the BARs only makes sense in an environment where you don't have a full-featured boot loader or you don't trust it. In servers and virtual machines, the PCI bus should always come fully set

Re: [Qemu-devel] [PATCH] xen_disk: fix unmapping of persistent grants

2014-11-12 Thread George Dunlap
On 11/12/2014 03:45 PM, Roger Pau Monne wrote: This patch fixes two issues with persistent grants and the disk PV backend (Qdisk): - Don't use batch mappings when using persistent grants, doing so prevents unmapping single grants (the whole area has to be unmapped at once). - Unmap

  1   2   >