Re: [Qemu-devel] [PATCH COLO-Frame v9 03/32] COLO: migrate colo related info to slave

On 2015/10/3 2:45, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We can know if VM in destination should go into COLO mode by refer to the info that been migrated from PVM. We skip this section if colo is not enabled (i.e. migrate_set_capability colo

[Qemu-devel] [PATCH/] checkpatch: port fix from kernel "## is not a valid modifier"

From: Andy Whitcroft checkpatch currently loops on fpu/softfloat.c Turns out this is fixed in the Linux version of checkpatch. So this is a port of Andy Whitcrofts fix from Linux, Original commit was commit 89a883530fe7 ("checkpatch: ## is not a valid modifier") As

Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

On Wed 07 Oct 2015 08:51:21 PM CEST, Max Reitz wrote: >> +if (s->num_children == s->max_children) { >> +if (s->max_children >= INT_MAX) { > > Opposing Berto (:-)), I like >= even if the > part is actually > impossible. I myself like to use constructs such as: > >

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

Laurent Desnogues writes: > Hello, > > On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias > wrote: >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >>

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

Edgar E. Iglesias writes: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Now Peter has pointed out I can't read ;-) Reviewed-by: Alex Bennée > --- > target-arm/cpu.h

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

On Tue, Oct 06, 2015 at 03:53:33PM +0100, Peter Maydell wrote: > On 6 October 2015 at 15:44, Stefan Hajnoczi wrote: > > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > >> @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void *opaque, > >> hwaddr addr, > >>

Re: [Qemu-devel] creating vm fails if maxMemory equals to memory, but hotplug same will success

On Wed, 7 Oct 2015 23:29:07 +0800 Yi Wang wrote: > Hi, all > When I create a vm using virsh, it will fail if maxMemory(2G) equals > to memory(2G) in XML: > error: Failed to create domain from vm1.xml > error: internal error: process exited while connecting to monitor: >

Re: [Qemu-devel] [PATCH COLO-Frame v9 02/32] migration: Introduce capability 'colo' to migration

On 2015/10/3 0:02, Eric Blake wrote: On 09/02/2015 02:22 AM, zhanghailiang wrote: We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'colo' string to users, they can use qmp command

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

Peter Maydell writes: > On 7 October 2015 at 12:51, Alex Bennée wrote: >> >> Edgar E. Iglesias writes: >> >>> From: "Edgar E. Iglesias" >>> >>> Signed-off-by: Edgar E. Iglesias

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

On 8 October 2015 at 06:38, Laurent Desnogues wrote: > Hello, > > On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias > wrote: >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

On Thu 08 Oct 2015 08:15:25 AM CEST, Markus Armbruster wrote: >> For the second point, you should also consider how useful this >> feature is to management tools. Just being able to remove and attach >> children from a quorum node seems very useful on its own. I don't see >> why we should wait for

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

Max Reitz writes: > On 22.09.2015 09:44, Wen Congyang wrote: >> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. >> It justs for adding/removing quorum's child now, and don't support all >> kinds of children, > > It does support all kinds of children

Re: [Qemu-devel] [PATCH] block: switch from g_slice allocator to malloc

On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote: > Simplify memory allocation by sticking with a single API. GSlice > is not that fast anyway (tcmalloc/jemalloc are better). > > Signed-off-by: Paolo Bonzini > --- > block/io.c| 4 ++-- >

Re: [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size

On Tue, Oct 06, 2015 at 10:40:41AM -0700, Alistair Francis wrote: > It is possible for the guest to set an invalid block > size which is larger then the fifo_buffer[] array. This > could cause a buffer overflow. > > To avoid this limit the maximum size of the blksize variable. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 05/16] block: Convert bs->file to BdrvChild

On Thu, 10/01 15:13, Kevin Wolf wrote: > @@ -1935,6 +1932,11 @@ void bdrv_close(BlockDriverState *bs) > bdrv_unref(backing_hd); > } > > +if (bs->file != NULL) { > +bdrv_unref_child(bs, bs->file); > +bs->file = NULL; > +} > + >

Re: [Qemu-devel] Debugging u-boot after relocation on arm machie

On 07/10/15 20:32, mar.krzeminski wrote: > Hello, > > I am working on u-boot under qemu. Debugging before u-boots relocate > itself works just fine. > After relocation and reloading elf in gdb, qemu does no stop on breakpoint. Are you using software breakpoints or hardware breakpoints? In case

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

On 29.09.2015 20:24, Sergey Fedorov wrote: > On 29.09.2015 20:19, Peter Maydell wrote: >> On 29 September 2015 at 18:14, Sergey Fedorov wrote: >>> On 29.09.2015 12:33, Peter Maydell wrote: On 28 September 2015 at 11:37, Sergey Fedorov wrote:

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

On Thu 08 Oct 2015 12:03:45 PM CEST, Kevin Wolf wrote: >> Note that if we want to make this interface stable there's one use >> case missing: there's currently no way to change the vote threshold. >> > The right way to change the voting threshold is bdrv_reopen(). Adding > support to quorum for

[Qemu-devel] Live migration sequence

Hello! I would like to clarify, what is the exact live migration sequence in qemu? I mean - there are pre_save and post_load callbacks for VMState structures. Is there any determined order of calling them related to memory contents migration? In other words, is there any guarantee that

[Qemu-devel] [PATCH 2/4] hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs

From: David Emulate AMD IOMMU on PIIX and Q35 controlled by a command line switch Signed-off-by: David Kiarie --- hw/pci-host/piix.c | 10 ++ hw/pci-host/q35.c | 10 ++ 2 files changed, 20 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/4] hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs

On Fri, Oct 09, 2015 at 05:53:55AM +0300, David Kiarie wrote: > From: David > > Emulate AMD IOMMU on PIIX and Q35 controlled by a command line > switch > > Signed-off-by: David Kiarie Please run scripts/checkpatch.pl and fix the errors that it

Re: [Qemu-devel] Debugging u-boot after relocation on arm machie

2015-10-08 13:22 GMT+02:00 Thomas Huth : > On 07/10/15 20:32, mar.krzeminski wrote: > > Hello, > > > > I am working on u-boot under qemu. Debugging before u-boots relocate > > itself works just fine. > > After relocation and reloading elf in gdb, qemu does no stop on >

Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads

On Tue, 6 Oct 2015 10:29:25 -0400 "Kevin O'Connor" wrote: > On Tue, Oct 06, 2015 at 09:30:18AM +0200, Laszlo Ersek wrote: > > On 10/06/15 01:51, Kevin O'Connor wrote: > > > Return a static signature ("QEMU CFG") if the guest does a read > > > to the DMA address io register. >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

Am 08.10.2015 um 10:29 hat Alberto Garcia geschrieben: > On Thu 08 Oct 2015 08:15:25 AM CEST, Markus Armbruster wrote: > >> For the second point, you should also consider how useful this > >> feature is to management tools. Just being able to remove and attach > >> children from a quorum node

Re: [Qemu-devel] [PATCH v6] linux-user/syscall.c: malloc()/calloc() to g_malloc()/g_try_malloc()/g_new0()

On Tue, Oct 06, 2015 at 09:47:12PM +0530, Harmandeep Kaur wrote: > Convert malloc()/ calloc() calls to g_malloc()/ g_try_malloc()/ g_new0() > > All heap memory allocation should go through glib so that we can take > advantage of a single memory allocator and its debugging/tracing features. > >

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

On Thu, 8 Oct 2015 10:07:34 +0100 Stefan Hajnoczi wrote: > On Tue, Oct 06, 2015 at 03:53:33PM +0100, Peter Maydell wrote: > > On 6 October 2015 at 15:44, Stefan Hajnoczi > > wrote: > > > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > > >> @@

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

On 8 October 2015 at 10:56, Sergey Fedorov wrote: > On 29.09.2015 20:24, Sergey Fedorov wrote: >> On 29.09.2015 20:19, Peter Maydell wrote: >>> On 29 September 2015 at 18:14, Sergey Fedorov wrote: On 29.09.2015 12:33, Peter Maydell wrote: > On

Re: [Qemu-devel] [PULL 0/5] s390x: Fixes and features

On 7 October 2015 at 22:21, Christian Borntraeger wrote: > Am 07.10.2015 um 22:55 schrieb Peter Maydell: >> On 6 October 2015 at 11:41, Christian Borntraeger >> wrote: >>> Peter, >>> >>> here are some fixes (and a small feature) for s390x. >>> >>>

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

On Wed, Oct 07, 2015 at 10:02:54PM +0530, Nutan Shinde wrote: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c| 9 ++--- > hw/audio/sb16.c | 15 +-- > 4 files

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

Hi all, short summary from my side. The whole thing seems to get complicated, let me explain why: 1) During review I found that the code in ide_atapi_cmd_reply_end can't work correctly if the byte_count_limit is not a divider or a multiple of cd_sector_size. The reason is that as soon as we

[Qemu-devel] [RFC PATCH] qapi: Rename simple union's generated tag member to type

Struct and union type members are generally named alike in QMP and C, except for a simple union's implicit tag member, which is "type" in QMP, and "kind" in C. Can't change QMP, so rename it in C. Since the implicit enumeration type is still called *Kind, this doesn't clean up the type vs. kind

Re: [Qemu-devel] [PATCH V10 0/3] Move sdhci.h to include/hw/sd

On Tue, Oct 06, 2015 at 10:54:03PM +0530, Sai Pavan Boddu wrote: > Move sdhci.h splitting it into common and internal. > Create a new directory for sd in include/hw/. > Correct paths of sd.h in at every instance of #include. > Add sdhci to xlnx-zynqmp SOC. > > Sai Pavan Boddu (3): > sd.h: Move

Re: [Qemu-devel] [PATCH v2] qobject: Replace property list with GHashTable

Nit-pick on subject line - s/qobject/qom/ and also copy Andreas Färber on the patch, since he's the primary maintainer of the QOM subsystem. On Tue, Oct 06, 2015 at 04:48:53PM +0300, Pavel Fedin wrote: > ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since > every pin is

Re: [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size

On Tue, Oct 06, 2015 at 11:34:46AM -0700, Peter Crosthwaite wrote: > On Tue, Oct 6, 2015 at 10:40 AM, Alistair Francis > wrote: > > It is possible for the guest to set an invalid block > > size which is larger then the fifo_buffer[] array. This > > could cause a

[Qemu-devel] [PATCH 4/4] hw/acpi: ACPI table for AMD IOMMU

From: David Add AMD IOMMU IVRS table to ACPI tables Signed-off-by: David Kiarie --- hw/i386/acpi-build.c| 85 + include/hw/acpi/acpi-defs.h | 55 + 2 files changed,

[Qemu-devel] [PATCH 1/4] hw/core: Add iommu to machine properties

From: David Add iommu to machine properties in preparation of introducing AMD IOMMU Signed-off-by: David Kiarie --- hw/core/machine.c | 25 + include/hw/boards.h | 2 ++ 2 files changed, 27 insertions(+) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH] block: switch from g_slice allocator to malloc

Am 08.10.2015 um 10:54 hat Stefan Hajnoczi geschrieben: > On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote: > > Simplify memory allocation by sticking with a single API. GSlice > > is not that fast anyway (tcmalloc/jemalloc are better). > > > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

On Thu, Oct 8, 2015 at 10:24 AM, Alex Bennée wrote: > > Laurent Desnogues writes: > >> Hello, >> >> On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias >> wrote: >>> From: "Edgar E. Iglesias"

[Qemu-devel] Dynamic reconfiguration (was: qmp: add monitor command to add/remove a child)

Am 08.10.2015 um 08:15 hat Markus Armbruster geschrieben: > Max Reitz writes: > > E.g. you may have a block filter in the future where you want to > > exchange its child BDS. This exchange should be an atomic operation, so > > we cannot use this interface there anyway. For

Re: [Qemu-devel] [Qemu-block] Dynamic reconfiguration (was: qmp: add monitor command to add/remove a child)

Am 08.10.2015 um 13:02 hat Kevin Wolf geschrieben: > Am 08.10.2015 um 08:15 hat Markus Armbruster geschrieben: > > Max Reitz writes: > > > E.g. you may have a block filter in the future where you want to > > > exchange its child BDS. This exchange should be an atomic operation,

Re: [Qemu-devel] [PULL 0/1] NUMA queue, 2015-10-06

On 6 October 2015 at 20:54, Eduardo Habkost wrote: > The following changes since commit 5fdb4671b08e0d1631447e81348b2b50a6b85bf7: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into > staging (2015-10-06 13:42:33 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v7 07/14] qapi: Move union tag quirks into subclass

Eric Blake writes: > Right now, simple unions have a quirk of using 'kind' in the C > struct to match the QMP wire name 'type'. This has resulted in > messy clients each doing special cases. While we plan to > eventually rename things to match, it is better in the meantime >

[Qemu-devel] [PULL v2 09/11] qmp: Fix device-list-properties not to crash for abstract device

Broken in commit f4eb32b "qmp: show QOM properties in device-list-properties", v2.1. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Andreas Färber Message-Id:

[Qemu-devel] [PULL v2 01/11] virtio-input: Fix device introspection on non-Linux hosts

When CONFIG_LINUX is off, devices "virtio-keyboard-device", "virtio-mouse-device", "virtio-tablet-device" and "virtio-input-host-device" aren't compiled in, yet "virtio-keyboard-pci", "virtio-mouse-pci", "virtio-tablet-pci" and "virtio-input-host-pci" still are. Attempts to introspect them crash,

[Qemu-devel] [PATCH V10 RESEND 1/3] sd.h: Move sd.h to include/hw/sd/

Create a sd directory under include/hw/ and move sd.h to include/hw/sd/ Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V10: Fix Commit Message. Changes

Re: [Qemu-devel] [PATCH v3 1/2] memhp: extend address auto assignment to support gaps

On Tue, Sep 29, 2015 at 04:53:28PM +0200, Igor Mammedov wrote: > setting gap to TRUE will make sparse DIMM > address auto allocation, leaving gaps between > a new DIMM address and preceeding existing DIMM. > > Signed-off-by: Igor Mammedov > --- > v2: > * make 'gap' boolean

Re: [Qemu-devel] [PATCH v7 08/14] qapi: Track location that created an implicit type

Eric Blake writes: > A future patch will move some error checking from the parser > to the various QAPISchema*.check() methods, which run only > after parsing completes. It will thus be possible to create > a python instance representing an implicit QAPI type that > parses

[Qemu-devel] [PATCH 3/4] hw/i386: Introduce AMD IOMMU

From: David Introduce basic AMD IOMMU emulation in Qemu. IOMMU implements event logging and host translation which should allow nested PCI passthrough.It also implemented a very basic IOTLB implementation Signed-off-by: David Kiarie ---

[Qemu-devel] [PULL v2 04/11] macio: move DBDMA_init from instance_init to realize

From: Paolo Bonzini DBDMA_init is not idempotent, and calling it from instance_init breaks a simple object_new/object_unref pair. Work around this, pending qdev-ification of DBDMA, by moving the call to realize. Reported-by: Markus Armbruster

[Qemu-devel] [PULL v2 03/11] hw: do not pass NULL to memory_region_init from instance_init

From: Paolo Bonzini This causes the region to outlive the object, because it attaches the region to /machine. This is not nice for the "realize" method, but much worse for "instance_init" because it can cause dangling pointers after a simple object_new/object_unref pair.

Re: [Qemu-devel] [PULL 00/19] Collected tilegx patches

On 7 October 2015 at 10:32, Richard Henderson wrote: > I've taken the liberty of modifying some of the patches that Chen Gang > has posted. Some of these are new cleanups that I saw along the way. > A few are filling out the final user-level non-fp, non-vector insns. > > > r~ >

[Qemu-devel] [PATCH v3 1/5] qom: introduce object_property_foreach method

Some users of QOM need to be able to iterate over properties defined against an object instance. Currently they are just directly using the QTAIL macros against the object properties data structure. This is bad because it exposes them to changes in the data structure used to store properties, as

Re: [Qemu-devel] [PATCH] trace: remove malloc tracing

On Wed, Sep 16, 2015 at 05:38:44PM +0200, Paolo Bonzini wrote: > The malloc vtable is not supported anymore in glib, because it broke > when constructors called g_malloc. Remove tracing of g_malloc, > g_realloc and g_free calls. > > Note that, for systemtap users, glib also provides tracepoints

[Qemu-devel] [PATCH 0/4] AMD IOMMU v1

David (4): hw/core: Add iommu to machine properties hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs hw/i386: Introduce AMD IOMMU hw/acpi: ACPI table for AMD IOMMU hw/core/machine.c | 25 + hw/i386/Makefile.objs |1 + hw/i386/acpi-build.c| 85 +++

[Qemu-devel] [PATCH v3 0/5] qom: more efficient object property handling

This patch series is a combination of my own previous patch to add support for object properties against classes: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.html And Pavel Fedin's patch to use a hash table instead of list

[Qemu-devel] [PULL v2 02/11] memory: allow destroying a non-empty MemoryRegion

From: Paolo Bonzini This is legal; the MemoryRegion will simply unreference all the existing subregions and possibly bring them down with it as well. However, it requires a bit of care to avoid an infinite loop. Finalizing a memory region cannot trigger an address space

[Qemu-devel] [PULL v2 06/11] libqtest: Clean up unused QTestState member sigact_old

Unused since commit d766825. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <144368-12182-6-git-send-email-arm...@redhat.com> Reviewed-by: Thomas Huth --- tests/libqtest.c | 1 - 1 file changed, 1 deletion(-)

[Qemu-devel] [PULL v2 07/11] libqtest: New hmp() & friends

New convenience function hmp() to facilitate use of human-monitor-command in tests. Use it to simplify its existing uses. To blend into existing libqtest code, also add qtest_hmpv() and qtest_hmp(). That, and the egregiously verbose GTK-Doc comment format make this patch look bigger than it is.

[Qemu-devel] [PULL v2 11/11] Revert "qdev: Use qdev_get_device_class() for -device , help"

This reverts commit 31bed5509dfcbdfc293154ce81086a4dbd7a80b6. The reverted commit changed qdev_device_help() to reject abstract devices and devices that have cannot_instantiate_with_device_add_yet set, to fix crash bugs like -device x86_64-cpu,help. Rejecting abstract devices makes sense:

Re: [Qemu-devel] [PATCH v3 1/2] memhp: extend address auto assignment to support gaps

On Thu, Oct 08, 2015 at 07:01:09PM +0530, Bharata B Rao wrote: > > @@ -333,13 +334,15 @@ uint64_t pc_dimm_get_free_addr(uint64_t > > address_space_start, > > goto out; > > } > > > > -if (ranges_overlap(dimm->addr, dimm_size, new_addr, size)) { > > +if

Re: [Qemu-devel] [PATCH v3 1/2] memhp: extend address auto assignment to support gaps

On Thu, 8 Oct 2015 19:01:09 +0530 Bharata B Rao wrote: > On Tue, Sep 29, 2015 at 04:53:28PM +0200, Igor Mammedov wrote: > > setting gap to TRUE will make sparse DIMM > > address auto allocation, leaving gaps between > > a new DIMM address and preceeding existing DIMM.

[Qemu-devel] [PATCH v3 4/5] qom: replace object property list with GHashTable

From: Pavel Fedin ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since every pin is represented as a property, number of these properties becomes very large. Every property add first makes sure there's no duplicates. Traversing the list becomes very

[Qemu-devel] [PULL v2 00/11] Fix device introspection regressions

QMP command device-list-properties regressed in 2.1: it can crash or leave dangling pointers behind. -device FOO,help regressed in 2.2: it no longer works for non-pluggable devices. I tried to fix that some time ago[*], but my fix failed review. This is my second, more comprehensive try. PATCH

[Qemu-devel] [PULL v2 05/11] tests: Fix how qom-test is run

We want to run qom-test for every architecture, without having to manually add it to every architecture's list of tests. Commit 3687d53 accomplished this by adding it to every architecture's list automatically. However, some architectures inherit their tests from others, like this:

[Qemu-devel] [PULL v2 08/11] device-introspect-test: New, covering device introspection

The test doesn't check that the output makes any sense, only that QEMU survives. Useful since we've had an astounding number of crash bugs around there. In fact, we have a bunch of them right now: a few devices crash or hang, and some leave dangling pointers behind. The test skips testing the

Re: [Qemu-devel] [PATCH] KVM: arm/arm64: Add VGICv3 save/restore API documentation

Hello! Since we are discussing qemu here, i removed kernel mailing lists and added qemu-devel. > A quick look at your patch suggests you still have data > structures like > > +struct gicv3_irq_state { > +/* The enable bits are only banked for per-cpu interrupts. */ > +unsigned long

[Qemu-devel] [PATCH V10 RESEND 0/3]Move sdhci.h to include/hw/sd

Move sdhci.h splitting it into common and internal. Create a new directory for sd in include/hw/. Correct paths of sd.h in at every instance of #include. Add sdhci to xlnx-zynqmp SOC. Sai Pavan Boddu (3): sd.h: Move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device

[Qemu-devel] [PATCH V10 RESEND 2/3] sdhci: Split sdhci.h for public and internal device usage

Split sdhci.h into pubilc version (i.e include/hw/sd/sdhci.h) and internal version (i.e hw/sd/sdhci-interna.h) based on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter

Re: [Qemu-devel] [PATCH] KVM: arm/arm64: Add VGICv3 save/restore API documentation

On 8 October 2015 at 14:28, Pavel Fedin wrote: > Hello! > > Since we are discussing qemu here, i removed kernel mailing lists and added > qemu-devel. > >> A quick look at your patch suggests you still have data >> structures like >> >> +struct gicv3_irq_state { >> +/*

[Qemu-devel] [PULL v2 10/11] qdev: Protect device-list-properties against broken devices

Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commit f4eb32b "qmp:

Re: [Qemu-devel] [PATCH V10 0/3] Move sdhci.h to include/hw/sd

> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Thursday, October 08, 2015 3:19 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; > crosthwaitepe...@gmail.com; Sai Pavan Boddu; Edgar Iglesias; Alistair Francis > Subject: Re:

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot to the seccomp sandbox

On Thu, Oct 01, 2015 at 12=36=05AM -0400, Namsun Ch'o wrote: > The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are > needed for -runas to work. It also doesn't whitelist chroot, which is needed > for the -chroot option. Unfortunately, QEMU enables seccomp before it drops

[Qemu-devel] [PATCH v5 0/6] fw_cfg DMA interface

Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Kevin O'Connor (1): fw_cfg: Define a static signature to be returned on DMA port reads Marc Marí

Re: [Qemu-devel] [PATCH v3 0/5] qom: more efficient object property handling

Hi! Just got test report from my colleague, he forgot to specify --target-list=aarch64-softmmu to configure and tried to build everything. Looks like there are more property iterations done by hand in PowerPC code: --- cut --- In file included from /home/igor/qemu/include/qom/object.h:20:0,

Re: [Qemu-devel] [PATCH v1 1/1] sdhci.c: Limit the maximum block size

On Thu, Oct 8, 2015 at 2:49 AM, Stefan Hajnoczi wrote: > On Tue, Oct 06, 2015 at 11:34:46AM -0700, Peter Crosthwaite wrote: >> On Tue, Oct 6, 2015 at 10:40 AM, Alistair Francis >> wrote: >> > It is possible for the guest to set an invalid block >>

Re: [Qemu-devel] [PATCH 2/4] hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs

On 10/09/2015 05:53 AM, David Kiarie wrote: From: David Emulate AMD IOMMU on PIIX and Q35 controlled by a command line switch Signed-off-by: David Kiarie --- hw/pci-host/piix.c | 10 ++ hw/pci-host/q35.c | 10 ++ 2 files

Re: [Qemu-devel] [RFC PATCH] qapi: Rename simple union's generated tag member to type

On 10/08/2015 06:26 AM, Markus Armbruster wrote: > Struct and union type members are generally named alike in QMP and C, > except for a simple union's implicit tag member, which is "type" in > QMP, and "kind" in C. Can't change QMP, so rename it in C. > > Since the implicit enumeration type is

[Qemu-devel] [PATCH v5 3/6] Implement fw_cfg DMA interface

Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c | 240

[Qemu-devel] [PATCH v5 2/6] fw_cfg DMA interface documentation

Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Peter Maydell Reviewed-by: Laszlo Ersek --- docs/specs/fw_cfg.txt | 65

Re: [Qemu-devel] [PULL 00/26] Do away with TB retranslation

On 7 October 2015 at 10:43, Richard Henderson wrote: > All patches now reviewed. I believe further cleanups can be > handled with subsequent patches. > > > r~ > > > The following changes since commit 5fdb4671b08e0d1631447e81348b2b50a6b85bf7: > > Merge remote-tracking branch

Re: [Qemu-devel] [PULL v2 00/11] Fix device introspection regressions

On 8 October 2015 at 14:02, Markus Armbruster wrote: > QMP command device-list-properties regressed in 2.1: it can crash or > leave dangling pointers behind. > > -device FOO,help regressed in 2.2: it no longer works for > non-pluggable devices. I tried to fix that some time

Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only

On 10/07/2015 06:05 PM, Eric Blake wrote: On 10/07/2015 12:20 AM, Denis V. Lunev wrote: From: Igor Redko This patch declares a new migration capability that allows to distinguish between true migration and the test. An alternative is using a custom URI but in this case

Re: [Qemu-devel] [PATCH] KVM: arm/arm64: Add VGICv3 save/restore API documentation

Hello! > One of the major problems with the emulation code is that it tried > to keep the old GICv2 emulation datastructures, macros, etc. Don't > try to use it as a guide for how to arrange the data structures. Ok. I will redo this after finishing kernel API respin. Kind regards, Pavel Fedin

Re: [Qemu-devel] [PATCH v3 0/5] qom: more efficient object property handling

On Thu, Oct 08, 2015 at 06:27:39PM +0300, Pavel Fedin wrote: > Hi! > > Just got test report from my colleague, he forgot to specify > --target-list=aarch64-softmmu to configure and tried to build everything. > Looks like there are more property iterations done by hand in PowerPC code: > ---

[Qemu-devel] [cross-post] QEMU fw_cfg DMA interface

Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel option and with fw_cfg DMA Linux boot support, this is the timing improvement for x86: Original QEMU and SeaBIOS QEMU startup time: .080 BIOS startup time: .060 Kernel setup time: .586 Total

Re: [Qemu-devel] [PATCH v7 07/14] qapi: Move union tag quirks into subclass

On 10/08/2015 06:25 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Right now, simple unions have a quirk of using 'kind' in the C >> struct to match the QMP wire name 'type'. This has resulted in >> messy clients each doing special cases. While we plan to >>

Re: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

On Tue, Sep 15, 2015 at 3:59 PM, Alistair Francis wrote: > On Sun, Sep 13, 2015 at 1:36 PM, Peter Crosthwaite > wrote: >> On Fri, Sep 11, 2015 at 3:30 AM, Sai Pavan Boddu >> wrote: >>> From: Peter Crosthwaite

[Qemu-devel] [PATCH v3 2/5] qmp: convert to use object_property_foreach iterators

Rather than directly traversing the object property list, use the object_property_foreach iterator. This removes a dependancy on the implementation approach for properties. Signed-off-by: Daniel P. Berrange --- qmp.c | 103

[Qemu-devel] [PATCH v3 3/5] vl: convert machine help to use object_property_foreach

Rather than directly traversing the object property list, use the object_property_foreach iterator. This removes a dependancy on the implementation approach for properties. Signed-off-by: Daniel P. Berrange --- vl.c | 37 ++--- 1 file

[Qemu-devel] [PATCH v5 5/6] Enable fw_cfg DMA interface for x86

Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Laszlo Ersek --- hw/i386/pc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] x86 amd64 singlestepping bug through syscall instruction

Hi all, I was told on IRC to use this ML to report the following bug. It seems that there is something wrong with QEMU with respect to handle the singlestepping and AMD64 syscall instruction. The AMD "syscall" instruction will clear defined flag in the FMASK MSR. Normally the TF flag is set

Re: [Qemu-devel] [PATCH v3 5/6] tcg/mips: Support r6 multiply/divide encodings

On 2015-10-02 13:24, James Hogan wrote: > MIPSr6 adds several new integer multiply, divide, and modulo > instructions, and removes several pre-r6 encodings, along with the HI/LO > registers which were the implicit operands of some of those > instructions. Update TCG to use the new instructions

[Qemu-devel] [PATCH v2 1/2] update-linux-headers: Rename SW_MAX to SW_MAX_

The next commit will compile hw/input/virtio-input.c and hw/input/virtio-input-hid.c even when CONFIG_LINUX is off. These files include both "include/standard-headers/linux/input.h" and then. Doesn't work, because both define SW_MAX. We don't actually use it. Patch input.h to define SW_MAX_

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

On 10/08/2015 08:06 AM, Peter Lieven wrote: > Hi all, > > short summary from my side. The whole thing seems to get complicated, > let me explain why: > > 1) During review I found that the code in ide_atapi_cmd_reply_end can't > work correctly if the > byte_count_limit is not a divider or a

[Qemu-devel] [PATCH v5 4/6] Enable fw_cfg DMA interface for ARM

Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Peter Maydell Reviewed-by: Laszlo Ersek --- hw/arm/virt.c | 8 1 file

Re: [Qemu-devel] [PATCH v3 1/6] tcg-opc.h: Simplify debug_insn_start def

On 2015-10-02 13:24, James Hogan wrote: > We already have a TLADDR_ARGS definition, so rearrange the order > slightly and use it in the definition of debug_insn_start, instead of > having an #ifdef. > > Signed-off-by: James Hogan > Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v2 0/2] virtio-input: Fix device introspection on non-Linux hosts

v2: New PATCH 1. Markus Armbruster (2): update-linux-headers: Rename SW_MAX to SW_MAX_ virtio-input: Fix device introspection on non-Linux hosts hw/input/Makefile.objs | 2 +- hw/virtio/virtio-pci.c | 20 hw/virtio/virtio-pci.h

Re: [Qemu-devel] [PATCH v3 1/5] qom: introduce object_property_foreach method

On 10/08/2015 08:09 AM, Daniel P. Berrange wrote: > Some users of QOM need to be able to iterate over properties > defined against an object instance. Currently they are just > directly using the QTAIL macros against the object properties > data structure. > > This is bad because it exposes them

Re: [Qemu-devel] [PATCH v3 2/5] qmp: convert to use object_property_foreach iterators

On 10/08/2015 08:09 AM, Daniel P. Berrange wrote: > Rather than directly traversing the object property list, > use the object_property_foreach iterator. This removes a > dependancy on the implementation approach for properties. s/dependancy/dependency/ > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync

On 10/07/2015 12:44 PM, Paolo Bonzini wrote: On 07/10/2015 08:20, Denis V. Lunev wrote: +if (migrate_is_test()) { +/* since no data is transfered during estimation all + all measurements below will be incorrect. + as well no need for delays. */ +

  1   2   3   >