Re: [Qemu-devel] [PATCH v2 4/5] vhost: move virtio 1.0 check to cross-endian helper

On 11/01/2016 17:13, Greg Kurz wrote: > Indeed vhost doesn't need to ask for vring endian fixing if the device is > virtio 1.0, since it is already handled by the in-kernel vhost driver. This > patch simply consolidates the logic into the existing helper. > > Signed-off-by: Greg Kurz

Re: [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params

On 11 January 2016 at 20:16, Lluís Vilanova wrote: > Great! I implemented a similar thing long time ago. In my case the machinery > is > completely hidden under the concept of "value promises" in TCG (i.e., the user > does not need to know about TCG internals like

Re: [Qemu-devel] [PATCH v2 5/5] virtio: optimize virtio_access_is_big_endian() for little-endian targets

On 11/01/2016 17:18, Greg Kurz wrote: > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro > and the virtio_access_is_big_endian() helper to have a branchless fast path > in the virtio memory accessors for targets that don't switch endian. > > This was considered as a

Re: [Qemu-devel] [PATCH v2 3/5] virtio: move cross-endian helper to vhost

On 11/01/2016 17:13, Greg Kurz wrote: > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > indeed returns the runtime state of the virtio device. However, it returns > false unconditionally in the general case. This sounds a bit strange > given the name of the function. >

Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification

On 01/11/2016 08:05 AM, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of

Re: [Qemu-devel] [PATCH 2/4] macio: add dma_active to VMStateDescription

On 08/01/16 20:55, John Snow wrote: > On 01/06/2016 04:17 PM, Mark Cave-Ayland wrote: >> On 06/01/16 20:57, John Snow wrote: >> >>> On 01/06/2016 03:37 PM, Mark Cave-Ayland wrote: Make sure that we include the value of dma_active in the migration stream. Signed-off-by: Mark

[Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

Instead of relying on peeking at bs->job, we want to explicitly get a reference to the job that was involved in this notifier callback. Extend the Notifier to include a job pointer, and include a reference to the job registering the callback. This cuts out a few more cases where we have to rely

[Qemu-devel] [PATCH 0/5] block: reduce reliance on bs->job pointer

This is a small collection of patches to reduce our use of the bs->job pointer where possible. There are still more usages in the code, but this cuts down on a few. The goal is to eventually eliminate all of them and allow multiple block jobs to run concurrently, but design on what that will look

[Qemu-devel] [PATCH 2/5] block: Allow stream_start to return job references

stream_start now picks up a reference for its return value, a copy of the job started. callers are responsible for putting it down when they are done with it. This removes a minor reference to bs->job in qmp_block_stream, for a simple tracing function. Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH 2/2] ppc: Allow 64kiB pages for POWER8 in TCG

On Fri, Jan 08, 2016 at 02:56:02PM +1100, Alexey Kardashevskiy wrote: > On 12/21/2015 01:41 PM, David Gibson wrote: > >Now that the spapr code has been extended to support 64kiB pages, we can > >allow guests to use 64kiB pages on an emulated POWER8 by adding it to the > >"segment_page_sizes"

Re: [Qemu-devel] [v15 12/15] vfio: add bus in reset flag

On 01/07/2016 12:44 AM, Alex Williamson wrote: On Wed, 2016-01-06 at 10:13 +0800, Chen Fan wrote: On 01/06/2016 03:58 AM, Alex Williamson wrote: On Tue, 2016-01-05 at 09:20 +0800, Cao jin wrote: From: Chen Fan mark the host bus be in reset. avoid multiple

Re: [Qemu-devel] [PATCH v4 1/1] xlnx-zynqmp: Add support for high DDR memory regions

On Mon, Jan 11, 2016 at 8:04 AM, Peter Maydell wrote: > On 5 January 2016 at 22:05, Alistair Francis > wrote: >> The Xilinx ZynqMP SoC and EP108 board supports three memory regions: >> - A 2GB region starting at 0 >> - A 32GB region

[Qemu-devel] [PATCH v2] sdhci: add quirk property for card insert interrupt status on Raspberry Pi

This quirk is a workaround for the following hardware behaviour, on which UEFI (specifically, the bootloader for Windows on Pi2) depends: 1. at boot with an SD card present, the interrupt status/enable registers are initially zero 2. upon enabling it in the interrupt enable register, the card

Re: [Qemu-devel] [PATCH v2 2/5] Revert "vhost-net: tell tap backend about the vnet endianness"

On 11/01/2016 17:12, Greg Kurz wrote: > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991. > > Cross-endian is now handled by the core virtio-net code. > > Signed-off-by: Greg Kurz > --- > v2: > - moved changes not belonging to the revert to patch 1 > -

Re: [Qemu-devel] [PATCH v2 1/5] virtio-net: use the backend cross-endian capabilities

On 11/01/2016 17:12, Greg Kurz wrote: > When running a fully emulated device in cross-endian conditions, including > a virtio 1.0 device offered to a big endian guest, we need to fix the vnet > headers. This is currently handled by the virtio_net_hdr_swap() function > in the core virtio-net code

[Qemu-devel] [PATCH 1/5] block: Allow mirror_start to return job references

Pick up an extra reference in mirror_start_job to allow callers of mirror_start and commit_active_start to get a reference to the job they have created. Phase out callers from fishing the job out of bs->job -- use the return value instead. Callers of mirror_start_job and commit_active_start are

[Qemu-devel] [PATCH 5/5] blockjob: add Job parameter to BlockCompletionFunc

It will no longer be sufficient to rely on the opaque parameter containing a BDS, and there's no way to reliably include a self-reference to the job we're creating, so always pass the Job object forward to any callbacks. Signed-off-by: John Snow --- block/backup.c|

[Qemu-devel] [PATCH 3/5] block: allow backup_start to return job references

backup_start picks up a reference to return the job it created to a caller. callers are updated to put down the reference when they are finished. This is particularly interesting for transactions where backup jobs pick up an implicit reference to the job. Previously, we check to see if the job

Re: [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h

04.12.2015 20:34, Peter Maydell wrote: > Our use of glib is now pervasive across QEMU. Move the include of > glib-compat.h > from qemu-common.h to osdep.h so that it is more widely accessible and doesn't > get forgotten by accident. (Failure to include it will result in build failure > on old

Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

18.12.2015 15:59, Peter Maydell wrote: > The checkpatch.pl script has a special case to permit the following > operators to have no spaces around them: > << >> & ^ | + - * / % > > QEMU style prefers all operators to consistently have spacing around > them, so remove this special case

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

On Sun, Jan 10, 2016 at 10:56:55AM +0300, Michael Tokarev wrote: > So, what's the status of this issue now? > (it is CVE-2015-8619 btw, maybe worth to mention this in the commit message) Seems we concluded it's best to keep keyname_len around and simply check it against the sizeof(keyname_buf).

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

+-- On Mon, 11 Jan 2016, Wolfgang Bumiller wrote --+ | Seems we concluded it's best to keep keyname_len around and simply check it | against the sizeof(keyname_buf). | | Here's a full new version as I haven't seen one yet. (With an adapted commit | message and the CVE id added.) Sorry, i

Re: [Qemu-devel] QEMU/KVM performance gets worser - high load - high interrupts - high context switches

On 09/01/2016 17:46, Gerhard Wiesinger wrote: > > # Positive consequences via munin monitoring: > # Reduced fork rate: 40 => 13 > # process states: running 15 => <1 > # CÜU temperature: (core dependant) 65-70°C => 56-64°C > # CPU usage: system: 47% => 15%, user: 76% => 50% > # Context Switches:

Re: [Qemu-devel] [PATCH] PCI: add param check for api

21.11.2015 10:45, Cao jin wrote: > add param check for pci_add_capability2, as it is a public API. > > Signed-off-by: Cao jin > --- > hw/pci/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 168b9cc..6938f64 100644 >

Re: [Qemu-devel] [PATCH] block: acquire in bdrv_query_image_info

On 25/12/2015 02:51, Fam Zheng wrote: > On Wed, 12/23 11:48, Paolo Bonzini wrote: >> NFS calls aio_poll inside bdrv_get_allocated_size. This requires >> acquiring the AioContext. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/qapi.c | 9 +++-- >> 1 file changed, 7

[Qemu-devel] [PULL 00/19] Trivial patches for 2016-01-11

This is the first trivial-patches pull request for 2016 year, and the first one for qemu 2.6 series. With some old stuff in there, collecting missing patches since Nov-2015. There's nothing exciting in there, except of a possible fun patch enabling sigaltstack syscall. Please consider

[Qemu-devel] [PULL 05/19] MAINTAINERS: Add the correct device_tree.h file

From: Thomas Huth device_tree.h is not in the main directory, but under include/sysemu/ nowadays. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 01/19] unicore32: convert get_sp_from_cpustate from macro to inline

All other architectures define get_sp_from_cpustate as an inline function, only unicore32 uses a #define. With this, some usages are impossible, for example, enabling sigaltstack in linux-user/syscall.c results in linux-user/syscall.c: In function ‘do_syscall’: linux-user/syscall.c:8299:39:

[Qemu-devel] [PULL 07/19] xen/Makefile.objs: simplify

From: Cao jin merge last two lines, keep alphabetic order. Signed-off-by: Cao jin Reviewed-by: Stefan Weil Reviewed-by: Stefano Stabellini Signed-off-by: Michael Tokarev

[Qemu-devel] [PATCH v2 1/3] linux-user/mmap.c: Set prot page flags for the correct region in mmap_frag()

From: Chen Gang mmap() size in mmap_frag() is qemu_host_page_size, but the outside calls page_set_flags() may be not with qemu_host_page_size. So after mmap(), call page_set_flags() in time. After this fix, for the next call for the same region, prot1 will be

[Qemu-devel] [PATCH v2 3/3] linux-user/mmap.c: Use TARGET_PAGE_SIZE as the increasing step

From: Chen Gang Just like another areas have done. --- linux-user/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 51c381d..86c270b 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -151,7

[Qemu-devel] [PULL 11/19] gt64120: convert to realize()

From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/mips/gt64xxx_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index

[Qemu-devel] [PULL 03/19] net: convert qemu_log to error_report, fix message

From: Paolo Bonzini Ensure that the error is printed with the proper timestamp. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- net/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dump.c

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

Hi, > I can boot up Linux VM with IGD pass-through with latest qemu (without > any additional patch), guest run 3D "nexuiz" and get 180fps. That is a pretty recent linux guest I assume? Tried older kernels too, possibly even the old userspace xorg driver? Do windows guest work as well?

[Qemu-devel] [PULL 15/19] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h

From: Peter Maydell Our use of glib is now pervasive across QEMU. Move the include of glib-compat.h from qemu-common.h to osdep.h so that it is more widely accessible and doesn't get forgotten by accident. (Failure to include it will result in build failure on old

[Qemu-devel] [PULL 09/19] hw/misc/edu: Convert to realize()

From: Cao jin for educational PCI device Signed-off-by: Cao jin Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- hw/misc/edu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 14/19] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

From: Peter Maydell The checkpatch.pl script has a special case to permit the following operators to have no spaces around them: << >> & ^ | + - * / % QEMU style prefers all operators to consistently have spacing around them, so remove this special case

[Qemu-devel] [PULL 19/19] hw/s390x: Remove superfluous return statements

From: Thomas Huth The "return;" statements at the end of functions do not make much sense, so let's remove them. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: Richard Henderson

[Qemu-devel] [PULL 18/19] hw/core/qdev: Remove superfluous return statement

From: Thomas Huth The "return;" statement at the end of device_set_realized() does not make much sense, so let's remove it. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/core/qdev.c | 1 - 1 file changed, 1 deletion(-)

Re: [Qemu-devel] [PATCH v2] linux-user: syscall: Add SO_LINGER for setsockopt

Le 11/01/2016 07:47, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Just implement it according to the other features implementations. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 18 +- >

[Qemu-devel] [PATCH v2 2/3] linux-user/mmap.c: Remove useless variable p for mmap_frag

From: Chen Gang It is useless. Signed-off-by: Chen Gang --- linux-user/mmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 7807ed0..51c381d 100644 ---

Re: [Qemu-devel] [PATCH] PCI: add param check for api

On 11/01/2016 09:32, Michael Tokarev wrote: >> > >> > +assert(size > 0); >> > +assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset); >> > + > I'd like to see some ACKs/Reviews for this one, in particular why > size should be != 0. In fact it should be >= 2, because two bytes are always

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

On Fr, 2016-01-08 at 19:32 +0100, Laszlo Ersek wrote: > On 01/08/16 18:45, Igor Mammedov wrote: > > On Fri, 8 Jan 2016 13:58:03 +0100 > > Gerd Hoffmann wrote: > > > >> This patch extends the functionality of the max-ram-below-4g option > >> to also allow increasing lowmem.

[Qemu-devel] [PULL 08/19] configure: fix trace backend check

From: Marc-André Lureau Found thanks to shellcheck! Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- configure | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 06/19] crypto: Fix typo in example

From: Eric Blake The example code wouldn't even compile, since it did not use a consistent spelling for the Error ** parameter. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrange Signed-off-by: Michael Tokarev

[Qemu-devel] [PATCH v2] linux-user/syscall.c: Add SO_RCVTIMEO and SO_SNDTIMEO for getsockopt

From: Chen Gang Implement them according to the other features implementations. Signed-off-by: Chen Gang --- linux-user/syscall.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 3/3] 9pfs: introduce V9fsVirtioState

V9fsState now only contains generic fields. Introduce V9fsVirtioState for virtio transport. Change virtio-pci and virtio-ccw to use V9fsVirtioState. Signed-off-by: Wei Liu --- v3: only include code to introduce V9fsVirtioState --- hw/9pfs/9p.c | 6 ++--

[Qemu-devel] [PATCH v3 1/3] fsdev: 9p-marshal: introduce V9fsBlob

Introduce a concept of blob. It will be used to pack / unpack xattr value. With this change there is no need to expose v9fs_pack to device code anymore. Signed-off-by: Wei Liu --- v3: use 'd' to encode / decode blob size --- fsdev/9p-iov-marshal.c | 26

[Qemu-devel] [PATCH v3 0/3] 9pfs: disentangling virtio and generic code

Hi all This is version 3 of this series. It is based on https://github.com/kvaneesh/qemu/commits/upstream-v9fs so it only contains patches that are not in that branch. These three patches were tested with Turex POSIX test suite 20080816 and 20090130-rc. It passed all tests in 20080816 and

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

Apologies; I overlooked that detail: Signed-off-by: Ashley Jonathan Regards, -- Jon Ashley -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: 11 January 2016 09:16 To: Ashley Jonathan;

Re: [Qemu-devel] [Qemu-block] [PATCH] send readcapacity10 when readcapacity16 failed

On 11/01/2016 09:49, Peter Lieven wrote: > > +if (task != NULL && task->status == SCSI_STATUS_CHECK_CONDITION > > +&& task->sense.key == SCSI_SENSE_UNIT_ATTENTION) { > > +break; > > +} > > Paolo, Ronnie, do you know what Readcapacity(10)

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

On Mon, Jan 11, 2016 at 10:46:20AM +, Stefano Stabellini wrote: > On Mon, 11 Jan 2016, Hao, Xudong wrote: > > Stefano, > > > > Patch http://marc.info/?l=qemu-devel=145137863501079 don't works for qemu > > at all, some conflict when git apply. > > Patch

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

11.12.2015 14:29, Ashley Jonathan wrote: > I have experienced a minor difficulty using QEMU with the "-serial pty" > option: > > If a process opens the slave pts device, writes data to it, then immediately > closes it, the data doesn't reliably get delivered to the emulated serial > port. This

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

On 25/12/2015 02:55, Fam Zheng wrote: > On Wed, 12/23 11:48, Paolo Bonzini wrote: >> This is also needed in bdrv_drain_all, not just in bdrv_drain. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/io.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

[Qemu-devel] Recall: [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

Hao, Xudong would like to recall the message, "[Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()".

[Qemu-devel] [PULL 13/19] PCI Bonito: QOMify and cleanup

From: Cao jin Also clear the code Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/pci-host/bonito.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH] send readcapacity10 when readcapacity16 failed

Am 07.01.2016 um 11:07 schrieb Paolo Bonzini: > > On 06/01/2016 18:57, John Snow wrote: >> Ronnie: Thanks for the explanation! >> >> Zhu: In light of this, can the patch be reworked slightly to explicitly >> check *why* READCAPACITY16 failed and only attempt the READCAPACITY10 as >> a fallback if

[Qemu-devel] [PULL 12/19] SH PCI Host: convert to realize()

From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/sh4/sh_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index a2f6d9e..4509053 100644

[Qemu-devel] [PULL 10/19] Add missing syscall nrs. according to more recent Linux kernels

From: Johan Ouwerkerk This change covers arm, aarch64, mips. Others to follow? The change was prompted by QEMU warning about a syscall 384 (get_random()) with Debian armhf binaries (ARMv7). Signed-off-by: Johan Ouwerkerk Reviewed-by: Peter

[Qemu-devel] [PULL 02/19] linux-user: enable sigaltstack for all architectures

There is no reason to limit sigaltstack syscall to just a few architectures and pretend it is not implemented for others. If some architecture is not ready for this, that architecture should be fixed instead. This fixes LP#1516408. Signed-off-by: Michael Tokarev Reviewed-by:

[Qemu-devel] [PATCH v3 2/3] 9pfs: use V9fsBlob to transmit xattr

And make v9fs_pack static function. Now we only need to export v9fs_{,un}marshal to device. Signed-off-by: Wei Liu --- v3: fix bug discovered by Aneesh --- fsdev/9p-iov-marshal.c | 4 ++-- fsdev/9p-iov-marshal.h | 3 --- hw/9pfs/9p.c | 21 +

Re: [Qemu-devel] [PATCH v2 3/7] device_tree: introduce qemu_fdt_node_path

Hi David, On 01/11/2016 03:38 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:21PM +, Eric Auger wrote: >> This new helper routine returns the node path of a device >> referred to by its node name and compat string. > > What if there are multiple nodes matching the name and compat?

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: >> recent libnfs versions support logging debug messages. Add >> support for it in qemu through an URL parameter. >> >> Example: >> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2 >> >>

[Qemu-devel] [PULL 17/19] hw/acpi: Remove superfluous return statement

From: Thomas Huth The "return;" statement at the end of acpi_memory_plug_cb() does not make much sense, so let's remove it. Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Signed-off-by: Thomas Huth Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Add SO_RCVTIMEO and SO_SNDTIMEO for getsockopt

Le 11/01/2016 09:54, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Implement them according to the other features implementations. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 27 +-- > 1

[Qemu-devel] [PULL 16/19] hw/ide: Remove superfluous return statements

From: Thomas Huth The "return;" statements at the end of functions do not make much sense, so let's remove them. Cc: qemu-bl...@nongnu.org Signed-off-by: Thomas Huth Reviewed-by: John Snow Signed-off-by: Michael Tokarev

[Qemu-devel] [PULL 04/19] iscsi: fix readcapacity error message

From: Zhu Lingshan fix:The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure, fixed the error message. Signed-off-by: Zhu Lingshan Reviewed-by: John Snow Signed-off-by: Michael Tokarev ---

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

On 11/12/2015 12:29, Ashley Jonathan wrote: > I have experienced a minor difficulty using QEMU with the "-serial > pty" option: > > If a process opens the slave pts device, writes data to it, then > immediately closes it, the data doesn't reliably get delivered to the > emulated serial port.

Re: [Qemu-devel] [RFC v6 11/14] softmmu: Simplify helper_*_st_name, wrap MMIO code

On Mon, Jan 11, 2016 at 10:54 AM, Alex Bennée wrote: > > Alvise Rigo writes: > >> Attempting to simplify the helper_*_st_name, wrap the MMIO code into an >> inline function. >> >> Suggested-by: Jani Kokkonen >>

Re: [Qemu-devel] [PATCH] PCI Bonito: QOMify

05.01.2016 13:57, Cao jin wrote: > Also clear the code Applied to -trivial. Thanks, /mjt

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

11.01.2016 11:07, Michael Tokarev wrote: > 30.12.2015 22:54, Sitsofe Wheeler wrote: >> Indented lines in the texi meant the perlpod produced interpreted the >> paragraph as being verbatim (thus formatting codes were not >> interpreted). Fix this by un-indenting problem lines. > > Applied to

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

30.12.2015 22:54, Sitsofe Wheeler wrote: > Indented lines in the texi meant the perlpod produced interpreted the > paragraph as being verbatim (thus formatting codes were not > interpreted). Fix this by un-indenting problem lines. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

Stefano, Patch http://marc.info/?l=qemu-devel=145137863501079 don't works for qemu at all, some conflict when git apply. Patch http://marc.info/?l=qemu-devel=145137863501079 is based on patch http://marc.info/?l=qemu-devel=145172165010604, right? I can boot up Linux VM with IGD pass-through

Re: [Qemu-devel] [RFC v6 11/14] softmmu: Simplify helper_*_st_name, wrap MMIO code

Alvise Rigo writes: > Attempting to simplify the helper_*_st_name, wrap the MMIO code into an > inline function. > > Suggested-by: Jani Kokkonen > Suggested-by: Claudio Fontana > Signed-off-by: Alvise Rigo

Re: [Qemu-devel] [PATCH v2 5/7] hw/arm/sysbus-fdt: helpers for clock node generation

Hi David, On 01/11/2016 03:41 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:23PM +, Eric Auger wrote: >> Some passthrough'ed devices depend on clock nodes. Those need to be >> generated in the guest device tree. This patch introduces some helpers >> to build a clock node from

Re: [Qemu-devel] [PATCH 0/4] Remove superfluous return statements

10.11.2015 23:16, Thomas Huth wrote: > Some functions in QEMU have a "return;" statement at the > very end of a function with "void" return type, i.e. the > return statement is superfluous. This patch series removes > some of them. > > Thomas Huth (4): > hw/ide: Remove superfluous return

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

On 11/01/2016 09:33, Michael Tokarev wrote: > 11.12.2015 14:29, Ashley Jonathan wrote: >> I have experienced a minor difficulty using QEMU with the "-serial pty" >> option: >> >> If a process opens the slave pts device, writes data to it, then immediately >> closes it, the data doesn't

[Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue

With automatically generated GUID, on minor version changes, an error occurred, stating that there is a problem with the installer. Now, a notification is shown, warning the user that another version of this product is already installed, and that configuration or removal of the existing version is

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: disentangling virtio and generic code

I forgot to mention -- this series can be pulled from: git://xenbits.xen.org/people/liuw/qemu.git wip.9pfs-refactor-v3 Wei.

Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state

On 12/16/2015 05:47 PM, Denis V. Lunev wrote: On 12/16/2015 03:02 PM, Paolo Bonzini wrote: On 16/12/2015 10:50, Peter Krempa wrote: We check that the state is "paused" and continue the vCPUs only in that case. The panic devices will move the VM to 'crashed' state. The code that is issuing

Re: [Qemu-devel] [Qemu-block] [PATCH V5] block/nfs: add support for setting debug level

On Mon, Jan 11, 2016 at 09:51:39AM +0100, Peter Lieven wrote: > Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: > >> recent libnfs versions support logging debug messages. Add > >> support for it in qemu through an URL parameter. >

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

On Mon, 11 Jan 2016, Hao, Xudong wrote: > Stefano, > > Patch http://marc.info/?l=qemu-devel=145137863501079 don't works for qemu > at all, some conflict when git apply. > Patch http://marc.info/?l=qemu-devel=145137863501079 is based on patch > http://marc.info/?l=qemu-devel=145172165010604,

[Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

Turning debug printfs to trace points for register access Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 68 +--- trace-events | 6 + 2 files changed, 16 insertions(+), 58 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with delta = load = 0

On Sat, Jan 09, 2016 at 08:39:53PM +0300, Dmitry Osipenko wrote: > Currently ptimer would print error message and clear enable flag for an > arming timer that has delta = load = 0. That actually could be a valid case > for some hardware, like instant IRQ trigger for oneshot timer or continuous >

Re: [Qemu-devel] [PATCH v10 6/7] hw/ptimer: Introduce ptimer_get_limit

On Sat, Jan 09, 2016 at 08:39:54PM +0300, Dmitry Osipenko wrote: > Currently ptimer users are used to store copy of the limit value, because > ptimer doesn't provide facility to retrieve the limit. Let's provide it. > > Signed-off-by: Dmitry Osipenko Fair call. One less piece

Re: [Qemu-devel] [PATCH] block: Fix .bdrv_open flags

On 01/11/2016 09:32 PM, Kevin Wolf wrote: bdrv_common_open() modified bs->open_flags after inferring the set of options to pass to the driver's .bdrv_open callback. This means that the cache options were correctly set in bs->open_flags (and therefore correctly displayed in 'info block'), but the

[Qemu-devel] [PATCH 15/25] 9pfs: factor out virtio_pdu_{, un}marshal

From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 14 ++ hw/9pfs/virtio-9p.c| 6 ++ hw/9pfs/virtio-9p.h| 5 + 3 files changed,

[Qemu-devel] [PATCH 01/25] 9pfs: rename virtio-9p-coth.{c, h} to coth.{c, h}

From: Wei Liu Those two files are not virtio specific. Rename them to use generic names. Fix includes in various C files. Change define guards and comments in header files. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH 12/25] 9pfs: PDU processing functions don't need to take V9fsState as argument

From: Wei Liu V9fsState can be referenced by pdu->s. Initialise that in device realization function. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 1 + hw/9pfs/virtio-9p.c

[Qemu-devel] [PATCH 08/25] 9pfs: merge hw/virtio/virtio-9p.h into hw/9pfs/virtio-9p.h

From: Wei Liu The deleted file only contained V9fsConf which wasn't virtio specific. Merge that to the general header of 9pfs. Fixed header inclusions as I went along. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH 22/25] 9pfs: rename virtio_9p_set_fd_limit to use v9fs_ prefix

From: Wei Liu It's not virtio specific. Signed-off-by: Wei Liu --- hw/9pfs/virtio-9p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 7fb05240987e..379fdcb2fe86 100644 ---

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: > > Turning debug printfs to trace points for register access Hello Miao! While I’m into adding trace points I don’t really like the decrease of logs usability introduced by this patch. Current code produces clear human

Re: [Qemu-devel] [PATCH] PCI: add param check for api

Thanks for your time. I almost forget this one... On 01/11/2016 05:20 PM, Paolo Bonzini wrote: On 11/01/2016 09:32, Michael Tokarev wrote: +assert(size > 0); +assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset); + I'd like to see some ACKs/Reviews for this one, in particular why

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

ping On 12/24/2015 12:33 PM, Andrey Smetanin wrote: Lately tsc page was implemented but filled with empty values. This patch setup tsc page scale and offset based on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value. The valid tsc page drops HV_X64_MSR_TIME_REF_COUNT msr reads count to

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote: > > Hi Dmitry, > > 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : >> >>> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: >>> >>> Turning debug printfs to trace points for register

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

On 01/08/2016 09:23 PM, Corey Minyard wrote: > Acked-by: Corey Minyard > > I agree with Greg's comments, too. Me also. I will rework the code to use ARRAY_SIZE or something similar. Thanks, C. > -corey > > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >>

Re: [Qemu-devel] [PATCH 4/8] ipmi: add FRU support

Hello, On 01/08/2016 08:41 PM, Corey Minyard wrote: > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >> This patch provides a simplistic FRU support for the IPMI BMC >> simulator. The FRU area contains 32 entries * 256 bytes which should >> be enough to start some simulation. >> >>

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/11/2016 08:59 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 01/08/2016 07:19 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: From: zhangchen Hi,all This patch add an

Re: [Qemu-devel] [PATCH 5/8] ipmi: add ACPI power and GUID commands

On 01/08/2016 08:46 PM, Corey Minyard wrote: > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/ipmi/ipmi_bmc_sim.c | 55 >> ++ >> 1 file changed, 55 insertions(+) >> >> diff --git

[Qemu-devel] [PATCH 13/25] 9pfs: PDU processing functions should start pdu_ prefix

From: Wei Liu This matches naming convention of pdu_marshal and pdu_unmarshal. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 88 ++---

  1   2   3   4   5   >