Re: [Qemu-devel] [PATCH 0/2] Active commit regression fix

2016-02-01 Thread Eric Blake
On 01/29/2016 10:17 PM, Jeff Cody wrote: > Bug #1300209 is a regression in 2.5, introduced during the > change away from bdrv_swap(). > > When we change the parent backing link (change_parent_backing_link), > we must also accomodate non-NULL tqe_prev pointers that point to a > NULL entry.

Re: [Qemu-devel] [Qemu-arm] Does QEMU support AArch64 Big Endian emulation on x86-64 host?

2016-02-01 Thread Peter Crosthwaite
On Mon, Feb 1, 2016 at 3:25 AM, Ruslan Bilovol wrote: > On Wed, Jan 27, 2016 at 7:39 PM, Peter Crosthwaite > wrote: >> On Tue, Jan 26, 2016 at 4:05 AM, Ruslan Bilovol >> wrote: >>> On Mon, Jan 25, 2016 at 6:07 PM,

Re: [Qemu-devel] [PATCH] fdc: fix detection under Linux

2016-02-01 Thread Hervé Poussineau
Le 29/01/2016 23:35, John Snow a écrit : Accidentally, I removed a "feature" where empty drives had geometry values applied to them, which allows seek on empty drives to work "by accident," as QEMU actually tries to disallow that. Seeks on empty drives should work, though, but the easiest thing

[Qemu-devel] [PATCH] kvm-all: trace: strerror fixup

2016-02-01 Thread Andrew Jones
Signed-off-by: Andrew Jones --- kvm-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 9148889921197..330f509a0da84 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2362,7 +2362,7 @@ int kvm_set_one_reg(CPUState *cs, uint64_t

Re: [Qemu-devel] [PATCH v8] spec: add qcow2 bitmaps extension specification

2016-02-01 Thread Max Reitz
On 27.01.2016 16:52, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such

[Qemu-devel] [PATCH V2 1/2] ARM: PL061: Clear PL061 device state after reset

2016-02-01 Thread Wei Huang
Current QEMU doesn't clear PL061 state after reset. This causes a weird issue with guest reboot via GPIO. Here is the device state description with two reboot requests: (PL061State fields) data old_in_data istate VM boot 0 0 0 After 1st

[Qemu-devel] [PATCH V2 2/2] ARM: PL061: Cleaning field of PL061 device state

2016-02-01 Thread Wei Huang
This patch removes the float_high field of PL061State, which doesn't seem to be used anywhere. Because this changes the device state, the version ID is also bumped up for the reason of compatiblity. Signed-off-by: Wei Huang --- hw/gpio/pl061.c | 6 ++ 1 file changed, 2

Re: [Qemu-devel] [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-01 Thread Alex Williamson
On Mon, 2016-02-01 at 14:10 +0100, Gerd Hoffmann wrote: >   Hi, >  > > > Unfortunately it's not the only one. Another example is, device-model > > > may want to write-protect a gfn (RAM). In case that this request goes > > > to VFIO .. how it is supposed to reach KVM MMU? > >  > > Well, let's work

Re: [Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread Eric Blake
On 02/01/2016 03:18 PM, John Snow wrote: > Signed-off-by: John Snow > --- > blockjob.c | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Eric Blake > > diff --git a/blockjob.c b/blockjob.c > index 80adb9d..a692142 100644 > --- a/blockjob.c > +++

Re: [Qemu-devel] [PATCH v2 0/3] SD emulation fixes for Pi2 Tianocore EDK2 UEFI

2016-02-01 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Monday, 25 January 2016 10:37 > > On 25 January 2016 at 18:06, Andrew Baumann > wrote: > > This is the most recent version of the patch series. However, > > there was an unresolved question about

Re: [Qemu-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Alex Williamson
On Mon, 2016-02-01 at 13:49 +0100, Gerd Hoffmann wrote: > > > Maybe we should define the interface as "guest writes 0xfc to pick > > > address, qemu takes care to place opregion there".  That gives us the > > > freedom to change the qemu implementation (either copy host opregion or > > > map the

[Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread John Snow
Signed-off-by: John Snow --- blockjob.c | 8 1 file changed, 8 deletions(-) diff --git a/blockjob.c b/blockjob.c index 80adb9d..a692142 100644 --- a/blockjob.c +++ b/blockjob.c @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job) } } -struct

[Qemu-devel] [PATCH v3 0/3] SD emulation fixes for Pi2 Tianocore EDK2 UEFI

2016-02-01 Thread Andrew Baumann
This series contains fixes to the SD card emulation that are needed to unblock Tianocore EDK2 UEFI (specifically, the bootloader for Windows on Raspberry Pi 2). Changes in v2, based on feedback from Peter Crosthwaite: * correct implementation of CMD23 to switch to transfer state on completion *

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

2016-02-01 Thread Eric Blake
On 02/01/2016 05:31 AM, Markus Armbruster wrote: >> |+visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, ); >> | if (err) { >> | goto out; >> | } >> | visit_type_ACPIOSTInfo(v, , "info", ); >> | if (err) { >> |-goto out; >> |+goto out_obj; >> |

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: change parent backing link when *tqe_prev == NULL

2016-02-01 Thread Max Reitz
On 30.01.2016 06:17, Jeff Cody wrote: > In change_parent_backing_link(), we only inserted the new > BlockDriverState entry into the device_list if the tqe_prev pointer was > NULL. However, we must also allow insertion when the BDS pointed > to by the tqe_prev pointer is NULL as well. > > This

Re: [Qemu-devel] [RFC PATCH 0/3] (Resend) TranslationBlock annotation mechanism

2016-02-01 Thread Lluís Vilanova
Lluís Vilanova writes: > Bastian Koppelmann writes: >> Hi Lluis, >> On 01/27/2016 07:54 PM, Lluís Vilanova wrote: [...] >>> >>> So, I'd say that such support is on the list of current developments (at >>> least >>> mine, specially now that I have a bit more time for it). But getting the >>>

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Eric Blake
On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. > > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node"

[Qemu-devel] [PATCH v3 1/3] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2016-02-01 Thread Andrew Baumann
CMD23 is optional for SD but required for MMC, and the UEFI bootloader used for Windows on Raspberry Pi 2 issues it. Reviewed-by: Peter Crosthwaite Signed-off-by: Andrew Baumann --- hw/sd/sd.c | 37 +

[Qemu-devel] [RFC] Programmable guest-to-QEMU hypercalls

2016-02-01 Thread Lluís Vilanova
Hi! I have in my trace instrumentation queue a series that adds a very simple but efficient way to trigger code in QEMU from guest code using guest-agnostic code. Blue Swirl showed some interest long ago in using it in the test suite (e.g., instruct QEMU to check the vCPU state after a series of

[Qemu-devel] [PATCH v3 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2016-02-01 Thread Andrew Baumann
The SD spec for ACMD41 says that a zero argument is an "inquiry" ACMD41, which does not start initialisation and is used only for retrieving the OCR. However, Tianocore EDK2 (UEFI) has a bug [1]: it first sends an inquiry (zero) ACMD41. If that first request returns an OCR value with the power up

[Qemu-devel] [PATCH v3 3/3] hw/sd: use guest error logging rather than fprintf to stderr

2016-02-01 Thread Andrew Baumann
Some of these errors may be harmless (e.g. probing unimplemented commands, or issuing CMD12 in the wrong state), and may also be quite frequent. Spamming the standard error output isn't desirable in such cases. Reviewed-by: Peter Crosthwaite Signed-off-by: Andrew

Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description

2016-02-01 Thread Alistair Francis
On Sat, Jan 30, 2016 at 1:35 AM, Michael Tokarev wrote: > 18.01.2016 21:42, Alistair Francis wrote: >> The description of object_property_get_int() stated that on an error >> it returns NULL. This is not the case and the function will return -1 >> if an error occurs. Update the

Re: [Qemu-devel] [PATCH v9 23/37] qmp: Support explicit null during input visit

2016-02-01 Thread Eric Blake
On 01/22/2016 10:12 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Implement the new type_null() callback for the qmp input visitor. >> While we don't yet have a use for this in qapi (the generator >> will need some tweaks first), one usage is already envisioned: >>

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: change parent backing link when *tqe_prev == NULL

2016-02-01 Thread Jeff Cody
On Mon, Feb 01, 2016 at 10:43:02PM +0100, Max Reitz wrote: > On 30.01.2016 06:17, Jeff Cody wrote: > > In change_parent_backing_link(), we only inserted the new > > BlockDriverState entry into the device_list if the tqe_prev pointer was > > NULL. However, we must also allow insertion when the

[Qemu-devel] [PULL 14/17] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-02-01 Thread Jason Wang
From: Laszlo Ersek The start_xmit() and e1000_receive_iov() functions implement DMA transfers iterating over a set of descriptors that the guest's e1000 driver prepares: - the TDLEN and RDLEN registers store the total size of the descriptor area, - while the TDH and RDH

[Qemu-devel] [PULL 16/17] net: always walk through filters in reverse if traffic is egress

2016-02-01 Thread Jason Wang
From: Li Zhijian Previously, if we attach more than one filters for a single netdev, both ingress and egress traffic will go through net filters in same order like: ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emulated device egress: emulated device ->filter1

[Qemu-devel] [PULL 13/17] slirp: Adding family argument to tcp_fconnect()

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Kay, Allen M
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Sunday, January 31, 2016 9:42 AM > To: Kay, Allen M; Gerd Hoffmann; David Woodhouse > Cc: igv...@ml01.01.org; xen-de...@lists.xensource.com; Eduardo Habkost; > Stefano Stabellini;

[Qemu-devel] [PATCH v4] blockjob: Fix hang in block_job_finish_sync

2016-02-01 Thread Fam Zheng
With a mirror job running on a virtio-blk dataplane disk, sending "q" to HMP will cause a dead loop in block_job_finish_sync. This is because the aio_poll() only processes the AIO context of bs which has no more work to do, while the main loop BH that is scheduled for setting the job->completed

Re: [Qemu-devel] [PATCH v3 0/4] Netfilter: Add each netdev a default filter

2016-02-01 Thread Yang Hongyang
If we have to add a default filter, then I have a suggestion only for this series: 1. Add a nop filter. filter-nop.c 2. Add a "default-filter=xxx" property to -netdev, if not specified, default to nop. On 02/01/2016 08:01 PM, zhanghailiang wrote: This series is a prerequisite for COLO, here

[Qemu-devel] [PATCH v2 0/2] Active commit regression fix

2016-02-01 Thread Jeff Cody
Changes from v1: * Rather than allow insertion when bs->device_listtqe_prev points to a NULL entry, make sure than we follow the block scheme of enforcing bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!) Bug #1300209 is a regression in 2.5, introduced during the change away

[Qemu-devel] [PATCH v2 2/2] block: qemu-iotests - add test for snapshot, commit, snapshot bug

2016-02-01 Thread Jeff Cody
Signed-off-by: Jeff Cody --- tests/qemu-iotests/143 | 114 + tests/qemu-iotests/143.out | 24 ++ tests/qemu-iotests/group | 1 + 3 files changed, 139 insertions(+) create mode 100755 tests/qemu-iotests/143 create

[Qemu-devel] [PATCH v2 1/2] block: set device_list.tqe_prev to NULL on BDS removal

2016-02-01 Thread Jeff Cody
This fixes a regression introduced with commit 3f09bfbc7. Multiple bugs arise in conjunction with live snapshots and mirroring operations (which include active layer commit). After a live snapshot occurs, the active layer and the base layer both have a non-NULL tqe_prev field in the device_list,

Re: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: Add Qualcomm Technologies, Inc HiDMA device support

2016-02-01 Thread Shanker Donthineni
Hi Eric, On 02/01/2016 08:37 AM, Eric Auger wrote: Hi Shanker, Vikram, On 01/30/2016 12:00 AM, Shanker Donthineni wrote: From: Vikram Sethi This patch introduces a Qualcomm Technologies, Inc HiDMA device and allows the instantiation of the vfio-qcom-hidma device from

[Qemu-devel] [PULL 04/17] cadence_gem: fix buffer overflow

2016-02-01 Thread Jason Wang
From: "Michael S. Tsirkin" gem_transmit copies a packet from guest into an tx_packet[2048] array on stack, with size limited by descriptor length set by guest. If guest is malicious and specifies a descriptor length that is too large, and should packet size exceed array size,

[Qemu-devel] [PULL 10/17] slirp: Factorizing and cleaning solookup()

2016-02-01 Thread Jason Wang
From: Guillaume Subiron solookup() was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Some optimization code is factorized inside the function (the function look at the last returned result before browsing the complete

[Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails

2016-02-01 Thread Jason Wang
From: Guillaume Subiron Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch

[Qemu-devel] [PULL 17/17] net/filter: Fix the output information for command 'info network'

2016-02-01 Thread Jason Wang
From: zhanghailiang The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not updated, because it got the old information through nf->info_str, it will not be updated while we change the value of

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-01 Thread Kirti Wankhede
Resending this mail again, somehow my previous mail didn't reached every to everyone's inbox. On 2/2/2016 3:16 AM, Kirti Wankhede wrote: Design for vGPU Driver: Main purpose of vGPU driver is to provide a common interface for vGPU management that can be used by differnt GPU drivers. This

[Qemu-devel] [PULL 07/17] slirp: Adding address family switch for produced frames

2016-02-01 Thread Jason Wang
From: Guillaume Subiron In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by:

[Qemu-devel] [PULL 09/17] slirp: Factorizing address translation

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the packet is destinated to the host, the loopback address is used,

[Qemu-devel] [PULL 08/17] slirp: Make Socket structure IPv6 compatible

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing

[Qemu-devel] [PULL 15/17] net: netmap: use nm_open() to open netmap ports

2016-02-01 Thread Jason Wang
From: Vincenzo Maffione This patch simplifies the netmap backend code by means of the nm_open() helper function provided by netmap_user.h, which hides the details of open(), iotcl() and mmap() carried out on the netmap device. Moreover, the semantic of nm_open() makes it

[Qemu-devel] [PULL 12/17] slirp: Make udp_attach IPv6 compatible

2016-02-01 Thread Jason Wang
From: Guillaume Subiron A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch makes solookup() compatible with varying address families, by using a new sockaddr_equal() function that compares two sockaddr_storage. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by:

Re: [Qemu-devel] [PATCH v10 0/2] mirror: Improve zero write and discard

2016-02-01 Thread Paolo Bonzini
On 22/01/2016 08:46, Fam Zheng wrote: > On Wed, 01/13 10:50, Fam Zheng wrote: >> > v10: Fix and simplify mirror_cow_align. [Max] > Jeff, are you happy to take these patches? Ping again. I have patches waiting for these to be accepted too. Paolo

Re: [Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread Fam Zheng
On Mon, 02/01 17:18, John Snow wrote: > Signed-off-by: John Snow > --- > blockjob.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index 80adb9d..a692142 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -278,14 +278,6 @@ void

[Qemu-devel] [PULL 00/17] Net patches

2016-02-01 Thread Jason Wang
The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: hw: Clean up includes (2016-01-29 15:07:25 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 06/17] slirp: Generalizing and neutralizing ARP code

2016-02-01 Thread Jason Wang
From: Guillaume Subiron Basically, this patch replaces "arp" by "resolution" every time "arp" means "mac resolution" and not specifically ARP. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 02/17] qemu-doc: Do not promote deprecated -smb and -redir options

2016-02-01 Thread Jason Wang
From: Thomas Huth Since -smb and -redir are deprecated options, we should not use them as examples in the documentation anymore. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-doc.texi | 9 + 1 file changed, 5

[Qemu-devel] [PULL 01/17] net/slirp: Tell the users when they are using deprecated options

2016-02-01 Thread Jason Wang
From: Thomas Huth We don't want to support the legacy -tftp, -bootp, -smb and -net channel options forever. So let's start telling the users that they are deprecated and what option should be used instead. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang

[Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_recieve

2016-02-01 Thread Jason Wang
From: Prasad J Pandit While receiving packets in 'gem_receive' routine, if Frame Check Sequence(FCS) is enabled, it copies the packet into a local buffer without checking its size. Add check to validate packet length against the buffer size to avoid buffer overflow.

Re: [Qemu-devel] [RFC Patch v2 06/10] virtio-net rsc: IPv4 checksum

2016-02-01 Thread Wei Xu
On 02/01/2016 02:31 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu If a field in the IPv4 header is modified, then the checksum have to be recalculated before sending it out. This in fact breaks bisection. I think you

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Wei Xu
On 02/01/2016 02:28 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu The timer will only be triggered if the packets pool is not empty, and it'll drain off all the cached packets, this is to reduce the delay to upper layer

Re: [Qemu-devel] [RFC Patch v2 08/10] virtio-net rsc: Sanity check & More bypass cases check

2016-02-01 Thread Wei Xu
On 02/01/2016 02:58 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu More general exception cases check 1. Incorrect version in IP header 2. IP options & IP fragment 3. Not a TCP packets 4. Sanity size check to prevent buffer

Re: [Qemu-devel] [Bug 1539940] [NEW] Qemu 2.5 Solaris 8 and 9 sparc hang after terminal type menu

2016-02-01 Thread Artyom Tarasenko
On Sat, Jan 30, 2016 at 5:41 PM, Zhen Ning Lim wrote: > Public bug reported: > > Qemu command: > qemu-system-sparc -nographic -monitor null -serial > mon:telnet:localhost:3000,server -bios ../../Downloads/ss20_v2.25_rom -M > SS-20 -hda ./solsparc -m 512 -cdrom

Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4

2016-02-01 Thread Wei Xu
On 02/01/2016 01:55 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Upon a packet is arriving, a corresponding chain will be selected or created, or be bypassed if it's not an IPv4 packets. The callback in the chain will

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 16:05, Yang Hongyang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function

Re: [Qemu-devel] [RFC Patch v2 09/10] virtio-net rsc: Add IPv6 support

2016-02-01 Thread Wei Xu
On 02/01/2016 03:14 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu A few more stuffs should be included to support this 1. Corresponding chain lookup 2. Coalescing callback for the protocol chain 3. Filter & Sanity Check.

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 03:56 PM, Hailiang Zhang wrote: > On 2016/2/1 15:46, Jason Wang wrote: >> >> >> On 02/01/2016 02:13 PM, Hailiang Zhang wrote: >>> On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: > We add a new helper function netdev_add_filter(),

Re: [Qemu-devel] [RFC Patch v2 04/10] virtio-net rsc: Detailed IPv4 and General TCP data coalescing

2016-02-01 Thread Wei Xu
On 02/01/2016 02:21 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Since this feature also needs to support IPv6, and there are some protocol specific differences difference for IPv4/6 in the header, so try to make the

Re: [Qemu-devel] [PATCH v7 12/13] qmp: Add query-ppc-cpu-cores command

2016-02-01 Thread Bharata B Rao
On Fri, Jan 29, 2016 at 04:45:06PM +0100, Igor Mammedov wrote: > On Thu, 28 Jan 2016 11:19:54 +0530 > Bharata B Rao wrote: > > > Show the details of PPC CPU cores via a new QMP command. > > > > TODO: update qmp-commands.hx with example > > > > Signed-off-by: Bharata

Re: [Qemu-devel] [RFC Patch v2 07/10] virtio-net rsc: Checking TCP flag and drain specific connection packets

2016-02-01 Thread Wei Xu
On 02/01/2016 02:44 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Normally it includes 2 typical way to handle a TCP control flag, bypass and finalize, bypass means should be sent out directly, and finalize means the packets should also

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

2016-02-01 Thread Christian Borntraeger
On 01/27/2016 05:53 PM, Matthew Rosato wrote: > Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Yang Hongyang
On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help

Re: [Qemu-devel] [PATCH] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-01 Thread Laszlo Ersek
Gerd, On 02/01/16 06:57, vladislav.vovche...@sk.com wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: 27 January 2016 02:21 >> To: qemu-devel@nongnu.org >> Cc: Keith Busch; Kevin Wolf; open list:nvme; Gonglei; Vladislav Vovchenko >> SFS; Feng Tian;

Re: [Qemu-devel] [RFC Patch v2 10/10] virtio-net rsc: Add Receive Segment Coalesce statistics

2016-02-01 Thread Wei Xu
On 02/01/2016 03:16 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Add statistics to log what happened during the process. Signed-off-by: Wei Xu --- hw/net/virtio-net.c| 49

Re: [Qemu-devel] [PATCH V2] net/traffic-mirror:Add traffic-mirror

2016-02-01 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 02/01/2016 10:57 AM, Jason Wang wrote: > > > > > >On 01/29/2016 09:38 AM, Li Zhijian wrote: > >> > >> > >>On 01/28/2016 01:44 PM, Jason Wang wrote: > >>> > >>> > >>>On 01/27/2016 10:40 AM, Zhang Chen wrote: > From: ZhangChen

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 05:39 PM, Hailiang Zhang wrote: > On 2016/2/1 17:18, Jason Wang wrote: >> >> >> On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string >>>

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

2016-02-01 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 01/29/2016 06:07 PM, Dr. David Alan Gilbert wrote: > >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: > On 01/27/2016 07:03 PM, Dr.

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 18:41, Daniel P. Berrange wrote: On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: Make the helper object_create() public and fix its first parameter to accept NULL value. Signed-off-by: zhanghailiang Cc: Paolo Bonzini

Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4

2016-02-01 Thread Jason Wang
On 02/01/2016 04:02 PM, Wei Xu wrote: [...] >> >>> +return NULL; >>> +} >>> + >>> +chain->proto = proto; >>> +chain->do_receive = virtio_net_rsc_receive4; >>> + >>> +QTAILQ_INIT(>buffers); >>> +QTAILQ_INSERT_TAIL(>rsc_chains, chain, next); >>> +return chain; >>>

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 04:21 PM, Hailiang Zhang wrote: >> >> Instead of this, I wonder maybe it's better to: >> >> - store the default filter property into a pointer to string > > Do you mean, pass a string parameter which stores the filter property > instead of > assemble

[Qemu-devel] [Bug 1539940] Re: Qemu 2.5 Solaris 8 and 9 sparc hang after terminal type menu

2016-02-01 Thread Zhen Ning Lim
Looks bad before i did setenv sbus-probe-list f Probing Memory Bank #7 64 Megabytes of DRAM Incorrect configuration checksum; Setting NVRAM parameters to default values. Setting diag-switch? NVRAM parameter to true Probing /iommu@f,e000/sbus@f,e0001000 at f,0 espdma esp sd st ledma le

Re: [Qemu-devel] [PATCH v7 12/13] qmp: Add query-ppc-cpu-cores command

2016-02-01 Thread Igor Mammedov
On Mon, 1 Feb 2016 14:13:58 +0530 Bharata B Rao wrote: > On Fri, Jan 29, 2016 at 04:45:06PM +0100, Igor Mammedov wrote: > > On Thu, 28 Jan 2016 11:19:54 +0530 > > Bharata B Rao wrote: > > > > > Show the details of PPC CPU cores via a

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-01 Thread Igor Mammedov
On Fri, 29 Jan 2016 09:13:15 -0600 Wei Huang wrote: > On 01/29/2016 08:50 AM, Peter Maydell wrote: > > On 29 January 2016 at 14:46, Shannon Zhao wrote: > >> On 2016/1/29 22:35, Wei Huang wrote: > >>> On 01/29/2016 04:10 AM, Shannon Zhao wrote: >

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Jason Wang
On 02/01/2016 04:39 PM, Wei Xu wrote: > On 02/01/2016 02:28 PM, Jason Wang wrote: >> >> On 02/01/2016 02:13 AM, w...@redhat.com wrote: >>> From: Wei Xu >>> >>> The timer will only be triggered if the packets pool is not empty, >>> and it'll drain off all the

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:18, Jason Wang wrote: On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string Do you mean, pass a string parameter which stores the filter property instead of assemble it in

Re: [Qemu-devel] CPU hotplug

2016-02-01 Thread Christian Borntraeger
On 02/01/2016 06:35 AM, David Gibson wrote: > Hi, > > It seems to me we're getting rather bogged down in how to proceed with > an improved CPU hotplug (and hot unplug) interface, both generically > and for ppc in particular. Yes, s390 also needs this. Can you add Matthew in any cpu hotplug

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:49, Jason Wang wrote: On 02/01/2016 05:39 PM, Hailiang Zhang wrote: On 2016/2/1 17:18, Jason Wang wrote: On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string Do you

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: > Make the helper object_create() public and fix its first > parameter to accept NULL value. > > Signed-off-by: zhanghailiang > Cc: Paolo Bonzini > --- > v2: > - New patch > ---

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote: > We add a new helper function netdev_add_filter(), this function > can help adding a filter object to a netdev. > Besides, we add a is_default member for struct NetFilterState > to indicate whether the filter is default or not. > >

Re: [Qemu-devel] [RFC Patch v2 04/10] virtio-net rsc: Detailed IPv4 and General TCP data coalescing

2016-02-01 Thread Jason Wang
On 02/01/2016 04:29 PM, Wei Xu wrote: > > On 02/01/2016 02:21 PM, Jason Wang wrote: > >> >> On 02/01/2016 02:13 AM, w...@redhat.com wrote: >>> From: Wei Xu >>> >>> Since this feature also needs to support IPv6, and there are >>> some protocol specific

Re: [Qemu-devel] [PATCH v7 01/13] machine: Don't allow CPU toplogies with partially filled cores

2016-02-01 Thread Igor Mammedov
On Fri, 29 Jan 2016 15:24:12 -0200 Eduardo Habkost wrote: > On Fri, Jan 29, 2016 at 05:52:15PM +0100, Igor Mammedov wrote: > > On Fri, 29 Jan 2016 13:36:05 -0200 > > Eduardo Habkost wrote: > > > > > On Fri, Jan 29, 2016 at 04:10:47PM +0100, Igor

Re: [Qemu-devel] [PATCH V2] net/traffic-mirror:Add traffic-mirror

2016-02-01 Thread Li Zhijian
On 02/01/2016 05:11 PM, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: On 02/01/2016 10:57 AM, Jason Wang wrote: On 01/29/2016 09:38 AM, Li Zhijian wrote: On 01/28/2016 01:44 PM, Jason Wang wrote: On 01/27/2016 10:40 AM, Zhang Chen wrote: From:

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 05:22 PM, Hailiang Zhang wrote: > On 2016/2/1 17:04, Jason Wang wrote: >> >> >> On 02/01/2016 03:56 PM, Hailiang Zhang wrote: >>> On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: > On 2016/2/1 11:14, Jason Wang wrote: >>

Re: [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E)

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > Based on qemu.git master. No pending prerequisites > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv10e > > and will soon be part of my branch with the rest of the v5 series, at: >

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Wei Xu
On 02/01/2016 05:31 PM, Jason Wang wrote: On 02/01/2016 04:39 PM, Wei Xu wrote: On 02/01/2016 02:28 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu The timer will only be triggered if the packets pool is not empty, and

[Qemu-devel] [PATCH v6 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

2016-02-01 Thread Eric Auger
qemu_fdt_setprop asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger --- v3 -> v4: fix returned value --- hw/arm/sysbus-fdt.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH v6 3/8] device_tree: introduce qemu_fdt_node_path

2016-02-01 Thread Eric Auger
This new helper routine returns a NULL terminated array of node paths matching a node name and a compat string. Signed-off-by: Eric Auger --- v5 -> v6: - in case of error, free the resources and return NULL - update the doc comment v4 -> v5: - support the case where

[Qemu-devel] [PATCH v6 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
This function returns the host device tree blob from sysfs (/proc/device-tree). It uses a recursive function inspired from dtc read_fstree. Signed-off-by: Eric Auger --- v5 -> v6: - fix some spelling mistakes - error_report + exit replaced by error_setg - const char

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

2016-02-01 Thread Marc-André Lureau
Hi On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: > The existing users pass a func that saves dev, and free the saved dev > later. Works as long as we call func() at most once. If multiple > devices match, all but the last one are leaked. Can this happen? It is

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 18:43, Daniel P. Berrange wrote: On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate

Re: [Qemu-devel] [PATCH v5 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
Hi Peter, On 01/25/2016 03:13 PM, Peter Maydell wrote: > On 18 January 2016 at 15:16, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/proc/device-tree). It uses a recursive function inspired >> from dtc read_fstree. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v5 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2016-02-01 Thread Eric Auger
Hi Peter, On 01/25/2016 03:33 PM, Peter Maydell wrote: > On 18 January 2016 at 15:16, Eric Auger wrote: >> This patch allows the instantiation of the vfio-amd-xgbe device >> from the QEMU command line (-device vfio-amd-xgbe,host=""). >> >> The guest is exposed with a device

Re: [Qemu-devel] [PATCH] build: Rename all "syscall.h" in target directories to "target_syscall.h".

2016-02-01 Thread Lluís Vilanova
Peter Maydell writes: > On 29 January 2016 at 18:53, Lluís Vilanova wrote: >> This fixes double-definitions in *-user builds when using the UST >> tracing backend (which indirectly includes the system's "syscall.h"). >> >> Signed-off-by: Lluís Vilanova

Re: [Qemu-devel] [PATCH] linux-user,ppc: synchronize syscall_nr.h

2016-02-01 Thread Laurent Vivier
Ping ? Le 19/01/2016 00:08, Laurent Vivier a écrit : > Synchronize with include/uapi/asm/unistd.h from kernel v4.4 > > This allows to use timerfd_create(). > > Signed-off-by: Laurent Vivier > --- > linux-user/ppc/syscall_nr.h | 14 +- > 1 file changed, 13

Re: [Qemu-devel] [PATCH] linux-user: fix realloc size of target_fd_trans.

2016-02-01 Thread Laurent Vivier
Ping ? Le 18/01/2016 23:50, Laurent Vivier a écrit : > target_fd_trans is an array of "TargetFdTrans *": compute size > accordingly. Use g_renew() as proposed by Paolo. > > Reported-by: Paolo Bonzini > Signed-off-by: Laurent Vivier > --- >

[Qemu-devel] [PATCH v6 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API

2016-02-01 Thread Eric Auger
This patch aligns the prototype with qemu_fdt_getprop. The caller can choose whether the function self-asserts on error (passing _fatal as Error ** argument, corresponding to the legacy behavior), or behaves differently such as simply output a message. In this later case the caller can use the

  1   2   3   >