Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

On 03/02/2016 08:55 AM, Markus Armbruster wrote: >>> >>> Please stick to lower case in file names. >> >> Which one do you prefer: mackeys.h or macKeys.h ? > > I'd call it mac-keys.h. mackeys.h would be okay. There's enough > precedence for '_' in file names to justify mac_keys.h, but I

Re: [Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On 02.03.2016 17:24, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). > > This patch also adds

Re: [Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Am 02.03.2016 um 17:39 hat Programmingkid geschrieben: > > On Mar 2, 2016, at 4:02 AM, Kevin Wolf wrote: > > > Am 02.03.2016 um 04:32 hat Programmingkid geschrieben: > >> > >> On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: > >> > >>> Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: >

Re: [Qemu-devel] [PATCH v2 02/19] qapi-visit: Expose visit_type_FOO_members()

Eric Blake writes: > Dan Berrange reported a case where he needs to work with a > QCryptoBlockOptions union type using the OptsVisitor, but only > visit one of the branches of that type (the discriminator is not > visited directly, but learned externally). When things were >

[Qemu-devel] [PATCH] add 1394 OHCI device

This patch adds 1394 (FireWire) virtual device support to QEMU. Signed-off-by: Ladi Prosek --- I am resurrecting this patch sent to the list by Itamar last year. My motivation is remote Windows kernel debugging - probably the same reason why this work was started in the first

Re: [Qemu-devel] [PATCH 21/38] ivshmem: Disentangle ivshmem_read()

On Wed, Mar 2, 2016 at 4:53 PM, Markus Armbruster wrote: >>> +if (msg == -1) { >>> +process_msg_shmem(s, fd); >> >> the previous code used to close fd if any, it's worth to keep that imho > > I'm blind. Where? Sorry, wrong place I looked at, seems you got them

[Qemu-devel] [PATCH] default-configs: add mips-softmmu-common.mak

Add mips-softmmu-common.mak and include it in existing mips*-softmmu.mak files to avoid having to repeat CONFIG defines four times. Suggested-by: Peter Maydell Signed-off-by: Leon Alrae --- default-configs/mips-softmmu-common.mak | 32

Re: [Qemu-devel] [PATCH 21/38] ivshmem: Disentangle ivshmem_read()

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/misc/ivshmem.c | 189 > +++--- > 1 file changed, 96 insertions(+), 93 deletions(-) > > diff --git

[Qemu-devel] [PATCH v2 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

The function qemu_strtoul() reads 'unsigned long' sized data, which is larger than uint32_t on 64-bit machines. Even though the snap_id field in the header is 32-bits, we must accomodate the full size in qemu_strtoul(). This patch also adds more meaningful error handling to the qemu_strtoul()

[Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

The function qemu_strtoul() reads 'unsigned long' sized data, which is larger than uint32_t on 64-bit machines. Even though the snap_id field in the header is 32-bits, we must accomodate the full size in qemu_strtoul(). This patch also adds more meaningful error handling to the qemu_strtoul()

[Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults

Qemu reports translation fault on 1st level instead of 0th level in case of AArch64 address translation if the translation table walk is disabled or the address is in the gap between the two regions. Signed-off-by: Sergey Sorokin --- target-arm/helper.c | 1 + 1 file

Re: [Qemu-devel] [PATCH 26/38] ivshmem: Drop the hackish test for UNIX domain chardev

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > The chardev must be capable of transmitting SCM_RIGHTS ancillary > messages. We check it by comparing CharDriverState member filename to > "unix:". That's almost as brittle as it is disgusting. > > When the

Re: [Qemu-devel] [PATCH 28/38] ivshmem: Tighten check of property "size"

On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > If size_t is narrower than 64 bits, passing uint64_t ivshmem_size to > mmap() truncates. Reject such sizes. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 07/19] qapi: Avoid use of 'data' member of qapi unions

Eric Blake writes: > qapi code generators currently create a 'void *data' member as QAPI > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of QAPI > the union feels a bit fishy, when we can

Re: [Qemu-devel] [V6 1/4] hw/i386: Introduce AMD IOMMU

On 25/02/16 18:43, Marcel Apfelbaum wrote: On 02/21/2016 08:10 PM, David Kiarie wrote: Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU The IOMMU does basic translation, error checking and has a mininal IOTLB implementation Hi, Signed-off-by: David Kiarie

Re: [Qemu-devel] [PATCH v2 04/19] chardev: Shorten references into ChardevBackend

Eric Blake writes: > An upcoming patch will alter how simple unions, like ChardevBackend, > are laid out, which will impact all lines of the form 'backend->u.XXX'. > To minimize the impact of that patch, use a temporary variable to > reduce the number of lines needing

Re: [Qemu-devel] [PATCH v2 05/19] util: Shorten references into SocketAddress

Eric Blake writes: > An upcoming patch will alter how simple unions, like SocketAddress, > are laid out, which will impact all lines of the form 'addr->u.XXX'. > To minimize the impact of that patch, use C99 initialization or a > temporary variable to reduce the number of

Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers

On 03/02/2016 07:02 PM, Michael S. Tsirkin wrote: > On Wed, Mar 02, 2016 at 06:53:08PM +0100, Cédric Le Goater wrote: >>> typedef struct RspBuffer RspBuffer; >> >> OK. So that's the rule for structs in qemu. It is not that clear >> when you look at the code around. I will change. np. > > Did you

Re: [Qemu-devel] [PATCH 32/38] qdev: New DEFINE_PROP_ON_OFF_AUTO

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Reviewed-by: Marc-André Lureau > hw/core/qdev-properties.c| 10 ++ > include/hw/qdev-properties.h | 3 +++ >

Re: [Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > close_peer_eventfds() cleans up three things: ioeventfd triggers if > they exist, eventfds, and the array to store them. > > Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers > when they don't

Re: [Qemu-devel] [PATCH 24/38] ivshmem: Propagate errors through ivshmem_recv_setup()

On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > This kills off the funny state described in the previous commit. > > Simplify ivshmem_io_read() accordingly, and update documentation. > > Signed-off-by: Markus Armbruster > --- >

Re: [Qemu-devel] [PATCH] target-i386: fix addr16 prefix

On 03/02/2016 07:04 AM, Paolo Bonzini wrote: > While ADDSEG will only be false in 16-bit mode for LEA, it can be > false even in other cases when 16-bit addresses are obtained via > the 67h prefix in 32-bit mode. In this case, gen_lea_v_seg forgets > to add a nonzero FS or GS base if CS/DS/ES/SS

Re: [Qemu-devel] [PATCH 31/38] ivshmem: Inline check_shm_size() into its only caller

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Improve the error messages while there. > > Signed-off-by: Markus Armbruster > --- I am not convinced this improves readibility much, I would cleanup a bit the function, but keep it. >

Re: [Qemu-devel] [PATCH v2 10/19] qapi-visit: Factor out gen_visit_members_call()

Eric Blake writes: > Upcoming patches will be adding several contexts where we want > to handle the visit of an implicit type (an anonymous base type, > or an anonymous branch of a flat union) by directly inlining > the visit of each member of the implicit type. The work is

Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers

On 03/02/2016 11:25 AM, Michael S. Tsirkin wrote: > On Wed, Mar 02, 2016 at 11:14:50AM +0100, Cédric Le Goater wrote: >> The IPMI command handlers in the BMC simulator use a macro >> IPMI_ADD_RSP_DATA() to push bytes in a response buffer. The macro >> hides the fact that it implicitly uses

Re: [Qemu-devel] [PATCH v2 09/19] qapi: Drop useless 'data' member of unions

Eric Blake writes: > Now that we no longer have any clients of the 'void *data' > member injected into unions, we can drop it. Update the > testsuite to drop the negative test union-clash-data, and > replace it with a positive test in qapi-schema-test that > proves that we no

Re: [Qemu-devel] [PATCH 25/38] ivshmem: Rely on server sending the ID right after the version

On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > The protocol specification (ivshmem-spec.txt, formerly > ivshmem_device_spec.txt) has always required the ID message to be sent > right at the beginning, and ivshmem-server has always complied. The > device, however,

Re: [Qemu-devel] [PATCH 27/38] ivshmem: Simplify how we cope with short reads from server

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Short reads from a UNIX domain sockets are exceedingly unlikely when > the other side always sends eight bytes and we always read eight > bytes. We cope with them anyway. However, the code doing that is > rather

Re: [Qemu-devel] [PATCH 33/38] ivshmem: Replace int role_val by OnOffAuto master

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > In preparation of making it a qdev property. > > Signed-off-by: Markus Armbruster > -- > hw/misc/ivshmem.c | 31 +++ > 1 file changed, 19 insertions(+), 12

Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper

Eric Blake writes: > And use it in qapi-types and qapi-event. Down the road, we may > want to lift our artificial restriction of no variants at the > top level of an event, at which point, inlining our check for > whether members is empty will no longer be sufficient, but >

Re: [Qemu-devel] [PATCH 21/38] ivshmem: Disentangle ivshmem_read()

Marc-André Lureau writes: > On Wed, Mar 2, 2016 at 4:53 PM, Markus Armbruster wrote: +if (msg == -1) { +process_msg_shmem(s, fd); >>> >>> the previous code used to close fd if any, it's worth to keep that imho >> >> I'm blind.

Re: [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers

On Wed, Mar 02, 2016 at 06:53:08PM +0100, Cédric Le Goater wrote: > > typedef struct RspBuffer RspBuffer; > > OK. So that's the rule for structs in qemu. It is not that clear > when you look at the code around. I will change. np. Did you look at CODING_STYLE? Pls do.

Re: [Qemu-devel] [PATCH 23/38] ivshmem: Receive shared memory synchronously in realize()

Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > When configured for interrupts (property "chardev" given), we receive > the shared memory from an ivshmem server. We do so asynchronously > after realize() completes, by setting up callbacks with >

Re: [Qemu-devel] [PATCH] target-i386: Fix SMSW for 64-bit mode

On 01/03/2016 19:28, Richard Henderson wrote: > In non-64-bit modes, the instruction always stores 16 bits. > But in 64-bit mode, when the destination is a register, the > instruction can write 32 or 64 bits. > > Signed-off-by: Richard Henderson > --- >

[Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out a unified storage solution. Since the typical hypervisor people are

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: > Add the keypad equals and power keys to the qcode_to_number array. These keys > are used on a Macintosh keyboard. > > Signed-off-by: John Arbuckle > > --- > ui/input-keymap.c |3 ++- > 1 files changed, 2

Re: [Qemu-devel] [PATCH v2 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On 02/03/2016 17:09, Jeff Cody wrote: > +ret = qemu_strtoul(snapshot_id, NULL, 10, _id); > +if (ret) { > +error_setg_errno(errp, -ret, "Invalid snapshot ID: %s", > + snapshot_id ? snapshot_id : ""); > +return ret; > +} > + > +if (snap_id >

Re: [Qemu-devel] [PATCH v2 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

Am 02.03.2016 um 17:12 hat Paolo Bonzini geschrieben: > > > On 02/03/2016 17:09, Jeff Cody wrote: > > +ret = qemu_strtoul(snapshot_id, NULL, 10, _id); > > +if (ret) { > > +error_setg_errno(errp, -ret, "Invalid snapshot ID: %s", > > + snapshot_id ?

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

On 2 March 2016 at 17:13, Programmingkid wrote: > > On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > >> On 2 March 2016 at 15:55, Markus Armbruster wrote: >>> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >>> precedence for '_'

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On 02.03.2016 16:16, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). > > Reported-by: Paolo

Re: [Qemu-devel] [PATCH v2 03/10] ipmi: remove IPMI_CHECK_RESERVATION() macro

On 03/02/2016 04:14 AM, Cédric Le Goater wrote: Some IPMI command handlers in the BMC simulator use a macro IPMI_CHECK_RESERVATION() to check a SDR reservation but the macro implicitly uses local variables. This patch simply removes it. Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On Wed, Mar 02, 2016 at 04:27:31PM +0100, Max Reitz wrote: > On 02.03.2016 16:16, Jeff Cody wrote: > > The function qemu_strtoul() reads 'unsigned long' sized data, > > which is larger than uint32_t on 64-bit machines. > > > > Even though the snap_id field in the header is 32-bits, we must > >

Re: [Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On 03/02/2016 09:24 AM, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). s/accomodate/accommodate/

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

On 2 March 2016 at 15:55, Markus Armbruster wrote: > I'd call it mac-keys.h. mackeys.h would be okay. There's enough > precedence for '_' in file names to justify mac_keys.h, but I personally > dislike that. Calling it adb-keys.h would make it clearer that what we're

Re: [Qemu-devel] Migration design planning

* John Snow (js...@redhat.com) wrote: > Hi Juan; > We need your assistance in reviewing two competing designs for migrating > some block data so we can move forward with the feature. > > First, some background: > > What: Block Dirty Bitmaps. They are simple primitives that keep track of > which

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > On 2 March 2016 at 15:55, Markus Armbruster wrote: >> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >> precedence for '_' in file names to justify mac_keys.h, but I personally >> dislike that. > >

Re: [Qemu-devel] [PATCH 3/3] block/qapi: Include empty drives in query-blockstats

Am 02.03.2016 um 18:10 hat Max Reitz geschrieben: > On 26.02.2016 21:22, Kevin Wolf wrote: > > Since commit 5ec18f8c, query-blockstats didn't return the statistics of > > drives without media any more because such drives have only a BB now, > > but not a BDS any more. > > > > This patch fixes the

Re: [Qemu-devel] [PATCH 21/38] ivshmem: Disentangle ivshmem_read()

Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> hw/misc/ivshmem.c | 189 >> +++--- >> 1

Re: [Qemu-devel] [PATCH 10/38] ivshmem: Compile debug prints unconditionally to prevent bit-rot

On 03/02/2016 02:51 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/01/2016 05:22 AM, Marc-André Lureau wrote: >>> On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster >>> wrote: Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH v5 1/5] nvdimm acpi: initialize the resource used by NVDIMM ACPI

On 03/02/2016 07:58 PM, Michael S. Tsirkin wrote: On Wed, Mar 02, 2016 at 07:50:37PM +0800, Xiao Guangrong wrote: 32 bits IO port starting from 0x0a18 in guest is reserved for NVDIMM ACPI emulation. The table, NVDIMM_DSM_MEM_FILE, will be patched into NVDIMM ACPI binary code OSPM uses this

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

Hi, > In any case this whole array ought at some point to be > replaced with a Q_KEY code to ADB code lookup -- at the > moment we will convert Q_KEY to pc scancode to ADB code, > which is unfortunate if the pc scancodes don't include > some keys that ADB and the host keyboard do. (In fact, >

Re: [Qemu-devel] [PATCH v2 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On Wed, Mar 02, 2016 at 05:12:57PM +0100, Paolo Bonzini wrote: > > > On 02/03/2016 17:09, Jeff Cody wrote: > > +ret = qemu_strtoul(snapshot_id, NULL, 10, _id); > > +if (ret) { > > +error_setg_errno(errp, -ret, "Invalid snapshot ID: %s", > > + snapshot_id ?

Re: [Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On Wed, Mar 02, 2016 at 05:32:11PM +0100, Max Reitz wrote: > On 02.03.2016 17:24, Jeff Cody wrote: > > The function qemu_strtoul() reads 'unsigned long' sized data, > > which is larger than uint32_t on 64-bit machines. > > > > Even though the snap_id field in the header is 32-bits, we must > >

Re: [Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On Wed, Mar 02, 2016 at 09:30:45AM -0700, Eric Blake wrote: > On 03/02/2016 09:24 AM, Jeff Cody wrote: > > The function qemu_strtoul() reads 'unsigned long' sized data, > > which is larger than uint32_t on 64-bit machines. > > > > Even though the snap_id field in the header is 32-bits, we must >

Re: [Qemu-devel] [PATCH 1/3] block/qapi: Factor out bdrv_query_blk_stats()

On 26.02.2016 21:22, Kevin Wolf wrote: > The new functions handles the data that is taken from the BlockBackend. > > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 131 > +++ > 1 file changed, 68 insertions(+), 63

Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats()

On 26.02.2016 21:22, Kevin Wolf wrote: > The new functions handles the data that is taken from the > BlockDriverState. > > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) Reviewed-by: Max

Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface

Eric Blake writes: > C types and JSON objects don't have fields, but members. We > shouldn't gratuitously invent terminology. This patch is a > strict renaming of generator code and static genarated functions, > plus the naming of the dummy filler member for empty structs, >

[Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

Add the keypad equals and power keys to the qcode_to_number array. These keys are used on a Macintosh keyboard. Signed-off-by: John Arbuckle --- ui/input-keymap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ui/input-keymap.c

Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats()

On 02.03.2016 17:52, Kevin Wolf wrote: > Am 02.03.2016 um 17:47 hat Max Reitz geschrieben: >> On 26.02.2016 21:22, Kevin Wolf wrote: >>> The new functions handles the data that is taken from the >>> BlockDriverState. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/qapi.c |

Re: [Qemu-devel] Migration design planning

On 03/02/2016 11:46 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> Hi Juan; >> We need your assistance in reviewing two competing designs for migrating >> some block data so we can move forward with the feature. >> >> First, some background: >> >> What: Block Dirty

[Qemu-devel] [PATCH 1/2] block/qapi: Set s->device in bdrv_query_stats()

This is the only instance of bdrv_query_blk_stats() accessing anything in the BlockStats structure other than s->stats, so let us move it to its caller (where it makes just as much sense) allowing us to make bdrv_query_blk_stats() take a pointer to the BlockDeviceStats instead of BlockStats.

[Qemu-devel] [PATCH 0/2] block/qapi: Pass bdrv_query_blk_stats() s->stats

Tis[1] a followup to Kevin's series “block/qapi: Include empty drives in query-blockstats” because not only should no good deed go unpunished, but the very same applies to mediocre comments, too, apparently. [1] I just misspelled “This” and then decided not to fix it. Max Reitz (2):

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

On Mar 2, 2016, at 11:15 AM, Eric Blake wrote: > On 03/02/2016 08:52 AM, Programmingkid wrote: >> Add the keypad equals and power keys to the qcode_to_number array. These keys >> are used on a Macintosh keyboard. >> >> Signed-off-by: John Arbuckle >> >> --- >>

Re: [Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On Mar 2, 2016, at 4:02 AM, Kevin Wolf wrote: > Am 02.03.2016 um 04:32 hat Programmingkid geschrieben: >> >> On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: >> >>> Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: I do think this patch is ready to be added to QEMU. I have listened to

Re: [Qemu-devel] [PATCH 3/3] block/qapi: Include empty drives in query-blockstats

On 26.02.2016 21:22, Kevin Wolf wrote: > Since commit 5ec18f8c, query-blockstats didn't return the statistics of > drives without media any more because such drives have only a BB now, > but not a BDS any more. > > This patch fixes the regression so that query-blockstats iterates over > BBs by

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

Programmingkid writes: > On Mar 2, 2016, at 4:32 AM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> This patch adds the file MacKeys.h. It is a file that contains all the >>> constants >>> for the Macintosh keyboard keycodes.

[Qemu-devel] [PATCH v2] default-configs: add mips-softmmu-common.mak

Add mips-softmmu-common.mak and include it in existing mips*-softmmu.mak files to avoid having to repeat CONFIG defines four times. Suggested-by: Peter Maydell Signed-off-by: Leon Alrae --- v2: * fixed comment line in mips-softmmu-common.mak

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

On 03/02/2016 08:52 AM, Programmingkid wrote: > Add the keypad equals and power keys to the qcode_to_number array. These keys > are used on a Macintosh keyboard. > > Signed-off-by: John Arbuckle > > --- > ui/input-keymap.c |3 ++- > 1 files changed, 2

Re: [Qemu-devel] [PATCH v3 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On 02.03.2016 17:24, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). > > This patch also adds

[Qemu-devel] [PATCH 2/2] block/qapi: Pass bdrv_query_blk_stats() s->stats

bdrv_query_blk_stats() does not need access to all of BlockStats, BlockDeviceStats is enough and is what this function is actually supposed to fill. Signed-off-by: Max Reitz --- block/qapi.c | 50 +- 1 file changed, 25

Re: [Qemu-devel] [PATCH 18/38] ivshmem: Leave INTx alone when using MSI-X

Paolo Bonzini writes: > On 02/03/2016 12:04, Markus Armbruster wrote: >> For better or worse, fallback to INTx has never been implemented in >> ivshmem. You can either ask for an INTx-only device (msi=off), or for >> an MSI-X-only device (msi=on). The latter *cannot* do

Re: [Qemu-devel] [PATCH v1 01/10] qdict: implement a qdict_crumple method for un-flattening a dict

On 19.02.2016 17:47, Daniel P. Berrange wrote: > The qdict_flatten() method will take a dict whose elements are > further nested dicts/lists and flatten them by concatenating > keys. > > The qdict_crumple() method aims todo the reverse, taking a flat > qdict, and turning it into a set of nested

Re: [Qemu-devel] [PATCH v2 1/1] block/sheepdog: fix argument passed to qemu_strtoul()

On Wed, Mar 02, 2016 at 11:09:29AM -0500, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). > >

Re: [Qemu-devel] [PATCH] input-keymap.c: Add keypad equal and power keys

On Mar 2, 2016, at 11:12 AM, Gerd Hoffmann wrote: > On Mi, 2016-03-02 at 10:52 -0500, Programmingkid wrote: >> Add the keypad equals and power keys to the qcode_to_number array. These keys >> are used on a Macintosh keyboard. >> >> Signed-off-by: John Arbuckle >> >>

Re: [Qemu-devel] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats()

Am 02.03.2016 um 17:47 hat Max Reitz geschrieben: > On 26.02.2016 21:22, Kevin Wolf wrote: > > The new functions handles the data that is taken from the > > BlockDriverState. > > > > Signed-off-by: Kevin Wolf > > --- > > block/qapi.c | 31 --- > > 1

Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote: > On 2 March 2016 at 15:55, Markus Armbruster wrote: >> I'd call it mac-keys.h. mackeys.h would be okay. There's enough >> precedence for '_' in file names to justify mac_keys.h, but I personally >> dislike that. > >

Re: [Qemu-devel] [PATCH 33/38] ivshmem: Replace int role_val by OnOffAuto master

Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> In preparation of making it a qdev property. >> >> Signed-off-by: Markus Armbruster >> -- >> hw/misc/ivshmem.c | 31

Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation

>> +static void s390_cpu_get_id(Object *obj, Visitor *v, const char *name, >> +void *opaque, Error **errp) >> +{ >> +S390CPU *cpu = S390_CPU(obj); >> +int64_t value = cpu->id; >> + >> +visit_type_int(v, name, , errp); >> +} >> + >> +static void

Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults

On 02.03.2016 21:04, Sergey Sorokin wrote: > Qemu reports translation fault on 1st level instead of 0th level in case of > AArch64 address translation if the translation table walk is disabled or > the address is in the gap between the two regions. It's probably not a very clear description in

Re: [Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> close_peer_eventfds() cleans up three things: ioeventfd triggers if >> they exist, eventfds, and the array to store them. >> >> Commit 98609cd (v1.2.0)

Re: [Qemu-devel] [PATCH 23/38] ivshmem: Receive shared memory synchronously in realize()

Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> When configured for interrupts (property "chardev" given), we receive >> the shared memory from an ivshmem server. We do so asynchronously >> after

Re: [Qemu-devel] [PATCH 24/38] ivshmem: Propagate errors through ivshmem_recv_setup()

Marc-André Lureau writes: > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> This kills off the funny state described in the previous commit. >> >> Simplify ivshmem_io_read() accordingly, and update documentation. >> >> Signed-off-by:

Re: [Qemu-devel] [V6 0/4] AMD IOMMU

On 01/03/16 16:48, Jan Kiszka wrote: On 2016-03-01 14:07, Michael S. Tsirkin wrote: On Sun, Feb 21, 2016 at 09:10:56PM +0300, David Kiarie wrote: Hello there, Repost, AMD IOMMU patches version 6. Changes since version 5 -Fixed macro formating issues -changed occurences of IO MMU to

Re: [Qemu-devel] [V6 4/4] hw/pci-host: Emulate AMD IOMMU

On Thu, Mar 03, 2016 at 12:09:28AM +0300, David Kiarie wrote: > > > On 22/02/16 14:22, Marcel Apfelbaum wrote: > >On 02/21/2016 08:11 PM, David Kiarie wrote: > >>Add AMD IOMMU emulation support to q35 chipset > >> > >>Signed-off-by: David Kiarie > >>--- > >>

[Qemu-devel] [PATCH v2 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

Memory accesses to code which has previously been translated into a TB show up in the MMIO path, so that they may invalidate the TB. It's extremely confusing to mix those in with device MMIOs, so split them into their own tracepoint. Signed-off-by: Hollis Blanchard

Re: [Qemu-devel] [V6 2/4] hw/core: Add AMD IOMMU to machine properties

On 21/02/16 23:09, Jan Kiszka wrote: On 2016-02-21 19:10, David Kiarie wrote: diff --git a/qemu-options.hx b/qemu-options.hx index 2f0465e..dad160f 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -38,7 +38,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \ "

Re: [Qemu-devel] [PATCH 27/38] ivshmem: Simplify how we cope with short reads from server

Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> Short reads from a UNIX domain sockets are exceedingly unlikely when >> the other side always sends eight bytes and we always read eight >> bytes. We

Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface

On 03/02/2016 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> C types and JSON objects don't have fields, but members. We >> shouldn't gratuitously invent terminology. This patch is a >> strict renaming of generator code and static genarated functions, >> plus

[Qemu-devel] [PATCH v2 1/2] trace: include CPU index in trace_memory_region_*()

Knowing which CPU performed an action is essential for understanding SMP guest behavior. However, cpu_physical_memory_rw() may be executed by a machine init function, before any VCPUs are running, when there is no CPU running ('current_cpu' is NULL). In this case, store -1 in the trace record as

[Qemu-devel] [PATCH 3/3] ppc: Add a few more P8 PMU SPRs

From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt --- target-ppc/cpu.h| 7 +++ target-ppc/translate_init.c | 28 2 files changed, 35 insertions(+) diff --git a/target-ppc/cpu.h

Re: [Qemu-devel] [PATCH v2 11/19] qapi: Add type.is_empty() helper

On 03/02/2016 12:04 PM, Markus Armbruster wrote: > Eric Blake writes: > >> And use it in qapi-types and qapi-event. Down the road, we may >> want to lift our artificial restriction of no variants at the >> top level of an event, at which point, inlining our check for >>

Re: [Qemu-devel] [PATCH 71/77] ppc: Add dummy ACOP SPR

On 11.11.2015 01:28, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/cpu.h| 1 + > target-ppc/translate_init.c | 4 > 2 files changed, 5 insertions(+) > > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h > index

Re: [Qemu-devel] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

On 11.11.2015 01:28, Benjamin Herrenschmidt wrote: > WORT and PID this time > > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/cpu.h| 2 ++ > target-ppc/translate_init.c | 16 > 2 files changed, 14 insertions(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation

> Check for and propogate errors during s390 cpu creation. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 30 + > hw/s390x/s390-virtio.c | 2 +- > hw/s390x/s390-virtio.h | 1 + > target-s390x/cpu-qom.h | 3

Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

On Wed, Mar 2, 2016 at 8:15 AM, Amit Shah wrote: > On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: >> RngBackend is now in charge of cleaning up the linked list on >> instance finalization. It also exposes a function to finalize >> individual RngRequest instances, called

Re: [Qemu-devel] [PATCH v7 6/6] s390x/cpu: Allow hotplug of CPUs

> Implement cpu hotplug routine and add the machine hook. > > Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 13 + > target-s390x/cpu.c | 7 +++ > 2 files

Re: [Qemu-devel] [RFC PATCH v2 3/3] VFIO: Type1 IOMMU mapping support for vGPU

On 02/24/2016 12:24 AM, Kirti Wankhede wrote: > Aim of this module is to pin and unpin guest memory. > This module provides interface to GPU driver that can be used to map guest > physical memory into its kernel space driver. > Currently this module has duplicate code from vfio_iommu_type1.c >

Re: [Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Am 02.03.2016 um 04:32 hat Programmingkid geschrieben: > > On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: > > > Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: > >> I do think this patch is ready to be added to QEMU. I have listened to > >> what you said and implemented your changes. >

Re: [Qemu-devel] [PATCH RFC v2 1/2] Add param Error** to msi_init() & modify the callers

This got lost over the Christmas break, sorry. Cc'ing Marcel for additional PCI expertise. Cao jin writes: > msi_init() is a supporting function in PCI device initialization, > in order to convert .init() to .realize(), it should be modified first. "Supporting

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

On Wed, Mar 02, 2016 at 03:29:33PM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 03:20 PM, Michael S. Tsirkin wrote: > >On Wed, Mar 02, 2016 at 03:15:19PM +0800, Xiao Guangrong wrote: > >> > >> > >>On 03/02/2016 02:36 PM, Michael S. Tsirkin wrote: > >>>On Wed, Mar 02, 2016 at 11:30:10AM

  1   2   3   >