Re: [Qemu-devel] [PATCH] Include setjmp.h in qemu/osdep.h (bug fix for w64)

2016-03-14 Thread Markus Armbruster
Stefan Weil writes: > setjmp must be declared before sysemu/os-win32.h > because it is redefined there for 64 bit Windows. > > Signed-off-by: Stefan Weil > --- > > This patch superseeds my previous patch > "Use special code for sigsetjmp only in cpu-exec.c". > > It is needed for QEMU on 64 bit W

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread Markus Armbruster
Peter Maydell writes: [...] > if we move away from C I'd rather > it to be a language that's nicer than C rather than one that's > uglier and larger and still retains all of C's flaws. Seconded strongly.

[Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions

2016-03-14 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and deterministically replay behavior of the system with connected disk drives

[Qemu-devel] [PATCH v5 1/7] replay: character devices

2016-03-14 Thread Pavel Dovgalyuk
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through t

[Qemu-devel] [PATCH v5 2/7] icount: remove obsolete warp call

2016-03-14 Thread Pavel Dovgalyuk
qemu_clock_warp call in qemu_tcg_wait_io_event function is not needed anymore, because it is called in every iteration of main_loop_wait. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpus.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpu

[Qemu-devel] [PATCH v5 4/7] block: add flush callback

2016-03-14 Thread Pavel Dovgalyuk
This patch adds callback for flush request. This callback is responsible for flushing whole block devices stack. bdrv_flush function does not proceed to underlying devices. It should be performed by this callback function, if needed. Signed-off-by: Pavel Dovgalyuk --- block/io.c|

[Qemu-devel] [PATCH v5 3/7] icount: decouple warp calls

2016-03-14 Thread Pavel Dovgalyuk
qemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode. Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include intera

[Qemu-devel] [PATCH v5 5/7] replay: bh scheduling fix

2016-03-14 Thread Pavel Dovgalyuk
This patch fixes scheduling of bottom halves when record/replay is enabled. Now BH are not added to replay queue when asynchronous events are disabled. This may happen in startup and loadvm/savevm phases of execution. Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c |2 +- 1 files c

[Qemu-devel] [PATCH v5 6/7] replay: fix error message

2016-03-14 Thread Pavel Dovgalyuk
This patch fixes error message in saving loop of the asynchronous events queue. Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/replay/replay-events.c b/replay/replay-events.c index 4aa8034..b6b8a64 100644 --- a/

[Qemu-devel] [PATCH v5 7/7] replay: introduce block devices record/replay

2016-03-14 Thread Pavel Dovgalyuk
This patch introduces block driver that implement recording and replaying of block devices' operations. All block completion operations are added to the queue. Queue is flushed at checkpoints and information about processed requests is recorded to the log. In replay phase the queue is matched with

[Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36 qapi-schema.json | 14 ++ qmp-commands.hx| 27 ++

[Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp commands xen-save-devices-state. We use this new command for COLO: 1. suspend

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 03:42 AM, Laszlo Ersek wrote: In build_crs(), the calculation & merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dword_memory(). Use aml_qword_memory() when necessary -- this fixes 64-bit BARs behind PXBs.

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Laszlo Ersek
On 03/14/16 09:07, Marcel Apfelbaum wrote: > On 03/14/2016 03:42 AM, Laszlo Ersek wrote: >> In build_crs(), the calculation & merging of the ranges already >> happens in >> 64-bit, but the entry boundaries are silently truncated to 32-bit in the >> call to aml_dword_memory(). Use aml_qword_memory()

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 10:23 AM, Laszlo Ersek wrote: On 03/14/16 09:07, Marcel Apfelbaum wrote: On 03/14/2016 03:42 AM, Laszlo Ersek wrote: In build_crs(), the calculation & merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dwor

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 02:24 AM, David Kiarie wrote: Add IOMMU as a string to machine properties which is used to control whether and the type of IOMMU to emulate Signed-off-by: David Kiarie --- hw/core/machine.c | 27 --- include/hw/boards.h | 1 + qemu-options.hx |

Re: [Qemu-devel] [V7 2/4] hw/i386: ACPI table for AMD IOMMU

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 02:24 AM, David Kiarie wrote: Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 98 ++- include/hw/acpi/acpi-defs.h | 55 +

[Qemu-devel] KVM Call for 2016-03-15

2016-03-14 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9

Re: [Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
This patch is needed by COLO Xen, More detail please ref: http://osdir.com/ml/general/2016-03/msg04860.html Thank -Xie On 03/14/2016 04:03 PM, Changlong Xie wrote: Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Int

Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode

2016-03-14 Thread tu bo
Using the latest qemu from master, and got a new qemu crash as below, (gdb) bt #0 0x03ffabb3b650 in raise () from /lib64/libc.so.6 #1 0x03ffabb3ced8 in abort () from /lib64/libc.so.6 #2 0x10384c30 in qemu_coroutine_enter (co=0x10a2ed40, opaque=0x0) at util/qemu-coroutine.c:112

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread David Kiarie
On Mon, Mar 14, 2016 at 11:40 AM, Marcel Apfelbaum wrote: > On 03/14/2016 02:24 AM, David Kiarie wrote: >> >> Add IOMMU as a string to machine properties which is >> used to control whether and the type of IOMMU to emulate >> >> Signed-off-by: David Kiarie >> --- >> hw/core/machine.c | 27 +++

Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID

2016-03-14 Thread Igor Mammedov
On Sun, 13 Mar 2016 13:40:29 +0200 Marcel Apfelbaum wrote: > According to the ACPI spec, each UID must be unique. > Use the irq number as UID for GSI links. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Marcel Apfelbaum > --- > > Hi, > > This patch was tested with Windows XP/2003/201

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-14 Thread Igor Mammedov
On Fri, 11 Mar 2016 10:24:29 +0530 Bharata B Rao wrote: > Hi, > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" that > was posted at > https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00081.html > > device_add semantics > > For -smp 16,sockets

[Qemu-devel] [PATCH v1] util: fix comment typos

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang --- util/buffer.c | 4 ++-- util/qemu-sockets.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index a6118bf..33e94d1 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -25,7 +25,7 @@ #define BUFFER_MIN_INIT_S

Re: [Qemu-devel] [PATCH] spapr_rng: fix race with main loop

2016-03-14 Thread Cédric Le Goater
On 03/11/2016 07:48 PM, Greg Kurz wrote: > Since commit "60253ed1e6ec rng: add request queue support to rng-random", > the use of a spapr_rng device may hang vCPU threads. > > The following path is taken without holding the lock to the main loop mutex: > > h_random() > rng_backend_request_entro

Re: [Qemu-devel] about correctness of IDE emulation

2016-03-14 Thread Stefan Hajnoczi
On Sun, Mar 13, 2016 at 02:37:21PM -0500, Huaicheng Li (coperd) wrote: > I meet some trouble in understanding IDE emulation: > > (1) IDE I/O Down Path (In VCPU thread): > upon KVM_EXIT_IO, corresponding disk ioport write function will write IO info > to IDEState, then ide read callback function

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 11:34 AM, David Kiarie wrote: On Mon, Mar 14, 2016 at 11:40 AM, Marcel Apfelbaum wrote: On 03/14/2016 02:24 AM, David Kiarie wrote: Add IOMMU as a string to machine properties which is used to control whether and the type of IOMMU to emulate Signed-off-by: David Kiarie ---

Re: [Qemu-devel] [RFC PATCH v2 6/9] spapr: CPU core device

2016-03-14 Thread Igor Mammedov
On Fri, 11 Mar 2016 10:24:35 +0530 Bharata B Rao wrote: > Add sPAPR specific CPU core device that is based on generic CPU core device. > Creating this core device will result in creation of all the CPU thread > devices that are part of this core. > > Introduce sPAPRMachineClass.dr_cpu_enabled to

[Qemu-devel] [PATCH 2/3] pxb: convert to realize()

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index ce5baf8..cc5074d 100644 --- a/hw/pci

[Qemu-devel] [PATCH 0/3] conversion to realize for pxb/pxb-pcie

2016-03-14 Thread Wei Jiangang
The previous patch named '[PATCH v3] PXB: convert to realize()' was raised by Cao jin , and reviewed by Marcel Apfelbaum . It conflicts with 02b0743 that had been merged, so resend a newer version. Wei Jiangang (3): hw/pci-bridge: modify pxb_dev_init_common pxb: convert to realize() pxb-pci

[Qemu-devel] [PATCH 3/3] pxb-pcie: convert to realize()

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index cc5074d..64267d8 100644 --- a/hw/pci

[Qemu-devel] [PATCH 1/3] hw/pci-bridge: modify pxb_dev_init_common

2016-03-14 Thread Wei Jiangang
1) add Error **errp parameter for it, 2) rename pxb_dev_init_common to pxb_dev_realize_common, and prepare for pxb/pxb-pcie convert to realize. 3) modify the callers, including pxb_dev_initfn and pxb_pcie_dev_initfn. Signed-off-by: Wei Jiangang Signed-off-by: Cao jin --- hw/pci-bridge/pci

Re: [Qemu-devel] [PATCH] spapr_rng: fix race with main loop

2016-03-14 Thread Thomas Huth
On 11.03.2016 19:48, Greg Kurz wrote: > Since commit "60253ed1e6ec rng: add request queue support to rng-random", > the use of a spapr_rng device may hang vCPU threads. > > The following path is taken without holding the lock to the main loop mutex: > > h_random() > rng_backend_request_entropy(

Re: [Qemu-devel] [RFC PATCH v2 6/9] spapr: CPU core device

2016-03-14 Thread Thomas Huth
On 14.03.2016 11:25, Igor Mammedov wrote: > On Fri, 11 Mar 2016 10:24:35 +0530 > Bharata B Rao wrote: > >> Add sPAPR specific CPU core device that is based on generic CPU core device. >> Creating this core device will result in creation of all the CPU thread >> devices that are part of this core.

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread Lluís Vilanova
Markus Armbruster writes: > Peter Maydell writes: > [...] >> if we move away from C I'd rather >> it to be a language that's nicer than C rather than one that's >> uglier and larger and still retains all of C's flaws. > Seconded strongly. I don't feel like that about C++, but then I maybe had a

[Qemu-devel] [PATCH 4/9] log: move qemu_log_close/qemu_log_flush from header to log.c

2016-03-14 Thread Denis V. Lunev
There is no particular reason to keep these functions in the header. Suggested by Paolo. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- include/qemu/log.h | 26 +- util/log.c | 21 + 2 files changed, 26 insertions(+),

[Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log

2016-03-14 Thread Denis V. Lunev
The following commit commit 96c33a4523ee1abe382ce4ff3e82b90ba78aa186 Author: Dimitris Aragiorgis Date: Thu Feb 18 13:38:38 2016 +0200 log: Redirect stderr to logfile if deamonized was created with unnecessary side effect - connect from libvirt starts to hang. This, in turn, was

[Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events

2016-03-14 Thread Denis V. Lunev
The problem is that virsh qemu-monitor-command --hmp VM log trace:help forces QEMU to exit even when running VM normally. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- trace/control.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/trace/cont

[Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least necessary to understand what has been happened on the system and to identify issues at higher-level subsystems (libvirt, etc). These messages will be quite useful t

[Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled

2016-03-14 Thread Denis V. Lunev
The patch is intended to avoid to perform any operation including calculation of log function arguments when the log is not enabled due to various reasons. Functions qemu_log and qemu_log_mask are replaced with variadic macros. Format checking performed by compiler will not suffer by this patch.

[Qemu-devel] [PATCH 7/9] log: report HMP command and event

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini CC: Luiz Capitulino CC: Markus Armbruster CC: Eric Blake --- include/qemu/log.h | 1 + monitor.c | 4 util/log.c | 2 ++ 3 files changed, 7 insertio

[Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target

2016-03-14 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy Do not print superfluous zero cpu state on vm start with -d cpu_reset Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini CC: Andreas Färber --- qom/cpu.c | 3 ++- 1 file changed, 2 insertions(+)

[Qemu-devel] [PATCH 9/9] log: adds a timestamp to each log entry

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin This patch is written as an addition to the previous one with logging of QPM commands. This information (the moment of the event) is very useful to match guest problems with actions performing by management software. example: 2015-10-19T08:52:57.859786Z QAPI event: { "timest

[Qemu-devel] [PATCH v2 0/9] log: assorted improvements

2016-03-14 Thread Denis V. Lunev
This patchset accumulates old patchset sent in the middle of October 2015 and recent simple changes changes. The following is done: - QMP/HMP/QAPI events are now logged - timestamp is added to the log message - arguments of qemu_log/qemu_log_mask are not calculated now if the log is disabled Th

[Qemu-devel] [PATCH 8/9] log: report QAPI event

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini CC: Luiz Capitulino CC: Markus Armbruster --- include/qemu/log.h | 1 + monitor.c | 6 ++ util/log.c | 2 ++ 3 files changed, 9 insertions(+) diff --

[Qemu-devel] [PULL 1/2] trace: include CPU index in trace_memory_region_*()

2016-03-14 Thread Stefan Hajnoczi
From: Hollis Blanchard Knowing which CPU performed an action is essential for understanding SMP guest behavior. However, cpu_physical_memory_rw() may be executed by a machine init function, before any VCPUs are running, when there is no CPU running ('current_cpu' is NULL). In this case, store -1

[Qemu-devel] [PULL 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-14 Thread Stefan Hajnoczi
From: Hollis Blanchard Memory accesses to code which has previously been translated into a TB show up in the MMIO path, so that they may invalidate the TB. It's extremely confusing to mix those in with device MMIOs, so split them into their own tracepoint. Signed-off-by: Hollis Blanchard Review

[Qemu-devel] [PULL 0/2] Tracing patches

2016-03-14 Thread Stefan Hajnoczi
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request f

Re: [Qemu-devel] [PATCH 00/11] block: Use BB function in .bdrv_create() implementations

2016-03-14 Thread Kevin Wolf
Am 08.03.2016 um 17:34 hat Kevin Wolf geschrieben: > All users of the block layers are supposed to go through a BlockBackend. > The .bdrv_create() implementations are such users, so this series > converts them. > > This series (specifically patch 1) will also help with moving the > writethrough ca

Re: [Qemu-devel] [PATCH RFC 00/17] Dirty bitmaps postcopy migration

2016-03-14 Thread Vladimir Sementsov-Ogievskiy
ping On 12.02.2016 21:00, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series are derived from my 'Dirty bitmaps migration' series. The core idea is switch to postcopy migration and drop usage of meta bitmaps. These patches provide dirty bitmap postcopy migration feature. Only named dirty

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-14 Thread Greg Kurz
On Fri, 27 Nov 2015 16:02:39 +0100 Patrik Hermansson wrote: > This patch adds the option to specify virtio queue sizes. Currently the > queue sizes is hard coded to 256, which might not be suitable for all types > of applications. This patch makes it possible to specify the queue size > between

Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()

2016-03-14 Thread Stefan Hajnoczi
On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > This patch adds NULL check for return value from qemu_find_file(), where it > is missing. It avoids unnecessary function calls with NULL parameter which in > turn return -1. Especially, incase of loa

Re: [Qemu-devel] [PULL for-2.6 00/11] s390x patches for 2.6

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 09:56, Cornelia Huck wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in the git repository at: > > g

Re: [Qemu-devel] [RFC PATCH v2 6/9] spapr: CPU core device

2016-03-14 Thread Igor Mammedov
On Mon, 14 Mar 2016 11:56:52 +0100 Thomas Huth wrote: > On 14.03.2016 11:25, Igor Mammedov wrote: > > On Fri, 11 Mar 2016 10:24:35 +0530 > > Bharata B Rao wrote: > > > >> Add sPAPR specific CPU core device that is based on generic CPU core > >> device. > >> Creating this core device will res

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread KONRAD Frederic
Hi, Le 09/03/2016 16:52, Richard Henderson a écrit : On 03/09/2016 09:38 AM, Lluís Vilanova wrote: Hi, NOTE: I won't be throwing patches anytime soon, I just want to know if there's interest in this for the future. While adding events for tracing guest instructions, I've found that t

[Qemu-devel] [PATCH v6] tests: pc: acpi: piix4: add sparse CPU hotplug case

2016-03-14 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - rebased on top of todays PCI tree to match modified tables --- tests/acpi-test-data/pc/APIC.cpuhp_sparse | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cpuhp_sparse | Bin 0 -> 5930 bytes tests/acpi-test-data/pc/SRAT.cpuhp_sparse | Bin 0 -> 264 bytes te

[Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-14 Thread Nikos Filippakis
Allocate array in nc_sendv_compat on the heap if it is large to reduce stack frame size, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- net/net.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/net/net.c b/net

Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()

2016-03-14 Thread rutuja shah
Regards Rutuja Shah On Mon, Mar 14, 2016 at 5:14 PM, Stefan Hajnoczi wrote: > On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote: >> From: Rutuja Shah >> >> This patch adds NULL check for return value from qemu_find_file(), where it >> is missing. It avoids unnecessary func

[Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Christophe Fergeau
Currently, virgl support has to go through a local unix socket, trying to connect to a VM using -spice gl through spice://localhost:5900 will only result in a black screen. This commit errors out when the user tries to start a VM with both GL support and a port/tls-port set. This would fit better i

Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()

2016-03-14 Thread Alberto Garcia
On Mon 14 Mar 2016 02:57:31 AM CET, Changlong Xie wrote: >> And now that we're at it, shouldn't we call quorum_report_bad() in >> FIFO mode as well? Or is there any reason not to do it? > > IMO, no reason not to do it. I'll send a patch to fix that. Thanks, Berto

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Corey Minyard
On 03/13/2016 09:03 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 12:59:13PM -0600, miny...@acm.org wrote: From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard This change

Re: [Qemu-devel] [PATCH v4 12/15] hbitmap: serialization

2016-03-14 Thread Vladimir Sementsov-Ogievskiy
On 11.03.2016 19:27, Max Reitz wrote: On 08.03.2016 05:45, Fam Zheng wrote: From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Th

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Marc-André Lureau
On Mon, Mar 14, 2016 at 12:41 PM, Christophe Fergeau wrote: > Currently, virgl support has to go through a local unix socket, trying > to connect to a VM using -spice gl through spice://localhost:5900 will > only result in a black screen. > This commit errors out when the user tries to start a VM

Re: [Qemu-devel] [PULL v1 00/18] Merge I/O channel fixes for Win32

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 10:03, Daniel P. Berrange wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH v6] tests: pc: acpi: piix4: add sparse CPU hotplug case

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 02:25 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- - rebased on top of todays PCI tree to match modified tables --- tests/acpi-test-data/pc/APIC.cpuhp_sparse | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cpuhp_sparse | Bin 0 -> 5930 bytes tests/acpi-tes

Re: [Qemu-devel] [PATCH v2 00/18] Multiple fixes & improvements to QIOChannel & Win32

2016-03-14 Thread Daniel P. Berrange
On Fri, Mar 11, 2016 at 11:51:29PM +, Andrew Baumann wrote: > Hi folks, > > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > Sent: Thursday, 10 March 2016 9:37 AM > > > > On 10/03/2016 18:26, Daniel P. Berrange wrote: > > > This series started out as an attempt to fix the Win32 problems

Re: [Qemu-devel] [Patch 1/1] net/net: Allocating Large sized arrays to heap

2016-03-14 Thread Eric Blake
On 03/12/2016 01:39 AM, Pooja Dhannawat wrote: > Signed-off-by: Pooja Dhannawat > --- > net/net.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/net/net.c b/net/net.c > index b0c832e..5399758 100644 > --- a/net/net.c > +++ b/net/net.c > @@ -709,16 +709,18 @@ ssi

Re: [Qemu-devel] [PATCH v5 1/7] replay: character devices

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 08:44, Pavel Dovgalyuk wrote: > This patch implements record and replay of character devices. > It records chardevs communication in replay mode. Recorded information > include data read from backend and counter of bytes written > from frontend to backend to preserve frontend intern

Re: [Qemu-devel] [PATCH 1/5] address_space: replaced function calls

2016-03-14 Thread Eric Blake
On 03/13/2016 01:10 PM, Peter Maydell wrote: > On 13 March 2016 at 18:56, Mriyam Tamuli wrote: >> replaced calls named cpu_physical_memory_* with address_space_* >> >> cpus.c >> cputlb.c >> disas.c >> exec.c >> --- >> cpus.c | 2 +- >> cputlb.c | 8 >> disas.c | 2 +- >> exec.c |

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 13:23, KONRAD Frederic wrote: >> These "target-specific hooks" probably ought not be "hooks" in the >> traditional sense of attaching them to CPUState. I'd be more >> comfortable with a refactoring that used include files -- maybe .h or >> maybe .inc.c. If we do the normal sort of

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 14:30, Corey Minyard wrote: > On 03/13/2016 09:03 PM, Michael S. Tsirkin wrote: >> On Wed, Feb 24, 2016 at 12:59:13PM -0600, miny...@acm.org wrote: >>> From: Corey Minyard >>> >>> This is the same place that the ACPI SSDT table gets added, so that >>> devices can add themselves to

Re: [Qemu-devel] [PATCH 1/1] Allocating Large sized arrays to heap

2016-03-14 Thread Paolo Bonzini
The subject isn't very clear, because it doesn't say which subsystem is being modified. You should use something like virtio: allocate temporary VirtQueueElementOld on heap The rest of the commit message is okay, but the lines are a bit long. Usually we use 70-75 characters only. On 11/03/2016

Re: [Qemu-devel] [PATCH v4 09/26] crypto: import an implementation of the XTS cipher mode

2016-03-14 Thread Daniel P. Berrange
On Fri, Mar 11, 2016 at 12:51:29PM -0700, Eric Blake wrote: > On 02/29/2016 05:00 AM, Daniel P. Berrange wrote: > > The XTS (XEX with tweaked-codebook and ciphertext stealing) > > cipher mode is commonly used in full disk encryption. There > > is unfortunately no implementation of it in either libg

Re: [Qemu-devel] [PATCH 2/9] qemu-log: fix cpu_reset log target

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > Do not print superfluous zero cpu state on vm start with -d cpu_reset It's really just the very first reset that is all zeroes. If you use "-S", you can be in prelaunch state and have a meaningful state. Over

Re: [Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > The problem is that > virsh qemu-monitor-command --hmp VM log trace:help > forces QEMU to exit even when running VM normally. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > --- > trace/control.c | 5 - > 1 file

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread Lluís Vilanova
KONRAD Frederic writes: > Hi, > Le 09/03/2016 16:52, Richard Henderson a écrit : >> On 03/09/2016 09:38 AM, Lluís Vilanova wrote: >>> Hi, >>> >>> NOTE: I won't be throwing patches anytime soon, I just want to know if >>> there's >>> interest in this for the future. >>> >>> While adding events fo

Re: [Qemu-devel] [PATCH v4 13/26] crypto: implement the LUKS block encryption format

2016-03-14 Thread Daniel P. Berrange
On Fri, Mar 11, 2016 at 03:31:59PM -0700, Eric Blake wrote: > On 02/29/2016 05:00 AM, Daniel P. Berrange wrote: > > Provide a block encryption implementation that follows the > > LUKS/dm-crypt specification. > > > > This supports all combinations of hash, cipher algorithm, > > cipher mode and iv g

Re: [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > /* In case -D is given do not redirect stderr to /dev/null */ > -if (!qemu_logfile) { > +if (!qemu_logfile || qemu_logfile == stderr) { > dup2(fd, 2); This relies on knowledge that fileno(qemu_logfile) is dup-ed t

Re: [Qemu-devel] [PATCH 4/9] log: move qemu_log_close/qemu_log_flush from header to log.c

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > There is no particular reason to keep these functions in the header. > Suggested by Paolo. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > --- > include/qemu/log.h | 26 +- > util/log.c

Re: [Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > The patch is intended to avoid to perform any operation including > calculation of log function arguments when the log is not enabled due to > various reasons. > > Functions qemu_log and qemu_log_mask are replaced with variadic macros. > > Format che

Re: [Qemu-devel] [PATCH 8/9] log: report QAPI event

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Pavel Butsykin > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > CC: Luiz Capitulino > CC: Markus Armbruster > --- > include/qemu/log.h | 1 + > monitor.c | 6 ++ >

[Qemu-devel] [Bug 1556306] Re: vhost-user: qemu stops processing packets under high load of traffic

2016-03-14 Thread Vincent JARDIN
Let's close it. Sorry, it should be opened into: https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1556306 Title: vhost-user: qemu stops processi

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Pavel Butsykin > > This log would be very welcome for long-term diagnostics of the system > in the production. This log is at least necessary to understand what > has been happened on the system and to identify issues at higher-level > subsyste

[Qemu-devel] [Bug 1556306] Re: vhost-user: qemu stops processing packets under high load of traffic

2016-03-14 Thread Vincent JARDIN
Correct, it is fixed in Qemu upstream. Just need to get it used into my ubuntu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1556306 Title: vhost-user: qemu stops processing packets under high lo

Re: [Qemu-devel] [PATCH 7/9] log: report HMP command and event

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > From: Pavel Butsykin Please explain the usecase here. Is it for debugging the hypervisor or for something else? Paolo > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > CC: Luiz Capitulino

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > > > On 14/03/2016 12:21, Denis V. Lunev wrote: > > From: Pavel Butsykin > > > > This log would be very welcome for long-term diagnostics of the system > > in the production. This log is at least necessary to understand what > > ha

Re: [Qemu-devel] [PATCH 9/9] log: adds a timestamp to each log entry

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 12:21, Denis V. Lunev wrote: > This patch is not perfect as messages from different threads could > interleave but this is not a big deal, timestamps are nearly the > same. You could use flockfile and funlockfile to avoid this. Paolo

Re: [Qemu-devel] [PULL 0/4] migration fixes

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 12:32, Amit Shah wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in the git repository at: > > https

Re: [Qemu-devel] [Patch 1/1] net/net: Allocating Large sized arrays to heap

2016-03-14 Thread Pooja Dhannawat
On Mon, Mar 14, 2016 at 7:41 PM, Eric Blake wrote: > On 03/12/2016 01:39 AM, Pooja Dhannawat wrote: > > Signed-off-by: Pooja Dhannawat > > --- > > net/net.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/net/net.c b/net/net.c > > index b0c832e..5399758 10

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-14 Thread Cédric Le Goater
Hello Thomas, On 03/11/2016 03:46 PM, Thomas Huth wrote: > I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into > the "Add a bunch of hypervisor SPRs to Book3s" to reduce the code churn > a little bit (note that the patch description for the "Add a bunch of > hypervisor SPRs to B

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Gerd Hoffmann
On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > Currently, virgl support has to go through a local unix socket, trying > to connect to a VM using -spice gl through spice://localhost:5900 will > only result in a black screen. > This commit errors out when the user tries to start a VM w

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Corey Minyard
On 03/14/2016 09:16 PM, Paolo Bonzini wrote: On 14/03/2016 14:30, Corey Minyard wrote: On 03/13/2016 09:03 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 12:59:13PM -0600, miny...@acm.org wrote: From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that d

[Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

2016-03-14 Thread Pooja Dhannawat
Removing support for DEPTH != 32 from blizzard template header and file that includes it, as macro DEPTH == 32 only used. Signed-off-by: Pooja Dhannawat --- hw/display/blizzard.c | 24 hw/display/blizzard_template.h | 30 +- 2 files c

Re: [Qemu-devel] [PULL 00/53] vhost, virtio, pci, pc, acpi

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 15:07, Michael S. Tsirkin wrote: > AFAIK the two large patchsets still outstanding (posted before soft > freeze) that I have a hand in are AMD IOMMU support and VFIO AER. > That might still make it in the next pull request. > > The following changes since commit a648c137383d84b

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Christophe Fergeau
Hi, On Mon, Mar 14, 2016 at 04:00:11PM +0100, Gerd Hoffmann wrote: > On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > > Currently, virgl support has to go through a local unix socket, trying > > to connect to a VM using -spice gl through spice://localhost:5900 will > > only result in

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least nece

Re: [Qemu-devel] [PATCH V4] hw/pxb: add chassis_nr property

2016-03-14 Thread Marcel Apfelbaum
On 03/03/2016 04:18 PM, Marcel Apfelbaum wrote: Add a chassis_nr property instead of using PXB bus number as internal bridge's chassis nr. ping Thanks, Marcel Suggested-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum --- v3->v4: - re-coded to fit current codebase v2->v3: - use

Re: [Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

2016-03-14 Thread Peter Maydell
On 14 March 2016 at 15:04, Pooja Dhannawat wrote: > Removing support for DEPTH != 32 from blizzard template header > and file that includes it, as macro DEPTH == 32 only used. > > Signed-off-by: Pooja Dhannawat > --- > hw/display/blizzard.c | 24 > hw/display/bl

Re: [Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:30 PM, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: The patch is intended to avoid to perform any operation including calculation of log function arguments when the log is not enabled due to various reasons. Functions qemu_log and qemu_log_mask are replaced

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Gerd Hoffmann
Hi, > > Didn't Gerd have a patch to sort fw_cfg files? > > > > ... yes, here it is: > > https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05238.html > > I could take that patch and modify it to add a new machine type... Sure, go ahead. Didn't submit the patch because I wasn't sure it i

  1   2   3   >