Re: [Qemu-devel] [PULL 00/53] vhost, virtio, pci, pc, acpi

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 15:07, Michael S. Tsirkin wrote: > AFAIK the two large patchsets still outstanding (posted before soft > freeze) that I have a hand in are AMD IOMMU support and VFIO AER. > That might still make it in the next pull request. > > The following changes since

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: > On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: > >On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > >> > >>On 14/03/2016 12:21, Denis V. Lunev wrote: > >>>From: Pavel Butsykin > >>> >

[Qemu-devel] [PATCH V2 1/1] virtio:Allocate temporary VirtQueueElementOld on heap

2016-03-14 Thread Jaya Tiwari
As per the list of functions in : http://wiki.qemu.org/BiteSizedTasks#Large_frames, qemu_get_virtqueue_element and qemu_put_virtqueue_element have large arrays on stack. Hence, moving them to heap This reduced their stack size from something 49248 to fit into less than 200. Signed-off-by: Jaya

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Eric Blake
On 03/14/2016 05:41 AM, Christophe Fergeau wrote: > Currently, virgl support has to go through a local unix socket, trying > to connect to a VM using -spice gl through spice://localhost:5900 will > only result in a black screen. > This commit errors out when the user tries to start a VM with both

[Qemu-devel] [PATCH 5/5] block: Reject writethrough mode except at the root

2016-03-14 Thread Kevin Wolf
Writethrough mode is going to become a BlockBackend feature rather than a BDS one, so forbid it in places where we won't be able to support it when the code finally matches the envisioned design. We only allowed setting the cache mode of non-root nodes after the 2.5 release, so we're still free

[Qemu-devel] [PATCH v2 1/1] socket: Allocating Large sized arrays to heap

2016-03-14 Thread Pooja Dhannawat
net_socket_send has a huge stack usage of 69712 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Pooja Dhannawat --- net/socket.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/socket.c b/net/socket.c

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 17:16, Denis V. Lunev wrote: >> BTW, I'm not against adding this to QEMU in general - just pointing out >> that in the context of libvirt usage reference in the commit message, >> it is not really needed. I'm totally ambivalent wrt adding this to QEMU >> for benefit of non-libvirt

[Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

2016-03-14 Thread Pooja Dhannawat
Removing support for DEPTH != 32 from blizzard template header and file that includes it, as macro DEPTH == 32 only used. Signed-off-by: Pooja Dhannawat --- hw/display/blizzard.c | 24 hw/display/blizzard_template.h | 30

[Qemu-devel] [PATCH 1/5] block: Remove copy-on-read from bdrv_move_feature_fields()

2016-03-14 Thread Kevin Wolf
Ever since we first introduced bdrv_append() in commit 8802d1fd ('qapi: Introduce blockdev-group-snapshot-sync command'), the copy-on-read flag was moved to the new top layer when taking a snapshot. The only problem is that it doesn't make a whole lot of sense. The use case for manually enabled

Re: [Qemu-devel] [PATCH 2/5] block: Remove dirty bitmaps from bdrv_move_feature_fields()

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > This patch changes dirty bitmaps from following a BlockBackend in graph > changes to sticking with the node they were created at. For the full > discussion, read the following mailing list thread: > > [Qemu-block] block: Dirty bitmaps and COR in

Re: [Qemu-devel] [PULL v3 0/8] VFIO updates 2016-03-11

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 16:00, Alex Williamson wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 03:26:04PM +, Daniel P. Berrange wrote: > On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: > > On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: > > >On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > > >> > > >>On 14/03/2016 12:21, Denis V.

Re: [Qemu-devel] [PATCH 7/9] log: report HMP command and event

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 16:08, Denis V. Lunev wrote: >> Please explain the usecase here. Is it for debugging the hypervisor or >> for something else? > > yes. There are important HMP-only commands like switch to snapshot, > which should be logged. The rest is the same as I have answered to > Daniel to

Re: [Qemu-devel] [PULL 0/4] migration fixes

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 12:32, Amit Shah wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in the git

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Gerd Hoffmann
On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > Currently, virgl support has to go through a local unix socket, trying > to connect to a VM using -spice gl through spice://localhost:5900 will > only result in a black screen. > This commit errors out when the user tries to start a VM

Re: [Qemu-devel] [PATCH v2 0/4] Separate QUORUM_REPORT_BAD events according to their node name

2016-03-14 Thread Max Reitz
On 10.03.2016 12:55, Alberto Garcia wrote: > QUORUM_REPORT_BAD events are limited to a maximum rate of 1 per > second. While this is not a problem in itself, this means that an > error in one a Quorum child will mask errors in the other children if > they happen within the same 1 second interval.

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 17:10, Denis V. Lunev wrote: > On 03/14/2016 06:26 PM, Daniel P. Berrange wrote: >> On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: >>> On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: > On

Re: [Qemu-devel] [PATCH 4/5] block: Make backing files always writeback

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > First of all, we're generally not writing to backing files, but when we > do, it's in the context of block jobs which know very well when to flush > the image. > > Signed-off-by: Kevin Wolf > --- > block.c| 5

Re: [Qemu-devel] [Patch 1/1] net/net: Allocating Large sized arrays to heap

2016-03-14 Thread Pooja Dhannawat
On Mon, Mar 14, 2016 at 7:41 PM, Eric Blake wrote: > On 03/12/2016 01:39 AM, Pooja Dhannawat wrote: > > Signed-off-by: Pooja Dhannawat > > --- > > net/net.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Corey Minyard
On 03/14/2016 09:16 PM, Paolo Bonzini wrote: On 14/03/2016 14:30, Corey Minyard wrote: On 03/13/2016 09:03 PM, Michael S. Tsirkin wrote: On Wed, Feb 24, 2016 at 12:59:13PM -0600, miny...@acm.org wrote: From: Corey Minyard This is the same place that the ACPI SSDT table

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-14 Thread Christophe Fergeau
Hi, On Mon, Mar 14, 2016 at 04:00:11PM +0100, Gerd Hoffmann wrote: > On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > > Currently, virgl support has to go through a local unix socket, trying > > to connect to a VM using -spice gl through spice://localhost:5900 will > > only result in

Re: [Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

2016-03-14 Thread Peter Maydell
On 14 March 2016 at 15:04, Pooja Dhannawat wrote: > Removing support for DEPTH != 32 from blizzard template header > and file that includes it, as macro DEPTH == 32 only used. > > Signed-off-by: Pooja Dhannawat > --- > hw/display/blizzard.c

Re: [Qemu-devel] [PATCH 5/9] log: improve performance of qemu_log and qemu_log_mask if disabled

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:30 PM, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: The patch is intended to avoid to perform any operation including calculation of log function arguments when the log is not enabled due to various reasons. Functions qemu_log and qemu_log_mask are replaced

Re: [Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-14 Thread Eric Blake
On 03/14/2016 06:46 AM, Nikos Filippakis wrote: > Allocate array in nc_sendv_compat on the heap if it is large to reduce stack > frame size, as stated in the BiteSizedTasks wiki page. Please wrap your commit messages at 70 or so columns (since 'git log' will display your text with indentation,

[Qemu-devel] [PATCH 0/5] block: API changes for 2.6

2016-03-14 Thread Kevin Wolf
This series contains those part of my current work that I want to be in the 2.6 release because they change the semantics of some QMP interfaces. This is especially true for the WCE changes, which concern things that weren't even accessible in 2.5 yet, so we're still completely free to change

[Qemu-devel] [PATCH 4/5] block: Make backing files always writeback

2016-03-14 Thread Kevin Wolf
First of all, we're generally not writing to backing files, but when we do, it's in the context of block jobs which know very well when to flush the image. Signed-off-by: Kevin Wolf --- block.c| 5 +++-- tests/qemu-iotests/142.out | 10 +- 2 files

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-14 Thread Cédric Le Goater
On 03/14/2016 04:43 PM, Thomas Huth wrote: > On 14.03.2016 15:53, Cédric Le Goater wrote: >> Hello Thomas, >> >> On 03/11/2016 03:46 PM, Thomas Huth wrote: >>> I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into >>> the "Add a bunch of hypervisor SPRs to Book3s" to reduce the

Re: [Qemu-devel] [PATCH 1/5] block: Remove copy-on-read from bdrv_move_feature_fields()

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > Ever since we first introduced bdrv_append() in commit 8802d1fd ('qapi: > Introduce blockdev-group-snapshot-sync command'), the copy-on-read flag > was moved to the new top layer when taking a snapshot. The only problem > is that it doesn't make a whole

Re: [Qemu-devel] [PATCH 3/5] block: Remove cache.writeback from blockdev-add

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > The WCE bit is a frontend property and should not be part of the backend > configuration. This is especially important because the same BDS can be > used by different users with different WCE requirements. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 07:11 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:26:04PM +, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-03-14 Thread Denis V. Lunev
On 03/10/2016 08:40 PM, Paolo Bonzini wrote: On 10/03/2016 18:37, Stefan Hajnoczi wrote: I suggest giving the new NBD command a "type" argument: 0 - SCSI mapped/anchored values according to SCSI Get LBA Status 1 - Dirty/clean, useful for incremental backup and other blocking tracking cases

[Qemu-devel] [Bug 1557033] [NEW] Persistent malfunction after guest shutdown/reboot

2016-03-14 Thread Piknik
Public bug reported: Running the VM the first time after the host has booted up is completely fine, no issues at all. However, after shutting down or restarting the VM, certain problems occur. In the Windows 10 VM, it may throw a SYSTEM_THREAD_EXCEPTION error on bootup, and other times it simply

Re: [Qemu-devel] [PATCH] Sort the fw_cfg file list

2016-03-14 Thread Corey Minyard
On 03/14/2016 11:33 PM, Paolo Bonzini wrote: On 14/03/2016 17:23, miny...@acm.org wrote: From: Gerd Hoffmann Entries are inserted at the correct place instead of being appended to the end in case sorting is enabled. Signed-off-by: Gerd Hoffmann Added

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-14 Thread Thomas Huth
On 14.03.2016 15:53, Cédric Le Goater wrote: > Hello Thomas, > > On 03/11/2016 03:46 PM, Thomas Huth wrote: >> I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into >> the "Add a bunch of hypervisor SPRs to Book3s" to reduce the code churn >> a little bit (note that the patch

[Qemu-devel] [PATCH 4/4] timer/m48t59.c: Change qemu_system_reset_request to watchdog_perform_action where appropriate

2016-03-14 Thread Nikos Filippakis
Instead of using qemu_system_reset_request() to reset when a watchdog triggers, let watchdog_perform_action() decide what to do, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- hw/timer/m48t59.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Qemu-devel] TCG question reg. tcg_cpu_exec()

2016-03-14 Thread Pranith Kumar
Hello Paolo, I have a question reg. tcg_cpu_exec(cpu) which is called from tcg_exec_all(). tcg_cpu_exec() is called for each cpu in a loop. I observed that this call does not always execute TBs on that particular CPU. It return because the exit_request is set. I am trying to understand what

[Qemu-devel] [PATCH 3/4] etraxfs_timer: Change qemu_system_reset_request to watchdog_perform_action where appropriate

2016-03-14 Thread Nikos Filippakis
Instead of using qemu_system_reset_request() to reset when a watchdog triggers, let watchdog_perform_action() decide what to do, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- hw/timer/etraxfs_timer.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 06:26 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 06:05:07PM +0300, Denis V. Lunev wrote: On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin

Re: [Qemu-devel] [PATCH 3/5] block: Remove cache.writeback from blockdev-add

2016-03-14 Thread Kevin Wolf
Am 14.03.2016 um 17:10 hat Eric Blake geschrieben: > On 03/14/2016 09:44 AM, Kevin Wolf wrote: > > The WCE bit is a frontend property and should not be part of the backend > > configuration. This is especially important because the same BDS can be > > used by different users with different WCE

[Qemu-devel] [PATCH] Sort the fw_cfg file list

2016-03-14 Thread minyard
From: Gerd Hoffmann Entries are inserted at the correct place instead of being appended to the end in case sorting is enabled. Signed-off-by: Gerd Hoffmann Added a new machine type for compatibility. Signed-off-by: Corey Minyard ---

Re: [Qemu-devel] [PATCH 5/5] block: Reject writethrough mode except at the root

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > Writethrough mode is going to become a BlockBackend feature rather than > a BDS one, so forbid it in places where we won't be able to support it > when the code finally matches the envisioned design. > > We only allowed setting the cache mode of

Re: [Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-03-14 Thread Gerd Hoffmann
Hi, > > Didn't Gerd have a patch to sort fw_cfg files? > > > > ... yes, here it is: > > https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg05238.html > > I could take that patch and modify it to add a new machine type... Sure, go ahead. Didn't submit the patch because I wasn't sure it

[Qemu-devel] [PATCH 2/4] omap1: Change qemu_system_reset_request to watchdog_perform_action where appropriate

2016-03-14 Thread Nikos Filippakis
Instead of using qemu_system_reset_request() to reset when a watchdog triggers, let watchdog_perform_action() decide what to do, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- hw/arm/omap1.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH 7/9] log: report HMP command and event

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:36 PM, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin Please explain the usecase here. Is it for debugging the hypervisor or for something else? Paolo yes. There are important HMP-only commands like switch to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-14 Thread Cédric Le Goater
Hello Thomas, On 03/11/2016 03:46 PM, Thomas Huth wrote: > I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into > the "Add a bunch of hypervisor SPRs to Book3s" to reduce the code churn > a little bit (note that the patch description for the "Add a bunch of > hypervisor SPRs to

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
On 03/14/2016 05:38 PM, Daniel P. Berrange wrote: On Mon, Mar 14, 2016 at 03:33:53PM +0100, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production.

Re: [Qemu-devel] [PATCH V4] hw/pxb: add chassis_nr property

2016-03-14 Thread Marcel Apfelbaum
On 03/03/2016 04:18 PM, Marcel Apfelbaum wrote: Add a chassis_nr property instead of using PXB bus number as internal bridge's chassis nr. ping Thanks, Marcel Suggested-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum --- v3->v4: - re-coded to

Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()

2016-03-14 Thread Eric Blake
On 03/12/2016 01:36 PM, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > This patch adds NULL check for return value from qemu_find_file(), where it > is missing. It avoids unnecessary function calls with NULL parameter which in > turn return -1. Especially, incase

[Qemu-devel] [PATCH 2/5] block: Remove dirty bitmaps from bdrv_move_feature_fields()

2016-03-14 Thread Kevin Wolf
This patch changes dirty bitmaps from following a BlockBackend in graph changes to sticking with the node they were created at. For the full discussion, read the following mailing list thread: [Qemu-block] block: Dirty bitmaps and COR in bdrv_move_feature_fields()

[Qemu-devel] [PATCH 3/5] block: Remove cache.writeback from blockdev-add

2016-03-14 Thread Kevin Wolf
The WCE bit is a frontend property and should not be part of the backend configuration. This is especially important because the same BDS can be used by different users with different WCE requirements. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 4 +--- 1 file

[Qemu-devel] [PATCH 1/4] musicpal: Change qemu_system_reset_request to watchdog_perform_action where appropriate

2016-03-14 Thread Nikos Filippakis
Instead of using qemu_system_reset_request() to reset when a watchdog triggers, let watchdog_perform_action() decide what to do, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- hw/arm/musicpal.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PULL 0/2] X86 fixes

2016-03-14 Thread Peter Maydell
On 11 March 2016 at 18:47, Eduardo Habkost wrote: > The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into > staging (2016-03-10 02:51:14 +) > > are available in the

Re: [Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 16:32, Eric Blake wrote: >> +const size_t STACKBUF_SIZE = 2048; >> + >> +uint8_t *buffer, *dynbuf = NULL; >> +uint8_t stackbuf[STACKBUF_SIZE]; Instead of using the "STACKBUF_SIZE" constant, you can use just "stackbuf[2048]", and then use sizeof(stackbuf) below. This

Re: [Qemu-devel] [PATCH] Sort the fw_cfg file list

2016-03-14 Thread Paolo Bonzini
On 14/03/2016 17:23, miny...@acm.org wrote: > From: Gerd Hoffmann > > Entries are inserted at the correct place instead of being > appended to the end in case sorting is enabled. > > Signed-off-by: Gerd Hoffmann > > Added a new machine type for

Re: [Qemu-devel] [PATCH v2 1/1] socket: Allocating Large sized arrays to heap

2016-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2016 at 10:07:53PM +0530, Pooja Dhannawat wrote: > net_socket_send has a huge stack usage of 69712 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Pooja Dhannawat > --- > net/socket.c | 8 +--- > 1 file

Re: [Qemu-devel] [PATCH] Include setjmp.h in qemu/osdep.h (bug fix for w64)

2016-03-14 Thread Markus Armbruster
Stefan Weil writes: > setjmp must be declared before sysemu/os-win32.h > because it is redefined there for 64 bit Windows. > > Signed-off-by: Stefan Weil > --- > > This patch superseeds my previous patch > "Use special code for sigsetjmp only in cpu-exec.c".

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-14 Thread Changlong Xie
On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is

Re: [Qemu-devel] info qtree command cause qemu ABORT!

2016-03-14 Thread hitmoon
在 2016年03月11日 12:18, hitmoon 写道: 在 2016年03月11日 11:14, Peter Maydell 写道: On 11 March 2016 at 10:08, hitmoon wrote: Peter: first launch following command: arm-softmmu/qemu-system-arm -M versatilepb -kernel ~/Qemu-ARM/vmlinuz-3.2.0-4-versatile -initrd

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

2016-03-14 Thread Markus Armbruster
Peter Maydell writes: [...] > if we move away from C I'd rather > it to be a language that's nicer than C rather than one that's > uglier and larger and still retains all of C's flaws. Seconded strongly.

[Qemu-devel] [PATCH v5 1/7] replay: character devices

2016-03-14 Thread Pavel Dovgalyuk
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through

[Qemu-devel] [PATCH v5 2/7] icount: remove obsolete warp call

2016-03-14 Thread Pavel Dovgalyuk
qemu_clock_warp call in qemu_tcg_wait_io_event function is not needed anymore, because it is called in every iteration of main_loop_wait. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpus.c |3 --- 1 files changed, 0

[Qemu-devel] [PATCH v5 4/7] block: add flush callback

2016-03-14 Thread Pavel Dovgalyuk
This patch adds callback for flush request. This callback is responsible for flushing whole block devices stack. bdrv_flush function does not proceed to underlying devices. It should be performed by this callback function, if needed. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions

2016-03-14 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and deterministically replay behavior of the system with connected disk drives

[Qemu-devel] [PATCH v5 3/7] icount: decouple warp calls

2016-03-14 Thread Pavel Dovgalyuk
qemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode. Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 10:23 AM, Laszlo Ersek wrote: On 03/14/16 09:07, Marcel Apfelbaum wrote: On 03/14/2016 03:42 AM, Laszlo Ersek wrote: In build_crs(), the calculation & merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to

Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode

2016-03-14 Thread tu bo
Using the latest qemu from master, and got a new qemu crash as below, (gdb) bt #0 0x03ffabb3b650 in raise () from /lib64/libc.so.6 #1 0x03ffabb3ced8 in abort () from /lib64/libc.so.6 #2 0x10384c30 in qemu_coroutine_enter (co=0x10a2ed40, opaque=0x0) at

[Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.c | 36 qapi-schema.json | 14 ++ qmp-commands.hx| 27

[Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp commands xen-save-devices-state. We use this new

Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID

2016-03-14 Thread Igor Mammedov
On Sun, 13 Mar 2016 13:40:29 +0200 Marcel Apfelbaum wrote: > According to the ACPI spec, each UID must be unique. > Use the irq number as UID for GSI links. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Marcel Apfelbaum > --- > >

[Qemu-devel] [PATCH v5 6/7] replay: fix error message

2016-03-14 Thread Pavel Dovgalyuk
This patch fixes error message in saving loop of the asynchronous events queue. Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/replay/replay-events.c b/replay/replay-events.c index

[Qemu-devel] [PATCH v5 7/7] replay: introduce block devices record/replay

2016-03-14 Thread Pavel Dovgalyuk
This patch introduces block driver that implement recording and replaying of block devices' operations. All block completion operations are added to the queue. Queue is flushed at checkpoints and information about processed requests is recorded to the log. In replay phase the queue is matched with

[Qemu-devel] [PATCH v5 5/7] replay: bh scheduling fix

2016-03-14 Thread Pavel Dovgalyuk
This patch fixes scheduling of bottom halves when record/replay is enabled. Now BH are not added to replay queue when asynchronous events are disabled. This may happen in startup and loadvm/savevm phases of execution. Signed-off-by: Pavel Dovgalyuk ---

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 03:42 AM, Laszlo Ersek wrote: In build_crs(), the calculation & merging of the ranges already happens in 64-bit, but the entry boundaries are silently truncated to 32-bit in the call to aml_dword_memory(). Use aml_qword_memory() when necessary -- this fixes 64-bit BARs behind PXBs.

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread David Kiarie
On Mon, Mar 14, 2016 at 11:40 AM, Marcel Apfelbaum wrote: > On 03/14/2016 02:24 AM, David Kiarie wrote: >> >> Add IOMMU as a string to machine properties which is >> used to control whether and the type of IOMMU to emulate >> >> Signed-off-by: David Kiarie

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-14 Thread Igor Mammedov
On Fri, 11 Mar 2016 10:24:29 +0530 Bharata B Rao wrote: > Hi, > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" that > was posted at > https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00081.html > > device_add semantics >

Re: [Qemu-devel] [V7 2/4] hw/i386: ACPI table for AMD IOMMU

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 02:24 AM, David Kiarie wrote: Add IVRS table for AMD IOMMU. Generate IVRS or DMAR depending on emulated IOMMU Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 98 ++- include/hw/acpi/acpi-defs.h |

Re: [Qemu-devel] [PATCH v2 0/1] Introduce "xen-load-devices-state"

2016-03-14 Thread Changlong Xie
This patch is needed by COLO Xen, More detail please ref: http://osdir.com/ml/general/2016-03/msg04860.html Thank -Xie On 03/14/2016 04:03 PM, Changlong Xie wrote: Changelog v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1):

Re: [Qemu-devel] [PATCH] hw/i386/acpi-build: place qword descriptors in bridge _CRS's when needed

2016-03-14 Thread Laszlo Ersek
On 03/14/16 09:07, Marcel Apfelbaum wrote: > On 03/14/2016 03:42 AM, Laszlo Ersek wrote: >> In build_crs(), the calculation & merging of the ranges already >> happens in >> 64-bit, but the entry boundaries are silently truncated to 32-bit in the >> call to aml_dword_memory(). Use

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 02:24 AM, David Kiarie wrote: Add IOMMU as a string to machine properties which is used to control whether and the type of IOMMU to emulate Signed-off-by: David Kiarie --- hw/core/machine.c | 27 --- include/hw/boards.h | 1 +

[Qemu-devel] KVM Call for 2016-03-15

2016-03-14 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By popular demand, a google calendar public entry with it

Re: [Qemu-devel] [PATCH] spapr_rng: fix race with main loop

2016-03-14 Thread Cédric Le Goater
On 03/11/2016 07:48 PM, Greg Kurz wrote: > Since commit "60253ed1e6ec rng: add request queue support to rng-random", > the use of a spapr_rng device may hang vCPU threads. > > The following path is taken without holding the lock to the main loop mutex: > > h_random() >

[Qemu-devel] [PATCH 3/3] pxb-pcie: convert to realize()

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c

Re: [Qemu-devel] [PATCH] spapr_rng: fix race with main loop

2016-03-14 Thread Thomas Huth
On 11.03.2016 19:48, Greg Kurz wrote: > Since commit "60253ed1e6ec rng: add request queue support to rng-random", > the use of a spapr_rng device may hang vCPU threads. > > The following path is taken without holding the lock to the main loop mutex: > > h_random() >

[Qemu-devel] [PATCH 1/9] trace: do not always call exit() in trace_enable_events

2016-03-14 Thread Denis V. Lunev
The problem is that virsh qemu-monitor-command --hmp VM log trace:help forces QEMU to exit even when running VM normally. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- trace/control.c | 5 - 1 file

[Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least necessary to understand what has been happened on the system and to identify issues at higher-level subsystems (libvirt, etc). These

[Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log

2016-03-14 Thread Denis V. Lunev
The following commit commit 96c33a4523ee1abe382ce4ff3e82b90ba78aa186 Author: Dimitris Aragiorgis Date: Thu Feb 18 13:38:38 2016 +0200 log: Redirect stderr to logfile if deamonized was created with unnecessary side effect - connect from libvirt starts to

[Qemu-devel] [PATCH 4/9] log: move qemu_log_close/qemu_log_flush from header to log.c

2016-03-14 Thread Denis V. Lunev
There is no particular reason to keep these functions in the header. Suggested by Paolo. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- include/qemu/log.h | 26 +- util/log.c |

[Qemu-devel] [PATCH v2 0/9] log: assorted improvements

2016-03-14 Thread Denis V. Lunev
This patchset accumulates old patchset sent in the middle of October 2015 and recent simple changes changes. The following is done: - QMP/HMP/QAPI events are now logged - timestamp is added to the log message - arguments of qemu_log/qemu_log_mask are not calculated now if the log is disabled

Re: [Qemu-devel] [PATCH 00/11] block: Use BB function in .bdrv_create() implementations

2016-03-14 Thread Kevin Wolf
Am 08.03.2016 um 17:34 hat Kevin Wolf geschrieben: > All users of the block layers are supposed to go through a BlockBackend. > The .bdrv_create() implementations are such users, so this series > converts them. > > This series (specifically patch 1) will also help with moving the > writethrough

Re: [Qemu-devel] [PATCH RFC 00/17] Dirty bitmaps postcopy migration

2016-03-14 Thread Vladimir Sementsov-Ogievskiy
ping On 12.02.2016 21:00, Vladimir Sementsov-Ogievskiy wrote: Hi all! These series are derived from my 'Dirty bitmaps migration' series. The core idea is switch to postcopy migration and drop usage of meta bitmaps. These patches provide dirty bitmap postcopy migration feature. Only named

[Qemu-devel] [PATCH v1] util: fix comment typos

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang --- util/buffer.c | 4 ++-- util/qemu-sockets.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index a6118bf..33e94d1 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -25,7 +25,7

[Qemu-devel] [PATCH 2/3] pxb: convert to realize()

2016-03-14 Thread Wei Jiangang
Signed-off-by: Wei Jiangang Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c

[Qemu-devel] [PATCH 0/3] conversion to realize for pxb/pxb-pcie

2016-03-14 Thread Wei Jiangang
The previous patch named '[PATCH v3] PXB: convert to realize()' was raised by Cao jin , and reviewed by Marcel Apfelbaum . It conflicts with 02b0743 that had been merged, so resend a newer version. Wei Jiangang (3): hw/pci-bridge: modify

[Qemu-devel] [PATCH 1/3] hw/pci-bridge: modify pxb_dev_init_common

2016-03-14 Thread Wei Jiangang
1) add Error **errp parameter for it, 2) rename pxb_dev_init_common to pxb_dev_realize_common, and prepare for pxb/pxb-pcie convert to realize. 3) modify the callers, including pxb_dev_initfn and pxb_pcie_dev_initfn. Signed-off-by: Wei Jiangang Signed-off-by: Cao

[Qemu-devel] [PULL 0/2] Tracing patches

2016-03-14 Thread Stefan Hajnoczi
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request

[Qemu-devel] [PULL 1/2] trace: include CPU index in trace_memory_region_*()

2016-03-14 Thread Stefan Hajnoczi
From: Hollis Blanchard Knowing which CPU performed an action is essential for understanding SMP guest behavior. However, cpu_physical_memory_rw() may be executed by a machine init function, before any VCPUs are running, when there is no CPU running ('current_cpu' is

[Qemu-devel] [PULL 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-14 Thread Stefan Hajnoczi
From: Hollis Blanchard Memory accesses to code which has previously been translated into a TB show up in the MMIO path, so that they may invalidate the TB. It's extremely confusing to mix those in with device MMIOs, so split them into their own tracepoint.

[Qemu-devel] [PATCH 8/9] log: report QAPI event

2016-03-14 Thread Denis V. Lunev
From: Pavel Butsykin Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini CC: Luiz Capitulino CC: Markus

Re: [Qemu-devel] [PATCH] Added NULL check for qemu_find_file()

2016-03-14 Thread Stefan Hajnoczi
On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > This patch adds NULL check for return value from qemu_find_file(), where it > is missing. It avoids unnecessary function calls with NULL parameter which in > turn return -1.

Re: [Qemu-devel] [V7 3/4] hw/core: Add AMD IOMMU to machine properties

2016-03-14 Thread Marcel Apfelbaum
On 03/14/2016 11:34 AM, David Kiarie wrote: On Mon, Mar 14, 2016 at 11:40 AM, Marcel Apfelbaum wrote: On 03/14/2016 02:24 AM, David Kiarie wrote: Add IOMMU as a string to machine properties which is used to control whether and the type of IOMMU to emulate Signed-off-by:

  1   2   3   >