Re: [Qemu-devel] [PATCH v5 1/7] replay: character devices

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 16:45, Kevin Wolf wrote: > Am 14.03.2016 um 08:44 hat Pavel Dovgalyuk geschrieben: >> This patch implements record and replay of character devices. >> It records chardevs communication in replay mode. Recorded information >> include data read from backend and counter of bytes

Re: [Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work

2016-03-23 Thread Max Reitz
On 17.03.2016 14:44, Kevin Wolf wrote: > Am 16.03.2016 um 19:54 hat Max Reitz geschrieben: >> This series appears to reinvent itself with every revision. This time, >> its main implication is that BBs are no longer automatically treated as >> monitor-owned, and that a BB's name is tightly tied to

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-23 Thread Wouter Verhelst
Hi, On Wed, Mar 23, 2016 at 05:16:01PM +0300, Denis V. Lunev wrote: > From: Pavel Borzenkov > > There exist some cases when a client knows that the data it is going to > write is all zeroes. Such cases include mirroring or backing up a device > implemented by a sparse

[Qemu-devel] [PATCH v2 3/5] .travis.yml: make -j3

2016-03-23 Thread Alex Bennée
The move from Travis VMs to Containers came with a upgrade from 1.5 cores to 2. The received wisdom is -j N+1 means a core can be doing work while other threads wait for IO to complete. This is hard to test on the Travis infrastructure but an initial before/after eyeballing seems to confirm it is

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Hollis Blanchard
Paolo, is it true that only TB-invalidating writes go through the io_mem_notdirty path? I'm looking at the live migration code now, and it seems like every memory write will go through that path when global dirty memory logging is enabled. -- Hollis Blanchard Mentor

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-23 Thread Wouter Verhelst
On Wed, Mar 23, 2016 at 09:14:10AM -0600, Eric Blake wrote: > On 03/23/2016 08:16 AM, Denis V. Lunev wrote: [...] > [1] Oh, you ARE adding this to the "Experimental extensions" section of > the document, so your wording IS correct. I guess the idea is that we > write up the documentation in the

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Hollis Blanchard
On Wed, 2016-03-23 at 17:53 +0100, Paolo Bonzini wrote: > > On 23/03/2016 17:47, Hollis Blanchard wrote: > > > > Paolo, is it true that only TB-invalidating writes go through the > > io_mem_notdirty path? I'm looking at the live migration code now, > > and it > > seems like every memory write

[Qemu-devel] [PULL 1/2] target-mips: indicate presence of IEEE 754-2008 FPU in R6/R5+MSA CPUs

2016-03-23 Thread Leon Alrae
MIPS Release 6 and MIPS SIMD Architecture make it mandatory to have IEEE 754-2008 FPU which is indicated by CP1 FIR.HAS2008, FCSR.ABS2008 and FCSR.NAN2008 bits set to 1. In QEMU we still keep these bits cleared as there is no 2008-NaN support. However, this now causes problems preventing from

[Qemu-devel] [PULL 2/2] default-configs: add mips-softmmu-common.mak

2016-03-23 Thread Leon Alrae
Add mips-softmmu-common.mak and include it in existing mips*-softmmu.mak files to avoid having to repeat CONFIG defines four times. Suggested-by: Peter Maydell Signed-off-by: Leon Alrae --- default-configs/mips-softmmu-common.mak | 32

[Qemu-devel] [PULL 0/2] target-mips queue

2016-03-23 Thread Leon Alrae
since commit ffa6564c9b13cea4b704e184d29d721f2cb061bb: Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20160322' into staging (2016-03-22 20:27:55 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20160323 for you to fetch changes up to b7c4ab809a4bfde4ab322b49fbe2e47536da7487

Re: [Qemu-devel] [PATCH] Fix some typos found by codespell

2016-03-23 Thread Stefan Weil
Am 23.03.2016 um 17:36 schrieb Peter Maydell: > On 23 March 2016 at 14:59, Stefan Weil wrote: >> - * This program is free sofware: you can redistribute it and/or modify >> + * This program is free software: you can redistribute it and/or modify >> * it under the terms of the

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] Various block-stream fixes

2016-03-23 Thread Jeff Cody
On Mon, Mar 21, 2016 at 03:47:24PM +0200, Alberto Garcia wrote: > This series is a follow-up to the patch I sent last week[1]. It > contains a few fixes from my intermediate block streaming branch, but > are independent from that feature, so they can be applied now without > problems. > > Berto >

[Qemu-devel] [PATCH v2 5/5] .travis.yml: reduce target list on core configure tweaks

2016-03-23 Thread Alex Bennée
A number of configure options only really affect the core code and any arch specific stuff should be flushed out by other builds: - trace-backends, log build is all targets, others can be less - --disable-build, ensuring disabling stuff doesn't break host - co-routine, default already built

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

2016-03-23 Thread Peter Maydell
On 23 March 2016 at 16:52, Programmingkid wrote: > On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote: >> I've put the qapi-schema.json and the ui/cocoa.m patches into the >> cocoa pull I've just sent. For the ADB keyboard part, I definitely >> think that the best

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-23 Thread Kevin Wolf
Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben: > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > +The type of information required by the client is passed to server in > > the > > +command flags field. If the server does not implement requested type or > > +

Re: [Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-03-23 Thread Stefan Hajnoczi
On Wed, Mar 23, 2016 at 10:46:56AM +0800, Xiao Guangrong wrote: > On 03/23/2016 04:30 AM, Stefan Hajnoczi wrote: > >On Tue, Mar 22, 2016 at 08:37:40AM -0700, Dan Williams wrote: > >>On Thu, Mar 17, 2016 at 3:04 AM, Stefan Hajnoczi wrote: > >>>On Thu, Mar 17, 2016 at 04:32:46PM

Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 17:47, Hollis Blanchard wrote: > Paolo, is it true that only TB-invalidating writes go through the > io_mem_notdirty path? I'm looking at the live migration code now, and it > seems like every memory write will go through that path when global > dirty memory logging is enabled.

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Eric Blake
On 03/23/2016 01:18 AM, Li, Liang Z wrote: >>> >>> >From guest's point of view, there are some pages currently not used by >> >> I see in your original RFC patch and your RFC doc, this line starts with a >> character '>'. Not sure this one has a special purpose? >> > > No special purpose. Maybe

Re: [Qemu-devel] [PATCH v5 0/4] Implement some QKeyCode support

2016-03-23 Thread Programmingkid
On Mar 23, 2016, at 10:37 AM, Peter Maydell wrote: > On 15 March 2016 at 17:13, Programmingkid wrote: >> This patchset adds QKeyCode support to the adb and cocoa code. >> >> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json, >> and

[Qemu-devel] [PATCH v2 1/5] .travis.yml: collapse the test matrix

2016-03-23 Thread Alex Bennée
Remove the concept of TARGETS and build the complete target list for each config combination. Now the matrix is just based on CONFIG stanzas and we use the additional stuff for: - things that only work on one compiler (sparse, gcov, gprof) - combos where "make check" fails Signed-off-by:

[Qemu-devel] [PATCH v2 0/5] travis: reduce the matrix, add OSX, speed-up builds

2016-03-23 Thread Alex Bennée
Here is v2. I've added two new patches, a tweak to configure to accept stems for target lists and then using that to cut the build time where it makes sense. There has been a little tweak to the OSX build and finally I've added r-b tags to the collapse and j3 patches. Alex Bennée (5):

[Qemu-devel] [PATCH v2 2/5] .travis.yml: enable OSX builds

2016-03-23 Thread Alex Bennée
Travis has support for OSX builds. Making the setup work cleanly involves a little hacking about with the .travis.yml file but rather than make it too messy I've pushed all the "brew" install stuff into a support script called ./scripts/macosx-brew.sh. Currently only the default ./configure

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-23 Thread Wouter Verhelst
On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > From: Pavel Borzenkov > > With the availability of sparse storage formats, it is often needed to > query status of a particular LBA range and read only those blocks of > data that are actually present on

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

2016-03-23 Thread Jan Kiszka
On 2016-03-23 17:27, Alex Bennée wrote: > > KONRAD Frederic writes: > >> Hi Alex, >> >> Thanks for having pulling all that together! >> About this patch the original author was Jan Kiszka >> (https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03323.html) >> >>

[Qemu-devel] [PATCH] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Bandan Das
vfio_listener_region_add for a iommu mr results in an overflow assert since vt-d memory region is initialized with UINT64_MAX. Convert calculations to 128 bit arithmetic for such regions and let int128_get64 assert for non iommu regions only. Suggested-by: Alex Williamson

Re: [Qemu-devel] [PATCH v1] util: fix comment typos

2016-03-23 Thread Eric Blake
On 03/14/2016 03:58 AM, Wei Jiangang wrote: > Signed-off-by: Wei Jiangang > --- > util/buffer.c | 4 ++-- > util/qemu-sockets.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-03-23 Thread John Snow
On 03/23/2016 06:26 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Restart of ATAPI DMA used to be unreachable, because the request to do > so wasn't indicated in bus->error_status due to the lack of spare bits, and > ide_restart_bh() would return early doing

Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-23 Thread Max Reitz
On 18.03.2016 11:31, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. Ah, so that's why I didn't have it in v3. Thanks for solving that mystery for me. :-) > The only other remaining user is >

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-23 Thread Eric Blake
On 03/18/2016 09:19 AM, Kevin Wolf wrote: +ov = opts_visitor_new(opts); + +visit_start_struct(opts_get_visitor(ov), + "luks", NULL, 0, _err); >>> >>> As this refers to "luks" specifically, shouldn't it be inside the switch >>> below? >> >> Or

[Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-03-23 Thread Dominik Dingel
While in the anonymous ram case we already take care of the right alignment such an alignment gurantee does not exist for file backed ram allocation. Instead, pagesize is used for alignment. On s390 this is not enough for gmap, as we need to satisfy an alignment up to segments. Reported-by:

Re: [Qemu-devel] [PATCH 03/12] block: Introduce BlockBackendPublic

2016-03-23 Thread Eric Blake
On 03/23/2016 03:09 AM, Kevin Wolf wrote: >>> +++ b/block/block-backend.c >>> @@ -33,6 +33,7 @@ struct BlockBackend { >>> DriveInfo *legacy_dinfo;/* null unless created by drive_new() */ >>> QTAILQ_ENTRY(BlockBackend) link; /* for block_backends */ >>>

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 11:26, Denis V. Lunev wrote: > If the migration occurs after the IDE DMA has been set up but before it > has been initiated, the state gets lost upon save/restore. Specifically, > ->dma_cb callback gets cleared, so, when the guest eventually starts bus > mastering, the DMA never

Re: [Qemu-devel] [PATCH] quorum: add child name into filename

2016-03-23 Thread Max Reitz
On 18.03.2016 04:21, Wen Congyang wrote: > The monitor command 'query-block' or 'info block' will output the filename. > So we can get each children's child-name after this patch. This useful for > dynamic reconfiguration. > > Signed-off-by: Wen Congyang > --- >

Re: [Qemu-devel] [PATCH] Fix some typos found by codespell

2016-03-23 Thread Eric Blake
On 03/23/2016 11:13 AM, Stefan Weil wrote: > I'm no longer sure which spelling is correct. :-) > >>From https://www.fsf.org/about/history.html: > 1985 Richard Stallman creates the Free Sofware Foundation I got a good chuckle out of that; then sent off a bug report to the webmaster. That

Re: [Qemu-devel] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback

2016-03-23 Thread Paolo Bonzini
On 22/03/2016 16:33, Kevin Wolf wrote: > This removes the last part of I/O throttling from block/io.c and moves > it to the BlockBackend. > > When draining the queue of a BlockDriverState, we must make sure that no > new requests can come in for it. Request sources from outside the block >

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

2016-03-23 Thread KONRAD Frederic
Hi Alex, Thanks for having pulling all that together! About this patch the original author was Jan Kiszka (https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03323.html) This has probably been dropped during a rebase. Thanks, Fred Le 18/03/2016 17:18, Alex Bennée a écrit : From:

Re: [Qemu-devel] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Alberto Garcia
On Wed 23 Mar 2016 10:03:41 AM CET, Kevin Wolf wrote: >> This series would mess up my own I/O throttling cleanups that have >> been posted in February and have hardly seen a review for one month. > > Which cleanups? The ones that you hid in an I/O path locking series? > Whose

[Qemu-devel] [patch v5 06/12] vfio: add check host bus reset is support or not

2016-03-23 Thread Cao jin
From: Chen Fan When assigning a vfio device with AER enabled, we must check whether the device supports a host bus reset (ie. hot reset) as this may be used by the guest OS in order to recover the device from an AER error. QEMU must therefore have the ability to

[Qemu-devel] [patch v5 05/12] vfio: refine function vfio_pci_host_match

2016-03-23 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/vfio/pci.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 0516d94..5b23a86 100644 --- a/hw/vfio/pci.c +++

Re: [Qemu-devel] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command

2016-03-23 Thread Christoffer Dall
Hi Peter, Stupid question: The subject says "SMP command". Did you mean "QMP command" ? Thanks, -Christoffer On Wed, Mar 23, 2016 at 01:32:29PM +0800, Peter Xu wrote: > v6 changes: > - patch 1 (squashed into patch 2) > - explain more about the following in commit message: why we need >

Re: [Qemu-devel] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 11:32:06AM +0100, Christoffer Dall wrote: > Hi Peter, > > Stupid question: The subject says "SMP command". Did you mean "QMP > command" ? It's for sure a good question... My fault. It should be QMP. Thanks to point out. -- peterx

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: > >> Markus Armbruster writes: > >> >> +## > >> >> +# @GICCapability: > >> >> +# > >> >> +# This

Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time

2016-03-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/03/2016 10:18, Markus Armbruster wrote: >>> In Kevin's idea there would be no ownership either way. Until then, I >>> think my patch actually gets us closer to the ideal. >> >> I'm afraid it gets us closer to where we used to be six years ago

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: >> >> Markus Armbruster writes: >> >> >> +## >> >> >>

Re: [Qemu-devel] [PATCH v3 05/10] util: add QAuthZSimple object type for a simple access control list

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 11:38:53AM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > Add a QAuthZSimple object type that implements the QAuthZ > > interface. This simple built-in implementation maintains > > a trivial access control list with a sequence of match > >

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote: >> Markus Armbruster writes: >> >> +## >> >> +# @GICCapability: >> >> +# >> >> +# This struct describes capability for a specific GIC version. These >> >> +# bits are not

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote: > > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > >> On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote: > >>> * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > From: Wen Congyang

Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 10:18, Markus Armbruster wrote: >> In Kevin's idea there would be no ownership either way. Until then, I >> think my patch actually gets us closer to the ideal. > > I'm afraid it gets us closer to where we used to be six years ago :) > > Qdev drive properties used to point to a

Re: [Qemu-devel] iotest 026 -nocache is broken

2016-03-23 Thread Vladimir Sementsov-Ogievskiy
On 22.03.2016 21:06, Paolo Bonzini wrote: On 22/03/2016 19:00, Vladimir Sementsov-Ogievskiy wrote: Hi all! Just a notice for commit (near to master branch top) commit 3666a97f78704b941c360dc917acb14c8774eca7 Author: Eric Blake Date: Thu Mar 17 16:48:40 2016 -0600

Re: [Qemu-devel] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Kevin Wolf
[ Cc: Stefan ] Am 23.03.2016 um 10:28 hat Paolo Bonzini geschrieben: > On 23/03/2016 10:03, Kevin Wolf wrote: > > Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben: > >> On 22/03/2016 16:33, Kevin Wolf wrote: > >>> This is another feature that was "logically" part of the BlockBackend, but >

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Changlong Xie
On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote: * Changlong Xie

[Qemu-devel] [patch v5 03/12] vfio: add pcie extended capability support

2016-03-23 Thread Cao jin
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. due to add a new pcie capability at the tail of the chain, in order to avoid config space overwritten, we introduce a copy config for parsing extended caps. and rebuild the

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

2016-03-23 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote: > >* Wen Congyang (we...@cn.fujitsu.com) wrote: > >>On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote: > >>>* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 03/22/2016 08:22 PM,

Re: [Qemu-devel] [PATCH v2 11/16] sheepdog: disable dataplane

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 11:45, Kevin Wolf wrote: > I wouldn't feel comfortable about ignoring this second part, but maybe > we could get away with it if we have a plan how to fix it in the long > run. The new op blockers should be able to do that, but I guess it will > be well into the 2.7 development

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-23 Thread Peter Maydell
On 23 March 2016 at 00:05, Samuel Thibault wrote: > Hello Peter, > > Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: >> diff --git a/slirp/mbuf.h b/slirp/mbuf.h >> index 38fedf4..ef5a4f7 100644 >> --- a/slirp/mbuf.h >> +++ b/slirp/mbuf.h >> @@ -81,11 +81,9 @@

Re: [Qemu-devel] [PATCH v3 10/10] vnc: allow specifying a custom ACL object name

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 03:38:14PM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > The VNC server has historically had support for ACLs to check > > both the SASL username and the TLS x509 distinguished name. > > The VNC server was responsible for creating the

Re: [Qemu-devel] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 09:54:03AM +0100, Andrea Bolognani wrote: > On Wed, 2016-03-23 at 13:32 +0800, Peter Xu wrote: > > v6 changes: > > - patch 1 (squashed into patch 2) > >   - explain more about the following in commit message: why we need > > this command, and what does the entries mean

Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface

2016-03-23 Thread Markus Armbruster
Peter Xu writes: > On Tue, Mar 22, 2016 at 12:42:42PM -0600, Eric Blake wrote: >> On 03/17/2016 09:27 PM, Peter Xu wrote: >> > This patch adds the command "query-gic-capabilities" but not implemnet >> >> s/not implemnet/does not implement/ > > Yep, again. Thanks. > >> >> >

[Qemu-devel] [patch v5 04/12] vfio: add aer support for vfio device

2016-03-23 Thread Cao jin
From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 85

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-23 Thread Daniel P. Berrange
On Sun, Mar 20, 2016 at 12:39:14PM +0100, Samuel Thibault wrote: > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > setup IPv4-only and IPv6-only network environments. I really don't like this kind of magic because it is totally invisible to the user unless they read

Re: [Qemu-devel] [PATCH v2 11/16] sheepdog: disable dataplane

2016-03-23 Thread Kevin Wolf
Am 16.03.2016 um 15:16 hat Paolo Bonzini geschrieben: > sheepdog has some calls to aio_poll that are hard to eliminate, for > example in sd_sheepdog_goto's call to do_req. Since I don't have > means to test sheepdog well, disable dataplane altogether for this > driver. > > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function

2016-03-23 Thread Sergey Fedorov
On 23/03/16 08:32, Peter Xu wrote: > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 6695fa7..8738fa1 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -306,6 +306,15 @@ void kvm_device_access(int fd, int group, uint64_t attr, > */ > int

Re: [Qemu-devel] [PATCH v3 07/10] qemu-nbd: add support for ACLs for TLS clients

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 12:14:27PM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > Currently any client which can complete the TLS handshake > > is able to use the NBD server. The server admin can turn > > on the 'verify-peer' option for the x509 creds to require >

Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time

2016-03-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/03/2016 11:25, Markus Armbruster wrote: >> Regardless of how and when we create BlockBackend, we'll want to keep >> the clean separation between frontend and backend internally and at the >> user interface. > > This means that the BlockBackend

Re: [Qemu-devel] [PATCH RFC 0/6] virtio: refactor host notifiers

2016-03-23 Thread Fam Zheng
On Thu, 03/17 11:01, Cornelia Huck wrote: > As discussed in the virtio-blk dataplane start/stop thread, the > various transports contain a lot of similar/identical boilerplate > code for setting up ioeventfds. This makes the code hard to follow. > > Let's drag all of the common handling into the

[Qemu-devel] [PATCH v3 0/2] Convert pxb initfn to Error

2016-03-23 Thread Wei Jiangang
v2 -> v3: - Pass local *err to error_setg() in pxb_dev_realize_common() v1 -> v2: - Extract a separate bugfix patch - Squash v1 patches 1-3 together - Drop the period and exclamation mark - Modify commit message v1: cover-letter The original patch named '[PATCH v3] PXB: convert to realize()'

[Qemu-devel] [PATCH v3 1/2] hw/pci-bridge: Add missing unref in case register-bus fails

2016-03-23 Thread Wei Jiangang
The error paths after a successful qdev_create/pci_bus_new should contain a object_unref/object_unparent. pxb_dev_init_common() did not yet, so add it. Signed-off-by: Wei Jiangang Signed-off-by: Cao jin ---

[Qemu-devel] [patch v5 10/12] vfio-pci: pass the aer error to guest

2016-03-23 Thread Cao jin
From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, resulting in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and let the

Re: [Qemu-devel] [PATCH qemu v14 01/18] memory: Fix IOMMU replay base address

2016-03-23 Thread Paolo Bonzini
On 22/03/2016 04:26, David Gibson wrote: >> > >...it might be simpler to replace both the iommu and >> > >offset_within_address_space fields here with a pointer to the >> > >MemoryRegionSection instead, which should give you all the info you >> > >need. >> >> >> MemoryRegionSection is

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2016-03-23 Thread Prasanna Kalever
On Fri, Feb 5, 2016 at 6:47 PM, Prasanna Kumar Kalever wrote: > > On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote: > > Am 12.11.2015 um 23:36 hat Eric Blake geschrieben: > > > On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > > > > +static struct glfs

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu

2016-03-23 Thread Sergey Fedorov
On 23/03/16 08:32, Peter Xu wrote: > diff --git a/target-arm/kvm.c b/target-arm/kvm.c > index 969ab0b..0a7f9a6 100644 > --- a/target-arm/kvm.c > +++ b/target-arm/kvm.c > @@ -62,13 +62,17 @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t > *cpus_to_try, > goto err; > } > > +

Re: [Qemu-devel] [PATCH RFC v2 1/2] Add param Error** to msi_init() & modify the callers

2016-03-23 Thread Cao jin
On 03/23/2016 04:12 PM, Markus Armbruster wrote: Cao jin writes: Really appreciate your review, I just finished reading all the comments and discussion. Seems pci_add_capability2()(commit cd9aa33e introduced) doesn`t follow the new error reporting rule(report

Re: [Qemu-devel] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 10:03, Kevin Wolf wrote: > Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben: >> On 22/03/2016 16:33, Kevin Wolf wrote: >>> This is another feature that was "logically" part of the BlockBackend, but >>> implemented as a BlockDriverState feature. It was always kept on top using

[Qemu-devel] [patch v5 02/12] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2016-03-23 Thread Cao jin
From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31

[Qemu-devel] [patch v5 01/12] vfio: extract vfio_get_hot_reset_info as a single function

2016-03-23 Thread Cao jin
From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1

[Qemu-devel] [patch v5 07/12] pci: add a pci_function_is_valid callback to check function if valid

2016-03-23 Thread Cao jin
From: Chen Fan PCI hotplug requires that function 0 is added last to close the slot. Since vfio supporting AER, we require that the VM bus contains the same set of devices as the host bus to support AER, we can perform an AER validation test whenever a function 0

[Qemu-devel] [patch v5 12/12] vfio: add 'aer' property to expose aercap

2016-03-23 Thread Cao jin
From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

2016-03-23 Thread Markus Armbruster
Wei Jiangang writes: > v1 -> v2: > > - Extract a separate bugfix patch > - Squash v1 patches 1-3 together > - Drop the period and exclamation mark > - Modify commit message > > v1: cover-letter > > The original patch named '[PATCH v3] PXB: convert to realize()' > was

Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 10:44:04AM +0100, Markus Armbruster wrote: > Depends. > > The general rule is to keep separate things separate, and patches > self-contained. The narrow sense of self-contained is each patch > compiles and works. The wider sense is each patch makes sense to its > readers

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci-bridge: Convert pxb initialization functions to Error

2016-03-23 Thread Markus Armbruster
Wei Jiangang writes: > Firstly, convert pxb_dev_init_common() to Error and rename > it to pxb_dev_realize_common(). > Actually, pxb_register_bus() is converted as well. > > And then, > convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error, > rename them to

Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface

2016-03-23 Thread Peter Xu
On Wed, Mar 23, 2016 at 10:52:29AM +0100, Markus Armbruster wrote: > The rule against returning non-dictionaries exists to avoid interfaces > that cannot evolve. With a dictionary, you can evolve by adding > members. > > The rule does *not* forbid returning lists of dictionaries. When a >

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 4/4] arm: implement query-gic-capabilities

2016-03-23 Thread Sergey Fedorov
On 23/03/16 08:32, Peter Xu wrote: > diff --git a/target-arm/monitor.c b/target-arm/monitor.c > index 254a9c9..4a2db59 100644 > --- a/target-arm/monitor.c > +++ b/target-arm/monitor.c > @@ -21,8 +21,66 @@ (snip) > GICCapabilityResult *qmp_query_gic_capabilities(Error **errp) > { > -return

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-23 Thread Samuel Thibault
Peter Maydell, on Wed 23 Mar 2016 12:43:44 +, wrote: > On 23 March 2016 at 00:05, Samuel Thibault wrote: > > Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > >> diff --git a/slirp/mbuf.h b/slirp/mbuf.h > >> index 38fedf4..ef5a4f7 100644 > >> ---

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 10:53:42AM -0600, Eric Blake wrote: >On 03/23/2016 01:18 AM, Li, Liang Z wrote: > >From guest's point of view, there are some pages currently not used by >>> >>> I see in your original RFC patch and your RFC doc, this line starts with a >>> character '>'. Not sure

Re: [Qemu-devel] [PATCH] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Alex Williamson
On Wed, 23 Mar 2016 16:57:35 -0400 Bandan Das wrote: > vfio_listener_region_add for a iommu mr results in > an overflow assert since vt-d memory region is initialized > with UINT64_MAX. Convert calculations to 128 bit arithmetic > for such regions and let int128_get64 assert for

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > This fails silently as well, since vpc_create() did not set errp > in this failuer case. Set errp in all instances in vpc_create(). s/faileur/failure/ Can be done when merging, no need to resend. signature.asc Description: PGP

Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button

2016-03-23 Thread Wei Huang
On 03/23/2016 11:12 AM, Peter Maydell wrote: > On 17 March 2016 at 13:25, Shannon Zhao wrote: >> From: Shannon Zhao >> >> There is a problem for power button that it will not work if an early >> system_powerdown request happens before guest

[Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets

2016-03-23 Thread Alex Bennée
This is useful if you want to build all targets of a given architecture or type. A simple submatch to an real target will add it to the list. Signed-off-by: Alex Bennée --- configure | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-2.6 0/7] block: VHD format fixes

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:37PM -0400, Jeff Cody wrote: > Fixes for a regression in vpc_create(), as well as a few issues with VHD > format > compatibility. > > > Jeff Cody (6): > block/vpc: fix VPC 'qemu-img create' regression > block/vpc: use current_size field for XenConverter VHD

[Qemu-devel] [PATCH v7 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu

2016-03-23 Thread Peter Xu
Some more lines to make sure we allow NULL for 1st/3rd parameter. Signed-off-by: Peter Xu --- target-arm/kvm.c | 14 +- target-arm/kvm_arm.h | 6 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/target-arm/kvm.c b/target-arm/kvm.c index

[Qemu-devel] [PATCH v7 3/4] kvm: add kvm_device_supported() helper function

2016-03-23 Thread Peter Xu
This can be used when probing whether KVM support specific device. Here, a raw vmfd is used. Signed-off-by: Peter Xu --- include/sysemu/kvm.h | 9 + kvm-all.c| 15 +++ 2 files changed, 24 insertions(+) diff --git a/include/sysemu/kvm.h

Re: [Qemu-devel] [PULL v3 02/13] crypto: add support for PBKDF2 algorithm

2016-03-23 Thread Wen Congyang
On 03/18/2016 12:53 AM, Daniel P. Berrange wrote: > The LUKS data format includes use of PBKDF2 (Password-Based > Key Derivation Function). The Nettle library can provide > an implementation of this, but we don't want code directly > depending on a specific crypto library backend. Introduce > a

Re: [Qemu-devel] [PATCH] quorum: Implement bdrv_get_specific_info

2016-03-23 Thread Fam Zheng
On Thu, 03/24 11:17, Wen Congyang wrote: > The monitor command 'query-block' or 'info block' will output the format > specific > information. So we can get each child's child-name after this patch. This > useful > for dynamic reconfiguration. > > Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH v7 1/4] arm: qmp: add query-gic-capabilities interface

2016-03-23 Thread Peter Xu
This patch add "query-gic-capabilities" but does not implemnet it. The command is ARM-only. The command will return a list of GICCapability struct that describes all GIC versions that current QEMU and system support. Libvirt is possibly the first consumer of this new command. Before this patch,

[Qemu-devel] [PATCH v7 0/4] ARM: add query-gic-capabilities QMP command

2016-03-23 Thread Peter Xu
v7 changes: - patch 1 - add more to commit log, about how to use the results [Markus] - change interface from dict back to array [Markus, Eric] - patch 2 - kvm_arm_create_scratch_host_vcpu should raise error when init non-zero, but failed to find a good CPU model [Sergey] - patch 3 -

[Qemu-devel] [PATCH v7 4/4] arm: implement query-gic-capabilities

2016-03-23 Thread Peter Xu
For emulated GIC capabilities, currently only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits by creating a scratch VM. Signed-off-by: Peter Xu --- target-arm/monitor.c | 58

[Qemu-devel] [PATCH] quorum: Implement bdrv_get_specific_info

2016-03-23 Thread Wen Congyang
The monitor command 'query-block' or 'info block' will output the format specific information. So we can get each child's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang --- block/quorum.c | 27

Re: [Qemu-devel] [PATCH qemu v14 17/18] vfio/spapr: Use VFIO_SPAPR_TCE_v2_IOMMU

2016-03-23 Thread Alexey Kardashevskiy
On 03/23/2016 05:03 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 02:06:36PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 01:53 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 01:12:59PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 12:08 PM, David Gibson wrote: On Tue, Mar 22, 2016

[Qemu-devel] [PATCH v2] vfio: convert to 128 bit arithmetic calculations when adding mem regions

2016-03-23 Thread Bandan Das
vfio_listener_region_add for a iommu mr results in an overflow assert since iommu memory region is initialized with UINT64_MAX. Convert calculations to 128 bit arithmetic for iommu memory regions and let int128_get64 assert for non iommu regions if there's an overflow. Suggested-by: Alex

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 02:35:42PM +, Li, Liang Z wrote: >> >No special purpose. Maybe it's caused by the email client. I didn't >> >find the character in the original doc. >> > >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg00715.html >> >> You could take a look at this

  1   2   3   >