[Qemu-devel] [PATCH v5 7/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D>

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic New set of helpers for handling nan2008-syle versions of instructions .., for Mips R6. All involved instructions have float operand and integer result. Their core functionality is implemented via

[Qemu-devel] [PATCH v5 6/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D>

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Updated handling of instuctions .. Note that legacy (pre-abs2008) ABS and NEG instructions are arithmetic (and, therefore, any NaN operand causes signaling invalid operation), while abs2008 ones are non-arithmetic, always

[Qemu-devel] [PATCH v5 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd()

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Only for Mips platform, and only for cases when snan_bit_is_one is 0, correct the order of argument comparisons in pickNaNMulAdd(). For more info, see [2], page 53, section "3.5.3 NaN Propagation". [1] "MIPS® Architecture For

[Qemu-devel] [PATCH v5 0/9] target-mips: Initiate IEEE 754-2008 support for Mips

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic v5 - platform initialization code revisited one more time; - handling of CLASS. and their MSA counterparts revisited; - better orgranization of patches (squashing, splitting); - corrected handling of

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-18 Thread Markus Armbruster
Markus Armbruster writes: [...] > To make forward progress, I recommend to split this patch into an > uncontroversial and a controversial part. The uncontroversial part are > the RFQDN rules. I offered Michael to do that for him, and he accepted. Patch is on its way.

Re: [Qemu-devel] [PATCH for-2.6] fw_cfg: Adopt /opt/RFQDN convention

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 06:42:09PM +0200, Markus Armbruster wrote: > FW CFG's primary user is QEMU, which uses it to expose configuration > information (in the widest sense) to Firmware. Thus the name FW CFG. > > FW CFG can also be used by others for their own purposes. QEMU is > merely acting

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > > > > reasonably freshly booted machine (so that the pages get > > > > > > > > > THPd). > > > > > > > > > >

Re: [Qemu-devel] [PATCH v3 03/10] tcg: Rearrange tb_link_page() to avoid forward declaration

2016-04-18 Thread Sergey Fedorov
On 18/04/16 20:20, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> Signed-off-by: Sergey Fedorov >> Signed-off-by: Sergey Fedorov >> Reviewed-by: Alex Bennée

[Qemu-devel] [PATCH for-2.6] fw_cfg: Adopt /opt/RFQDN convention

2016-04-18 Thread Markus Armbruster
FW CFG's primary user is QEMU, which uses it to expose configuration information (in the widest sense) to Firmware. Thus the name FW CFG. FW CFG can also be used by others for their own purposes. QEMU is merely acting as transport then. Names starting with opt/ are reseved for such uses.

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Sergey Fedorov
On 18/04/16 20:17, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 18/04/16 17:09, Alex Bennée wrote: >>> Sergey Fedorov writes: diff --git a/cpu-exec.c b/cpu-exec.c >> (snip) @@ -507,14 +510,12 @@ int cpu_exec(CPUState *cpu)

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 11:51:41AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 18:30 +0300, Michael S. Tsirkin wrote: > > > > > Setting (only) VIRTIO_F_IOMMU_PASSTHROUGH indicates to the guest that > > > its own operating system's IOMMU code is expected to be broken, and > > > that the

[Qemu-devel] [PATCH v2] target-arm: Fix descriptor address masking in ARM address translation

2016-04-18 Thread Sergey Sorokin
There is a bug in ARM address translation regime with a long-descriptor format. On the descriptor reading its address is formed from an index which is a part of the input address. And on the first iteration this index is incorrectly masked with 'grainsize' mask. But it can be wider according to

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > On 18/04/16 17:09, Alex Bennée wrote: >> Sergey Fedorov writes: >>> From: Sergey Fedorov >>> >>> 'tb_invalidated_flag' was meant to catch two events: >>> * some TB has been invalidated by

Re: [Qemu-devel] [PATCH v5 7/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D>

2016-04-18 Thread Aleksandar Markovic
There was a small error in the version of this patch 7/9 sent an hour ago. Please apply this corrected version. From: Aleksandar Markovic New set of helpers for handling nan2008-syle versions of instructions .., for Mips R6.

[Qemu-devel] [PATCH] target-arm: Stage 2 permission fault was fixed in AArch32 state

2016-04-18 Thread Sergey Sorokin
As described in AArch32.CheckS2Permission an instruction fetch fails if XN bit is set or there is no read permission for the address. Signed-off-by: Sergey Sorokin --- target-arm/helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v5 5/9] target-mips: Activate IEEE 274-2008 signaling NaN bit meaning

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Functions mips_cpu_reset() and msa_reset() are updated so that flag snan_bit_is_one is properly set for any Mips FPU/MSA configuration. For main FPUs, CPUs with FCR31's FCR31_NAN2008 bit set will invoke set_snan_bit_is_one(0). For MSA, as

[Qemu-devel] [PATCH v5 4/9] target-mips: Amend processor definitions in relation to FCR31

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend definitions of some Mips processors related to FCR31 (float status control register). Most significantly, FCR31 of processors mips32r6-generic, mips64r6-generic, and P5600 will be set so that its FCR31_ABS2008 and FCR31_NAN2008 bits

[Qemu-devel] [PATCH v5 2/9] softfloat: For Mips only, correct default NaN values

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Only for Mips platform, and only for cases when snan_bit_is_one is 0, correct default NaN values (in their 16-, 32-, and 64-bit flavors). For more info, see [1], page 84, Table 6.3 "Value Supplied When a New Quiet NaN Is Created", and

[Qemu-devel] [PULL 0/1] QOM CPUState patch queue 2016-04-18

2016-04-18 Thread Andreas Färber
Hello Peter, This is my QOM CPU patch queue. Please pull. Regards, Andreas Cc: Peter Maydell The following changes since commit 6a6fa68ae2884cc1834110e549faa9cd86050ce6: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging

[Qemu-devel] [PULL 1/1] MAINTAINERS: Drop target-i386 from CPU subsystem

2016-04-18 Thread Andreas Färber
X86CPU QOM type is in good hands and actively maintained these days, so drop it from the generic QOM CPU subsystem. Some refactorings and design questions will still intersect, but review and discussions of individual series can still take place while opting out of general X86CPU patch review.

Re: [Qemu-devel] [PATCH v3 03/10] tcg: Rearrange tb_link_page() to avoid forward declaration

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > Reviewed-by: Alex Bennée This clashes with the tcg

[Qemu-devel] [PATCH v5 8/9] target-mips: Clean up position and order of helpers for CVT.<L|W>.<S|D>

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch makes position and order of helpers for CVT.. within file target-mips/op_helper.c consistent with position and order of helpers for ... Signed-off-by: Aleksandar Markovic

Re: [Qemu-devel] [PULL 0/1] QOM CPUState patch queue 2016-04-18

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 17:29, Andreas Färber wrote: > Hello Peter, > > This is my QOM CPU patch queue. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > > The following changes since commit 6a6fa68ae2884cc1834110e549faa9cd86050ce6: > > Merge

[Qemu-devel] [PATCH v5 9/9] target-mips: Clean up position of abs2008/nan2008 cases in genfarith()

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch slightly reorders cases in genfarith() so that abs2008/nan2008- dependant cases are grouped together, for easier maintenantce (code becomes less prone to errors). Signed-off-by: Aleksandar Markovic

[Qemu-devel] [PATCH v5 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch modifies SoftFloat library so that it can be configured in run-time in relation to the meaning of signaling NaN bit, while, at the same time, strictly preserving its behavior on all existing platforms. Background: In

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 19:27 +0300, Michael S. Tsirkin wrote: > I balk at adding more hacks to a broken system. My goals are > merely to > - make things work correctly with an IOMMU and new guests, >   so people can use userspace drivers with virtio devices > - prevent security risks when guest

Re: [Qemu-devel] [PATCH RFC 2/3] vfio: report group noiommu status

2016-04-18 Thread Alex Williamson
On Mon, 18 Apr 2016 12:58:20 +0300 "Michael S. Tsirkin" wrote: > When using vfio, callers might want to know whether device is added to a > regular group or an non-iommu group. > > Report this status from vfio_add_group_dev. > > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH RFC 3/3] vfio: add virtio pci quirk

2016-04-18 Thread Alex Williamson
On Mon, 18 Apr 2016 12:58:28 +0300 "Michael S. Tsirkin" wrote: > Modern virtio pci devices can set VIRTIO_F_IOMMU_PLATFORM > to signal they are safe to use with an IOMMU. > > Without this bit, exposing the device to userspace is unsafe, so probe > and fail VFIO initialization

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Andy Lutomirski
On Mon, Apr 18, 2016 at 11:29 AM, David Woodhouse wrote: > For x86, you *can* enable virtio-behind-IOMMU if your DMAR tables tell > the truth, and even legacy kernels ought to cope with that. > FSVO 'ought to' where I suspect some of them will actually crash with a > NULL

Re: [Qemu-devel] Persistent Main Memory in QEmu

2016-04-18 Thread Artyom Tarasenko
Hi Tianyou, On Mon, Apr 18, 2016 at 5:50 AM, Li, Tianyou wrote: > Currently we are trying to implement below functionalities in QEmu: main > memory in guest can be logically viewed as persistent and its content can be > survived through reboot or shutdown/powerup. > > I

Re: [Qemu-devel] [PATCH for-2.6] fw_cfg: Adopt /opt/RFQDN convention

2016-04-18 Thread Eric Blake
On 04/18/2016 10:42 AM, Markus Armbruster wrote: > FW CFG's primary user is QEMU, which uses it to expose configuration > information (in the widest sense) to Firmware. Thus the name FW CFG. > > FW CFG can also be used by others for their own purposes. QEMU is > merely acting as transport then.

[Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-18 Thread Matthew Schumacher
Thank you for working on this. Super helpful to have someone looking at this issue! With those two patches applied to 2.6.0-rc2 I still get the following: qemu-system-x86_64: block/mirror.c:342: mirror_iteration: Assertion `hbitmap_next == next_sector' failed. The line number confirms that

[Qemu-devel] [PULL 0/1] X86 fix for 2.6.0-rc3

2016-04-18 Thread Eduardo Habkost
Last-minute fix. Still in time for -rc3, I hope. The following changes since commit 92b674b62a1aec734280c9019cfb3b3745044b66: Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-peter' into staging (2016-04-18 17:42:59 +0100) are available in the git repository at:

[Qemu-devel] [PULL 1/1] target-i386: Set AMD alias bits after filtering CPUID data

2016-04-18 Thread Eduardo Habkost
QEMU complains about -cpu host on an AMD machine: warning: host doesn't support requested feature: CPUID.8001H:EDX [bit 0] For bits 0,1,3,4,5,6,7,8,9,12,13,14,15,16,17,23,24. KVM_GET_SUPPORTED_CPUID and and x86_cpu_get_migratable_flags() don't handle the AMD CPUID aliases bits, making

[Qemu-devel] [PATCH 1/2] block: Invalidate all children

2016-04-18 Thread Fam Zheng
Currently we only recurse to bs->file, which will miss the children in quorum and VMDK. Recurse into the whole subtree to avoid that. Signed-off-by: Fam Zheng --- block.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/block.c

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-18 Thread Li, Liang Z
> > > > I am now working on how to benefit post-copy by skipping the free > > > > pages, and I remember you have said we should let the destination > > > > know the info of free pages so as to avoid request the free pages > > > > from the > > > source. > > > > > > > > We have two solutions: > > >

[Qemu-devel] [PATCH 2/2] block: Inactivate all children

2016-04-18 Thread Fam Zheng
Currently we only inactivate the top BDS. Actually bdrv_inactivate should be the opposite of bdrv_invalidate_cache. Recurse into the whole subtree instead. Signed-off-by: Fam Zheng --- block.c | 8 1 file changed, 8 insertions(+) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH 0/2] block: More complete inactivate/invalidate of on graph

2016-04-18 Thread Fam Zheng
If qcow2 is a quorum child, we currently don't properly invalidate or inactivate it during migration. Recurse into the whole subtree (subgraph) in both bdrv_invalidate_cache and bdrv_inactivate. Fam Zheng (2): block: Invalidate all children block: Inactivate all children block.c | 28

Re: [Qemu-devel] [PATCH] cuda: fix off-by-one error in SET_TIME command

2016-04-18 Thread David Gibson
On Mon, Apr 18, 2016 at 10:07:45AM +0200, Aurelien Jarno wrote: > With the new framework the cuda_cmd_set_time command directly receive > the data, without the command byte. Therefore the time is stored at > in_data[0], not at in_data[1]. > > This fixes the "hwclock --systohc" command in a guest.

[Qemu-devel] [PULL 0/1] ppc-for-2.6 queue 20160419

2016-04-18 Thread David Gibson
The following changes since commit 92b674b62a1aec734280c9019cfb3b3745044b66: Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-peter' into staging (2016-04-18 17:42:59 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160419

[Qemu-devel] [PULL 1/1] cuda: fix off-by-one error in SET_TIME command

2016-04-18 Thread David Gibson
From: Aurelien Jarno With the new framework the cuda_cmd_set_time command directly receive the data, without the command byte. Therefore the time is stored at in_data[0], not at in_data[1]. This fixes the "hwclock --systohc" command in a guest. Cc: Hervé Poussineau

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Alex Bennée
Peter Maydell writes: > On 15 April 2016 at 16:56, Alex Bennée wrote: >> A number of configure options only really affect the core code and any >> arch specific stuff should be flushed out by other builds: >> >> - trace-backends, log build is

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 10:15, Alex Bennée wrote: > Peter Maydell writes: >> The wildcarding gives you a configure command that will >> potentially change behaviour as we introduce new targets, >> too; that makes me a bit nervous. > > Well it doesn't

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > The same here. Freshly

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 10:04, Mark Cave-Ayland wrote: > Hi Peter, > > This update is primarily to fix a regression booting early versions of MacOS > X under qemu-system-ppc. Please pull. > > > ATB, > > Mark. > > > The following changes since commit

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Alex Bennée
Peter Maydell writes: > On 18 April 2016 at 10:15, Alex Bennée wrote: >> Peter Maydell writes: >>> The wildcarding gives you a configure command that will >>> potentially change behaviour as we introduce new targets,

[Qemu-devel] [PATCH RFC 1/3] virtio: add features for IOMMU control

2016-04-18 Thread Michael S. Tsirkin
The interaction between virtio and DMA API is messy. On most systems with virtio, physical addresses match bus addresses, and it doesn't particularly matter whether we use the DMA API. On some systems, including Xen and any system with a physical device that speaks virtio behind a physical

[Qemu-devel] [PATCH RFC 0/3] virtio-pci: iommu support

2016-04-18 Thread Michael S. Tsirkin
This is an attempt to allow enabling IOMMU for DMA. Design: - new feature bit IOMMU_PLATFORM which means host won't bypass IOMMU - virtio core uses DMA API if it sees IOMMU_PLATFORM - add quirk for vfio to disable device unless IOMMU_PLATFORM is set or

Re: [Qemu-devel] [PULL 00/03] seccomp branch queue

2016-04-18 Thread Peter Maydell
On 16 April 2016 at 20:04, Eduardo Otubo wrote: > The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-04-15' > into staging (2016-04-15 17:43:34 +0100) > > are

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > > > > > > > The same here. Freshly booted machine with 64GiB ram. I've > > > > > > checked > > > > > > /proc/vmstat: huge pages were

[Qemu-devel] [RFC PATCH V3 4/4] colo-compare: add TCP, UDP, ICMP packet comparison

2016-04-18 Thread Zhang Chen
Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 158 +++-- 1 file changed, 154 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] ehci: apply limit to itd/sidt descriptors

2016-04-18 Thread P J P
+-- On Mon, 18 Apr 2016, Gerd Hoffmann wrote --+ | Commit "156a2e4 ehci: make idt processing more robust" tries to avoid a | DoS by the guest (create a circular itd queue and let qemu ehci | emulation run in circles forever). Unfortunaly this has two problems: | First it misses the case of sitds,

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-18 Thread Alexander Graf
On 18.04.16 11:21, Gerd Hoffmann wrote: > On Mo, 2016-04-18 at 09:26 +0200, Alexander Graf wrote: >> >> On 18.04.16 08:53, Gerd Hoffmann wrote: >>> Hi, >>> Vnc already uses qemu_input_event_send_key_delay today, so I'm not sure where things fall apart. >>> >>> Well, not everywhere.

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Andrea Arcangeli (aarca...@redhat.com) wrote: > On Fri, Apr 15, 2016 at 06:23:30PM +0300, Kirill A. Shutemov wrote: > > The same here. Freshly booted machine with 64GiB ram. I've checked > > /proc/vmstat: huge pages were allocated > > I tried the test in a loop and I can't reproduce it here. >

[Qemu-devel] [PATCH] cadence_uart: bounds check write offset

2016-04-18 Thread Michael S. Tsirkin
cadence_uart_init() initializes an I/O memory region of size 0x1000 bytes. However in uart_write(), the 'offset' parameter (offset within region) is divided by 4 and then used to index the array 'r' of size CADENCE_UART_R_MAX which is much smaller: (0x48/4). If 'offset>>=2' exceeds

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > reasonably freshly booted machine (so

[Qemu-devel] [PATCH v2 1/3] powerpc: scan_features() updates incorrect bits for REAL_LE

2016-04-18 Thread Michael Ellerman
From: Anton Blanchard The REAL_LE feature entry in the ibm_pa_feature struct is missing an MMU feature value, meaning all the remaining elements initialise the wrong values. This means instead of checking for byte 5, bit 0, we check for byte 0, bit 0, and then we incorrectly

[Qemu-devel] [RFC PATCH V3 2/4] colo-compare: track connection and enqueue packet

2016-04-18 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+

[Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
This adds a flag to enable/disable bypassing the IOMMU by virtio devices. This is on top of patch http://article.gmane.org/gmane.comp.emulators.qemu/403467 virtio: convert to use DMA api Tested with patchset http://article.gmane.org/gmane.linux.kernel.virtualization/27545 virtio-pci: iommu

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 14:47 +0300, Michael S. Tsirkin wrote: > This adds a flag to enable/disable bypassing the IOMMU by > virtio devices. I'm still deeply unhappy with having this kind of hack in the virtio code at all, as you know. Drivers should just use the DMA API and if the *platform* wants

[Qemu-devel] [PATCH 2/2] Revert "ehci: make idt processing more robust"

2016-04-18 Thread Gerd Hoffmann
This reverts commit 156a2e4dbffa85997636a7a39ef12da6f1b40254. Breaks freebsd. --- hw/usb/hcd-ehci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 923f110..7add81c 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@

[Qemu-devel] [PATCH 1/2] ehci: apply limit to itd/sidt descriptors

2016-04-18 Thread Gerd Hoffmann
Commit "156a2e4 ehci: make idt processing more robust" tries to avoid a DoS by the guest (create a circular itd queue and let qemu ehci emulation run in circles forever). Unfortunaly this has two problems: First it misses the case of sitds, and second it reportly breaks freebsd. So lets go for a

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

2016-04-18 Thread Denis V. Lunev
On 04/18/2016 12:34 PM, Daniel P. Berrange wrote: On Mon, Apr 18, 2016 at 09:12:44AM +0800, Fam Zheng wrote: On Sat, 04/16 16:29, Denis V. Lunev wrote: On 04/15/2016 06:27 AM, Fam Zheng wrote: virtlockd in libvirt locks the first byte, we lock byte 1 to avoid the intervene. Suggested-by:

Re: [Qemu-devel] [PATCH] cuda: fix off-by-one error in SET_TIME command

2016-04-18 Thread Hervé Poussineau
Le 18/04/2016 10:07, Aurelien Jarno a écrit : This fixes the "hwclock --systohc" command in a guest. Cc: Hervé Poussineau Cc: David Gibson Signed-off-by: Aurelien Jarno Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

2016-04-18 Thread Daniel P. Berrange
On Mon, Apr 18, 2016 at 09:12:44AM +0800, Fam Zheng wrote: > On Sat, 04/16 16:29, Denis V. Lunev wrote: > > On 04/15/2016 06:27 AM, Fam Zheng wrote: > > >virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > >the intervene. > > > > > >Suggested-by: "Daniel P. Berrange"

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread H. Peter Anvin
On April 18, 2016 2:28:42 AM PDT, "Daniel P. Berrange" wrote: >On Fri, Apr 15, 2016 at 08:56:59AM -0700, H. Peter Anvin wrote: >> On April 15, 2016 3:41:34 AM PDT, Cole Robinson >wrote: >> >Libvirt currently rejects using host /dev/urandom as an input

Re: [Qemu-devel] [PATCH] migration: remove useless code

2016-04-18 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > page_buffer is set twice repeatedly, remove the previous set. > > Signed-off-by: Liang Li > --- > migration/ram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 3f05738..31d40f4

Re: [Qemu-devel] [PATCH for-2.7 v2 00/17] block: Lock images when opening

2016-04-18 Thread Daniel P. Berrange
On Fri, Apr 15, 2016 at 11:27:50AM +0800, Fam Zheng wrote: > v2: Lock byte 1 in the image itself, no lock file. [Daniel] > Fix migration (image are not locked in bdrv_open_common if > BDRV_O_INACTIVE). [Denis] > Simplify test case fixes because of the above. > Add lock for RBD. >

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> * Andrea Arcangeli (aarca...@redhat.com) wrote: > > On Fri, Apr 15, 2016 at 06:23:30PM +0300, Kirill A. Shutemov wrote: > > > The same here. Freshly booted machine with 64GiB ram. I've checked > > > /proc/vmstat: huge pages were allocated > > > > I tried the test in a loop and I can't reproduce

[Qemu-devel] [PATCH RFC 2/3] vfio: report group noiommu status

2016-04-18 Thread Michael S. Tsirkin
When using vfio, callers might want to know whether device is added to a regular group or an non-iommu group. Report this status from vfio_add_group_dev. Signed-off-by: Michael S. Tsirkin --- drivers/vfio/pci/vfio_pci.c | 2 +-

Re: [Qemu-devel] [PATCH] cadence_uart: bounds check write offset

2016-04-18 Thread Peter Maydell
CCing the maintainers for this device... On 18 April 2016 at 11:07, Michael S. Tsirkin wrote: > cadence_uart_init() initializes an I/O memory region of size 0x1000 > bytes. However in uart_write(), the 'offset' parameter (offset within > region) is divided by 4 and then used to

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Hubert Kario
On Friday 15 April 2016 17:51:36 H. Peter Anvin wrote: > On April 15, 2016 9:10:44 AM PDT, Hubert Kario wrote: > >On Friday 15 April 2016 09:47:51 Eric Blake wrote: > >> On 04/15/2016 04:41 AM, Cole Robinson wrote: > >> > Libvirt currently rejects using host /dev/urandom as an

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Hubert Kario
On Sunday 17 April 2016 17:27:05 H. Peter Anvin wrote: > On 04/16/16 01:31, Paolo Bonzini wrote: > > Right, but there's always the point about people that use > > heterogeneous hosts and cannot pass rdrand/rdseed to the guest. > > For these, we should add a QEMU driver that uses rdrand/rdseed,

[Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and the mailing list we seem to be in reasonable shape for the 2.6 release. I would ideally like the 2.6rc3 tarball which we will make later this week to be the final one before full release. This is therefore the last call for any

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Daniel P. Berrange
On Mon, Apr 18, 2016 at 01:07:40PM +0200, Hubert Kario wrote: > On Monday 18 April 2016 02:46:19 H. Peter Anvin wrote: > > Another thing that really needs to be addressed, but is a separate > > issue: invalidating and reseeding the entropy pool after a snapshot > > event. > > definitely agreed >

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Samuel Thibault
Hello, Peter wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full release. > > This is

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-18 Thread Sergey Fedorov
On 07/04/16 19:18, Cornelia Huck wrote: > On Thu, 7 Apr 2016 18:53:44 +0300 > Sergey Fedorov wrote: (snip) >> --- >> pc-bios/s390-ccw/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pc-bios/s390-ccw/Makefile

[Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests

2016-04-18 Thread Daniel P. Berrange
This adds support for testing the LUKS driver with the block I/O test framework. cd tests/qemu-io-tests ./check -luks A handful of test cases are modified to work with luks - 004 - whitelist luks format - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops - 048 - use

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Mark Cave-Ayland
On 18/04/16 12:22, Peter Maydell wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full

[Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

2016-04-18 Thread Samuel Thibault
From: Wei Liu pv-grub booting got broken with recent qemu-xen, due to ac0487e1d2ae811cd4d035741a109a4ecfb013f1 ('xenfb.c: avoid expensive loops when prod <= out_cons') prod - out_cons can actually be XENFB_OUT_RING_LEN when the ring is exactly full, this is a normal

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 12:22, Peter Maydell wrote: > This is therefore the last call for any bugs that need to be fixed > for 2.6 or patches that must go in. If you have anything you think > should go into 2.6 please either add it to the "still unfixed in > master" part of

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > > > > > > > > > The same here. Freshly booted machine with 64GiB ram. I've > > > > > >

[Qemu-devel] [PATCH v8 1/3] block: add support for --image-opts in block I/O tests

2016-04-18 Thread Daniel P. Berrange
Currently all block tests use the traditional syntax for images just specifying a filename. To support the LUKS driver without resorting to JSON, the tests need to be able to use the new --image-opts argument to qemu-img and qemu-io. This introduces a new env variable IMGOPTSSYNTAX. If this is

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 07:58:37AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 14:47 +0300, Michael S. Tsirkin wrote: > > This adds a flag to enable/disable bypassing the IOMMU by > > virtio devices. > > I'm still deeply unhappy with having this kind of hack in the virtio > code at all,

[Qemu-devel] [PATCH v8 2/3] block: add support for encryption secrets in block I/O tests

2016-04-18 Thread Daniel P. Berrange
The LUKS block driver tests will require the ability to specify encryption secrets with block devices. This requires using the --object argument to qemu-img/qemu-io to create a 'secret' object. When the IMGKEYSECRET env variable is set, it provides the password to be associated with a secret

[Qemu-devel] [PATCH v8 0/3] Tests for LUKS driver

2016-04-18 Thread Daniel P. Berrange
This series contains the 3 test suite patches that had to be dropped from the v6 series during merge with the block tree: v6: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04935.html v7: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg06687.html Changed in v8: - Add

Re: [Qemu-devel] [PATCH 01/50] scripts: add script to build QEMU and analyze inclusions

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > scripts/analyze-inclusions | 89 > ++ > 1 file changed, 89 insertions(+) > create mode 100644 scripts/analyze-inclusions > > diff --git

Re: [Qemu-devel] [PATCH 13/50] target-ppc: do not use target_ulong in cpu-qom.h

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > Bring the PowerPCCPUClass handle_mmu_fault method type into line with > the one in CPUState. You mean CPUClass, don't you? > Using vaddr also makes the cpu-qom.h file target independent. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > pio_addr_t is almost unused, because these days I/O ports are simply > accessed through the address space. cpu_{in,out}[bwl] themselves are > almost unused; monitor.c and xen-hvm.c could use address_space_read/write > directly, since they have an

Re: [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > (CCs only on cover letter due to huge series). > > I am sending this now because of vacation coming soon (yay!). > This series removes usage of NEED_CPU_H from several central > include files in QEMU, most notably hw/hw.h and qemu-common.h. >

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread David Gibson
On Mon, Apr 18, 2016 at 01:23:06PM +0100, Mark Cave-Ayland wrote: > On 18/04/16 12:22, Peter Maydell wrote: > > > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > > the mailing list we seem to be in reasonable shape for the 2.6 release. > > I would ideally like the 2.6rc3

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 10:03:52AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 16:12 +0300, Michael S. Tsirkin wrote: > > I'm not sure I understand the issue.  The public API is not about how > > the driver works.  It doesn't say "don't use DMA API" anywhere, does it? > > It's about

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > 'tb_invalidated_flag' was meant to catch two events: > * some TB has been invalidated by tb_phys_invalidate(); > * the whole translation buffer has been flushed by tb_flush(). > > Then it was

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Stefan Weil
Am 18.04.2016 um 15:02 schrieb Peter Maydell: > On 18 April 2016 at 12:22, Peter Maydell wrote: >> This is therefore the last call for any bugs that need to be fixed >> for 2.6 or patches that must go in. If you have anything you think >> should go into 2.6 please either

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 14:44, Stefan Weil wrote: > Am 18.04.2016 um 15:02 schrieb Peter Maydell: >> Hi Stefan -- I see you added "update the translation po/ files" >> to the list. Can you remind me how to do this? I think it's >> just "make -C po update", which seems to update the

Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > gdbstub-xml.c defines a bunch of arrays of strings; there is no > need to include anything. > > Signed-off-by: Paolo Bonzini > --- > scripts/feature_to_c.sh | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 16:12 +0300, Michael S. Tsirkin wrote: > I'm not sure I understand the issue.  The public API is not about how > the driver works.  It doesn't say "don't use DMA API" anywhere, does it? > It's about telling device whether to obey the IOMMU and > about discovering whether a

Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 14:54, Markus Armbruster wrote: > Paolo Bonzini writes: > >> gdbstub-xml.c defines a bunch of arrays of strings; there is no >> need to include anything. > We might want to include osdep.h anyway, just to avoid adding an > exception to

Re: [Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

2016-04-18 Thread Samuel Thibault
Wei Liu, on Mon 18 Apr 2016 15:40:15 +0100, wrote: > This patch is already queued by Stefano. Ah, sorry, I missed it. Samuel

[Qemu-devel] Persistent Main Memory in QEmu

2016-04-18 Thread Li, Tianyou
Hi, Currently we are trying to implement below functionalities in QEmu: main memory in guest can be logically viewed as persistent and its content can be survived through reboot or shutdown/powerup. I have looked into the QEmu memory management code include memory.c, exec.c and other related

  1   2   >