Re: [Qemu-devel] [PATCH qemu v16 02/19] memory: Call region_del() callbacks on memory listener unregistering

2016-05-05 Thread Alex Williamson
On Wed, 4 May 2016 16:52:14 +1000 Alexey Kardashevskiy wrote: > When a new memory listener is registered, listener_add_address_space() > is called and which in turn calls region_add() callbacks of memory regions. > However when unregistering the memory listener, it is just

Re: [Qemu-devel] [PATCH qemu v16 01/19] vfio: Delay DMA address space listener release

2016-05-05 Thread Alex Williamson
On Wed, 4 May 2016 16:52:13 +1000 Alexey Kardashevskiy wrote: > This postpones VFIO container deinitialization to let region_del() > callbacks (called via vfio_listener_release) do proper clean up > while the group is still attached to the container. Any mappings within the

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-05 Thread Emilio G. Cota
On Wed, May 04, 2016 at 07:22:16 -1000, Richard Henderson wrote: > On 05/04/2016 05:36 AM, Emilio G. Cota wrote: > >BTW in the last couple of days I did some more work beyond v4: > > > >- Added a benchmark (not a correctness test) to measure parallel > > performance of QHT (recall that

Re: [Qemu-devel] TCP Segementation Offloading

2016-05-05 Thread Stefan Hajnoczi
On Sun, May 01, 2016 at 02:31:57PM +0200, Ingo Krabbe wrote: > Good Mayday Qemu Developers, > > today I tried to find a reference to a networking problem, that seems to be > of quite general nature: TCP Segmentation Offloading (TSO) in virtual > environments. > > When I setup TAP network

Re: [Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

2016-05-05 Thread Stefan Hajnoczi
On Thu, May 05, 2016 at 11:05:27AM +, Catalin Vasile wrote: > When the virtio-net and virtio-scsi drivers have done the probe() primitive > they set the DRIVER_OK flag. > > If the vhost kernel backend is used, the set_status() primitive in qemu will > be triggered with DRIVER_OK status and

Re: [Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-05-05 Thread Stefan Hajnoczi
On Thu, Mar 24, 2016 at 12:02:03AM +0530, Md Haris Iqbal wrote: > Signed-off-by: Md Haris Iqbal > --- > linux-user/qemu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Jeff Cody
On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > From: Vikhyat Umrao > > Date: Mon, 2 May 2016 21:47:31 +0530 > >

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-05-05 Thread Alex Williamson
[cc +Intel,NVIDIA] On Thu, 5 May 2016 18:29:08 +0800 Dong Jia wrote: > On Wed, 4 May 2016 13:26:53 -0600 > Alex Williamson wrote: > > > On Wed, 4 May 2016 17:26:29 +0800 > > Dong Jia wrote: > > > > > On

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Stefan Hajnoczi
On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > From: Vikhyat Umrao > Date: Mon, 2 May 2016 21:47:31 +0530 > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() > > Ceph RBD

[Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

2016-05-05 Thread Ladi Prosek
There is a discrepancy between dataplane and no-dataplane virtio behavior with respect to the ISR status register and MSI-X capability. Without dataplane the Queue interrupt ISR status bit is set regardless of how the notification is delivered to the guest. With dataplane the Queue interrupt ISR

Re: [Qemu-devel] [PATCH v6 08/26] intel_iommu: provide helper function vtd_get_iommu

2016-05-05 Thread David Kiarie
On Thu, May 5, 2016 at 6:25 AM, Peter Xu wrote: > Moves acpi_get_iommu() under VT-d to make it a public function. > > Signed-off-by: Peter Xu > --- > hw/i386/acpi-build.c | 7 +-- > hw/i386/intel_iommu.c | 13 + >

[Qemu-devel] [PATCH 5/5] libqos: add qvirtio_wait_queue_buf()

2016-05-05 Thread Stefan Hajnoczi
Like qvirtqueue_get_buf() but blocking and checks for the expected buffer token. New virtio device tests are expected to use this function as a convenient way to pop buffers off the used ring. Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio.c | 28

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, May 05, 2016 12:57 AM > > On Wed, 4 May 2016 02:45:59 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson > > > Sent: Wednesday, May 04, 2016 6:44 AM > > > > > > > diff --git

Re: [Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

2016-05-05 Thread Bharata B Rao
On Tue, Apr 05, 2016 at 06:47:16PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2016-03-31 03:39:19) > > Set up device tree entries for the hotplugged CPU core and use the > > exising RTAS event logging infrastructure to send CPU hotplug notification > > to the guest. > > > >

[Qemu-devel] [PATCH 4/5] libqos: add qvirtqueue_get_buf()

2016-05-05 Thread Stefan Hajnoczi
Add a function to pop buffers off the used ring. Up until now the virtio device tests were so simple that they could probe the buffer memory to detect completed requests. That means they never actually reclaimed buffers from the used ring. The qvirtqueue_get_buf() function will allow more

[Qemu-devel] [PATCH 3/5] libqos: add virtio buffer token

2016-05-05 Thread Stefan Hajnoczi
Allow the qvirtqueue_add_buf() caller to associate a void *token with the buffer. The next patch adds a qvirtqueue_get_buf() function which returns the token of the buffer that was popped from the virtqueue. This allows users to identify which buffer was popped. Existing virtio device tests are

[Qemu-devel] [PATCH 1/5] libqos: fix virtio descriptor free list

2016-05-05 Thread Stefan Hajnoczi
Although qvring_init() chains together all descriptors for the free list, free_head is used as a counter instead of as a free list head. The test cases appear to work because they are so trivial that the free_head counter never exceeds the vring size. If they added more descriptors free_head

[Qemu-devel] [PATCH 0/5] libqos: add ability to pop buffers from virtqueue

2016-05-05 Thread Stefan Hajnoczi
The libqos virtio framework currently offers no way to pop buffers off the virtqueue. Existing test cases are trivial and therefore get away without reclaiming buffers. More extensive tests really do need to pop buffers and do the housekeeping associated with the 'used' ring. This patch series

[Qemu-devel] [PATCH 2/5] libqos: fix virtio num_free descriptor counter

2016-05-05 Thread Stefan Hajnoczi
The num_free variable is only ever decremented and never used for anything. Although it is currently useless and could be removed, it will become important once a function is added to pop buffers from a virtqueue. This patch adds the missing num_free initialization and adds assertions to check

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-05 Thread Tian, Kevin
> From: Song, Jike > Sent: Thursday, May 05, 2016 2:56 PM > > > > The only reason I can come up with for why we'd want to integrate an > > api-only domain into the existing type1 code would be to avoid page > > accounting issues where we count locked pages once for a normal > > assigned device and

Re: [Qemu-devel] [RFC PATCH v2.1 09/12] spapr: convert boot CPUs into CPU core devices

2016-05-05 Thread Bharata B Rao
On Fri, Apr 08, 2016 at 06:35:19PM -0500, Michael Roth wrote: > Quoting Bharata B Rao (2016-03-31 03:39:18) > > Introduce sPAPRMachineClass.dr_cpu_enabled to indicate support for > > CPU core hotplug. Initialize boot time CPUs as core deivces and prevent > > topologies that result in partially

Re: [Qemu-devel] [PATCH v2 2/2] xen: add pvUSB backend

2016-05-05 Thread Anthony PERARD
On Wed, May 04, 2016 at 10:25:03AM +0200, Juergen Gross wrote: > On 03/05/16 17:06, Anthony PERARD wrote: > > On Thu, Mar 10, 2016 at 04:19:30PM +0100, Juergen Gross wrote: > >> +static void usbback_bh(void *opaque) > >> +{ > >> +struct usbback_info *usbif; > >> +struct usbif_urb_back_ring

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Wednesday, May 04, 2016 9:32 PM > > Thanks Alex. > > >> +config VGPU_VFIO > >> +tristate > >> +depends on VGPU > >> +default n > >> + > > > > This is a little bit convoluted, it seems like everything added in this > > patch is vfio agnostic, it

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-05 Thread Tian, Kevin
> From: Alex Williamson > Sent: Thursday, May 05, 2016 1:06 AM > > > > + > > > > +static int vgpu_dev_mmio_fault(struct vm_area_struct *vma, struct > > > > vm_fault > *vmf) > > > > +{ > > > > + int ret = 0; > > > > + struct vfio_vgpu_device *vdev = vma->vm_private_data; > > > > +

Re: [Qemu-devel] [PATCH v6 22/26] x86-iommu: replace existing VT-d hooks into X86 ones

2016-05-05 Thread Jan Kiszka
On 2016-05-05 05:25, Peter Xu wrote: > Previously, there are lots of VT-d hooks in common codes (like q35, > ioapic, etc.). A better way is to avoid using VT-d interfaces. Also, we > can start to abstract some common functions between Intel and future AMD > IOMMU device. Just don't introduce the

Re: [Qemu-devel] Migration ToDo list (a.k.a. Rant)

2016-05-05 Thread Li, Liang Z
> From: Qemu-devel [mailto:qemu-devel- > bounces+liang.z.li=intel@nongnu.org] On Behalf Of Juan Quintela > Sent: Wednesday, May 04, 2016 7:20 PM > To: QEMU Developer > Subject: [Qemu-devel] Migration ToDo list (a.k.a. Rant) > > > Hi > > I am lots of times asked about what is the ToDo list

[Qemu-devel] [Bug 1529449] Re: serial is required for -device nvme

2016-05-05 Thread Tom Yan
** Attachment added: "1.png" https://bugs.launchpad.net/qemu/+bug/1529449/+attachment/4656269/+files/1.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529449 Title: serial is required for

[Qemu-devel] [Bug 1529449] Re: serial is required for -device nvme

2016-05-05 Thread Tom Yan
** Attachment added: "0.png" https://bugs.launchpad.net/qemu/+bug/1529449/+attachment/4656268/+files/0.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529449 Title: serial is required for

[Qemu-devel] [Bug 1529449] Re: serial is required for -device nvme

2016-05-05 Thread Tom Yan
Since both "drive=" and "serial=" expects an arbitrary string (while the value for "drive=" must be unique since it's the "id=" of a "-drive"), why not use the same string from "drive=" as the value of "serial=" when it's not specified explicitly? Apparently "-device scsi-hd" has already been

[Qemu-devel] [PATCH v2 7/9] migration: refine the compression code

2016-05-05 Thread Liang Li
The current code for multi-thread compression is not clear, especially in the aspect of using lock. Refine the code to make it clear. Signed-off-by: Liang Li --- migration/ram.c | 84 +++-- 1 file changed, 40

[Qemu-devel] [PATCH v2 3/9] migration: remove useless code

2016-05-05 Thread Liang Li
page_buffer is set twice repeatedly, remove the previous set. Signed-off-by: Liang Li Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-05 Thread Kirti Wankhede
On 5/4/2016 4:13 AM, Alex Williamson wrote: > On Tue, 3 May 2016 00:10:41 +0530 > Kirti Wankhede wrote: > [..] >> + if (domain->vfio_iommu_api_only) >> + mm = domain->vmm_mm; >> + else >> + mm = current->mm; >> + >> + if (!mm) >>

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-05 Thread Jike Song
On 05/04/2016 06:43 AM, Alex Williamson wrote: > On Tue, 3 May 2016 00:10:41 +0530 > Kirti Wankhede wrote: >> + >> +/* >> + * Pin a set of guest PFNs and return their associated host PFNs for vGPU. >> + * @vaddr [in]: array of guest PFNs >> + * @npage [in]: count of array

[Qemu-devel] [PATCH v2 6/9] migration: protect the quit flag by lock

2016-05-05 Thread Liang Li
quit_comp_thread and quit_decomp_thread are accessed by several thread, it's better to protect them with locks. We use a per thread flag to replace the global one, and the new flag is protected by a lock. Signed-off-by: Liang Li --- migration/ram.c | 32

[Qemu-devel] [PATCH v2 4/9] qemu-file: Fix qemu_put_compression_data flaw

2016-05-05 Thread Liang Li
Current qemu_put_compression_data can only work with no writable QEMUFile, and can't work with the writable QEMUFile. But it does not provide any measure to prevent users from using it with a writable QEMUFile. We should fix this flaw to make it works with writable QEMUFile. Signed-off-by: Liang

[Qemu-devel] [PATCH v2 0/9] live migration bug fix and refine

2016-05-05 Thread Liang Li
This patch set fixed a bug which will block live migration and another potential issue when using multi-thread (de)compression. The last patches try to refine the code and make the using of lock more clear. Some of the code snippets are from Juan's multiple-fd patches, with very small change.

[Qemu-devel] [PATCH v2 9/9] migration: code clean up

2016-05-05 Thread Liang Li
Use 'QemuMutex comp_done_lock' and 'QemuCond comp_done_cond' instead of 'QemuMutex *comp_done_lock' and 'QemuCond comp_done_cond'. To keep consistent with 'QemuMutex decomp_done_lock' and 'QemuCond comp_done_cond'. Signed-off-by: Liang Li --- migration/ram.c | 36

[Qemu-devel] [PATCH v2 5/9] migration: refine ram_save_compressed_page

2016-05-05 Thread Liang Li
Use qemu_put_compression_data to do the compression directly instead of using do_compress_ram_page, avoid some data copy. very small improvement, at the same time, add code to check if the compression is successful. Signed-off-by: Liang Li --- migration/ram.c | 27

Re: [Qemu-devel] Migration ToDo list (a.k.a. Rant)

2016-05-05 Thread Hailiang Zhang
Hi Juan, On 2016/5/4 19:20, Juan Quintela wrote: Hi I am lots of times asked about what is the ToDo list for migration, that was on my head, and random notes over my desk, so, trying some organization (Yes, I would put this in the wiki). - migration thread on reception would make trivial

Re: [Qemu-devel] [PATCH v18 0/8] Block replication for continuous checkpoints

2016-05-05 Thread Hailiang Zhang
ping^2 ... Sorry for the noise, but this series is the prerequisite of COLO and it got no feedback for almost three weeks ... On 2016/4/15 16:10, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the

[Qemu-devel] [PATCH v2 2/9] migration: Fix a potential issue

2016-05-05 Thread Liang Li
At the end of live migration and before vm_start() on the destination side, we should make sure all the decompression tasks are finished, if this can not be guaranteed, the VM may get the incorrect memory data, or the updated memory may be overwritten by the decompression thread. Add the code to

[Qemu-devel] [PATCH v2 1/9] migration: Fix multi-thread compression bug

2016-05-05 Thread Liang Li
Recently, a bug related to multiple thread compression feature for live migration is reported. The destination side will be blocked during live migration if there are heavy workload in host and memory intensive workload in guest, this is most likely to happen when there is one decompression

[Qemu-devel] [PATCH v2 8/9] migration: refine the decompression code

2016-05-05 Thread Liang Li
The current code for multi-thread decompression is not clear, especially in the aspect of using lock. Refine the code to make it clear. Signed-off-by: Liang Li --- migration/ram.c | 50 +- 1 file changed, 25 insertions(+), 25

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 11:28, xiaoqiang zhao wrote: > This patch set QOM'ify files under hw/intc directory. See each commit > message for details. > > Changes in v1: > use error_setg instead of error_report in realize function How can you have changes in a v1? Was this supposed

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread xiaoqiang zhao
> 在 2016年5月5日,18:46,Peter Maydell 写道: > >> On 5 May 2016 at 11:41, 赵小强 wrote: >> At 2016-05-05 18:39:52, "Peter Maydell" wrote: On 5 May 2016 at 11:28, xiaoqiang zhao wrote: This patch set

Re: [Qemu-devel] [Qemu-arm] [PATCH RESEND 2/5] hw/display: QOM'ify jazz_led.c

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move graphic_console_init into realize stage > > Signed-off-by: xiaoqiang zhao > --- > hw/display/jazz_led.c | 18 +++--- > 1 file

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-05-05 Thread Dong Jia
On Wed, 4 May 2016 13:26:53 -0600 Alex Williamson wrote: > On Wed, 4 May 2016 17:26:29 +0800 > Dong Jia wrote: > > > On Fri, 29 Apr 2016 11:17:35 -0600 > > Alex Williamson wrote: > > > > Dear Alex: > > > >

[Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread xiaoqiang zhao
This patch set QOM'ify files under hw/intc directory. See each commit message for details. Changes in v1: use error_setg instead of error_report in realize function xiaoqiang zhao (9): hw/intc: QOM'ify etraxfs_pic.c hw/intc: QOM'ify exynos4210_combiner.c hw/intc: QOM'ify

[Qemu-devel] [PATCH v1 9/9] hw/intc: QOM'ify omap_intc.c

2016-05-05 Thread xiaoqiang zhao
* Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/omap_intc.c | 64 +++-- 1 file changed,

[Qemu-devel] [PATCH v1 6/9] hw/intc: QOM'ify pl190.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/pl190.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/intc/pl190.c b/hw/intc/pl190.c index 5ecbc4a..1e50baf 100644 --- a/hw/intc/pl190.c

Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move tmu2_glx_init into realize stage > > Signed-off-by: xiaoqiang zhao Reviewed-by: Peter Maydell > +static void

Re: [Qemu-devel] [Qemu-arm] [PATCH RESEND 4/5] hw/display: QOM'ify milkymist-vgafb.c

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move graphic_console_init into realize stage > > Signed-off-by: xiaoqiang zhao > --- Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

2016-05-05 Thread 赵小强
At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >This patch set trys to QOM'ify hw/char files, see commit messages >for more details > >Changes in v2: >* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is suggested by > Cornelia Huck

[Qemu-devel] [PATCH v1 2/9] hw/intc: QOM'ify exynos4210_combiner.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/exynos4210_combiner.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, May 05, 2016 6:45 PM > > > On 5/5/2016 2:36 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede > >> Sent: Wednesday, May 04, 2016 9:32 PM > >> > >> Thanks Alex. > >> > >> >> +config VGPU_VFIO > >> >> +tristate > >> >> +

[Qemu-devel] [PATCH v1 1/9] hw/intc: QOM'ify etraxfs_pic.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/etraxfs_pic.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/intc/etraxfs_pic.c b/hw/intc/etraxfs_pic.c index 48f9477..64a6f4b 100644 ---

[Qemu-devel] [PATCH v1 5/9] hw/intc: QOM'ify lm32_pic.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/lm32_pic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/intc/lm32_pic.c b/hw/intc/lm32_pic.c index edc08f1..3dad01c 100644 ---

[Qemu-devel] [PATCH v1 7/9] hw/intc: QOM'ify slavio_intctl.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/slavio_intctl.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index c9486ed..e82e893

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 11:41, 赵小强 wrote: > At 2016-05-05 18:39:52, "Peter Maydell" wrote: >>On 5 May 2016 at 11:28, xiaoqiang zhao wrote: >>> This patch set QOM'ify files under hw/intc directory. See each commit >>> message for

[Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

2016-05-05 Thread Catalin Vasile
When the virtio-net and virtio-scsi drivers have done the probe() primitive they set the DRIVER_OK flag. If the vhost kernel backend is used, the set_status() primitive in qemu will be triggered with DRIVER_OK status and it will trigger vhost_XXX_start(). How does the net and scsi solutions

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

2016-05-05 Thread Peter Maydell
On 5 May 2016 at 11:38, 赵小强 wrote: > At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >>This patch set trys to QOM'ify hw/char files, see commit messages >>for more details >> >>Changes in v2: >>* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is

[Qemu-devel] [PATCH v1 8/9] hw/intc: QOM'ify grlib_irqmp.c

2016-05-05 Thread xiaoqiang zhao
* Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function Signed-off-by: xiaoqiang zhao --- hw/intc/grlib_irqmp.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v1 3/9] hw/intc: QOM'ify exynos4210_gic.c

2016-05-05 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Split the exynos4210_irq_gate_init into an instance_init and a DeviceClass::realize function Signed-off-by: xiaoqiang zhao --- hw/intc/exynos4210_gic.c | 39 --- 1 file changed,

[Qemu-devel] [PATCH v1 4/9] hw/intc: QOM'ify imx_avic.c

2016-05-05 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/imx_avic.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index 7027655..d21cb97 100644 ---

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread 赵小强
At 2016-05-05 18:39:52, "Peter Maydell" wrote: >On 5 May 2016 at 11:28, xiaoqiang zhao wrote: >> This patch set QOM'ify files under hw/intc directory. See each commit >> message for details. >> >> Changes in v1: >> use error_setg instead

Re: [Qemu-devel] [RESEND PATCH v2 0/4] QOM'ify hw/audio files

2016-05-05 Thread 赵小强
At 2016-03-17 17:06:12, "xiaoqiang zhao" wrote: >This patch set QOM'ify some files under hw/audio directory. >See each patch's commit message for details. > >Changes in v2: >Move AUD_open_in/out function into device realize stage > >Sorry for the misoperation before,

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems like everything added in this > patch is

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 5:37 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Thursday, May 05, 2016 6:45 PM On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +

Re: [Qemu-devel] [PATCH v2 1/3] net: improve UDP/TCP checksum computation.

2016-05-05 Thread Peter Maydell
On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > This patch adds: > * based on Eth, UDP, TCP struct present in eth.h instead of hardcoded > indexes. > * based on various macros present in eth.h. > * allow to account for optional VLAN header. This is doing

Re: [Qemu-devel] [PATCH v1 1/9] hw/intc: QOM'ify etraxfs_pic.c

2016-05-05 Thread Edgar E. Iglesias
On Thu, May 05, 2016 at 06:28:48PM +0800, xiaoqiang zhao wrote: > Drop the old SysBus init function and use instance_init > > Signed-off-by: xiaoqiang zhao Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias >

[Qemu-devel] [PATCH v1 1/6] scripts: add __init__.py file to scripts/qmp/

2016-05-05 Thread Daniel P. Berrange
When searching for modules to load, python will ignore any sub-directory which does not contain __init__.py. This means that both scripts and scripts/qmp/ have to be explicitly added to the python path. By adding a __init__.py file to scripts/qmp, we only need add scripts/ to the python path and

[Qemu-devel] [PATCH v1 3/6] scripts: refactor the VM class in iotests for reuse

2016-05-05 Thread Daniel P. Berrange
The iotests module has a python class for controlling QEMU processes. Pull the generic functionality out of this file and create a scripts/qemu.py module containing a QEMUMachine class. Put the QTest integration support into a subclass QEMUQtestMachine. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

2016-05-05 Thread Daniel P. Berrange
This series of patches provides a framework for testing migration performance characteristics. The motivating factor for this is planning that is underway in OpenStack wrt making use of QEMU migration features such as compression, auto-converge and post-copy. The primary aim for OpenStack is to

[Qemu-devel] [PATCH v1 5/6] scripts: ensure monitor socket has SO_REUSEADDR set

2016-05-05 Thread Daniel P. Berrange
If tests use a TCP based monitor socket, the connection will go into a TIMED_WAIT state when the test exits. This will randomly prevent the test from being re-run without a certain time period. Set the SO_REUSEADDR flag on the socket to ensure we can immediately re-run the tests ---

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

2016-05-05 Thread Sergey Fedorov
On 05/04/16 18:32, Alex Bennée wrote: > diff --git a/exec.c b/exec.c > index f46e596..17f390e 100644 > --- a/exec.c > +++ b/exec.c > @@ -826,6 +826,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int > flags, > { > CPUBreakpoint *bp; > > +/* TODO: locking (RCU?) */ > bp =

Re: [Qemu-devel] [V9 0/4] AMD IOMMU

2016-05-05 Thread David Kiarie
On Wed, May 4, 2016 at 2:05 PM, Valentine Sinitsyn wrote: > On 04.05.2016 16:02, David Kiarie wrote: >> >> >> >> On 04/05/16 13:58, Valentine Sinitsyn wrote: >>> >>> On 04.05.2016 15:51, David Kiarie wrote: On Wed, May 4, 2016 at 10:39 AM, Valentine

Re: [Qemu-devel] [PATCH v2 2/3] Add ENET/Gbps Ethernet support to FEC device

2016-05-05 Thread Peter Maydell
On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > The ENET device (present in i.MX6) is "derived" from FEC and backward > compatible with it. > > This patch add the necessary support of the added feature in the ENET > device to allow Linux to use it (on supported

[Qemu-devel] [PATCH v1 2/6] scripts: add a 'debug' parameter to QEMUMonitorProtocol

2016-05-05 Thread Daniel P. Berrange
Add a 'debug' parameter to the QEMUMonitorProtocol class which will cause it to print out all JSON strings on sys.stderr Signed-off-by: Daniel P. Berrange --- scripts/qmp/qmp.py | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v1 4/6] scripts: set timeout when waiting for qemu monitor connection

2016-05-05 Thread Daniel P. Berrange
If QEMU fails to launch for some reason, the QEMUMonitorProtocol class accept() method will wait forever in a socket accept call. Set a timeout of 15 seconds so that we fail more gracefully instead of hanging the test script forever Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH v1 6/6] tests: introduce a framework for testing migration performance

2016-05-05 Thread Daniel P. Berrange
This introduces a moderately general purpose framework for testing performance of migration. The initial guest workload is provided by the included 'stress' program, which is configured to spawn one thread per guest CPU and run a maximally memory intensive workload. It will loop over GB of

Re: [Qemu-devel] [PATCH v2 1/4] adb-keys.h - initial commit

2016-05-05 Thread Peter Maydell
On 24 March 2016 at 14:03, Programmingkid wrote: > Add the adb-keys.h file. It maps ADB transition key codes with values. > > Signed-off-by: John Arbuckle > --- > *v2 changes: > Changed order of this patch. > > include/hw/input/adb-keys.h |

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

2016-05-05 Thread Michael S. Tsirkin
On Thu, May 05, 2016 at 11:13:37AM +0200, Ladi Prosek wrote: > There is a discrepancy between dataplane and no-dataplane virtio > behavior with respect to the ISR status register and MSI-X > capability. > > Without dataplane the Queue interrupt ISR status bit is set > regardless of how the

Re: [Qemu-devel] [PATCH v2 3/3] Add ENET device to i.MX6 SOC.

2016-05-05 Thread Peter Maydell
On 23 April 2016 at 11:58, Jean-Christophe Dubois wrote: > This adds the ENET device to the i.MX6 SOC. > > This was tested by booting Linux on an Qemu i.MX6 instance and accessing > the internet from the linux guest. > > Signed-off-by: Jean-Christophe Dubois

Re: [Qemu-devel] [PATCH v7 0/6] Add i.MX6 (Single/Dual/Quad) support

2016-05-05 Thread Peter Maydell
On 2 April 2016 at 15:29, Jean-Christophe Dubois wrote: > This patch series adds support for the Freescale i.MX6 processor. > > For now we only support the following devices: > * up to 4 Cortex A9 cores > * A9 MPCORE (SCU, GIC, TWD) > * 5 i.MX UARTs > * 2 EPIT timers > * 1

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

2016-05-05 Thread xiaoqiang zhao
> 在 2016年5月5日,20:51,Peter Maydell 写道: > >> On 5 May 2016 at 11:38, 赵小强 wrote: >> At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >>> This patch set trys to QOM'ify hw/char files, see commit messages >>> for more details >>>

Re: [Qemu-devel] [PATCH v8 0/5] ARM: Add NUMA support for machine virt

2016-05-05 Thread Peter Maydell
On 26 April 2016 at 12:21, Andrew Jones wrote: > On Tue, Apr 26, 2016 at 06:40:24PM +0800, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Add NUMA support for machine virt. Tested successfully running a guest >> Linux kernel with the following patch

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

2016-05-05 Thread Sergey Fedorov
On 05/05/16 18:25, Sergey Fedorov wrote: > On 05/05/16 18:03, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> On 05/04/16 18:32, Alex Bennée wrote: diff --git a/exec.c b/exec.c index f46e596..17f390e 100644 --- a/exec.c +++ b/exec.c @@ -826,6

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer

2016-05-05 Thread Chen Gang
On 5/5/16 00:05, Peter Maydell wrote: > On 29 March 2016 at 15:13, wrote: >> From: Chen Gang >> >> The return address is in target space, so the restorer address needs to >> be target space, too. >> >> Signed-off-by: Chen Gang

[Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup()

2016-05-05 Thread Stefan Hajnoczi
qvirtqueue_setup() allocates the vring and virtqueue state. So far there has been no function to free it. Callers have been using guest_free() for the vring but forgot to free the QVirtQueue state. This patch solves the memory leak by introducing qvirtqueue_cleanup(). Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v3 7/7] target-arm: A64: Create Instruction Syndromes for Data Aborts

2016-05-05 Thread Edgar E. Iglesias
On Wed, May 04, 2016 at 06:38:49PM +0100, Peter Maydell wrote: > On 29 April 2016 at 13:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add support for generating the instruction syndrome for Data Aborts. > > These syndromes

Re: [Qemu-devel] [RFC PATCH] virtio: set ISR status when delivering queue MSI

2016-05-05 Thread Michael S. Tsirkin
On Thu, May 05, 2016 at 05:27:03PM +0200, Ladi Prosek wrote: > On Thu, May 5, 2016 at 5:20 PM, Michael S. Tsirkin wrote: > > On Thu, May 05, 2016 at 05:15:01PM +0200, Ladi Prosek wrote: > >> On Thu, May 5, 2016 at 5:02 PM, Michael S. Tsirkin wrote: > >> > On

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-05 Thread Michael S. Tsirkin
On Wed, May 04, 2016 at 08:44:37PM -0700, Yuanhan Liu wrote: > Hello, > > On Wed, May 04, 2016 at 10:13:49PM +0300, Michael S. Tsirkin wrote: > > How do you avoid it? > > > > > > Management is required to make this robust, auto-reconnect > > > > is handy for people bypassing management. > > > >

Re: [Qemu-devel] [PATCH 1/2] migration: Move qjson.[ch] to migration/

2016-05-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Type QJSON lets you build JSON text. Its interface mirrors (a subset > of) abstract JSON syntax. > > QAPI output visitors also produce JSON text. They assert their > preconditions and invariants, and therefore abort on incorrect use. > >

Re: [Qemu-devel] [RFC PATCH v3 2/3] VFIO driver for vGPU device

2016-05-05 Thread Neo Jia
On Thu, May 05, 2016 at 09:24:26AM +, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Thursday, May 05, 2016 1:06 AM > > > > > + > > > > > +static int vgpu_dev_mmio_fault(struct vm_area_struct *vma, struct > > > > > vm_fault > > *vmf) > > > > > +{ > > > > > + int ret = 0; > > > > >

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-05-05 Thread Server Angels
** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not honor open file handles on unlinked files Status in

Re: [Qemu-devel] [PATCH RFC 0/8] basic vfio-ccw infrastructure

2016-05-05 Thread Neo Jia
On Thu, May 05, 2016 at 01:19:45PM -0600, Alex Williamson wrote: > [cc +Intel,NVIDIA] > > On Thu, 5 May 2016 18:29:08 +0800 > Dong Jia wrote: > > > On Wed, 4 May 2016 13:26:53 -0600 > > Alex Williamson wrote: > > > > > On Wed, 4 May

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-05-05 Thread Server Angels
I would appreciate this patch being committed as I *think* it's affecting a system i'm building now. I have a backup host with 2 VMs. For business reasons they need to be network isolated from each other and the host, so each is passed through a physical NIC. Each VM does need access to a

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

2016-05-05 Thread Li, Liang Z
> This series of patches provides a framework for testing migration > performance characteristics. The motivating factor for this is planning that > is > underway in OpenStack wrt making use of QEMU migration features such as > compression, auto-converge and post-copy. The primary aim for

Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

2016-05-05 Thread Fam Zheng
On Thu, 05/05 15:06, Jeff Cody wrote: > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > > From: Vikhyat Umrao > >

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

2016-05-05 Thread Chen Fan
On 04/26/2016 10:48 PM, Alex Williamson wrote: On Tue, 26 Apr 2016 11:39:02 +0800 Chen Fan wrote: On 04/14/2016 09:02 AM, Chen Fan wrote: On 04/12/2016 05:38 AM, Alex Williamson wrote: On Tue, 5 Apr 2016 19:42:02 +0800 Cao jin wrote:

  1   2   >