Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: > On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang Z wrote: >> > On Wed, Jul 06, 2016 at 12:49:06PM +, Li, Liang Z wrote: >> > > > > > > After live migration, 'guest-stats' can't get the expected >> > > > > > >

Re: [Qemu-devel] [PATCH] tcg: Merge GETPC and GETRA

On Tue, 2016-07-26 at 06:12 +0530, Richard Henderson wrote: > The return address argument to the softmmu template helpers was > confused.  In the legacy case, we wanted to indicate that there > is no return address, and so passed in NULL.  However, we then > immediately subtracted GETPC_ADJ from

Re: [Qemu-devel] [PATCH] vhost: check for vhost_ops before using.

Hi On Wed, Aug 3, 2016 at 9:25 AM Ilya Maximets wrote: > 'vhost_set_vring_enable()' tries to call function using pointer to > 'vhost_ops' which can be already zeroized in 'vhost_dev_cleanup()' > while vhost disconnection. > > Fix that by checking 'vhost_ops' before

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

On Thu, Jul 28, 2016 at 4:51 PM, Reda Sallahi wrote: > On 7/28/16, Stefan Hajnoczi wrote: >> On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: >>> -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, _abort); >>> +if (dd.flags

Re: [Qemu-devel] [RFC v5 7/7] hw/arm/virt-acpi-build: Add ITS description in ACPI MADT table

Hi Shannon, On 03/08/2016 02:56, Shannon Zhao wrote: > Hi Eric, > > On 2016/8/3 2:07, Eric Auger wrote: >> This patch exposes the GICv3 ITS to the ACPI guest. The ITS structure >> is added to the MADT table. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v5: new >> >>

[Qemu-devel] Trace Guest and Host

Hi everyone, I wanted to setup a ftrace based mechanism to understand flows within the guest and host simultaneously. Are there mechanisms available to get traces from guest and host and then collate them to get a merged trace which helps to understand exact flow of guest with host ? OR generate

Re: [Qemu-devel] [PATCH 2/2] gtk: Modularize GTK display

Hi, > +static void (*early_init_fn)(int opengl); > +static void (*init_fn)(DisplayState *ds, bool full_screen, bool > grab_on_hover); > + > +void gtk_register_early_init_fun(void *fn) > +{ > +assert(!early_init_fn); > +early_init_fn = fn; > +} > + > +void gtk_register_init_fun(void

Re: [Qemu-devel] [PATCH v5 13/13] cpu-exec: replace cpu->queued_work with GArray

Emilio G. Cota writes: > On Tue, Aug 02, 2016 at 18:27:44 +0100, Alex Bennée wrote: >> Under times of high memory stress the additional small mallocs by a >> linked list are source of potential memory fragmentation. As we have >> worked hard to avoid mallocs elsewhere when

[Qemu-devel] [PATCH] virtio-blk: rename virtio_device_info to virtio_blk_info

The old one is confusing with @virtio_device_info in virtio.c, so make it more appropriate. Signed-off-by: Changlong Xie --- hw/block/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c

Re: [Qemu-devel] [RFC v5 7/7] hw/arm/virt-acpi-build: Add ITS description in ACPI MADT table

Hi Shannon, On 03/08/2016 10:50, Shannon Zhao wrote: > > > On 2016/8/3 15:22, Auger Eric wrote: >> Hi Shannon, >> >> On 03/08/2016 02:56, Shannon Zhao wrote: Hi Eric, On 2016/8/3 2:07, Eric Auger wrote: >> This patch exposes the GICv3 ITS to the ACPI guest. The ITS structure

[Qemu-devel] [PATCH for-2.8] dmg: Move the driver to block-obj-y

dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module, so that its reference to libbz2, since 6b383c08c, doesn't add an extra library to the main executable. We are working on on-demand loading of block drivers which will be easier if all format drivers are always built-in (so

[Qemu-devel] [PATCH] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice

PCI hotplug for bridges was introduced only since 2.0 however acpi_set_bsel()->object_property_add_uint32_ptr(bus, ACPI_PCIHP_PROP_BSEL) didn't take in account that for legacy mode (1.7) when PCI hotplug for bridges is unavailable and ACPI_PCIHP_PROP_BSEL property the only bus "PCI.0' has been

Re: [Qemu-devel] [PATCH] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice

On 08/03/2016 11:04 AM, Igor Mammedov wrote: PCI hotplug for bridges was introduced only since 2.0 however acpi_set_bsel()->object_property_add_uint32_ptr(bus, ACPI_PCIHP_PROP_BSEL) didn't take in account that for legacy mode (1.7) when PCI hotplug for bridges is unavailable and

Re: [Qemu-devel] [PATCH] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice

On Wed, 3 Aug 2016 11:17:11 +0300 Marcel Apfelbaum wrote: > On 08/03/2016 11:04 AM, Igor Mammedov wrote: > > PCI hotplug for bridges was introduced only since 2.0 however > > acpi_set_bsel()->object_property_add_uint32_ptr(bus, ACPI_PCIHP_PROP_BSEL) > > didn't take in

Re: [Qemu-devel] [PATCH] Update ancient copyright string in QEMU -version output

On Thu, Jul 28, 2016 at 04:24:45PM +0100, Peter Maydell wrote: > Currently the -version command line argument prints a string ending > with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some > eight years out of date; abstract it out of the several places that > print the string and

Re: [Qemu-devel] [RFC PATCH 09/11] zynqmp_crf: add the clock mechanism

Le 29/07/2016 à 15:51, Peter Maydell a écrit : On 13 June 2016 at 17:27, wrote: From: KONRAD Frederic This adds the pll to the zynqmp_crf and the dp_video clock output. Signed-off-by: KONRAD Frederic ---

[Qemu-devel] [PATCH] ppc: Fix catching some segfaults in user mode

The usermode "translate" code generates an error code value that has the "is_write" bit set, which causes our switch/case to miss and display "Invalid segfault errno" and a spurrious second state dump. Fix it. Signed-off-by: Benjamin Herrenschmidt --- linux-user/main.c

[Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

Other archs don't do it, some programs catch signals just fine and those dumps just clutter the output. Keep the dumps for cases that aren't supposed to happen such as unknown codes. Signed-off-by: Benjamin Herrenschmidt --- linux-user/main.c | 14 -- 1

Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts

On 3 August 2016 at 04:15, Benjamin Herrenschmidt wrote: > The current constructs ends up cropping the host address to 32-bit > which crashes for me running 32-bit ppc programs on an x86_64. > > Signed-off-by: Benjamin Herrenschmidt > --- > >

Re: [Qemu-devel] [RFC v5 7/7] hw/arm/virt-acpi-build: Add ITS description in ACPI MADT table

On 2016/8/3 15:22, Auger Eric wrote: > Hi Shannon, > > On 03/08/2016 02:56, Shannon Zhao wrote: >> > Hi Eric, >> > >> > On 2016/8/3 2:07, Eric Auger wrote: >>> >> This patch exposes the GICv3 ITS to the ACPI guest. The ITS structure >>> >> is added to the MADT table. >>> >> >>> >>

Re: [Qemu-devel] [PATCH] ide: fix DMA register transitions

Am 03.08.2016 um 07:06 hat Stefan Weil geschrieben: > Am 03.08.2016 um 00:05 schrieb John Snow: > > ATA8-APT defines the state transitions for both a host controller and > > for the hardware device during the lifecycle of a DMA transfer, in > > section 9.7 "DMA command protocol." > > > > One of

[Qemu-devel] [QUESTION]stuck in SeaBIOS because of losing a SMI

Hi, all: Recently I use a shell script to continuously reset a vm to see what may happen. After one day, the vm is stuck. Looking from the following seabios log and kvm trace log, it seems like losing a SMI or SeaBIOS can not handle a SMI. This problem is reproducible on my machine (SeaBIOS 1.9.1,

Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts

On Wed, 2016-08-03 at 09:40 +0100, Peter Maydell wrote: > > index 6eb5fe8..0164535 100644 > > --- a/include/exec/cpu_ldst.h > > +++ b/include/exec/cpu_ldst.h > > @@ -49,7 +49,7 @@ > > > >  #if defined(CONFIG_USER_ONLY) > >  /* All direct uses of g2h and h2g need to go away for usermode softmmu. 

Re: [Qemu-devel] [RFC PATCH V10 3/7] Jhash: add linux kernel jhashtable in qemu

On 08/02/2016 02:40 PM, Jason Wang wrote: On 2016年07月26日 09:49, Zhang Chen wrote: Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian

Re: [Qemu-devel] [PATCH 1/5] target-ppc: add vector insert instructions

On 08/03/2016 07:07 AM, David Gibson wrote: On Mon, Aug 01, 2016 at 12:49:38PM +0530, Rajalakshmi Srinivasaraghavan wrote: The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd -

Re: [Qemu-devel] [PATCH 3/5] target-ppc: add vector count trailing zeros instructions

Rajalakshmi Srinivasaraghavan writes: > The following vector count trailing zeros instructions are > added from ISA 3.0. > > vctzb - Vector Count Trailing Zeros Byte > vctzh - Vector Count Trailing Zeros Halfword > vctzw - Vector Count Trailing Zeros Word > vctzd -

Re: [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

On 08/03/2016 02:23 AM, Andrew Jeffery wrote: > On Tue, 2016-08-02 at 19:15 +0200, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater > > Reviewed-by: Andrew Jeffery Thanks for the overall review Andrew, C. >> --- >> hw/arm/aspeed.c | 1 - >> 1

Re: [Qemu-devel] [Patch v1 24/29] qmp: add QMP interface "query-cpu-model-expansion"

> On Tue, Aug 02, 2016 at 05:04:05PM +0200, David Hildenbrand wrote: > [...] > > > > > > > +# model can be used by tooling without having to specify a > > > > +# compatibility machine - e.g. when displaying the "host" > > > > model. > > > > +# All static CPU models

Re: [Qemu-devel] [Patch v1 25/29] qmp: add QMP interface "query-cpu-model-comparison"

> > > > > > > I think this is "feature subset" on the one hand and "earlier generation" > > on the other hand - at least for s390x. But it boils down to runnability I > > think: (< and > are actually quite misleading) > > It sounds like we need to clarify what are the use cases and >

Re: [Qemu-devel] [RFC PATCH V10 2/7] colo-base: add colo-base to define and handle packet

On 08/02/2016 02:38 PM, Jason Wang wrote: On 2016年07月26日 09:49, Zhang Chen wrote: COLO-base used by colo-compare and filter-rewriter. s/used/is used/ OK~ this can share common data structure like:net packet, s/this/This/ and ':' looks unnecessary. OK~ and share other functions.

Re: [Qemu-devel] [PATCH v6 0/4] Dynamic module loading for block drivers

On Tue, 08/02 10:17, Colin Lord wrote: > It sounds like since this series removes dmg from the list of > modularized drivers, there is a libbz2 dependency that may get pulled in > from the dmg driver. I believe Fam was suggesting moving that part of > the dmg driver into its own module (although

Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts

On 3 August 2016 at 11:18, Benjamin Herrenschmidt wrote: > On Wed, 2016-08-03 at 19:50 +1000, Benjamin Herrenschmidt wrote: >> >> > I'm confused. Is this just swapping the order of the operands to >> > '+'? >> > I wouldn't expect that to make any difference because

[Qemu-devel] [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-delete-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device

[Qemu-devel] [PATCH v5 08/11] block: Accept node-name for drive-backup

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

On 3 August 2016 at 12:28, Benjamin Herrenschmidt wrote: > To the best of my understanding we only ever generate > 0x4000 and 0x4200 via ppc_cpu_handle_mmu_fault() > in user_only_helper.c unless there's another path to DSI > in user mode that I missed. > > That

Re: [Qemu-devel] [RFC v3 14/19] tcg: remove global exit_request

Sergey Fedorov writes: > On 03/06/16 23:40, Alex Bennée wrote: >> The only remaining use of the global exit_request flag is now to ensure >> we exit the run_loop when we first start to process pending work. This >> is just as easily done by setting the

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

On 3 August 2016 at 09:02, Benjamin Herrenschmidt wrote: > Other archs don't do it, some programs catch signals just fine > and those dumps just clutter the output. Keep the dumps for cases > that aren't supposed to happen such as unknown codes. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/2] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

On 3 August 2016 at 04:15, Benjamin Herrenschmidt wrote: > We use the wrong argument name for the g2h() macro ! > > Signed-off-by: Benjamin Herrenschmidt > --- > > Not sure who to CC for this... > > include/exec/cpu_ldst.h | 2 +- > 1 file

[Qemu-devel] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add

There is no reason why an NBD server couldn't be started for any node, even if it's not on the top level. This converts nbd-server-add to accept a node-name. Note that there is a semantic difference between using a BlockBackend name and the node name of its root: In the former case, the NBD

[Qemu-devel] [PATCH v5 10/11] nbd-server: Use a separate BlockBackend

The builtin NBD server uses its own BlockBackend now instead of reusing the monitor/guest device one. This means that it has its own writethrough setting now. The builtin NBD server always uses writeback caching now regardless of whether the guest device has WCE enabled. qemu-nbd respects the

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

On Wed, 2016-08-03 at 12:32 +0100, Peter Maydell wrote: > Yeah, there's an LTP test that fails because of this (we > send a SIGSEGV when we should be sending a SIGBUS). It's > a bit painful to fix though, since as you say we've > effectively thrown away some information. I'm inclined to > put this

[Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. checkpatch.pl tries to flag them since commit 5d596c2, but it's not very good at it. Offenders tracked down with Coccinelle script scripts/coccinelle/err-bad-newline.cocci, an updated version of the

[Qemu-devel] [PULL v1] io: remove mistaken call to object_ref on QTask

The QTask struct is just a standalone struct, not a QOM Object, so calling object_ref() on it is not appropriate. This results in mangling the 'destroy' field in the QTask struct, causing the later call to qtask_free() to try to call the function at address 0x1, with predictably segfault happy

[Qemu-devel] [PULL v1] Merge qio-next 2016-08-03

The following changes since commit 8b54a6a6c63dc84f2744f6b125c1a6c5a16ee10b: Merge remote-tracking branch 'remotes/ehabkost/tags/numa-pull-request' into staging (2016-08-02 12:55:12 +0100) are available in the git repository at: git://github.com/berrange/qemu

Re: [Qemu-devel] [PATCH v2] mirror: double performance of the bulk stage if the disc is full

Am 14.07.2016 um 19:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size: the data occupies maximum available >

[Qemu-devel] [PATCH v5 01/11] block: Accept node-name for block-stream

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-stream to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the

[Qemu-devel] [PATCH v5 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the

[Qemu-devel] [PATCH v5 04/11] block: Accept node-name for blockdev-mirror

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v5 00/11] block: Accept node-name in all node level QMP commands

As stated in the RFC I sent two weeks ago: * Node level commands: We need to complete the conversion that makes commands accept node names instead of BlockBackend names. In some places we intentionally allow only BlockBackends because we don't know if the command works in other

[Qemu-devel] [PATCH v5 09/11] block: Accept node-name for drive-mirror

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the

[Qemu-devel] [PATCH v5 03/11] block: Accept node-name for blockdev-backup

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an

[Qemu-devel] [PATCH v2] ppc: Stop dumping state on all exceptions in linux-user

Other archs don't do it, some programs catch signals just fine and those dumps just clutter the output. Keep the dumps for cases that aren't supposed to happen such as unknown codes. Signed-off-by: Benjamin Herrenschmidt --- v2. Leave the "XXX" comments alone, we can

Re: [Qemu-devel] [PATCH for-2.8] dmg: Move the driver to block-obj-y

On 03/08/2016 10:01, Fam Zheng wrote: > dmg.o was moved to block-obj-m in 5505e8b76 to become a separate module, > so that its reference to libbz2, since 6b383c08c, doesn't add an extra > library to the main executable. > > We are working on on-demand loading of block drivers which will be >

Re: [Qemu-devel] [PATCH] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice

Hi On Wed, Aug 3, 2016 at 12:06 PM Igor Mammedov wrote: > PCI hotplug for bridges was introduced only since 2.0 however > acpi_set_bsel()->object_property_add_uint32_ptr(bus, > ACPI_PCIHP_PROP_BSEL) > didn't take in account that for legacy mode (1.7) when > PCI hotplug

Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts

On Wed, 2016-08-03 at 19:50 +1000, Benjamin Herrenschmidt wrote: >  > > I'm confused. Is this just swapping the order of the operands to > > '+'? > > I wouldn't expect that to make any difference because typecast has > > higher precedence than '+'... > > The typecast to target_ulong which is

Re: [Qemu-devel] [QUESTION]stuck in SeaBIOS because of losing a SMI

On 03/08/2016 11:43, Xulei (Stone) wrote: > Hi, all: > Recently I use a shell script to continuously reset a vm to see what may > happen. > After one day, the vm is stuck. Looking from the following seabios log and > kvm trace log, it seems like losing a SMI or SeaBIOS can not handle a SMI. >

[Qemu-devel] [PATCH v5 07/11] block: Accept node-name for change-backing-file

In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts change-backing-file to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command

Re: [Qemu-devel] [PATCH 1/2] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

On Wed, 2016-08-03 at 12:19 +0100, Peter Maydell wrote: >  > I don't understand why this didn't cause compile failures... I didn't either. I found: include/qom/cpu.h:typedef uint64_t vaddr; So g2h becomes something like (target_ulong)(uint64) + guest_base Which does build ;-) Cheers, Ben.

Re: [Qemu-devel] [PATCH] ppc: Stop dumping state on all exceptions in linux-user

On Wed, 2016-08-03 at 12:05 +0100, Peter Maydell wrote: > On 3 August 2016 at 09:02, Benjamin Herrenschmidt > > wrote: > > > > Other archs don't do it, some programs catch signals just fine > > and those dumps just clutter the output. Keep the dumps for cases > > that

[Qemu-devel] [PATCH 0/4] error: Newline fixes

Markus Armbruster (4): error: Strip trailing '\n' from error string arguments (again) checkpatch: Fix newline detection in error_setg() & friends vfio: Use error_report() instead of error_printf() for errors error: Fix error_printf() calls lacking newlines hw/i386/pc.c

[Qemu-devel] [PATCH for-2.7 v3 33/36] tests: pc-cpu-test leaks fixes

From: Marc-André Lureau The path is allocated and should be freed. The qmp response should be unref, but then 'machine' must be duplicated. Use a destroy function for the PCTestData. Signed-off-by: Marc-André Lureau Reviewed-by: Eric

Re: [Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

On Sun, Jul 31, 2016 at 06:06:30PM -0700, Ashish Mittal wrote: A quick first pass review... > +/* insure init once */ > +static pthread_mutex_t of_global_ctx_lock; There is no need for this since .bdrv_open() and .bdrv_create() run under the QEMU global mutex. > + > +/* HyperScale Driver

Re: [Qemu-devel] [PATCH v5 04/11] block: Accept node-name for blockdev-mirror

On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-mirror to accept a node-name without lifting the restriction > that we're operating at a root node. > >

Re: [Qemu-devel] [PATCH v5 08/11] block: Accept node-name for drive-backup

On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-backup and the corresponding transaction action to accept a > node-name without lifting the restriction that

Re: [Qemu-devel] [PATCH 2/2] iotests: fix 109

On 03.08.2016 17:22, Sascha Silbe wrote: > Dear Vladimir, > > Vladimir Sementsov-Ogievskiy writes: > >> 109 iotest is broken for raw after 0965a41e998ab820b5 >> [mirror: double performance of the bulk stage if the disc is full] >> >> The problem is with finishing

Re: [Qemu-devel] [PATCH v5 10/11] nbd-server: Use a separate BlockBackend

On 03.08.2016 13:21, Kevin Wolf wrote: > The builtin NBD server uses its own BlockBackend now instead of reusing > the monitor/guest device one. > > This means that it has its own writethrough setting now. The builtin > NBD server always uses writeback caching now regardless of whether the >

[Qemu-devel] [PATCH for-2.7 v3 13/36] portio: keep references on portio

From: Marc-André Lureau The isa_register_portio_list() function allocates ioports data/state. Let's keep the reference to this data on some owner. This isn't enough to fix leaks, but at least, ASAN stops complaining of direct leaks. Further cleanup would require

[Qemu-devel] [PATCH for-2.7 v3 15/36] pc: simplify passing qemu_irq

From: Marc-André Lureau qemu_irq is already a pointer, no need to have an extra pointer level. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 8 hw/input/pckbd.c | 4

[Qemu-devel] [PATCH for-2.7 v3 16/36] pc: don't leak a20_line

From: Marc-André Lureau The irqs array is no longer being used Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc.c

[Qemu-devel] [PATCH for-2.7 v3 21/36] tests: fix qom-test leaks

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/qom-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qom-test.c b/tests/qom-test.c index

Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, August 3, 2016 10:30 PM > To: Gonglei > Cc: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; > peter.huangp...@huawei.com; luoneng...@huawei.com; >

Re: [Qemu-devel] [PATCH for-2.7 v3 19/36] char: free the tcp connection data when closing

Hi - Original Message - > > > On 03/08/2016 16:55, marcandre.lur...@redhat.com wrote: > > @@ -2851,11 +2851,6 @@ static void tcp_chr_disconnect(CharDriverState *chr) > > return; > > } > > > > -s->connected = 0; > > -if (s->listen_ioc) { > > -s->listen_tag

Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

On Wed, Aug 03, 2016 at 04:33:28PM +0200, Cornelia Huck wrote: > On Wed, 3 Aug 2016 17:30:22 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Aug 01, 2016 at 05:20:19PM +0800, Gonglei wrote: > > > This is the specification (version 6) about a new virtio crypto device. > > >

[Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

From: Marc-André Lureau Remove machine class name initialization from DEFINE_PC_MACHINE, rely on class base init name generation instead. Get rid of some leaks that way. Signed-off-by: Marc-André Lureau --- hw/core/machine.c| 1 +

[Qemu-devel] [PATCH for-2.7 v3 18/36] acpi-build: fix array leak

From: Marc-André Lureau The free_ranges array is used as a temporary pointer array, the segment should still be freed, however, it shouldn't free the elements themself. Signed-off-by: Marc-André Lureau Tested-by: Marcel Apfelbaum

[Qemu-devel] [PATCH for-2.7 v3 29/36] usb: free USBDevice.strings

From: Marc-André Lureau The list is created during instance init and further populated with usb_desc_set_string(). Clear it when unrealizing the device. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann ---

[Qemu-devel] [PATCH for-2.7 v3 24/36] ahci: free irqs array

From: Marc-André Lureau Each irq is referenced by the IDEBus in ide_init2(), thus we can free the no longer used array. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Acked-by: John Snow

Re: [Qemu-devel] [PATCH v5 09/11] block: Accept node-name for drive-mirror

On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-mirror to accept a node-name without lifting the restriction that > we're operating at a root node. > > In case

[Qemu-devel] [PATCH for-2.7 v3 30/36] usb: free leaking path

From: Marc-André Lureau qdev_get_dev_path() returns an allocated string, free it when no longer needed. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/desc.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH 2/2] iotests: fix 109

Dear Vladimir, Vladimir Sementsov-Ogievskiy writes: > 109 iotest is broken for raw after 0965a41e998ab820b5 > [mirror: double performance of the bulk stage if the disc is full] > > The problem is with finishing block-job with error: before specified > patch mirror was

[Qemu-devel] [PATCH for-2.7 v3 01/36] build-sys: fix building with make CFLAGS=.. argument

From: Marc-André Lureau When calling make with a CFLAGS=.. argument, the -g/-O filter is not applied, which may result with build failure with ASAN for example. It could be solved with an 'override' directive on CFLAGS, but that would actually prevent setting

[Qemu-devel] [PATCH for-2.7 v3 11/36] tests: fix small leak in test-io-channel-command

From: Marc-André Lureau srcfifo && dstfifo must be freed in error case, however unlink() may delete a file from a different context. Instead, use mkdtemp()/rmdir() for the temporary files. Signed-off-by: Marc-André Lureau Reviewed-by:

[Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

From: Marc-André Lureau Free the list, not just the elements. Signed-off-by: Marc-André Lureau --- include/glib-compat.h | 9 + qga/main.c| 8 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH for-2.7 v3 02/36] tests: fix test-qga leaks

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-qga.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index

[Qemu-devel] [PATCH for-2.7 v3 12/36] tests: fix leak in test-string-input-visitor

From: Marc-André Lureau Free the list returned by visit_type_intList(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-string-input-visitor.c | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH for-2.7 v3 00/36] Various memory leak fixes

From: Marc-André Lureau Hi, Thanks to AddressSanitizer (ASAN), I found a number of direct leaks worth fixing. Note that there are probably many indirect leaks left (I am adding some here), I haven't investigated much yet. There are still a number of direct leaks

[Qemu-devel] [PATCH for-2.7 v3 05/36] tests: fix test-cutils leaks

From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-cutils.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH for-2.7 v3 10/36] tests: fix check-qom-proplist leaks

From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-proplist.c | 16 1 file changed, 16 insertions(+) diff --git

[Qemu-devel] [PATCH for-2.7 v3 27/36] virtio-input: free config list

From: Marc-André Lureau Clear the list when finalizing. The list is created during realize with virtio_input_idstr_config() and later by further calls to virtio_input_init_config() and virtio_input_add_config(). This leak can be reproduced with

[Qemu-devel] [PATCH for-2.7 v3 35/36] ahci: fix sglist leak on retry

From: Marc-André Lureau ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) #1 0x7fc4993bce58 in g_malloc

Re: [Qemu-devel] [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-delete-internal-sync to accept a node-name without > lifting the restriction that we're operating at

[Qemu-devel] [PATCH for-2.7 v3 04/36] qga: free remaining leaking state

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/guest-agent-command-state.c | 7 +++ qga/guest-agent-core.h | 1 + qga/main.c | 6 ++ 3 files changed, 14 insertions(+) diff --git

[Qemu-devel] [PATCH for-2.7 v3 09/36] tests: fix check-qom-interface leaks

From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/check-qom-interface.c

[Qemu-devel] [PATCH for-2.7 v3 26/36] qjson: free str

From: Marc-André Lureau Release the qstring allocated in qjson_new(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- migration/qjson.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

From: Marc-André Lureau Allows one to specify a destroy function for the test data. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 15 +++ tests/libqtest.h | 7 ++- 2 files changed, 21 insertions(+), 1

[Qemu-devel] [PATCH for-2.7 v3 34/36] tests: fix rsp leak in postcopy-test

From: Marc-André Lureau In all cases, even when the dict doesn't contain 'ram', the qmp response must be unref. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH v5 07/11] block: Accept node-name for change-backing-file

On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > change-backing-file to accept a node-name without lifting the > restriction that we're operating at a root node. > >

Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

On Mon, Aug 01, 2016 at 05:20:19PM +0800, Gonglei wrote: > This is the specification (version 6) about a new virtio crypto device. > After a big reconstruction, the spec (symmetric algos) is near to stabilize. > This version fix some problems of formating and return value, etc. > > If you have

[Qemu-devel] [PATCH for-2.7 v3 06/36] tests: fix test-vmstate leaks

From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-vmstate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PULL for-2.7 0/6] usb patch queue.

he Xilinx maintainers (2016-08-01 15:31:32 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-usb-20160803-1 > > for you to fetch changes up to 0e39bb022b5fa8c11964968885f3263c02ce42b0: > > xen: use a common function for pv and hv

  1   2   3   >