Re: [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, September 07, 2016 5:29 AM > > On Wed, 7 Sep 2016 01:05:11 +0530 > Kirti Wankhede wrote: > > > On 9/6/2016 11:10 PM, Alex Williamson wrote: > > > On Sat, 3 Sep 2016 22:04:56 +0530 > > > Kirti Wankhede wrote:

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-07 Thread Juan Quintela
Ashijeet Acharya wrote: > Mark old-commands for speed and downtime as deprecated. > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting maximum migration speed and expected downtime limit parameters > respectively. > Change downtime units to

[Qemu-devel] [PULL 14/64] target-ppc: add maddhd and maddhdu instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania maddhd: Multiply-Add High Doubleword maddhdu: Multiply-Add High Doubleword Unsigned Above two instruction are dual form and differ by 1 bit (31st bit) Multiplies two 64-bit registers (RA * RB), adds third register(RC) to the result(quadword)

[Qemu-devel] [PULL 55/64] ppc: Fix macio ESCC legacy mapping

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt The current mapping, while correct for the base ports (which is all the driver uses these days), is wrong for the extended registers. I suspect the bugs come from incorrect tables in the CHRP IO Ref document, I have verified the new values

[Qemu-devel] [PULL 60/64] ppc: Improve the exception helpers flags

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt They generate exceptions, but they don't update the environment Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Richard Henderson Signed-off-by: David Gibson ---

Re: [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add

2016-09-07 Thread Paolo Bonzini
On 07/09/2016 08:05, David Gibson wrote: > On Wed, Sep 07, 2016 at 01:32:23PM +0800, Peter Xu wrote: >> Considering that we may have multiple IOMMU notifier consumers in the >> future, converting iommu_ops.notify_{started|stopped} into some more >> general form. Now we can trap all notifier

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Cédric Le Goater
On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: >> This is a bit broader than Ben's patch which used PPC_SEGMENT_64B. >> it's basically !PPC_64B which includes the e5500. >> >> If so, here is a proposal below adding a new PPC_RFI

Re: [Qemu-devel] [PATCH v3 6/8] docker: make sure debootstrap is at least 1.0.67

2016-09-07 Thread Sascha Silbe
Dear Fam, Fam Zheng writes: [...] >> +NEED_DEBOOTSTRAP=true >> +elif ! (echo "${MIN_DEBOOTSTRAP_VERSION}" ; "${DEBOOTSTRAP}" --version \ >> +| cut -d ' ' -f 2) | sort -t . -n -k 1,1 -k 2,2 -k 3,3 -C; then > > Like -V, -C is not available on OSX either.

Re: [Qemu-devel] [PATCH 1/7] hw/mips_cmgcr: allow GCR base to be moved

2016-09-07 Thread Leon Alrae
On Fri, Aug 19, 2016 at 08:08:57PM +0100, Paul Burton wrote: > Support moving the GCR base address & updating the CPU's CP0 CMGCRBase > register appropriately. This is required if a platform needs to move its > GCRs away from other memory, as the MIPS Boston development board does > to avoid its

[Qemu-devel] [PATCH v16 02/16] hw/ptimer: Introduce timer policy feature

2016-09-07 Thread Dmitry Osipenko
Some of the timer devices may behave differently from what ptimer provides. Introduce ptimer policy feature that allows ptimer users to change default and wrong timer behaviour, for example to continuously trigger periodic timer when load value is equal to "0". Signed-off-by: Dmitry Osipenko

[Qemu-devel] [PATCH v16 12/16] tests: ptimer: Add tests for "no immediate reload" policy

2016-09-07 Thread Dmitry Osipenko
PTIMER_POLICY_NO_IMMEDIATE_RELOAD makes ptimer to not to re-load counter on setting counter value to "0" or starting to run with "0". Signed-off-by: Dmitry Osipenko --- tests/ptimer-test.c | 51 --- 1 file changed, 44

[Qemu-devel] [PATCH v16 10/16] tests: ptimer: Add tests for "no immediate trigger" policy

2016-09-07 Thread Dmitry Osipenko
PTIMER_POLICY_NO_IMMEDIATE_TRIGGER makes ptimer to not to trigger on starting to run with / setting counter to "0". Signed-off-by: Dmitry Osipenko --- tests/ptimer-test.c | 58 ++--- 1 file changed, 51 insertions(+), 7

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Holger Schranz
Hello Eric, Kevin, unfortunately it was not possible for me to get the git tree at this time. I have insert the changes by hand, which was into this mail below in block/iscsi.c in the distribution from qemu.org for 2.7 (was this o.k.)? After installing and start with virsh create, the following

[Qemu-devel] [PATCH] 9pfs: add support for IO limits to 9p-local driver

2016-09-07 Thread Pradeep
Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which use 9p-local driver. Signed-off-by: Pradeep fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 52 + hw/9pfs/9p-local.c | 18 -

Re: [Qemu-devel] [PATCH v4 0/4] Introduce error_report_{fatal|abort}

2016-09-07 Thread Lluís Vilanova
Fam Zheng writes: > On Wed, 09/07 10:23, Alex Bennée wrote: >> Last time I needed to do error reporting I was told the error_setg >> method was the correct way to do it and the report/exit case made sense >> only in the top level. Before we add even more error reporting >> primitives can we

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-07 Thread Ashijeet Acharya
On Wed, Sep 7, 2016 at 2:11 PM, Juan Quintela wrote: > Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting maximum migration speed

[Qemu-devel] [PATCH v16 05/16] hw/ptimer: Add "wraparound after one period" policy

2016-09-07 Thread Dmitry Osipenko
Currently, periodic counter wraps around immediately once counter reaches "0", this is wrong behaviour for some of the timers, resulting in one period being lost. Add new ptimer policy that provides correct behaviour for such timers, so that counter stays with "0" for a one period before wrapping

[Qemu-devel] [PATCH v16 00/16] PTimer fixes/features and ARM MPTimer conversion

2016-09-07 Thread Dmitry Osipenko
Hello, Currently, QEMU ARM MPTimer device model provides only a certain subset of the emulation behavior. This patch series is supposed to add missing parts by converting the MPTimer to use generic ptimer helper. It fixes some important ptimer bugs and provides new features that are required for

[Qemu-devel] [PATCH v16 15/16] arm_mptimer: Convert to use ptimer

2016-09-07 Thread Dmitry Osipenko
Current ARM MPTimer implementation uses QEMUTimer for the actual timer, this implementation isn't complete and mostly tries to duplicate of what generic ptimer is already doing fine. Conversion to ptimer brings the following benefits and fixes: - Simple timer pausing implementation

[Qemu-devel] [PATCH v16 08/16] tests: ptimer: Add tests for "continuous trigger" policy

2016-09-07 Thread Dmitry Osipenko
PTIMER_POLICY_CONTINUOUS_TRIGGER makes periodic ptimer to re-trigger every period in case of load = delta = 0. Signed-off-by: Dmitry Osipenko --- include/hw/ptimer.h | 4 ++-- tests/ptimer-test.c | 14 -- 2 files changed, 14 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster wrote: >> >>> QAPI language design issues, copying Eric. >>> >>> Marc-André Lureau

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Eric Blake
On 09/07/2016 06:48 AM, Holger Schranz wrote: > Hello Eric, Kevin, > > unfortunately it was not possible for me to get the git tree at this > time. I have insert the changes by hand, which was into this mail below > in block/iscsi.c in the distribution from qemu.org for 2.7 (was this o.k.)?

[Qemu-devel] [PULL 18/64] ppc: Move embedded spe ops out of translate.c

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Makes things a bit more manageable Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 1328

Re: [Qemu-devel] [PATCH v3 2/2] usb-mtp: added object properties

2016-09-07 Thread Gerd Hoffmann
Hi, > and object properties. Most object properties are data that we already > have, except for the unique persistant object identifier. Windows > +case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER: > +/* Should be persistant between sessions, > + * but using our objedt ID is

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

2016-09-07 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907 Type: series Message-id: 1473244183-31510-1-git-send-email-da...@gibson.dropbear.id.au === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v2] checkpatch: Fix whitespace checks for documentation code blocks

2016-09-07 Thread Paolo Bonzini
On 07/09/2016 14:49, Lluís Vilanova wrote: > Prevent blank lines in documentation code blocks to be signalled as > incorrect trailing whitespace. > > Code blocks in documentation are 4-column aligned, and blank lines in > them should have exactly 4 columns of trailing whitespace to prevent >

[Qemu-devel] [PATCH v16 03/16] tests: Add ptimer tests

2016-09-07 Thread Dmitry Osipenko
Ptimer is a generic countdown timer helper that is used by many timer device models as well as by the QEMU core. Add QTests for the ptimer. Signed-off-by: Dmitry Osipenko --- stubs/vmstate.c | 5 + tests/Makefile.include| 2 + tests/ptimer-test-stubs.c | 107

[Qemu-devel] [PATCH v16 07/16] hw/ptimer: Add "continuous trigger" policy

2016-09-07 Thread Dmitry Osipenko
Currently, periodic timer that has load = delta = 0 performs trigger on timer reload and stops, printing a "period zero" error message. Introduce new policy that makes periodic timer to continuously trigger with a period interval in case of load = 0. Signed-off-by: Dmitry Osipenko

[Qemu-devel] [PULL 57/64] ppc: Stop dumping state on all exceptions in linux-user

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Other archs don't do it, some programs catch signals just fine and those dumps just clutter the output. Keep the dumps for cases that aren't supposed to happen such as unknown codes. Signed-off-by: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH] Fix remainder field for TR_SETUP completion event

2016-09-07 Thread Gerd Hoffmann
On Di, 2016-08-23 at 13:46 +0200, Hans Petter Selasky wrote: > Hi, > > Patch is also attached. > > --HPS > > > Fix remainder field for TR_SETUP completion event. Previously > > the code would incorrectly report the remainder as 8 bytes. A remainder of > > 0 > > bytes should be reported when

Re: [Qemu-devel] [PATCH 0/2] curses Coverity fixes

2016-09-07 Thread Gerd Hoffmann
On Do, 2016-08-11 at 15:23 +0100, Peter Maydell wrote: > This patchset fixes a couple of issues found by Coverity > in the curses ui frontend. Added to ui queue. thanks, Gerd

Re: [Qemu-devel] [virtio-comment] [PATCH] *** Vhost-pci RFC v2 ***

2016-09-07 Thread Wang, Wei W
On 09/07/2016 01:17 PM, Stefan Hajnoczi wrote: > On Mon, Sep 05, 2016 at 08:56:14AM +, Marc-André Lureau wrote: > > Hi > > > > On Sat, Sep 3, 2016 at 5:36 PM Wang, Wei W wrote: > > > > > Marc-André and I just got different thoughts about a design > > > direction. I

Re: [Qemu-devel] [PATCH 2/7] hw/mips_gictimer: provide API for retrieving frequency

2016-09-07 Thread Leon Alrae
On Fri, Aug 19, 2016 at 08:08:58PM +0100, Paul Burton wrote: > Provide a new function mips_gictimer_get_freq() which returns the > frequency at which a GIC timer will count. This will be useful for > boards which perform setup based upon this frequency. > > Signed-off-by: Paul Burton

[Qemu-devel] [PATCH v16 11/16] hw/ptimer: Add "no immediate reload" policy

2016-09-07 Thread Dmitry Osipenko
Immediate counter re-load on setting (or on starting to run with) counter = 0 is a wrong behaviour for some of the timers. Add "no immediate reload" policy that provides correct behaviour for such timers. Signed-off-by: Dmitry Osipenko --- hw/core/ptimer.c| 8 +---

[Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-07 Thread Paulina Szubarczyk
Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be allocated what is done by calling ioreq_init_copy_buffers. For the 'read' operation, first, the qemu device invokes the read operation on local buffers and on

[Qemu-devel] [PATCH v6 1/2] libs/gnttab: introduce grant copy interface

2016-09-07 Thread Paulina Szubarczyk
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is invoked. In mini-os the operation is yet not implemented. For the OSs that does not implement gnttab the call of the grant copy operation causes abort. Signed-off-by: Paulina Szubarczyk

Re: [Qemu-devel] [PATCH 1/2] SDL2: only show consoles by shortcuts and not hide.

2016-09-07 Thread Gerd Hoffmann
On Di, 2016-08-23 at 23:36 +0300, Andrei Karas wrote: > This fix issue with stuck keys in SDL2 if press one of shortcuts > for show/hide consoles. More detailed description please. How exactly do you end up with stuck keys? > win = ev->key.keysym.scancode - SDL_SCANCODE_1; >

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-07 Thread Greg Kurz
On Wed, 7 Sep 2016 11:36:21 +0200 Laurent Vivier wrote: > On 06/09/2016 23:41, Greg Kurz wrote: > > On Tue, 6 Sep 2016 15:17:56 +0200 > > Laurent Vivier wrote: > > > >> And add support for ppc64. > >> > >> Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH] 9pfs: add support for IO limits to 9p-local driver

2016-09-07 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] 9pfs: add support for IO limits to 9p-local driver Type: series Message-id:

[Qemu-devel] [PATCH v2] checkpatch: Fix whitespace checks for documentation code blocks

2016-09-07 Thread Lluís Vilanova
Prevent blank lines in documentation code blocks to be signalled as incorrect trailing whitespace. Code blocks in documentation are 4-column aligned, and blank lines in them should have exactly 4 columns of trailing whitespace to prevent QEMU's wiki to render them as separate code blocks.

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-07 Thread Laurent Vivier
On 07/09/2016 14:44, Greg Kurz wrote: > On Wed, 7 Sep 2016 11:36:21 +0200 > Laurent Vivier wrote: > >> On 06/09/2016 23:41, Greg Kurz wrote: >>> On Tue, 6 Sep 2016 15:17:56 +0200 >>> Laurent Vivier wrote: >>> And add support for ppc64.

[Qemu-devel] [PATCH v16 06/16] tests: ptimer: Add tests for "wraparound after one period" policy

2016-09-07 Thread Dmitry Osipenko
PTIMER_POLICY_WRAP_AFTER_ONE_PERIOD changes ptimer behaviour in a such way, that it would wrap around after one period instead of doing it immediately. Signed-off-by: Dmitry Osipenko --- tests/ptimer-test.c | 45 +++-- 1 file changed, 31

[Qemu-devel] [PATCH v16 04/16] hw/ptimer: Suppress error messages under qtest

2016-09-07 Thread Dmitry Osipenko
Under qtest ptimer emits lots of warning messages. The messages are caused by the actual checking of the ptimer error conditions. Suppress those messages, so they do not distract. Signed-off-by: Dmitry Osipenko --- hw/core/ptimer.c | 9 +++-- 1 file changed, 7

[Qemu-devel] [PATCH v16 01/16] hw/ptimer: Actually stop the timer in case of error

2016-09-07 Thread Dmitry Osipenko
Running with counter / period = 0 is treated as a error case, printing error message claiming that timer has been disabled. However, timer is only marked as disabled, keeping to tick till expired and triggering after being claimed as disabled. Stop the QEMU timer to avoid confusion.

[Qemu-devel] [PULL 20/64] ppc: Move VMX ops out of translate.c

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Makes things a bit more manageable Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 1068

Re: [Qemu-devel] Fixing dma-helper qiov truncation

2016-09-07 Thread Paolo Bonzini
On 07/09/2016 09:31, Mark Cave-Ayland wrote: > Now that the 2.8 tree is open, I'd like to resurrect this earlier patch > to switch the macio controller over to the new byte-aligned DMA helpers: > https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg04907.html. > > The first patch in the

Re: [Qemu-devel] [PATCH] console: skip same-size resize

2016-09-07 Thread Gerd Hoffmann
On Fr, 2016-08-26 at 13:47 +0400, Marc-André Lureau wrote: > virtio-gpu does a set-scanout at each frame (it might be a driver > regression). xorg vs wayland maybe? as far I know only wayland pageflips for each frame. > qemu_console_resize() recreate a surface even if the size > didn't change,

Re: [Qemu-devel] [PATCH] qemu-options.hx: correct spice options streaming-video default document value to 'off'

2016-09-07 Thread Gerd Hoffmann
On Mo, 2016-08-01 at 12:06 +0800, Li Zhijian wrote: > since f1d3e58, the code had changed the default value to 'off', so this patch > make document and code are consistent. Added to UI queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] checkpatch: Fix whitespace checks for documentation code blocks

2016-09-07 Thread Lluís Vilanova
Paolo Bonzini writes: > On 06/09/2016 12:30, Lluís Vilanova wrote: >> Prevent blank lines in documentation code blocks to be signalled as >> incorrect trailing whitespace. >> >> Code blocks in documentation are 4-column aligned, and blank lines in >> them should have exactly 4 columns of

Re: [Qemu-devel] [PATCH] console: skip same-size resize

2016-09-07 Thread Marc-André Lureau
Hi On Wed, Sep 7, 2016 at 4:10 PM Gerd Hoffmann wrote: > On Fr, 2016-08-26 at 13:47 +0400, Marc-André Lureau wrote: > > virtio-gpu does a set-scanout at each frame (it might be a driver > > regression). > > xorg vs wayland maybe? as far I know only wayland pageflips for each

[Qemu-devel] Raspberry Pi emulation and network devices

2016-09-07 Thread Tom Cook
I'm trying to emulate a raspberry pi in QEMU using the fork at https://github.com/0xabu/qemu. I've cloned that code, then merged more recent changes from https://github.com/qemu/qemu (as of sometime yesterday) and fixed up the resulting build failures. The guest is running Linux kernel

[Qemu-devel] [PATCH v16 13/16] hw/ptimer: Add "no counter round down" policy

2016-09-07 Thread Dmitry Osipenko
For most of the timers counter starts to decrement after first period expires. Due to rounding down performed by the ptimer_get_count, it returns counter - 1 for the running timer, so that for the ptimer user it looks like counter gets decremented immediately after running the timer. Add "no

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-07 Thread Marcel Apfelbaum
On 09/07/2016 10:53 AM, Laszlo Ersek wrote: On 09/06/16 13:35, Gerd Hoffmann wrote: Hi, [...] Side note: the linux kernel allocates io space nevertheless, so checking /proc/ioports after boot doesn't tell you what the firmware did. Yeah, we've got to convince Linux to stop doing that.

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-07 Thread Laszlo Ersek
On 09/07/16 08:21, Gerd Hoffmann wrote: > Hi, > ports, if that's allowed). For example: - 1-32 ports needed: use root ports only - 33-64 ports needed: use 31 root ports, and one switch with 2-32 downstream ports > > I expect you rarely need any switches. You can

Re: [Qemu-devel] [PATCH v5 02/20] qapi.py: add a simple #ifdef conditional

2016-09-07 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Sep 6, 2016 at 7:58 PM Markus Armbruster wrote: > >> QAPI language design issues, copying Eric. >> >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Tue, Sep 6, 2016 at 5:00

Re: [Qemu-devel] [RFC v4 20/28] cpus: tweak sleeping and safe_work rules for MTTCG

2016-09-07 Thread Paolo Bonzini
On 11/08/2016 17:24, Alex Bennée wrote: > Once TCG gains the ability to sleep individual threads we need to make > sure they don't sleep when safe work is pending as all threads need to > go through the process_queued_work function. Also if we have multiple > threads wait_for_safe_work can now

[Qemu-devel] [PULL 10/64] target-ppc: add cnttzw[.] instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania Add ISA3.0: Count trailing zeros word instruction. Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson Signed-off-by: David Gibson --- target-ppc/helper.h

[Qemu-devel] [PULL 13/64] target-ppc: add maddld instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania maddld: Multiply-Add Low Doubleword Multiplies two 64-bit registers (RA * RB), adds third register(RC) to the result(quadword) and returns the lower dword in the target register(RT). Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PULL 02/64] hw/ppc: include fdt helper routine in a common file

2016-09-07 Thread David Gibson
From: Cédric Le Goater spapr_pci would also be a good candidate but the macro _FDT is slightly different. It returns and does not exit. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr.c| 11

[Qemu-devel] [PULL 30/64] ppc: Fix source NIP on SLB related interrupts

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt We need to pass it to the raise helper since we don't update it before the calls. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/mmu-hash64.c | 16

[Qemu-devel] [PULL 29/64] ppc: Make tlb_fill() use new exception helper

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- linux-user/main.c| 12 ++-- target-ppc/excp_helper.c | 146

[Qemu-devel] [PULL 59/64] ppc: Improve flags for helpers loading/writing the time facilities

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Those helpers never load from or store to the TCG tracked environment, not do they generate synchronous exceptions (they might generate an asynchronous interrupt but that's not an issue here). So we can make them all use TCG_CALL_NO_RWG

[Qemu-devel] [PULL 51/64] target-ppc: add extswsli[.] instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania extswsli : Extend Sign Word & Shift Left Immediate Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson Reviewed-by: Richard Henderson Signed-off-by: David

[Qemu-devel] [PULL 41/64] ppc: Don't set access_type on all load/stores on hash64

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt We don't use it so let's not generate the updates. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 4 +++- 1 file changed, 3

[Qemu-devel] [PULL 53/64] hw/ppc: use error_report instead of fprintf

2016-09-07 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr.c | 12 ++-- hw/ppc/spapr_drc.c | 8 hw/ppc/spapr_iommu.c | 4 ++-- hw/ppc/spapr_rtas.c | 13 +++--

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Benjamin Herrenschmidt
On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: > This is a bit broader than Ben's patch which used PPC_SEGMENT_64B.  > it's basically !PPC_64B which includes the e5500. > > If so, here is a proposal below adding a new PPC_RFI in the  > "PowerPC Instructions types definitions" enum for

[Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine

2016-09-07 Thread David Gibson
From: Cédric Le Goater The exact same routine will be used in PowerNV. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/Makefile.objs | 2 +- hw/ppc/fdt.c | 49

Re: [Qemu-devel] [virtio-dev][RFC v3] virtio-sdm: new device specification

2016-09-07 Thread Edgar E. Iglesias
On Wed, Sep 07, 2016 at 09:24:39AM +0200, Christian Pinto wrote: > Hello Edgar, > > thanks for your comments. > Thanks for the clarification, I have a few follow-up questions/comments. > > On 06/09/2016 23:43, Edgar E. Iglesias wrote: > >Hi, > > > >Sorry for the delay. I have a few questions.

Re: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-07 Thread Kevin Wolf
Am 06.09.2016 um 21:04 hat Eric Blake geschrieben: > When qemu uses iscsi devices in sg mode, iscsilun->block_size > is left at 0. Prior to commits cf081fca and similar, when > block limits were tracked in sectors, this did not matter: > various block limits were just left at 0. But when we

Re: [Qemu-devel] [PATCH RFC 3/4] target-ppc: use atomic_cmpxchg for ld/st reservation

2016-09-07 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Wed, 2016-09-07 at 10:17 +0530, Nikunj A Dadhania wrote: >> > David Gibson writes: >> >> > >> > [ Unknown signature status ] >> > On Fri, Sep 02, 2016 at 12:02:55PM +0530, Nikunj A Dadhania wrote: >> >

Re: [Qemu-devel] [RFC v4 14/28] tcg: add kick timer for single-threaded vCPU emulation

2016-09-07 Thread Alex Bennée
Paolo Bonzini writes: > On 07/09/2016 05:25, Richard Henderson wrote: >>> >>> +/* Set to kick if we have to do more than one vCPU */ >>> +if (CPU_NEXT(first_cpu)) { >>> +kick_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, kick_tcg_thread, >>> +

Re: [Qemu-devel] [PATCH v3 2/3] memory: generalize iommu_ops.notify_started to notifier_add

2016-09-07 Thread David Gibson
On Wed, Sep 07, 2016 at 03:23:16PM +0800, Peter Xu wrote: > On Wed, Sep 07, 2016 at 04:05:50PM +1000, David Gibson wrote: > > On Wed, Sep 07, 2016 at 01:32:23PM +0800, Peter Xu wrote: > > > Considering that we may have multiple IOMMU notifier consumers in the > > > future, converting

Re: [Qemu-devel] [PATCH v3 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-07 Thread David Gibson
On Wed, Sep 07, 2016 at 03:09:16PM +0800, Peter Xu wrote: > On Wed, Sep 07, 2016 at 04:02:39PM +1000, David Gibson wrote: > > On Wed, Sep 07, 2016 at 01:32:22PM +0800, Peter Xu wrote: > > > IOMMU Notifier list is used for notifying IO address mapping changes. > > > Currently VFIO is the only user.

[Qemu-devel] [PULL 16/64] ppc: Provide basic raise_exception_* functions

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Instead of using the same helpers called from translate.c, let's have a bunch of functions that take the various argument combinations, especially the retaddr which will be needed in subsequent patches, and leave the helpers to be just that,

[Qemu-devel] [PULL 33/64] ppc: Don't update NIP BookE 2.06 tlbwe

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt This is no longer necessary as the helpers will properly retrieve the return address when needed. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 11/64] target-ppc: add cmpeqb instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania Search a byte in the stream of 8bytes provided in the register Suggested-by: Richard Henderson Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson Signed-off-by:

[Qemu-devel] [PULL 32/64] ppc: Don't update NIP in facility unavailable interrupts

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt This is no longer necessary as the helpers will properly retrieve the return address when needed. Also remove gen_update_current_nip() which didn't seem to make much sense to me. Signed-off-by: Benjamin Herrenschmidt

[Qemu-devel] [PULL 58/64] ppc: Don't generate dead code on unconditional branches

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt We are always generating the "else" case of the condition even when generating an unconditional branch that will never hit it. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 31/64] ppc: Don't update NIP in DCR access routines

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt This is no longer necessary as the helpers will properly retrieve the return address when needed Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 64/64] tests: Check serial output of firmware boot of some machines

2016-09-07 Thread David Gibson
From: Thomas Huth Some of the machines that we have got a firmware image for write some output to the serial console while booting up. We can use this output to make sure that the machine is basically working, so this adds a test that checks the output of these machines for

[Qemu-devel] [PULL 48/64] target-ppc: add vcmpnez[b, h, w][.] instructions

2016-09-07 Thread David Gibson
From: Swapnil Bokade Adds following instructions: vcmpnezb[.]: Vector Compare Not Equal or Zero Byte vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword vcmpnezw[.]: Vector Compare Not Equal or Zero Word Signed-off-by: Swapnil Bokade [

[Qemu-devel] [PULL 42/64] ppc: Use a helper to generate "LE unsupported" alignment interrupts

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Some operations aren't allowed in LE mode, use a helper rather than open coding the exception generation. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---

Re: [Qemu-devel] [PATCH v4 0/4] Introduce error_report_{fatal|abort}

2016-09-07 Thread Peter Xu
On Wed, Sep 07, 2016 at 05:33:08PM +0800, Fam Zheng wrote: > On Wed, 09/07 10:23, Alex Bennée wrote: > > Last time I needed to do error reporting I was told the error_setg > > method was the correct way to do it and the report/exit case made sense > > only in the top level. Before we add even more

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-07 Thread Cédric Le Goater
On 09/06/2016 09:07 AM, Mark Cave-Ayland wrote: > On 06/09/16 01:16, David Gibson wrote: > >> On Mon, Sep 05, 2016 at 09:51:09PM +0100, Mark Cave-Ayland wrote: >>> On 05/09/16 21:30, Cédric Le Goater wrote: >>> > Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a >

[Qemu-devel] [PULL 36/64] ppc: Don't update NIP in dcbz and lscbx

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Instead, pass GETPC() result to the corresponding helpers. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/mem_helper.c | 9 +

[Qemu-devel] [PULL 62/64] spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call

2016-09-07 Thread David Gibson
From: Laurent Vivier Since kernel v4.0, linux uses H_CHANGE_LOGICAL_LAN_MAC to change lively the MAC address of an ibmveth interface. As QEMU doesn't implement this h_call, we can't change anymore the MAC address of an spapr-vlan interface. Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-07 Thread Laszlo Ersek
On 09/06/16 13:35, Gerd Hoffmann wrote: > Hi, > >>> +Plug only legacy PCI devices as Root Complex Integrated Devices >>> +even if the PCIe spec does not forbid PCIe devices. >> >> I suggest "even though the PCI Express spec does not forbid PCI Express >> devices as Integrated Devices". (Detail

Re: [Qemu-devel] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure

2016-09-07 Thread Benjamin Herrenschmidt
On Wed, 2016-09-07 at 15:46 +1000, David Gibson wrote: > Right, that's probably better.  Not immediately sure how the > scomdevice would get hold of its chip's scom AS, but we can probably > figure out something. Passed at instanciation ? Cheers, Ben.

Re: [Qemu-devel] [RFC v4 14/28] tcg: add kick timer for single-threaded vCPU emulation

2016-09-07 Thread Alex Bennée
Richard Henderson writes: > On 08/11/2016 08:24 AM, Alex Bennée wrote: >> Currently we rely on the side effect of the main loop grabbing the >> iothread_mutex to give any long running basic block chains a kick to >> ensure the next vCPU is scheduled. As this code is being

[Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

2016-09-07 Thread David Gibson
The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-09-06 17:18:17 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160907 for you

[Qemu-devel] [PULL 34/64] ppc: Don't update NIP on conditional trap instructions

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt This is no longer necessary as the helpers will properly retrieve the return address when needed. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 19/64] ppc: Move DFP ops out of translate.c

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Makes things a bit more manageable Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 365

[Qemu-devel] [PULL 15/64] target-ppc: introduce opc4 for Expanded Opcode

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania ISA 3.0 has introduced EO - Expanded Opcode. Introduce third level indirect opcode table and corresponding parsing routines. EO (11:12) Expanded opcode field Formats: XX1 EO (11:15) Expanded opcode field Formats: VX, X, XX2 Signed-off-by:

[Qemu-devel] [PULL 23/64] ppc: Make float_invalid_op_excp() pass the return address

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Instead of relying on NIP having been updated already Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/fpu_helper.c | 6 -- 1 file changed, 4

[Qemu-devel] [PULL 17/64] ppc: Move classic fp ops out of translate.c

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt Makes things a bit more manageable Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 1205

[Qemu-devel] [PULL 63/64] tests: Resort check-qtest entries in Makefile.include

2016-09-07 Thread David Gibson
From: Thomas Huth The rather random list of check-qtest-xxx entries caused some confusion in the past, where to use "=" and where to use "+=" (see commits 0ccac16f59462b8e2b9afbc1 and 1f5c1cfbaec0792cd2e5da for example). Sorting the check-qtest-xxx entries by architecure

[Qemu-devel] [PULL 40/64] ppc: Fix CFAR updates

2016-09-07 Thread David Gibson
From: Benjamin Herrenschmidt We were one instruction off Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 1/1] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-07 Thread Denis V. Lunev
On 09/07/2016 09:15 AM, Jeff Cody wrote: > On Tue, Sep 06, 2016 at 06:11:19PM +0300, Denis V. Lunev wrote: >> bdrv_is_allocated_above() returns true in the case if qcow2 even for >> completely zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both >> cases. > Hi Denis, > > Not just qcow2.

[Qemu-devel] [PULL 03/64] target-ppc: Introduce Power9 family

2016-09-07 Thread David Gibson
From: "Aneesh Kumar K.V" The patch adds CPU PVR definition for POWER9 and enables QEMU to launch guests/linux-user in TCG mode. Signed-off-by: Aneesh Kumar K.V [ Added POWER9 alias, POWER9 SPAPR core and dropped MMU defines ]

[Qemu-devel] [PULL 05/64] target-ppc: adding addpcis instruction

2016-09-07 Thread David Gibson
From: Nikunj A Dadhania ISA 3.0 instruction for adding immediate value shifted with next instruction address and return the result in the target register. Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson

  1   2   3   >