Until now we have been comparing physical addresses in LL/SC sequence.
Unfortunately that means that on each SC we have to do the address
translation which is a quite complex operation. If we could get rid of
it then it would allow us to throw away SC helpers and benefit from having
common
On Wed, 09/21 08:50, Alex Bennée wrote:
>
> Fam Zheng writes:
>
> > On Tue, 09/20 14:56, Alex Bennée wrote:
> >> This re-factors the docker makefile to include a docker-run target which
> >> can be controlled entirely from environment variables specified on the
> >> make
On Tue, Sep 20, 2016 at 07:21:07PM +0200, Paolo Bonzini wrote:
>
>
> On 20/09/2016 17:14, Daniel P. Berrange wrote:
> > Any VM which
> > uses the separate namespace is tainted, which means if theres a bug
> > report we'll require the reported to remove whatever config caused
> > the tainting and
If compiling with -Werror=unused-result, replay-internal.c won't build
due to a call to fwrite() where the returned value is ignored. A simple
cast to (void) is not sufficient on recent GCCs, so this fixes it.
Signed-off-by: Felipe Franciosi
---
replay/replay-internal.c | 2
> From: Felipe Franciosi [mailto:fel...@nutanix.com]
> > On 21 Sep 2016, at 07:24, Markus Armbruster wrote:
> >
> > "Pavel Dovgalyuk" writes:
> >
> >>> From: Felipe Franciosi [mailto:fel...@nutanix.com]
> >>> If compiling with -Werror=unused-result,
Am 2016-08-16 15:56, schrieb Michael Walle:
Am 2016-08-16 15:41, schrieb Riku Voipio:
On Tue, Aug 16, 2016 at 03:32:56PM +0200, Michael Walle wrote:
Am 2016-07-22 17:57, schrieb Alexander Graf:
>On 07/22/2016 05:18 PM, Michael Walle wrote:
>>64 bit user mode doesn't work for the e5500 core
From: Pavel Dovgalyuk
VMState added by this patch preserves correct
loading of the integratorcp device state.
Signed-off-by: Pavel Dovgalyuk
---
hw/arm/integratorcp.c | 62 +
1 file changed,
On Mon, Sep 19, 2016 at 11:59:31AM +0530, Nikunj A Dadhania wrote:
> From: Benjamin Herrenschmidt
>
> Instead of an array of fixed sized blocks, use a list, as we will need
> to have sources with variable number of interrupts. SPAPR only uses
> a single entry. Native
Fam Zheng writes:
> On Wed, 09/21 10:44, Alex Bennée wrote:
>>
>> FWIW we already have some coverage of the MacOSX builds via Travis
>> (although being able to run it quickly on a dev system would be useful).
>
> Being able to detect breakage earlier than a pull req bounce from
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
parameters, but the qapi qmp_dispatch() code uses
QERR_INVALID_PARAMETER_TYPE.
Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
appropriate.
Signed-off-by: Marc-André Lureau
---
Hi,
'monitor: use qmp_dispatch()' patch broke some iotests expecting a
'missing parameter' error. This series fixes qapi visitors to return
this error for all types.
Marc-André Lureau (3):
qapi: return a 'missing parameter' error
qapi: clear given pointer
iotests: fix expected error
This patch adds bdrv_recurse_is_first_non_filter implementation
for blkreplay driver. It allows creating snapshots when blkreplay
is enabled.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |9 +
1 file changed, 9 insertions(+)
diff --git
This set of patches includes several fixes for replay and
adds network record/replay for network devices. It also makes possible
saving/restoring vmstate in replay mode.
Record and replay for network interactions is performed with the network filter.
Each backend must have its own instance of the
This patch moves replay static variables into the structure
to allow saving and loading them with savevm/loadvm.
Reviewed-by: Paolo Bonzini
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-events.c |2 +-
replay/replay-internal.c | 20
This patch introduces vmstate for replay data structures.
It allows saving and loading vmstate while replaying.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-internal.h |9 +
replay/replay-snapshot.c | 40
This patch implements initial vmstate creation or loading at the start
of record/replay. It is needed for rewinding the execution in the replay mode.
v4 changes:
- snapshots are not created by default anymore
v3 changes:
- added rrsnapshot option
Signed-off-by: Pavel Dovgalyuk
On Wed, Sep 21, 2016 at 11:49:25AM +0800, Fam Zheng wrote:
> This makes the configure command more obvious which usually has useful
> information.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/common.rc | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
On Tue, 2016-09-20 at 22:54 -0400, G 3 wrote:
> You really want to remove the included list of resolutions? I was
> thinking about adding a lot more built-in resolutions in another
> patch. A built-in list is very convenient.
I mean remove it from the driver and put it in OpenBIOS instead.
On Mon, Sep 19, 2016 at 11:59:32AM +0530, Nikunj A Dadhania wrote:
> From: Benjamin Herrenschmidt
>
> This will make life easier for dealing with dynamically configured
> ICSes such as PHB3
>
> Signed-off-by: Benjamin Herrenschmidt
>
QEMU currently refuses to start with KVM-PR and only prints out
qemu: fatal: Unknown MMU model 851972
when being started there. This is because commit 4322e8ced5aaac719
("ppc: Fix 64K pages support in full emulation") introduced a new
POWERPC_MMU_64K bit to indicate support for this page
On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote:
>
> > On 21 Sep 2016, at 07:24, Markus Armbruster wrote:
> >
> > "Pavel Dovgalyuk" writes:
> >
> >>> From: Felipe Franciosi [mailto:fel...@nutanix.com]
> >>> If compiling with
Benjamin Herrenschmidt writes:
> On Sun, 2016-08-14 at 15:54 -0700, no-reply@ec2-52-6-146-230.compute-
> 1.amazonaws.com wrote:
>> Hi,
>>
>> Your series seems to have some coding style problems. See output
>> below for more information:
>
> Bla bla bla bla ...
>
>
Missing argument returns a corresponding error message for all types
now.
Signed-off-by: Marc-André Lureau
---
tests/qemu-iotests/087.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out
This patch disables snapshotting for block driver filters.
It is needed, because snapshots should be created
in underlying disk images, not in filters itself.
Signed-off-by: Pavel Dovgalyuk
---
block/snapshot.c |3 +++
1 file changed, 3 insertions(+)
diff --git
On Fri, 12 Aug 2016 14:54:04 +0800
Xiao Guangrong wrote:
> For each NVDIMM present or intended to be supported by platform,
> platform firmware also exposes an ACPI Namespace Device under
> the root device
>
> So it builds nvdimm devices for all slots to support
> On 21 Sep 2016, at 07:24, Markus Armbruster wrote:
>
> "Pavel Dovgalyuk" writes:
>
>>> From: Felipe Franciosi [mailto:fel...@nutanix.com]
>>> If compiling with -Werror=unused-result, replay-internal.c won't build
>>> due to a call to fwrite() where the
On Wed, 09/21 10:44, Alex Bennée wrote:
>
> FWIW we already have some coverage of the MacOSX builds via Travis
> (although being able to run it quickly on a dev system would be useful).
Being able to detect breakage earlier than a pull req bounce from Peter would
also be good.
>
> >
> > I
On Wed, 21 Sep 2016 09:02:35 +0200
Greg Kurz wrote:
> On Tue, 20 Sep 2016 15:49:33 +0100
> Stefan Hajnoczi wrote:
>
> > Errors can occur during virtqueue_pop(), especially in
> > virtqueue_map_desc(). In order to handle this we must unmap iov[]
> > before
This patch fixes bug with stopping and restarting replay
through monitor.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c| 15 +--
cpus.c |1 +
include/sysemu/replay.h |4
replay/replay-events.c |8
This patch adds support of recording and replaying network packets in
irount rr mode.
Record and replay for network interactions is performed with the network filter.
Each backend must have its own instance of the replay filter as follows:
-netdev user,id=net1 -device rtl8139,netdev=net1
On Wed, Sep 21, 2016 at 11:49:22AM +0800, Fam Zheng wrote:
> Put the list of package names in an environment, and output their
> package names to the target file in the end.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/ubuntu.docker | 4 +++-
> 1 file changed,
Only the POWER[789] CPUs should have the ARCH_206 bit set. This is what the
linux kernel does. I guess this was also the intention of commit 0e019746.
We have to make sure all *206 bits are set.
Before this patch, the flags check in the GET_FEATURES2 macro returned true
if _any_ bit was set. This
Hi Greg,
Thanks for having a look at patchset.
See the replies below.
On Fri, 16 Sep 2016 04:33:36 -0400
Pradeep Jagadeesh wrote:
Uses throttling APIs to limit I/O bandwidth and number of operations on the
fsdev devices.
Signed-off-by: Pradeep Jagadeesh
On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote:
>
> > >
> > > total: 428 errors, 73 warnings, 1950 lines checked
> > >
> > > Your patch has style problems, please review.If any of these
> > > errors
> > > are false positives report them to the maintainer, see
> > > CHECKPATCH in
On Tue, 20 Sep 2016 15:49:29 +0100
Stefan Hajnoczi wrote:
> v4:
> * Rebase to qemu.git/master
> * Use "unsigned int" instead of "unsigned" in virtqueue_undo_map_desc()
> [Cornelia]
>
FWIW, any unchanged or only trivially-rebased patch retains my r-b or
a-b.
> v3:
> *
On Wed, 21 Sep 2016 15:29:26 +1000
David Gibson wrote:
> Now that we allow CPU hot unplug on a few platforms, we can end up in a
> situation where we don't have a CPU with index 0. Or at least we could,
> if we didn't have code to explicitly prohibit unplug of CPU
On Wed, Sep 21, 2016 at 11:49:20AM +0800, Fam Zheng wrote:
> Put the list of package names in an environment, and output their
> package names to the target file in the end.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/centos6.docker | 6 --
> 1 file
On Wed, Sep 21, 2016 at 11:49:26AM +0800, Fam Zheng wrote:
> Add a make variable SHOW_ENV. When it's set to non empty, print the
> package information and environment variables.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/Makefile.include | 2 +-
> tests/docker/run
On Wed, Sep 21, 2016 at 11:49:24AM +0800, Fam Zheng wrote:
> Previously it is expanded to a whitespace separated list which is not
> the most appropriate format. Since it's only two items, flatten it.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/test-quick | 2 +-
> 1 file
On Wed, Sep 21, 2016 at 12:27:25PM +0800, Fam Zheng wrote:
> I understand that we've been keeping eyes on the uncovered files. Since
> I'm adding some more files I volunteer to look after them in the futuer.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: Jeff Cody
On Mon, Sep 19, 2016 at 11:59:30AM +0530, Nikunj A Dadhania wrote:
> With a single cpu VM running with kernel-irqchip=off and a flood ping
> running in the guest. Migration fails once in few times.
>
> Found that whenever there is an interrupt (in this case lsi int 3 from
> e1000), we raise an
On Mon, Sep 19, 2016 at 11:59:29AM +0530, Nikunj A Dadhania wrote:
> Fix inconsistent irq status, because of this in the trace logs, for e.g.
> LSI status was 0x7, i.e. XICS_STATUS_ASSERTED, XICS_STATUS_SENT and
> XICS_STATUS_REJECTED all set, which did not make sense. So the REJECTED
> would have
By the way, is this full patch of you?
---
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index ea625f2..dd4ef5c 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -721,7 +722,7 @@ static int rtc_post_load(void *opaque, int version_id)
{
RTCState *s = opaque;
-
On 20.09.2016 16:39, Cédric Le Goater wrote:
> On 09/20/2016 04:24 PM, Thomas Huth wrote:
>> On 20.09.2016 16:04, Cédric Le Goater wrote:
[...]
>>> There are other issues after in the guest (kernel crashing). But I think
>>> these are related to TM which is not supported in KVM-PR. I am not sure
Public bug reported:
target-arm/translate-a64.c:2028:37: warning: ?: using integer constants
in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
** Affects: qemu
Importance:
On Wed, Sep 21, 2016 at 12:27:26PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> tests/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index b4a9cfc..24ac6cf 100644
> --- a/tests/.gitignore
> +++
On Wed, Sep 21, 2016 at 12:27:19PM +0800, Fam Zheng wrote:
> The uuid generation doesn't return error, so update the function
> signature and calling code accordingly.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: Eric Blake
> Reviewed-by: Jeff Cody
On Wed, 2016-09-21 at 13:18 +1000, David Gibson wrote:
> > There are actually a couple of places where I agree with the style
> > change, so I'll include that in a futher post after more useful
> review
> > has been posted (seriously, stylebots are just infuriating).
>
> So.. as irritating as you
Fam Zheng writes:
> On Wed, 09/21 08:50, Alex Bennée wrote:
>>
>> Fam Zheng writes:
>>
>> > On Tue, 09/20 14:56, Alex Bennée wrote:
>> >> This re-factors the docker makefile to include a docker-run target which
>> >> can be controlled entirely from environment
On Wed, Sep 21, 2016 at 11:57:05AM +0200, Michael Walle wrote:
> Only the POWER[789] CPUs should have the ARCH_206 bit set. This is what the
> linux kernel does. I guess this was also the intention of commit 0e019746.
> We have to make sure all *206 bits are set.
>
> Before this patch, the flags
On Wed, Sep 21, 2016 at 11:42:15AM +0200, Thomas Huth wrote:
> QEMU currently refuses to start with KVM-PR and only prints out
>
> qemu: fatal: Unknown MMU model 851972
>
> when being started there. This is because commit 4322e8ced5aaac719
> ("ppc: Fix 64K pages support in full emulation")
When qemu is being killed, its last words are:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from
pid 11180
That's nice, but what process is 11180? What if I told you we can
do better:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from
pid
Hi,
What's the procedure to update / who can update QEMU's dtc mirror
git://git.qemu.org/dtc.git which is used as submodule?
There's a patch series relying on the dtc v1.4.2 tag:
https://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg01815.html
but the dtc mirror is outdated and that tag is
On Wed, Sep 21, 2016 at 11:49:21AM +0800, Fam Zheng wrote:
> Put the list of package names in an environment, and output their
> package names to the target file in the end.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/fedora.docker | 14 --
> 1
On Wed, Sep 21, 2016 at 11:49:23AM +0800, Fam Zheng wrote:
> Now that 23 is becoming an "old" release with 24 available. Fedora has a
> quick release cycle, so use latest to follow more closely.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/dockerfiles/fedora.docker | 2 +-
On Wed, Sep 21, 2016 at 12:27:20PM +0800, Fam Zheng wrote:
> crypto now uses built-in uuid implementation, so this check is not
> needed.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: Eric Blake
> Reviewed-by: Jeff Cody
> ---
>
On Wed, Sep 21, 2016 at 11:49:28AM +0800, Fam Zheng wrote:
> This is the last command to run (unless DEBUG), make it 'exec' to
> simplify the process tree.
>
> Signed-off-by: Fam Zheng
> ---
> tests/docker/run | 15 +--
> 1 file changed, 9 insertions(+), 6
On Wed, Sep 21, 2016 at 11:49:27AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> tests/docker/docker.py | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index b85c165..552608e 100755
>
On Wed, Sep 21, 2016 at 01:20:57PM +1000, David Gibson wrote:
> On Tue, Aug 30, 2016 at 01:02:47AM +, Nathan Whitehorn wrote:
> > These are mandatory per PAPR and available on Linux 4.3 and newer kernels.
> > The calls in question are required to run FreeBSD guests with reasonable
> >
Some getters already set *obj argument to NULL early, let's do this for
all for consistent behaviour in case of errors.
Signed-off-by: Marc-André Lureau
---
qapi/qmp-input-visitor.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
Am 20.09.2016 um 20:01 hat Eric Blake geschrieben:
> On 09/20/2016 06:38 AM, Kevin Wolf wrote:
> > In order to remove the necessity to use BlockBackend names in the external
> > API,
> > we already converted all block layer QMP commands on the node level to
> > accept
> > node names instead of
> On 21 Sep 2016, at 11:07, Daniel P. Berrange wrote:
>
> On Wed, Sep 21, 2016 at 10:00:23AM +, Felipe Franciosi wrote:
>>
>>> On 21 Sep 2016, at 07:24, Markus Armbruster wrote:
>>>
>>> "Pavel Dovgalyuk" writes:
>>>
>
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474391326-871-1-git-send-email-fel...@nutanix.com
Subject: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
=== TEST SCRIPT BEGIN ===
#!/bin/bash
The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e:
build-sys: fix make install regression (2016-09-20 11:32:43 +0100)
are available in the git repository at:
git://github.com/otubo/qemu.git tags/pull-seccomp-20160921
for you to fetch changes up
getrusage is used in a number of places throughout the qemu codebase
(notably, in crypto/pbkdf.c). Without this syscall being whitelisted,
qemu ends up getting killed by the kernel whenever you try to connect to
a VNC console.
Signed-off-by: Brian Rak
Acked-by: Eduardo
This is a small helper that tries to fetch binary name for given
PID.
Signed-off-by: Michal Privoznik
---
include/qemu/osdep.h | 10 ++
util/oslib-posix.c | 37 +
util/oslib-win32.c | 7 +++
3 files changed, 54
v2 of:
http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html
The checkpatch.pl shows the following error for 1/2:
ERROR: architecture specific defines should be avoided
#63: FILE: util/oslib-posix.c:441:
+#if defined(__FreeBSD__)
But I guess we should ignore the error,
On Wed, 21 Sep 2016 12:22:25 +0200
Pradeep Jagadeesh wrote:
> Hi Greg,
>
> Thanks for having a look at patchset.
> See the replies below.
>
> > On Fri, 16 Sep 2016 04:33:36 -0400
> > Pradeep Jagadeesh wrote:
> >
> >> Uses throttling
Actually, I just noticed Pavel is in the middle of submitting a "replay
additions" series (currently at v4).
Pavel: is this something you can address as part of that series?
Thanks,
Felipe
> On 21 Sep 2016, at 11:12, Felipe Franciosi wrote:
>
>
>> On 21 Sep 2016, at
With this patch, blockdev-add always works on a node level, i.e. it
creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the
'device' option any more, but 'node-name' becomes mandatory.
Signed-off-by: Kevin Wolf
---
blockdev.c| 124
On 09/21/2016 02:53 AM, Andrew Jones wrote:
> On Tue, Sep 20, 2016 at 10:33:53PM -0400, Wei Huang wrote:
>> This patch adds a pmu=[on/off] option to enable/disable vPMU support
>> in guest vCPU. This option is only available for cortex-a57/cortex-53/
>> host under both TCG and KVM modes, but
Allow customization of the start and stop of ioeventfd. This will
allow direct start of dataplane without passing through the default
ioeventfd handlers, which in turn allows using the dataplane logic
instead of virtio_add_queue_aio. It will also enable some code
simplification, because the sole
On Wed, 21 Sep 2016 06:35:04 -0700 (PDT)
no-re...@patchew.org wrote:
> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
>
Heh... of course patchew doesn't know
On Wed 21 Sep 2016 12:36:28 PM CEST, Marc-André Lureau wrote:
> Some getters already set *obj argument to NULL early, let's do this for
> all for consistent behaviour in case of errors.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Alberto Garcia
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/141 | 24 ++--
tests/qemu-iotests/141.out | 24
2 files
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/071 | 8
1 file changed, 4 insertions(+), 4
Even for nodes that have a BlockBackend attached, bdrv_get_parent_name()
can return NULL if the BB is anonymous (e.g. it belongs to a block job
or a device that was created with a drive= option).
Remove the information from the error message. The user probably knows
already why the node is still
This will be used to forbid iothread configuration when the
proxy does not allow using ioeventfd. To simplify the implementation,
change the direction of the ioeventfd_disabled callback too.
Signed-off-by: Paolo Bonzini
---
hw/s390x/virtio-ccw.c | 6 +++---
On Wed, Sep 21, 2016 at 08:35:41AM -0500, Wei Huang wrote:
> On 09/21/2016 02:53 AM, Andrew Jones wrote:
> > On Tue, Sep 20, 2016 at 10:33:53PM -0400, Wei Huang wrote:
[snip]
> >> +if (cpu->has_pmu == ON_OFF_AUTO_ON && !kvm_enabled()) {
> >> +cpu->has_pmu = ON_OFF_AUTO_OFF;
> >> +
On Wed, 09/21 15:44, Greg Kurz wrote:
> On Wed, 21 Sep 2016 06:35:04 -0700 (PDT)
> no-re...@patchew.org wrote:
>
> > Hi,
> >
> > Your series failed automatic build test. Please find the testing commands
> > and
> > their output below. If you have docker installed, you can probably
> >
On 09/21/2016 09:01 AM, Fam Zheng wrote:
> On Wed, 09/21 15:44, Greg Kurz wrote:
>> On Wed, 21 Sep 2016 06:35:04 -0700 (PDT)
>> no-re...@patchew.org wrote:
>>
>>> Hi,
>>>
>>> Your series failed automatic build test. Please find the testing commands
>>> and
>>> their output below. If you have
On Wed, Sep 21, 2016 at 03:29:26PM +1000, David Gibson wrote:
> Now that we allow CPU hot unplug on a few platforms, we can end up in a
> situation where we don't have a CPU with index 0. Or at least we could,
> if we didn't have code to explicitly prohibit unplug of CPU 0.
>
> Longer term we
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/117 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/081 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/041 | 71 +++---
1
This simplifies the code and removes the ioeventfd_set_disabled
callback.
Signed-off-by: Paolo Bonzini
---
hw/s390x/virtio-ccw.c | 11 +--
hw/s390x/virtio-ccw.h | 1 -
hw/virtio/virtio-bus.c | 4 ++--
hw/virtio/virtio-mmio.c| 13
This error is caused by a buggy guest: let's switch the device to the
broken state instead of terminating QEMU.
Signed-off-by: Greg Kurz
---
hw/scsi/virtio-scsi.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c
Override start_ioeventfd and stop_ioeventfd to start/stop the
whole dataplane logic. This has some positive side effects:
- no need anymore for virtio_add_queue_aio (i.e. a revert of
commit 0ff841f6d138904d514efa1d885bcaf54583852d)
- no need anymore to switch from generic ioeventfd handlers
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 147446363181.4880.18104448248886932114.stgit@bahia
Subject: [Qemu-devel] [PATCH 0/7] virtio: avoid
From: Prasad J Pandit
ColdFire Fast Ethernet Controller uses buffer descriptors to manage
data flow to/fro receive & transmit queues. While transmitting
packets, it could continue to read buffer descriptors if a buffer
descriptor has length of zero. Add check to avoid it.
From: Prasad J Pandit
i.MX Fast Ethernet Controller uses buffer descriptors to manage
data flow to/fro receive & transmit queues. While transmitting
packets, it could continue to read buffer descriptors if a buffer
descriptor has length of zero. Add check to avoid it.
On 09/21/2016 07:56 AM, Kevin Wolf wrote:
> Even for nodes that have a BlockBackend attached, bdrv_get_parent_name()
> can return NULL if the BB is anonymous (e.g. it belongs to a block job
> or a device that was created with a drive= option).
>
> Remove the information from the error message.
On Wed, 21 Sep 2016 15:14:00 +0200
Greg Kurz wrote:
> A broken guest may send a request with only non-empty out buffers
> or only non-empty in buffers, virtqueue_pop() will then return a
> VirtQueueElement with out_num == 0 or in_num == 0 respectively.
>
> All 9P requests are
> On 21 Sep 2016, at 14:55, Eric Blake wrote:
>
> On 09/21/2016 07:31 AM, Markus Armbruster wrote:
>>>
>>> If we want to ignore return value reliably, lets just pull in the
>>> ignore_value macro from gnulib which is known to work across GCC
>>> versions
>>>
>>>
>>> /*
Benjamin Herrenschmidt writes:
> On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote:
>>
>> > >
>> > > total: 428 errors, 73 warnings, 1950 lines checked
>> > >
>> > > Your patch has style problems, please review.If any of these
>> > > errors
>> > > are false
Add support for the virtio 1.0 "emergency write"
(VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest
debugging and might be used in cases where the guest crashes so badly
that it cannot use virtqueues.
Disabled for compatibility machines to avoid exposing a new feature to
This series is a follow up to Stefan's work to eradicate most calls to
exit() we currently have in the virtio code.
It addresses all exit() call sites in the blk, net and scsi device code,
where the error is about a missing or malformed in/out header sent by
the guest. They are converted to use
This error is caused by a buggy guest: let's switch the device to the
broken state instead of terminating QEMU.
Signed-off-by: Greg Kurz
---
hw/net/virtio-net.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
All these errors are caused by a buggy guest: let's switch the device to
the broken state instead of terminating QEMU.
Signed-off-by: Greg Kurz
---
hw/block/virtio-blk.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git
All these errors are caused by a buggy guest: let's switch the device to
the broken state and stop processing the request, instead of terminating
QEMU.
Signed-off-by: Greg Kurz
---
hw/scsi/virtio-scsi.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
1 - 100 of 385 matches
Mail list logo