Re: [Qemu-devel] [PATCH V8 1/6] oslib-posix: add helpers for stack alloc and free

Am 26.09.2016 um 16:43 hat Peter Lieven geschrieben: > Am 26.09.2016 um 15:44 schrieb Kevin Wolf: > >Am 26.09.2016 um 13:44 hat Peter Lieven geschrieben: > >>the allocated stack will be adjusted to the minimum supported stack size > >>by the OS and rounded up to be a multiple of the system

Re: [Qemu-devel] [PATCH 0/4] tests: enable ohci/uhci/xhci tests on PPC64

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474899049-12506-1-git-send-email-lviv...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] tests: enable ohci/uhci/xhci tests on PPC64 === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 05/18] target-riscv: Add Arithmetic instructions

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +#if defined(TARGET_RISCV64) +target_ulong helper_mulhsu(CPURISCVState *env, target_ulong arg1, + target_ulong arg2) +{ +int64_t a = arg1; +uint64_t b = arg2; +return (int64_t)((__int128_t)a * b >> 64); +}

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

* Chunguang Li (lichungu...@hust.edu.cn) wrote: > > > > > -原始邮件- > > 发件人: "Dr. David Alan Gilbert" > > 发送时间: 2016年9月26日 星期一 > > 收件人: "Chunguang Li" > > 抄送: qemu-devel@nongnu.org, amit.s...@redhat.com, pbonz...@redhat.com, > >

Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section

On 09/26/2016 05:39 AM, Thomas Huth wrote: On 26.09.2016 10:22, Kevin Wolf wrote: Am 23.09.2016 um 18:42 hat John Snow geschrieben: On 09/23/2016 12:09 PM, Thomas Huth wrote: The folder include/hw/ide/ belongs to the IDE section. Signed-off-by: Thomas Huth ---

Re: [Qemu-devel] [PATCH] arm-smmu: Fix bug when merging two 32 bit words to form 64 bit word

On Mon, Sep 26, 2016 at 01:52:22PM +, Paul Kennedy wrote: > From 7bf015d76a5b53cd061c91f91fea4427101b26fd Mon Sep 17 00:00:00 2001 > From: Paul Kennedy > Date: Mon, 26 Sep 2016 11:59:00 +0100 > Subject: [PATCH] arm-smmu: Fix bug when merging two 32 bit words to form

Re: [Qemu-devel] [PULL 23/36] cadence_gem: Add queue support

On Mon, Sep 26, 2016 at 4:01 AM, Paolo Bonzini wrote: > > > On 22/09/2016 19:22, Peter Maydell wrote: >> +case GEM_RECEIVE_Q1_PTR ... GEM_RECEIVE_Q15_PTR: >> +s->rx_desc_addr[offset - GEM_RECEIVE_Q1_PTR + 1] = val; >> +break; > > MAX_PRIORITY_QUEUES is

Re: [Qemu-devel] [PATCH 06/18] target-riscv: Add JALR, Branch Instructions

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: Signed-off-by: Sagar Karandikar --- target-riscv/translate.c | 107 +++ 1 file changed, 107 insertions(+) diff --git a/target-riscv/translate.c b/target-riscv/translate.c

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] ahci: fix ncq aiocb-related segfault

On 09/26/2016 12:10 PM, Stefan Hajnoczi wrote: On Thu, Sep 22, 2016 at 04:10:39PM -0400, John Snow wrote: Fix ncq_cb to prevent a segfault on sys_reset. John Snow (1): ahci: clear aiocb in ncq_cb hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 Maybe worth adding as a

Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

On Mon, Sep 26, 2016 at 08:54:52AM +0200, Auger Eric wrote: > Hi Edgar, Prem, > > On 25/09/2016 16:58, Edgar E. Iglesias wrote: > > On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote: > >> On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric wrote: > >> > >>> Hi Prem, >

Re: [Qemu-devel] [PATCH 01/18] target-riscv: Add RISC-V target stubs and Maintainer

On 09/26/2016 05:56 AM, Sagar Karandikar wrote: > Only files that live outside of target-riscv and hw/riscv, excluding > configure and default-configs changes. > > Signed-off-by: Sagar Karandikar > --- > +++ b/qapi-schema.json > @@ -832,7 +832,7 @@ > # Since: 2.6 >

[Qemu-devel] [PATCH v1 1/1] cadence_gem: Fix priority queue out of bounds access

There was an error with some of the register implementation assuming there are 16 priority queues supported when the IP only supports 8. This patch corrects the registers to only support 8 queues. Signed-off-by: Alistair Francis Reported-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH] iothread: check iothread->ctx before aio_context_unref to avoid assertion

On Mon, Sep 26, 2016 at 01:29:58PM +0800, Lin Ma wrote: > if iothread->ctx is set to NULL, aio_context_unref triggers the assertion: > g_source_unref: assertion 'source != NULL' failed. > The patch fixes it. > > Signed-off-by: Lin Ma > --- > iothread.c | 3 +++ > 1 file changed,

Re: [Qemu-devel] [PATCH v3 0/3] Add -blockdev command line option

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1474903676-5680-1-git-send-email-kw...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/3] Add -blockdev

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

On 09/23/2016 04:46 AM, David Gibson wrote: > On Thu, Sep 22, 2016 at 10:25:59AM +0200, Cédric Le Goater wrote: @@ -493,6 +525,8 @@ static void pnv_chip_power9_class_init(ObjectClass *klass, void *data) k->chip_cfam_id = 0x100d10498000ull; /* P9 Nimbus DD1.0 */

Re: [Qemu-devel] [PATCH v3 6/9] virtio-net: handle virtio_net_receive() errors

On Mon, Sep 26, 2016 at 10:34:40AM +0200, Greg Kurz wrote: > All these errors are caused by a buggy guest: let's switch the device to > the broken state instead of terminating QEMU. Also we detach the element > from the virtqueue and free it. > > Signed-off-by: Greg Kurz >

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

Am 26.09.2016 um 18:24 schrieb Paolo Bonzini: > On 26/09/2016 18:20, Andreas Färber wrote: >> Am 26.09.2016 um 18:17 schrieb Richard Henderson: >>> On 09/26/2016 05:20 AM, Paolo Bonzini wrote: On 26/09/2016 12:56, Sagar Karandikar wrote: > -cpu-qom.h merged into cpu.h Please

Re: [Qemu-devel] [PATCH v3 3/9] virtio-9p: handle handle_9p_output() error

On Mon, Sep 26, 2016 at 10:34:15AM +0200, Greg Kurz wrote: > A broken guest may send a request without providing buffers for the reply > or for the request itself, and virtqueue_pop() will return an element with > either in_num == 0 or out_num == 0. > > All 9P requests are expected to start with

Re: [Qemu-devel] [PATCH 02/18] target-riscv: Add RISC-V Target stubs inside target-riscv/

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +/* QEMU addressing/paging config */ +#define TARGET_PAGE_BITS 12 /* 4 KiB Pages */ +#if defined(TARGET_RISCV64) +#define TARGET_LONG_BITS 64 /* this defs TCGv as TCGv_i64 in tcg/tcg-op.h */ +#define TARGET_PHYS_ADDR_SPACE_BITS 50 +#define

Re: [Qemu-devel] [PATCH v2 3/7] block/qapi: Move 'aio' option to file driver

On 23.09.2016 16:32, Kevin Wolf wrote: > The option whether or not to use a native AIO interface really isn't a > generic option for all drivers, but only applies to the native file > protocols. This patch moves the option in blockdev-add to the > appropriate places (raw-posix and raw-win32). > >

Re: [Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8

On 26/09/2016 16:17, Felipe Franciosi wrote: > A typo introduced in f19661c8 prevents qemu from building when configured > with --enable-trace-backend=dtrace. > > Signed-off-by: Felipe Franciosi Reviewed-by: Laurent Vivier > --- >

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

Am 26.09.2016 um 18:17 schrieb Richard Henderson: > On 09/26/2016 05:20 AM, Paolo Bonzini wrote: >> On 26/09/2016 12:56, Sagar Karandikar wrote: >>> -cpu-qom.h merged into cpu.h >> >> Please follow the model of other targets. RISCVCPUClass and the >> RISCVCPU typedef should be in cpu-qom.h. > >

Re: [Qemu-devel] [PATCH v3 5/9] virtio-net: handle virtio_net_handle_ctrl() error

On Mon, Sep 26, 2016 at 10:34:32AM +0200, Greg Kurz wrote: > This error is caused by a buggy guest: let's switch the device to the > broken state instead of terminating QEMU. Also we detach the element > from the virtqueue and free it. > > Signed-off-by: Greg Kurz > --- > v3: -

Re: [Qemu-devel] [PATCH v2 0/7] block: Make more blockdev-add options work

On 23.09.2016 16:32, Kevin Wolf wrote: > This series moves a few more options from flags to the appropriate place. This > doesn't only result in cleaner code, but also allows using these options in > nested node definitions. > > After this series, bds_tree_init() is only a thin wrapper around

Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section

On 09/26/2016 05:39 AM, Thomas Huth wrote: On 26.09.2016 10:22, Kevin Wolf wrote: Am 23.09.2016 um 18:42 hat John Snow geschrieben: On 09/23/2016 12:09 PM, Thomas Huth wrote: The folder include/hw/ide/ belongs to the IDE section. Signed-off-by: Thomas Huth ---

[Qemu-devel] Virtio-net cli parameters

Hi All, I want to add couple of new cli options for the virtio-net driver and use them inside the virtio-net driver to throttle the packets. I did go through the code and did single stepping using the gdb, but still could not find the place where the virtio-net parameters are getting parsed and

Re: [Qemu-devel] top(1) utility implementation in QEMU

On Mon, Sep 26, 2016 at 07:14:33PM +0530, prashanth sunder wrote: > Hi All, > > Summary of the discussion and different approaches we had on IRC > regarding a top(1) tool in qemu > > Implement unique naming for all event loop resources. Sometimes a > string literal can be used but other times

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

> On 26 Sep 2016, at 14:54, Paolo Bonzini wrote: > > > Considering that NBD supports multiple outstanding requests, is it a big > deal to require one request per terabyte of storage? +1 Also I don't think we particularly want to make clearing the entire disk easy to do

Re: [Qemu-devel] [PATCH v3 0/3] Add -blockdev command line option

On 26.09.2016 17:27, Kevin Wolf wrote: > This series adds an option that is directly mapped to the blockdev-add QMP > command. It works more or less like -drive, except that it doesn't create a > BlockBackend (creating just a BDS without a BB is impossible with -drive) and > doesn't support legacy

Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: make some functions static

On Mon, Sep 26, 2016 at 10:34:05AM +0200, Greg Kurz wrote: > Some functions that were called from the dataplane code are now only used > locally: > > virtio_blk_init_request() > virtio_blk_handle_request() > virtio_blk_submit_multireq() > > since commit "03de2f527499 virtio-blk: do not use vring

[Qemu-devel] [PATCH 3/4] libqos: use generic qtest_shutdown()

Machine specific shutdown function can be registered by the machine specific qtest_XXX_boot() if needed. So we will not have to test twice the archicture (on boot and on shutdown) if the test can be run on several architectures. Signed-off-by: Laurent Vivier ---

Re: [Qemu-devel] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

Am 19.09.2016 um 22:39 hat Eric Blake geschrieben: > On 09/18/2016 11:37 PM, Denis V. Lunev wrote: > > On 09/19/2016 04:21 AM, Fam Zheng wrote: > >> On Thu, 09/15 19:34, Denis V. Lunev wrote: > >>> They should work very similar, covering same areas if backing store is > >>> shorter than the image.

Re: [Qemu-devel] [PATCH] tests: cleanup ptimer-test

On 26/09/2016 17:17, Dmitry Osipenko wrote: > On 26.09.2016 16:37, Paolo Bonzini wrote: >> 1) ptimer-test is not a qtest---it runs the ptimer.c code directly in the >> ptimer-test process >> >> 2) ptimer-test has its own stubs file, so there is no need to add more >> stubs to stubs/vmstate.c >>

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix error path in qmp_blockdev_change_medium()

On 26.09.2016 15:06, Kevin Wolf wrote: > Commit 00949bab incorrectly changed one instance of into errp while > touching the line. Change it back. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] ahci: fix ncq aiocb-related segfault

On Thu, Sep 22, 2016 at 04:10:39PM -0400, John Snow wrote: > Fix ncq_cb to prevent a segfault on sys_reset. > > John Snow (1): > ahci: clear aiocb in ncq_cb > > hw/ide/ahci.c | 1 + > 1 file changed, 1 insertion(+) > > -- > 2.7.4 Maybe worth adding as a clarification: The issue is when

Re: [Qemu-devel] [PATCH v2 4/5] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events

Stefan Hajnoczi writes: > On Thu, Sep 15, 2016 at 05:50:58PM +0200, Lluís Vilanova wrote: > In the subject line: > s/dinamically-disabled/dynamically/ >> for e in events: >> +# tracer without checks >> +out('', >> +'static inline void __nocheck__%(api)s(%(args)s)', >

Re: [Qemu-devel] [RFC PATCH v2 0/6] translate: [tcg] Generic translation framework

Lluís Vilanova writes: > This series proposes a generic (target-agnostic) instruction translation > framework. > It basically provides a generic main loop for instruction disassembly, which > calls target-specific functions when necessary. This generalization makes > inserting new code in the

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

On 26/09/2016 18:35, Andreas Färber wrote: > Am 26.09.2016 um 18:24 schrieb Paolo Bonzini: >> On 26/09/2016 18:20, Andreas Färber wrote: >>> Am 26.09.2016 um 18:17 schrieb Richard Henderson: On 09/26/2016 05:20 AM, Paolo Bonzini wrote: > On 26/09/2016 12:56, Sagar Karandikar wrote:

Re: [Qemu-devel] [PATCH 04/18] target-riscv: Add framework for instruction decode

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +/* THIS BUILDS 13 bit imm (implicit zero is tacked on here), also note that bit + #12 is obtained in a special way to get sign extension */ +#define GET_B_IMM(inst) ((int16_t)inst >> 25) & 0x3F) << 5)\ +

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64.

On 09/21/16 03:00, David Gibson wrote: On Wed, Sep 21, 2016 at 01:20:57PM +1000, David Gibson wrote: On Tue, Aug 30, 2016 at 01:02:47AM +, Nathan Whitehorn wrote: These are mandatory per PAPR and available on Linux 4.3 and newer kernels. The calls in question are required to run FreeBSD

[Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8

A typo introduced in f19661c8 prevents qemu from building when configured with --enable-trace-backend=dtrace. Signed-off-by: Felipe Franciosi --- hw/scsi/spapr_vscsi.c | 2 +- hw/scsi/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V8 1/6] oslib-posix: add helpers for stack alloc and free

Am 26.09.2016 um 15:44 schrieb Kevin Wolf: Am 26.09.2016 um 13:44 hat Peter Lieven geschrieben: the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

> -原始邮件- > 发件人: "Dr. David Alan Gilbert" > 发送时间: 2016年9月26日 星期一 > 收件人: "Chunguang Li" > 抄送: qemu-devel@nongnu.org, amit.s...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com, quint...@redhat.com > 主题: Re: [Qemu-devel] Migration

[Qemu-devel] [PATCH v3 1/3] block: Add '-blockdev' command line option

This is an option that is directly mapped to the blockdev-add QMP command. It works more or less like -drive, except that it doesn't create a BlockBackend and doesn't support legacy options. This patch adds minimal documentation, the next patches will improve it. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v3 0/3] Add -blockdev command line option

This series adds an option that is directly mapped to the blockdev-add QMP command. It works more or less like -drive, except that it doesn't create a BlockBackend (creating just a BDS without a BB is impossible with -drive) and doesn't support legacy options. Depends on Dan's "[PATCH v13 0/6]

[Qemu-devel] [PATCH v3 2/3] doc: Document generic -blockdev options

This adds documentation for the -blockdev options that apply to all nodes independent of the block driver used. All options that are shared by -blockdev and -drive are now explained in the section for -blockdev. The documentation of -drive mentions that all -blockdev options are accepted as well.

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

On 09/26/2016 05:20 AM, Paolo Bonzini wrote: On 26/09/2016 12:56, Sagar Karandikar wrote: -cpu-qom.h merged into cpu.h Please follow the model of other targets. RISCVCPUClass and the RISCVCPU typedef should be in cpu-qom.h. I thought we had this discussion before, and cpu-qom.h is sort

Re: [Qemu-devel] [PATCH v3 7/9] virtio-net: handle virtio_net_flush_tx() errors

On Mon, Sep 26, 2016 at 10:34:48AM +0200, Greg Kurz wrote: > All these errors are caused by a buggy guest: let's switch the device to > the broken state instead of terminating QEMU. Also we detach the element > from the virtqueue and free it. > > If this happens, virtio_net_flush_tx() also

Re: [Qemu-devel] [PATCH v3 9/9] virtio-scsi: handle virtio_scsi_set_config() error

On Mon, Sep 26, 2016 at 10:35:04AM +0200, Greg Kurz wrote: > This error is caused by a buggy guest: let's switch the device to the > broken state instead of terminating QEMU. > > Signed-off-by: Greg Kurz > --- > hw/scsi/virtio-scsi.c |5 +++-- > 1 file changed, 3

Re: [Qemu-devel] [PATCH] tests: cleanup ptimer-test

On 26.09.2016 16:37, Paolo Bonzini wrote: > 1) ptimer-test is not a qtest---it runs the ptimer.c code directly in the > ptimer-test process > > 2) ptimer-test has its own stubs file, so there is no need to add more > stubs to stubs/vmstate.c > Thank you for the correction. Don't know whether I

[Qemu-devel] [PATCH] libqos: fix qvring_init()

"vq->desc[i].addr" is a 64bit value, so write it with writeq(), not writew(). struct vring_desc { __virtio64 addr; __virtio32 len; __virtio16 flags; __virtio16 next; }; Signed-off-by: Laurent Vivier --- tests/libqos/virtio.c | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH v3 3/3] doc: Document driver-specific -blockdev options

This documents the driver-specific options for the raw, qcow2 and file block drivers for the man page. For everything else, we refer to the QAPI documentation. Signed-off-by: Kevin Wolf --- qemu-options.hx | 115 +++- 1 file

Re: [Qemu-devel] [PATCH v3 8/9] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error()

On Mon, Sep 26, 2016 at 10:34:56AM +0200, Greg Kurz wrote: > The virtio_scsi_bad_req() function is called when a guest sends a > request with missing or ill-sized headers. This generally happens > when the virtio_scsi_parse_req() function returns an error. > > With this patch,

Re: [Qemu-devel] [PATCH 03/18] target-riscv: Add initialization for translation

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: RISCVCPU *cpu_riscv_init(const char *cpu_model) { -return NULL; +RISCVCPU *cpu; +CPURISCVState *env; +const riscv_def_t *def; + +def = cpu_riscv_find_by_name(cpu_model); +if (!def) { +return NULL; +} +cpu =

Re: [Qemu-devel] [PATCH v3 2/3] qapi: auto generate enum value strings

On 09/26/2016 05:38 AM, Daniel P. Berrange wrote: > On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote: >> Automatically generate enum value strings that containing the acceptable >> values. >> (Borrowwed Daniel's code.) s/Borrowwed/Borrowed/ >> >> Signed-off-by: Lin Ma >>

[Qemu-devel] [PATCH v2 3/6] intc/slavio_intctl: implement InterruptStatsProvider interface

Signed-off-by: Hervé Poussineau --- hw/intc/slavio_intctl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index e82e893..a9acb64 100644 --- a/hw/intc/slavio_intctl.c +++

Re: [Qemu-devel] [PULL 00/27] Net patches

On 26 September 2016 at 01:59, Jason Wang wrote: > The following changes since commit 3b71ec8516bb50e9a743645bf139571de0b39f61: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-09-23 16:15:33 +0100) > > are available in the git

Re: [Qemu-devel] [PULL 00/28] Misc patches for 2016-09-26

On 26 September 2016 at 06:40, Paolo Bonzini wrote: > The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into > staging (2016-09-23 15:28:07 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474919934-21518-1-git-send-email-riku.voi...@linaro.org Subject: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

On 09/26/2016 07:46 AM, Vladimir Sementsov-Ogievskiy wrote: > This extension allows big requests for TRIM and WRITE_ZEROES through > special 'shift' parameter, which means that offset and length should be > shifted left by several bits. > > This is needed for efficient clearing large regions of

Re: [Qemu-devel] [PATCH 11/18] target-riscv: Add Double Precision Floating-Point Instructions

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +case OPC_RISC_FSGNJ_D: +/* also OPC_RISC_FSGNJN_D, OPC_RISC_FSGNJX_D */ +if (rm == 0x0) { +gen_helper_fsgnj_d(cpu_fpr[rd], cpu_env, cpu_fpr[rs1], + cpu_fpr[rs2]); +} else if (rm

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > I assume that if using Version 1 that the bit will be ignored > Therein lies a problem. If dpdk tweaks flags, updating it will break guest migration. One way is to require that users specify all flags fully when creating the

[Qemu-devel] [PATCH] tests: Test IPv6 and ppc64 in the PXE tester

The firmware of the pseries machine, SLOF, is able to load files via IPv6 networking, too. So to test both, network bootloading on ppc64 and IPv6 (via Slirp) , let's add some PXE tests for this environment, too. Since we can not use the normal x86 boot sector for network boot loading, we use a

Re: [Qemu-devel] [PATCH 07/18] target-riscv: Add Loads/Stores, FP Loads/Stores

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: Signed-off-by: Sagar Karandikar --- target-riscv/translate.c | 117 +++ 1 file changed, 117 insertions(+) diff --git a/target-riscv/translate.c b/target-riscv/translate.c

[Qemu-devel] [PATCH v2 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic

Hi, This patchset aims at genericizing the 'info irq' and 'info pic' HMP commands, so that it is available on all machines and can display details about more than one interrupt controller per machine. Patch 1 adds a new interface InterruptStatsProvider, which is used to: - gather statistics for

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

On 26 September 2016 at 12:58, wrote: > From: Riku Voipio > > Linux-user and bsd-user code needs lots of arch-specific ifdefs, > so disable the warning. > > Signed-off-by: Riku Voipio > --- > scripts/checkpatch.pl | 5

Re: [Qemu-devel] [PATCH 09/18] target-riscv: Add FMADD, FMSUB, FNMADD, FNMSUB Instructions,

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +/* convert RISC-V rounding mode to IEEE library numbers */ +unsigned int ieee_rm[] = { +float_round_nearest_even, +float_round_to_zero, +float_round_down, +float_round_up, +float_round_ties_away +}; + +/* obtain rm value to use

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

W dniu 26.09.2016 o 10:56, Cédric Le Goater pisze: On 09/26/2016 10:25 AM, KONRAD Frederic wrote: Le 24/09/2016 à 10:55, Edgar E. Iglesias a écrit : On Sat, Sep 24, 2016 at 10:25:39AM +0200, Cédric Le Goater wrote: On 09/23/2016 08:26 PM, mar.krzeminski wrote: Hi Cedric, W dniu

[Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

From: Riku Voipio Linux-user and bsd-user code needs lots of arch-specific ifdefs, so disable the warning. Signed-off-by: Riku Voipio --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PULL v2 00/19] virtio, pc: fixes and features

On 23 September 2016 at 15:04, Michael S. Tsirkin wrote: > The following changes since commit eaff9c4367ac3f7ac44f6c6f4cb7bcd4daa89af5: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160923' into > staging (2016-09-23 15:28:07 +0100) > > are available in the git

[Qemu-devel] [PATCH v2 2/6] intc/i8259: implement InterruptStatsProvider interface

Signed-off-by: Hervé Poussineau --- hw/intc/i8259.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index c2607a5..75c8d22 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -29,6 +29,7 @@

[Qemu-devel] [PATCH v2 4/6] intc/lm32_pic: implement InterruptStatsProvider interface

We have to change the vmstate version due to changes in statistics counters. Signed-off-by: Hervé Poussineau --- hw/intc/lm32_pic.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/hw/intc/lm32_pic.c b/hw/intc/lm32_pic.c

[Qemu-devel] [PATCH v2 5/6] intc: make HMP 'info irq' and 'info pic' commands use InterruptStatsProvider interface

Signed-off-by: Hervé Poussineau --- hmp-commands-info.hx | 12 - hmp.c | 65 ++ hmp.h | 2 ++ hw/intc/i8259.c| 36 - hw/intc/lm32_pic.c

Re: [Qemu-devel] [PATCH 10/18] target-riscv: Add Single Precision Floating-Point Instructions

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +uint64_t helper_fsgnj_s(CPURISCVState *env, uint64_t frs1, uint64_t frs2) +{ +frs1 = (frs1 & ~(uint32_t)INT32_MIN) | (frs2 & (uint32_t)INT32_MIN); +return frs1; +} + +uint64_t helper_fsgnjn_s(CPURISCVState *env, uint64_t frs1, uint64_t

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

On Mon, Sep 26, 2016 at 05:04:21PM +0200, Kevin Wolf wrote: > Am 19.09.2016 um 22:39 hat Eric Blake geschrieben: [...] > > I typically write this as: > > > > L2 <- L1 <- L0 > > > > (read "L2 backs L1, which in turn backs L0") with the active on the > > right. So I understand the confusion in

Re: [Qemu-devel] [PATCH 12/18] target-riscv: Add system instructions

On 09/26/2016 03:56 AM, Sagar Karandikar wrote: +void helper_fence_i(CPURISCVState *env) +{ +RISCVCPU *cpu = riscv_env_get_cpu(env); +CPUState *cs = CPU(cpu); +/* Flush QEMU's TLB */ +tlb_flush(cs, 1); +/* ARM port seems to not know if this is okay inside a TB + But we

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

On 09/26/2016 07:51 AM, Paolo Bonzini wrote: >> +- bit 3, `NBD_CMD_FLAG_SHIFT`; This flag is valid for `NBD_CMD_TRIM` and >> + `NBD_CMD_WRITE_ZEROES`. If this flag is set the server shifts request >> + *length* and *offset* left by N bits, where N is defined by >> `NBD_OPT_SHIFT` >> + option

[Qemu-devel] [PATCH v2 1/6] intc: add an interface to gather statistics/informations on interrupt controllers

This interface will be used by HMP commands 'info irq' and 'info pic'. Signed-off-by: Hervé Poussineau --- hw/intc/Makefile.objs | 1 + hw/intc/intc.c | 41 + include/hw/intc/intc.h | 30 ++ 3

Re: [Qemu-devel] [PATCH v3 8/9] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error()

On Mon, 26 Sep 2016 17:35:38 +0100 Stefan Hajnoczi wrote: > On Mon, Sep 26, 2016 at 10:34:56AM +0200, Greg Kurz wrote: > > The virtio_scsi_bad_req() function is called when a guest sends a > > request with missing or ill-sized headers. This generally happens > > when the

[Qemu-devel] [PATCH v2 6/6] intc: make HMP 'info irq' and 'info pic' commands available on all targets

Signed-off-by: Hervé Poussineau --- hmp-commands-info.hx | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 6a7c476..55d50c4 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -172,8 +172,6

Re: [Qemu-devel] [PATCH 06/16] cpus-common: move CPU list management to common code

Paolo Bonzini writes: > Add a mutex for the CPU list to system emulation, as it will be used to > manage safe work. Abstract manipulation of the CPU list in new functions > cpu_list_add and cpu_list_remove. > > Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v5 8/9] block: implement bdrv_recurse_is_first_non_filter for blkreplay

This patch adds bdrv_recurse_is_first_non_filter implementation for blkreplay driver. It allows creating snapshots when blkreplay is enabled. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |9 + 1 file changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH v5 9/9] integratorcp: adding vmstate for save/restore

From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk --- hw/arm/integratorcp.c | 62 + 1 file changed,

Re: [Qemu-devel] [PATCH v5 0/9] replay additions

On 26/09/2016 10:07, Pavel Dovgalyuk wrote: > This set of patches includes several fixes for replay and > adds network record/replay for network devices. It also makes possible > saving/restoring vmstate in replay mode. > > Record and replay for network interactions is performed with the

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

Le 24/09/2016 à 10:55, Edgar E. Iglesias a écrit : On Sat, Sep 24, 2016 at 10:25:39AM +0200, Cédric Le Goater wrote: On 09/23/2016 08:26 PM, mar.krzeminski wrote: Hi Cedric, W dniu 23.09.2016 o 10:28, Cédric Le Goater pisze: On 09/23/2016 10:17 AM, Peter Maydell wrote: On 23 September

[Qemu-devel] [PATCH v3 0/9] virtio: avoid inappropriate QEMU termination

Stefan Hajnoczi recently posted a patchset to avoid exit() when a virtio device enters invalid states: <1474473146-19337-1-git-send-email-stefa...@redhat.com> The above patchset provides the ability to deactivate a virtio device if it encounters an unrecoverable issue, with the introduction of a

Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray

Am 23.09.2016 um 21:38 hat John Snow geschrieben: > On 09/23/2016 11:35 AM, Max Reitz wrote: > >On 23.09.2016 03:45, John Snow wrote: > >> block/block-backend.c | 22 -- > >> block/io.c | 25 + > >> cpus.c

[Qemu-devel] [PATCH v3 1/9] virtio-9p: add parentheses to sizeof operator

Signed-off-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- v3: - added Cornelia's and Stefan's R-b tags --- hw/9pfs/virtio-9p-device.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v3 7/9] virtio-net: handle virtio_net_flush_tx() errors

All these errors are caused by a buggy guest: let's switch the device to the broken state instead of terminating QEMU. Also we detach the element from the virtqueue and free it. If this happens, virtio_net_flush_tx() also returns -EINVAL, so that all callers can stop processing the virtqueue

[Qemu-devel] [PULL 02/27] net: hmp_host_net_remove: Del the -net option of the removed host_net

From: Shmulik Ladkani Upon hmp_host_net_remove(), the appropriate -net client is deleted (according to the given vlan_id and device id), as well as the corresponsing hub port. However, the relevant '-net' option that was added by former hmp_host_net_add() call is

Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and little inprovement

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 26, 2016 4:15 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; f...@redhat.com; Wubin (H) > Subject: Re: [Qemu-devel] [PATCH v2 0/3] crypto: add ctr mode support and > little

[Qemu-devel] [PULL 17/27] net: limit allocation in nc_sendv_compat

From: Peter Lieven we only need to allocate enough memory to hold the packet. This might be less than NET_BUFSIZE. Additionally fail early if the packet is larger than NET_BUFSIZE. Signed-off-by: Peter Lieven Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

Hi Edgar, Prem, On 25/09/2016 16:58, Edgar E. Iglesias wrote: > On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote: >> On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric wrote: >> >>> Hi Prem, >>> >>> Missing commit message >>> Signed-off-by: Prem Mallappa

Re: [Qemu-devel] [PATCH] iothread: check iothread->ctx before aio_context_unref to avoid assertion

On 26/09/2016 07:29, Lin Ma wrote: > if iothread->ctx is set to NULL, aio_context_unref triggers the assertion: > g_source_unref: assertion 'source != NULL' failed. > The patch fixes it. > > Signed-off-by: Lin Ma > --- > iothread.c | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [Qemu-devel] [RFC/PATCH] migration: SMRAM dirty bitmap not fetched from kvm-kmod and not send to destination

On 25/09/2016 13:33, Herongguang (Stephen) wrote: > Tested-by: He Rongguang Thanks! Paolo

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

Paolo Bonzini writes: > On 24/09/2016 22:43, Richard Henderson wrote: I don't see that the cpu_list_lock protects the last two lines in any way. >>> >>> It does: >>> >>> qemu_mutex_lock(_cpu_list_lock); >> >> What I meant is that I don't see that the mutex

Re: [Qemu-devel] [PATCH v2 3/3] crypto: add mode check in qcrypto_cipher_new() for cipher-builtin

On Sat, Sep 24, 2016 at 10:10:00AM +0800, Gonglei wrote: > Signed-off-by: Gonglei > --- > crypto/cipher-builtin.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c > index fd59a9e..d710608 100644 > ---

Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section

Am 23.09.2016 um 18:42 hat John Snow geschrieben: > On 09/23/2016 12:09 PM, Thomas Huth wrote: > >The folder include/hw/ide/ belongs to the IDE section. > > > >Signed-off-by: Thomas Huth > >--- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git

Re: [Qemu-devel] [PATCH 12/16] cpus-common: remove redundant call to exclusive_idle()

Paolo Bonzini writes: > No need to call exclusive_idle() from cpu_exec_end since it is done > immediately afterwards in cpu_exec_start. Any exclusive section could > run as soon as cpu_exec_end leaves, because cpu->running is false and the > mutex is not taken, so the call

Re: [Qemu-devel] write_zeroes/trim on the whole disk

Am 24.09.2016 um 14:27 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 24.09.2016 15:06, Vladimir Sementsov-Ogievskiy wrote: > >On 24.09.2016 00:21, Wouter Verhelst wrote: > >>On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: > >>>My preference would be a new flag to the existing

  1   2   3   4   >