[Qemu-devel] [PATCH 0/2] Adding transport abstraction and iSER support

2016-10-09 Thread Roy Shterman
Introducing new transport abstraction, with additional support in iSER transport layer. Also adding new zero-copy API that is needed in iSER case. changes from v1: - Adding iser as an additional block driver changes from v2: - Splitting iser support and new API into two patches - Removing option

[Qemu-devel] [PATCH 1/2] block/iscsi: Introducing new zero-copy API

2016-10-09 Thread Roy Shterman
A new API to deploy zero-copy command submission. The new API takes I/O vectors list and number of I/O vectors to submit as input parameters when initiating the command. New API must be used if working with iSER transport option. Signed-off-by: Roy Shterman --- block/iscsi.c

[Qemu-devel] [PATCH 2/2] block/iscsi: Adding new iSER transport layer option

2016-10-09 Thread Roy Shterman
iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. In order to use the new iSER transport one need to have RDMA supported HW and to choose iser as the protocol name in Libiscsi URI. For now iSER memory buffers are

Re: [Qemu-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed

2016-10-09 Thread Emil Condrea
On Tue, Oct 4, 2016 at 11:06 AM, Paolo Bonzini wrote: > > > On 04/10/2016 08:43, Emil Condrea wrote: >> xen_be_frontend_changed -> xen_fe_frontend_changed > > This is not correct. The front-end is implemented in the guest domain, > while the back-end is implemented in the

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-09 Thread Michael S. Tsirkin
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove

Re: [Qemu-devel] [PATCH 1/4] target-ppc: implement vexts[bh]2w and vexts[bhw]2d

2016-10-09 Thread Richard Henderson
On 10/07/2016 01:57 PM, Nikunj A Dadhania wrote: +VEXT_SIGNED(vextsb2w, s32, UINT8_MAX, char, int32_t) +VEXT_SIGNED(vextsb2d, s64, UINT8_MAX, char, int64_t) char has target-dependent sign. Use int8_t. r~

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Michael S. Tsirkin
On Wed, Sep 28, 2016 at 10:28:48AM +0800, Yuanhan Liu wrote: > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 26, 2016

Re: [Qemu-devel] [PATCH v5 11/14] virtio-crypto: emulate virtio crypto as a legacy device by default

2016-10-09 Thread Michael S. Tsirkin
On Thu, Oct 06, 2016 at 07:36:44PM +0800, Gonglei wrote: > the scenario of virtio crypto device is mostly NFV, which require > the existing Guest can't need to do any changes to support virtio > crypto, so that they can easily migrate the existing network units > to VM. That's also a basic

Re: [Qemu-devel] [PATCH v5 11/14] virtio-crypto: emulate virtio crypto as a legacy device by default

2016-10-09 Thread Gonglei (Arei)
Hi Michael, Happy to listen to your voice :) > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, October 10, 2016 7:48 AM > Subject: Re: [PATCH v5 11/14] virtio-crypto: emulate virtio crypto as a legacy > device by default > > On Thu, Oct 06, 2016

Re: [Qemu-devel] [PATCH v9 08/11] vfio: vote the function 0 to do host bus reset when aer occurred

2016-10-09 Thread Cao jin
帆,昨天电话里面好像还有个点没清楚,这个点也在这个patch里,不知道我理解 的对不对,有空的时候请帮斧正下: (已经理解,对于uncorrectable error, driver里是会做reset link的,也就是 设置pci bridge的secondary bus reset的那个bit) On 07/19/2016 03:38 PM, Zhou Jie wrote: From: Chen Fan Due to all devices assigned to VM on the same way as

[Qemu-devel] [PATCH 2/2] macio: switch over to new byte-aligned DMA helpers

2016-10-09 Thread Mark Cave-Ayland
Now that the DMA helpers are byte-aligned they can be called directly from the macio routines rather than emulating byte-aligned accesses via multiple block-level accesses. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 213

[Qemu-devel] [PATCH 0/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-09 Thread Mark Cave-Ayland
This is a follow-up to the thread at https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01396.html which introduces an explicit alignment to the DMA helpers to facilitate conversion of the macio controller over to use the now byte-aligned DMA helpers. Patch 1 introduces an alignment

[Qemu-devel] [Bug 1631773] [NEW] hw/dma/pl080.c:354: possible typo ?

2016-10-09 Thread dcb
Public bug reported: hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected: s->conf & (0x2 | 0x2). Consider verifying it. Source code is if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) { Maybe better code if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) { **

Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main device is closed

2016-10-09 Thread Wen Congyang
At 2016/10/7 20:21, Paolo Bonzini wrote: Without this change, there is a race condition in tests/test-replication. Depending on how fast the failover job (active commit) runs, there is a chance of two bad things happening: 1) replication_done can be called after the secondary has been closed

[Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-09 Thread Mark Cave-Ayland
The hard-coded default alignment is BDRV_SECTOR_SIZE, however this is not necessarily the case for all platforms. Use this as the default alignment for all current callers. Signed-off-by: Mark Cave-Ayland --- dma-helpers.c| 20 +++-

Re: [Qemu-devel] [Qemu-block] [PATCH] block: failed qemu-img command should return non-zero exit code

2016-10-09 Thread Reda Sallahi
On Sun, Oct 09, 2016 at 05:17:27PM +0800, Xu Tian wrote: > If backing file can not open when do qemu-img rebase, var 'ret' not > assign a no-zero value, qemu-img process go out with exit code zero. > > Signed-off-by: Xu Tian > --- > qemu-img.c | 2 ++ > 1 file changed, 2

[Qemu-devel] [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address offset

2016-10-09 Thread Thorsten Kohfeldt
From: Thorsten Kohfeldt Date: Sat, 24 Sep 2016 20:43:20 +0200 Subject: [PATCH] vfio: Fix vfio_rtl8168_quirk_data_read address offset Introductory comment for rtl8168 VFIO MSI-X quirk states: At BAR2 offset 0x70 there is a dword data register, offset 0x74

Re: [Qemu-devel] [PATCH v3 3/8] intel_iommu: pass whole remapped addresses to apic

2016-10-09 Thread Michael S. Tsirkin
On Sat, Oct 08, 2016 at 01:24:55PM +0800, Peter Xu wrote: > On Tue, Oct 04, 2016 at 01:17:28PM +0200, Igor Mammedov wrote: > > On Fri, 30 Sep 2016 18:10:08 +0200 > > Radim Krčmář wrote: > > > > > The MMIO interface to APIC only allowed 8 bit addresses, which is not > > >

Re: [Qemu-devel] [PATCH v2] Avoid additional GET_FEATURES call on vhost-user

2016-10-09 Thread Michael S. Tsirkin
On Thu, Sep 22, 2016 at 01:13:41PM +0100, Felipe Franciosi wrote: > Vhost-user requires an early GET_FEATURES call to determine if the > slave supports protocol feature negotiation. An extra GET_FEATURES > call is made after vhost_backend_init() to actually set the device > features. > > This

Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-09 Thread Michael S. Tsirkin
On Thu, Oct 06, 2016 at 06:00:52PM +0200, Radim Krčmář wrote: > 2016-10-06 11:51-0300, Eduardo Habkost: > > On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Krčmář wrote: > >> Signed-off-by: Radim Krčmář > >> --- > >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c >

[Qemu-devel] [PATCH v5 03/35] exec: Avoid direct references to Int128 parts

2016-10-09 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- exec.c| 4 ++-- include/qemu/int128.h | 10 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index c8389f9..cc2997e 100644 ---

[Qemu-devel] [PATCH v5 00/35] cmpxchg-based emulation of atomics

2016-10-09 Thread Richard Henderson
Hopefully I've (re-)incorporated all of the commentary from v3 and v4. Please do double-check. r~ Alex Bennée (1): linux-user: enable parallel code generation on clone Emilio G. Cota (18): atomics: add atomic_xor atomics: add atomic_op_fetch variants target-i386: emulate LOCK'ed

[Qemu-devel] [PATCH v5 01/35] atomics: add atomic_xor

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" This paves the way for upcoming work. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-8-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v5 05/35] int128: Add int128_make128

2016-10-09 Thread Richard Henderson
Allows Int128 to be used more generally, rather than having to begin with 64-bit inputs and accumulate. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/int128.h | 20 +++- 1 file changed, 15 insertions(+), 5

[Qemu-devel] [PATCH v5 04/35] int128: Use __int128 if available

2016-10-09 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/int128.h | 135 +- tests/test-int128.c | 22 2 files changed, 145 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v5 15/35] tcg: Add CONFIG_ATOMIC64

2016-10-09 Thread Richard Henderson
Allow qemu to build on 32-bit hosts without 64-bit atomic ops. Even if we only allow 32-bit hosts to multi-thread emulate 32-bit guests, we still need some way to handle the 32-bit guest using a 64-bit atomic operation. Do so by dropping back to single-step. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v5 02/35] atomics: add atomic_op_fetch variants

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" This paves the way for upcoming work. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-9-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v5 14/35] tcg: Add atomic128 helpers

2016-10-09 Thread Richard Henderson
Force the use of cmpxchg16b on x86_64. Wikipedia suggests that only very old AMD64 (circa 2004) did not have this instruction. Further, it's required by Windows 8 so no new cpus will ever omit it. If we truely care about these, then we could check this at startup time and then avoid executing

[Qemu-devel] [PATCH v5 07/35] linux-user: enable parallel code generation on clone

2016-10-09 Thread Richard Henderson
From: Alex Bennée The variable parallel_cpus controls the generation of thread aware atomic code. We only need to set it once we clone our first thread. At this point any existing translations need to be thrown away. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v5 08/35] cputlb: Replace SHIFT with DATA_SIZE

2016-10-09 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 16 softmmu_template.h | 7 ++- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/cputlb.c b/cputlb.c index 3c99c34..5575b73 100644

[Qemu-devel] [PATCH v5 19/35] target-i386: emulate LOCK'ed INC using atomic helper

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Merge gen_inc_locked back into gen_inc to share cc update.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-14-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v5 23/35] target-i386: emulate LOCK'ed BTX ops using atomic helpers

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Avoid redundant qemu_ld in locked case. Fix previously unnoticed incorrect zero-extension of address in register-offset case.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-18-git-send-email-c...@braap.org>

[Qemu-devel] [PATCH v5 10/35] cputlb: Remove includes from softmmu_template.h

2016-10-09 Thread Richard Henderson
We already include exec/address-spaces.h and exec/memory.h in cputlb.c; the include of qemu/timer.h appears to be a fossil. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- softmmu_template.h | 4 1 file changed, 4 deletions(-) diff

[Qemu-devel] [PATCH v5 22/35] target-i386: emulate LOCK'ed XADD using atomic helper

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Move load of reg value to common location.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-17-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 15

[Qemu-devel] [PATCH v5 11/35] cputlb: Move most of iotlb code out of line

2016-10-09 Thread Richard Henderson
Saves 2k code size off of a cold path. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 37 + softmmu_template.h | 52 ++-- 2 files

[Qemu-devel] [PATCH v5 31/35] linux-user: remove handling of ARM's EXCP_STREX

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-29-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v5 12/35] cputlb: Tidy some macros

2016-10-09 Thread Richard Henderson
TGT_LE and TGT_BE are not size dependent and do not need to be redefined. The others are no longer used at all. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 8 softmmu_template.h | 22

[Qemu-devel] [PATCH v5 16/35] tcg: Emit barriers with parallel_cpus

2016-10-09 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index cdd61d6..bb2bfee 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c

[Qemu-devel] [PATCH v5 34/35] target-alpha: Introduce MMU_PHYS_IDX

2016-10-09 Thread Richard Henderson
Rather than using helpers for physical accesses, use a mmu index. The primary cleanup is with store-conditional on physical addresses. Signed-off-by: Richard Henderson --- target-alpha/cpu.h| 18 +--- target-alpha/helper.c | 8 ++ target-alpha/helper.h

[Qemu-devel] [PATCH v5 32/35] linux-user: remove handling of aarch64's EXCP_STREX

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-30-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v5 09/35] cputlb: Move probe_write out of softmmu_template.h

2016-10-09 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- cputlb.c | 21 + softmmu_template.h | 23 --- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/cputlb.c b/cputlb.c index

[Qemu-devel] [PATCH v5 17/35] target-i386: emulate LOCK'ed cmpxchg using cmpxchg helpers

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" The diff here is uglier than necessary. All this does is to turn FOO into: if (s->prefix & PREFIX_LOCK) { BAR } else { FOO } where FOO is the original implementation of an unlocked cmpxchg. [rth: Adjust unlocked cmpxchg to use movcond instead of

[Qemu-devel] [PATCH v5 35/35] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-10-09 Thread Richard Henderson
Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. However, portable parallel code is written assuming only cmpxchg which means that in practice this is a viable alternative. Signed-off-by: Richard Henderson --- linux-user/main.c|

[Qemu-devel] [PATCH v5 13/35] tcg: Add atomic helpers

2016-10-09 Thread Richard Henderson
Add all of cmpxchg, op_fetch, fetch_op, and xchg. Handle both endian-ness, and sizes up to 8. Handle expanding non-atomically, when emulating in serial. Signed-off-by: Richard Henderson --- Makefile.objs | 2 +- Makefile.target | 1 + atomic_template.h |

[Qemu-devel] [PATCH v5 18/35] target-i386: emulate LOCK'ed OP instructions using atomic helpers

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Eliminate some unnecessary temporaries.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-13-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 76

[Qemu-devel] [PATCH v5 20/35] target-i386: emulate LOCK'ed NOT using atomic helper

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Avoid qemu_load that's redundant with the atomic op.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-15-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 26

[Qemu-devel] [PATCH v5 21/35] target-i386: emulate LOCK'ed NEG using cmpxchg helper

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" [rth: Move redundant qemu_load out of cmpxchg loop.] Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-16-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 38

[Qemu-devel] [PATCH v5 24/35] target-i386: emulate XCHG using atomic helper

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-19-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-i386/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v5 25/35] target-i386: remove helper_lock()

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" It's been superseded by the atomic helpers. The use of the atomic helpers provides a significant performance and scalability improvement. Below is the result of running the atomic_add-test microbenchmark with: $ x86_64-linux-user/qemu-x86_64

[Qemu-devel] [PATCH v5 27/35] target-arm: Rearrange aa32 load and store functions

2016-10-09 Thread Richard Henderson
Stop specializing on TARGET_LONG_BITS == 32; unconditionally allocate a temp and expand with tcg_gen_extu_i32_tl. Split out gen_aa32_addr, gen_aa32_frob64, gen_aa32_ld_i32 and gen_aa32_st_i32 as separate interfaces. Reviewed-by: Alex Bennée Signed-off-by: Richard

[Qemu-devel] [PATCH v5 26/35] tests: add atomic_add-bench

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" With this microbenchmark we can measure the overhead of emulating atomic instructions with a configurable degree of contention. The benchmark spawns $n threads, each performing $o atomic ops (additions) in a loop. Each atomic operation is performed on a

[Qemu-devel] [PATCH v5 28/35] target-arm: emulate LL/SC using cmpxchg helpers

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. Portable parallel code, however, is written assuming only cmpxchg--and not LL/SC--is available. This means that in practice emulating LL/SC with cmpxchg is a viable

[Qemu-devel] [PATCH v5 30/35] target-arm: emulate aarch64's LL/SC using cmpxchg helpers

2016-10-09 Thread Richard Henderson
From: "Emilio G. Cota" Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. Portable parallel code, however, is written assuming only cmpxchg--and not LL/SC--is available. This means that in practice emulating LL/SC with cmpxchg is a viable

[Qemu-devel] [RFC QEMU PATCH 3/8] nvdimm acpi: do not use fw_cfg on Xen

2016-10-09 Thread Haozhong Zhang
No fw_cfg is created when QEMU is used as the device model of Xen. Signed-off-by: Haozhong Zhang --- Cc: Xiao Guangrong Cc: "Michael S. Tsirkin" Cc: Igor Mammedov --- hw/acpi/nvdimm.c | 7 +--

[Qemu-devel] [RFC QEMU PATCH 2/8] xen-hvm: add a function to copy ACPI to guest

2016-10-09 Thread Haozhong Zhang
xen_acpi_copy_to_guest() will be used later to copy NVDIMM ACPI to guest. Signed-off-by: Haozhong Zhang --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xensource.com --- include/hw/xen/xen.h | 6

[Qemu-devel] [RFC QEMU PATCH 0/8] Implement vNVDIMM for Xen HVM guest

2016-10-09 Thread Haozhong Zhang
Overview This RFC QEMU patch series along with corresponding patch series of Xen, Linux kernel and ndctl implements vNVDIMM for Xen HVM guests. DSM (and hence labels) and hotplug are not supported by this patch series and will be implemented later. Design and Implementation

[Qemu-devel] [RFC QEMU PATCH 1/8] nvdimm: do not initialize label_data if label_size is zero

2016-10-09 Thread Haozhong Zhang
When memory-backend-xen is used, the label_data pointer can not be got via memory_region_get_ram_ptr(). We will use other functions to get label_data once we introduce NVDIMM label support to Xen. Signed-off-by: Haozhong Zhang --- Cc: Xiao Guangrong

[Qemu-devel] [RFC QEMU PATCH 7/8] xen-hvm: create hotplug memory region for HVM guest

2016-10-09 Thread Haozhong Zhang
Reserve the address space after guest physical memory for the hotplug memory region which is used by the existing implementation to place NVDIMM devices. Signed-off-by: Haozhong Zhang --- Cc: "Michael S. Tsirkin" Cc: Igor Mammedov

Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container

2016-10-09 Thread Alexey Kardashevskiy
On 07/10/16 18:36, Auger Eric wrote: > Hi, > > On 07/10/2016 09:01, Markus Armbruster wrote: >> Eric Auger writes: >> >>> The error is currently simply reported in vfio_get_group. Don't >>> bother too much with the prefix which will be handled at upper level, >>> later on.

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Zhang Chen
On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the related info can be found in 'filename'

[Qemu-devel] [PULL 08/14] Add a 'name' parameter to qemu_thread_create

2016-10-09 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" If enabled, set the thread name at creation (on GNU systems with pthread_set_np) Fix up all the callers with a thread name Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin

[Qemu-devel] [PULL 06/33] tests: acpi: extend cphp testcase with numa check

2016-10-09 Thread Michael S. Tsirkin
From: Igor Mammedov so it would be possible to verify _PXM generation in DSDT and SRAT tables. Signed-off-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

[Qemu-devel] [PULL 07/14] Add 'debug-threads' suboption to --name

2016-10-09 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Add flag storage to qemu-thread-* to store the namethreads flag Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- include/qemu/thread.h

[Qemu-devel] [PATCH for-2.5] iotests: drop thread spun work-around

2016-10-09 Thread Michael S. Tsirkin
We've disabled the warning, there should be no need for test to work around it. Signed-off-by: Michael S. Tsirkin --- This is on top of main-loop: suppress warnings under qtest I just tested this by running make check. Is this enough? tests/qemu-iotests/common.filter | 1

[Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-09 Thread Michael S. Tsirkin
The following changes since commit 48f592118ab42f83a1a7561c4bfd2b72a100f241: bsd-user: fix FreeBSD build after d148d90e (2016-10-07 15:17:53 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 27/33] virtio-input: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/input/virtio-input.c | 23

[Qemu-devel] [PULL 10/33] virtio-serial: add missing virtio_detach_element() call

2016-10-09 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Ports enter a "throttled" state when writing to the chardev would block. The current output VirtQueueElement is kept around until the chardev becomes writable again. There are several places in the virtio-serial lifecycle where the VirtQueueElement

[Qemu-devel] [PULL 28/33] virtio-scsi: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/scsi/virtio-scsi.c | 28

[Qemu-devel] [PULL 07/33] tests: acpi tables expected blobs update

2016-10-09 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT.cphp | Bin 6435 -> 6471 bytes tests/acpi-test-data/pc/SRAT.cphp |

[Qemu-devel] [PULL 17/33] virtio-net: handle virtio_net_flush_tx() errors

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz All these errors are caused by a buggy guest: let's switch the device to the broken state instead of terminating QEMU. Also we detach the element from the virtqueue and free it. If this happens, virtio_net_flush_tx() also returns -EINVAL, so that all callers can

[Qemu-devel] [PULL 25/33] virtio-serial: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/char/virtio-serial-bus.c | 18

[Qemu-devel] [PULL 30/33] virtio-rng: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 21 +

[Qemu-devel] [PULL 26/33] virtio-gpu: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. The device virtio-gpu is special because it actually does not adhere to the virtio migration schema, because device state is last. Signed-off-by: Halil Pasic Reviewed-by: Michael S.

[Qemu-devel] [PULL 12/33] virtio-blk: make some functions static

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz Some functions that were called from the dataplane code are now only used locally: virtio_blk_init_request() virtio_blk_handle_request() virtio_blk_submit_multireq() since commit "03de2f527499 virtio-blk: do not use vring in dataplane", and

[Qemu-devel] [Qemu-block][PATCH] qemu-img: fix failed qemu-img command return zero exit code defeat

2016-10-09 Thread Xu Tian
If backing file can not open when do image rebase, flag 'ret' not assign a non-zero value, then qemu-img process exit with code zero. Assign value '-1' to flag 'ret' after report error message to fix this defeat. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1383012 Signed-off-by: Xu Tian

[Qemu-devel] [PATCH v12 0/2] virtio-crypto: virtio crypto device specification

2016-10-09 Thread Gonglei
This is the specification about a new virtio crypto device. You can get the source code from the below website: [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04132.html [PATCH v4 00/13] virtio-crypto:

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 12:05:31PM +0800, Yuanhan Liu wrote: > On Fri, Sep 30, 2016 at 10:16:43PM +0300, Michael S. Tsirkin wrote: > > > > And the same is done is done in DPDK: > > > > > > > > static inline int __attribute__((always_inline)) > > > > copy_desc_to_mbuf(struct virtio_net *dev,

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 07:17:06AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 10, 2016 at 12:05:31PM +0800, Yuanhan Liu wrote: > > On Fri, Sep 30, 2016 at 10:16:43PM +0300, Michael S. Tsirkin wrote: > > > > > And the same is done is done in DPDK: > > > > > > > > > > static inline int

Re: [Qemu-devel] [RFC 1/4] spapr_pci: Delegate placement of PCI host bridges to machine type

2016-10-09 Thread David Gibson
On Mon, Oct 10, 2016 at 12:04:29PM +1100, Alexey Kardashevskiy wrote: > On 07/10/16 20:17, David Gibson wrote: > > On Fri, Oct 07, 2016 at 04:34:59PM +1100, Alexey Kardashevskiy wrote: > >> On 07/10/16 16:10, David Gibson wrote: > >>> On Fri, Oct 07, 2016 at 02:57:43PM +1100, Alexey Kardashevskiy

[Qemu-devel] block/nfs: Fine grained runtime options in nfs

2016-10-09 Thread Ashijeet Acharya
Hi all, I was working on trying to add blockdev-add compatibility for the nfs block driver but before that runtime options need to be separated into various options rather than just a simple "filename" option. I have added the following until now: a) host b) port (not sure about this one, do we

[Qemu-devel] [PULL 09/16] Add a 'name' parameter to qemu_thread_create

2016-10-09 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" If enabled, set the thread name at creation (on GNU systems with pthread_set_np) Fix up all the callers with a thread name Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin

[Qemu-devel] [PULL 03/33] virtio-serial: enable virtio console emergency write feature

2016-10-09 Thread Michael S. Tsirkin
From: Sascha Silbe Add support for enabling the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. The previous patch introduced the plumbing required for this; now we expose the virtio feature to the guest. The feature is disabled for compatibility

[Qemu-devel] [PULL for-2.0 1/3] Detect pthread_setname_np at configure time

2016-10-09 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Warn if no way of setting thread name is available. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- configure

[Qemu-devel] [PULL 13/33] virtio-9p: handle handle_9p_output() error

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz A broken guest may send a request without providing buffers for the reply or for the request itself, and virtqueue_pop() will return an element with either in_num == 0 or out_num == 0. All 9P requests are expected to start with the following 7-byte header:

[Qemu-devel] [PULL 18/33] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error()

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz The virtio_scsi_bad_req() function is called when a guest sends a request with missing or ill-sized headers. This generally happens when the virtio_scsi_parse_req() function returns an error. With this patch, virtio_scsi_bad_req() will mark the device as broken,

[Qemu-devel] [PULL 04/33] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

2016-10-09 Thread Michael S. Tsirkin
From: Igor Mammedov Replace repeated pattern for (i = 0; i < nb_numa_nodes; i++) { if (test_bit(idx, numa_info[i].node_cpu)) { ... break; with a helper function to lookup numa node index for cpu. Suggested-by: Michael S. Tsirkin

[Qemu-devel] [PULL 32/33] virtio: cleanup VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Now all the usages of the old version of VMSTATE_VIRTIO_DEVICE are gone, so we can get rid of the conditionals, and the old macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL 24/33] virtio-9p: convert VMSTATE_VIRTIO_DEVICE

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/9pfs/virtio-9p-device.c | 17 +++--

[Qemu-devel] [PULL 33/33] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE

2016-10-09 Thread Michael S. Tsirkin
From: Feng Wu The Trigger Mode field of IOAPIC must match the Trigger Mode in the IRTE according to VT-d Spec 5.1.5.1. Signed-off-by: Feng Wu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by:

[Qemu-devel] [PULL 14/33] virtio-blk: handle virtio_blk_handle_request() errors

2016-10-09 Thread Michael S. Tsirkin
From: Greg Kurz All these errors are caused by a buggy guest: QEMU should not exit. With this patch, if virtio_blk_handle_request() detects a buggy request, it marks the device as broken and returns an error to the caller so it takes appropriate action. In the case of

[Qemu-devel] [PULL 21/33] virtio: prepare change VMSTATE_VIRTIO_DEVICE macro

2016-10-09 Thread Michael S. Tsirkin
From: Halil Pasic In most cases the functions passed to VMSTATE_VIRTIO_DEVICE only call the virtio_load and virtio_save wrappers. Some include some pre- and post- massaging too. The massaging is better expressed as such in the VMStateDescription. Let us prepare for

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Zhang Chen
On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 11:03:33AM +0800, Yuanhan Liu wrote: > On Mon, Oct 10, 2016 at 02:20:22AM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2016 at 10:28:48AM +0800, Yuanhan Liu wrote: > > > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Sep 27, 2016

[Qemu-devel] [PATCH v12 2/2] virtio-crypto: Add conformance clauses

2016-10-09 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..3bde4b6 100644 ---

[Qemu-devel] [PATCH v12 1/2] virtio-crypto: Add virtio crypto device specification

2016-10-09 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). Currently, the virtio crypto device provides the following crypto services: CIPHER, MAC, HASH, and AEAD. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. VIRTIO-153 Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 06:46:44AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 10, 2016 at 11:37:44AM +0800, Yuanhan Liu wrote: > > On Thu, Sep 29, 2016 at 11:21:48PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Sep 29, 2016 at 10:05:22PM +0200, Maxime Coquelin wrote: > > > > > > > > > > >

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Hailiang Zhang
Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-09 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 04:16:19AM +, Wang, Zhihong wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Monday, October 10, 2016 11:59 AM > > To: Michael S. Tsirkin > > Cc: Maxime Coquelin

Re: [Qemu-devel] [PATCH 2/4] target-ppc: implement vnegw/d instructions

2016-10-09 Thread Nikunj A Dadhania
Richard Henderson writes: > On 10/07/2016 01:57 PM, Nikunj A Dadhania wrote: >> +r->element[i] = (~(b->element[i]) + 1) & mask; \ > > Any reason you're not writing this as a proper negate? No particular reason, I was just trying to mimic the pseudo code in

Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init()

2016-10-09 Thread David Gibson
On Fri, Oct 07, 2016 at 12:10:07PM +0200, Greg Kurz wrote: > On Fri, 7 Oct 2016 10:39:09 +0100 > Peter Maydell wrote: > > > On 7 October 2016 at 00:55, David Gibson > > wrote: > > > It is an improvement. But I still think if we're relying

  1   2   >