Re: [Qemu-devel] [PATCH 4/8] tests: Better handle legacy IO addresses in tco-test

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 05:14:04PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 12:52, David Gibson wrote: > > tco_test uses the libqos PCI code to access the device. This makes perfect > > sense for the PCI config space accesses. However for IO, rather than the > > usual PCI approach of

Re: [Qemu-devel] [PATCH v1 2/3] target-ppc: implement vnegw/d instructions

2016-10-18 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Wed, Oct 12, 2016 at 10:38:52AM +0530, Nikunj A Dadhania wrote: >> Vector Integer Negate Instructions: >> >> vnegw: Vector Negate Word >> vnegd: Vector Negate Doubleword >> >> Signed-off-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH 2/7] nios2: Add architecture emulation support

2016-10-18 Thread Marek Vasut
On 10/19/2016 03:24 AM, Richard Henderson wrote: > On 10/18/2016 03:05 PM, Marek Vasut wrote: Thanks, I hope this is fixed now, although I mostly special-case the R_ZERO handling throughout the code. Any writes to R_ZERO are now ignored and any usage is converted to mov/movi

[Qemu-devel] [PATCH] Added iopmem device emulation

2016-10-18 Thread Logan Gunthorpe
An iopmem device is one which exposes volatile or non-volatile memory mapped directly to a BAR region. One purpose is to provide buffers to do peer to peer transfers on the bus. As such this device uses QEMU's drive backing store to simulate non-volatile memory and provides through a mapped BAR

[Qemu-devel] [Bug 1634726] [NEW] qemu "make test" fails in iov.c with "undefined reference" on aarch64 on Ubuntu 16.04

2016-10-18 Thread Edward Vielmetti
Public bug reported: I'm building the master tree on a multicore ARMv8 machine running Ubuntu 16.04. The build worked just fine, using the simple directions in the README file and "make -j 64" to do the build. Next, I did "make test", and got this: emv@armv8hello:~/src/qemu/qemu/build$ make

Re: [Qemu-devel] [virtio-dev] RE: [PATCH v7 09/12] virtio-crypto: add data queue processing handler

2016-10-18 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Tuesday, October 18, 2016 6:09 PM > Subject: Re: [virtio-dev] RE: [Qemu-devel] [PATCH v7 09/12] virtio-crypto: add > data queue processing handler > > On Mon, Oct 17, 2016 at 06:29:42AM +, Gonglei

Re: [Qemu-devel] [GIT PULL] pseries: Update SLOF firmware image to 20161019

2016-10-18 Thread David Gibson
On Wed, Oct 19, 2016 at 10:15:16AM +1100, Alexey Kardashevskiy wrote: > The following changes since commit bd56ff33ed174cbe825a3b9929399ca804ce0f27: > > pseries: Update SLOF firmware image to 20161019 (2016-10-19 10:05:26 +1100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 1/8] libqos: Give qvirtio_config_read*() consistent semantics

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 03:27:09PM +0200, Greg Kurz wrote: > On Tue, 18 Oct 2016 21:52:06 +1100 > David Gibson wrote: > > > The 'addr' parameter to qvirtio_config_read*() doesn't have a consistent > > meaning: when using the virtio-pci versions, it's a full PCI space

Re: [Qemu-devel] [PATCH 7/8] tests: Use qpci_mem{read, write} in ivshmem-test

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 06:14:09PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 12:52, David Gibson wrote: > > ivshmem implements a block of shared memory in a PCI BAR. Currently our > > test case accesses this using qtest_mem{read,write}. However, deducing > > the correct addresses for

Re: [Qemu-devel] [PATCH V3 2/7] nios2: Add architecture emulation support

2016-10-18 Thread Marek Vasut
On 10/19/2016 01:04 AM, Richard Henderson wrote: > On 10/18/2016 02:50 PM, Marek Vasut wrote: >> +/* Special R-Type instruction opcode */ >> +#define INSN_R_TYPE 0x3A >> + >> +/* I-Type instruction parsing */ >> +#define I_TYPE(instr, code) \ >> +struct {

Re: [Qemu-devel] [PATCH 2/8] libqos: Handle PCI IO de-multiplexing in common code

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 03:28:17PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 12:52, David Gibson wrote: > > The PCI IO space (aka PIO, aka legacy IO) and PCI memory space (aka MMIO) > > are distinct address spaces by the PCI spec (although parts of one might be > > aliased to parts of the

Re: [Qemu-devel] [PATCH v2 00/15] target-sparc improvements

2016-10-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1476844470-29763-1-git-send-email-...@twiddle.net Subject: [Qemu-devel] [PATCH v2 00/15] target-sparc improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] spapr_pci: advertise explicit numa IDs even when there's 1 node

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 03:50:23PM -0500, Michael Roth wrote: > With the addition of "numa_node" properties for PHBs we began > advertising NUMA affinity in cases where nb_numa_nodes > 1. > > Since the default on the guest side is to make no assumptions about > PHB NUMA affinity (defaulting to

Re: [Qemu-devel] [PATCH 3/8] libqos: Move BAR assignment to common code

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 05:00:08PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 12:52, David Gibson wrote: > > The PCI backends in libqos each supply an iomap() and iounmap() function > > which is used to set up a specified PCI BAR. But PCI BAR allocation takes > > place entirely within PCI

Re: [Qemu-devel] [PATCH v1 3/3] target-ppc: implement xxbr[qdwh] instruction

2016-10-18 Thread Nikunj A Dadhania
Richard Henderson writes: > On 10/12/2016 07:21 PM, David Gibson wrote: >>> +static void gen_bswap32x4(TCGv_i64 outh, TCGv_i64 outl, >>> + TCGv_i64 inh, TCGv_i64 inl) >>> +{ >>> +TCGv_i64 hi = tcg_temp_new_i64(); >>> +TCGv_i64 lo =

Re: [Qemu-devel] [PATCH v2 00/15] target-sparc improvements

2016-10-18 Thread Mark Cave-Ayland
On 19/10/16 03:34, Richard Henderson wrote: > The two main goals in this patch set are: > > * Make use of the new MO_ALIGN_* flags, to allow less use of >check_align, and support partially misaligned fp memory ops. > > * More cleanups for ASIs, in the end using the new atomic ops. > >

Re: [Qemu-devel] [PATCH 4/8] tests: Better handle legacy IO addresses in tco-test

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 06:28:26PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 17:14, Laurent Vivier wrote: > > > > > > On 18/10/2016 12:52, David Gibson wrote: > >> tco_test uses the libqos PCI code to access the device. This makes perfect > >> sense for the PCI config space accesses.

Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > The OpenBIOS NVRAM set-up is based on the layout defined in the CHRP > (Common Hardware Reference Platform) specification. This is the same > layout that is also used by the PAPR specification and thus by the SLOF > firmware of the

Re: [Qemu-devel] [PATCH 8/8] libqos: Change PCI accessors to take opaque BAR handle

2016-10-18 Thread David Gibson
On Tue, Oct 18, 2016 at 06:48:16PM +0200, Laurent Vivier wrote: > > > On 18/10/2016 12:52, David Gibson wrote: > > The usual use model for the libqos PCI functions is to map a specific PCI > > BAR using qpci_iomap() then pass the returned token into IO accessor > > functions. This, and the fact

[Qemu-devel] [PATCH V4 2/7] nios2: Add architecture emulation support

2016-10-18 Thread Marek Vasut
From: Chris Wulff Add support for emulating Altera NiosII R1 architecture into qemu. This patch is based on previous work by Chris Wulff from 2012 and updated to latest mainline QEMU. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da

Re: [Qemu-devel] [PULL 06/22] linux-user: Fix syslog() syscall support

2016-10-18 Thread Riku Voipio
On Mon, Oct 17, 2016 at 04:24:24PM +0300, riku.voi...@linaro.org wrote: > From: Aleksandar Markovic > > There are currently several problems related to syslog() support. > > For example, if the second argument "bufp" of target syslog() syscall > is NULL, the

[Qemu-devel] [PATCH v2 6/6] tests/vhost-user-bridge: use contrib/libvhost-user

2016-10-18 Thread Marc-André Lureau
Use the libvhost-user library. This ended up being a rather large patch that cannot be easily splitted, due to massive code move and API changes. Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 1177 +

[Qemu-devel] [PATCH v3 1/4] fdc: Add a floppy qbus

2016-10-18 Thread Kevin Wolf
This adds a qbus to the floppy controller that should contain the floppy drives eventually. At the moment it just exists and is empty. Signed-off-by: Kevin Wolf Reviewed-by: John Snow --- hw/block/fdc.c | 40 +++- 1 file

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-18 Thread Pino Toscano
On Tuesday, 18 October 2016 11:44:26 CEST Kevin Wolf wrote: > Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben: > > The 'obj' result of the visitor was not properly freed, like done in > > other places doing a similar job. > > --- > > block/qapi.c | 1 + > > 1 file changed, 1 insertion(+) > >

[Qemu-devel] [PATCH 4/8] tests: Better handle legacy IO addresses in tco-test

2016-10-18 Thread David Gibson
tco_test uses the libqos PCI code to access the device. This makes perfect sense for the PCI config space accesses. However for IO, rather than the usual PCI approach of mapping a PCI BAR, then accessing that, it instead uses the legacy approach of fixed, known addresses in PCI IO space. That

[Qemu-devel] [PATCH 2/8] libqos: Handle PCI IO de-multiplexing in common code

2016-10-18 Thread David Gibson
The PCI IO space (aka PIO, aka legacy IO) and PCI memory space (aka MMIO) are distinct address spaces by the PCI spec (although parts of one might be aliased to parts of the other in some cases). However, qpci_io_read*() and qpci_io_write*() can perform accesses to either space depending on

[Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.start broken

2016-10-18 Thread Halil Pasic
The handling of VMStateField.start is currently quite broken if VMS_ALLOC is present (that is for VMSTATE_VBUFFER_ALLOC_UINT32) but fortunately also quite underutilized -- nobody is using .start != 0. Let's prove with this patch that it's really broken (as a first step towards fixing things up).

Re: [Qemu-devel] [PATCH v3 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-18 Thread Igor Mammedov
On Mon, 17 Oct 2016 19:44:52 -0200 Eduardo Habkost wrote: > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote: > [...] > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx, > > MachineState *machine, > > /* The current AML generator can cover

[Qemu-devel] [PATCH v2 0/6] Start a contrib/libvhost-user

2016-10-18 Thread Marc-André Lureau
Hi vhost-user & virtio have tricky corners and evolve regularly. There isn't a reference code that would help you get started either. And the backends duplicate most of the effort. Furthermore, due to usage of ancillary data, shared memory, eventfd, atomics, it is not so simple to implement in

[Qemu-devel] CVE-2016-5403 results in a bug

2016-10-18 Thread yue
hi, all:     i apply this patch, https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33  .   but this patch always results in a bug(bug?).  a vm always exits

[Qemu-devel] is there a way to optimize vhost of virtio-net

2016-10-18 Thread yue
hi, jasowang: according to my test , the vm's network performance is just 20% of physical ethernet, the thread of vhost  easily eat up 100% cpu when under pressure. when using multi queue(two queues) the performance goes up by 50%, but it uses more threads. if we can come to a conclusion

Re: [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17

2016-10-18 Thread Peter Maydell
On 17 October 2016 at 18:51, Eduardo Habkost wrote: > The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2016-10-17 16:17:51 +0100) > > are available in the git

Re: [Qemu-devel] qemu master tests/vmstate prints "Failed to load simple/primitive:b_1" etc

2016-10-18 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Paolo Bonzini writes: > > > On 17/10/2016 21:15, Dr. David Alan Gilbert wrote: > >> * Peter Maydell (peter.mayd...@linaro.org) wrote: > >>> On 17 October 2016 at 19:51, Dr. David Alan Gilbert > >>>

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-18 Thread Daniel P. Berrange
On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's

Re: [Qemu-devel] [PATCH v2 3/4] sockets: add AF_VSOCK support

2016-10-18 Thread Stefan Hajnoczi
On Mon, Oct 17, 2016 at 09:25:46AM -0500, Eric Blake wrote: > On 10/16/2016 08:35 AM, Stefan Hajnoczi wrote: > > >>> + > >>> +if (sscanf(str, "%32[^:]:%32[^,]%n", cid, port, ) != 2) { > >> > >> This says stop at the first comma after the colon... > >> > >>> +error_setg(errp, "error

Re: [Qemu-devel] [Qemu-block] block/nfs: Fine grained runtime options in nfs

2016-10-18 Thread Peter Lieven
Am 17.10.2016 um 21:34 schrieb Ashijeet Acharya: On Tue, Oct 18, 2016 at 12:59 AM, Eric Blake wrote: On 10/17/2016 01:00 PM, Ashijeet Acharya wrote: One more relatively easy question though, will we include @port as an option in runtime_opts while converting NFS to use

Re: [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage

2016-10-18 Thread Peter Lieven
Am 12.10.2016 um 23:18 schrieb Michael R. Hines: Peter, Greetings from DigitalOcean. We're experiencing the same symptoms without this patch. We have, collectively, many gigabytes of un-planned-for RSS being used per-hypervisor that we would like to get rid of =). Without explicitly trying

[Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start

2016-10-18 Thread Halil Pasic
The member VMStateField.start was solely used to implement the partial data migration for VBUFFER data (basically provide migration for a sub-buffer). However the implementation of this feature is broken, but this goes unnoticed since the feature is not used at all. So what the series does is

[Qemu-devel] [PATCH 3/4] Revert "tests/test-vmstate.c: prove VMStateField.start broken"

2016-10-18 Thread Halil Pasic
This reverts the effect of the previous patch in the series as a preparation for getting rid of VMStateField.start. Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl --- tests/test-vmstate.c | 48

[Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2016-10-18 Thread T. Huth
OK, according to the last comments, the bug has been fixed somewhere with the last kernel or QEMU releases, so I'm closing this ticket now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v2 5/6] contrib: add libvhost-user

2016-10-18 Thread Marc-André Lureau
Add a library to help implementing vhost-user backend (or slave). Dealing with vhost-user as an application developper isn't so easy: you have all the trouble with any protocol: validation, unix ancillary data, shared memory, eventfd, logging, and on top of that you need to deal with virtio

[Qemu-devel] [PATCH v2 1/6] tests/vhost-user-bridge: remove false comment

2016-10-18 Thread Marc-André Lureau
dispatcher_remove() is in use. Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 775e031..e91279b 100644 --- a/tests/vhost-user-bridge.c +++

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: check divider against baud rate

2016-10-18 Thread Peter Maydell
On 18 October 2016 at 10:47, P J P wrote: > From: Prasad J Pandit > > The Cadence UART device emulator calculates speed by dividing the > baud rate by a divider. If this divider was to be zero or if baud > rate was to be lesser than the divider, it

Re: [Qemu-devel] [PATCH 15/18] block: only call aio_poll on the current thread's AioContext

2016-10-18 Thread Stefan Hajnoczi
On Mon, Oct 17, 2016 at 10:04:59AM +0200, Paolo Bonzini wrote: > > > On 16/10/2016 18:40, Stefan Hajnoczi wrote: > > > void bdrv_wakeup(BlockDriverState *bs) > > > { > > > +if (bs->wakeup) { > > > +aio_bh_schedule_oneshot(qemu_get_aio_context(), dummy_bh_cb, > > > NULL); > > > +

[Qemu-devel] [PATCH v3 3/4] fdc: Move qdev properties to FloppyDrive

2016-10-18 Thread Kevin Wolf
This makes the FloppyDrive qdev object actually useful: Now that it has all properties that don't belong to the controller, you can actually use '-device floppy' and get a working result. Command line semantics is consistent with CD-ROM drives: By default you get a single empty floppy drive. You

Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-18 Thread Igor Mammedov
On Tue, 11 Oct 2016 09:19:10 +1100 Alexey Kardashevskiy wrote: > Ping, anyone? I have a similar patch http://patchwork.ozlabs.org/patch/681709/ which bumps limit to 288 and does a little bit more so it wouldn't affect current users. After that's merged, I plan to get rid of this

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-18 Thread Markus Armbruster
Eric Blake writes: > On 10/17/2016 09:50 AM, Markus Armbruster wrote: >>> But even if I realised that QemuOpts support this syntax, I think we >>> would still have to use the dotted syntax because it's explicit about >>> the index and we need that because the list can contains

Re: [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start

2016-10-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20161018105724.26520-1-pa...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH 3/3] ppc/xics: change the icp_ routines API to use an 'ICPState *' argument

2016-10-18 Thread Cédric Le Goater
The routines : void icp_set_cppr(ICPState *icp, uint8_t cppr); void icp_set_mfrr(ICPState *icp, uint8_t mfrr); void icp_eoi(ICPState *icp, uint32_t xirr); now use one 'ICPState *icp' argument instead of a 'XICSState *' and a server arguments. The backlink on XICSState* is

[Qemu-devel] [PATCH 0/3] ppc/xics: interface cleanups

2016-10-18 Thread Cédric Le Goater
Hello, Here are a couple of changes removing duplicated code and modifying the remaining icp_ routines still using a 'XICSState *' as argument. Thanks, C. Cédric Le Goater (3): ppc/xics: add a xics_set_nr_servers common routine ppc/xics: add a XICSState backlink in ICPState ppc/xics:

[Qemu-devel] [v2] nvic: set pending status for not active interrupts

2016-10-18 Thread marcin.krzeminski
From: Marcin Krzeminski According to ARM DUI 0552A 4.2.10. NVIC set pending status also for disabled interrupts. This patch adds possibility to emulate this in Qemu. Signed-off-by: Marcin Krzeminski --- Changes for v2: - add a

[Qemu-devel] [Bug 1452742] Re: the option for vdagent communication needed for qxl scren resizing is not documented

2016-10-18 Thread T. Huth
To be able to include your patch, you've got to send it to the qemu- devel mailing list, with a proper Signed-off-by line. Please see http ://qemu-project.org/Contribute/SubmitAPatch#Submitting_your_Patches for details. -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 498039] Re: No copy/paste with VNC display with Windows guest

2016-10-18 Thread T. Huth
Right, this problem should be fixed with Spice, so I'm closing this ticket now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/498039

[Qemu-devel] [PATCH] char: cadence: check divider against baud rate

2016-10-18 Thread P J P
From: Prasad J Pandit The Cadence UART device emulator calculates speed by dividing the baud rate by a divider. If this divider was to be zero or if baud rate was to be lesser than the divider, it could lead to a divide by zero error. Add check to avoid it. Reported-by:

[Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives

2016-10-18 Thread Kevin Wolf
This tests the different supported methods to create floppy drives and how they interact. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/172 | 242 + tests/qemu-iotests/172.out | 1205 tests/qemu-iotests/group |

Re: [Qemu-devel] [PATCH v3 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-18 Thread Eduardo Habkost
On Tue, Oct 18, 2016 at 11:12:04AM +0200, Igor Mammedov wrote: > On Mon, 17 Oct 2016 19:44:52 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote: > > [...] > > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,

[Qemu-devel] [PATCH v2] qapi: fix memory leak in QmpOutputVisitor

2016-10-18 Thread Pino Toscano
qmp_output_start_struct() and qmp_output_start_list() create a new QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, where it is saved as 'value'. When freeing the iterator in qmp_output_free(), these values are never freed properly. The simple solution is to

[Qemu-devel] [PATCH 4/4] migration: drop unused VMStateField.start

2016-10-18 Thread Halil Pasic
The member VMStateField.start was solely used to implement the partial data migration for VBUFFER data (basically provide migration for a sub-buffer). However the implementation of this feature seems broken to me, but this goes unnoticed since the feature is not used at all. Instead of fixing it

Re: [Qemu-devel] [PULL 00/19] VFIO updates 2016-10-17

2016-10-18 Thread Peter Maydell
On 17 October 2016 at 20:51, Alex Williamson wrote: > The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2016-10-17 16:17:51 +0100) > > are available in the

[Qemu-devel] [PATCH v2] vl: exit qemu on guest panic if -no-shutdown is not set

2016-10-18 Thread Christian Borntraeger
For automated testing purposes it can be helpful to exit qemu (poweroff) when the guest panics. Make this the default unless -no-shutdown is specified. For internal-errors like errors from KVM_RUN the behaviour is not changed, in other words QEMU does not exit to allow debugging in the QEMU

[Qemu-devel] [PATCH 2/3] ppc/xics: add a XICSState backlink in ICPState

2016-10-18 Thread Cédric Le Goater
The link will be used to change the API of the icp_* routines which are still using an XICSState as an argument. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 1 + include/hw/ppc/xics.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/hw/intc/xics.c

[Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

2016-10-18 Thread Pino Toscano
qmp_output_start_struct() and qmp_output_start_list() create a new QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, where it is saved as 'value'. When freeing the iterator in qmp_output_free(), these values are never freed properly. The simple solution is to

[Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-18 Thread Pino Toscano
The 'obj' result of the visitor was not properly freed, like done in other places doing a similar job. --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi.c b/block/qapi.c index 6f947e3..50d3090 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -698,6 +698,7 @@ void

[Qemu-devel] [PATCH v2 3/6] tests/vhost-user-bridge: indicate peer disconnected

2016-10-18 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 19b0e94..97e45d8 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@

[Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: remove unnecessary dispatcher_remove

2016-10-18 Thread Marc-André Lureau
The call fd is not watched Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index e91279b..19b0e94 100644 --- a/tests/vhost-user-bridge.c +++

Re: [Qemu-devel] CVE-2016-5403 results in a bug

2016-10-18 Thread Stefan Hajnoczi
On Tue, Oct 18, 2016 at 10:24 AM, yue wrote: > i apply this patch, > https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33 > . > but

Re: [Qemu-devel] [PATCH v3 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-18 Thread Eduardo Habkost
On Tue, Oct 18, 2016 at 11:02:54AM +0200, Igor Mammedov wrote: > On Mon, 17 Oct 2016 19:44:52 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote: > > [...] > > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,

Re: [Qemu-devel] [very-WIP 3/4] slirp: VMStatify sbuf

2016-10-18 Thread Halil Pasic
On 10/17/2016 09:06 PM, Dr. David Alan Gilbert wrote: >> OK, memory was allocated at #2 >> > It is a bit confusing though (for a novice like me) that we have a non >> > ALLOC VBUFFER >> > whose pointer is NULL after post_load. > I don't think this pointer can be NULL; the sbreserve at #2 causes

[Qemu-devel] [PATCH v2] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-18 Thread Pino Toscano
The 'obj' result of the visitor was not properly freed, like done in other places doing a similar job. Signed-off-by: Pino Toscano --- Changes in v2: - added Signed-off-by block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi.c b/block/qapi.c index

[Qemu-devel] [PATCH 1/8] libqos: Give qvirtio_config_read*() consistent semantics

2016-10-18 Thread David Gibson
The 'addr' parameter to qvirtio_config_read*() doesn't have a consistent meaning: when using the virtio-pci versions, it's a full PCI space address, but for virtio-mmio, it's an offset from the device's base mmio address. This means that the callers need to do different things to calculate the

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

2016-10-18 Thread Pino Toscano
On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote: > On 10/18/2016 04:17 AM, Pino Toscano wrote: > > qmp_output_start_struct() and qmp_output_start_list() create a new > > QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, > > where it is saved as 'value'. When

[Qemu-devel] [PATCH v4 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-18 Thread Igor Mammedov
that's enough to make old code that depends on it to prevent QEMU starting with more than 255 CPUs. Signed-off-by: Igor Mammedov --- v4: - keep assert() as it doesn't affect x2APIC cpus (Eduardo) --- hw/acpi/cpu_hotplug.c | 7 ++- hw/i386/pc.c | 6 -- 2

[Qemu-devel] [PATCH 1/3] ppc/xics: add a xics_set_nr_servers common routine

2016-10-18 Thread Cédric Le Goater
xics_spapr and xics_kvm nearly define the same 'set_nr_servers' handler. Only the type of the ICP differs. So let's make a common one to remove some duplicated code. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 24 +--- hw/intc/xics_kvm.c|

Re: [Qemu-devel] [PULL 00/25] target-arm queue

2016-10-18 Thread Peter Maydell
On 17 October 2016 at 19:40, Peter Maydell wrote: > Random mix of stuff here, nothing in particular > very large. Includes a fix for the regression running > Thumb userspace code. > > thanks > -- PMM > > > The following changes since commit

Re: [Qemu-devel] [PATCH v3 05/13] pc: leave max apic_id_limit only in legacy cpu hotplug code

2016-10-18 Thread Igor Mammedov
On Mon, 17 Oct 2016 19:44:52 -0200 Eduardo Habkost wrote: > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote: > [...] > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx, > > MachineState *machine, > > /* The current AML generator can cover

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-18 Thread Kevin Wolf
Am 17.10.2016 um 16:50 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben: > >> Cc: Kevin for discussion of QemuOpts dotted key convention > >> > >> "Daniel P. Berrange" writes: > >> >

[Qemu-devel] [PATCH v2 4/6] tests/vhost-user-bridge: do not accept more than one connection

2016-10-18 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 97e45d8..5b618f6 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-18 Thread Daniel P. Berrange
On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's

Re: [Qemu-devel] [PULL 0/5] machine + memory backend queue, 2016-10-17

2016-10-18 Thread Peter Maydell
On 17 October 2016 at 18:55, Eduardo Habkost wrote: > The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2016-10-17 16:17:51 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v3 09/13] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

2016-10-18 Thread Eduardo Habkost
On Tue, Oct 18, 2016 at 09:17:48AM +0200, Igor Mammedov wrote: > On Mon, 17 Oct 2016 19:51:12 -0200 > Eduardo Habkost wrote: > > > On Thu, Oct 13, 2016 at 11:52:43AM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > v4: > >

Re: [Qemu-devel] [PATCH v2] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-18 Thread Eric Blake
On 10/18/2016 05:37 AM, Pino Toscano wrote: > The 'obj' result of the visitor was not properly freed, like done in > other places doing a similar job. > > Signed-off-by: Pino Toscano > --- Reviewed-by: Eric Blake > > Changes in v2: > - added

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

2016-10-18 Thread Eric Blake
On 10/18/2016 04:17 AM, Pino Toscano wrote: > qmp_output_start_struct() and qmp_output_start_list() create a new > QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, > where it is saved as 'value'. When freeing the iterator in > qmp_output_free(), these values are never

Re: [Qemu-devel] [PATCH] script/clean-includes: added duplicate #include check

2016-10-18 Thread Anand J
On Thu, Oct 13, 2016 at 12:10 AM, Anand J wrote: > Added script to check duplicate #include entries. This check will scan and > print the files in which duplicate #include entries are present. > > Script might output false postive entries as well. Such entries should >

Re: [Qemu-devel] [PATCH] script/clean-includes: added duplicate #include check

2016-10-18 Thread Thomas Huth
On 12.10.2016 20:40, Anand J wrote: > Added script to check duplicate #include entries. This check will scan and > print the files in which duplicate #include entries are present. > > Script might output false postive entries as well. Such entries should > not be removed. So if it finds any

[Qemu-devel] [Bug 1631773] Re: hw/dma/pl080.c:354: possible typo ?

2016-10-18 Thread T. Huth
Thanks for reporting the issue, patch has now been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=04bb79d1f519ae190a ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PATCH v3 2/4] fdc: Add a floppy drive qdev

2016-10-18 Thread Kevin Wolf
Floppy controllers automatically create two floppy drive devices in qdev now. (They always created two drives, but managed them only internally.) Signed-off-by: Kevin Wolf Reviewed-by: John Snow --- hw/block/fdc.c | 151

[Qemu-devel] [PATCH v3 0/4] fdc: Use separate qdev device for drives

2016-10-18 Thread Kevin Wolf
We have been complaining for a long time about how the floppy controller and floppy drives are combined in a single qdev device and how this makes the device awkward to work with because it behaves different from all other block devices. The latest reason to complain was when I noticed that using

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

2016-10-18 Thread Igor Mammedov
On Mon, 17 Oct 2016 17:20:22 -0200 Eduardo Habkost wrote: > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > > > Remove all the cannot_destroy_with_object_finalize_yet as > > unsafe

Re: [Qemu-devel] [PATCH v3 06/13] pc: apic_common: extend APIC ID property to 32bit

2016-10-18 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 11:52:40AM +0200, Igor Mammedov wrote: > ACPI ID is 32 bit wide on CPUs with x2APIC support. > Extend 'id' property to support it. > > Signed-off-by: Igor Mammedov > --- > v3: >keep original behaviour where 'id' is readonly after >object is

[Qemu-devel] [PATCH 1/4] tests/test-vmstate.c: Add vBuffer test

2016-10-18 Thread Halil Pasic
From: Guenther Hutzl The unit test test-vmstate.c is missing tests for some of the complex vmstate macros. This patch adds a new test for VMSTATE_VBUFFER and VMSTATE_VBUFFER_ALLOC_UINT32. The added test does not cover start != 0 because it's broken and unused so our

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

2016-10-18 Thread Eric Blake
On 10/18/2016 06:13 AM, Eric Blake wrote: > On 10/18/2016 04:17 AM, Pino Toscano wrote: >> qmp_output_start_struct() and qmp_output_start_list() create a new >> QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor, >> where it is saved as 'value'. When freeing the iterator in

[Qemu-devel] [PATCH v2 0/6] Start a contrib/libvhost-user

2016-10-18 Thread Marc-André Lureau
Hi vhost-user & virtio have tricky corners and evolve regularly. There isn't a reference code that would help you get started either. And the backends duplicate most of the effort. Furthermore, due to usage of ancillary data, shared memory, eventfd, atomics, it is not so simple to implement in

Re: [Qemu-devel] [PATCH v4 0/3] iotests: Fix test 162

2016-10-18 Thread Kevin Wolf
Am 17.10.2016 um 19:07 hat Max Reitz geschrieben: > On 28.09.2016 22:46, Max Reitz wrote: > > 162 is potentially racy and makes some invalid assumptions about what > > should happen when connecting to a non-existing domain name. This series > > fixes both issues. > > > > > > v4: > > - Added

[Qemu-devel] [PATCH 8/8] libqos: Change PCI accessors to take opaque BAR handle

2016-10-18 Thread David Gibson
The usual use model for the libqos PCI functions is to map a specific PCI BAR using qpci_iomap() then pass the returned token into IO accessor functions. This, and the fact that iomap() returns a (void *) which actually contains a PCI space address, kind of suggests that the return value from

[Qemu-devel] [PATCH 5/8] libqos: Add streaming accessors for PCI MMIO

2016-10-18 Thread David Gibson
Currently PCI memory (aka MMIO) space is accessed via a set of readb/writeb style accessors. This is what we want for accessing discrete registers of a certain size. However, there are a few cases where we instead need a "bag of bytes" style streaming interface to PCI MMIO space. This can be

[Qemu-devel] [PATCH 3/8] libqos: Move BAR assignment to common code

2016-10-18 Thread David Gibson
The PCI backends in libqos each supply an iomap() and iounmap() function which is used to set up a specified PCI BAR. But PCI BAR allocation takes place entirely within PCI space, so doesn't really need per-backend versions. For example, Linux includes generic BAR allocation code used on

Re: [Qemu-devel] [PATCH v2] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-18 Thread Kevin Wolf
Am 18.10.2016 um 12:37 hat Pino Toscano geschrieben: > The 'obj' result of the visitor was not properly freed, like done in > other places doing a similar job. > > Signed-off-by: Pino Toscano Thanks, applied to my block branch. Kevin

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-18 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > Hi, > > I had a look at a couple of readline like libraries; > > editline and linenoise. A difficulty with using them is that > > they both want fd's or FILE*'s;

Re: [Qemu-devel] [PATCH 1/2] KVM: page track: add a new notifier type: track_flush_slot

2016-10-18 Thread Jike Song
On 10/18/2016 12:02 AM, Alex Williamson wrote: > On Fri, 14 Oct 2016 15:19:01 -0700 > Neo Jia wrote: > >> On Fri, Oct 14, 2016 at 10:51:24AM -0600, Alex Williamson wrote: >>> On Fri, 14 Oct 2016 09:35:45 -0700 >>> Neo Jia wrote: >>> On Fri, Oct 14, 2016

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-18 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Oct 18, 2016 at 02:08:14PM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > >> Hi, > > >> I had a look at a

  1   2   3   4   >