Re: [Qemu-devel] [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info

2016-12-04 Thread Li, Liang Z
> On 11/30/2016 12:43 AM, Liang Li wrote: > > +static void send_unused_pages_info(struct virtio_balloon *vb, > > + unsigned long req_id) > > +{ > > + struct scatterlist sg_in; > > + unsigned long pos = 0; > > + struct virtqueue *vq = vb->req_vq; > > + struct virtio

Re: [Qemu-devel] [PATCH for-2.9 17/30] aspeed/smc: handle SPI flash Command mode

2016-12-04 Thread mar.krzeminski
Hi Cedric, Since there is no public datasheet user guide for SMC I would ask some question regarding HW itself because I got impression that you are implementing in this model a part functionality that is done by Bootrom. W dniu 29.11.2016 o 16:43, Cédric Le Goater pisze: The Aspeed SMC cont

Re: [Qemu-devel] [PATCH for-2.9 22/30] aspeed/smc: handle dummy bytes when doing fast reads

2016-12-04 Thread mar.krzeminski
W dniu 29.11.2016 o 16:44, Cédric Le Goater pisze: When doing fast read, a certain amount of dummy bytes should be sent before the read. This number is configurable in the controler CE0 Control Register and needs to be modeled using fake transfers the flash module. When the controller is confi

Re: [Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

2016-12-04 Thread mar.krzeminski
Hi Cedric, it looks like good idea for now to handle boot from flash. As I understand you are trying to omit bootrom code in Qemu model? This could lead you to some hacks in device models (eg SMC). W dniu 29.11.2016 o 16:44, Cédric Le Goater pisze: Fill a ROM region with the flash content to su

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-04 Thread Michael S. Tsirkin
On Fri, Dec 02, 2016 at 10:01:52PM +0100, Laszlo Ersek wrote: > When passed to git-diff (and to every other git command producing diffs > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > will place the more declarative / abstract hunks first, while changes to > imperative co

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-04 Thread Cole Robinson
On 12/01/2016 06:26 AM, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 11:25 AM, Stefan Hajnoczi wrote: >> On Thu, Dec 1, 2016 at 11:20 AM, Stefan Hajnoczi wrote: >>> On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange >>> wrote: Wayland always uses evdev as its input source, so QEMU

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-04 Thread Fam Zheng
On Sun, 12/04 19:33, Michael S. Tsirkin wrote: > > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > > new file mode 100644 > > index ..3cab16e0505c > > --- /dev/null > > +++ b/scripts/git.orderfile > > @@ -0,0 +1,20 @@ > > +# Apply this diff order to your git configuration w

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-04 Thread Fam Zheng
On Thu, 12/01 19:26, Stefan Hajnoczi wrote: > Add an AioContext poll handler to detect new virtqueue buffers without > waiting for a guest->host notification. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) >

[Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-04 Thread Yi Fang
NBD client has not implemented callback for .bdrv_has_zero_init. So bdrv_has_zero_init always returns 0 when doing non-shared storage migration. This patch implemented NBD_CMD_HAS_ZERO_INIT and will avoid unnecessary set-dirty. Signed-off-by: Yi Fang --- block/block-backend.c | 5 +

Re: [Qemu-devel] [PATCH RFC 2/7] block-backend: Introduce blk_root() helper

2016-12-04 Thread Hailiang Zhang
On 2016/10/25 17:58, Changlong Xie wrote: I know you need blk->root in the next patch, but we strongly don't recommend your current solution. Please refer Kevin's cf2ab8fc 1409 /* XXX Ugly way to get blk->root, but that's a feature, not a bug. This 1410 * hack makes it obvious that vhd

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-04 Thread Michael S. Tsirkin
On Mon, Dec 05, 2016 at 08:30:21AM +0800, Fam Zheng wrote: > On Sun, 12/04 19:33, Michael S. Tsirkin wrote: > > > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > > > new file mode 100644 > > > index ..3cab16e0505c > > > --- /dev/null > > > +++ b/scripts/git.orderfile > > >

Re: [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options

2016-12-04 Thread Hailiang Zhang
On 2016/10/25 18:01, Changlong Xie wrote: On 10/20/2016 09:57 PM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- block/replication.c | 33

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

2016-12-04 Thread Yaowei Bai
On Thu, Dec 01, 2016 at 04:23:17PM +0100, Paolo Bonzini wrote: > > > On 01/12/2016 14:50, Stefan Hajnoczi wrote: > > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: > >> It's timer to expire, not clock. > >> > >> Signed-off-by: Yaowei Bai > >> --- > >> include/qemu/timer.h | 2 +- >

Re: [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-04 Thread Gonglei (Arei)
I don't think the root cause of those warnings are introduced by virtio-crypto driver. What's your opinion? Sam and David? Thanks, -Gonglei > -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: Sunday, December 04, 2016 10:40 AM > Subject: Re: [PATCH v5 1/1] cr

Re: [Qemu-devel] [PATCH 3/7] target-ppc: Implement bcds. instruction

2016-12-04 Thread David Gibson
On Sat, Dec 03, 2016 at 03:00:02AM -0200, Jose Ricardo Ziviani wrote: > bcds.: Decimal shift. Given two registers vra and vrb, this instruction > shift the vrb value by vra bits into the result register. > > Signed-off-by: Jose Ricardo Ziviani Reviewed-by: David Gibson > --- > target-ppc/help

Re: [Qemu-devel] [PATCH 3/7] target-ppc: Implement bcds. instruction

2016-12-04 Thread David Gibson
On Mon, Dec 05, 2016 at 02:12:29PM +1100, David Gibson wrote: > On Sat, Dec 03, 2016 at 03:00:02AM -0200, Jose Ricardo Ziviani wrote: > > bcds.: Decimal shift. Given two registers vra and vrb, this instruction > > shift the vrb value by vra bits into the result register. > > > > Signed-off-by: Jos

Re: [Qemu-devel] [PATCH 2/7] target-ppc: Implement unsigned quadword left/right shift and unit tests

2016-12-04 Thread David Gibson
On Sat, Dec 03, 2016 at 05:37:27PM -0800, Richard Henderson wrote: > On 12/02/2016 09:00 PM, Jose Ricardo Ziviani wrote: > > +++ b/include/qemu/host-utils.h > > @@ -29,6 +29,33 @@ > > #include "qemu/bswap.h" > > > > #ifdef CONFIG_INT128 > > +static inline void urshift(uint64_t *plow, uint64_t *p

Re: [Qemu-devel] [PATCH 4/7] target-ppc: Implement bcdus. instruction

2016-12-04 Thread David Gibson
On Sat, Dec 03, 2016 at 03:00:03AM -0200, Jose Ricardo Ziviani wrote: > bcdus.: Decimal unsigned shift. This instruction works like bcds. but > considers only unsigned BCDs (no sign in least meaning 4 bits). > > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1

Re: [Qemu-devel] [PATCH 5/7] target-ppc: Implement bcdsr. instruction

2016-12-04 Thread David Gibson
On Sat, Dec 03, 2016 at 03:00:04AM -0200, Jose Ricardo Ziviani wrote: > bcdsr.: Decimal shift and round. This instruction works like bcds. > however, when performing right shift, 1 will be added to the > result if the last digit was >= 5. > > Signed-off-by: Jose Ricardo Ziviani > --- > target-pp

[Qemu-devel] [PATCH for-2.9 0/3] cryptodev: prepare works for hotplug

2016-12-04 Thread Gonglei
The patch set make the cryptodev object can be hot plugging in safety, and which are preparing works for virtio-crypto device hotpulgging. Gonglei (3): cryptodev: introduce a new is_used property cryptodev: wrap the ready flag virtio-crypto: avoid one cryptodev device is used by multiple vir

[Qemu-devel] [PATCH for-2.9 1/3] cryptodev: introduce a new is_used property

2016-12-04 Thread Gonglei
This property is used to Tag the cryptodev backend is used by virtio-crypto or not. Making cryptodev can't be hot unplugged when it's in use. Cleanup resources when cryptodev is finalized. Signed-off-by: Gonglei --- backends/cryptodev.c | 19 +++ hw/virtio/virtio-crypto.c

[Qemu-devel] [PATCH for-2.9 2/3] cryptodev: wrap the ready flag

2016-12-04 Thread Gonglei
The ready flag should be set by the children of cryptodev backend interface. Warp the setter/getter functions for it. Signed-off-by: Gonglei --- backends/cryptodev-builtin.c | 4 backends/cryptodev.c | 15 +++ hw/virtio/virtio-crypto.c| 4 ++-- include/sysemu/crypt

[Qemu-devel] [PATCH for-2.9 3/3] virtio-crypto: avoid one cryptodev device is used by multiple virtio crypto devices

2016-12-04 Thread Gonglei
Add the check condition for cryptodev device in order to avoid one cryptodev device is used by multiple virtio crypto devices. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/

Re: [Qemu-devel] [PATCH RFC 4/7] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

2016-12-04 Thread Hailiang Zhang
On 2016/10/26 9:40, Changlong Xie wrote: On 10/20/2016 09:57 PM, zhanghailiang wrote: The helper backup_do_checkpoint() will be used for primary related codes. Here we split it out from secondary_do_checkpoint(). Besides, it is unnecessary to call backup_do_checkpoint() in replication starting

Re: [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target

2016-12-04 Thread Bharata B Rao
On Fri, Dec 2, 2016 at 11:46 PM, Dr. David Alan Gilbert wrote: > * Bharata B Rao (bharata@gmail.com) wrote: > > Hi, > > > > - Add ram object and dimm device at the source > > > > (qemu) object_add memory-backend-ram,id=ram0,size=128M > > (qemu) device_add pc-dimm,id=dimm0,memdev=ram0 > > > >

[Qemu-devel] [PATCH] ppc/spapr: implement H_SIGNAL_SYS_RESET

2016-12-04 Thread Nicholas Piggin
The H_SIGNAL_SYS_RESET hcall allows a guest CPU to raise a system reset exception on CPUs within the same guest -- all CPUs, all-but-self, or a specific CPU (including self). This has not made its way to a PAPR release yet, but we have an hcall number assigned. H_SIGNAL_SYS_RESET = 0x380 Syn

Re: [Qemu-devel] [Qemu-ppc] [RFCv2 12/12] ppc: Rework CPU compatibility testing across migration

2016-12-04 Thread David Gibson
On Fri, Dec 02, 2016 at 03:48:25PM +0100, Greg Kurz wrote: > On Wed, 16 Nov 2016 09:17:55 +1100 > David Gibson wrote: > > > Migrating between different CPU versions is quite complicated for ppc. > > A long time ago, we ensure identical CPU versions at either end by checking > > the PVR had the sa

Re: [Qemu-devel] [PATCH] ppc/spapr: implement H_SIGNAL_SYS_RESET

2016-12-04 Thread David Gibson
On Mon, Dec 05, 2016 at 02:56:47PM +1100, Nicholas Piggin wrote: > The H_SIGNAL_SYS_RESET hcall allows a guest CPU to raise a system reset > exception on CPUs within the same guest -- all CPUs, all-but-self, or a > specific CPU (including self). > > This has not made its way to a PAPR release yet,

[Qemu-devel] [PATCH ppc-for-2.9] ppc/spapr: implement H_SIGNAL_SYS_RESET

2016-12-04 Thread Nicholas Piggin
The H_SIGNAL_SYS_RESET hcall allows a guest CPU to raise a system reset exception on CPUs within the same guest -- all CPUs, all-but-self, or a specific CPU (including self). This has not made its way to a PAPR release yet, but we have an hcall number assigned. H_SIGNAL_SYS_RESET = 0x380 Syn

Re: [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target

2016-12-04 Thread Michael Roth
Quoting Bharata B Rao (2016-12-04 21:51:32) > On Fri, Dec 2, 2016 at 11:46 PM, Dr. David Alan Gilbert > wrote: > > * Bharata B Rao (bharata@gmail.com) wrote: > > Hi, > > > > - Add ram object and dimm device at the source > > > > (qemu) object_add memory-backend-ram,id=

Re: [Qemu-devel] [PATCH] display: cirrus: check vga bits per pixel(bpp) value

2016-12-04 Thread P J P
+-- On Mon, 28 Nov 2016, P J P wrote --+ | +-- On Wed, 16 Nov 2016, Marc-André Lureau wrote --+ | | For completeness, do you have a reproducer and/or a backtrace? | | Yes, there is. | | === | Thread 4 "qemu-system-x86" received signal SIGFPE, Arithmetic exception. | [Switching to Thread 0x700

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-04 Thread Pavel Dovgalyuk
Paolo, > From: Kevin Wolf [mailto:kw...@redhat.com] > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > > > > > > I

[Qemu-devel] [PATCH for-2.9 0/2] cryptodev: support xts(aes) algorithm

2016-12-04 Thread Longpeng(Mike)
This patchset firstly fix a bug in cryptodev_builtin_get_aes_algo, and then add xts(aes) algorithm support. Longpeng(Mike) (2): cryptodev: fix the check of aes algorithm cryptodev: add xts(aes) support backends/cryptodev-builtin.c | 55 +--- 1 file cha

[Qemu-devel] [PATCH for-2.9 2/2] cryptodev: add xts(aes) support

2016-12-04 Thread Longpeng(Mike)
This patch add xts(aes) support. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 8 1 file changed, 8 insertions(+) diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c index 9dec6b8..ecad565 100644 --- a/backends/cryptodev-builtin.c +++ b/backends/

[Qemu-devel] [PATCH for-2.9 1/2] cryptodev: fix the check of aes algorithm

2016-12-04 Thread Longpeng(Mike)
As the key length of xts(aes) is different with other mode of aes, so we should check specially in cryptodev_builtin_get_aes_algo, if it is xts mode. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 47 +++- 1 file changed, 33 insertions(+)

Re: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable

2016-12-04 Thread Jason Wang
On 2016年12月02日 19:28, P J P wrote: From: Prasad J Pandit Local 'netcfg' variable in 'virtio_net_get_config' routine was not initialised. It could leak uninitialised 'netcfg.mtu' field memory. Initialise 'netcfg' to avoid it. Reported-by: Azureyang Signed-off-by: Prasad J Pandit --- hw/ne

Re: [Qemu-devel] [PATCH ppc-for-2.9] ppc/spapr: implement H_SIGNAL_SYS_RESET

2016-12-04 Thread David Gibson
On Mon, Dec 05, 2016 at 04:50:21PM +1100, Nicholas Piggin wrote: > The H_SIGNAL_SYS_RESET hcall allows a guest CPU to raise a system reset > exception on CPUs within the same guest -- all CPUs, all-but-self, or a > specific CPU (including self). > > This has not made its way to a PAPR release yet,