Re: [Qemu-devel] [PATCH 1/2] tcg/aarch64: Fix addsub2 for 0+C

2016-12-07 Thread Richard Henderson
On 12/07/2016 10:10 AM, Peter Maydell wrote: > On 7 December 2016 at 18:07, Richard Henderson wrote: >> When al == xzr, we cannot use addi/subi because that encodes xsp. >> Force a zero into the temp register for that (rare) case. > > Incidentally I was slightly surprised that

[Qemu-devel] [PATCH v1 ppc-for-2.9 0/9] POWER9 TCG enablements - part9

2016-12-07 Thread Nikunj A Dadhania
This series contains 12 new instructions for POWER9 ISA3.0 Couple of consolidation patches VSX Vector Insert/Extract Word VSX Vector Permute VSX Load/Store with length VSX Scalar Quad-Precision Move Instructions Changelog: v0: * Fixed lxvl/lxvll and stxvl/stxvll as

[Qemu-devel] [PATCH v1 2/9] target-ppc: implement lxvll instruction

2016-12-07 Thread Nikunj A Dadhania
lxvll: Load VSX Vector Left-justified with Length Little/Big-endian Storage: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|FF|FF| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Loading 14 bytes to vector

[Qemu-devel] [PATCH v1 1/9] target-ppc: implement lxvl instruction

2016-12-07 Thread Nikunj A Dadhania
lxvl: Load VSX Vector with Length Little/Big-endian Storage: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|FF|FF| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Loading 14 bytes results in: Vector (8-bit

[Qemu-devel] [PATCH v1 3/9] target-ppc: implement stxvl instruction

2016-12-07 Thread Nikunj A Dadhania
stxvl: Store VSX Vector with Length Vector (8-bit elements) in BE: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Vector (8-bit elements) in LE:

Re: [Qemu-devel] [PATCH 07/21] qcow2: add bitmaps extension

2016-12-07 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. > > For now, disable image resize if it has bitmaps. It will be fixed later. > > Signed-off-by:

[Qemu-devel] [PATCH v1 4/9] target-ppc: implement stxvll instructions

2016-12-07 Thread Nikunj A Dadhania
stxvll: Store VSX Vector Left-justified with Length Vector (8-bit elements) in LE/BE: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Storing 14 bytes

[Qemu-devel] [PATCH v1 6/9] target-ppc: implement xxinsertw instruction

2016-12-07 Thread Nikunj A Dadhania
xxinsertw: VSX Vector Insert Word Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 30 ++

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Andrea Arcangeli
Hello, On Wed, Dec 07, 2016 at 08:57:01AM -0800, Dave Hansen wrote: > It is more space-efficient. We're fitting the order into 6 bits, which > would allows the full 2^64 address space to be represented in one entry, Very large order is the same as very large len, 6 bits of order or 8 bytes of

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Dave Hansen
On 12/07/2016 10:38 AM, Andrea Arcangeli wrote: >> > and leaves room for the bitmap size to be encoded as well, if we decide >> > we need a bitmap in the future. > How would a bitmap ever be useful with very large page-order? Please, guys. Read the patches. *Please*. The current code doesn't

[Qemu-devel] [PATCH v5 3/3] utils: Add prefetch for Thunderx platform

2016-12-07 Thread vijay . kilari
From: Vijaya Kumar K Thunderx pass2 chip requires explicit prefetch instruction to give prefetch hint. To speed up live migration on Thunderx platform, prefetch instruction is added in zero buffer check function.The below results show live migration time improvement

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Dave Hansen
Removing silly virtio-dev@ list because it's bouncing mail... On 12/07/2016 08:21 AM, David Hildenbrand wrote: >> Li's current patches do that. Well, maybe not pfn/length, but they do >> take a pfn and page-order, which fits perfectly with the kernel's >> concept of high-order pages. > > So we

[Qemu-devel] [PATCH v5 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-12-07 Thread vijay . kilari
From: Vijaya Kumar K Add helper API to read MIDR_EL1 registers to fetch cpu identification information. This helps in adding errata's and architecture specific features. This is implemented only for arm architecture. Signed-off-by: Vijaya Kumar K

[Qemu-devel] [PATCH] Correct value of ARM Cortex-A8 MVFR1 register.

2016-12-07 Thread Julian Brown
The value of the MVFR1 (Media and VFP Feature Register 1) register for the Cortex-A8 appears to be incorrect (according to the TRM, DDI0344K), with the "full denormal arithmetic" and "propagation of NaN" fields holding both 0 instead of both 1. I had a go tracing the history of the use of this

[Qemu-devel] [PATCH for 2.8 v4 1/1] cadence_uart: Check baud rate generator and divider values on migration

2016-12-07 Thread Alistair Francis
The Cadence UART device emulator calculates speed by dividing the baud rate by a 'baud rate generator' & 'baud rate divider' value. The device specification defines these register values to be non-zero and within certain limits. Checks were recently added when writing to these registers but not

[Qemu-devel] [PATCH 0/2] tcg/aarch64 fixes

2016-12-07 Thread Richard Henderson
Both of these were identified by Alex and his risu testsuite, and diagnosed by Peter. I believe that both bugs are my fault, originally. The risu testsuite, as posted, now passes with an aarch64 host. r~ Richard Henderson (2): tcg/aarch64: Fix addsub2 for 0+C tcg/aarch64: Fix

Re: [Qemu-devel] [PATCH for 2.8 v3 1/1] cadence_uart: Check baud rate generator and divider values on migration

2016-12-07 Thread Alistair Francis
On Tue, Dec 6, 2016 at 1:31 AM, Peter Maydell wrote: > On 5 December 2016 at 18:35, Alistair Francis > wrote: >> The Cadence UART device emulator calculates speed by dividing the >> baud rate by a 'baud rate generator' & 'baud rate divider'

Re: [Qemu-devel] Slow qemu guest performance after host is resumed from suspended state

2016-12-07 Thread Stefan Hajnoczi
On Sun, Dec 4, 2016 at 10:52 PM, Ruslan Habalov <3v0n...@gmail.com> wrote: > Hi everyone, > > I'm having the following qemu issue since about February on Xubuntu. > > Steps to reproduce: > 1) Boot host and boot qemu guest - everything works perfect > 2) Shutdown qemu guest > 3) Suspend host and

Re: [Qemu-devel] [kvm-unit-tests PATCH v14 2/5] arm: Add support for read_sysreg() and write_sysreg()

2016-12-07 Thread Andrew Jones
On Tue, Dec 06, 2016 at 12:05:25PM -0600, Wei Huang wrote: > This patch adds two new macros to support read/write operations of ARMv7 > and ARMv8 system registers. As part of the change, xstr() is revised to > support variable arguments. With it, ARMv7 system register can be defined > with

[Qemu-devel] [PATCH 1/2] tcg/aarch64: Fix addsub2 for 0+C

2016-12-07 Thread Richard Henderson
When al == xzr, we cannot use addi/subi because that encodes xsp. Force a zero into the temp register for that (rare) case. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 1/2] tcg/aarch64: Fix addsub2 for 0+C

2016-12-07 Thread Peter Maydell
On 7 December 2016 at 18:07, Richard Henderson wrote: > When al == xzr, we cannot use addi/subi because that encodes xsp. > Force a zero into the temp register for that (rare) case. Incidentally I was slightly surprised that the optimisation pass didn't turn "add2 rlo, rhi, 0,

[Qemu-devel] [PATCH 2/2] tcg/aarch64: Fix tcg_out_movi

2016-12-07 Thread Richard Henderson
There were some patterns, like 0x___00ff, for which we would select to begin a multi-insn sequence with MOVN, but would fail to set the 0x lane back from 0x. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 57

[Qemu-devel] [PATCH v1 5/9] target-ppc: implement xxextractuw instruction

2016-12-07 Thread Nikunj A Dadhania
xxextractuw: VSX Vector Extract Unsigned Word Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 31 +++ target-ppc/translate/vsx-impl.inc.c | 27

[Qemu-devel] [PATCH v1 9/9] target-ppc: Add xxperm and xxpermr instructions

2016-12-07 Thread Nikunj A Dadhania
From: Bharata B Rao xxperm: VSX Vector Permute xxpermr: VSX Vector Permute Right-indexed Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 23

[Qemu-devel] [PATCH v1 8/9] target-ppc: implement xscpsgnqp instruction

2016-12-07 Thread Nikunj A Dadhania
xscpsgnqp: VSX Scalar Copy Sign Quad-Precision Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target-ppc/translate/vsx-impl.inc.c | 12 +++- target-ppc/translate/vsx-ops.inc.c | 1 + 2 files changed, 12 insertions(+),

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Andrea Arcangeli
On Wed, Dec 07, 2016 at 10:44:31AM -0800, Dave Hansen wrote: > On 12/07/2016 10:38 AM, Andrea Arcangeli wrote: > >> > and leaves room for the bitmap size to be encoded as well, if we decide > >> > we need a bitmap in the future. > > How would a bitmap ever be useful with very large page-order? >

Re: [Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests

2016-12-07 Thread Andrew Jones
On Tue, Dec 06, 2016 at 12:05:23PM -0600, Wei Huang wrote: > Changes from v13: > * Rename cp15.h to sysreg.h for ARMv7 and add a new file sysreg.h for ARMv8 > * Add macros for read_sysreg() and write_sysreg(). CP15 registers can be > defined with __ACCESS_CP15() or __ACCESS_CP15_64(). sysreg.h

[Qemu-devel] [PATCH v5 0/3] Live migration optimization for Thunderx platform

2016-12-07 Thread vijay . kilari
From: Vijaya Kumar K The CPU MIDR_EL1 register is exposed to userspace for arm64 with the below patch. https://lkml.org/lkml/2016/7/8/467 Thunderx platform requires explicit prefetch instruction to provide prefetch hint. Using MIDR_EL1 information, provided by above

[Qemu-devel] [PATCH] tcg/s390: Fix setcond expansion

2016-12-07 Thread Richard Henderson
We can't use LOAD AND TEST for unsigned data and then expect to extract the result with ADD LOGICAL WITH CARRY. Fall through to using COMPARE LOGICAL IMMEDIATE instead. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 50

Re: [Qemu-devel] [PATCH 08/21] block: introduce auto-loading bitmaps

2016-12-07 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps store in the disk image, which should s/store/stored/ > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH v5 1/3] cutils: Set __builtin_prefetch optional parameters

2016-12-07 Thread vijay . kilari
From: Vijaya Kumar K Optional parameters of __builtin_prefetch() which specifies rw and locality to 0's. For checking buffer is zero, set rw as read and temporal locality to 0. On arm64, __builtin_prefetch(addr) generates 'prfmpldl1keep' where

[Qemu-devel] [PATCH v1 7/9] target-ppc: implement xsnegqp instruction

2016-12-07 Thread Nikunj A Dadhania
xsnegqp: VSX Scalar Negate Quad-Precision Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 4 target-ppc/translate/vsx-ops.inc.c | 1 + 2 files changed, 5 insertions(+) diff --git a/target-ppc/translate/vsx-impl.inc.c

Re: [Qemu-devel] [PATCH 16/21] qmp: add persistent flag to block-dirty-bitmap-add

2016-12-07 Thread Eric Blake
On 11/22/2016 11:26 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > +++

[Qemu-devel] [Bug 1579306] Re: usb-uas does not work in Windows (10) guest

2016-12-07 Thread Ashish Girdhar
I am also facing this issue. On further probing, I found out that usb-uas in Qemu doesn't support "SET_SEL" control command due to which windows driver "uaspstor.sys" couldn't complete the enumeration. It is clearly mentioned in USB 3.1 specs that uasp devices should handle two new control

Re: [Qemu-devel] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-12-07 Thread Fam Zheng
On Fri, 12/02 01:30, Max Reitz wrote: > On 31.10.2016 16:38, Fam Zheng wrote: > > They are wrappers of POSIX fcntl "file private locking". > > > > Signed-off-by: Fam Zheng > > --- > > include/qemu/osdep.h | 2 ++ > > util/osdep.c | 29 + > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cadence_uart: Check if receiver timeout counter is disabled

2016-12-07 Thread Laurent Vivier
I CC: Xilinx Zynq Maintainers. Laurent On 07/12/2016 22:12, Andrew Gacek wrote: > When register Rcvr_timeout_reg0 (R_RTOR in cadence_uart.c) is set to > 0, the receiver timeout counter should be disabled. See page 1801 of > "Zynq-7000 AP SoC Technical Reference Manual". This commit adds a > such

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-07 Thread Vladimir Sementsov-Ogievskiy
08.12.2016 06:39, Alex Bligh wrote: [...] are vendor dependent extensions. The 'BASE' namespace represents metadata contexts defined within this document. Other namespaces may be registered by reference within this document. +The "BASE:allocation" Backticks: `BASE:allocation` An idea:

Re: [Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

2016-12-07 Thread Fam Zheng
On Fri, 12/02 01:52, Max Reitz wrote: > > diff --git a/qemu-img.c b/qemu-img.c > > index afcd51f..b2f4077 100644 > > --- a/qemu-img.c > > +++ b/qemu-img.c > > @@ -679,6 +679,10 @@ static int img_check(int argc, char **argv) > > break; > > } > > } > > + > > +if

Re: [Qemu-devel] test-qga failures on Fedora 24

2016-12-07 Thread Marc-André Lureau
Hi - Original Message - > On 7 July 2016 at 00:02, Michael Roth wrote: > > Quoting John Snow (2016-07-06 17:41:32) > >> > >> > >> On 07/06/2016 06:20 PM, Michael Roth wrote: > >> > Quoting Marc-André Lureau (2016-07-06 16:40:52) > >> >>> Here's the meat of it:

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Dave Hansen
We're talking about a bunch of different stuff which is all being conflated. There are 3 issues here that I can see. I'll attempt to summarize what I think is going on: 1. Current patches do a hypercall for each order in the allocator. This is inefficient, but independent from the underlying

[Qemu-devel] [Bug 584146] Re: Virtual fat breaks with -snapshot

2016-12-07 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU? If so, could you please provide a proper command line that triggers this problem? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [Bug 584516] Re: opensuse 11.2 guest hangs after live migration with clocksource=kvm-clock

2016-12-07 Thread Thomas Huth
This bug ticket is quite old already ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 538808] Re: qemu-system-x86_64 0.12.2 crashes with -m 967 under Windows

2016-12-07 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/538808 Title:

[Qemu-devel] [PATCH] cadence_uart: Check if receiver timeout counter is disabled

2016-12-07 Thread Andrew Gacek
When register Rcvr_timeout_reg0 (R_RTOR in cadence_uart.c) is set to 0, the receiver timeout counter should be disabled. See page 1801 of "Zynq-7000 AP SoC Technical Reference Manual". This commit adds a such a check before setting the receive timeout interrupt. Signed-off-by: Andrew Gacek

Re: [Qemu-devel] [PATCH 08/21] block: introduce auto-loading bitmaps

2016-12-07 Thread John Snow
On 11/22/2016 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps store in the disk image, which should > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [QEMU PATCH v15 3/4] tests/migration: Add test for QTAILQ migration

2016-12-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index

[Qemu-devel] [QEMU PATCH v15 4/4] migration: add error_report

2016-12-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..8ddd230 100644 ---

Re: [Qemu-devel] [PATCH 3/3] hw/intc/arm_gicv3: Don't signal Pending+Active interrupts to CPU

2016-12-07 Thread Edgar E. Iglesias
On Tue, Dec 06, 2016 at 05:46:19PM +, Peter Maydell wrote: > The GICv3 requires that we only signal Pending interrupts to > the CPU. This category does not include Pending+Active interrupts, > which means we need to check whether the interrupt is Active in > the gicr_int_pending() and

[Qemu-devel] [QEMU PATCH v15 0/4] migration: migrate QTAILQ

2016-12-07 Thread Jianjun Duan
I addressed some review comments. Comments are welcome. v15: - Improved error messages. Previous versions are: v14: - Fixed a return statement. (link: http://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg04467.html) v13: - Changed some QTAILQ related macro names to match

[Qemu-devel] [QEMU PATCH v15 1/4] migration: extend VMStateInfo

2016-12-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan ---

[Qemu-devel] [QEMU PATCH v15 2/4] migration: migrate QTAILQ

2016-12-07 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list.

Re: [Qemu-devel] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-07 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > Add a test for QTAILQ migration to tests/test-vmstate.c. Yes, but see comment below if you have to respin: > Signed-off-by: Jianjun Duan > --- > tests/test-vmstate.c | 160 >

Re: [Qemu-devel] Slow qemu guest performance after host is resumed from suspended state

2016-12-07 Thread Ruslan Habalov
Following Stefan's suggestion I've investigated the possibility of potential problems with interrupts. Unfortunately, I can see no differences between both scenarios regarding the interrupt counter growth (c.f. https://evonide.com/images/qemu_proc_interrupts.png). After a short conversation with

Re: [Qemu-devel] [PATCH 2/3] hw/intc/arm_gicv3: Remove incorrect usage of fieldoffset

2016-12-07 Thread Edgar E. Iglesias
On Tue, Dec 06, 2016 at 05:46:18PM +, Peter Maydell wrote: > In the ARMCPRegInfo definitions for the GICv3 CPU interface > registers, we were trying to use .fieldoffset to specify > the locations of data fields within the GICv3CPUState struct. > This is completely broken, because .fieldoffset

Re: [Qemu-devel] [QEMU PATCH v14 4/4] migration: add error_report

2016-12-07 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > Added error_report where version_ids do not match in vmstate_load_state. > > Signed-off-by: Jianjun Duan Yes, but the error message would be better if it printed the two version numbers so you could see what went

[Qemu-devel] [Bug 498417] Re: cache=writeback on disk image doesn't do write-back

2016-12-07 Thread Thomas Huth
QEMU 0.11 / 0.12 is pretty much outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/3] target-arm: Log AArch64 exception returns

2016-12-07 Thread Edgar E. Iglesias
On Tue, Dec 06, 2016 at 05:46:17PM +, Peter Maydell wrote: > We already log exception entry; add logging of the AArch64 exception > return path as well. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias > --- >

Re: [Qemu-devel] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-07 Thread Jianjun Duan
On 12/07/2016 11:49 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Add a test for QTAILQ migration to tests/test-vmstate.c. > > Yes, but see comment below if you have to respin: > >> Signed-off-by: Jianjun Duan >> --- >>

Re: [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-07 Thread Sam Ravnborg
On Mon, Dec 05, 2016 at 03:12:52AM +, Gonglei (Arei) wrote: > I don't think the root cause of those warnings are introduced by > virtio-crypto driver. > > What's your opinion? Sam and David? Root cause here is that arch/sparc/include/asm/topology_64.h references cpu_data without including

Re: [Qemu-devel] [QEMU PATCH v14 0/4] migration: migrate QTAILQ

2016-12-07 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > ping Yes, hopefully this can go in right near the start of 2.9 Dave > > On 11/23/2016 09:53 AM, Jianjun Duan wrote: > > Hi all, > > > > I addressed some review comments. Comments are welcome. > > > > v14: - Fixed a return statement.

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-07 Thread Andrea Arcangeli
On Wed, Dec 07, 2016 at 11:54:34AM -0800, Dave Hansen wrote: > We're talking about a bunch of different stuff which is all being > conflated. There are 3 issues here that I can see. I'll attempt to > summarize what I think is going on: > > 1. Current patches do a hypercall for each order in the

[Qemu-devel] [Bug 538808] Re: qemu-system-x86_64 0.12.2 crashes with -m 967 under Windows

2016-12-07 Thread Stefan Weil
I think that QEMU did not crash, but simply was not able to allocate the block of memory which was requested. This is an inherent problem of the fragmented memory of 32 bit applications on Windows. QEMU reports problems with memory allocation, but QEMU for Windows tries to send those messages to

[Qemu-devel] [PATCH for-2.9 2/2] cryptodev: add 3des-ede support

2016-12-07 Thread Longpeng(Mike)
This patch add 3des-ede support for cryptodev. However this is effective only when backend using libgcrypt/nettle, because cipher-builtin doesn't support 3des-ede yet. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 12 1 file changed, 12

Re: [Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-07 Thread Alex Bennée
Pranith Kumar writes: > We acquire mmap lock and tb lock in one order and release them in a > different order. This does not need to be that way. > > This patch was inspired by a previous patch by Emilio G. Cota >

[Qemu-devel] [Bug 1631625] Re: target-mips/dsp_helper.c: two possible bad shifts

2016-12-07 Thread Thomas Huth
Fix has been committed: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=e6e2784cacd4cfec149 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH for-2.8 2/2] tests: check-qom-proplist: add checks for cmdline-created objects

2016-12-07 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 02:15:00PM -0600, Michael Roth wrote: > check-qom-proplist originally added tests for verifying that > object-creation helpers object_new_with_{props,propv} behaved in > similar fashion to the "traditional" method involving setting each > individual property separately

Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-07 Thread Kevin Wolf
Am 07.12.2016 um 03:55 hat Fam Zheng geschrieben: > On Mon, 12/05 13:03, Markus Armbruster wrote: > > == Basic dynamic reconfiguration operation == > > > > The basic operation is "replace child". > > > > Beware of race conditions. Consider: > > > > BB > > | > >

Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-07 Thread Fam Zheng
On Wed, 12/07 10:48, Kevin Wolf wrote: > > If so I think there is no race to worry about, mirror-filter should go > > away only after a QMP command. > > Currently, a mirror job goes away whenever it is done. This is not > directly tied to a QMP command. Ah right, block-job-complete is only

Re: [Qemu-devel] [PATCH for-2.8 1/2] monitor: fix object_del for command-line-created objects

2016-12-07 Thread Markus Armbruster
Michael Roth writes: > Currently objects specified on the command-line are only partially > cleaned up when 'object_del' is issued in either HMP or QMP: the > object itself is fully finalized, but the QemuOpts are not removed. > This results in the following behavior:

Re: [Qemu-devel] [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-07 Thread Kevin Wolf
Am 06.12.2016 um 16:21 hat Eric Blake geschrieben: > On 12/06/2016 03:25 AM, Kevin Wolf wrote: > > Am 06.12.2016 um 00:42 hat Eric Blake geschrieben: > >> While not directly related to NBD_CMD_WRITE_ZEROES, the qemu > >> team discovered that it is useful if a server can advertise > >> whether an

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-07 Thread Greg Kurz
On Tue, 6 Dec 2016 20:30:52 + Stefan Hajnoczi wrote: > On Tue, Dec 06, 2016 at 05:48:00PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > >

Re: [Qemu-devel] [PATCH v2 7/7] target-ppc: Implement bcdtrunc. instruction

2016-12-07 Thread David Gibson
On Tue, Dec 06, 2016 at 05:40:10PM -0200, Jose Ricardo Ziviani wrote: > bcdutrunc. Decimal unsigned truncate. Works like bcdtrunc. with > unsigned BCD numbers. > > Signed-off-by: Jose Ricardo Ziviani Short description (subject line) says 'bcdtrunc.' instead of

Re: [Qemu-devel] [PATCH v2 2/7] target-ppc: Implement unsigned quadword left/right shift and unit tests

2016-12-07 Thread David Gibson
On Tue, Dec 06, 2016 at 05:40:05PM -0200, Jose Ricardo Ziviani wrote: > This commit implements functions to right and left shifts and the > unittest for them. Such functions is needed due to instructions > that requires them. > > Today, there is already a right shift implementation in int128.h >

Re: [Qemu-devel] [PATCH v2 1/7] target-ppc: Implement bcd_is_valid function

2016-12-07 Thread David Gibson
On Tue, Dec 06, 2016 at 05:40:04PM -0200, Jose Ricardo Ziviani wrote: > A function to check if all digits of a given BCD number is valid is > here presented because more instructions will need to reuse the > same code. > > Signed-off-by: Jose Ricardo Ziviani I've

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Wednesday, December 07, 2016 4:34 PM > To: berra...@redhat.com; ebl...@redhat.com; arm...@redhat.com; > Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Wubin (H); Zhoujian (jay, Euler); longpeng > Subject: [PATCH for-2.9 1/2] crypto: add 3des-ede

Re: [Qemu-devel] [PATCH for-2.8 1/2] monitor: fix object_del for command-line-created objects

2016-12-07 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 02:14:59PM -0600, Michael Roth wrote: > Currently objects specified on the command-line are only partially > cleaned up when 'object_del' is issued in either HMP or QMP: the > object itself is fully finalized, but the QemuOpts are not removed. > This results in the

Re: [Qemu-devel] ui/egl-helpers.c license and reuse

2016-12-07 Thread Markus Armbruster
Eric Blake writes: > On 12/06/2016 10:18 AM, John Snow wrote: >> >> >> On 12/06/2016 10:47 AM, Frediano Ziglio wrote: >>> Hi, >>> I work in the SPICE team (www.spice-space.org). I'd like to reuse some >>> code from >>> this file for some test for our project. The license

Re: [Qemu-devel] [Qemu-block] [PULL for-2.8 0/3] Block patches for -rc3

2016-12-07 Thread Kevin Wolf
Am 06.12.2016 um 16:43 hat Eric Blake geschrieben: > On 12/06/2016 09:11 AM, Eric Blake wrote: > > >> BlockdevOptionsGluster.debug(-level) does not have "Added in 2.8" so I > >> had to dig through git-blame(1) to verify that it was indeed added in > >> the current release cycle. > > > > Then

[Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Longpeng(Mike)
Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede support when using libgcrypt or nettle. Signed-off-by: Longpeng(Mike) --- crypto/cipher-gcrypt.c | 6 ++ crypto/cipher-nettle.c | 37 + crypto/cipher.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence

2016-12-07 Thread Laurent Vivier
Le 07/12/2016 à 09:58, Zhang Chen a écrit : > > > On 12/02/2016 03:57 PM, Laurent Vivier wrote: >> >> On 02/12/2016 03:59, Zhang Chen wrote: >>> >>> On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: > Say it in another way to make it easier to

Re: [Qemu-devel] ui/egl-helpers.c license and reuse

2016-12-07 Thread Gerd Hoffmann
Hi, > "IANAL," > > Looks like the file was authored by four people with no explicit > license, so it defaulted to GPL2. > > Cole Robinson, Gerd Hoffman, Gonglei, and Peter Maydell. > > Maybe you can get explicit permission from these four. I'm fine with relicensing the file. I'd suggest

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-07 Thread Avi Kivity
On 12/02/2016 12:12 PM, Stefan Hajnoczi wrote: On Thu, Dec 01, 2016 at 09:35:27AM -0500, Paolo Bonzini wrote: Maybe we could do the same for sockets? When data is available on a socket (or when it becomes writable), write to a user memory location. I, too, have an interest in polling; in my

Re: [Qemu-devel] [PATCH for-2.9] cryptodev: remove single-DES support in cryptodev

2016-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2016 at 09:31:25AM +0800, Longpeng(Mike) wrote: > Single-DES is obsolete and it's broken/useless for decades, we should > remove it in cryptodev, as suggested by Daniel. > Guest who wants to use this obsolete cipher alg will use its built-in > implementation instead. > >

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Longpeng (Mike)
On 2016/12/7 17:19, Longpeng (Mike) wrote: > > > On 2016/12/7 16:52, Gonglei (Arei) wrote: > >>> -Original Message- >>> From: longpeng >>> Sent: Wednesday, December 07, 2016 4:34 PM >>> To: berra...@redhat.com; ebl...@redhat.com; arm...@redhat.com; >>> Gonglei (Arei) >>> Cc:

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2016 at 04:33:41PM +0800, Longpeng(Mike) wrote: > Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede > support when using libgcrypt or nettle. > > Signed-off-by: Longpeng(Mike) > --- > crypto/cipher-gcrypt.c | 6 ++ >

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2016 at 05:19:38PM +0800, Longpeng (Mike) wrote: > > > On 2016/12/7 16:52, Gonglei (Arei) wrote: > > >> -Original Message- > >> From: longpeng > >> Sent: Wednesday, December 07, 2016 4:34 PM > >> To: berra...@redhat.com; ebl...@redhat.com; arm...@redhat.com; > >> Gonglei

Re: [Qemu-devel] [PATCH for-2.9 0/2] VT-d extend GAW to 48 bits

2016-12-07 Thread Fam Zheng
On Wed, 12/07 13:52, Peter Xu wrote: > The first patch did some check to make sure the CE GAW bits are always > valid (it can overflow in old codes, I see it dangerous). > > The second patch extended VT-d GAW (Guest Address Width) from 39 bits > to 48 bits. > > Please review. Thanks, > > Peter

[Qemu-devel] [Bug 1643537] Re: target-ppc/int_helper.c: 2 * bad array index

2016-12-07 Thread Thomas Huth
Fix has been committed: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a813fe73621e1221a09 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH for-2.9 0/2] crypto: add 3des-ede support

2016-12-07 Thread Longpeng(Mike)
This patchset add 3DES-EDE support when using gcrypt/nettle. Due to the virtio-crypto has been supportted, the guest can use various cipher-algo including 3DES-EDE. Longpeng(Mike) (2): crypto: add 3des-ede support when using libgcrypt/nettle cryptodev: add 3des-ede support

Re: [Qemu-devel] [PATCH v2 6/7] target-ppc: Implement bcdtrunc. instruction

2016-12-07 Thread David Gibson
On Tue, Dec 06, 2016 at 05:40:09PM -0200, Jose Ricardo Ziviani wrote: > bcdtrunc.: Decimal integer truncate. Given a BCD number in vrb and the > number of bytes to truncate in vra, the return register will have vrb > with such bits truncated. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence

2016-12-07 Thread Zhang Chen
On 12/02/2016 03:57 PM, Laurent Vivier wrote: On 02/12/2016 03:59, Zhang Chen wrote: On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Longpeng (Mike)
On 2016/12/7 16:52, Gonglei (Arei) wrote: >> -Original Message- >> From: longpeng >> Sent: Wednesday, December 07, 2016 4:34 PM >> To: berra...@redhat.com; ebl...@redhat.com; arm...@redhat.com; >> Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; Wubin (H); Zhoujian (jay, Euler); longpeng >>

Re: [Qemu-devel] [PATCH for-2.9 1/2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-07 Thread Longpeng (Mike)
Hi Daniel, On 2016/12/7 17:37, Daniel P. Berrange wrote: > On Wed, Dec 07, 2016 at 04:33:41PM +0800, Longpeng(Mike) wrote: .. >> diff --git a/qapi/crypto.json b/qapi/crypto.json >> index 5c9d7d4..848b6cd 100644 >> --- a/qapi/crypto.json >> +++ b/qapi/crypto.json >> @@ -63,6 +63,7 @@ >> #

Re: [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-07 Thread Herbert Xu
On Tue, Dec 06, 2016 at 09:01:49AM +, Gonglei (Arei) wrote: > > Would you please review and/or ack the virtio_crypto_algs.c? > It is the realization of specified algs based on Linux Crypto Framework. I have no issues with it. If the virtio folks are happy with the interface with the host

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-07 Thread Avi Kivity
On 12/01/2016 04:35 PM, Paolo Bonzini wrote: Maybe we could do the same for sockets? When data is available on a socket (or when it becomes writable), write to a user memory location. I, too, have an interest in polling; in my situation most of the polling happens in userspace. You are

Re: [Qemu-devel] [RFC for-2.8] machine: Convert abstract typename on compat_props to subclass names

2016-12-07 Thread Greg Kurz
On Tue, 6 Dec 2016 17:31:59 -0200 Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 05:19:52PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > >

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

2016-12-07 Thread Kevin Wolf
Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. It also allows us to inject errors on > those operations, just like we can for

Re: [Qemu-devel] [RFC for-2.8] machine: Convert abstract typename on compat_props to subclass names

2016-12-07 Thread Eduardo Habkost
On Wed, Dec 07, 2016 at 02:39:25PM +0100, Greg Kurz wrote: > On Tue, 6 Dec 2016 17:31:59 -0200 > Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 05:19:52PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > > Since

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.8.0-rc3 is now available

2016-12-07 Thread Michael Roth
Quoting Michael Roth (2016-12-07 08:07:33) > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > fourth release candidate for the QEMU 2.8 release. This release is meant > for testing purposes and should not be used in a production environment. > >

Re: [Qemu-devel] vpc max table entries calculation error

2016-12-07 Thread Kevin Wolf
Am 29.11.2016 um 22:07 hat Nick Owens geschrieben: > i'm writing to discuss an issue in qemu's vpc creation. > > when creating a dynamic-type vpc image with qemu-img like so: > > $ qemu-img create -f vpc vhd.vhd 100M > Formatting 'vhd.vhd', fmt=vpc size=104857600 > > and then inspecting the

  1   2   >