[Qemu-devel] [PULL 0/4] tcg fixes

2017-01-13 Thread Richard Henderson
remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-01-13 14:38:21 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20170113 for you to fetch changes up to 8cf9a3d3f7a4b95f33e0bda5416b9c

[Qemu-devel] [PULL 2/4] target/arm: Fix ubfx et al for aarch64

2017-01-13 Thread Richard Henderson
The patch in 59a71b4c5b4e suffered from a merge failure when compared to the original patch in http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg00137.html Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-13 Thread Lluís Vilanova
Paolo Bonzini writes: > On 12/01/2017 20:37, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >>> On Tue, Jan 10, 2017 at 05:31:37PM +0100, Paolo Bonzini wrote: On 09/01/2017 18:01, Stefan Hajnoczi wrote: > Or use a simpler scheme: > > struct CPUState { > ... > uint32

Re: [Qemu-devel] [PATCH v3 5/5] target-m68k: increment/decrement with SP

2017-01-13 Thread Richard Henderson
On 01/13/2017 10:36 AM, Laurent Vivier wrote: > On 680x0 family only. > > Address Register indirect With postincrement: > > When using the stack pointer (A7) with byte size data, the register > is incremented by two. > > Address Register indirect With predecrement: > > When using the stack poin

[Qemu-devel] [PATCH v7 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache

2017-01-13 Thread Lluís Vilanova
The function is reused in later patches. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- cputlb.c|2 +- include/exec/exec-all.h |6 ++ translate-all.c | 14 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/cput

[Qemu-devel] [PATCH v7 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2017-01-13 Thread Lluís Vilanova
Optimizes tracing of events with the 'tcg' and 'vcpu' properties (e.g., memory accesses), making it feasible to statically enable them by default on all QEMU builds. Some quick'n'dirty numbers with 400.perlbench (SPECcpu2006) on the train input (medium size - suns.pl) and the guest_mem_before even

[Qemu-devel] [PATCH v7 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events

2017-01-13 Thread Lluís Vilanova
If an event is dynamically disabled, the TCG code that calls the execution-time tracer is not generated. Removes the overheads of execution-time tracers for dynamically disabled events. As a bonus, also avoids checking the event state when the execution-time tracer is called from TCG-generated cod

[Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count() inlinable

2017-01-13 Thread Lluís Vilanova
Later patches will make use of it. Signed-off-by: Lluís Vilanova --- trace/control-internal.h |7 ++- trace/control.c | 11 +++ trace/control.h |4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/trace/control-internal.h b/trace/contr

[Qemu-devel] [PATCH v7 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state

2017-01-13 Thread Lluís Vilanova
Every vCPU now uses a separate set of TBs for each set of dynamic tracing event state values. Each set of TBs can be used by any number of vCPUs to maximize TB reuse when vCPUs have the same tracing state. This feature is later used by tracetool to optimize tracing of guest code events. The maxim

[Qemu-devel] [PATCH v6 2/9] block: Change bdrv_get_encrypted_filename()

2017-01-13 Thread Max Reitz
Instead of returning a pointer to the filename, g_strdup() it. This will become necessary once we do not have BlockDriverState.filename anymore. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- include/block/block.h | 2 +- block.c | 17 ++

[Qemu-devel] [PATCH v6 4/9] block: Do not blindly copy filename from file

2017-01-13 Thread Max Reitz
bdrv_refresh_filename() can do the same and it has some checks whether the filename can actually be inherited or not, so we can let it do its job in bdrv_open_inherit() after bdrv_open_common() has been called. The only thing we need to set in bdrv_open_common() is the exact_filename of a BDS with

[Qemu-devel] [PATCH v7 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-13 Thread Lluís Vilanova
This keeps consistency across all decisions taken during translation when the dynamic state of a vCPU is changed in the middle of translating some guest code. Signed-off-by: Lluís Vilanova --- include/qom/cpu.h |3 +++ qom/cpu.c |2 ++ trace/control-target.c | 21

[Qemu-devel] [PATCH v6 5/9] block: Add bdrv_filename()

2017-01-13 Thread Max Reitz
Split the part which actually refreshes the BlockDriverState.filename field off of bdrv_refresh_filename() into a more generic function bdrv_filename(), which first calls bdrv_refresh_filename() and then stores a qemu-usable filename in the given buffer instead of BlockDriverState.filename. Since

[Qemu-devel] [PATCH v7 6/7] trace: [tcg, trivial] Re-align generated code

2017-01-13 Thread Lluís Vilanova
Last patch removed a nesting level in generated code. Re-align all code generated by backends to be 4-column aligned. Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/dtrace.py |4 ++-- scripts/tracetool/backend/ftrace.py | 20 ++-- scripts/tracetool/backend/log.

[Qemu-devel] [PATCH v7 7/7] trace: [trivial] Statically enable all guest events

2017-01-13 Thread Lluís Vilanova
The optimizations of this series makes it feasible to have them available on all builds. Signed-off-by: Lluís Vilanova --- trace-events |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace-events b/trace-events index f74e1d3d22..0a0f4d9cd6 100644 --- a/trace-events

[Qemu-devel] [PATCH v6 1/9] block: Always set *file in get_block_status

2017-01-13 Thread Max Reitz
*file should always be set (to NULL, if nothing else) instead of leaving it dangling sometimes. This should also be documented so callers can rely on this behavior. Signed-off-by: Max Reitz --- block/io.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/io.c b/bloc

[Qemu-devel] [PATCH v6 0/9] block: Drop BDS.filename

2017-01-13 Thread Max Reitz
*** This series is based on v4 of my *** *** "block: Fix some filename generation issues" series *** The BDS filename field is generally only used when opening disk images or emitting error or warning messages, the only exception to this rule is the map command of qemu-img. However, using exact_f

[Qemu-devel] [PATCH v6 3/9] block: Avoid BlockDriverState.filename

2017-01-13 Thread Max Reitz
In places which directly pass a filename to the OS, we should not use the filename field at all but exact_filename instead (although the former currently equals the latter if that is set). In raw_open_common(), we do not need to access BDS.filename because we already have a local variable pointing

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Felipe Franciosi
> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: > > On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: >> >>> On 13 Jan 2017, at 09:04, Michael S. Tsirkin wrote: >>> >>> On Fri, Jan 13, 2017 at 03:09:46PM +, Felipe Franciosi wrote: Hi Marc-Andre, > On 1

Re: [Qemu-devel] [PATCH] virtio_crypto: header update

2017-01-13 Thread Gonglei (Arei)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Saturday, January 14, 2017 12:18 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) > Subject: [PATCH] virtio_crypto: header update > > Update header from latest linux driver. Session creation structs gain

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-13 Thread Gonglei (Arei)
> > On Fri, Jan 13, 2017 at 02:54:29AM +, Gonglei (Arei) wrote: > > > > > > > > On Thu, Jan 12, 2017 at 12:26:24PM +, Gonglei (Arei) wrote: > > > > Hi, > > > > > > > > > > > > > > > > > > On 01/04/2017 11:10 AM, Gonglei (Arei) wrote: > > > > > > Hi all, > > > > > > > > > > > > I attach the

Re: [Qemu-devel] [PATCH RFC v3 00/14] VT-d: vfio enablement and misc enhances

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 05:58:02PM +0200, Michael S. Tsirkin wrote: > On Fri, Jan 13, 2017 at 11:06:26AM +0800, Peter Xu wrote: > > v3: > > - fix style error reported by patchew > > - fix comment in domain switch patch: use "IOMMU address space" rather > > than "IOMMU region" [Kevin] > > - add ac

Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count() inlinable

2017-01-13 Thread Richard Henderson
On 01/13/2017 12:48 PM, Lluís Vilanova wrote: uring and controlling the state of tracing events. * - * Copyright (C) 2011-2016 Lluís Vilanova + * Copyright (C) 2011-2017 Lluís Vilanova * * This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file i

Re: [Qemu-devel] [PATCH v7 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-13 Thread Richard Henderson
On 01/13/2017 12:48 PM, Lluís Vilanova wrote: This keeps consistency across all decisions taken during translation when the dynamic state of a vCPU is changed in the middle of translating some guest code. Signed-off-by: Lluís Vilanova --- include/qom/cpu.h |3 +++ qom/cpu.c

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Richard Henderson
On 01/12/2017 03:46 AM, Stefan Hajnoczi wrote: The virtio_queue_set_notification() nesting introduced for AioContext polling raised an assertion with virtio-net (even in non-polling mode). Converting virtio-net and virtio-crypto to use virtio_queue_set_notification() in a nesting fashion would b

[Qemu-devel] [PATCH] cryptodev: setiv only when really need

2017-01-13 Thread Longpeng(Mike)
ECB mode cipher doesn't need IV, if we setiv for it then qemu crypto API would report "Expected IV size 0 not **", so we should setiv only when the cipher algos really need. Signed-off-by: Longpeng(Mike) --- backends/cryptodev-builtin.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletio

[Qemu-devel] [PATCH] hw/core/null-machine: Add the possibility to instantiate a CPU, RAM and kernel

2017-01-13 Thread Thomas Huth
Sometimes it is useful to have just a machine with CPU and RAM, without any further hardware in it, e.g. if you just want to do some instruction debugging for TCG with a remote GDB attached to QEMU, or run some embedded code with the "-semihosting" QEMU parameter. qemu-system-m68k already features

[Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-01-13 Thread Stafford Horne
I am working on testing instruction emulation patches for the linux kernel. During testing I found these 2 issues: - sets DSX (delay slot exception) but never clears it - EEAR for illegal insns should point to the bad exception (as per openrisc spec) but its not This patch fixes these two is

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Thomas Huth writes: > On 12.01.2017 17:22, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> When running certain HMP commands ("info registers", "info cpustats", >>> "nmi", "memsave" or dumping virtual memory) with the "none" machine, >>> QEMU crashes with a segmentation fault. This happe

Re: [Qemu-devel] [PATCH RFC v3 09/14] memory: introduce memory_region_notify_one()

2017-01-13 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Signed-off-by: Peter Xu --- include/exec/memory.h | 15 +++ memory.c |

[Qemu-devel] [Bug 1654271] Re: host machine freezes

2017-01-13 Thread Thomas Huth
Moving this to the Ubuntu-qemu bug tracker since you're apparently using Ubuntu's QEMU, not the upstream QEMU. ** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

[Qemu-devel] [PATCH] sdl2: fix build failure on windows

2017-01-13 Thread Gerd Hoffmann
Cc: Stefan Weil Cc: Samuel Thibault Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9a79b17..91fb111 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -817,9 +817,15 @@ void sdl_display_init(DisplayState *ds, int full_scre

[Qemu-devel] [Bug 886621] Re: Mac OS X Lion: segmentation fault

2017-01-13 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently version 2.8)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

[Qemu-devel] [Bug 917645] Re: [Feature request] ia64-softmmu wanted

2017-01-13 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/917645 Title: [Feature request] ia64-softmmu wanted Status in HelenOS branches: Confirmed S

[Qemu-devel] [Bug 894037] Re: With VNC, "-usbdevice tablet" no longer makes mouse pointers line up

2017-01-13 Thread Thomas Huth
According to comment #6 this has been fixed in version 1.0 ... is there still something left to do here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix()

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 08:12 AM, Cao jin wrote: > Also move certain hunk above, to place msix init related code together. > > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > > Signed-off-by: Cao jin > --- > hw/scsi/megasas.c | 19 +++

Re: [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error

2017-01-13 Thread Markus Armbruster
Cao jin writes: > Only a tiny modification in patch "megasas: remove unnecessary > megasas_use_msix()" to fix a megasas issue. Please have a look at Michael's review in Message-ID: <20170112163519-mutt-send-email-...@kernel.org> > v8 changelog: > 1. reorder: place the "megasas: remove unnecessa

[Qemu-devel] [Bug 893068] Re: Spanish keys { and [ did not work

2017-01-13 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently version 2.8)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

Re: [Qemu-devel] [PATCH v8 10/10] megasas: remove unnecessary megasas_use_msix()

2017-01-13 Thread Markus Armbruster
Cao jin writes: > Also move certain hunk above, to place msix init related code together. > > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > > Signed-off-by: Cao jin > --- > hw/scsi/megasas.c | 19 ++- > 1 f

Re: [Qemu-devel] [PATCH v8 00/10] Convert msix_init() to error

2017-01-13 Thread Cao jin
On 01/13/2017 04:22 PM, Markus Armbruster wrote: > Cao jin writes: > >> Only a tiny modification in patch "megasas: remove unnecessary >> megasas_use_msix()" to fix a megasas issue. > > Please have a look at Michael's review in > Message-ID: <20170112163519-mutt-send-email-...@kernel.org> >

Re: [Qemu-devel] [PATCH] sdl2: fix build failure on windows

2017-01-13 Thread Stefan Weil
Am 13.01.2017 um 09:14 schrieb Gerd Hoffmann: > Cc: Stefan Weil > Cc: Samuel Thibault > Signed-off-by: Gerd Hoffmann > --- > ui/sdl2.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index 9a79b17..91fb111 100644 > --- a/ui/sdl2.c > +++ b/ui/sdl2.c > @@ -8

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-13 Thread Gerd Hoffmann
Hi, > Sure, thanks for the pointers! > I suppose I can change later to msi-x in a follow up patch > to avoid introducing new bugs from the beginning :) I'd use msi-x right from start to avoid any backward compatibility issues. cheers, Gerd

[Qemu-devel] [Bug 1656234] [NEW] Qemu core dumped if using virtio-net

2017-01-13 Thread Robert Hu
Public bug reported: System Environment === Qemu commit/branch: e92fbc75 Host OS: RHEL7.2 ia32e Host Kernel: 4.9.0 Guest OS: RHEL7.2 ia32e Guest Kernel: 4.9.0 Bug detailed description === While create a kvm guest using virtio-net, the qemu will core dump with showing "Aborted (core dumpe

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-13 Thread Xiao Guangrong
On 01/13/2017 11:02 AM, Li Qiang wrote: From: Li Qiang The spec doesn't say the namespace label can't be zero when read/write it. As this is no harmful, just allow it. WHY? The spec said that the label should be at least 128K.

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not > >good, and we should end the day when we need to recompile the code > >before getting useful debugging information for

Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h

2017-01-13 Thread Christian Borntraeger
On 01/11/2017 03:17 AM, Richard Henderson wrote: > This lets us expose facilities to TCG_TARGET_HAS_* defines > directly, rather than hiding behind function calls. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.h | 126 > -- > tc

[Qemu-devel] [PATCH v2 0/2] POWER9 TCG enablements - part12

2017-01-13 Thread Nikunj A Dadhania
This series contains 5 new instructions for POWER9 ISA3.0 VSX Scalar Test Data Class VSX Vector Test Data Class Changelog: v1: * Zero the match variable in the element loops v0: * Concise logic for identifying data class in Scalar/Vector test data class instructions Nikunj A Dadhania

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:55:22PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >In this patch, IOMMUNotifier.{start|end} are introduced to store section > >information for a specific notifier. When notification occurs, we not > >only check the notification type (MAP|UNM

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-13 Thread Li, Liang Z
> On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > Add a new feature which supports sending the page information with > > range array. The current implementation uses PFNs array, which is not > > very efficient. Using ranges can improve the performance of > > inflating/deflating signif

[Qemu-devel] [PATCH v2 2/2] target-ppc: Add xststdc[sp, dp, qp] instructions

2017-01-13 Thread Nikunj A Dadhania
xststdcsp: VSX Scalar Test Data Class Single-Precision xststdcdp: VSX Scalar Test Data Class Double-Precision xststdcqp: VSX Scalar Test Data Class Quad-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 66 - target/ppc/helpe

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-13 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally bring a dead loop when guest starts. I think it just takes too much time instead of dead loop? The solu

[Qemu-devel] [PATCH v2 1/2] target-ppc: Add xvtstdc[sp, dp] instructions

2017-01-13 Thread Nikunj A Dadhania
xvtstdcsp: VSX Vector Test Data Class Single-Precision xvtstdcdp: VSX Vector Test Data Class Double-Precision Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 40 + target/ppc/helper.h | 2 ++ target/ppc/internal.h

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Jason Wang
On 2017年01月13日 17:13, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting usef

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Jason Wang
On 2017年01月13日 17:23, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:55:22PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check th

Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-01-11

2017-01-13 Thread Peter Maydell
On 11 January 2017 at 19:34, Paolo Bonzini wrote: > The following changes since commit 41a0e54756a9ae6b60be34bb33302a7e085fdb07: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-01-10 10:46:21 +) > > are available in the git repository at: > > > git://

Re: [Qemu-devel] [PULL 0/4] migration: QTAILQ migration

2017-01-13 Thread Peter Maydell
On 13 January 2017 at 03:37, Amit Shah wrote: > On (Fri) 06 Jan 2017 [12:10:22], Peter Maydell wrote: >> On 5 January 2017 at 16:32, Amit Shah wrote: >> > The following changes since commit >> > dbe2b65566e76d3c3a0c3358285c0336ac61e757: >> > >> > Merge remote-tracking branch >> > 'remotes/viv

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-13 Thread Vladimir Sementsov-Ogievskiy
12.01.2017 16:11, Alex Bligh wrote: On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy wrote: Yes this is better. But is it actually needed to force contexts have some safe default? If context wants it may define such default without this requirement.. So, should it be requirement at all

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Markus Armbruster writes: > Thomas Huth writes: > >> On 12.01.2017 17:22, Markus Armbruster wrote: >>> Thomas Huth writes: >>> When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes

Re: [Qemu-devel] [PATCH] virtio-ccw: fix ring sizing

2017-01-13 Thread Cornelia Huck
On Thu, 12 Jan 2017 23:26:22 +0200 "Michael S. Tsirkin" wrote: > Current code seems to assume ring size is > always decreased but this is not required by spec: > what spec says is just that size can not exceed > the maximum. Fix it up. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/v

Re: [Qemu-devel] [PATCH v6 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:44 +0100 Laszlo Ersek wrote: > Introduce the following fw_cfg files: > > - "etc/smi/supported-features": a little endian uint64_t feature bitmap, > presenting the features known by the host to the guest. Read-only for > the guest. > > The content of this file wil

Re: [Qemu-devel] [PATCH RFC v3 07/14] memory: add section range info for IOMMU notifier

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 05:37:43PM +0800, Jason Wang wrote: [...] > >>>diff --git a/memory.c b/memory.c > >>>index 2bfc37f..e88bb54 100644 > >>>--- a/memory.c > >>>+++ b/memory.c > >>>@@ -1671,7 +1671,9 @@ void memory_region_notify_iommu(MemoryRegion *mr, > >>> } > >>> QLIST_FOREACH(iom

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-13 Thread Alex Bligh
> On 13 Jan 2017, at 09:48, Vladimir Sementsov-Ogievskiy > wrote: > > 12.01.2017 16:11, Alex Bligh wrote: >>> On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> Yes this is better. But is it actually needed to force contexts have some >>> safe default? If context want

Re: [Qemu-devel] [PATCH RFC v3 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

2017-01-13 Thread Markus Armbruster
Dou Liyang writes: > In order to reduce the execution time, this patch optimize > the qmp_query_blockstats(): > Remove the next_query_bds function. > Remove the bdrv_query_stats function. > Remove some judgement sentence. > > The original qmp_query_blockstats calls next_query_bds to get > the nex

[Qemu-devel] Data corruption in Qemu 2.7.1

2017-01-13 Thread Peter Lieven
Hi, i currently facing a problem in our testing environment where I see file system corruption with 2.7.1 on iSCSI and Local Storage (LVM). Trying to bisect, but has anyone observed this before? Thanks, Peter

Re: [Qemu-devel] [PATCH RFC v3 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-13 Thread Markus Armbruster
Dou Liyang writes: > Change log v2 -> v3: > 1. Remove the unnecessary code for the bdrv_next_node(). > 2. Remove the change of the locking rules. > Even if this change can improve the performance, but it may > effect the consistency. > > For the multi-disks guest, we can use the datapla

Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112

2017-01-13 Thread Peter Maydell
On 12 January 2017 at 02:02, David Gibson wrote: > The following changes since commit b44486dfb9447c88e4b216e730adcc780190852c: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20170110-1' into > staging (2017-01-10 14:52:34 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] ahci: advertise HOST_CAP_64

2017-01-13 Thread Ladi Prosek
The AHCI emulation code supports 64-bit addressing and should advertise this fact in the Host Capabilities register. Both Linux and Windows drivers test this bit to decide if the upper 32 bits of various registers may be written to, and at least some versions of Windows have a bug where DMA is atte

Re: [Qemu-devel] [PULL 00/67] ppc-for-2.9 queue 20170112

2017-01-13 Thread Laurent Vivier
On 13/01/2017 11:54, Peter Maydell wrote: > Q: can we just enable these tests for PCI with > check-qtest-ppc64-y += $(check-qtest-pci-y) > gcov-files-ppc64-y += $(gcov-files-pci-y) > > the way we do for i386/x86_64 ? Or is that doing too much > unwanted extra testing? For most of the devices test

Re: [Qemu-devel] [PATCH v6 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-13 Thread Laszlo Ersek
On 01/13/17 11:15, Igor Mammedov wrote: > On Thu, 12 Jan 2017 19:24:44 +0100 > Laszlo Ersek wrote: > >> Introduce the following fw_cfg files: >> >> - "etc/smi/supported-features": a little endian uint64_t feature bitmap, >> presenting the features known by the host to the guest. Read-only for >

Re: [Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Thomas Huth
On 13.01.2017 08:59, Markus Armbruster wrote: > Thomas Huth writes: > >> On 12.01.2017 17:22, Markus Armbruster wrote: >>> Thomas Huth writes: >>> When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping virtual memory) with the "none" machine,

[Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Haozhong Zhang
The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. Reported-by: Stefan Hajnoczi Signed-off-by: Haozhong Zhang Message-Id: 20170112110928.GF4621@stefanha-x1.localdomain Messag

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > > The virtio_queue_set_notification() nesting introduced for AioContext > > polling > > raised an assertion with virtio-net (even in non-polling mode). Converting > > virtio-net and virt

[Qemu-devel] [PATCH v4] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Thomas Huth
When running certain HMP commands ("info registers", "info cpustats", "info tlb", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes with a segmentation fault. This happens because the "none" machine does not have any CPUs by default, but these HMP commands did not ch

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-13 Thread Mark Cave-Ayland
On 12/01/17 12:57, Hervé Poussineau wrote: > Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >> Hi Hervé, >> >> nice work! >> >> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >> wrote: >>> Hi, >>> >>> This patchset adds the emulation of the IBM RS/6000 7020 (40p). The >>> real machine is >

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Xiao Guangrong
On 01/13/2017 07:56 PM, Haozhong Zhang wrote: The missing of 'nvdimm' in the machine type option '-M' means NVDIMM is disabled. QEMU should refuse to plug any NVDIMM device in this case and report the misconfiguration. Thanks for your fix. Reviewed-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v3 3/3] cputlb: drop flush_global flag from tlb_flush

2017-01-13 Thread Alex Bennée
Richard Henderson writes: > On 01/12/2017 08:03 AM, Alex Bennée wrote: >> And I immediately realise I missed out: >> >>> Signed-off-by: Alex Bennée >>> Reviewed-by: Richard Henderson >> [DG: ppc portions] >> Acked-by: David Gibson >> >> Do you want me to re-post or can you apply when you take

[Qemu-devel] system_clock_scale unset in hw/intc/armv7m_nvic.c

2017-01-13 Thread James Hanley
How should system_clock_scale be set in hw/intc/armv7m_nvic.c - there is no API for the global, and I've defaulted the global to SYSTICK_SCALE which seems to work, but is not obvious. This was needed as this value was set to zero and the arm firmware was selecting the external clock source causing

Re: [Qemu-devel] [Qemu-discuss] system_clock_scale unset in hw/intc/armv7m_nvic.c

2017-01-13 Thread Peter Maydell
On 13 January 2017 at 12:35, James Hanley wrote: > How should system_clock_scale be set in hw/intc/armv7m_nvic.c - there is no > API for the global, and I've defaulted the global to SYSTICK_SCALE which > seems to work, but is not obvious. This was needed as this value was set to > zero and the ar

Re: [Qemu-devel] [PATCH v4] monitor: Fix crashes when using HMP commands without CPU

2017-01-13 Thread Markus Armbruster
Thomas Huth writes: > When running certain HMP commands ("info registers", "info cpustats", > "info tlb", "nmi", "memsave" or dumping virtual memory) with the "none" > machine, QEMU crashes with a segmentation fault. This happens because the > "none" machine does not have any CPUs by default, but

Re: [Qemu-devel] [PATCH v4 0/2] Fixes/tests for hmp_object_del()

2017-01-13 Thread Markus Armbruster
Andreas, please have a look. Feel free to ask me to take it through my tree. Michael Roth writes: > hmp_object_del() followed by a subsequent hmp_object_add() can trigger a > duplicate ID error if the previous object shared the same ID and was added > via the command-line. Please see patch 2/2

[Qemu-devel] [PATCH v2 0/5] Fixes for target/m68k

2017-01-13 Thread Laurent Vivier
This is a series of fixes for target/m68k found: - with RISU (bit operation with immediate) - while debugging package build under chroot (gen_flush_flags() and CAS address modes) - while I was working on the softmmu mode (CAS alignment and SP address modes) v2: - Don't align stack access on co

[Qemu-devel] [PATCH v2 2/5] target-m68k: fix gen_flush_flags()

2017-01-13 Thread Laurent Vivier
gen_flush_flags() is setting unconditionally cc_op_synced to 1 and s->cc_op to CC_OP_FLAGS, whereas env->cc_op can be set to something else by a previous tcg fragment. We fix that by not setting cc_op_synced to 1 (except for gen_helper_flush_flags() that updates env->cc_op) FIX: https://github.co

[Qemu-devel] [PATCH v2 1/5] target-m68k: fix bit operation with immediate value

2017-01-13 Thread Laurent Vivier
M680x0 bit operations with an immediate value use 9 bits of the 16bit value, while coldfire ones use only 8 bits. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/tra

[Qemu-devel] [PATCH v2 3/5] target-m68k: manage pre-dec et post-inc in CAS

2017-01-13 Thread Laurent Vivier
In these cases we must update the address register after the operation. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 0e97900..23e2b06 100644 --- a/target/m68k/transla

[Qemu-devel] [PATCH v2 5/5] target-m68k: increment/decrement with SP

2017-01-13 Thread Laurent Vivier
On 680x0 family only. Address Register indirect With postincrement: When using the stack pointer (A7) with byte size data, the register is incremented by two. Address Register indirect With predecrement: When using the stack pointer (A7) with byte size data, the register is decremented by two.

[Qemu-devel] [PATCH v2 4/5] target-m68k: CAS doesn't need aligned access

2017-01-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 23e2b06..cf5d8dd 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1934,7 +1934,6 @@ DISAS_INSN(cas) defau

Re: [Qemu-devel] [PATCH v2 5/5] target-m68k: increment/decrement with SP

2017-01-13 Thread Thomas Huth
On 13.01.2017 13:52, Laurent Vivier wrote: > On 680x0 family only. > > Address Register indirect With postincrement: > > When using the stack pointer (A7) with byte size data, the register > is incremented by two. > > Address Register indirect With predecrement: > > When using the stack pointer

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-13 Thread Igor Mammedov
On Thu, 12 Jan 2017 19:24:45 +0100 Laszlo Ersek wrote: > The generic edk2 SMM infrastructure prefers > EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If > Trigger() only brings the current processor into SMM, then edk2 handles it > in the following ways: > > (1) If Trigg

[Qemu-devel] [PATCH 03/16] test-thread-pool: use generic AioContext infrastructure

2017-01-13 Thread Paolo Bonzini
Once the thread pool starts using aio_co_wake, it will also need qemu_get_current_aio_context(). Make test-thread-pool create an AioContext with qemu_init_main_loop, so that stubs/iothread.c and tests/iothread.c can provide the rest. Signed-off-by: Paolo Bonzini --- tests/test-thread-pool.c | 1

[Qemu-devel] [PATCH 02/16] block-backend: allow blk_prw from coroutine context

2017-01-13 Thread Paolo Bonzini
qcow2_create2 calls this. Do not run a nested event loop, as that breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup list of the currently running one. Signed-off-by: Paolo Bonzini --- block/block-backend.c | 12 1 file changed, 8 insertions(+), 4 deletions

[Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-13 Thread Paolo Bonzini
This is in preparation for making qio_channel_yield work on AioContexts other than the main one. Signed-off-by: Paolo Bonzini --- include/io/channel.h | 30 ++ io/channel-command.c | 13 + io/channel-file.c| 11 +++ io/channel-socket.c | 16 ++

[Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-13 Thread Paolo Bonzini
This series pushes down aio_context_acquire/release to the point where we can actually reason on using different fine-grained mutexes. The main infrastructure is introduced in patch 1. The new API aio_co_wake starts a coroutine with aio_context_acquire/release protection, which requires tracking

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-13 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: > The missing of 'nvdimm' in the machine type option '-M' means NVDIMM > is disabled. QEMU should refuse to plug any NVDIMM device in this case > and report the misconfiguration. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Haoz

[Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-13 Thread Paolo Bonzini
Support separate coroutines for reading and writing, and place the read/write handlers on the AioContext that the QIOChannel is registered with. Signed-off-by: Paolo Bonzini --- include/io/channel.h | 37 ++ io/channel.c | 86 ++

[Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-13 Thread Paolo Bonzini
aio_co_wake provides the infrastructure to start a coroutine on a "home" AioContext. It will be used by CoMutex and CoQueue, so that coroutines don't jump from one context to another when they go to sleep on a mutex or waitqueue. However, it can also be used as a more efficient alternative to one

[Qemu-devel] [PATCH 07/16] coroutine-lock: reschedule coroutine on the AioContext it was running on

2017-01-13 Thread Paolo Bonzini
As a small step towards the introduction of multiqueue, we want coroutines to remain on the same AioContext that started them, unless they are moved explicitly with e.g. aio_co_schedule. This patch avoids that coroutines switch AioContext when they use a CoMutex. For now it does not make much of a

[Qemu-devel] [PATCH 12/16] block: explicitly acquire aiocontext in bottom halves that need it

2017-01-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- async.c | 4 ++-- block/archipelago.c | 3 +++ block/blkdebug.c | 9 + block/blkreplay.c | 2 +- block/block-backend.c | 6 ++ block/curl.c | 26 ++ block/gluster.c | 9 + bl

[Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads

2017-01-13 Thread Paolo Bonzini
Read the replies from a coroutine, switching the read side between the "read header" coroutine and the I/O coroutine that reads the body of the reply. qio_channel_yield is used so that the right coroutine is restarted automatically, eliminating the need for send_coroutine in NBDClientSession. Sig

[Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks that need it

2017-01-13 Thread Paolo Bonzini
This covers both file descriptor callbacks and polling callbacks, since they execute related code. Signed-off-by: Paolo Bonzini --- aio-posix.c | 7 --- aio-win32.c | 6 -- block/curl.c | 16 +--- block/iscsi.c | 4 block/linux-aio

[Qemu-devel] [PATCH 08/16] qed: introduce qed_aio_start_io and qed_aio_next_io_cb

2017-01-13 Thread Paolo Bonzini
qed_aio_start_io and qed_aio_next_io will not have to acquire/release the AioContext, while qed_aio_next_io_cb will. Split the functionality and gain a little type-safety in the process. Signed-off-by: Paolo Bonzini --- block/qed.c | 39 +-- 1 file changed, 2

  1   2   3   >