Re: [Qemu-devel] iommu emulation

On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: [...] > > Alex, do you like something like below to fix above issue that Jintack > > has encountered? > > > > (note: this code is not for compile, only trying show what I mean...) > > > > --8<--- > > diff --git

Re: [Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

Richard Henderson writes: > On 02/14/2017 02:05 PM, Nikunj A Dadhania wrote: >> Yes, you are right. I had a discussion with Paul Mackerras yesterday, he >> explained to me in detail about the bits. I am working on the revised >> implementation. Will detail it in the commit

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

On 2017年02月16日 11:25, Zhang Chen wrote: Ping... No new for a long time. Who can pick up this patch? I believe you'd better cc migration maintainers (cced), have you tried scripts/get_maintainer ? Thanks Thanks Zhang Chen On 02/14/2017 04:28 AM, Stefano Stabellini wrote: On Wed,

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017/2/16 10:27, Zhang Chen wrote: On 02/15/2017 04:34 PM, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by:

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

On 2017年02月16日 13:43, Jason Wang wrote: On 2017年02月16日 13:36, Liu, Yi L wrote: -Original Message- From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On Behalf Of Michael S. Tsirkin Sent: Tuesday, January 10, 2017 1:40 PM To: qemu-devel@nongnu.org Cc: Peter

Re: [Qemu-devel] [PATCH v6 3/7] ACPI: Add vmgenid blob storage to the build tables

> On Feb 15, 2017, at 6:30 AM, Laszlo Ersek wrote: > > On 02/15/17 07:15, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> This allows them to be centrally initialized and destroyed >> >> The "AcpiBuildTables.vmgenid" array will be used to

[Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

On Thu, Feb 16, 2017 at 10:18:00AM +0800, Cao jin wrote: > Hi peter > > On 02/14/2017 03:51 PM, Peter Xu wrote: > > When we add PCIe extended capabilities, we should be following the rule > > that we add the head extended cap (at offset 0x100) first, then the rest > > of them. Meanwhile, we are

Re: [Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

On Thu, Feb 16, 2017 at 09:13:31AM +1100, Richard Henderson wrote: > On 02/15/2017 05:37 PM, Bharata B Rao wrote: > > + * > > + * TODO: When float128_muladd() becomes available, switch this > > + * implementation to use that instead of separate float128_mul() > > + * followed by float128_add(). >

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 13, 2017 at 6:57 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: >> +static int vxhs_parse_uri(const char *filename, QDict *options) >> +{ >> +URI *uri = NULL; >> +char *hoststr, *portstr; >> +char *port; >> +

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

On Thu, Feb 16, 2017 at 01:48:42PM +1100, David Gibson wrote: > On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > > On 02/15/2017 03:45 AM, David Gibson wrote: > > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > > On 02/14/2017 06:15 AM, David Gibson

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

> On Feb 15, 2017, at 7:24 AM, Laszlo Ersek wrote: > > On 02/15/17 13:19, Igor Mammedov wrote: >> On Tue, 14 Feb 2017 22:15:46 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren >>> >>> This implements the VM Generation ID feature by

Re: [Qemu-devel] [PATCH v6 5/7] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

> On Feb 15, 2017, at 7:36 AM, Laszlo Ersek wrote: > > Two questions: > > On 02/15/17 07:15, b...@skyportsystems.com > wrote: >> From: Igor Mammedov >> >> Add commands to query Virtual Machine Generation ID counter. >>

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang --- net/colo-compare.c | 20

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

Ping... No new for a long time. Who can pick up this patch? Thanks Zhang Chen On 02/14/2017 04:28 AM, Stefano Stabellini wrote: On Wed, 8 Feb 2017, Eric Blake wrote: On 02/07/2017 11:24 PM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Xen colo will

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

On 2017年02月16日 13:36, Liu, Yi L wrote: -Original Message- From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On Behalf Of Michael S. Tsirkin Sent: Tuesday, January 10, 2017 1:40 PM To: qemu-devel@nongnu.org Cc: Peter Maydell ; Eduardo

[Qemu-devel] [PATCH v2 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while call qemu_chr_fe_set_handlers(); Fix it by pass

[Qemu-devel] [PATCH v7 7/8] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID both from guest memory and from the monitor * test that the "auto" argument to the GUID generates a valid GUID, as seen by the

Re: [Qemu-devel] [PATCH 14/17] qmp: add x-debug-block-dirty-bitmap-sha256

16.02.2017 03:35, John Snow wrote: On 02/13/2017 04:54 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz This is simply the same as the version in the other two series, right? Yes.

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Wed, Feb 15, 2017 at 07:52:35PM -0700, Alex Williamson wrote: > On Thu, 16 Feb 2017 10:35:28 +0800 > Peter Xu wrote: > > > On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > > > VFIO actually wants to create a capability with ID == 0. > > > This is done

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

On Wed, Feb 15, 2017 at 04:25:05PM +0200, Marcel Apfelbaum wrote: > On 02/14/2017 09:51 AM, Peter Xu wrote: > >When we add PCIe extended capabilities, we should be following the rule > >that we add the head extended cap (at offset 0x100) first, then the rest > >of them. Meanwhile, we are always

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > VFIO actually wants to create a capability with ID == 0. > This is done to make guest drivers skip the given capability. > pcie_add_capability then trips up on this capability > when looking for end of capability list. > > To

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 2017年02月16日 10:25, Zhang Chen wrote: @@ -703,13 +704,11 @@ static void colo_compare_finalize(Object *obj) qemu_chr_fe_deinit(>chr_sec_in); qemu_chr_fe_deinit(>chr_out); -g_queue_free(>conn_list); +g_main_loop_quit(s->compare_loop); +qemu_thread_join(>thread); -

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017年02月16日 10:43, Hailiang Zhang wrote: On 2017/2/16 10:34, Jason Wang wrote: On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug.

Re: [Qemu-devel] iommu emulation

On Thu, 16 Feb 2017 10:28:39 +0800 Peter Xu wrote: > On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: > > [...] > > > > Alex, do you like something like below to fix above issue that Jintack > > > has encountered? > > > > > > (note: this code is not for

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > On 02/15/2017 03:45 AM, David Gibson wrote: > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > On 02/14/2017 06:15 AM, David Gibson wrote: > > > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Check for valid page size when hot plugging memory

On Wed, Feb 15, 2017 at 10:21:44AM +0100, Thomas Huth wrote: > On POWER, the valid page sizes that the guest can use are bound > to the CPU and not to the memory region. QEMU already has some > fancy logic to find out the right maximum memory size to tell > it to the guest during boot (see

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

Sorry, pressed the "send" button instead of "expand text" on the previous email ... On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >>

[Qemu-devel] [PATCH v2 0/4] colo-compare: fix some bugs

This series includes two parts: codes optimization and bug fix. patch 1 tries to move timer process into colo compare thread as a new coroutine. patch 2 ~ 4 fixe some bugs of colo compare. v2: - Squash patch 3 of last version into patch 2. (ZhangChen's suggestion) zhanghailiang (4):

[Qemu-devel] [PATCH v7 3/8] ACPI: Add vmgenid blob storage to the build tables

From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid_guid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() ->

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 02/15/2017 04:34 PM, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang --- net/colo-compare.c | 20

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 02/15/2017 04:34 PM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 2017/2/16 10:25, Zhang Chen wrote: On 02/15/2017 04:34 PM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017/2/16 10:34, Jason Wang wrote: On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >> b/tests/qemu-iotests/common.config >> index f6384fb..c7a80c0 100644 >> ---

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Thu, 16 Feb 2017 10:35:28 +0800 Peter Xu wrote: > On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > > VFIO actually wants to create a capability with ID == 0. > > This is done to make guest drivers skip the given capability. > > pcie_add_capability then

[Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But the original logic is not correct, we didn't remove the right fd because we call g_main_context_find_source_by_id(NULL, tag) which always try to

[Qemu-devel] [PATCH v2 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if (qemu_thread_is_self(>thread))' branch. Before compare thead exits,

[Qemu-devel] [PATCH v3 6/8] blockdev: Improve message for orphaned -drive

We warn when a -drive isn't supported by the machine type (commit a66c9dc): $ qemu-system-x86_64 -S -display none -drive if=mtd Warning: Orphaned drive without device: id=mtd0,file=,if=mtd,bus=0,unit=0 Improve this to point to the offending bit of configuration: qemu-system-x86_64:

[Qemu-devel] [PATCH v15 03/25] hbitmap: improve dirty iter

Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 --

[Qemu-devel] [PATCH v3 3/8] hw: Default -drive to if=none instead of ide when ide cannot work

Block backends defined with -drive if=ide are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=ide drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Unused

[Qemu-devel] [PATCH v15 16/25] qmp: add persistent flag to block-dirty-bitmap-add

Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c | 18

[Qemu-devel] [PATCH v15 24/25] qmp: block-dirty-bitmap-remove: remove persistent

Remove persistent bitmap from the storage on block-dirty-bitmap-remove. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+)

[Qemu-devel] [PATCH v15 21/25] qcow2-bitmap: refcounts

Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img check implementation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-bitmap.c | 76

Re: [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable

03.02.2017 20:07, Paolo Bonzini wrote: > The function is not needed anymore now that migration is built on > top of QIOChannel. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] m68k: Remove dummy machine

26.01.2017 11:30, Thomas Huth wrote: > Since it is now possible to instantiate a CPU and RAM with the "none" > machine, too, and a kernel can be loaded there with the generic loader > device, there is no more need for the m68k "dummy" machine. Thus let's > remove this unmaintained file now.

[Qemu-devel] [PATCH v15 05/25] block: fix bdrv_dirty_bitmap_granularity signature

Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir

[Qemu-devel] [PATCH v15 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 18 ++

[Qemu-devel] [PATCH v15 02/25] specs/qcow2: do not use wording 'bitmap header'

A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir

[Qemu-devel] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

[Qemu-devel] [PATCH v15 11/25] block: introduce persistent dirty bitmaps

New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-bitmap.c | 487

[Qemu-devel] [PATCH v15 01/25] specs/qcow2: fix bitmap granularity qemu-specific note

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0..dda53dd 100644 ---

Re: [Qemu-devel] [PATCH] CODING_STYLE: Mention preferred comment form

03.02.2017 20:58, Peter Maydell wrote: > Our defacto coding style strongly prefers /* */ style comments > over the single-line // style, and checkpatch enforces this, > but we don't actually document this. Mention it in CODING_STYLE. Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH v15 00/25] qcow2: persistent dirty bitmaps

Hi all! There is a new update of qcow2-bitmap series - v15. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v15 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v15) v15: 13,14: add John's r-b 15: qcow2_can_store_new_dirty_bitmap: -

Re: [Qemu-devel] [Qemu-block] regarding bug name : -hda FAT:. limited to 504MBytes

Am 14.02.2017 um 23:24 hat Thomas Huth geschrieben: > On 14.02.2017 22:38, Shubham Kumar wrote: > > Since the problem seems like the used FAT-16 file system , > > Will it solve the problem if I change the code of vvfat.c for FAT-32 file > > system to increase acceptable file size ? > > As far

Re: [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet

08.02.2017 20:57, Thomas Huth wrote: > The "qemu,register" device needs to be wired up in source code, there > is no way the user can make any real use of this device with the > "-device" parameter or the "device_add" monitor command yet. Applied both v3 patches to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] cadence_gem: Remove unused parameter debug message

Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v3] register: fix incorrect read mask

15.02.2017 01:55, Philippe Mathieu-Daudé wrote: > The register_read() and register_write() functions expect a bitmask argument. > To avoid duplicated code, a new inlined function register_enabled_mask() is > introduced. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] hw/acpi/tco.c: fix tco timer stop

06.02.2017 17:44, Igor Pavlikevich wrote: > TCO timer does not actually stop > > Signed-off-by: Igor Pavlikevich > --- > hw/acpi/tco.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c > index 8ce7daf..b4adac8 100644 > ---

Re: [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi

On 15/02/2017 13:18, Markus Armbruster wrote: > Drives defined with if=scsi get connected to buses created with > -device, unlike other interface types. Deprecate this usage. > > There is no good default SCSI HBA for PC machines. Deprecate if=scsi > there entirely. > > Before this series,

Re: [Qemu-devel] [PATCH v6 2/7] docs: VM Generation ID device description

On Tue, 14 Feb 2017 22:15:44 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This patch is based off an earlier version by > Gal Hammer (gham...@redhat.com) > > Requirements section, ASCII diagrams and overall help > provided by Laszlo Ersek

Re: [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info

On Wed, 02/15 14:42, Vladimir Sementsov-Ogievskiy wrote: > 15.02.2017 14:33, Fam Zheng wrote: > > On Wed, 02/15 14:09, Vladimir Sementsov-Ogievskiy wrote: > > > Currently backup to nbd target is broken, as nbd doesn't have > > > .bdrv_get_info realization. > > > > > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

On 02/13/2017 02:41 PM, Stefan Hajnoczi wrote: > On Fri, Feb 03, 2017 at 07:07:02PM +0100, Halil Pasic wrote: >> >> >> On 02/03/2017 04:37 PM, Michael S. Tsirkin wrote: >>> On Fri, Feb 03, 2017 at 10:33:16AM +, Stefan Hajnoczi wrote: > +\begin{description} > +\item[0] dataq1 >

Re: [Qemu-devel] [PATCH 6/6] coroutine-lock: make CoRwlock thread-safe and fair

On Wed, 02/15 12:20, Paolo Bonzini wrote: > > > On 15/02/2017 10:23, Fam Zheng wrote: > > On Mon, 02/13 19:12, Paolo Bonzini wrote: > >> This adds a CoMutex around the existing CoQueue. Because the write-side > > > > s/CoQueue/CoRwlock/ > > No, I meant that CoRwlock has a CoQueue, and after

[Qemu-devel] [PATCH v2 2/3] hw: Deprecate -drive if=scsi with non-onboard HBAs

Block backends defined with "-drive if=T" with T other than "none" are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. Drives defined with if=scsi are also picked up by SCSI HBAs added with -device, unlike other interface types.

Re: [Qemu-devel] [PATCH 3/9] armv7m: Rewrite NVIC to not use any GIC code

Peter Maydell writes: > From: Michael Davidsaver > > Despite some superficial similarities of register layout, the > M-profile NVIC is really very different from the A-profile GIC. > Our current attempt to reuse the GIC code means that we have >

[Qemu-devel] [PATCH v15 18/25] qmp: add x-debug-block-dirty-bitmap-sha256

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h |

Re: [Qemu-devel] [PATCH] softfloat: Use correct type in float64_to_uint64_round_to_zero()

03.02.2017 21:59, Peter Maydell wrote: > In float64_to_uint64_round_to_zero() a typo meant that we were > taking the uint64_t return value from float64_to_uint64() and > putting it into an int64_t variable before returning it as > uint64_t again. Use uint64_t instead of pointlessly casting it >

Re: [Qemu-devel] [PATCH 6/6] coroutine-lock: make CoRwlock thread-safe and fair

On 15/02/2017 10:23, Fam Zheng wrote: > On Mon, 02/13 19:12, Paolo Bonzini wrote: >> This adds a CoMutex around the existing CoQueue. Because the write-side > > s/CoQueue/CoRwlock/ No, I meant that CoRwlock has a CoQueue, and after this patch it is wrapped by a CoMutex too. >> @@ -375,16

Re: [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info

On Wed, 02/15 14:09, Vladimir Sementsov-Ogievskiy wrote: > Currently backup to nbd target is broken, as nbd doesn't have > .bdrv_get_info realization. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v2: add WARNING > > === > > Since commit > > commit

Re: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and remove some icount special cases

> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 29/01/2017 22:09, Paolo Bonzini wrote: > > The series includes three parts: > > > > 1-2: fix two bugs, the first one pretty bad, the second seems > > to be theoretical only. > > > > 3-5: simplify cpu_exec.

[Qemu-devel] Emulating a Sun Blade 1500, with a Ultrasparc IIIi 1.5 GHz, 2GB ECC RAM. SunOS 5.10

Hello, I have an old Sun Blade 1500, with a Ultrasparc IIIi 1.5 GHz, 2GB ECC RAM. SunOS 5.10, ufs filesystem. The hardware (MB, HDD and video card) is failing on me and I'm searching for a way to emulate it on x86 hardware, I prefer to run the emulator on Linux as OS. I have a DD raw copy of the

[Qemu-devel] [PATCH] cadence_gem: Remove unused parameter debug message

Reported by cppcheck. Signed-off-by: Fam Zheng --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index e99d454..d4de8ad 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -508,7

[Qemu-devel] [PATCH] net: Remove useless local var pkt

This has been pointless since commit 605d52e62, which was a search-and-replace, overlooked the redundancy. Signed-off-by: Fam Zheng --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 1019b50..7f928d7 100644

[Qemu-devel] [PATCH 5/5] colo-compare: Fix removing fds been watched incorrectly in finalization

We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while call qemu_chr_fe_set_handlers(); Fix it by pass

[Qemu-devel] [PATCH] hw/ppc/spapr: Check for valid page size when hot plugging memory

On POWER, the valid page sizes that the guest can use are bound to the CPU and not to the memory region. QEMU already has some fancy logic to find out the right maximum memory size to tell it to the guest during boot (see getrampagesize() in the file target/ppc/kvm.c for more information).

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

Hello, 2017-02-15 7:30 GMT+08:00 John Snow : > > > On 02/09/2017 08:22 PM, Li Qiang wrote: > > Hello John, > > > > 2017-02-10 3:42 GMT+08:00 John Snow > >: > > > > > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > > As the

Re: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and remove some icount special cases

On 15/02/2017 13:45, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> On 29/01/2017 22:09, Paolo Bonzini wrote: >>> The series includes three parts: >>> >>> 1-2: fix two bugs, the first one pretty bad, the second seems >>> to be

Re: [Qemu-devel] [PATCH v6 7/7] tests: Add unit tests for the VM Generation ID feature

On Tue, 14 Feb 2017 22:15:49 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > The following tests are implemented: > * test that a GUID passed in by command line is propagated to the guest. > * test that changing the GUID at runtime via the monitor is

Re: [Qemu-devel] [PATCH v3 07/16] target-m68k: manage FPU exceptions

On 02/07/2017 11:59 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 28 + target/m68k/fpu_helper.c | 107 ++- target/m68k/helper.h | 1 + target/m68k/translate.c | 27

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

Hi Halil, > > On 02/09/2017 03:29 AM, Gonglei (Arei) wrote: > [..] > > Oh, so much work need to be done. > > > > Halil, Would you mind work together with me to perfect the spec? > > And feel free to add your signed-off-by tag. :) > > > > TBH as a non-native English speaker, it's more difficult

Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

Hi, > > On Sat, 2017-02-11 at 10:39 -0500, Paolo Bonzini wrote: > > > > > > > > > > > > > > On 10/02/2017 10:31, Gonglei (Arei) wrote: > > > > > > > > > > But We tested the same cases on Xen platform and VMware, and > > > > > the guest booted successfully. > > > > > > > > Were these two also

Re: [Qemu-devel] [PATCH v3 12/16] target-m68k: add fscale, fgetman, fgetexp and fmod

On 02/07/2017 11:59 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 1 + target/m68k/fpu_helper.c | 56 target/m68k/helper.h | 4 target/m68k/translate.c | 14 4

Re: [Qemu-devel] [PATCH v3 13/16] target-m68k: add fsglmul and fsgldiv

On 02/07/2017 11:59 AM, Laurent Vivier wrote: fsglmul and fsgldiv truncate data to single precision before computing results. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 22 ++ target/m68k/helper.h | 2 ++ target/m68k/translate.c |

Re: [Qemu-devel] [PATCH v3 14/16] target-m68k: add explicit single and double precision operations

On 02/07/2017 11:59 AM, Laurent Vivier wrote: +case 0: /* fmove */ +break; +case 0x40: /* fsmove */ +gen_helper_redf32_FP0(cpu_env); +gen_helper_extf32_FP0(cpu_env); +break; +case 0x44: /* fdmove */ +gen_helper_redf64_FP0(cpu_env); +

Re: [Qemu-devel] [PATCH v3 15/16] target-m68k: add more FPU instructions

On 02/07/2017 11:59 AM, Laurent Vivier wrote: +static long double floatx80_to_ldouble(floatx80 val) +{ +if (floatx80_is_infinity(val)) { +if (floatx80_is_neg(val)) { +return -__builtin_infl(); +} +return __builtin_infl(); +} +if

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

Hi peter On 02/14/2017 03:51 PM, Peter Xu wrote: > When we add PCIe extended capabilities, we should be following the rule > that we add the head extended cap (at offset 0x100) first, then the rest > of them. Meanwhile, we are always adding new capability bits at the end > of the list. Here the

Re: [Qemu-devel] Estimation of qcow2 image size converted from raw image

On 02/15/2017 09:20 AM, Daniel P. Berrange wrote: >> Let's try this syntax: >> >> $ qemu-img query-max-size -f raw -O qcow2 input.raw >> 1234678000 >> >> As John explained, it is only an estimate. But it will be a >> conservative maximum. > > This forces you to have an input file. It would

Re: [Qemu-devel] [PATCH v6 5/7] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

Two questions: On 02/15/17 07:15, b...@skyportsystems.com wrote: > From: Igor Mammedov > > Add commands to query Virtual Machine Generation ID counter. > > QMP command example: > { "execute": "query-vm-generation-id" } > > HMP command example: > info

Re: [Qemu-devel] [PATCH v5 4/7] blkdebug: Add pass-through write_zero and discard support

Am 14.02.2017 um 20:25 hat Eric Blake geschrieben: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. It also allows us to inject errors on > those operations, just like we can for

Re: [Qemu-devel] Estimation of qcow2 image size converted from raw image

On Wed, Feb 15, 2017 at 05:57:12PM +0200, Nir Soffer wrote: > On Wed, Feb 15, 2017 at 5:20 PM, Daniel P. Berrange > wrote: > > On Wed, Feb 15, 2017 at 03:14:19PM +, Stefan Hajnoczi wrote: > >> On Mon, Feb 13, 2017 at 05:46:19PM +0200, Maor Lipchuk wrote: > >> > I was

Re: [Qemu-devel] [Qemu-discuss] Estimation of qcow2 image size converted from raw image

On Wed, Feb 15, 2017 at 05:05:04PM +0100, Alberto Garcia wrote: > On Wed 15 Feb 2017 04:57:12 PM CET, Nir Soffer wrote: > >>> Let's try this syntax: > >>> > >>> $ qemu-img query-max-size -f raw -O qcow2 input.raw > >>> 1234678000 > >>> > >>> As John explained, it is only an estimate. But it

Re: [Qemu-devel] [PATCH 17/18] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 09/02/2017 16:38, Eric Blake wrote: >> +static int blockstatus_to_extent(BlockDriverState *bs, uint64_t offset, >> + uint64_t length, NBDExtent *extent) >> +{ >> +BlockDriverState *file; >> +uint64_t start_sector = offset >> BDRV_SECTOR_BITS; >> +

Re: [Qemu-devel] blockdev-add/del status

On 02/15/2017 09:26 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > What is the status of qmp commands blockdev-add and x-blockdev-del? Is > blockdev-add stable (it never had x- prefix)? What should be done to get > rid of "x-" for x-blockdev-del? We are still working on 'BlockdevOptions'

Re: [Qemu-devel] Estimation of qcow2 image size converted from raw image

On Wed, Feb 15, 2017 at 5:14 PM, Stefan Hajnoczi wrote: > On Mon, Feb 13, 2017 at 05:46:19PM +0200, Maor Lipchuk wrote: >> I was wondering if that is possible to provide a new API that >> estimates the size of >> qcow2 image converted from a raw image. We could use this new

Re: [Qemu-devel] [Qemu-discuss] Estimation of qcow2 image size converted from raw image

On Wed 15 Feb 2017 04:57:12 PM CET, Nir Soffer wrote: >>> Let's try this syntax: >>> >>> $ qemu-img query-max-size -f raw -O qcow2 input.raw >>> 1234678000 >>> >>> As John explained, it is only an estimate. But it will be a >>> conservative maximum. >> >> This forces you to have an input

Re: [Qemu-devel] [PATCH 18/18] nbd: BLOCK_STATUS for standard get_block_status function: client part

On 09/02/2017 17:00, Eric Blake wrote: >> +if (!client->block_status_ok) { >> +*pnum = nb_sectors; >> +ret = BDRV_BLOCK_DATA | BDRV_BLOCK_ALLOCATED; >> +if (bs->drv->protocol_name) { This condition is always true, I think? >> +ret |=

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

> On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: > >> >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov > > wrote: >> >> On Wed, 15 Feb 2017 20:04:40 +0200 >> "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification

Ewww, it looks like I have a mingw disagreement I need to fix; > QEMU_CFLAGS -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/pixman-1 > -I$(SRC_PATH)/dtc/libfdt -Werror -mms-bitfields > -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0 >

  1   2   >