Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 21:34:45 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: > > > As long as all users pass in 0 though there's a real possibility guests > > > will implement this incorrectly. > > We are here to ensure that

[Qemu-devel] [Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2017-02-16 Thread Nadav Goldin
Hi Dave, thanks for looking into this. > Can you clarify what the host and L1 kernels are please? Host - 4.8.15-200.fc24.x86_64 Guest - 3.10.0-514.2.2.el7.x86_64 Results of adding the debug messages and running a simpler command(with master again - 5dae13): [root@vm-el73 ~]#

[Qemu-devel] [PATCH 0/3] qemu-img raw preallocation

2017-02-16 Thread Nir Soffer
This series add missing tests for raw image preallocation, refine preallocation=full and improve documentation. Create on top of the commit 10ddfe7b6044 (qemu-img: Do not truncate before preallocation) from Kevin block branch. Nir Soffer (3): qemu-img: Add tests for raw image preallocation

Re: [Qemu-devel] [PATCH] net: Remove useless local var pkt

2017-02-16 Thread Jason Wang
On 2017年02月15日 16:58, Dmitry Fleytman wrote: Reviewed-by: Dmitry Fleytman This patch also fixes compilation with NET_RX_PKT_DEBUG defined. On 15 Feb 2017, at 10:31 AM, Fam Zheng wrote: This has been pointless since commit 605d52e62, which was a

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Jason Wang
On 2017年02月16日 20:29, Dmitry Fleytman wrote: This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. Dmitry Fleytman (5): eth: Extend vlan stripping functions NetRxPkt: Fix

[Qemu-devel] [PATCH 3/3] qemu-img: Improve documentation for PREALLOC_MODE_FALLOC

2017-02-16 Thread Nir Soffer
Now that we are truncating the file in both PREALLOC_MODE_FULL and PREALLOC_MODE_OFF, not truncating in PREALLOC_MODE_FALLOC looks odd. Add a comment explaining why we do not truncate in this case. Signed-off-by: Nir Soffer --- block/file-posix.c | 7 ++- 1 file changed, 6

[Qemu-devel] [PATCH 1/2] Update README to accomodate markdown format

2017-02-16 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- README | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/README b/README index cb60d05bee..225afd6be7 100644 --- a/README +++ b/README @@ -1,5 +1,5 @@ - QEMU README -

[Qemu-devel] [PATCH 0/2] Add mardown formatting to README

2017-02-16 Thread Pranith Kumar
Also create README.md as a symlink to README so that github displays markdown. Update the README file to markdown so that it makes the github page look prettier. I know that github repo is a mirror and not the official repo, but I think it doesn't hurt to have it in markdown format. The last

[Qemu-devel] [PATCH 2/2] Create README.md as a symlink to README

2017-02-16 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- README.md | 1 + 1 file changed, 1 insertion(+) create mode 12 README.md diff --git a/README.md b/README.md new file mode 12 index 00..100b93820a --- /dev/null +++ b/README.md @@ -0,0 +1 @@ +README \ No newline at end of

Re: [Qemu-devel] [PATCH RFC v2 03/12] s390x/css: add s390-map-css machine option

2017-02-16 Thread Dong Jia Shi
* Dong Jia Shi [2017-01-12 08:25:04 +0100]: > From: Xiao Feng Ren > > We want to support real (i.e. not virtual) channel devices > even for guests that do not support MCSS-E (where guests may > see devices from any channel subsystem

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Peter Xu
On Thu, Feb 16, 2017 at 05:36:06AM +, Liu, Yi L wrote: > > -Original Message- > > From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Tuesday, January 10, 2017 1:40 PM > > To: qemu-devel@nongnu.org > > Cc: Peter

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-16 Thread Fam Zheng
On Thu, 02/16 08:58, Franklin Snaipe Mathieu wrote: > +p = lock_user_string(arg3) > +if (!p) { Please compile test at least, even if it is a trivial patch. Fam

[Qemu-devel] [PATCH 2/3] qemu-img: Truncate before full preallocation

2017-02-16 Thread Nir Soffer
In commit 10ddfe7b6044 (qemu-img: Do not truncate before preallocation) we moved truncate to the PREALLOC_MODE_OFF branch to avoid slowdown in posix_fallocate(). However this change is not optimal when using PREALLOC_MODE_FULL, since knowing the final size from the beginning could allow the file

Re: [Qemu-devel] [PATCH 1/2] Update README to accomodate markdown format

2017-02-16 Thread Nir Soffer
On Fri, Feb 17, 2017 at 2:54 AM, Pranith Kumar wrote: > Signed-off-by: Pranith Kumar > --- > README | 44 +--- > 1 file changed, 21 insertions(+), 23 deletions(-) > > diff --git a/README b/README > index

[Qemu-devel] [PATCH v3 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

2017-02-16 Thread zhanghailiang
We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if (qemu_thread_is_self(>thread))' branch. Before compare thead exits,

[Qemu-devel] [PATCH v3 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

2017-02-16 Thread zhanghailiang
We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while call qemu_chr_fe_set_handlers(); Fix it by pass

[Qemu-devel] [PATCH v3 1/4] colo-compare: use g_timeout_source_new() to process the stale packets

2017-02-16 Thread zhanghailiang
Instead of using qemu timer to process the stale packets, We re-use the colo compare thread to process these packets by creating a new timeout coroutine. Besides, since we process all the same vNIC's net connection/packets in one thread, it is safe to remove the timer_check_lock. Signed-off-by:

[Qemu-devel] [PATCH v3 0/4] colo-compare: fix some bugs

2017-02-16 Thread zhanghailiang
This series includes two parts: codes optimization and bug fix. patch 1 tries to move timer process into colo compare thread as a new coroutine. patch 2 ~ 4 fixe some bugs of colo compare. v2->v3: - change the definition of remove_fd_in_watch() instead of introducing a function (Marc-Andr??

[Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation

2017-02-16 Thread Nir Soffer
Add tests for creating raw image with and without the preallocation option. Signed-off-by: Nir Soffer --- tests/qemu-iotests/175 | 61 ++ tests/qemu-iotests/175.out | 18 ++ tests/qemu-iotests/group | 1 + 3 files

[Qemu-devel] [PATCH v3 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread zhanghailiang
We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But the original logic is not correct, we didn't remove the right fd because we call g_main_context_find_source_by_id(NULL, tag) which always try to

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Jason Wang
On 2017年02月16日 20:39, Peter Maydell wrote: On 16 February 2017 at 12:29, Dmitry Fleytman wrote: This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. I think

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-16 Thread ashish mittal
Hi, I am getting the following error with checkpatch.pl ERROR: externs should be avoided in .c files #78: FILE: block/vxhs.c:28: +QemuUUID qemu_uuid __attribute__ ((weak)); Is there any way to get around this, or does it mean that I would have to add a vxhs.h just for this one entry? Thanks,

[Qemu-devel] [PATCH v8 0/8] Add support for VM Generation ID

2017-02-16 Thread ben
From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This patch set has dependencies on new guest

[Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

[Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Anton Nefedov
also remove a useless NULL check in the event reporting code Signed-off-by: Anton Nefedov --- qapi/event.json | 4 ++-- vl.c| 22 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/qapi/event.json b/qapi/event.json

[Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

2017-02-16 Thread ben
From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID

[Qemu-devel] [PATCH v8 6/8] tests: Move reusable ACPI code into a utility file

2017-02-16 Thread ben
From: Ben Warren Also usable by upcoming VM Generation ID tests Signed-off-by: Ben Warren --- MAINTAINERS | 2 + tests/Makefile.include | 2 +- tests/acpi-utils.c | 65 +++ tests/acpi-utils.h

[Qemu-devel] [PATCH v8 1/8] linker-loader: Add new 'write pointer' command

2017-02-16 Thread ben
From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren

Re: [Qemu-devel] Fix build break during configuration on musl-libc based system

2017-02-16 Thread Felix Janda
Defining _GNU_SOURCE causes musl to define everything including everything protected by _XOPEN_SOURCE. However it does not cause musl to define _XOPEN_SOURCE. On the other hand, the ncurses header specifically checks for _XOPEN_SOURCE or _XOPEN_SOURCE_EXTENDED. So it is not completely clear

[Qemu-devel] [PATCH] iotests: Fix another race in 030

2017-02-16 Thread John Snow
We can't rely on a non-paused job to be present and running for us. Assume that if the job is not present that it completed already. Signed-off-by: John Snow --- tests/qemu-iotests/030 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v8 8/8] MAINTAINERS: Add VM Generation ID entries

2017-02-16 Thread ben
From: Ben Warren Signed-off-by: Ben Warren Reviewed-by: Laszlo Ersek --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 81d4baf..8f5dd35 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH v8 2/8] docs: VM Generation ID device description

2017-02-16 Thread ben
From: Ben Warren This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) Requirements section, ASCII diagrams and overall help provided by Laszlo Ersek (ler...@redhat.com) Signed-off-by: Gal Hammer Signed-off-by: Ben Warren

[Qemu-devel] [PATCH v8 3/8] ACPI: Add vmgenid blob storage to the build tables

2017-02-16 Thread ben
From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid_guid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() ->

[Qemu-devel] [PATCH v8 5/8] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-02-16 Thread ben
From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

2017-02-16 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/16/2017 04:08 PM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >>> On 02/14/2017 02:05 PM, Nikunj A Dadhania wrote: Yes, you are right. I had a discussion with Paul Mackerras yesterday, he explained to

[Qemu-devel] [PATCH v8 3/5] hw/intc/arm_gicv3_kvm: Implement get/put functions

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K This actually implements pre_save and post_load methods for in-kernel vGICv3. Signed-off-by: Pavel Fedin Signed-off-by: Peter Maydell [PMM: * use decimal, not 0bnnn * fixed typo in names of

Re: [Qemu-devel] [PATCH v3 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Marc-André Lureau
Hi - Original Message - > We can call qemu_chr_fe_set_handlers() to add/remove fd been watched > in 'context' which can be either default main context or other explicit > context. But the original logic is not correct, we didn't remove > the right fd because we call

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Liu, Yi L
> -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, February 17, 2017 11:26 AM > To: Liu, Yi L > Cc: Michael S. Tsirkin ; qemu-devel@nongnu.org; Peter > Maydell ; Eduardo Habkost >

Re: [Qemu-devel] [PATCH v3 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

2017-02-16 Thread Zhang Chen
On 02/17/2017 10:53 AM, zhanghailiang wrote: We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while

Re: [Qemu-devel] [PATCH v3 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

2017-02-16 Thread Zhang Chen
On 02/17/2017 10:53 AM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Peter Xu
On Fri, Feb 17, 2017 at 06:36:41AM +, Liu, Yi L wrote: > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, February 17, 2017 11:26 AM > > To: Liu, Yi L > > Cc: Michael S. Tsirkin ; qemu-devel@nongnu.org; Peter > >

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Dmitry Fleytman
> On 17 Feb 2017, at 5:05, Jason Wang wrote: > > > >> On 2017年02月16日 20:39, Peter Maydell wrote: >>> On 16 February 2017 at 12:29, Dmitry Fleytman wrote: >>> This series fix a few issues related >>> to processing of RX packets with VLAN headers. >>>

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Liu, Yi L
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, February 16, 2017 1:44 PM > To: Liu, Yi L ; Michael S. Tsirkin ; > qemu- > de...@nongnu.org > Cc: Peter Maydell ; Eduardo Habkost >

[Qemu-devel] [PATCH v8 1/5] kernel: Add definitions for GICv3 attributes

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K This temporary patch adds kernel API definitions. Use proper header update procedure after these features are released. Signed-off-by: Pavel Fedin Signed-off-by: Vijaya Kumar K ---

[Qemu-devel] [PATCH v8 4/5] target-arm: Add GICv3CPUState in CPUARMState struct

2017-02-16 Thread vijay . kilari
From: Vijaya Kumar K Add gicv3state void pointer to CPUARMState struct to store GICv3CPUState. In case of usecase like CPU reset, we need to reset GICv3CPUState of the CPU. In such scenario, this pointer becomes handy. This patch take care of only GICv3.

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:47, Chad Joan wrote: > I am glad others are chiming in and might provide better solutions. > > Honestly, following the instructions at > http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite > daunting to me, just to get one line of code changed. It might

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-02-16 Thread Jason Wang
On 2017年02月17日 14:18, Liu, Yi L wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, February 16, 2017 1:44 PM To: Liu, Yi L ; Michael S. Tsirkin ; qemu- de...@nongnu.org Cc: Peter Maydell

Re: [Qemu-devel] [PATCH] iotests: Fix another race in 030

2017-02-16 Thread Fam Zheng
On Thu, 02/16 17:00, John Snow wrote: > We can't rely on a non-paused job to be present and running for us. > Assume that if the job is not present that it completed already. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/030 | 5 - > 1 file changed, 4

[Qemu-devel] [PATCH v4 1/4] tests/docker: add basic user mapping support

2017-02-16 Thread Alex Bennée
Currently all docker builds are done by exporting a tarball to the docker container and running the build as the containers root user. Other use cases are possible however and it is possible to map a part of users file-system to the container. This is useful for example for doing cross-builds of

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-16 Thread Kevin Wolf
Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: > Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > > are loaded when the image is opened and become

[Qemu-devel] [PATCH 1/3] usb-ccid: better bulk_out error handling

2017-02-16 Thread Gerd Hoffmann
Add err goto label where we can jump to from all error conditions. STALL request on all errors. Reset position on all errors. Normal request processing is not in a else branch any more, so this code is reintended, there are no code changes in that part of the code though. Signed-off-by: Gerd

Re: [Qemu-devel] [PATCH v6 0/7] Add support for VM Generation ID

2017-02-16 Thread Laszlo Ersek
On 02/16/17 13:08, Igor Mammedov wrote: > On Wed, 15 Feb 2017 21:52:55 +0100 > Laszlo Ersek wrote: > >> On 02/15/17 21:09, Michael S. Tsirkin wrote: >>> On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote: >> >> [snip] >> For patches #1, #3, #4 and #5:

Re: [Qemu-devel] [PATCH v4 0/4] Docker cross-compile targets and user build support

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Hi Fam, > > Here is the latest iteration of the docker changes incorporating your > suggestions: > > - -u behaves safely if user already added > - cross containers specify QEMU_CONFIGURE_OPTS > - merged docker and build automation in MAINTAINERS

[Qemu-devel] [PATCH v2 02/22] ppc/xics: remove set_nr_servers() handler from XICSStateClass

2017-02-16 Thread Cédric Le Goater
Today, the ICP (Interrupt Controller Presenter) objects are created by the 'nr_servers' property handler of the XICS object and a class handler. They are realized in the XICS object realize routine. Let's simplify the process by creating the ICP objects along with the XICS object at the machine

[Qemu-devel] [PATCH v2 07/22] ppc/xics: use the QOM interface to get irqs

2017-02-16 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 5 +++-- hw/ppc/spapr_events.c | 6 +++--- hw/ppc/spapr_pci.c | 2 +- include/hw/pci-host/spapr.h | 2 +- include/hw/ppc/spapr_vio.h | 2 +- include/hw/ppc/xics.h | 3 ++- 6 files changed, 11

[Qemu-devel] [PATCH v2 10/22] ppc/xics: register the reset handler of ICS objects

2017-02-16 Thread Cédric Le Goater
The reset of the ICS objects is currently handled by XICS but this can be done for each individual ICS. This also reduces the use of the XICS list of ICS. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 5 - hw/ppc/spapr.c | 1 + 2 files changed, 1 insertion(+), 5

[Qemu-devel] [PATCH v2 18/22] ppc/xics: move kernel_xics_fd out of KVMXICSState

2017-02-16 Thread Cédric Le Goater
The kernel ICP file descriptor is the only reason behind the KVMXICSState class and it's in the way of more cleanups. Let's make it a static for the moment and move forward. If this is problem, we could use an attribute under the sPAPR machine later on. Signed-off-by: Cédric Le Goater

[Qemu-devel] [PATCH v2 22/22] ppc/xics: remove the XICSState classes

2017-02-16 Thread Cédric Le Goater
These classed are not used anymore. They have been deprecated by the QOM interface. Do the cleanups. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 11 --- hw/intc/xics_kvm.c | 13 - hw/intc/xics_spapr.c | 14 -- hw/ppc/spapr.c

Re: [Qemu-devel] [RFC v5] RBD: Add support readv,writev for rbd

2017-02-16 Thread Jason Dillaman
On Thu, Feb 16, 2017 at 4:00 AM, wrote: > From: tianqing > > Rbd can do readv and writev directly, so wo do not need to transform > iov to buf or vice versa any more. > > Signed-off-by: tianqing > --- > block/rbd.c | 49

[Qemu-devel] [PULL 07/14] linux-user: manage two new IFLA host message types

2017-02-16 Thread Laurent Vivier
Add QEMU_IFLA_GSO_MAX_SEGS and QEMU_IFLA_GSO_MAX_SIZE in host_to_target_data_link_rtattr(). These two messages are sent by the host kernel when we use "sudo". Found with qemu-m68k and Debian etch-m68k (sudo 1.6.8p12-4) and host kernel 4.7.6-200.fc24.x86_64 Signed-off-by: Laurent Vivier

[Qemu-devel] [PULL 09/14] linux-user: Update m68k syscall definitions to match Linux 4.6

2017-02-16 Thread Laurent Vivier
From: Adrian Glaubitz Signed-off-by: John Paul Adrian Glaubitz Reviewed-by: Laurent Vivier Message-Id: <20170116224915.19430-2-glaub...@physik.fu-berlin.de> Signed-off-by: Laurent Vivier ---

[Qemu-devel] [PULL 10/14] linux-user: fix settime old value location

2017-02-16 Thread Laurent Vivier
From: Marc-André Lureau old_value is the 4th argument of timer_settime(), not the 2nd. Signed-off-by: Marc-André Lureau Signed-off-by: Pranith Kumar Reviewed-by: Laurent Vivier Message-Id:

[Qemu-devel] [PULL 06/14] linux-user: Fix mq_open

2017-02-16 Thread Laurent Vivier
From: Lena Djokic If fourth argument is NULL it should be passed without using lock_user function which would, in that case, return EFAULT, and system call supports passing NULL as fourth argument. Signed-off-by: Lena Djokic Reviewed-by: Peter

[Qemu-devel] [PATCH 2/5] NetRxPkt: Fix memory corruption on VLAN header stripping

2017-02-16 Thread Dmitry Fleytman
This patch fixed a problem that was introduced in commit eb700029. When net_rx_pkt_attach_iovec() calls eth_strip_vlan() this can result in pkt->ehdr_buf being overflowed, because ehdr_buf is only sizeof(struct eth_header) bytes large but eth_strip_vlan() can write sizeof(struct eth_header) +

[Qemu-devel] [PATCH v4 3/4] .shippable.yml: new CI provider

2017-02-16 Thread Alex Bennée
Ostensibly Shippable offers a similar set of services as Travis. However they are focused on Docker container based work-flows so we can use our existing containers to run a few extra builds - in this case a bunch of cross-compiled targets on a Debian multiarch system. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v4 0/4] Docker cross-compile targets and user build support

2017-02-16 Thread Alex Bennée
Hi Fam, Here is the latest iteration of the docker changes incorporating your suggestions: - -u behaves safely if user already added - cross containers specify QEMU_CONFIGURE_OPTS - merged docker and build automation in MAINTAINERS Regards, Alex Bennée (4): tests/docker: add basic user

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
Hello Paolo, On 16.02.2017 12:53, Paolo Bonzini wrote: > As you noticed, the problem is that now cpu_vmexit is called without a > cpu_restore_state before. > > The right fix is to pass the retaddr to cpu_vmexit (via > cpu_svm_check_intercept_param); something like this untested patch: ... > >

Re: [Qemu-devel] [PATCH v4 2/4] new: debian docker targets for cross-compiling

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index 4778b27ca8..84bdcc944a 100644 > --- a/tests/docker/Makefile.include > +++ b/tests/docker/Makefile.include > @@ -54,6 +54,10 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker >

Re: [Qemu-devel] [PATCH v4 1/4] tests/docker: add basic user mapping support

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Currently all docker builds are done by exporting a tarball to the > docker container and running the build as the containers root user. > Other use cases are possible however and it is possible to map a part > of users file-system to the container. This

[Qemu-devel] [PATCH v2 01/22] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

2017-02-16 Thread Cédric Le Goater
Today, the ICS (Interrupt Controller Source) object is created and realized by the init and realize routines of the XICS object, but some of the parameters are only known at the machine level. These parameters are passed from the sPAPR machine to the ICS object in a rather convoluted way using

[Qemu-devel] [PATCH v2 00/22] ppc/xics: simplify ICS and ICP creation

2017-02-16 Thread Cédric Le Goater
Hello, The goal behind this series is to simplify the XICS interface by moving back in the machine the way the ICS and ICP objects interact together. It's up to the machine to implement this "fabric" logic by providing a set of handlers of a QOM interface. These handlers are used to grab an ICS

Re: [Qemu-devel] [PATCH 15/17] iotests: add default node-name

2017-02-16 Thread Fam Zheng
On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > When testing migration, auto-generated by qemu node-names differs in > source and destination qemu and migration fails. After this patch, > auto-generated by iotest nodenames will be the same. What should be done in libvirt to make sure

[Qemu-devel] [PATCH v2 16/22] ppc/xics: register the reset handler of ICP objects

2017-02-16 Thread Cédric Le Goater
The reset of the ICP objects is currently handled by XICS but this can be done for each individual ICP. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 18 -- hw/ppc/spapr.c | 1 + 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/intc/xics.c

[Qemu-devel] [PULL 01/14] linux-user: remove ifdef __USER_MISC

2017-02-16 Thread Laurent Vivier
From: Riku Voipio This preprocessor macro isn't set anywhere. Remove the check so -strace can show these options. Signed-off-by: Riku Voipio --- linux-user/strace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/strace.c

Re: [Qemu-devel] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

2017-02-16 Thread Kevin Wolf
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add detailed error messages. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Why not merge this patch into the one that originally introduced the function? Kevin

[Qemu-devel] [PATCH] hw/arm/virt: fix cpu object reference leak

2017-02-16 Thread Igor Mammedov
object_new(FOO) returns an object with ref_cnt == 1 and following object_property_set_bool(cpuobj, true, "realized", NULL) set parent of cpuobj to '/machine/unattached' which makes ref_cnt == 2. Since machvirt_init() doesn't take ownership of cpuobj returned by object_new() it should explicitly

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 12:29, Dmitry Fleytman wrote: > This series fix a few issues related > to processing of RX packets with VLAN headers. > > See commit messages of specific patches > for information regarding affected devices. I think at least the "fix buffer overrun"

Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Plenty of code relies on QemuOpt member @str not being null, including >> qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to >> qemu_opt_foreach(). >> > >> >> Assert member @str isn't

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
On 2017/2/16 21:04, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 4:49 PM Hailiang Zhang < zhang.zhanghaili...@huawei.com> wrote: Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call

Re: [Qemu-devel] [PATCH v4 13/18] qcow2: add support for LUKS encryption format

2017-02-16 Thread Alberto Garcia
On Fri 10 Feb 2017 06:09:05 PM CET, Daniel P. Berrange wrote: > @@ -990,12 +1123,6 @@ static int qcow2_open(BlockDriverState *bs, QDict > *options, int flags, > s->refcount_max = UINT64_C(1) << (s->refcount_bits - 1); > s->refcount_max += s->refcount_max - 1; > > -if

[Qemu-devel] [PATCH v2 03/22] ppc/xics: store the ICS object under the sPAPR machine

2017-02-16 Thread Cédric Le Goater
A list of ICS objects was introduced under the XICS object for the PowerNV machine, but, for the sPAPR machine, it brings extra complexity as there is only a single ICS. To simplify the code, let's add the ICS pointer under the sPAPR machine and try to reduce the use of this list where possible.

[Qemu-devel] [PATCH v2 04/22] ppc/xics: add an InterruptStatsProvider interface to ICS and ICP objects

2017-02-16 Thread Cédric Le Goater
This is, again, to reduce the use of the list of ICS objects. Let's make each individual ICS and ICP object an InterruptStatsProvider and remove this same interface from XICSState. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 76

[Qemu-devel] [PATCH v2 06/22] ppc/xics: use the QOM interface under the sPAPR machine

2017-02-16 Thread Cédric Le Goater
Add 'ics_get' and 'ics_resend' handlers to the sPAPR machine. These are relatively simple for a single ICS. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 2 +- hw/ppc/spapr.c| 18 ++ include/hw/ppc/xics.h | 1 + 3 files changed, 20

Re: [Qemu-devel] [PATCH v15 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-16 Thread Kevin Wolf
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > Reviewed-by:

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context.

Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Use unsigned comparisons to check the result of qemu_strtoul() and >> strtoull(). >> >> Signed-off-by: Markus Armbruster >> --- >> tests/test-cutils.c | 60 >>

[Qemu-devel] [PATCH 2/3] usb-ccid: move header size check

2017-02-16 Thread Gerd Hoffmann
Move up header size check, so we can use header fields in sanity checks (in followup patches). Also reword the debug message. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 4/4] MAINTAINERS: merge Build and test automation with Docker tests

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > The docker framework is really just another piece in the build > automation puzzle so lets merge it together. For added bonus I've also > included the Travis and Patchew status links. The Shippable links will > be added later once mainline tests have been

[Qemu-devel] [Bug 1665344] [NEW] documentation error:404 not found

2017-02-16 Thread Suramya
Public bug reported: In http://wiki.qemu-project.org/Outreachy_2017_MayAugust the urls http://www.qemu-project.org/images/4/4e/Q35.pdf and http://www.qemu-project.org/images/f/f6/PCIvsPCIe.pdf on opening displays: Not Found The requested URL /images/4/4e/Q35.pdf was not found on this

Re: [Qemu-devel] [PATCH v4 3/4] .shippable.yml: new CI provider

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Ostensibly Shippable offers a similar set of services as Travis. > However they are focused on Docker container based work-flows so we > can use our existing containers to run a few extra builds - in this > case a bunch of cross-compiled targets on a

[Qemu-devel] [PATCH v2 12/22] ppc/xics: extend the QOM interface to handle ICPs

2017-02-16 Thread Cédric Le Goater
Let's add two new handlers for ICPs. One is to get an ICP object from a server number and a second is to resend the irqs when needed. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 2 +- hw/ppc/spapr.c| 20 include/hw/ppc/xics.h | 3 +++

[Qemu-devel] [PATCH v2 08/22] ppc/xics: use the QOM interface to resend irqs

2017-02-16 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 0ffdf09c5304..2decb921e4e3 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -229,16 +229,15

[Qemu-devel] [PATCH v2 15/22] ppc/xics: simplify spapr_dt_xics() interface

2017-02-16 Thread Cédric Le Goater
spapr_dt_xics() only needs the number of servers to build the device tree nodes. Let's change the routine interface to reflect that. Signed-off-by: Cédric Le Goater --- hw/intc/xics_spapr.c | 4 ++-- hw/ppc/spapr.c| 2 +- include/hw/ppc/xics.h | 2 +- 3 files changed, 4

[Qemu-devel] [PATCH v2 14/22] ppc/xics: use the QOM interface to grab an ICP

2017-02-16 Thread Cédric Le Goater
Also introduce a xics_icp_get() helper to simplify the changes. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 31 ++- hw/intc/xics_spapr.c| 17 + hw/ppc/spapr_cpu_core.c | 4 ++-- include/hw/ppc/xics.h | 8

[Qemu-devel] [PATCH v2 17/22] ppc/xics: move the ICP array under the sPAPR machine

2017-02-16 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 17 - include/hw/ppc/spapr.h | 3 +++ include/hw/ppc/xics.h | 2 -- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 445d9a6ddad4..6b35b48f818a

Re: [Qemu-devel] [RFC v5] RBD: Add support readv,writev for rbd

2017-02-16 Thread Jaze Lee
2017-02-16 22:14 GMT+08:00 Jason Dillaman : > On Thu, Feb 16, 2017 at 4:00 AM, wrote: >> From: tianqing >> >> Rbd can do readv and writev directly, so wo do not need to transform >> iov to buf or vice versa any more. >> >>

Re: [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() invalid input

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> tests/test-cutils.c | 24 >> 1 file changed, 24 insertions(+) >> > > Perhaps you could also add a test of "-".

[Qemu-devel] [PATCH 4/5] NetRxPkt: Account buffer with ETH header in IOV length

2017-02-16 Thread Dmitry Fleytman
In case of VLAN stripping ETH header is stored in a separate chunk and length of IOV should take this into account. This patch fixes checksum validation for RX packets with VLAN header. Devices affected by this problem: e1000e and vmxnet3. Signed-off-by: Dmitry Fleytman ---

[Qemu-devel] [PATCH 3/5] NetRxPkt: Do not try to pull more data than present

2017-02-16 Thread Dmitry Fleytman
In case of VLAN stripping, ETH header put into a separate buffer, therefore amont of data copied from original IOV should be smaller. Signed-off-by: Dmitry Fleytman --- hw/net/net_rx_pkt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Dmitry Fleytman
This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. Dmitry Fleytman (5): eth: Extend vlan stripping functions NetRxPkt: Fix memory corruption on VLAN header stripping

  1   2   3   4   >