Re: [Qemu-devel] [PULL 0/3] audio patch queue

2017-02-21 Thread Peter Maydell
On 20 February 2017 at 14:12, Gerd Hoffmann wrote: > Hi, > > Here is the audio queue, bringing support for replay and fixing audio > with SDL2. > > please pull, > Gerd > > The following changes since commit 5d42ff913bb294c661aed8dfcd386fed9e185148: > > Merge

[Qemu-devel] [PATCH 3/6] virtio-gpu: use dpy_gl_scanout_disable

2017-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index b526b3f..f49b7fe 100644 --- a/hw/display/virtio-gpu-3d.c +++

[Qemu-devel] [PATCH 6/6] gtk-egl: add scanout_disable support

2017-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 1 + ui/gtk-egl.c | 15 ++- ui/gtk.c | 1 + 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index 408e21b..ca9a226 100644 --- a/include/ui/gtk.h

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-21 Thread Peter Maydell
On 21 February 2017 at 09:41, Markus Armbruster wrote: > Eric Blake writes: > > [...] >> 'git send-email -s' can also add Signed-off-by: lines, if you didn't add >> them earlier (but only if you use send-email, rather than attachments) :) > > That's fine, as

Re: [Qemu-devel] [PATCH 0/6] ui: some gl scanout improvements.

2017-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2017 at 1:38 PM Gerd Hoffmann wrote: > Hi, > > Upcoming intel vgpu support will need some updates for the qemu opengl > support, specifically we will need support for importing dma-bufs. > The kernel support for this is still brewing though and thus the qemu

[Qemu-devel] [PATCH 3/3] vl: pass CPUState to qemu_system_guest_panicked

2017-02-21 Thread Paolo Bonzini
qemu_system_guest_panicked was already using current_cpu implicitly, so it makes sense for it to receive a CPUState. This lets the function call cpu_get_crash_info and free the result. Signed-off-by: Paolo Bonzini --- include/sysemu/sysemu.h | 2 +- kvm-all.c

[Qemu-devel] [PATCH 1/3] qom-qobject: introduce object_property_{g, s}et_ptr

2017-02-21 Thread Paolo Bonzini
The functions simplify the handling of QOM properties whose type is a QAPI struct. They go through a QObject just like the other functions that access a QOM property through its C type. Like QAPI_CLONE, the functions are wrapped by macros that take a QAPI type name and use it to build the name

Re: [Qemu-devel] [PATCH] qemu-options: explain disk I/O throttling options

2017-02-21 Thread Alberto Garcia
On Mon 20 Feb 2017 05:52:04 PM CET, Stefan Hajnoczi wrote: > The disk I/O throttling options have been listed for a long time but > never explained on the QEMU man page. > +@item bps=@var{b},bps_rd=@var{r},bps_wr=@var{w} > +Specify bandwidth throttling limits in bytes per second, either for all

Re: [Qemu-devel] [PATCH 4/5] tests/test-vmstate.c: test array of ptr with null

2017-02-21 Thread Halil Pasic
On 02/21/2017 11:49 AM, Dr. David Alan Gilbert wrote: >> +static void test_arr_ptr_str_0_save(void) >> +{ >> +TestStructTriv ar[AR_SIZE] = {{.i = 0}, {.i = 1}, {.i = 2}, {.i = 3} }; >> +TestArrayOfPtrToStuct sample = {.ar = {[0], NULL, [2], [3]} }; >> +uint8_t wire_sample[] = { >> +

[Qemu-devel] [PULL v2 04/24] test-thread-pool: use generic AioContext infrastructure

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Once the thread pool starts using aio_co_wake, it will also need qemu_get_current_aio_context(). Make test-thread-pool create an AioContext with qemu_init_main_loop, so that stubs/iothread.c and tests/iothread.c can provide the rest. Reviewed-by: Stefan

[Qemu-devel] [PULL v2 10/24] qed: introduce qed_aio_start_io and qed_aio_next_io_cb

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini qed_aio_start_io and qed_aio_next_io will not have to acquire/release the AioContext, while qed_aio_next_io_cb will. Split the functionality and gain a little type-safety in the process. Reviewed-by: Stefan Hajnoczi Signed-off-by:

Re: [Qemu-devel] [PATCH 2/5] migration/vmstate: split up vmstate_base_addr

2017-02-21 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Currently vmstate_base_addr does several things: it pinpoints the field > within the struct, possibly allocates memory and possibly does the first > pointer dereference. Obviously allocation is needed only for load. > > Let us split up the

Re: [Qemu-devel] [PATCH RFC v3 15/15] vfio: ccw: introduce support for ccw0

2017-02-21 Thread Dong Jia Shi
* Cornelia Huck [2017-02-20 19:59:01 +0100]: > On Fri, 17 Feb 2017 09:29:39 +0100 > Dong Jia Shi wrote: > > > Although Linux does not use format-0 channel command words (CCW0) > > these are a non-optional part of the platform spec, and for

Re: [Qemu-devel] [PATCH v1 06/10] target/ppc: use tcg ops for neg instruction

2017-02-21 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> static void gen_neg(DisasContext *ctx) >> { >> -gen_op_arith_neg(ctx, 0); >> +tcg_gen_neg_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); >> } >> > > NACK. You're forgetting

Re: [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t

2017-02-21 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> This will permit its use in parse_option_size(). >> >> Cc: Dr. David Alan Gilbert >> Cc: Eduardo Habkost (maintainer:X86) >> Cc: Kevin Wolf

[Qemu-devel] [PATCH 5/6] sdl2: add scanout_disable support

2017-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/sdl2.h | 1 + ui/sdl2-gl.c | 16 +++- ui/sdl2.c | 1 + 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index 2de792f..aaf226c 100644 ---

Re: [Qemu-devel] [PATCH 1/5] elf-loader: Allow late loading of elf

2017-02-21 Thread Cornelia Huck
(restored cc:s) On Mon, 20 Feb 2017 16:33:36 +0100 Thomas Huth wrote: > On 20.02.2017 15:19, Cornelia Huck wrote: > > From: Farhan Ali > > > > The current QEMU ROM infrastructure rejects late loading of ROMs. > > And ELFs are currently loaded as

Re: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED

2017-02-21 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED Message-id: 20170221104256.5153-1-pbonz...@redhat.com === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH 2/2] qapi: Improve qobject input visitor error reporting

2017-02-21 Thread Markus Armbruster
Error messages refer to nodes of the QObject being visited by name. Trouble is the names are sometimes less than helpful: * The name of the root QObject is whatever @name argument got passed to the visitor, except NULL gets mapped to "null". We commonly pass NULL. Not good. Avoiding

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

2017-02-21 Thread Markus Armbruster
Zhang Chen writes: > We can call this qmp command to do checkpoint outside of qemu. > Xen colo will need this function. I know nothing about "Xen colo", but I'll try anyway. I *guess* "Xen colo" is a long-running activity, and the new commands interact with it.

[Qemu-devel] [PATCH v5 09/18] qcow: convert QCow to use QCryptoBlock for encryption

2017-02-21 Thread Daniel P. Berrange
This converts the qcow driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead. With this change it is now required to use the

[Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-02-21 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.

[Qemu-devel] [PATCH v5 14/18] qcow2: add iotests to cover LUKS encryption support

2017-02-21 Thread Daniel P. Berrange
This extends the 087 iotest to cover LUKS encryption when doing blockdev-add. Two further tests are added to validate read/write of LUKS encrypted images with a single file and with a backing file. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz

[Qemu-devel] [PULL v2 12/24] block: explicitly acquire aiocontext in timers that need it

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Daniel P. Berrange Message-id: 20170213135235.12274-13-pbonz...@redhat.com

[Qemu-devel] [PULL v2 02/24] aio: introduce aio_co_schedule and aio_co_wake

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini aio_co_wake provides the infrastructure to start a coroutine on a "home" AioContext. It will be used by CoMutex and CoQueue, so that coroutines don't jump from one context to another when they go to sleep on a mutex or waitqueue. However, it can also be

[Qemu-devel] [PULL v2 17/24] async: remove unnecessary inc/dec pairs

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Pull the increment/decrement pair out of aio_bh_poll and into the callers. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] spice: add display & head options

2017-02-21 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann wrote: > This allows to specify display and head to use, simliar to vnc. > > Does "head" in qemu always match the head for multi-monitor spice? (with a single qxl/virtio). I don't clearly understand the relation, I would need

[Qemu-devel] [PATCH 0/6] ui: some gl scanout improvements.

2017-02-21 Thread Gerd Hoffmann
Hi, Upcoming intel vgpu support will need some updates for the qemu opengl support, specifically we will need support for importing dma-bufs. The kernel support for this is still brewing though and thus the qemu patches are still experimental and a moving target. While working on it I did some

[Qemu-devel] [PATCH 4/6] spice: add scanout_disable support

2017-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index b80a9f3..23ccf2a 100644 --- a/ui/spice-display.c +++

[Qemu-devel] [PATCH 2/6] console: add dpy_gl_scanout_disable

2017-02-21 Thread Gerd Hoffmann
Helper function (and DisplayChangeListenerOps ptr) to disable scanouts. Replaces using dpy_gl_scanout_texture with 0x0 size and no texture specified. Allows cleanups to make the io and gfx emulation code more readable. Signed-off-by: Gerd Hoffmann --- include/ui/console.h |

[Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED

2017-02-21 Thread Paolo Bonzini
This is an alternative approach to simplifying the crash information patches. Currently, crash information is exposed twice, through a QOM property and through a method. This is because accessing QOM properties with QAPI struct types is a huge pain in the neck. Patch 1 fixes this by providing a

Re: [Qemu-devel] [PATCH 5/5] tests/test-vmstate.c: test array of ptr to primitive

2017-02-21 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Let's have a test for ptr arrays to some primitive type with some > not-null and null ptrs intermixed. > > Signed-off-by: Halil Pasic > > --- > > Mainly for the sake of completeness and also to demonstrate that it

[Qemu-devel] [PATCH v5 02/18] block: add ability to set a prefix for opt names

2017-02-21 Thread Daniel P. Berrange
When integrating the crypto support with qcow/qcow2, we don't want to use the bare LUKS option names "hash-alg", "key-secret", etc. We want to namespace them "luks-hash-alg", "luks-key-secret" so that they don't clash with any general qcow options at a later date. Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v5 05/18] iotests: skip 042 with qcow which dosn't support zero sized images

2017-02-21 Thread Daniel P. Berrange
Test 042 is designed to verify operation with zero sized images. Such images are not supported with qcow (v1), so this test has always failed. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PULL v2 03/24] block-backend: allow blk_prw from coroutine context

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini qcow2_create2 calls this. Do not run a nested event loop, as that breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup list of the currently running one. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo

[Qemu-devel] [PULL v2 14/24] block: explicitly acquire aiocontext in bottom halves that need it

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Daniel P. Berrange Message-id: 20170213135235.12274-15-pbonz...@redhat.com

[Qemu-devel] [PULL v2 05/24] io: add methods to set I/O handlers on AioContext

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini This is in preparation for making qio_channel_yield work on AioContexts other than the main one. Reviewed-by: Daniel P. Berrange Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL v2 19/24] coroutine-lock: make CoMutex thread-safe

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini This uses the lock-free mutex described in the paper '"Blocking without Locking", or LFTHREADS: A lock-free thread library' by Gidenstam and Papatriantafilou. The same technique is used in OSv, and in fact the code is essentially a conversion to C of

Re: [Qemu-devel] [PATCH V2 0/7] execute code from mmio area

2017-02-21 Thread KONRAD Frederic
Ping! Would be nice for us if we can get this into 2.9. Thanks, Fred Le 17/02/2017 à 21:17, fred.kon...@greensocs.com a écrit : From: KONRAD Frederic This series allows to execute code from mmio areas. The main goal of this is to be able to run code for example

Re: [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap

2017-02-21 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Change the qemu_strtosz() & friends to return -EINVAL when @endptr is >> null and the conversion doesn't consume the string completely. >> Matches how qemu_strtol() & friends work. >> >>

Re: [Qemu-devel] [PATCH] spice: add display & head options

2017-02-21 Thread Gerd Hoffmann
On Di, 2017-02-21 at 08:52 +, Marc-André Lureau wrote: > Hi > > On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann > wrote: > > This allows to specify display and head to use, simliar to > vnc. > > > > Does "head" in qemu always match the head for

Re: [Qemu-devel] [PATCH v1 07/10] target/ppc: update ov/ov32 for nego

2017-02-21 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> For 64-bit mode if the register RA contains 0x8000___, OV >> and OV32 are set to 1. >> >> For 32-bit mode if the register RA contains 0x8000_, OV and OV32 are >> set to 1. >> >> Use

Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.

2017-02-21 Thread Markus Armbruster
Eric Blake writes: [...] > 'git send-email -s' can also add Signed-off-by: lines, if you didn't add > them earlier (but only if you use send-email, rather than attachments) :) That's fine, as you *should* use git send-email. If it looks unattractive to you because it needs

[Qemu-devel] [PATCH 1/6] console: rename dpy_gl_scanout to dpy_gl_scanout_texture

2017-02-21 Thread Gerd Hoffmann
We'll add a variant which accepts dmabufs soon. Change the name so we can easily disturgish the two variants. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 14 +++--- include/ui/console.h | 19 +++ include/ui/gtk.h | 24

Re: [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example

2017-02-21 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 4/5] tests/test-vmstate.c: test array of ptr with null

2017-02-21 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Add test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT with an array > containing some null pointer. > > Signed-off-by: Halil Pasic > Reviewed-by: Dr. David Alan Gilbert > --- > tests/test-vmstate.c | 51

Re: [Qemu-devel] [PULL 00/24] Block patches

2017-02-21 Thread Stefan Hajnoczi
On Mon, Feb 20, 2017 at 01:37:58PM +, Peter Maydell wrote: > On 20 February 2017 at 09:32, Stefan Hajnoczi wrote: > > The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: > > > > Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214'

Re: [Qemu-devel] [Qemu-arm] [PATCH 10/11] stm32f205: Create armv7m object without using armv7m_init()

2017-02-21 Thread Alistair Francis
On Mon, Feb 20, 2017 at 9:45 AM, Philippe Mathieu-Daudé wrote: > On 02/20/2017 12:36 PM, Peter Maydell wrote: >> >> Switch the stm32f205 SoC to create the armv7m object directly >> rather than via the armv7m_init() wrapper. This fits better >> with the SoC model's very QOMified

[Qemu-devel] [PATCH v5 07/18] iotests: fix 097 when run with qcow

2017-02-21 Thread Daniel P. Berrange
The previous commit: commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd Author: Eric Blake Date: Mon Dec 5 09:49:34 2016 -0600 qcow2: Don't strand clusters near 2G intervals during commit extended the 097 test case so that it did two passes, once with an internal

[Qemu-devel] [PATCH v5 03/18] qcow: document another weakness of qcow AES encryption

2017-02-21 Thread Daniel P. Berrange
Document that use of guest virtual sector numbers as the basis for the initialization vectors is a potential weakness, when combined with internal snapshots or multiple images using the same passphrase. This fixes the formatting of the itemized list too. Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v5 17/18] block: remove all encryption handling APIs

2017-02-21 Thread Daniel P. Berrange
Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying

[Qemu-devel] [PULL v2 09/24] blkdebug: reschedule coroutine on the AioContext it is running on

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Keep the coroutine on the same AioContext. Without this change, there would be a race between yielding the coroutine and reentering it. While the race cannot happen now, because the code only runs from a single AioContext, this will change with

[Qemu-devel] [PULL v2 21/24] test-aio-multithread: add performance comparison with thread-based mutexes

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Add two implementations of the same benchmark as the previous patch, but using pthreads. One uses a normal QemuMutex, the other is Linux only and implements a fair mutex based on MCS locks and futexes. This shows that the slower performance of the

[Qemu-devel] [PULL v2 15/24] block: explicitly acquire aiocontext in aio callbacks that need it

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Daniel P. Berrange Message-id: 20170213135235.12274-16-pbonz...@redhat.com

[Qemu-devel] [PULL 07/11] blockdev: Make orphaned -drive fatal

2017-02-21 Thread Markus Armbruster
Block backends defined with "-drive if=T" with T other than "none" are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. If machine initialization code doesn't comply, the block backend remains unused. This triggers a warning since

[Qemu-devel] [PULL v2 18/24] block: document fields protected by AioContext lock

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Daniel P. Berrange Message-id: 20170213135235.12274-19-pbonz...@redhat.com

[Qemu-devel] [PATCH] vmxcap: update for September 2016 SDM

2017-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- scripts/kvm/vmxcap | 8 1 file changed, 8 insertions(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index af8de15..e0990c7 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/kvm/vmxcap @@ -171,8 +171,11 @@ controls = [

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-21 Thread Laszlo Ersek
On 02/21/17 02:43, Michael S. Tsirkin wrote: > On Mon, Feb 20, 2017 at 09:55:40PM +0100, Laszlo Ersek wrote: >> On 02/20/17 21:45, Eric Blake wrote: >>> On 02/20/2017 02:19 PM, Dr. David Alan Gilbert wrote: * Eric Blake (ebl...@redhat.com) wrote: > On 02/20/2017 04:23 AM, Dr. David Alan

Re: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED

2017-02-21 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH 0/3] simplify struct QOM properties and use the result for GUEST_PANICKED

[Qemu-devel] [PATCH v5 06/18] iotests: skip 048 with qcow which doesn't support resize

2017-02-21 Thread Daniel P. Berrange
Test 048 is designed to verify data preservation during an image resize. The qcow (v1) format impl has never supported resize so always fails. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PATCH v5 15/18] iotests: enable tests 134 and 158 to work with qcow (v1)

2017-02-21 Thread Daniel P. Berrange
The 138 and 158 iotests exercise the legacy qcow2 aes encryption code path and they work fine with qcow v1 too. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/134 | 2 +-

[Qemu-devel] [PULL v2 00/24] Block patches

2017-02-21 Thread Stefan Hajnoczi
The following changes since commit 56f9e46b841c7be478ca038d8d4085d776ab4b0d: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-20' into staging (2017-02-20 17:42:47 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

[Qemu-devel] [PULL v2 06/24] io: make qio_channel_yield aware of AioContexts

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini Support separate coroutines for reading and writing, and place the read/write handlers on the AioContext that the QIOChannel is registered with. Reviewed-by: Daniel P. Berrange Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

2017-02-21 Thread Zhang Chen
On 02/21/2017 07:15 PM, Markus Armbruster wrote: Zhang Chen writes: We can call this qmp command to do checkpoint outside of qemu. Xen colo will need this function. I know nothing about "Xen colo", but I'll try anyway. I *guess* "Xen colo" is a long-running

[Qemu-devel] [PULL v2 22/24] coroutine-lock: place CoMutex before CoQueue in header

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini This will avoid forward references in the next patch. It is also more logical because CoQueue is not anymore the basic primitive. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-id:

[Qemu-devel] [PULL v2 07/24] nbd: convert to use qio_channel_yield

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini In the client, read the reply headers from a coroutine, switching the read side between the "read header" coroutine and the I/O coroutine that reads the body of the reply. In the server, if the server can read more requests it will create a new "read

Re: [Qemu-devel] [PATCH v1 05/10] target/ppc: update overflow flags for add/sub

2017-02-21 Thread Nikunj A Dadhania
Richard Henderson writes: > On 02/20/2017 09:11 PM, Nikunj A Dadhania wrote: >> tcg_temp_free(t0); >> +tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1); >> +tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1); >> if (NARROW_MODE(ctx)) { >> -tcg_gen_ext32s_tl(cpu_ov,

Re: [Qemu-devel] [PATCH] spice: add display & head options

2017-02-21 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2017 at 1:11 PM Gerd Hoffmann wrote: > On Di, 2017-02-21 at 08:52 +, Marc-André Lureau wrote: > > Hi > > > > On Tue, Feb 21, 2017 at 11:58 AM Gerd Hoffmann > > wrote: > > > > This allows to specify display and head to use,

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > > Hello David, Hi Alexey, > On Tue, Feb 14, 2017 at 07:34:26PM +, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > Hi David, > > > > > > Thank your, now it's clear. > > > > > > On Mon, Feb 13,

[Qemu-devel] seek help for AER

2017-02-21 Thread Cao jin
Hi, First, sorry for such a long time delay on the AER job. I was on 12 days holiday, and start to work on the patch 2 weeks ago, because I use a newer version kernel(4.10 rc8) to start off the work, several tiny problems slow me. Now I meet a confusing issue on aer_inject module. When I use

Re: [Qemu-devel] [PATCH 0/2] add bcm2835 sdhost controller to bcm2835 platform

2017-02-21 Thread Peter Maydell
On 20 February 2017 at 17:34, Clement Deschamps wrote: > This patches add the Arasan SD controller to the BCM2835/36 platforms. Cool! > On the real hardware, both SD controllers are wired to the same SD card. > Selection is done via multi-function pins through the

Re: [Qemu-devel] [Qemu-block] [RFC PATCH V4] qemu-img: make convert async

2017-02-21 Thread Stefan Hajnoczi
On Mon, Feb 20, 2017 at 03:59:42PM +0100, Peter Lieven wrote: > Am 20.02.2017 um 15:50 schrieb Stefan Hajnoczi: > > On Fri, Feb 17, 2017 at 05:00:24PM +0100, Peter Lieven wrote: > > > +if (s->wr_in_order) { > > > +/* reenter the coroutine that might have waited > > > +

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-options: explain disk I/O throttling options

2017-02-21 Thread Stefan Hajnoczi
On Mon, Feb 20, 2017 at 01:40:21PM -0600, Eric Blake wrote: > On 02/20/2017 10:52 AM, Stefan Hajnoczi wrote: > > The disk I/O throttling options have been listed for a long time but > > never explained on the QEMU man page. > > > > Suggested-by: Nini Gu > > Cc: Alberto Garcia

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/11] armv7m: Abstract out the "load kernel" code

2017-02-21 Thread Alistair Francis
On Mon, Feb 20, 2017 at 8:23 AM, Philippe Mathieu-Daudé wrote: > On 02/20/2017 12:35 PM, Peter Maydell wrote: >> >> Abstract the "load kernel" code out of armv7m_init() into its own >> function. This includes the registration of the CPU reset function, >> to parallel how we

Re: [Qemu-devel] [PATCH 04/11] armv7m: Use QOMified armv7m object in armv7m_init()

2017-02-21 Thread Alistair Francis
On Mon, Feb 20, 2017 at 7:35 AM, Peter Maydell wrote: > Make the legacy armv7m_init() function use the newly QOMified > armv7m object rather than doing everything by hand. > > We can return the armv7m object rather than the NVIC from > armv7m_init() because its interface

[Qemu-devel] [PATCH v5 13/18] qcow2: add support for LUKS encryption format

2017-02-21 Thread Daniel P. Berrange
This adds support for using LUKS as an encryption format with the qcow2 file. The use of the existing 'encryption=on' parameter is replaced by a new parameter 'encryption-format' which takes the values 'aes' or 'luks'. e.g. # qemu-img create --object secret,data=123456,id=sec0 \ -f qcow2

Re: [Qemu-devel] [PATCH 1/3] qom-qobject: introduce object_property_{g, s}et_ptr

2017-02-21 Thread Paolo Bonzini
On 21/02/2017 11:42, Paolo Bonzini wrote: > The functions simplify the handling of QOM properties whose type > is a QAPI struct. They go through a QObject just like the other > functions that access a QOM property through its C type. > > Like QAPI_CLONE, the functions are wrapped by macros

[Qemu-devel] [PULL v2 11/24] aio: push aio_context_acquire/release down to dispatching

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini The AioContext data structures are now protected by list_lock and/or they are walked with FOREACH_RCU primitives. There is no need anymore to acquire the AioContext for the entire duration of aio_dispatch. Instead, just acquire it before and after

[Qemu-devel] [PATCH] vmxcap: port to Python 3

2017-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- scripts/kvm/vmxcap | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index 2220255..af8de15 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/kvm/vmxcap @@ -27,9 +27,9 @@

Re: [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example

2017-02-21 Thread Markus Armbruster
Vincenzo Maffione writes: > In the vhost-user example, a chardev with id chr0 is referenced by the > vhost-user net backend, but the id is not specified in the chardev option. > > Signed-off-by: Vincenzo Maffione > --- > qemu-options.hx | 2 +- > 1

Re: [Qemu-devel] [PULL 0/8] target-mips queue

2017-02-21 Thread Peter Maydell
On 20 February 2017 at 20:30, Yongbok Kim wrote: > Hi, > > This is pull-req for target-mips. > > Regards, > Yongbok > > The following changes since commit 56f9e46b841c7be478ca038d8d4085d776ab4b0d: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH 1/5] elf-loader: Allow late loading of elf

2017-02-21 Thread Christian Borntraeger
On 02/20/2017 04:33 PM, Thomas Huth wrote: > On 20.02.2017 15:19, Cornelia Huck wrote: >> From: Farhan Ali >> >> The current QEMU ROM infrastructure rejects late loading of ROMs. >> And ELFs are currently loaded as ROM, this prevents delayed loading >> of ELFs. So when

Re: [Qemu-devel] iommu emulation

2017-02-21 Thread Jintack Lim
On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson wrote: > On Thu, 16 Feb 2017 10:28:39 +0800 > Peter Xu wrote: > > > On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: > > > > [...] > > > > > > Alex, do you like something like below

Re: [Qemu-devel] [Qemu-block] blockdev-add I/O throttling parameters

2017-02-21 Thread Stefan Hajnoczi
On Mon, Feb 20, 2017 at 05:29:19PM +0100, Alberto Garcia wrote: > On Mon, Feb 20, 2017 at 04:45:54PM +0100, Kevin Wolf wrote: > > > I can imagine two solutions that do not need these parameters in > > > blockdev-add: > > > > > > 1. I/O throttling is implemented by a BlockDriver. Users are

[Qemu-devel] [PULL v2 08/24] coroutine-lock: reschedule coroutine on the AioContext it was running on

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini As a small step towards the introduction of multiqueue, we want coroutines to remain on the same AioContext that started them, unless they are moved explicitly with e.g. aio_co_schedule. This patch avoids that coroutines switch AioContext when they use a

Re: [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap

2017-02-21 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Change the qemu_strtosz() & friends to return -EINVAL when @endptr is > >> null and the conversion doesn't consume the string

Re: [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system

2017-02-21 Thread Peter Maydell
On 21 February 2017 at 02:24, wrote: > On Sat, Feb 18, 2017 at 10:41:41PM +, Peter Maydell wrote: >> >> Does the BE ppc64 risu build work for you? I tried >> installing the cross-compiler, but the build fails >> because there's no risu_ppc64.c. (ppc64le works

Re: [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix a third integer overflow

2017-02-21 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PULL 00/11] usb patch queue

2017-02-21 Thread Peter Maydell
he following changes since commit 56f9e46b841c7be478ca038d8d4085d776ab4b0d: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-02-20' > into staging (2017-02-20 17:42:47 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu

Re: [Qemu-devel] [PATCH for 2.9 0/3] guest panic information follow-up

2017-02-21 Thread Paolo Bonzini
On 20/02/2017 19:21, Denis V. Lunev wrote: > This is a set of followup patches requested by Eric Blake. > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Eric Blake

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-21 Thread Stefan Hajnoczi
On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > >> On 2/17/17, 1:42 PM, "Jeff Cody" wrote: > >> > >> On Thu,

Re: [Qemu-devel] [PULL 0/2] QAPI patches for 2017-02-20

2017-02-21 Thread Markus Armbruster
Zhang Chen writes: > Hi~ Markus. > > This patch set has been reviewed for a long time, can you pick up it? > > [PATCH V7 0/2] Add new qmp commands to suppurt Xen COLO I think this should go through a COLO maintainer chain, or perhaps the Xen maintainer, but not

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-21 Thread Daniel P. Berrange
On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote: > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > > >> On

[Qemu-devel] [PATCH v5 08/18] qcow: make encrypt_sectors encrypt in place

2017-02-21 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller uses the same buffer for input/output already and the other two callers are easily converted to do so. Reviewed-by: Alberto

[Qemu-devel] [PATCH v5 00/18] Convert QCow[2] to QCryptoBlock & add LUKS support

2017-02-21 Thread Daniel P. Berrange
Previously posted: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00201.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05147.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05671.html This series is a continuation of previous work to support

[Qemu-devel] [PATCH v5 01/18] block: expose crypto option names / defs to other drivers

2017-02-21 Thread Daniel P. Berrange
The block/crypto.c defines a set of QemuOpts that provide parameters for encryption. This will also be needed by the qcow/qcow2 integration, so expose the relevant pieces in a new block/crypto.h header. Reviewed-by: Max Reitz Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v5 04/18] qcow: require image size to be > 1 for new images

2017-02-21 Thread Daniel P. Berrange
The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v5 16/18] block: rip out all traces of password prompting

2017-02-21 Thread Daniel P. Berrange
Now that qcow & qcow2 are wired up to get encryption keys via the QCryptoSecret object, nothing is relying on the interactive prompting for passwords. All the code related to password prompting can thus be ripped out. Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL v2 01/24] block: move AioContext, QEMUTimer, main-loop to libqemuutil

2017-02-21 Thread Stefan Hajnoczi
From: Paolo Bonzini AioContext is fairly self contained, the only dependency is QEMUTimer but that in turn doesn't need anything else. So move them out of block-obj-y to avoid introducing a dependency from io/ to block-obj-y. main-loop and its dependency iohandler also

[Qemu-devel] [PATCH v5 12/18] qcow2: extend specification to cover LUKS encryption

2017-02-21 Thread Daniel P. Berrange
Update the qcow2 specification to describe how the LUKS header is placed inside a qcow2 file, when using LUKS encryption for the qcow2 payload instead of the legacy AES-CBC encryption Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange ---

  1   2   3   4   5   6   >