[Qemu-devel] [d...@kernelim.com: [PATCH] nvme: Fix get/set number of queues feature, again]

Comments? - Forwarded message from Dan Aloni - Date: Sun, 28 May 2017 16:06:49 +0300 From: Dan Aloni To: qemu-devel@nongnu.org Cc: Alex Friedman , Keith Busch , Stefan Hajnoczi

[Qemu-devel] [Question] How can we confirm hot-plug disk succesfully?

Hi all In device hot-remove scenario, if we don't probe acpiphp module on the guest, 'device_del' will never emit DEVICE_DELETED event(because guest will not write to __EJ0) . So we can confirm that hot-remove failed. But IIUC, there is no event such as DEVICE_ADDED, so 1) How can we confirm

[Qemu-devel] [PATCHv5 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Laszlo Ersek --- hw/nvram/fw_cfg.c | 16

Re: [Qemu-devel] [PATCHv4 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

On 16/06/17 22:28, Laszlo Ersek wrote: > This patch is generally good, but I'd like to suggest improvements: > > (1) In the commit message, please mention that we are exposing the > internals of FWCfgIoState and FWCfgMemState so that board code can map > the MemoryRegion fields (such as

[Qemu-devel] [PATCHv5 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

In preparation for calling fw_cfg_init1() during realize rather than during init, move the assert() checking for existing fw_cfg devices and the linking of the device to the machine with object_property_add_child() to a new fw_cfg instance_init() function. This guarantees that we will still

[Qemu-devel] [PATCHv5 1/5] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

As indicated by Laszlo it is a QOM bug for the realize() method to actually map the device. Set up the IO regions within fw_cfg_io_realize() and defer the mapping with sysbus_add_io() to the caller, as already done in fw_cfg_init_mem_wide(). This makes the iobase and dma_iobase properties now

[Qemu-devel] [PATCHv5 4/5] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be able to wire it up differently, it is much more convenient for the caller to instantiate the device and have the fw_cfg default files already preloaded during realize. Move fw_cfg_init1() to the end of both the

[Qemu-devel] [PATCHv5 0/5] fw_cfg: qdev-related tidy-ups

As part of some ongoing sun4u work, I need to be able to wire the fw_cfg IO interface to a separate IO space by instantiating the qdev device instead of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with FW_CFG_MEM and tidies up the realize methods accordingly. Signed-off-by:

[Qemu-devel] [PATCHv5 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility for the internal MemoryRegion fields to be mapped by name for boards that wish to wire up the fw_cfg device themselves. An additional minor tidy-up is that the FWCfgEntry typedef is moved from the struct definitions in

[Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode

I've noticed that there is no way to control file and folder umask on the host when using 9p in mapped mode. This can be a major headache when actually sharing data between different users using groups and ACLs. Thus I added the options fmask and dmask to fsdev and virtfs to control the actual

[Qemu-devel] [PATCH 1/1] Add support for custom fmasks/dmasks in 9ps mapped mode

Signed-off-by: Tobias Schramm --- fsdev/file-op-9p.h | 4 fsdev/qemu-fsdev-opts.c | 12 hw/9pfs/9p-local.c | 33 + hw/9pfs/9p.c| 3 +++ 4 files changed, 48 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v3 0/1] Add fmask/dmask option for 9p mapped mode

Hi, as per Manos suggestion I'm now parsing the fmask/dmask as unsigned rather than signed longs. Tobias Schramm Tobias Schramm (1): Add support for custom fmasks/dmasks in 9ps mapped mode fsdev/file-op-9p.h | 4 fsdev/qemu-fsdev-opts.c | 12 hw/9pfs/9p-local.c

Re: [Qemu-devel] [PATCH] translator mega-patch

On 18 June 2017 at 15:37, Lluís Vilanova wrote: > I seem to remember we discussed this at some point before I sent the first > version, to allow multiple targets on the same binary, but decided against it. > > Still, I can leave the ops struct in place without even trying to

[Qemu-devel] Commit 77af8a2b9 breaks (mac)OS X 10.11.6

Hello, After 77af8a2b9 (hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.) OS X 10.11.6 hangs during boot near detecting IOAPIC. (Gabriel's latest v3 applesmc patch series does not fix this.) Maybe another register needs to be implemented somewhere? Regards,

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

G 3 wrote on 06/18/2017 03:38:29 PM: > > From: Aaron Larson > > Date: 06/05/2017 12:22 PM > > Subject: [PATCH v3] target-ppc: Enable open-pic timers to count > > and generate interrupts > > > > Previously QEMU open-pic

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

Lluís Vilanova writes: > Lluís Vilanova writes: >> Emilio G Cota writes: >>> On Thu, Jun 15, 2017 at 18:19:11 -0400, Emilio G. Cota wrote: (snip) > +/** > + * DisasContextBase: > + * @tb: Translation block for this disassembly. > + * @pc_first: Address of first guest

Re: [Qemu-devel] [RFH] qemu-2.6 memory corruption with OVMF and linux-4.9

* Philipp Hahn (h...@univention.de) wrote: > Hello, > > Am 17.06.2017 um 18:51 schrieb Laszlo Ersek: > > (I also recommend using the "vbindiff" tool for such problems, it is > > great for picking out patterns.) > > > > ** ** ** ** ** ** ** ** 8 9 ** ** ** 13 14 15 > > --

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

Lluís Vilanova writes: > Emilio G Cota writes: >> On Thu, Jun 15, 2017 at 18:19:11 -0400, Emilio G. Cota wrote: >>> (snip) >>> > +/** >>> > + * DisasContextBase: >>> > + * @tb: Translation block for this disassembly. >>> > + * @pc_first: Address of first guest instruction in this TB. >>> > + *

[Qemu-devel] [PATCH] vcpu_dirty: share the same field in CPUState for all accelerators

This patch simply replaces the separate boolean field in CPUState that kvm, hax (and upcoming hvf) have for keeping track of vcpu dirtiness with a single shared field. Signed-off-by: Sergio Andres Gomez Del Real --- include/qom/cpu.h | 5 +++-- kvm-all.c

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

G 3 wrote on 06/18/2017 09:45:25 AM: > >>> From: Aaron Larson > >>> To: ag...@suse.de, alar...@ddci.com, da...@gibson.dropbear.id.au, > >> qemu-devel@nongnu.org, qemu-...@nongnu.org > >>> Date: 06/05/2017 12:22 PM > >>> Subject: [PATCH v3]

[Qemu-devel] [PATCH v3 1/1] Add support for custom fmasks/dmasks in 9ps mapped mode

Signed-off-by: Tobias Schramm --- v3: Use unsigned types for umask v2: Adjust patch to QEMU code style fsdev/file-op-9p.h | 4 fsdev/qemu-fsdev-opts.c | 12 hw/9pfs/9p-local.c | 29 + hw/9pfs/9p.c| 3

Re: [Qemu-devel] ARM v6 memory barrier cp15 ops still implemented as NOPs

On 16 June 2017 at 20:41, Alex Bennée wrote: > > Peter Maydell writes: > >> Hi; I just noticed that we seem to still implement the ARM v6 >> memory-barrier cp15 ops as NOPs: >> >> { .name = "ISB", .cp = 15, .crn = 7, .crm = 5, .opc1 = 0,

Re: [Qemu-devel] [RFH] qemu-2.6 memory corruption with OVMF and linux-4.9

Am 18.06.2017 um 20:27 schrieb Dr. David Alan Gilbert: > * Philipp Hahn (h...@univention.de) wrote: >> Hello, >> >> Am 17.06.2017 um 18:51 schrieb Laszlo Ersek: >>> (I also recommend using the "vbindiff" tool for such problems, it is >>> great for picking out patterns.) >>> >>> ** ** **

Re: [Qemu-devel] [PATCHv5 5/5] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

On Sun, Jun 18, 2017 at 09:02:14AM +0100, Mark Cave-Ayland wrote: > By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility > for the internal MemoryRegion fields to be mapped by name for boards that wish > to wire up the fw_cfg device themselves. > > An additional minor

Re: [Qemu-devel] [RFH] qemu-2.6 memory corruption with OVMF and linux-4.9

Hello, Am 17.06.2017 um 18:51 schrieb Laszlo Ersek: > (I also recommend using the "vbindiff" tool for such problems, it is > great for picking out patterns.) > > ** ** ** ** ** ** ** ** 8 9 ** ** ** 13 14 15 > -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- > 01

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

On Sat, Jun 17, 2017 at 04:37:02PM +0800, Wei Wang wrote: > On 06/16/2017 11:15 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 16, 2017 at 06:10:27PM +0800, Wei Wang wrote: > > > On 06/16/2017 04:57 PM, Jason Wang wrote: > > > > > > > > On 2017年06月16日 11:22, Michael S. Tsirkin wrote: > > > > > > I

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

On Jun 18, 2017, at 4:36 PM, alar...@ddci.com wrote: G 3 wrote on 06/18/2017 09:45:25 AM: From: Aaron Larson To: ag...@suse.de, alar...@ddci.com, da...@gibson.dropbear.id.au, qemu-devel@nongnu.org, qemu-...@nongnu.org Date: 06/05/2017 12:22 PM

Re: [Qemu-devel] [PATCH v6 6/6] target: [tcg, arm] Port to generic translation framework

On Sun, Jun 18, 2017 at 17:41:02 +0300, Lluís Vilanova wrote: > Is there any ready-made kernel or disk image I can test with? I test ARM with: $ qemu-system-arm -machine type=virt -nographic -smp 1 -m 4096 \ -netdev user,id=unet,hostfwd=tcp::-:22 \ -device

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

On Mon, Jun 19, 2017 at 00:54:05 +0300, Lluís Vilanova wrote: > Aha, just checked your proposed patches more closely and it totally makes > sense > to keep "is_jmp" to simplify the diffs, so I'll go for that one. Also I think it's important to break down the changes to each architecture into

Re: [Qemu-devel] [Question] How can we confirm hot-plug disk succesfully?

Resend 在 6/18/2017 3:21 PM, Xie Changlong 写道: Hi all In device hot-remove scenario, if we don't probe acpiphp module on the guest, 'device_del' will never emit DEVICE_DELETED event(because guest will not write to __EJ0) . So we can confirm that hot-remove failed. But IIUC, there is no event

Re: [Qemu-devel] [PATCH] translator mega-patch

On Sun, Jun 18, 2017 at 17:37:39 +0300, Lluís Vilanova wrote: > Emilio G Cota writes: > > > On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: > >> Signed-off-by: Lluís Vilanova > >> --- > >> include/exec/gen-icount.h |2 > >>

Re: [Qemu-devel] [PATCH 1/1] Add support for custom fmasks/dmasks in 9ps mapped mode

On Sun, Jun 18, 2017 at 10:28:13AM +0200, Tobias Schramm wrote: @@ -1469,6 +1472,28 @@ static int local_parse_opts(QemuOpts *opts, struct FsDriverEntry *fse) fse->path = g_strdup(path); +fse->fmask = SM_LOCAL_MODE_BITS; +if (fmask) { +mask = strtol(fmask, NULL, 0); (Use

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

On Mon, Jun 05, 2017 at 10:22:53AM -0700, Aaron Larson wrote: > Previously QEMU open-pic implemented the 4 open-pic timers including > all timer registers, but the timers did not "count" or generate any > interrupts. The patch makes the timers both count and generate > interrupts. The timer

[Qemu-devel] [PATCH v2 1/1] Add support for custom fmasks/dmasks in 9ps mapped mode

Signed-off-by: Tobias Schramm --- v2: Adjust patch to QEMU code style fsdev/file-op-9p.h | 4 fsdev/qemu-fsdev-opts.c | 12 hw/9pfs/9p-local.c | 29 + hw/9pfs/9p.c| 3 +++ 4 files changed, 44

[Qemu-devel] [PATCH v2 0/1] Add fmask/dmask option for 9p mapped mode

Hi, as suggested by the automated tests I adjusted the code style to be compatible with QEMUs existing code base. The previous failed test seems to be irrelevant since it passes fine on my dev machine and the failure is in a totally unrelated component. Tobias Schramm Tobias Schramm (1): Add

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

Emilio G Cota writes: > On Thu, Jun 15, 2017 at 18:19:11 -0400, Emilio G. Cota wrote: >> (snip) >> > +/** >> > + * DisasContextBase: >> > + * @tb: Translation block for this disassembly. >> > + * @pc_first: Address of first guest instruction in this TB. >> > + * @pc_next: Address of next guest

Re: [Qemu-devel] [PATCH v6 6/6] target: [tcg, arm] Port to generic translation framework

Emilio G Cota writes: > On Mon, Jun 12, 2017 at 17:54:30 +0300, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> target/arm/translate-a64.c | 346 ++--- >> target/arm/translate.c | 720 >> ++-- >>

Re: [Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework

Emilio G Cota writes: > On Mon, Jun 12, 2017 at 17:53:47 +0300, Lluís Vilanova wrote: >> This series proposes a generic (target-agnostic) instruction translation >> framework. >> >> It basically provides a generic main loop for instruction disassembly, which >> calls target-specific functions

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

Quoting David Gibson (2017-06-18 05:24:22) > On Fri, Jun 16, 2017 at 12:19:26PM -0500, Michael Roth wrote: > > Quoting Igor Mammedov (2017-06-16 08:53:12) > > > On Wed, 14 Jun 2017 19:27:12 -0500 > > > Michael Roth wrote: > > > > > > > Quoting Igor Mammedov (2017-06-14

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

Quoting David Gibson (2017-06-18 04:59:33) > On Fri, Jun 16, 2017 at 11:15:46AM -0500, Michael Roth wrote: > > Quoting David Gibson (2017-06-16 09:40:53) > > > On Fri, Jun 16, 2017 at 03:53:12PM +0200, Igor Mammedov wrote: > > > > On Wed, 14 Jun 2017 19:27:12 -0500 > > > > Michael Roth

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

On Sun, Jun 18, 2017 at 07:37:00AM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-18 04:59:33) > > On Fri, Jun 16, 2017 at 11:15:46AM -0500, Michael Roth wrote: > > > Quoting David Gibson (2017-06-16 09:40:53) > > > > On Fri, Jun 16, 2017 at 03:53:12PM +0200, Igor Mammedov wrote: > > >

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

On Jun 18, 2017, at 6:50 AM, qemu-devel-requ...@nongnu.org wrote: On Fri, Jun 16, 2017 at 11:31:02AM -0500, alar...@ddci.com wrote: Aaron Larson wrote on 06/05/2017 12:22:53 PM: From: Aaron Larson To: ag...@suse.de, alar...@ddci.com,

Re: [Qemu-devel] [PATCH v3] target-ppc: Enable open-pic timers to count and generate interrupts

On Fri, Jun 16, 2017 at 11:31:02AM -0500, alar...@ddci.com wrote: > Aaron Larson wrote on 06/05/2017 12:22:53 PM: > > > From: Aaron Larson > > To: ag...@suse.de, alar...@ddci.com, da...@gibson.dropbear.id.au, > qemu-devel@nongnu.org, qemu-...@nongnu.org > >

Re: [Qemu-devel] [PATCH v6 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

On Tue, Jun 13, 2017 at 10:18:18AM +0530, Bharata B Rao wrote: > On Mon, Jun 12, 2017 at 05:10:44PM +0800, David Gibson wrote: > > On Mon, Jun 12, 2017 at 11:02:34AM +0530, Bharata B Rao wrote: > > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > > stream (in the place of HPT

Re: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170618082813.8091-1-toblemi...@gmail.com Type: series Subject: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

>> A Linux guest will deflate the balloon (all or some pages) in the >> following scenarios: >> a) page migration > > It inflates it first, doesn't it? Yes, that that is true. I was just listing all scenarios. > >> b) unload virtio-balloon kernel module >> c) hibernate/suspension >> d)

Re: [Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

On Thu, Jun 15, 2017 at 07:05:29PM +0300, Roman Kagan wrote: > On Thu, Jun 15, 2017 at 03:27:28PM +0200, Igor Mammedov wrote: [...] > > > > > future. But the APIC id is also the KVM vcpu_id, so there's no need > > > > > to > > > > > have VP_INDEX maintained by QEMU. > > > > agreed it'd be

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

On Fri, Jun 16, 2017 at 12:19:26PM -0500, Michael Roth wrote: > Quoting Igor Mammedov (2017-06-16 08:53:12) > > On Wed, 14 Jun 2017 19:27:12 -0500 > > Michael Roth wrote: > > > > > Quoting Igor Mammedov (2017-06-14 04:00:01) > > > > On Tue, 13 Jun 2017 16:42:45 -0500 >

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

On Fri, Jun 16, 2017 at 11:15:46AM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-16 09:40:53) > > On Fri, Jun 16, 2017 at 03:53:12PM +0200, Igor Mammedov wrote: > > > On Wed, 14 Jun 2017 19:27:12 -0500 > > > Michael Roth wrote: > > > > > > > Quoting Igor

Re: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170618082813.8091-1-toblemi...@gmail.com Subject: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped

Re: [Qemu-devel] [PATCH] translator mega-patch

Emilio G Cota writes: > On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> include/exec/gen-icount.h |2 >> include/exec/translate-all_template.h | 73 >> include/qom/cpu.h

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

Emilio G Cota writes: > On Thu, Jun 15, 2017 at 19:25:07 -0400, Emilio G. Cota wrote: >> Also, consider keeping the @is_jmp name instead of renaming it to >> @jmp_type. (@jmp would be shorter but it would be confusing though, >> e.g. cris has both dc->jmp and dc->is_jmp.) > It turns out that

Re: [Qemu-devel] [PATCH v6 3/6] target: [tcg] Add generic translation framework

Emilio G Cota writes: > Some minor nits below. > On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> +/** >> + * BreakpointHitType: >> + * @BH_MISS: No hit >> + * @BH_HIT_INSN: Hit, but continue translating instruction >>