Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

2017-07-24 Thread John Snow
On 07/21/2017 05:06 AM, Igor Mammedov wrote: On Thu, 20 Jul 2017 21:29:33 +0200 Phil Dennis-Jordan wrote: On Thu, Jul 20, 2017 at 6:40 PM, Programmingkid wrote: I noticed that Windows 2000 does not boot up in QEMU recently. After bisecting

[Qemu-devel] [PULL 3/4] mps2: Correctly set parent bus for SCC device

2017-07-24 Thread Peter Maydell
A cut-and-paste error meant that instead of setting the qdev parent bus for the SCC device we were setting it twice for the ARMv7M container device. Fix this bug. Signed-off-by: Peter Maydell Message-id: 1500634509-28011-1-git-send-email-peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 04/13] instrument: Allow adding the "instrument" property without modifying event files

2017-07-24 Thread Lluís Vilanova
Adds a configure argument to allow users to add the instrument property to events without having to modify any trace event files. Signed-off-by: Lluís Vilanova --- configure | 17 + rules.mak |3 +++

[Qemu-devel] [PATCH 08/13] instrument: [linux-user] Add command line library loader

2017-07-24 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- linux-user/main.c| 20 linux-user/syscall.c |4 2 files changed, 24 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index ad03c9e8b2..fdb7ddb199 100644 --- a/linux-user/main.c +++

Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK)

2017-07-24 Thread David Hildenbrand
On 24.07.2017 06:39, Richard Henderson wrote: > On 07/21/2017 05:56 AM, David Hildenbrand wrote: >> +tcg_gen_extrl_i64_i32(cc, o->in1); >> +tcg_gen_shri_i32(cc, cc, 28); >> +tcg_gen_andi_i32(cc, cc, 0x3ul); >> +tcg_gen_mov_i32(cc_op, cc); >> +tcg_temp_free_i32(cc); >> +

[Qemu-devel] [PATCH 10/13] instrument: [softmmu] Add command line library loader

2017-07-24 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- qemu-options.hx | 17 + vl.c| 11 +++ 2 files changed, 28 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 9bd6bf0eee..aacd01cee7 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

Re: [Qemu-devel] dirty page count problem

2017-07-24 Thread Alex Bennée
Dr. David Alan Gilbert writes: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> Hi, >> Git bisect is pointing to your patch 084140bd49: >> exec: fix access to ram_list.dirty_memory when sync dirty bitmap >> >> trying to diagnose a bug I'm seeing; it looks like

Re: [Qemu-devel] [RFC 13/29] vhost+postcopy: Transmit 'listen' to client

2017-07-24 Thread Maxime Coquelin
On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index b98fbe4834..1f70f5760f 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -67,6 +67,7 @@ typedef enum VhostUserRequest {

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Kevin Wolf
Am 24.07.2017 um 16:28 hat Eric Blake geschrieben: > On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: > > There is not much getting started documentation for qemu-iotests. This > > patch explains how to create a new test and covers the overall testing > > approach. > > > > +2. Create the test file

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Denis V. Lunev
On 07/24/2017 05:43 PM, Lluís Vilanova wrote: > Denis V Lunev writes: > >> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: >>> On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: Current trace system have a drawback: parameters of trace functions are

[Qemu-devel] [PATCH v2] hmp/(p)memsave: Allow >32bit file size

2017-07-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" memsave and pmemsave only take 32bit size arguments in HMP at the moment; let them take 64bit values. Reported-by: Pierre Kim Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 4 ++--

Re: [Qemu-devel] [PATCH v3 0/5] target/s390x: Fix broken build with --disable-tcg

2017-07-24 Thread Richard Henderson
On 07/24/2017 04:32 AM, Cornelia Huck wrote: On Mon, 24 Jul 2017 10:52:45 +0200 Thomas Huth wrote: Our configure script was recently equipped with a new --disable-tcg parameter, but this does unfortunately not work on s390x hosts yet. Fix the build by moving some code around

[Qemu-devel] [PATCH 2/2] iotests: Add test of recent fix to 'qemu-img measure'

2017-07-24 Thread Eric Blake
The new test 190 ensures we don't regress back to an infinite loop when measuring the size of a 2T+ qcow2 image. I did not append to test 178, because that test is also designed to run with format 'raw'; also, this gives us some coverage of the measure command under the quick group.

[Qemu-devel] [PATCH 1/2] iotests: Check dirty bitmap statistics in 124

2017-07-24 Thread Eric Blake
We had a bug for multiple releases where dirty-bitmap count was documented in bytes but reported in sectors; enhance the testsuite to add coverage of DirtyBitmapInfo to ensure we do not regress again. Signed-off-by: Eric Blake --- tests/qemu-iotests/124 | 7 ++- 1 file

Re: [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 08:50 AM, Alexey Kardashevskiy wrote: > On 06/07/17 03:13, Cédric Le Goater wrote: >> Each interrupt source is associated with a 2-bit state machine called >> an Event State Buffer (ESB). It is controlled by MMIO to trigger >> events. >> >> See code for more details on the states. >>

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Philippe Mathieu-Daudé
On 07/24/2017 09:17 AM, Denis V. Lunev wrote: On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: Current trace system have a drawback: parameters of trace functions are calculated even if corresponding tracepoint is

Re: [Qemu-devel] [PATCH v1 1/6] target/s390x: fix pgm irq ilen for stsi

2017-07-24 Thread Thomas Huth
On 21.07.2017 14:56, David Hildenbrand wrote: > The instruction is 4 bytes long. > > Signed-off-by: David Hildenbrand > --- > target/s390x/misc_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/misc_helper.c

Re: [Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one

2017-07-24 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 03:18:25PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 24, 2017 at 04:01:14PM +0200, Gerd Hoffmann wrote: > > qemu carries a bunch of reverse keymaps in pc-bios/keymaps/, to map > > keysyms it receives from vnc clients back to keycodes. These keymaps > > seem to be

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Eric Blake
On 07/24/2017 09:34 AM, Peter Maydell wrote: > On 24 July 2017 at 15:28, Eric Blake wrote: >> On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: >>> There is not much getting started documentation for qemu-iotests. This >>> patch explains how to create a new test and covers the

[Qemu-devel] [PATCH for 2.10] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check

2017-07-24 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert This code has an optimised, word aligned version, and a boring unaligned version. Recently 084140bd498909 fixed a missing offset addition from the core of both versions. However, the offset isn't necessarily aligned and thus the choice between

Re: [Qemu-devel] [PATCH] migration: optimize the downtime

2017-07-24 Thread Dr. David Alan Gilbert
* Jay Zhou (jianjay.z...@huawei.com) wrote: > Hi Dave, > > On 2017/7/21 17:49, Dr. David Alan Gilbert wrote: > > * Jay Zhou (jianjay.z...@huawei.com) wrote: > > > Qemu_savevm_state_cleanup() takes about 300ms in my ram migration tests > > > with a 8U24G vm(20G is really occupied), the main cost

[Qemu-devel] [PATCH for-2.10 0/2] Test for bug fixes from byte-based block status

2017-07-24 Thread Eric Blake
Kevin is correct, and I need tests of my recent bug fixes :) https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07235.html Eric Blake (2): iotests: Check dirty bitmap statistics in 124 iotests: Add test of recent fix to 'qemu-img measure' tests/qemu-iotests/124 | 7 +-

Re: [Qemu-devel] [PATCH] migration: optimize the downtime

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 17:35, Dr. David Alan Gilbert wrote: > * Jay Zhou (jianjay.z...@huawei.com) wrote: >> Hi Dave, >> >> On 2017/7/21 17:49, Dr. David Alan Gilbert wrote: >>> * Jay Zhou (jianjay.z...@huawei.com) wrote: Qemu_savevm_state_cleanup() takes about 300ms in my ram migration tests

Re: [Qemu-devel] [PULL v2 00/10] QAPI patches for 2017-07-18

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 12:56, Markus Armbruster wrote: > The following changes since commit df95f1a298a3e16c80293343143dcedbe7978f6c: > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170721-tag' > into staging (2017-07-24 10:01:15 +0100) > > are available in the

Re: [Qemu-devel] [PATCH 4/4] tests/pxe-test: add testcase using vhost-user-bridge

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 11:55:53AM +0200, Jens Freimann wrote: > +static const char *init_hugepagefs(const char *path) > +{ > +struct statfs fs; > +int ret; > + > +if (access(path, R_OK | W_OK | X_OK)) { > +g_test_message("access on path (%s): %s\n", path, strerror(errno)); > +

Re: [Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-24 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 03:49:29PM +0200, Paolo Bonzini wrote: > On 19/07/2017 13:56, Thomas Huth wrote: > > +@node Machine types > > +@section Machine types > > + > > +For architectures which aim to support live migration compatibility > > +across releases, each release will introduce a new

[Qemu-devel] [Bug 1705717] Re: Live migration fails with 'host' cpu when KVM is inserted with nested=1

2017-07-24 Thread hbagdi
Hello, I could not replicate this behavior on another system. So, please close this bug. Apologies for the inconvenience. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1705717 Title: Live

Re: [Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one

2017-07-24 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 04:01:14PM +0200, Gerd Hoffmann wrote: > qemu carries a bunch of reverse keymaps in pc-bios/keymaps/, to map > keysyms it receives from vnc clients back to keycodes. These keymaps > seem to be buggy and incomplete at times. So, to tackle the issue once > for all, I've

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 15:28, Eric Blake wrote: > On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: >> There is not much getting started documentation for qemu-iotests. This >> patch explains how to create a new test and covers the overall testing >> approach. >> >> +2. Create the

Re: [Qemu-devel] [PATCH 2/7] block: add aio_context field in ThrottleGroupMember

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 12:45:16PM +0300, Manos Pitsidianakis wrote: > timer_cb() needs to know about the current Aio context of the throttle > request that is woken up. In order to make ThrottleGroupMember backend > agnostic, this information is stored in an aio_context field instead of >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-24 Thread Dan Williams
On Mon, Jul 24, 2017 at 5:37 AM, Jan Kara wrote: > On Mon 24-07-17 08:06:07, Pankaj Gupta wrote: >> >> > On Sun 23-07-17 13:10:34, Dan Williams wrote: >> > > On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel wrote: >> > > > On Sun, 2017-07-23 at 09:01 -0700, Dan

Re: [Qemu-devel] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 08:00 AM, Alexey Kardashevskiy wrote: > On 24/07/17 14:02, David Gibson wrote: >> On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote: >>> This is very similar to the current ICS_SIMPLE model in XICS. We try >>> to reuse the ICS model because the sPAPR machine is tied to

Re: [Qemu-devel] [PULL 0/1] Error reporting patches for 2017-07-24

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 13:22, Markus Armbruster wrote: > The following changes since commit df95f1a298a3e16c80293343143dcedbe7978f6c: > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170721-tag' > into staging (2017-07-24 10:01:15 +0100) > > are available in the

Re: [Qemu-devel] [RFC PATCH for 2.10 2/3] docker: fix dirty/stash detection on some systems

2017-07-24 Thread Philippe Mathieu-Daudé
On 07/20/2017 10:47 AM, Alex Bennée wrote: I reported this a while ago but evidently forgot to push the patch upstream. Without this I wasn't seeing the dirty tree state submitted to the docker build which is very confusing. Reference: Subject: [PATCH 1/6] tests/docker/Makefile.include: fix

Re: [Qemu-devel] [RFC PATCH 09/26] ppc/xive: add an overall memory region for the ESBs

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 08:09 AM, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote: >> On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote: >>> Each source adds its own ESB mempry region to the overall ESB memory >>> region of the controller. It will be

Re: [Qemu-devel] [RFC PATCH 10/26] ppc/xive: record interrupt source MMIO address for hcalls

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 07:11 AM, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:23PM +0200, Cédric Le Goater wrote: >> The address of the MMIO page through which the Event State Buffer is >> controlled is returned to the guest by the H_INT_GET_SOURCE_INFO hcall. >> >> Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [RFC PATCH 11/26] ppc/xics: introduce a print_info() handler to the ICS and ICP objects

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 07:13 AM, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:24PM +0200, Cédric Le Goater wrote: >> This handler will be used to customize the ouput of the XIVE interrupt >> source and presenter objects. > > I'm not really happy with this without having a clear idea of where > this

Re: [Qemu-devel] [RFC PATCH 13/26] ppc/xive: introduce a XIVE interrupt presenter model

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 08:05 AM, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:26PM +0200, Cédric Le Goater wrote: >> Just like the interrupt source model, we try to reuse the ICP model >> because the sPAPR machine is tied to the XICSFabric interface and >> should be using a common framework to

[Qemu-devel] [PULL for-2.10 0/2] NBD patches for 2.10

2017-07-24 Thread Eric Blake
The following changes since commit cf44d31d35df3de9d4f49339254050195f777f3e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-07-18-v2' into staging (2017-07-24 13:21:33 +0100) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-07-24

[Qemu-devel] [PATCH 1/3] keysym: add next and prior

2017-07-24 Thread Gerd Hoffmann
Page-up and Page-down where renamed. Add the names to the keysym list so we can parse both old and new names. The keypad versions are already present in the vnc map. Signed-off-by: Gerd Hoffmann --- ui/curses_keys.h | 2 ++ ui/vnc_keysym.h | 2 ++ 2 files changed, 4

Re: [Qemu-devel] [PATCH] hmp/(p)memsave: Allow >32bit file size

2017-07-24 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Thomas Huth (th...@redhat.com) wrote: >> On 24.07.2017 14:14, Dr. David Alan Gilbert (git) wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > memsave and pmemsave only take 32bit size arguments in HMP at the >> >

[Qemu-devel] [PATCH for-2.10] target/arm: Correct MPU trace handling of write vs execute

2017-07-24 Thread Peter Maydell
Correct off-by-one bug in the PSMAv7 MPU tracing where it would print a write access as "reading", an insn fetch as "writing", and a read access as "execute". Since we have an MMUAccessType enum now, we can make the code clearer in the process by using that rather than the raw 0/1/2 values.

Re: [Qemu-devel] [PATCH 1/7] block: move ThrottleGroup membership to ThrottleGroupMember

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 12:45:15PM +0300, Manos Pitsidianakis wrote: > This commit eliminates the 1:1 relationship between BlockBackend and > throttle group state. Users will be able to create multiple throttle > nodes, each with its own throttle group state, in the future. The > throttle group

Re: [Qemu-devel] [PATCH 3/7] block: tidy ThrottleGroupMember initializations

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 12:45:17PM +0300, Manos Pitsidianakis wrote: > Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() > which is called whenever a ThrottleGroupMember is initialized. There's > no need for them to be separate. > > Signed-off-by: Manos Pitsidianakis

Re: [Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 16:47, Daniel P. Berrange wrote: > If it takes more work downstream to undelete & maintain machine > types in the downstream fork, that means downstream maintainers > less free time to improve QEMU upstream. From that POV, deleting > machine types & props upstream is actually

Re: [Qemu-devel] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 06:02 AM, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote: >> This is very similar to the current ICS_SIMPLE model in XICS. We try >> to reuse the ICS model because the sPAPR machine is tied to the >> XICSFabric interface and should be using a

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failedbecauseof vhost region merge

2017-07-24 Thread peng.hao2
>On Mon, 24 Jul 2017 18:32:35 +0800 (CST) > wrote: >> > On Sun, 23 Jul 2017 20:46:11 +0800 >> > Peng Hao wrote: >> >> > > When a guest that has several hotplugged dimms is migrated, on >> > > destination it will fail to resume. Because

Re: [Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-24 Thread Paolo Bonzini
On 19/07/2017 13:56, Thomas Huth wrote: > +@node Machine types > +@section Machine types > + > +For architectures which aim to support live migration compatibility > +across releases, each release will introduce a new versioned machine > +type. For example, the 2.8.0 release introduced machine

Re: [Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 16:11, Daniel P. Berrange wrote: >>> + >>> +The supported lifetime for versioned machine types is 12 releases, >>> +which is equivalent to 4 years worth of previous QEMU releases. >> I think there's still no consensus on this. > > Indeed, which is exactly why I sent this patch - we

Re: [Qemu-devel] [RFC PATCH v2 4/4] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-24 Thread Alexander Bezzubikov
2017-07-24 12:42 GMT+03:00 Gerd Hoffmann : > On Sun, 2017-07-23 at 22:44 +0300, Alexander Bezzubikov wrote: > > By the way, any ideas on how to avoid 'bus overstealing' would > > be greatly appreciated. > > Static BIOS variable isn't applicable since its value isn't saved > >

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Denis V Lunev writes: > On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: >> On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Current trace system have a drawback: parameters of trace functions >>> are calculated even if corresponding tracepoint is disabled. Also, it

Re: [Qemu-devel] [RFC 14/29] vhost+postcopy: Register new regions with the ufd

2017-07-24 Thread Maxime Coquelin
On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" When new regions are sent to the client using SET_MEM_TABLE, register them with the userfaultfd. Signed-off-by: Dr. David Alan Gilbert ---

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-24 Thread Eduardo Habkost
On Mon, Jul 24, 2017 at 02:13:09PM +0200, Lukáš Doktor wrote: > Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a): > > On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: > >> Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > >>> On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor

Re: [Qemu-devel] virtio-net-pci possible limitation on AArch64

2017-07-24 Thread Alexandru Avadanii
Hi, Andrew, Thank you for looking at this. Comments inline. > -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Monday, July 24, 2017 6:02 PM > To: Alexandru Avadanii > Cc: qemu-devel@nongnu.org; svc-armband > Subject: Re: [Qemu-devel] virtio-net-pci possible

Re: [Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

2017-07-24 Thread Eric Blake
On 07/24/2017 04:28 AM, Kevin Wolf wrote: > Am 21.07.2017 um 20:32 hat Eric Blake geschrieben: >> Series 2-4 of my byte-based conversion missed soft freeze, so they >> are now 2.11 material. However, there are some bug fixes in those >> series that we should fix now in 2.10 (patch 1 from series

Re: [Qemu-devel] [PATCH v2] pc: acpi: force FADT rev1 for 440fx based machine types

2017-07-24 Thread Programmingkid
> On Jul 24, 2017, at 9:50 AM, Igor Mammedov wrote: > > w2k used to boot on QEMU until revision of FADT has > been bumped to rev3 > (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > guest OS support.) > > Keep PC machine at rev1 to remain

Re: [Qemu-devel] [PULL for-2.10 0/2] NBD patches for 2.10

2017-07-24 Thread Peter Maydell
On 24 July 2017 at 15:01, Eric Blake wrote: > The following changes since commit cf44d31d35df3de9d4f49339254050195f777f3e: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-07-18-v2' > into staging (2017-07-24 13:21:33 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH] hmp/(p)memsave: Allow >32bit file size

2017-07-24 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 24.07.2017 14:14, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > memsave and pmemsave only take 32bit size arguments in HMP at the > > moment; let them take 64bit values. > > > > Reported-by:

Re: [Qemu-devel] [RFC PATCH for 2.10 0/3] some docker fixes

2017-07-24 Thread Alex Bennée
Alex Bennée writes: > Hi, > > I noticed some problems while running my local builds and while trying > to reproduce Travis failures. They apply on top of the currently in > flight pull-req pull-ci-updates-for-softfreeze-180717-2 > > Alex Bennée (3): > docker: ensure

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-24 Thread Eric Blake
On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > +2. Create the test file > + > +Copy an existing test (one that most closely resembles

[Qemu-devel] [PULL 0/5] Block layer patches for 2.10.0-rc0

2017-07-24 Thread Kevin Wolf
The following changes since commit 5dd8990841a9e331d9d4838a116291698208cbb6: util: Introduce include/qemu/cpuid.h (2017-07-24 12:42:55 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 1/5] iotests: Remove a few tests from 'quick' group

2017-07-24 Thread Kevin Wolf
From: Eric Blake A run of './check -qcow2 -g quick' on my machine produced only two tests that took longer than 5 seconds; 178 took 18, and 189 took 7. Remove them from the quick group. Signed-off-by: Eric Blake Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v1 2/6] target/s390x: fix pgm irq ilen in translate_pages()

2017-07-24 Thread Thomas Huth
On 21.07.2017 14:56, David Hildenbrand wrote: > 0 is certainly wrong. Let's use ILEN_AUTO. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/mmu_helper.c

Re: [Qemu-devel] [RFC PATCH v2 4/4] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-24 Thread Marcel Apfelbaum
On 24/07/2017 17:39, Alexander Bezzubikov wrote: 2017-07-24 12:42 GMT+03:00 Gerd Hoffmann >: On Sun, 2017-07-23 at 22:44 +0300, Alexander Bezzubikov wrote: > By the way, any ideas on how to avoid 'bus overstealing' would > be greatly

Re: [Qemu-devel] virtio-net-pci possible limitation on AArch64

2017-07-24 Thread Andrew Jones
On Fri, Jul 21, 2017 at 06:37:26PM +, Alexandru Avadanii wrote: > Hi, > I ran into an interesting limitation (or possibly bug) while trying to attach > more than 3 (three) virtio-net-pci NICs to an AArch64 guest. > I created 4 network with virsh (see below for xml defitions) - nothing fancy,

Re: [Qemu-devel] [PATCH for 2.10] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check

2017-07-24 Thread Paolo Bonzini
On 24/07/2017 17:04, Dr. David Alan Gilbert (git) wrote: > From: Dr. David Alan Gilbert > > This code has an optimised, word aligned version, and a boring > unaligned version. Recently 084140bd498909 fixed a missing offset > addition from the core of both versions.

Re: [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 06:29 AM, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:20PM +0200, Cédric Le Goater wrote: >> Each interrupt source is associated with a 2-bit state machine called >> an Event State Buffer (ESB). It is controlled by MMIO to trigger >> events. >> >> See code for more details on

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-24 Thread Dan Williams
On Mon, Jul 24, 2017 at 8:48 AM, Jan Kara wrote: > On Mon 24-07-17 08:10:05, Dan Williams wrote: >> On Mon, Jul 24, 2017 at 5:37 AM, Jan Kara wrote: [..] >> This approach would turn into a full fsync on the host. The question >> in my mind is whether there is any

Re: [Qemu-devel] [PATCH 0/2] improve tracing

2017-07-24 Thread Lluís Vilanova
Denis V Lunev writes: > On 07/24/2017 05:43 PM, Lluís Vilanova wrote: >> Denis V Lunev writes: >> >>> On 07/24/2017 02:34 PM, Stefan Hajnoczi wrote: On Fri, Jul 21, 2017 at 05:31:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Current trace system have a drawback: parameters of

Re: [Qemu-devel] [PATCH v5 0/2 (for 2.10] Document deprecated features & support lifecycle

2017-07-24 Thread Stefan Hajnoczi
On Wed, Jul 19, 2017 at 11:08:00AM +0100, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01286.html > v3:

[Qemu-devel] [PATCH 3/3] Add qemu-keymap tool.

2017-07-24 Thread Gerd Hoffmann
qemu-keymap generates qemu reverse keymaps from xkb keymaps, which can be used with the qemu "-k" command line switch. Signed-off-by: Gerd Hoffmann --- configure | 23 ++ Makefile | 5 ++ qemu-keymap.c | 243

[Qemu-devel] [PATCH 2/3] ui: move qemu_input_linux_to_qcode()

2017-07-24 Thread Gerd Hoffmann
Move from input-linux.c to input-keymap.c and export it, so the function is available elsewhere too. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input-keymap.c | 115 + ui/input-linux.c | 113

[Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one

2017-07-24 Thread Gerd Hoffmann
qemu carries a bunch of reverse keymaps in pc-bios/keymaps/, to map keysyms it receives from vnc clients back to keycodes. These keymaps seem to be buggy and incomplete at times. So, to tackle the issue once for all, I've written a tool to generate those maps from xkb keyboard layout data using

[Qemu-devel] [PULL 2/2] maint: Reorder include directives for qemu-{nbd, io}

2017-07-24 Thread Eric Blake
HACKING recommends listing system includes right after osdep.h, and before any other in-project headers. Signed-off-by: Eric Blake Message-Id: <20170721135047.25005-3-ebl...@redhat.com> --- qemu-img.c | 3 ++- qemu-nbd.c | 8 2 files changed, 6 insertions(+), 5

[Qemu-devel] [PULL 1/2] qemu-nbd: Update version string

2017-07-24 Thread Eric Blake
qemu-io and qemu-img already mirror the qemu version string, time to make qemu-nbd do the same. Reported-by: 陳培泓 Signed-off-by: Eric Blake Message-Id: <20170721135047.25005-2-ebl...@redhat.com> Reviewed-by: Daniel P. Berrange ---

[Qemu-devel] [PULL 4/5] block: Skip implicit nodes in query-block/blockstats

2017-07-24 Thread Kevin Wolf
Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet, it shouldn't be affected by added nodes. This is true as

[Qemu-devel] [PULL 5/5] qemu-iotests: Avoid unnecessary sleeps

2017-07-24 Thread Kevin Wolf
Test cases 030, 041 and 055 used to sleep for a second after calling block-job-pause to make sure that the block job had time to actually get into paused state. We can instead poll its status and use that one second only as a timeout. The tests also slept a second for checking that the block jobs

Re: [Qemu-devel] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

2017-07-24 Thread Stefan Hajnoczi
On Fri, Jul 14, 2017 at 12:45:18PM +0300, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. > > A new QAPI struct, ThrottleLimits, is introduced to

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-24 Thread Jan Kara
On Mon 24-07-17 08:10:05, Dan Williams wrote: > On Mon, Jul 24, 2017 at 5:37 AM, Jan Kara wrote: > > On Mon 24-07-17 08:06:07, Pankaj Gupta wrote: > >> > >> > On Sun 23-07-17 13:10:34, Dan Williams wrote: > >> > > On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel

Re: [Qemu-devel] [PATCH for 2.10 03/35] thunk: check nb_fields is valid before continuing

2017-07-24 Thread Eric Blake
On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes > se->field_offsets[i] = malloc(nb_fields * sizeof(int)); >^~~ > > Reported-by: Clang Static

[Qemu-devel] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer

2017-07-24 Thread Philippe Mathieu-Daudé
linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/flatload.c | 15 +-- 1 file changed, 9 insertions(+), 6

Re: [Qemu-devel] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > not hit since 2009! :) > > linux-user/elfload.c:1102:20: warning: Out of bound memory access (access > exceeds upper limit of memory block) > (*regs[i]) = tswap32(env->gregs[i]); > ~~~^~~~ > >

Re: [Qemu-devel] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion > if (res > (unsigned long)-4096) > ^~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [Qemu-devel] [PATCH for 2.10 23/35] m68k/translate: fix incorrect copy/paste

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 21:19, Philippe Mathieu-Daudé a écrit : > On 07/24/2017 04:01 PM, Richard Henderson wrote: >> On 07/24/2017 11:54 AM, Laurent Vivier wrote: >>> Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : diff --git a/target/m68k/translate.c b/target/m68k/translate.c index

Re: [Qemu-devel] [PATCH for 2.10 31/35] syscall: replace strcpy() by g_strlcpy()

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > linux-user/syscall.c:9860:17: warning: Call to function 'strcpy' is insecure > as it does not provide bounding of the memory buffer. Replace unbounded copy > functions with analogous functions that support length arguments such as >

Re: [Qemu-devel] [PATCH for 2.10 30/35] syscall: fix use of uninitialized values

2017-07-24 Thread Laurent Vivier
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit : > linux-user/syscall.c:1627:35: warning: 1st function call argument is an > uninitialized value > target_saddr->sa_family = tswap16(addr->sa_family); > ^~~~ >

[Qemu-devel] [PATCH v2] pc: acpi: force FADT rev1 for 440fx based machine types

2017-07-24 Thread Igor Mammedov
w2k used to boot on QEMU until revision of FADT has been bumped to rev3 (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.) Keep PC machine at rev1 to remain compatible and Q35 at rev3 where w2k isn't supported anyway so OSX could run as well.

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windows vmstartup

2017-07-24 Thread peng.hao2
I'm sorry I copy and paste code to make a patch, but I make a mistake to send a uncompleted patch. 彭浩 penghao IT开发工程师 IT Development Engineer 操作系统产品部/中心研究院/系统产品 OS Product Department/Central R&D Institute/System Product 成都市天府大道中段800号中兴大厦A座 T: +86 028 18123274005

[Qemu-devel] [PULL 2/5] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

2017-07-24 Thread Kevin Wolf
From: Eric Blake We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then removed things from block/qapi.c, in preparation for a rewrite to a list of dirty sectors in the

[Qemu-devel] [PULL 3/5] qcow2: Fix sector calculation in qcow2_measure()

2017-07-24 Thread Kevin Wolf
From: Eric Blake We used MAX() instead of the intended MIN() when computing how many sectors to view in the current loop iteration of qcow2_measure(), and passed in a value of INT_MAX sectors instead of our more usual limit of BDRV_REQUEST_MAX_SECTORS (the latter avoids 32-bit

Re: [Qemu-devel] [PATCH v5 1/2 (for 2.10)] docs: document support lifetime for features

2017-07-24 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 04:26:24PM +0200, Paolo Bonzini wrote: > On 24/07/2017 16:11, Daniel P. Berrange wrote: > >>> + > >>> +The supported lifetime for versioned machine types is 12 releases, > >>> +which is equivalent to 4 years worth of previous QEMU releases. > >> I think there's still no

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 17/26] ppc/xive: add hcalls support

2017-07-24 Thread Cédric Le Goater
On 07/24/2017 11:39 AM, Alexey Kardashevskiy wrote: > On 06/07/17 03:13, Cédric Le Goater wrote: >> A set of Hypervisor's call are used to configure the interrupt sources >> and the event/notification queues of the guest: >> >>H_INT_GET_SOURCE_INFO >>H_INT_SET_SOURCE_CONFIG >>

[Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2017-07-24 Thread Peter Maloney
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1488363 Title: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card Status in

[Qemu-devel] [PATCH for-2.10 0/2] test recent byte-based bug fixes

2017-07-24 Thread Eric Blake
Kevin has a point: all bug fixes deserve regression tests :) https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07235.html Eric Blake (2): iotests: Check dirty bitmap statistics in 124 iotests: Add test of recent fix to 'qemu-img measure' tests/qemu-iotests/124 | 4 +++-

Re: [Qemu-devel] [PATCH for 2.10 06/35] qcow2: remove inconsistent check

2017-07-24 Thread Eric Blake
On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > This is equivalent to assert(russian roulette) so better remove it. > > block/qcow2-bitmap.c:259:29: warning: The left operand of '==' is a garbage > value > assert(bitmap_table == NULL); > ^ > >

[Qemu-devel] [PATCH for 2.10 24/35] linux-user/sh4: fix incorrect memory write

2017-07-24 Thread Philippe Mathieu-Daudé
not hit since 2009! :) linux-user/elfload.c:1102:20: warning: Out of bound memory access (access exceeds upper limit of memory block) (*regs[i]) = tswap32(env->gregs[i]); ~~~^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH for 2.10 28/35] syscall: check dup/dup2/dup3() errors, return EBADFD/EINVAL if required

2017-07-24 Thread Philippe Mathieu-Daudé
Linux dup(2) manpage: ERRORS EBADF newfd is out of the allowed range for file descriptors (like negative) EINVAL (dup3()) oldfd was equal to newfd Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 32

[Qemu-devel] [PATCH for 2.10 29/35] syscall: fix out-of-bound memory access

2017-07-24 Thread Philippe Mathieu-Daudé
linux-user/syscall.c:555:25: warning: Out of bound memory access (accessed memory precedes memory block) target_fd_trans[fd] = trans; ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c | 1 + 1

Re: [Qemu-devel] [PATCH for 2.10 07/35] qcow2: fix null pointer dereference

2017-07-24 Thread Eric Blake
On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > If find_bitmap_by_name() fails we have bm=NULL and go to the 'fail' label, > then > call bitmap_free(bm) which does g_free(bm->name) with bm=NULL... > > Clang's scan-build-5.0 output: > block/qcow2-bitmap.c:492:12: warning: Access to field

[Qemu-devel] Torn read/write possible on aarch64/x86-64 MTTCG?

2017-07-24 Thread Andrew Baumann via Qemu-devel
Hi all, I'm trying to track down what appears to be a translation bug in either the aarch64 target or x86_64 TCG (in multithreaded mode). The symptoms are entirely consistent with a torn read/write -- that is, a 64-bit load or store that was translated to two 32-bit loads and stores -- but

  1   2   3   4   5   >