[Qemu-devel] [PATCH 3/4] ppc: spapr: Rename cpu_dt_id to vcpu_id

2017-08-03 Thread Sam Bobroff
This field actually records the VCPU ID used by KVM and, although the value is also used in the device tree it is primarily the VCPU ID so rename it as such. Signed-off-by: Sam Bobroff --- hw/ppc/ppc.c| 8 hw/ppc/spapr.c | 16

[Qemu-devel] [PATCH 1/4] spapr: Fix bug in h_signal_sys_reset()

2017-08-03 Thread Sam Bobroff
The unicast case in h_signal_sys_reset() seems to be broken: rather than selecting the target CPU, it looks like it will pick either the first CPU or fail to find one at all. Fix it by using the search function rather than open coding the search. This was found by inspection; the code appears to

[Qemu-devel] [PATCH 2/4] e500: Use cpu_index instead of vcpu_dt_id

2017-08-03 Thread Sam Bobroff
The e500 platform code uses the function ppc_get_vcpu_dt_id() but that function is actually specific to SPAPR machines, not PPC CPUs, and will always return the cpu_index in this context. Simply use the cpu_index instead (which is 'i' in this context because qemu_get_cpu(i) returns the cpu with

[Qemu-devel] [PATCH 0/4] Cleanup cpu_dt_id

2017-08-03 Thread Sam Bobroff
In preparation for some other work in this area, here is a patch set that cleans up some of the code around the cpu_dt_id field of struct PowerPCCPU. It includes a bugfix for h_signal_sys_reset() because the code there uses the cpu_dt_id field and it would need to be changed by this set anyway.

[Qemu-devel] [PATCH 4/4] ppc: spapr: Make VCPU ID handling private to SPAPR

2017-08-03 Thread Sam Bobroff
The concept of a VCPU ID that differs from the CPU's index (cpu->cpu_index) exists only within SPAPR machines so, move the functions ppc_get_vcpu_id() and ppc_get_cpu_by_vcpu_id() into spapr.c and rename them appropriately. Signed-off-by: Sam Bobroff --- hw/ppc/ppc.c

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

2017-08-03 Thread Kevin Wolf
Am 31.07.2017 um 11:54 hat Manos Pitsidianakis geschrieben: > block/throttle.c uses existing I/O throttle infrastructure inside a > block filter driver. I/O operations are intercepted in the filter's > read/write coroutines, and referred to block/throttle-groups.c > > The driver can be used with

Re: [Qemu-devel] [PATCH v3 7/7] block: add throttle block filter driver interface tests

2017-08-03 Thread Kevin Wolf
Am 31.07.2017 um 11:54 hat Manos Pitsidianakis geschrieben: > Signed-off-by: Manos Pitsidianakis I would add at least two more cases: * Both limits and throttle-group are given in blockdev-add * limits and throttle-group are both missing It would also be nice to test that

Re: [Qemu-devel] [PATCH v3 0/2] ERC cleanup and CRW bugfix

2017-08-03 Thread Cornelia Huck
On Thu, 3 Aug 2017 02:35:25 +0200 Dong Jia Shi wrote: > This series is trying to: > 1. clear up ERC related code > 2. bugfix for channel path related CRW generation > > Change log > -- > v2->v3: > Added Halil's R-B on both patches. > Patch #1: > Added ERC

Re: [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes

2017-08-03 Thread Lukáš Doktor
Would someone please take a look at this un-reviewed patch? Thanks, Lukáš Dne 26.7.2017 v 16:42 Lukáš Doktor napsal(a): > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > --- > scripts/qemu.py | 76

Re: [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM

2017-08-03 Thread Kevin Wolf
Am 02.08.2017 um 12:57 hat Manos Pitsidianakis geschrieben: > On Wed, Aug 02, 2017 at 11:39:22AM +0100, Stefan Hajnoczi wrote: > > On Tue, Aug 01, 2017 at 07:49:33PM +0300, Manos Pitsidianakis wrote: > > > On Tue, Aug 01, 2017 at 04:47:03PM +0100, Stefan Hajnoczi wrote: > > > > On Mon, Jul 31,

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

2017-08-03 Thread Kevin Wolf
Am 03.08.2017 um 00:00 hat Anatol Pomozov geschrieben: > Hello Richard > > Thank you for this useful information. I still learning about ELF and > a lot of things are still unclear for me. > > On Mon, Jul 31, 2017 at 11:20 AM, Richard Henderson wrote: > > On 07/31/2017 10:21

[Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-03 Thread Marc-André Lureau
Learn to compile out vhost-user (net, scsi & upcoming users). Keep it enabled by default on non-win32, that is assumed to be POSIX. Fail if trying to enable it on win32. When trying to make a vhost-user netdev, it gives the following error: -netdev vhost-user,id=foo,chardev=chr-test: Parameter

Re: [Qemu-devel] [RFC 20/29] migration: wakeup dst ram-load-thread for recover

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On the destination side, we cannot wake up all the threads when we got > reconnected. The first thing to do is to wake up the main load thread, > so that we can continue to receive valid messages from source again and > reply when needed. > > At this point,

Re: [Qemu-devel] [PATCH] docs/pcie.txt: Replace ioh3420 with pcie-root-port

2017-08-03 Thread Marcel Apfelbaum
On 03/08/2017 0:25, Michael S. Tsirkin wrote: On Wed, Aug 02, 2017 at 06:51:13PM +0300, Marcel Apfelbaum wrote: Do not mention ioh3420 in the "how to" doc. The device still works and can be used by already existing setups, but no need to be mentioned. Suggested-by: Andrew Jones

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-03 Thread Cornelia Huck
On Thu, 3 Aug 2017 11:07:46 +0200 Marc-André Lureau wrote: > Learn to compile out vhost-user (net, scsi & upcoming users). Keep it > enabled by default on non-win32, that is assumed to be POSIX. Fail if > trying to enable it on win32. > > When trying to make a

Re: [Qemu-devel] [RFC 21/29] migration: new cmd MIG_CMD_RECV_BITMAP

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Add a new vm command MIG_CMD_RECV_BITMAP to request received bitmap for > one ramblock. > > Signed-off-by: Peter Xu > --- > migration/savevm.c | 59 > ++ > migration/savevm.h | 1

Re: [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM

2017-08-03 Thread Stefan Hajnoczi
On Thu, Aug 03, 2017 at 10:08:01AM +0200, Kevin Wolf wrote: > Am 02.08.2017 um 12:57 hat Manos Pitsidianakis geschrieben: > > On Wed, Aug 02, 2017 at 11:39:22AM +0100, Stefan Hajnoczi wrote: > > > On Tue, Aug 01, 2017 at 07:49:33PM +0300, Manos Pitsidianakis wrote: > > > > On Tue, Aug 01, 2017 at

Re: [Qemu-devel] [PATCH 3/3] block: remove legacy I/O throttling

2017-08-03 Thread Kevin Wolf
Am 01.08.2017 um 15:49 hat Manos Pitsidianakis geschrieben: > This commit removes all I/O throttling from block/block-backend.c. In > order to support the existing interface, it is changed to use the > block/throttle.c filter driver. > > The throttle filter node that is created by the legacy

Re: [Qemu-devel] [RFC v3 6/8] virtio-iommu: Implement the translation and commands

2017-08-03 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: Tuesday, August 01, 2017 3:03 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; > peter.mayd...@linaro.org; alex.william...@redhat.com; m...@redhat.com; > qemu-...@nongnu.org;

Re: [Qemu-devel] [RFC v2 6/8] virtio-iommu: Implement the translation and commands

2017-08-03 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, July 31, 2017 6:38 PM > To: Peter Xu ; Bharat Bhushan > > Cc: w...@redhat.com; peter.mayd...@linaro.org; kevin.t...@intel.com; > drjo...@redhat.com;

Re: [Qemu-devel] [RFC v5 0/8] ARM SMMUv3 Emulation Support

2017-08-03 Thread Auger Eric
Hi Tomasz, On 03/08/2017 12:11, Tomasz Nowicki wrote: > Hi Eric, > > On 01.08.2017 15:07, Auger Eric wrote: >> Hi Tomasz, >> On 01/08/2017 13:01, Tomasz Nowicki wrote: >>> Hi Eric, >>> >>> Just letting you know that I am facing another issue with the following >>> setup: >>> 1. host (4.12 kernel

Re: [Qemu-devel] [PATCH v3 4/7] block: convert ThrottleGroup to object with QOM

2017-08-03 Thread Kevin Wolf
Am 03.08.2017 um 12:53 hat Stefan Hajnoczi geschrieben: > On Thu, Aug 03, 2017 at 10:08:01AM +0200, Kevin Wolf wrote: > > Am 02.08.2017 um 12:57 hat Manos Pitsidianakis geschrieben: > > > On Wed, Aug 02, 2017 at 11:39:22AM +0100, Stefan Hajnoczi wrote: > > > > On Tue, Aug 01, 2017 at 07:49:33PM

Re: [Qemu-devel] [RFC 24/29] migration: new message MIG_RP_MSG_RESUME_ACK

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t > is used as payload to let the source know whether destination is ready > to continue the migration. > > Signed-off-by: Peter Xu > --- > migration/migration.c |

Re: [Qemu-devel] [RFC v5 0/8] ARM SMMUv3 Emulation Support

2017-08-03 Thread Tomasz Nowicki
Hi Eric, On 01.08.2017 15:07, Auger Eric wrote: Hi Tomasz, On 01/08/2017 13:01, Tomasz Nowicki wrote: Hi Eric, Just letting you know that I am facing another issue with the following setup: 1. host (4.12 kernel & 64K page) and VM (4.12 kernel & 64K page) 2. QEMU + -netdev

Re: [Qemu-devel] [PATCH 2/3] block: skip implicit nodes in snapshots, blockjobs

2017-08-03 Thread Kevin Wolf
Am 01.08.2017 um 15:49 hat Manos Pitsidianakis geschrieben: > Implicit filter nodes added at the top of nodes can interfere with block > jobs. This is not a problem when they are added by other jobs since > adding another job will issue a QERR_DEVICE_IN_USE, but it can happen in > the next commit

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-03 Thread Marcel Apfelbaum
On 03/08/2017 5:41, Laine Stump wrote: On 08/02/2017 01:58 PM, Marcel Apfelbaum wrote: On 02/08/2017 19:26, Michael S. Tsirkin wrote: On Wed, Aug 02, 2017 at 06:36:29PM +0300, Marcel Apfelbaum wrote: Can dmi-pci support shpc? why doesn't it? For compatibility? I don't know why, but the fact

Re: [Qemu-devel] [RFC 22/29] migration: new message MIG_RP_MSG_RECV_BITMAP

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introducing new return path message MIG_RP_MSG_RECV_BITMAP to send > received bitmap of ramblock back to source. > > This is the reply message of MIG_CMD_RECV_BITMAP, it contains not only > the header (including the ramblock name), and it was appended with

Re: [Qemu-devel] [RFC 23/29] migration: new cmd MIG_CMD_POSTCOPY_RESUME

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introducing this new command to be sent when the source VM is ready to > resume the paused migration. What the destination does here is > basically release the fault thread to continue service page faults. > > Signed-off-by: Peter Xu >

[Qemu-devel] [PULL] build-sys: add --disable-vhost-user

2017-08-03 Thread Michael S. Tsirkin
From: Marc-André Lureau Learn to compile out vhost-user (net, scsi & upcoming users). Keep it enabled by default on non-win32, that is assumed to be POSIX. Fail if trying to enable it on win32. When trying to make a vhost-user netdev, it gives the following error:

Re: [Qemu-devel] [PATCH] kvm: workaround build break on gcc-7.1.1 / fedora26

2017-08-03 Thread Philippe Mathieu-Daudé
On 08/03/2017 10:55 AM, Eric Blake wrote: On 08/03/2017 08:34 AM, Philippe Mathieu-Daudé wrote: Hi Greg, On 08/02/2017 11:47 AM, Greg Kurz wrote: Building QEMU on fedora26 with the latest gcc package fails: CC ppc64-softmmu/target/ppc/kvm.o In file included from

Re: [Qemu-devel] [PATCH] kvm: workaround build break on gcc-7.1.1 / fedora26

2017-08-03 Thread Cornelia Huck
On Thu, 3 Aug 2017 09:10:29 -0500 Eric Blake wrote: > On 08/03/2017 08:46 AM, Philippe Mathieu-Daudé wrote: > > Hi Greg, > > > > On 08/02/2017 11:47 AM, Greg Kurz wrote: > >> Building QEMU on fedora26 with the latest gcc package fails: > >> > >>CC

[Qemu-devel] [PATCH for-2.10 4/5] qemu-io: Allow reopen read-write

2017-08-03 Thread Kevin Wolf
This allows qemu-iotests to test the switch between read-only and read-write mode for block devices. Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index

Re: [Qemu-devel] [PATCH v2 1/4] qemu-img: Sort sub-command names in --help

2017-08-03 Thread Eric Blake
On 08/03/2017 10:14 AM, Kevin Wolf wrote: > Am 28.07.2017 um 18:47 hat Eric Blake geschrieben: >> 'amend' was the only sub-command not listed alphabetically; > > Not completel true: create is the second one that is in the wrong place, > it should come after commit/compare/convert. Do you want to

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:02:57PM +0200, Kevin Wolf wrote: > Commit 8ee03995 refactored the code incorrectly and broke the release of > permissions on the old BDS. Instead of changing the permissions to the > new required values after removing the old BDS from the list of > children, it only

Re: [Qemu-devel] [PATCH v2 4/4] maint: Include bug-reporting info in --help output.

2017-08-03 Thread Philippe Mathieu-Daudé
On 07/28/2017 01:47 PM, Eric Blake wrote: These days, many programs are including a bug-reporting address, or better yet, a link to the project web site, at the tail of their --help output. However, we were not very consistent at doing so: only qemu-nbd and qemu-qa mentioned anything, with the

[Qemu-devel] [PULL] virtio: fix for rc2

2017-08-03 Thread Michael S. Tsirkin
The following changes since commit aaaec6acad7cf97372d48c1b09126a09697519c8: Update version for v2.10.0-rc1 release (2017-08-02 16:36:32 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [Qemu-devel] [Qemu-arm] [PATCH 06/15] target/arm: Remove incorrect comment about MPU_CTRL

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:52PM +0100, Peter Maydell wrote: > Remove the comment that claims that some MPU_CTRL bits are stored > in sctlr_el[1]. This has never been true since MPU_CTRL was added > in commit 29c483a50607 -- the comment is a leftover from > Michael Davidsaver's original

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/15] target/arm: Don't store M profile PRIMASK and FAULTMASK in daif

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:55PM +0100, Peter Maydell wrote: > We currently store the M profile CPU register state PRIMASK and > FAULTMASK in the daif field of the CPU state in its I and F > bits. This is a legacy from the original implementation, which > tried to share the cpu_exec_interrupt

Re: [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-03 Thread Laine Stump
On 08/03/2017 06:29 AM, Marcel Apfelbaum wrote: > On 03/08/2017 5:41, Laine Stump wrote: >> On 08/02/2017 01:58 PM, Marcel Apfelbaum wrote: >>> On 02/08/2017 19:26, Michael S. Tsirkin wrote: On Wed, Aug 02, 2017 at 06:36:29PM +0300, Marcel Apfelbaum wrote: >> Can dmi-pci support shpc?

Re: [Qemu-devel] [RFC 12/29] migration: allow dst vm pause on postcopy

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Aug 01, 2017 at 10:47:16AM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > [...] > > > > +/* Return true if we should continue the migration, or false. */ > > > +static bool

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

2017-08-03 Thread Alistair Francis
On Fri, Jul 28, 2017 at 5:49 PM, Philippe Mathieu-Daudé wrote: > On 07/28/2017 08:56 PM, Alistair Francis wrote: >> >> On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé >> wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>

[Qemu-devel] [PATCH for-2.10 0/5] block: bdrv_reopen() fixes

2017-08-03 Thread Kevin Wolf
This is the first part of some fixes to bdrv_reopen(), which seems reasonable enough to merge for 2.10. There is much more wrong with bdrv_reopen() currently, especially with respect to op blocker permissions (basically the required permissions can change based on the options used in

[Qemu-devel] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

2017-08-03 Thread Kevin Wolf
Commit 8ee03995 refactored the code incorrectly and broke the release of permissions on the old BDS. Instead of changing the permissions to the new required values after removing the old BDS from the list of children, it only re-obtains the permissions it already had. Change the order of

[Qemu-devel] [PATCH for-2.10 2/5] block: Allow reopen rw without BDRV_O_ALLOW_RDWR

2017-08-03 Thread Kevin Wolf
BDRV_O_ALLOW_RDWR is a flag that tells whether qemu can internally reopen a node read-write temporarily because the user requested read-write for the top-level image, but qemu decided that read-only is enough for this node (a backing file). bdrv_reopen() is different, it is also used for cases

Re: [Qemu-devel] [PATCH 1/2] scsi: Make LUN 0 a simple enclosure

2017-08-03 Thread Hannes Reinecke
On 08/03/2017 03:32 PM, Daniel P. Berrange wrote: > On Thu, Aug 03, 2017 at 03:27:00PM +0200, Hannes Reinecke wrote: >> Instead of having an 'invisible' LUN0 (in case LUN 0 is not connected) >> this patch maks LUN0 a enclosure service, exposing it to the OS. >> >> Signed-off-by: Hannes Reinecke

Re: [Qemu-devel] [PATCH for-2.10 5/5] qemu-iotests: Test reopen between read-only and read-write

2017-08-03 Thread Eric Blake
On 08/03/2017 10:03 AM, Kevin Wolf wrote: > This serves as a regression test for the bugs that were just fixed for > bdrv_reopen() between read-only and read-write mode. If I'm right that this also fixes the difference between intermediate vs. live commit to an initial read-write image that can't

Re: [Qemu-devel] [RFC 00/29] Migration: postcopy failure recovery

2017-08-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > As we all know that postcopy migration has a potential risk to lost > the VM if the network is broken during the migration. This series > tries to solve the problem by allowing the migration to pause at the > failure point, and do recovery after the link is

[Qemu-devel] [PATCH v3 3/4] qga: Give more --version information

2017-08-03 Thread Eric Blake
Include the package version information (useful for detecting builds from git or downstream backports), and the copyright notice. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrange --- qga/main.c | 6 -- 1 file changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v3 1/4] qemu-img: Sort sub-command names in --help

2017-08-03 Thread Eric Blake
'amend' and 'create' were not listed alphabetically; hoist them earlier. Separate the @end table block to make it easier to copy-and-paste the addition of future sub-commands. Signed-off-by: Eric Blake --- v3: also sort 'create' [Kevin] --- qemu-img-cmds.hx | 21

[Qemu-devel] [PATCH v3 for-2.10 0/4] improved --version/--help tweaks

2017-08-03 Thread Eric Blake
Not sure if this should go through Kevin's block tree, Paolo's miscellaneous patches, or if I should just do a pull request myself (since patch 4 includes a change to qemu-nbd) since v2: add R-b on 2-4; also sort 'qemu-img --help' create text 001/4:[0012] [FC] 'qemu-img: Sort sub-command names

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 3/5] block: Set BDRV_O_ALLOW_RDWR during rw reopen

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:02:59PM +0200, Kevin Wolf wrote: > Reopening an image should be consistent with opening it, so we should > set BDRV_O_ALLOW_RDWR for any image that is reopened read-write like in > bdrv_open_inherit(). > > Signed-off-by: Kevin Wolf > --- > block.c |

[Qemu-devel] [PATCH v3 2/4] qemu-io: Give more --version information

2017-08-03 Thread Eric Blake
Include the package version information (useful for detecting builds from git or downstream backports), and the copyright notice. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrange Acked-by: Kevin Wolf --- qemu-io.c | 4 +++- 1

Re: [Qemu-devel] [PATCH] kvm: workaround build break on gcc-7.1.1 / fedora26

2017-08-03 Thread Greg Kurz
On Thu, 3 Aug 2017 10:34:45 -0300 Philippe Mathieu-Daudé wrote: > Hi Greg, > > On 08/02/2017 11:47 AM, Greg Kurz wrote: > > Building QEMU on fedora26 with the latest gcc package fails: > > > >CC ppc64-softmmu/target/ppc/kvm.o > > In file included from

[Qemu-devel] [PULL 3/8] mips: Improve segment defs for KVM T guests

2017-08-03 Thread Yongbok Kim
From: James Hogan Improve the segment definitions used by get_physical_address() to yield target_ulong types, e.g. 0x8000 instead of 0x8000. This is in preparation for enabling emulation of MIPS KVM T segments in TCG MIPS targets, which unlike KVM could

[Qemu-devel] [PULL 4/8] mips: Add KVM T segment support for TCG

2017-08-03 Thread Yongbok Kim
From: James Hogan MIPS KVM trap & emulate guest kernels have a different segment layout compared with traditional MIPS kernels, to allow both the user and kernel code to run from the user address segment without repeatedly trapping to KVM. QEMU currently supports this

Re: [Qemu-devel] [PATCH 0/2] scsi: enclosure support

2017-08-03 Thread Paolo Bonzini
On 03/08/2017 15:26, Hannes Reinecke wrote: > Hi all, > > due to a customer issue I've added simple subenclosure support > to the SCSI emulation. The patch simply converts the current invisible > LUN0 into an enclosure device; existing setups using LUN0 as disks or > CD-ROMs will not be affected.

Re: [Qemu-devel] [PATCH] tests/pxe: Check virtio-net-ccw on s390x

2017-08-03 Thread Cornelia Huck
On Thu, 3 Aug 2017 15:30:19 +0200 Thomas Huth wrote: > Now that we've got a firmware that can do TFTP booting on s390x (i.e. > the pc-bios/s390-netboot.img), we can enable the PXE tester for this > architecture, too. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [Qemu-arm] [PATCH 08/15] target/arm: Define and use XPSR bit masks

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:54PM +0100, Peter Maydell wrote: > The M profile XPSR is almost the same format as the A profile CPSR, > but not quite. Define some XPSR_* macros and use them where we > definitely dealing with an XPSR rather than reusing the CPSR ones. > > Signed-off-by: Peter

Re: [Qemu-devel] [Qemu-arm] [PATCH 15/15] nvic: Implement "user accesses BusFault" SCS region behaviour

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:44:01PM +0100, Peter Maydell wrote: > The ARMv7M architecture specifies that most of the addresses in the > PPB region (which includes the NVIC, systick and system registers) > are not accessible to unprivileged accesses, which should > BusFault with a few exceptions: >

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 4/5] qemu-io: Allow reopen read-write

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:03:00PM +0200, Kevin Wolf wrote: > This allows qemu-iotests to test the switch between read-only and > read-write mode for block devices. > > Signed-off-by: Kevin Wolf > --- > qemu-io-cmds.c | 19 +-- > 1 file changed, 17

[Qemu-devel] [PATCH v3 4/4] maint: Include bug-reporting info in --help output

2017-08-03 Thread Eric Blake
These days, many programs are including a bug-reporting address, or better yet, a link to the project web site, at the tail of their --help output. However, we were not very consistent at doing so: only qemu-nbd and qemu-qa mentioned anything, with the latter pointing to an individual person

[Qemu-devel] [Bug 1708462] [NEW] Support Python 3 to build

2017-08-03 Thread Ross Burton
Public bug reported: Currently qemu's configure requires Python 2 to build. As Python 2 is rapidly approaching its EOL, it should be possible to build qemu with Python 3. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a

Re: [Qemu-devel] [Bug 1708442] [NEW] Crash(assert) during reading image from http url through qemu-nbd

2017-08-03 Thread Andrey Smetanin
03.08.2017, 17:01, "Eric Blake" <1708...@bugs.launchpad.net>: > On 08/03/2017 07:12 AM, Andrey Smetanin wrote: >>  Public bug reported: >> >>  Description: >>  During reading image from nbd device mounted by qemu-nbd server with url >> backend I/O error happens >>  "blk_update_request: I/O error,

Re: [Qemu-devel] [PATCH] kvm: workaround build break on gcc-7.1.1 / fedora26

2017-08-03 Thread Greg Kurz
On Thu, 3 Aug 2017 10:46:47 -0300 Philippe Mathieu-Daudé wrote: > Hi Greg, > > On 08/02/2017 11:47 AM, Greg Kurz wrote: > > Building QEMU on fedora26 with the latest gcc package fails: > > > >CC ppc64-softmmu/target/ppc/kvm.o > > In file included from

[Qemu-devel] [PATCH for-2.10 5/5] qemu-iotests: Test reopen between read-only and read-write

2017-08-03 Thread Kevin Wolf
This serves as a regression test for the bugs that were just fixed for bdrv_reopen() between read-only and read-write mode. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/187 | 69 ++ tests/qemu-iotests/187.out | 18

Re: [Qemu-devel] [PATCH 07/15] target/arm: Fix outdated comment about exception exit

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:53PM +0100, Peter Maydell wrote: > When we switched our handling of exception exit to detect > the magic addresses at translate time rather than via > a do_unassigned_access hook, we forgot to update a > comment; correct the omission. > > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-arm] [PATCH 12/15] target/arm: Don't calculate lr in arm_v7m_cpu_do_interrupt() until needed

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:58PM +0100, Peter Maydell wrote: > Move the code in arm_v7m_cpu_do_interrupt() that calculates the > magic LR value down to when we're actually going to use it. > Having the calculation and use so far apart makes the code > a little harder to understand than it needs

Re: [Qemu-devel] [PATCH] kvm: workaround build break on gcc-7.1.1 / fedora26

2017-08-03 Thread Eric Blake
On 08/03/2017 08:46 AM, Philippe Mathieu-Daudé wrote: > Hi Greg, > > On 08/02/2017 11:47 AM, Greg Kurz wrote: >> Building QEMU on fedora26 with the latest gcc package fails: >> >>CC ppc64-softmmu/target/ppc/kvm.o >> In file included from include/sysemu/hw_accel.h:16:0, >>

[Qemu-devel] [PULL 1/8] target-mips: Don't stop on [d]mtc0 DESAVE/KScratch

2017-08-03 Thread Yongbok Kim
From: James Hogan Writing to the MIPS DESAVE register (and now the KScratch registers) will stop translation, supposedly due to risk of execution mode switches. However these registers are basically RW scratch registers with no side effects so there is no risk of them

[Qemu-devel] [PULL 7/8] target/mips: Drop redundant gen_io_start/stop()

2017-08-03 Thread Yongbok Kim
From: James Hogan DMTC0 CP0_Cause does a redundant gen_io_start() and gen_io_end() pair, even though this is done for all DMTC0 operations outside of the switch statement. Remove these redundant calls. Fixes: 5dc5d9f055c5 ("mips: more fixes to the MIPS interrupt glue

[Qemu-devel] [PULL 8/8] target/mips: Fix RDHWR CC with icount

2017-08-03 Thread Yongbok Kim
From: James Hogan RDHWR CC reads the CPU timer like MFC0 CP0_Count, so with icount enabled it must set can_do_io while it calls the helper to avoid the "Bad icount read" error. It should also break out of the translation loop to ensure that timer interrupts are

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-03 Thread Igor Mammedov
On Wed, 2 Aug 2017 18:29:33 -0300 Eduardo Habkost wrote: > On Wed, Aug 02, 2017 at 03:50:36PM +0200, Laurent Vivier wrote: > > On 02/08/2017 15:42, Philippe Mathieu-Daudé wrote: > > > Hi Laurent, > > > > > > On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier

[Qemu-devel] [PATCH for-2.10 3/5] block: Set BDRV_O_ALLOW_RDWR during rw reopen

2017-08-03 Thread Kevin Wolf
Reopening an image should be consistent with opening it, so we should set BDRV_O_ALLOW_RDWR for any image that is reopened read-write like in bdrv_open_inherit(). Signed-off-by: Kevin Wolf --- block.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [Bug 1708442] Re: Crash(assert) during reading image from http url through qemu-nbd

2017-08-03 Thread Andrey Smetanin
I've build qemu-nbd-bug.go into binary qemu-nbd-bug (go build qemu-nbd-bug.go), so to reproduce bug anyone may try: 0) ensure image.img exists in current folder. image.img may be copied from "Qemu-nbd core dump and script to reproduce " attachment. 1) sudo ./qemu-nbd-bug 2) wait while binary

Re: [Qemu-devel] [PATCH v2 1/4] qemu-img: Sort sub-command names in --help

2017-08-03 Thread Kevin Wolf
Am 28.07.2017 um 18:47 hat Eric Blake geschrieben: > 'amend' was the only sub-command not listed alphabetically; Not completel true: create is the second one that is in the wrong place, it should come after commit/compare/convert. Do you want to fix that one, too? > hoist it earlier, and

Re: [Qemu-devel] [PATCH for-2.10 4/5] qemu-io: Allow reopen read-write

2017-08-03 Thread Eric Blake
On 08/03/2017 10:03 AM, Kevin Wolf wrote: > This allows qemu-iotests to test the switch between read-only and > read-write mode for block devices. > > Signed-off-by: Kevin Wolf > --- > qemu-io-cmds.c | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-03 Thread Eduardo Habkost
On Wed, Aug 02, 2017 at 02:33:00PM +0200, Halil Pasic wrote: > > > On 08/02/2017 01:01 AM, Eduardo Habkost wrote: > > TYPE_VIRTIO_DEVICE devices are already not usable with -device > > and device_add, but they are reported as user-creatable on > > "-device help" and through monitor interfaces. >

[Qemu-devel] [PULL 2/8] mips/malta: leave space for the bootmap after the initrd

2017-08-03 Thread Yongbok Kim
From: Aurelien Jarno Since commit 9768e2abf7 the initrd is loaded at the end of the low memory to avoid clash for the kernel relocation when kaslr is used. However this in turn conflicts with the bootmap memory that the kernel tries to place after initrd, but in low

[Qemu-devel] [PULL 0/8] target-mips queue

2017-08-03 Thread Yongbok Kim
The following changes since commit aaaec6acad7cf97372d48c1b09126a09697519c8: Update version for v2.10.0-rc1 release (2017-08-02 16:36:32 +0100) are available in the git repository at: git://github.com/yongbok/upstream-qemu.git tags/mips-20170803 for you to fetch changes up

[Qemu-devel] [PULL 5/8] target-mips: apply CP0.PageMask before writing into TLB entry

2017-08-03 Thread Yongbok Kim
From: Leon Alrae PFN0 and PFN1 have to be masked out with PageMask_Mask. Signed-off-by: Leon Alrae Reviewed-by: Yongbok Kim [Yongbok Kim: Added commit message] Signed-off-by: Yongbok Kim ---

[Qemu-devel] [PULL 6/8] target/mips: Use BS_EXCP where interrupts are expected

2017-08-03 Thread Yongbok Kim
From: James Hogan Commit e350d8ca3ac7 ("target/mips: optimize indirect branches") made indirect branches able to directly find the next TB and jump straight to it without breaking out of translated code and going around the main execution loop. This breaks the assumption

Re: [Qemu-devel] [PATCH for-2.10 1/5] block: Fix order in bdrv_replace_child()

2017-08-03 Thread Eric Blake
On 08/03/2017 10:02 AM, Kevin Wolf wrote: > Commit 8ee03995 refactored the code incorrectly and broke the release of > permissions on the old BDS. Instead of changing the permissions to the > new required values after removing the old BDS from the list of > children, it only re-obtains the

Re: [Qemu-devel] [PATCH v2 2/4] qemu-io: Give more --version information

2017-08-03 Thread Kevin Wolf
Am 28.07.2017 um 18:47 hat Eric Blake geschrieben: > Include the package version information (useful for detecting > builds from git or downstream backports), and the copyright notice. > > Signed-off-by: Eric Blake Acked-by: Kevin Wolf

Re: [Qemu-devel] [PATCH for-2.10 2/5] block: Allow reopen rw without BDRV_O_ALLOW_RDWR

2017-08-03 Thread Eric Blake
On 08/03/2017 10:02 AM, Kevin Wolf wrote: > BDRV_O_ALLOW_RDWR is a flag that tells whether qemu can internally > reopen a node read-write temporarily because the user requested > read-write for the top-level image, but qemu decided that read-only is > enough for this node (a backing file). > >

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-03 Thread Alistair Francis
On Fri, Jul 28, 2017 at 4:57 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 07/28/2017 07:16 PM, Alistair Francis wrote: >> >> Convert any remaining uses of fprintf(stderr, "warning:"... >> to use warn_report() instead. This helps standardise on a single >> method of

Re: [Qemu-devel] [Qemu-arm] [PATCH 13/15] target/arm: Create and use new function arm_v7m_is_handler_mode()

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:59PM +0100, Peter Maydell wrote: > Add a utility function for testing whether the CPU is in Handler > mode; this is just a check whether v7m.exception is non-zero, but > we do it in several places and it makes the code a bit easier > to read to not have to mentally

Re: [Qemu-devel] [Qemu-arm] [PATCH 14/15] armv7m_nvic.h: Move from include/hw/arm to include/hw/intc

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:44:00PM +0100, Peter Maydell wrote: > The armv7m_nvic.h header file was accidentally placed in > include/hw/arm; move it to include/hw/intc to match where > its corresponding .c file lives. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar

Re: [Qemu-devel] [PATCH] target-mips: apply CP0.PageMask before writing into TLB entry

2017-08-03 Thread Yongbok Kim
On 02/08/2017 19:56, Philippe Mathieu-Daudé wrote: > Hi Leon, > > On 08/02/2017 10:58 AM, Yongbok Kim wrote: >> From: Leon Alrae >> >> PFN0 and PFN1 have to be masked out with PageMask_Mask. >> >> Signed-off-by: Leon Alrae >> Reviewed-by: Yongbok

[Qemu-devel] [Bug 1708442] Re: Crash(assert) during reading image from http url through qemu-nbd

2017-08-03 Thread Andrey Smetanin
I've attached patch which resolves bug, but actually it's just workaround and may be not unsafe, because it's just ignore assert. ** Patch added: "workaround patch"

Re: [Qemu-devel] [PATCH for-2.10 3/5] block: Set BDRV_O_ALLOW_RDWR during rw reopen

2017-08-03 Thread Eric Blake
On 08/03/2017 10:02 AM, Kevin Wolf wrote: > Reopening an image should be consistent with opening it, so we should > set BDRV_O_ALLOW_RDWR for any image that is reopened read-write like in > bdrv_open_inherit(). > > Signed-off-by: Kevin Wolf > --- > block.c | 5 - > 1 file

Re: [Qemu-devel] [Qemu-arm] [PATCH 11/15] target/arm: Make arm_cpu_dump_state() handle the M-profile XPSR

2017-08-03 Thread Edgar E. Iglesias
On Wed, Aug 02, 2017 at 05:43:57PM +0100, Peter Maydell wrote: > Make the arm_cpu_dump_state() debug logging handle the M-profile XPSR > rather than assuming it's an A-profile CPSR. On M profile the PSR > line of a register dump will now look like this: > > XPSR=4100 -Z-- T priv-thread > >

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 2/5] block: Allow reopen rw without BDRV_O_ALLOW_RDWR

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:02:58PM +0200, Kevin Wolf wrote: > BDRV_O_ALLOW_RDWR is a flag that tells whether qemu can internally > reopen a node read-write temporarily because the user requested > read-write for the top-level image, but qemu decided that read-only is > enough for this node (a

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 5/5] qemu-iotests: Test reopen between read-only and read-write

2017-08-03 Thread Jeff Cody
On Thu, Aug 03, 2017 at 05:03:01PM +0200, Kevin Wolf wrote: > This serves as a regression test for the bugs that were just fixed for > bdrv_reopen() between read-only and read-write mode. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/187 | 69 >

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

2017-08-03 Thread Dr. David Alan Gilbert
* Alberto Garcia (be...@igalia.com) wrote: > On Thu, Jul 13, 2017 at 08:01:16PM +0100, Dr. David Alan Gilbert (git) wrote: > > --- a/vl.c > > +++ b/vl.c > > @@ -4787,8 +4787,8 @@ int main(int argc, char **argv, char **envp) > > replay_disable_events(); > > iothread_stop_all(); > > > >

[Qemu-devel] [PULL 0/1] cpu: crash fix for -rc2 (don't allow negative core id)

2017-08-03 Thread Eduardo Habkost
The following changes since commit aaaec6acad7cf97372d48c1b09126a09697519c8: Update version for v2.10.0-rc1 release (2017-08-02 16:36:32 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/machine-pull-request for you to fetch changes up to

[Qemu-devel] [PULL for-2.10 1/3] tcg/arm: Fix runtime overalignment test

2017-08-03 Thread Richard Henderson
Patch 85aa80813dd changed the IF emitting the TST instruction, but failed to change the ?: converting CMP to CMPEQ, so the result of the TST is ignored. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 1/1] cpu: don't allow negative core id

2017-08-03 Thread Eduardo Habkost
From: Laurent Vivier With pseries machine type a negative core-id is not managed properly: -1 gives an inaccurate error message ("core -1 already populated"), -2 crashes QEMU (core dump) As it seems a negative value is invalid for any architecture, instead of checking this

Re: [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled

2017-08-03 Thread Philippe Mathieu-Daudé
On 08/03/2017 02:56 PM, Richard Henderson wrote: On 08/03/2017 10:40 AM, Philippe Mathieu-Daudé wrote: On 07/26/2017 05:02 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Hi Peter, I think this patch belongs to 2.10, as there is no time to fix TCI + MTTCG. Should I

[Qemu-devel] [PULL for-2.10 2/3] target/s390x: Fix CSST for 16-byte store

2017-08-03 Thread Richard Henderson
Found by Coverity (CID 1378273). Reviewed-by: Philippe Mathieu-Daudé Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/mem_helper.c

[Qemu-devel] [PULL for-2.10 0/3] TCG misc patches

2017-08-03 Thread Richard Henderson
at: git://github.com/rth7680/qemu.git tags/pull-tcg-20170803 for you to fetch changes up to 13aaef678ed377b12b76dc7fb9e615b2f2f9047b: tcg: Increase minimum alignment from tcg_malloc to 8 (2017-08-03 11:00:30 -0700) Queued misc tcg

  1   2   3   >