Re: [Qemu-devel] [PATCH for-2.10 0/2] Fix NBD client after server error

2017-08-11 Thread Eric Blake
On 08/10/2017 09:37 PM, Eric Blake wrote: > Patch 1 is a much smaller patch than Vladimir's attempt [1] at fixing > the client in the face of a malicious server. > > [1] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01501.html > > Patch 2 is not to be applied; it is a hack for easily

[Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

2017-08-11 Thread Markus Armbruster
v2: * PATCH 1: Whitespace change dropped [Eric] * PATCH 2: Deallocation done differently [Paolo], R-by dropped Commit message typo [Eric] Markus Armbruster (2): vl: Factor object_create() out of main() vl: Partial support for non-scalar properties with -object qapi-schema.json |

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/2] Increased the size of requester_id field from MemTxAttrs

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 15:32, Diana Madalina Craciun wrote: > On 07/26/2017 03:23 PM, Auger Eric wrote: >> With respect to the renaming, stream_id really is ARM specific and >> corresponds to the ID space before the SMMU while you mostly address >> device id problematics here

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Thomas Huth
On 11.08.2017 18:11, David Hildenbrand wrote: > On 11.08.2017 16:39, Thomas Huth wrote: >> On 11.08.2017 16:21, David Hildenbrand wrote: >>> On 11.08.2017 16:00, Thomas Huth wrote: On 11.08.2017 09:46, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 16:19, Thomas Huth wrote: > On 11.08.2017 09:46, David Hildenbrand wrote: >> Let's move everything into internal.h > > Or kvm_s390x.h ? ;-) And even kvm-stubs.c! > > Thomas > > -- Thanks, David

[Qemu-devel] [Bug 1583420] Re: Please support "-soundhw none"

2017-08-11 Thread VinceLe
It looks like qemu without any specific -soundhw CLI option uses pulseaudio. So I still think a -soundhw none would be nice to have. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1583420 Title:

Re: [Qemu-devel] [PATCH v6 17/19] migration: Rename initial_bytes

2017-08-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Now it is called qemu_file_bytes that reflects better what it does, > and we create qemu_file_bytes_now to not have to call qemu_ftell() twice. Yes OK, although you could lose the 'qemu_' off the start; it's local anyway. Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 18:10, Peter Maydell wrote: > I get an intermittent failure on aarch64 test-aio-multithread: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > gtester -k --verbose -m=quick tests/test-aio-multithread > TEST:

[Qemu-devel] [RFC v1 1/3] target/arm: Update the memops for exclusive load

2017-08-11 Thread Alistair Francis
Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Signed-off-by: Alistair Francis ---

[Qemu-devel] [RFC v1 3/3] target/arm: Correct exclusive store return value

2017-08-11 Thread Alistair Francis
The exclusive store operation should return 0 if the operation updates memory and 1 if it doesn't. This means that storing tmp in the rd register is incorrect. This patch updates the succesful opertion to store 0 into the rd register instead of tmp. It also adds a branch to fail if the memory

[Qemu-devel] [RFC v1 0/3] Fixup exclusive store logic

2017-08-11 Thread Alistair Francis
I found some issues with the way exclusive store was working. This patch series seems to fix the test cases that were failing for me and also seem to follow what the ARM ARM says. The first patch is just a simple adjustment. The second patch is just preparing for the third patch. The third

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

2017-08-11 Thread Kevin Wolf
Am 11.08.2017 um 17:34 hat Christian Ehrhardt geschrieben: > On Fri, Aug 11, 2017 at 2:37 PM, Kevin Wolf wrote: > > > Am 11.08.2017 um 14:04 hat Fam Zheng geschrieben: > > > On Fri, 08/11 13:07, Christian Ehrhardt wrote: > > > > Simplifying that to a smaller test: > > > > > > >

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

2017-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > set, but this was done only when ACPI tables are built which is not > needed for a Xen guest. The need for the property starts with commit > "pc: pcihp:

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread Richard Henderson
It's not all kvm related, so I'd prefer the more general name. r~ On August 11, 2017 9:19:52 AM CDT, Thomas Huth wrote: >On 11.08.2017 09:46, David Hildenbrand wrote: >> Let's move everything into internal.h > >Or kvm_s390x.h ? ;-) > > Thomas -- Sent from my Android device

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-08-11 Thread Eduardo Habkost
On Fri, Aug 11, 2017 at 05:44:55PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > > CCing Zack Cornelius. > > > > On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > > > This series adds a new "persistent" option to > > >

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-08-11 Thread Eduardo Habkost
CCing Zack Cornelius. On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > This series adds a new "persistent" option to > memory-backend-file. The new option it will be useful if > somebody is sharing RAM contents on a file using share=on, but > don't need it to be flushed to disk

Re: [Qemu-devel] [PULL 0/7] Block/Multiboot patches for 2.10.0-rc3

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 15:05, Kevin Wolf wrote: > The following changes since commit 95766c2cd04395e5712b4d5967b3251f35d537df: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-08-10 18:53:39 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2 2/2] vl: Partial support for non-scalar properties with -object

2017-08-11 Thread Eric Blake
On 08/11/2017 11:05 AM, Markus Armbruster wrote: > We've wanted -object to support non-scalar properties for a while. > Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based > authorization API". Review led to the conclusion that we need to > replace rather than add to QemuOpts. Initial

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-08-11 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 01:33:00PM -0300, Eduardo Habkost wrote: > CCing Zack Cornelius. > > On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > > This series adds a new "persistent" option to > > memory-backend-file. The new option it will be useful if > > somebody is sharing RAM

[Qemu-devel] [Bug 1583420] Re: Please support "-soundhw none"

2017-08-11 Thread Daniel Berrange
Pulseaudio is a sound *backend*. This is independent of the choice of guest hardware frontend. You can disable pulseaudio using an env variable QEMU_AUDIO_DRV=none -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC PATCH] memory: fix access_with_adjusted_size() on big-endian

2017-08-11 Thread KONRAD Frederic
Hi Philippe, Thanks for that, I'll try this out when I'm back. The 15th is blank holiday here. Thanks, Fred On 08/11/2017 04:49 PM, Philippe Mathieu-Daudé wrote: On 08/11/2017 11:25 AM, Paolo Bonzini wrote: On 11/08/2017 16:06, Philippe Mathieu-Daudé wrote: remove unnecessary

Re: [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI

2017-08-11 Thread Anthony PERARD
On Wed, Aug 09, 2017 at 04:51:21PM -0400, Lan Tianyu wrote: > From: Chao Gao > > If a vIOMMU is exposed to guest, guest will configure the msi to remapping > format. The original code isn't suitable to the new format. A new pair > bind/unbind interfaces are added for this

[Qemu-devel] [RFC v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions

2017-08-11 Thread Alistair Francis
Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions as we are going to use them later. Signed-off-by: Alistair Francis --- tcg/tcg-op.c | 4 ++-- tcg/tcg-op.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 19:18, Richard Henderson wrote: > It's not all kvm related, so I'd prefer the more general name. Thomas suggested to have both, internal.h and kvm_s390x.h All KVM stuff goes into kvm_s390x.h. I even moved the stubs to kvm-stubs.c (that's the way e.g. x86 handles it). End result

[Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/

2017-08-11 Thread David Hildenbrand
Let's just introduce an helper. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 +--- target/s390x/cpu.c | 6 ++ target/s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c

[Qemu-devel] [PATCH v3 2/2] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-11 Thread Jens Freimann
From: Jens Freimann Add a PXE testcase tunneling traffic through vhost-user-bridge process. Create a vhost-user-bridge process and connect it to qemu via a socket. Signed-off-by: Jens Freimann --- tests/Makefile.include | 4 +- tests/pxe-test.c

Re: [Qemu-devel] [PATCH 01/15] ui: add keycodemapdb repository as a GIT submodule

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 01:23:08PM -0500, Eric Blake wrote: > On 08/10/2017 10:55 AM, Daniel P. Berrange wrote: > > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > > data file mapping between all the different scancode/keycode/keysym > > sets that are known, and a tool to

Re: [Qemu-devel] [PATCH 02/15] ui: convert common input code to keycodemapdb

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 01:59:09PM -0500, Eric Blake wrote: > On 08/10/2017 10:55 AM, Daniel P. Berrange wrote: > > Replace the number_to_qcode, qcode_to_number and linux_to_qcode > > tables with automatically generated tables. > > > > Missing entries in linux_to_qcode now fixed: > > > In

Re: [Qemu-devel] [PATCH v3 2/6] seccomp: add obsolete argument to command line

2017-08-11 Thread Eduardo Otubo
On Wed, Aug 02, 2017 at 01:33:56PM +0100, Daniel P. Berrange wrote: > On Fri, Jul 28, 2017 at 02:10:36PM +0200, Eduardo Otubo wrote: > > This patch introduces the argument [,obsolete=allow] to the `-sandbox on' > > option. It allows Qemu to run safely on old system that still relies on > > old

Re: [Qemu-devel] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 01:35:15PM -0500, Eric Blake wrote: > On 08/10/2017 11:04 AM, Daniel P. Berrange wrote: > > The inet_parse() function looks for 'ipv4' and 'ipv6' > > flags, but only treats them as bare bool flags. The normal > > QemuOpts parsing would allow on/off values to be set too. > >

Re: [Qemu-devel] [PATCH v6 08/19] migration: Create x-multifd-group parameter

2017-08-11 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:26:18PM +0200, Juan Quintela wrote: > Indicates how many pages we are going to send in each batch to a multifd > thread. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu

[Qemu-devel] [PATCH RFC 5/5] target/s390x: cleanup cpu.h

2017-08-11 Thread David Hildenbrand
Let's reshuffle the function prototypes so we get a cleaner outline of the files. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 140 ++--- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git

[Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

2017-08-11 Thread David Hildenbrand
cpu.h is accessed outside of target/s390x. It should only contain what is expected to be accessed outside of this folder. Therefore, create internal.h and move a lot to that file. While doing that, I noticed that a lot of function prototypes not available with CONFIG_USER_ONLY are not protected

[Qemu-devel] [PATCH RFC 2/5] target/s390x: move a couple of functions to cpu.c

2017-08-11 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- target/s390x/cpu.c | 80 + target/s390x/cpu.h | 88 +++--- 2 files changed, 90 insertions(+), 78 deletions(-) diff --git a/target/s390x/cpu.c

Re: [Qemu-devel] [PATCH] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Fam Zheng
On Fri, 08/11 15:44, Xie Changlong wrote: > 在 8/10/2017 4:01 PM, Fam Zheng 写道: > > People get surprised when, after "qemu-imc create -f raw /dev/sdX", they > > s/qemu-imc/qemu-img/ Thanks, will fix in v2. Fam

[Qemu-devel] [PATCH v2] x86: Increase max vcpu number to 8192

2017-08-11 Thread Lan Tianyu
Intel Xeon phi chip will support 352 logical threads. For HPC usage case, it will create a huge VM with vcpus number as same as host cpus. This patch is to increase max vcpu number from 288 to 8192 which is current default maximum cpu number for Linux kernel. Signed-off-by: Lan Tianyu

Re: [Qemu-devel] [PATCH v2] x86: Increase max vcpu number to 8192

2017-08-11 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Message-id: 1502417472-15511-1-git-send-email-tianyu@intel.com Subject: [Qemu-devel] [PATCH v2] x86: Increase max vcpu number to 8192 === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

2017-08-11 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2017 01:30 PM, Markus Armbruster wrote: >> A command is a query if it has no side effect and yields a result. >> Such commands are typically named query-FOO, but there are exceptions. >> >> The basic idea is to find candidates with

Re: [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object

2017-08-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/08/2017 18:36, Markus Armbruster wrote: +while (!QSIMPLEQ_EMPTY(_queue)) { +ObjectOptionsQueueEntry *e = QSIMPLEQ_FIRST(_queue); + +QSIMPLEQ_REMOVE_HEAD(_queue, entry); +

[Qemu-devel] [PATCH V2 for-2.10] xlnx-qspi: add a property for mmio-execution

2017-08-11 Thread KONRAD Frederic
This adds mmio-exec property to workaround the migration bug. When enabled the migration is blocked and will return an error. Signed-off-by: KONRAD Frederic V1 -> V2: * changed mmio-exec to x-mmio-exec --- hw/ssi/xilinx_spips.c | 36

Re: [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 02:02:32PM -0500, Eric Blake wrote: > On 08/10/2017 10:55 AM, Daniel P. Berrange wrote: > > Now that keycode numbers are converted to QKeyCodes immediately > > when creating input events, the InputKeyEvent struct can be > > changed to only accept a QKeyCode, instead of a

Re: [Qemu-devel] [PATCH for-2.11 0/4] ppc64: add e6500

2017-08-11 Thread Alexander Graf
On 09.08.17 08:13, David Gibson wrote: On Mon, Aug 07, 2017 at 05:50:44PM +0200, KONRAD Frederic wrote: Hi, Those are some patches to add basic e6500 support for the moment e5500 with a correct MMU configuration and supported instructions. Some (maybe a lot of) things are missing (ie: the

Re: [Qemu-devel] [PATCH v3 2/6] seccomp: add obsolete argument to command line

2017-08-11 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 11:12:48AM +0200, Eduardo Otubo wrote: > On Wed, Aug 02, 2017 at 01:33:56PM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 28, 2017 at 02:10:36PM +0200, Eduardo Otubo wrote: > > > This patch introduces the argument [,obsolete=allow] to the `-sandbox on' > > > option. It

Re: [Qemu-devel] [PATCH for-2.10?] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Fam Zheng
On Thu, 08/10 08:58, Eric Blake wrote: > On 08/10/2017 03:01 AM, Fam Zheng wrote: > > People get surprised when, after "qemu-imc create -f raw /dev/sdX", they > > still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 > > header. While this is natural because raw doesn't need to

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-11 Thread Fam Zheng
On Thu, 08/10 12:25, Cornelia Huck wrote: > > I think the UI (giving no consideration to how we might implement > > this!) would ideally be something like: > > * if anybody mails a patch which touches an "unmaintained" file, > >a robot should send a reply along the lines of "thanks for the >

Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

2017-08-11 Thread David Hildenbrand
> /var/tmp/patchew-tester-tmp-05mor12r/src/hw/intc/s390_flic_kvm.c:125:5: > error: no previous prototype for ‘kvm_s390_inject_flic’ > [-Werror=missing-prototypes] > int kvm_s390_inject_flic(struct kvm_s390_irq *irq) > ^~~~ > cc1: all warnings being treated as errors

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-11 Thread David Gibson
On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: > On 9 August 2017 at 08:03, David Gibson wrote: > > The following changes since commit 54affb3a3623b1d36c95e34faa722a5831323a74: > > > > Update version for v2.10.0-rc2 release (2017-08-08 19:07:46

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 09:51, David Gibson wrote: > On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: >> On 9 August 2017 at 08:03, David Gibson wrote: >> > I haven't completed a Travis build for this, which is part of my usual

Re: [Qemu-devel] [PATCH v6 06/19] migration: Add multifd capability

2017-08-11 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:26:16PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH v6 07/19] migration: Create x-multifd-threads parameter

2017-08-11 Thread Peter Xu
On Tue, Aug 08, 2017 at 06:26:17PM +0200, Juan Quintela wrote: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 521e15c..3fe1a64 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -918,6 +918,7 @@ > # > # @return-path: If enabled, migration will use the return path

Re: [Qemu-devel] [PATCH] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Xie Changlong
在 8/10/2017 4:01 PM, Fam Zheng 写道: People get surprised when, after "qemu-imc create -f raw /dev/sdX", they s/qemu-imc/qemu-img/ still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 -- Thanks -Xie

[Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread David Hildenbrand
Let's move everything into internal.h Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 62 - target/s390x/internal.h | 52 + 2 files changed, 52 insertions(+), 62 deletions(-)

Re: [Qemu-devel] [PULL for-2.10 0/3] Block patches

2017-08-11 Thread Peter Maydell
On 10 August 2017 at 18:48, Stefan Hajnoczi wrote: > The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809' > into staging (2017-08-10 11:12:36 +0100) > > are available in

Re: [Qemu-devel] [PATCH] x86: Increase max vcpu number to 352

2017-08-11 Thread Lan Tianyu
On 2017年08月11日 03:22, Radim Krčmář wrote: > 2017-08-10 15:16-0300, Eduardo Habkost: >> On Thu, Aug 10, 2017 at 02:41:03PM +0200, Radim Krčmář wrote: >>> 2017-08-10 19:02+0800, Lan Tianyu: On 2017年08月10日 18:26, Daniel P. Berrange wrote: > On Thu, Aug 10, 2017 at 06:08:07PM +0800, Lan

Re: [Qemu-devel] [PATCH] 9pfs: include for XATTR_SIZE_MAX

2017-08-11 Thread Patrick Steinhardt
On Mon, Jun 26, 2017 at 09:20:45PM +0200, Patrick Steinhardt wrote: > The function `v9fs_xattrcreate` makes use of the define `XATTR_SIZE_MAX` > to reject attempts of creating xattrs with an invalid size, which is > defined in . On glibc-based systems, this header is > indirectly included via , ,

Re: [Qemu-devel] [PATCH for-2.10?] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Fam Zheng
On Fri, 08/11 15:28, Fam Zheng wrote: > On Thu, 08/10 08:58, Eric Blake wrote: > > On 08/10/2017 03:01 AM, Fam Zheng wrote: > > > +if (total_size) { > > > +int64_t zero_size = MIN(BDRV_SECTOR_SIZE, total_size); > > > +uint8_t *buf; > > > > Since BDRV_SECTOR_SIZE is small

[Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can only be used inside target/s390x/. Move everything that isn't fast enough to run away and restructure it right away. Minor style fixes to avoid checkpatch warning to: - struct Lowcore: "{"

Re: [Qemu-devel] [PATCH 1/2] nbd: Drop connection if broken server is detected

2017-08-11 Thread Vladimir Sementsov-Ogievskiy
11.08.2017 05:37, Eric Blake wrote: As soon as the server is sending us garbage, we should quit trying to send further messages to the server, and allow all pending coroutines for any remaining replies to error out. Failure to do so can let a malicious server cause the client to hang, for

[Qemu-devel] [PATCH for-2.11 v2] file-posix: Clear out first sector in hdev_create

2017-08-11 Thread Fam Zheng
People get surprised when, after "qemu-img create -f raw /dev/sdX", they still see qcow2 with "qemu-img info", if previously the bdev had a qcow2 header. While this is natural because raw doesn't need to write any magic bytes during creation, hdev_create is free to clear out the first sector to

Re: [Qemu-devel] [PATCH v2] x86: Increase max vcpu number to 8192

2017-08-11 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1502417472-15511-1-git-send-email-tianyu@intel.com Subject: [Qemu-devel] [PATCH v2] x86: Increase max vcpu

[Qemu-devel] [Update PATCH V2] x86: Increase max vcpu number to 8192

2017-08-11 Thread Lan Tianyu
Intel Xeon phi chip will support 352 logical threads. For HPC usage case, it will create a huge VM with vcpus number as same as host cpus. This patch is to increase max vcpu number from 288 to 8192 which is current default maximum cpu number for Linux kernel. Signed-off-by: Lan Tianyu

Re: [Qemu-devel] [PATCH 2/8] io: introduce a network socket listener API

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 01:12:25PM -0500, Eric Blake wrote: > On 08/10/2017 11:04 AM, Daniel P. Berrange wrote: > > The existing QIOChannelSocket class provides the ability to > > listen on a single socket at a time. This patch introduces > > a QIONetListener class that provides a higher level API

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

2017-08-11 Thread Kevin Wolf
Am 11.08.2017 um 14:04 hat Fam Zheng geschrieben: > On Fri, 08/11 13:07, Christian Ehrhardt wrote: > > Simplifying that to a smaller test: > > > > $ qemu-img create -f qcow2 /tmp/test.qcow2 100M > > $ qemu-system-x86_64 -S -m 512 -smp 1 -nodefaults --nographic -monitor > > stdio -drive > >

Re: [Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

2017-08-11 Thread Kevin Wolf
Am 09.08.2017 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > 185 can sometimes produce wrong output like this: > > = > 185 2s ... - output mismatch (see 185.out.bad) > --- /work/src/qemu/master/tests/qemu-iotests/185.out2017-07-14 \ >

Re: [Qemu-devel] [Update PATCH V2] x86: Increase max vcpu number to 8192

2017-08-11 Thread Eduardo Habkost
On Thu, Aug 10, 2017 at 10:26:06PM -0400, Lan Tianyu wrote: > Intel Xeon phi chip will support 352 logical threads. For HPC > usage case, it will create a huge VM with vcpus number as same as host > cpus. This patch is to increase max vcpu number from 288 to 8192 which > is current default maximum

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > + > +static const char *cc_names[] = { > +[CC_OP_CONST0]= "CC_OP_CONST0", This should get moved out of the header to the c file that uses it. (Why it's ever there in the first place is a mystery...) Otherwise, Reviewed-by: Richard

Re: [Qemu-devel] [PATCH RFC 2/5] target/s390x: move a couple of functions to cpu.c

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.c | 80 + > target/s390x/cpu.h | 88 > +++--- > 2 files changed, 90

Re: [Qemu-devel] [PATCH RFC 5/5] target/s390x: cleanup cpu.h

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > Let's reshuffle the function prototypes so we get a cleaner outline > of the files. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 140 > ++--- > 1 file

Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

2017-08-11 Thread David Hildenbrand
On 11.08.2017 15:15, Richard Henderson wrote: > On 08/11/2017 12:46 AM, David Hildenbrand wrote: >> + >> +static const char *cc_names[] = { >> +[CC_OP_CONST0]= "CC_OP_CONST0", > > This should get moved out of the header to the c file that uses it. > (Why it's ever there in the first place

Re: [Qemu-devel] [PATCH 1/2] loader: Handle ELF files with overlapping zero-initialized data

2017-08-11 Thread Richard Henderson
On 08/07/2017 07:39 AM, Peter Maydell wrote: > For embedded systems, notably ARM, one common use of ELF > file segments is that the 'physical addresses' represent load addresses > and the 'virtual addresses' execution addresses, such that > the load addresses are packed into ROM or flash, and the

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

2017-08-11 Thread Fam Zheng
On Fri, 08/11 14:06, Paolo Bonzini wrote: > On 11/08/2017 09:54, Fam Zheng wrote: > > On Thu, 08/10 12:25, Cornelia Huck wrote: > >>> I think the UI (giving no consideration to how we might implement > >>> this!) would ideally be something like: > >>> * if anybody mails a patch which touches an

Re: [Qemu-devel] [PATCH 2/8] io: introduce a network socket listener API

2017-08-11 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 01:39:43PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Aug 11, 2017 at 01:26:00PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > The existing QIOChannelSocket

[Qemu-devel] [PATCH 1/2] Add manpage for QEMU Backup Tool

2017-08-11 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The following commit is an initial implementation of manpage

[Qemu-devel] [PATCH 0/2] QEMU Backup Tool

2017-08-11 Thread Ishani Chugh
This patch series is intended to introduce QEMU Backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action.

Re: [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > Let's move everything into internal.h > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 62 > - > target/s390x/internal.h | 52

Re: [Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/

2017-08-11 Thread Richard Henderson
On 08/11/2017 12:46 AM, David Hildenbrand wrote: > } > +void s390_enable_css_support(S390CPU *cpu) Spacing. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote: > Currently, at least x86_64 and s390x support building with --disable-tcg. > Instead of forcing tcg (which causes the test to fail on such builds), > allow to use kvm as well. > > Signed-off-by: Cornelia Huck >

Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Cornelia Huck
On Fri, 11 Aug 2017 14:29:53 +0100 "Daniel P. Berrange" wrote: > On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote: > > Currently, at least x86_64 and s390x support building with --disable-tcg. > > Instead of forcing tcg (which causes the test to fail on such

Re: [Qemu-devel] [PATCH 2/2] loader: Ignore zero-sized ELF segments

2017-08-11 Thread Richard Henderson
On 08/07/2017 07:39 AM, Peter Maydell wrote: > Some ELF files have program headers that specify segments that > are of zero size. Ignore them, rather than trying to create > zero-length ROM blobs for them, because the zero-length blob > can falsely trigger the overlapping-ROM-blobs check. > >

[Qemu-devel] [PATCH for-2.10? v2 2/2] file-posix: Do runtime check for ofd lock API

2017-08-11 Thread Fam Zheng
It is reported that on Windows Subsystem for Linux, ofd operations fail with -EINVAL. In other words, QEMU binary built with system headers that exports F_OFD_SETLK doesn't necessarily run in an environment that actually supports it: $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0

Re: [Qemu-devel] [PATCH v3 1/6] seccomp: changing from whitelist to blacklist

2017-08-11 Thread Daniel P. Berrange
On Fri, Aug 11, 2017 at 11:51:12AM +0200, Eduardo Otubo wrote: > On Thu, Aug 03, 2017 at 06:54:15PM +0200, Thomas Huth wrote: > > On 28.07.2017 14:10, Eduardo Otubo wrote: > > > This patch changes the default behavior of the seccomp filter from > > > whitelist to blacklist. By default now all

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-11 Thread Thomas Huth
On 11.08.2017 12:19, Cornelia Huck wrote: > On Fri, 11 Aug 2017 11:49:22 +0200 > Cornelia Huck wrote: > >> On Fri, 11 Aug 2017 07:57:54 +0200 >> Thomas Huth wrote: >> >>> The first patch improves the buffer handling in the pxe tester a >>> little bit by

[Qemu-devel] [PATCH] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Cornelia Huck
Currently, at least x86_64 and s390x support building with --disable-tcg. Instead of forcing tcg (which causes the test to fail on such builds), allow to use kvm as well. Signed-off-by: Cornelia Huck --- Not sure who should merge this. I can add it to the s390 tree if nobody

Re: [Qemu-devel] [PATCH] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Thomas Huth
On 11.08.2017 13:47, Cornelia Huck wrote: > Currently, at least x86_64 and s390x support building with --disable-tcg. > Instead of forcing tcg (which causes the test to fail on such builds), > allow to use kvm as well. > > Signed-off-by: Cornelia Huck > --- > > Not sure who

Re: [Qemu-devel] [PATCH for-2.10? v3 0/2] block: Do OFD lock check at runtime

2017-08-11 Thread Kevin Wolf
Am 11.08.2017 um 13:44 hat Fam Zheng geschrieben: > v3: Fix mingw build. [patchew] > > v2: Probe /dev/null to save LOC. [Eric] > Mention "new glibc + old kernel" in commit message. [Kevin, Daniel, Eric, > Christian] > > This fixes the image opening failure reported by Andrew Baumann: >

Re: [Qemu-devel] [PATCH 2/8] io: introduce a network socket listener API

2017-08-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Aug 11, 2017 at 01:26:00PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > The existing QIOChannelSocket class provides the ability to > > > listen on a single socket at a time. This patch

Re: [Qemu-devel] [PATCH] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Cornelia Huck
On Fri, 11 Aug 2017 13:56:37 +0200 Thomas Huth wrote: > On 11.08.2017 13:47, Cornelia Huck wrote: > > diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c > > index 11f48b049c..38664a0594 100644 > > --- a/tests/boot-serial-test.c > > +++ b/tests/boot-serial-test.c

[Qemu-devel] [PATCH 2/2] backup: QEMU Backup Tool

2017-08-11 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

[Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Cornelia Huck
Currently, at least x86_64 and s390x support building with --disable-tcg. Instead of forcing tcg (which causes the test to fail on such builds), allow to use kvm as well. Signed-off-by: Cornelia Huck --- v1->v2: switch around kvm and tcg Added Paolo on cc:; I can still take

Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Thomas Huth
On 11.08.2017 15:18, Cornelia Huck wrote: > Currently, at least x86_64 and s390x support building with --disable-tcg. > Instead of forcing tcg (which causes the test to fail on such builds), > allow to use kvm as well. > > Signed-off-by: Cornelia Huck > --- > > v1->v2: switch

Re: [Qemu-devel] [PATCH v2] boot-serial-test: fallback to kvm accelerator

2017-08-11 Thread Paolo Bonzini
On 11/08/2017 15:34, Cornelia Huck wrote: > On Fri, 11 Aug 2017 14:29:53 +0100 > "Daniel P. Berrange" wrote: > >> On Fri, Aug 11, 2017 at 03:18:01PM +0200, Cornelia Huck wrote: >>> Currently, at least x86_64 and s390x support building with --disable-tcg. >>> Instead of

[Qemu-devel] big endian arm.

2017-08-11 Thread KONRAD Frederic
Hi Peters, I got some strange results since this commit: commit 9776f636455b6f0d9c14dce112242ed653f954b4 Author: Peter Crosthwaite Date: Fri Mar 4 11:30:21 2016 + arm: boot: Support big-endian elfs Support ARM big-endian ELF files in system-mode

Re: [Qemu-devel] big endian arm.

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 10:59, KONRAD Frederic wrote: > Hi Peters, > > I got some strange results since this commit: > > commit 9776f636455b6f0d9c14dce112242ed653f954b4 > Author: Peter Crosthwaite > Date: Fri Mar 4 11:30:21 2016 + > >

Re: [Qemu-devel] big endian arm.

2017-08-11 Thread Peter Maydell
On 11 August 2017 at 12:03, KONRAD Frederic wrote: > On 08/11/2017 12:18 PM, Peter Maydell wrote: >> That said, if you specify a BE elf file then we do >> set the SCTLR.EE and CPSR.E bits on reset in do_cpu_reset() >> (a change added in the commit you quote), which is

Re: [Qemu-devel] big endian arm.

2017-08-11 Thread Philippe Mathieu-Daudé
Hi Frederic, I'm slowly working on Hercules MCU peripherals and use a R4F core. It seems that when I try to load a big endian image on a Cortex-R5 it gets confused: * the instructions are fine it executes some code. So far no problem here * GDB address / insns are wrong endianness.

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-11 Thread Philippe Mathieu-Daudé
Hi David, Peter, On 08/11/2017 05:59 AM, Peter Maydell wrote: On 11 August 2017 at 09:51, David Gibson wrote: On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: On 9 August 2017 at 08:03, David Gibson wrote: I haven't

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-11 Thread Cornelia Huck
On Fri, 11 Aug 2017 12:52:54 +0200 Thomas Huth wrote: > On 11.08.2017 12:19, Cornelia Huck wrote: > > A quick test on x86_64 with --disable-tcg showed no further problems > > than boot-serial-test, so at least it's only the one for now (and it > > might make sense to simply

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-11 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:54 +0200 Thomas Huth wrote: > The first patch improves the buffer handling in the pxe tester a > little bit by allocating a separate buffer on the heap for each > architecture. This also gets rid of the huge pre-initialized > array in the tester,

Re: [Qemu-devel] [PATCH v3 1/6] seccomp: changing from whitelist to blacklist

2017-08-11 Thread Eduardo Otubo
On Thu, Aug 03, 2017 at 06:54:15PM +0200, Thomas Huth wrote: > On 28.07.2017 14:10, Eduardo Otubo wrote: > > This patch changes the default behavior of the seccomp filter from > > whitelist to blacklist. By default now all system calls are allowed and > > a small black list of definitely forbidden

Re: [Qemu-devel] [PATCH 0/2] QEMU Backup Tool

2017-08-11 Thread Stefan Hajnoczi
On Thu, Aug 10, 2017 at 11:14:33PM +0530, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management

  1   2   3   >