[Qemu-devel] [PULL v4 12/38] tests: Add vm test lib

2017-09-15 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the

Re: [Qemu-devel] [PATCH qemu v2 09/13] memory: Rename mem_begin/mem_commit/mem_add helpers

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 10:40, Alexey Kardashevskiy wrote: > This renames some helper to reflect better what they do. > > This drops AS in address_space_update_flatview() as it is not used anymore > and renames to flatview_render_new(). > > Signed-off-by: Alexey Kardashevskiy > --- >

[Qemu-devel] [PATCH 4/6] block: Base permissions on rw state after reopen

2017-09-15 Thread Kevin Wolf
When new permissions are calculated during bdrv_reopen(), they need to be based on the state of the graph as it will be after the reopen has completed, not on the current state of the involved nodes. This patch makes bdrv_is_writable() optionally accept a BlockReopenQueue from which the new flags

[Qemu-devel] [PATCH 2/6] block: Add reopen_queue to bdrv_child_perm()

2017-09-15 Thread Kevin Wolf
In the context of bdrv_reopen(), we'll have to look at the state of the graph as it will be after the reopen. This interface addition is in preparation for the change. Signed-off-by: Kevin Wolf --- include/block/block_int.h | 7 +++ block.c | 19

Re: [Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib

2017-09-15 Thread Fam Zheng
On Fri, 09/15 12:37, Alex Bennée wrote: > > Fam Zheng writes: > > > This is the common code to implement a "VM test" to > > > > 1) Download and initialize a pre-defined VM that has necessary > > dependencies to build QEMU and SSH access. > > > > 2) Archive $SRC_PATH to a

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > > > On Thu, Sep 14, 2017 at

[Qemu-devel] [PULL v4 15/38] tests: Add NetBSD image

2017-09-15 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski Message-Id: <20170913030119.3957-9-f...@redhat.com> --- tests/vm/netbsd | 42 ++ 1

Re: [Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-09-15 Thread Pavel Butsykin
On 17.08.2017 12:15, Pavel Butsykin wrote: This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image. Image can be fragmented and shrink is done by punching holes in the image file.

Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set

2017-09-15 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson This breaks the mips cross build: In file included from /tmp/qemu-test/src/tcg/tcg.c:254:0: /tmp/qemu-test/src/tcg/mips/tcg-target.inc.c: In function

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 12:40, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > On 15 September 2017 at 10:02, Fam Zheng wrote: > > > The following changes since commit > > > 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > > > tcg/tci: do

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 08:21:53PM +0800, Fam Zheng wrote: > On Fri, 09/15 12:40, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > > On 15 September 2017 at 10:02, Fam Zheng wrote: > > > > The following changes since commit > > > >

Re: [Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-15 Thread Fam Zheng
On Fri, 09/15 14:16, Kevin Wolf wrote: > Am 15.09.2017 um 07:45 hat Fam Zheng geschrieben: > > So it is easier to copy paste the path. > > > > Signed-off-by: Fam Zheng > > I don't think I ever tried to do anything with the diff that would have > required the full path, but if

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 13:31, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 08:21:53PM +0800, Fam Zheng wrote: > > On Fri, 09/15 12:40, Daniel P. Berrange wrote: > > > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > > > On 15 September 2017 at 10:02, Fam Zheng

Re: [Qemu-devel] [PATCH v2 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-15 Thread Farhan Ali
On 09/15/2017 03:40 AM, Thomas Huth wrote: On 14.09.2017 17:55, Farhan Ali wrote: Wire up the virtio-gpu device for the CCW bus. The virtio-gpu is a virtio-1 device, so disable revision 0. Signed-off-by: Farhan Ali Acked-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 1/2] virtio-gpu: Handle endian conversion

2017-09-15 Thread Farhan Ali
On 09/15/2017 03:31 AM, Gerd Hoffmann wrote: Hi, +static void +virtio_gpu_ctrl_hdr_bswap_cpu(struct virtio_gpu_ctrl_hdr *hdr) +{ +hdr->type = le32_to_cpu(hdr->type); +hdr->flags = le32_to_cpu(hdr->flags); +hdr->fence_id = le64_to_cpu(hdr->fence_id); +hdr->ctx_id =

Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()

2017-09-15 Thread Thomas Huth
On 15.09.2017 15:15, Greg Kurz wrote: > It never got used since its introduction (commit 7c43bca004af). > > Signed-off-by: Greg Kurz > --- > target/ppc/kvm.c |5 - > target/ppc/kvm_ppc.h |6 -- > 2 files changed, 11 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 15:09:02 +0200 David Hildenbrand wrote: > On 15.09.2017 15:07, Cornelia Huck wrote: > > On Fri, 15 Sep 2017 13:57:40 +0200 > > David Hildenbrand wrote: > > > >> As an alternative, simply > >> > >> diff --git a/target/s390x/cpu_models.c

[Qemu-devel] [PULL v4 13/38] tests: Add ubuntu.i386 image

2017-09-15 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-7-f...@redhat.com> --- tests/vm/ubuntu.i386 | 88 1 file changed,

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > On Fri, 09/15 16:03, Peter Xu wrote: > > > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > > > > > bdrv_close_all() would abort() due to op

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-15 Thread Dou Liyang
Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used to

[Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen()

2017-09-15 Thread Kevin Wolf
If we switch between read-only and read-write, the permissions that image format drivers need on bs->file change, too. Make sure to update the permissions during bdrv_reopen(). Signed-off-by: Kevin Wolf --- include/block/block.h | 1 + block.c | 64

[Qemu-devel] [PATCH 5/6] block: reopen: Queue children after their parents

2017-09-15 Thread Kevin Wolf
We will calculate the required new permissions in the prepare stage of a reopen. Required permissions of children can be influenced by the changes made to their parents, but parents are independent from their children. This means that permissions need to be calculated top-down. In order to achieve

Re: [Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib

2017-09-15 Thread Alex Bennée
Fam Zheng writes: > This is the common code to implement a "VM test" to > > 1) Download and initialize a pre-defined VM that has necessary > dependencies to build QEMU and SSH access. > > 2) Archive $SRC_PATH to a .tar file. > > 3) Boot the VM, and pass the source tar

[Qemu-devel] [PATCH 4/4] ppc/kvm: generalize the use of kvmppc_get_htab_fd()

2017-09-15 Thread Greg Kurz
The use of KVM_PPC_GET_HTAB_FD is open-coded in kvmppc_read_hptes() and kvmppc_write_hpte(). This patch modifies kvmppc_get_htab_fd() so that it can be used everywhere we need to access the in-kernel htab: - add an index argument => only kvmppc_read_hptes() passes an actual index, all other

[Qemu-devel] [Bug 1679126] Re: null pointer access on migration resume of systemrescuecd boot menu with qxl-vga

2017-09-15 Thread Thomas Huth
The fix has apparently been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a703d3aef5991b72a5a45880e7491232b8032f09 ... and has been released with QEMU v2.9 already. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you

[Qemu-devel] [PATCH RFC 0/1] s390x: pci compat handling

2017-09-15 Thread Cornelia Huck
While playing around with compat machines a bit, I noticed that my zpci detanglement patches broke migration from 2.7 to current master (2.8 or newer are fine, which is why I did not notice that before.) qemu 2.7 seems to create a savevm that a s390-next (or master) build without the s390 phb

Re: [Qemu-devel] [PATCH v7 04/13] tests: Add a test key pair

2017-09-15 Thread Alex Bennée
Fam Zheng writes: > This will be used by setup test user ssh. > > Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée > --- > tests/keys/id_rsa | 27 +++ > tests/keys/id_rsa.pub | 1 + > 2 files changed,

[Qemu-devel] [PATCH 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and amdvi_realize() to the generic

[Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Mohammed Gamal
Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c | 10 +- hw/i386/intel_iommu.c | 10 +- hw/i386/x86-iommu.c | 13

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 11:55, Peter Maydell wrote: > On 15 September 2017 at 10:02, Fam Zheng wrote: > > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > > +0100) > > > > are

Re: [Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-15 Thread Kevin Wolf
Am 15.09.2017 um 07:45 hat Fam Zheng geschrieben: > So it is easier to copy paste the path. > > Signed-off-by: Fam Zheng I don't think I ever tried to do anything with the diff that would have required the full path, but if you say so... :-) Thanks, applied to the block

Re: [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG

2017-09-15 Thread Alex Bennée
David Hildenbrand writes: > On 13.09.2017 18:13, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >>> guest tries to bring these CPUs up but fails), because we don't support >>>

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-15 Thread Nikunj A Dadhania
David Gibson writes: > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> >> >> >> I thought, I am doing the same here for PowerNV, number of online cores >> >> is equal to initial online

Re: [Qemu-devel] [PATCH qemu v2 11/13] memory: Share FlatView's and dispatch trees between address spaces

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 10:40, Alexey Kardashevskiy wrote: > + > +static bool flatview_can_share(FlatView *old_view, FlatView *new_view) > +{ > +MemoryRegion *old_root = memory_region_unalias_entire(old_view->root); > +MemoryRegion *new_root = memory_region_unalias_entire(new_view->root); > + > +

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-15 Thread Pavel Butsykin
On 17.07.2017 16:56, Pavel Butsykin wrote: On 07.07.2017 17:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that

Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
(oups, forgot the v2 on Subject) On Fri, Sep 15, 2017 at 11:06:43AM +0200, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma:

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-15 Thread Mohammed Gamal
On Fri, 2017-09-15 at 10:07 +0800, Peter Xu wrote: > On Thu, Sep 14, 2017 at 05:31:38PM -0300, Eduardo Habkost wrote: > > On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > > > On 14.09.2017 22:18, Mohammed Gamal wrote: > > > > Starting the following command line causes a segfault > >

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 11:06, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. >

[Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made registering the s390 pci host bridge conditional on presense of the zpci facility bit. Sadly, that breaks migration from some old machines. Create the s390 phb if we need it for compat reasons, even if we don't provide the zpci

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Marc-André Lureau
Hi On Thu, Sep 14, 2017 at 9:46 PM, Peter Xu wrote: > On Thu, Sep 14, 2017 at 07:53:15PM +0100, Dr. David Alan Gilbert wrote: >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> > Hi >> > >> > On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: >> >

[Qemu-devel] [PATCH 2/2] x86_iommu: check if machine has PCI bus

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 14, 2017 at 01:15:09PM +0200, Marc-André Lureau wrote: > > > > There should be a limit

Re: [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration

2017-09-15 Thread Mark Cave-Ayland
On 14/09/17 04:52, David Gibson wrote: > On Wed, Sep 13, 2017 at 07:58:23PM +0200, Laurent Vivier wrote: >> On 13/09/2017 19:11, Mark Cave-Ayland wrote: >>> On 13/09/17 08:12, David Gibson wrote: >>> This is subtly incorrect. It sets the DECR on load to exactly the value that was

Re: [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code

2017-09-15 Thread Lluís Vilanova
Richard Henderson writes: > On 09/14/2017 08:20 AM, Lluís Vilanova wrote: >> Richard Henderson writes: >> >>> On 09/10/2017 09:27 AM, Lluís Vilanova wrote: TCG BBLs and instructions have multiple exit points from where to raise tracing events, but some of the necessary information in

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:07, Cornelia Huck wrote: > On Fri, 15 Sep 2017 13:57:40 +0200 > David Hildenbrand wrote: > >> As an alternative, simply >> >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c >> index 0f28ebd162..0f22efc3b6 100644 >> ---

[Qemu-devel] [PULL v4 16/38] tests: Add OpenBSD image

2017-09-15 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-10-f...@redhat.com> --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create

Re: [Qemu-devel] [PATCH qemu v2 00/13] memory: Reduce memory use

2017-09-15 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH qemu v2 00/13] memory: Reduce memory use Message-id: 20170915084030.40988-1-...@ozlabs.ru Type:

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > On 15 September 2017 at 10:02, Fam Zheng wrote: > > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > >

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 12:14, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > registering the s390 pci host bridge conditional on presense > of the zpci facility bit. Sadly, that breaks migration from > some old machines. > > Create the s390 phb if we need it for

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:03:54PM +0100, Peter Maydell wrote: > On 15 September 2017 at 12:40, Daniel P. Berrange wrote: > > IIUC, the public part of the key gets exposed to the guest images via > > cloud-init metadata. During boot the guest read this metadata and add > >

Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by switching to ccw/aliases

2017-09-15 Thread Kevin Wolf
Am 13.09.2017 um 11:10 hat Cornelia Huck geschrieben: > Recent changes in s390x made pci support dependant on the zpci cpu > feature, which is not provided on all models (and not on by default). > This means we cannot instatiate pci devices on a standard qemu > invocation for s390x. Moreover, the

Re: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

2017-09-15 Thread Kevin Wolf
Am 13.09.2017 um 18:44 hat Adam Wolfe Gordon geschrieben: > Register a watcher with rbd so that we get notified when an image is > resized. Propagate resizes to parent block devices so that guest devices > get resized without user intervention. > > Signed-off-by: Adam Wolfe Gordon

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand wrote: > As an alternative, simply > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 0f28ebd162..0f22efc3b6 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -195,6

[Qemu-devel] [PATCH 3/4] ppc/kvm: change kvmppc_get_htab_fd() to return -errno on error

2017-09-15 Thread Greg Kurz
When kvmppc_get_htab_fd() fails, its return value is propagated up to qemu_savevm_state_iterate() or to qemu_savevm_state_complete_precopy(). All savevm handlers expect to receive a negative errno on error. Let's patch kvmppc_get_htab_fd() accordingly. While here, let's change htab_load() in the

[Qemu-devel] [PATCH 2/4] spapr: introduce helpers to migrate HPT chunks and the end marker

2017-09-15 Thread Greg Kurz
This consolidates some duplicated code in a single helper. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index f680f28a15ea..841117f6d185

[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed. Aborted (core dumped) The 40p machine type already

[Qemu-devel] [PULL v4 18/38] MAINTAINERS: Add tests/vm entry

2017-09-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-Id: <20170913030119.3957-12-f...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..42f5454311 100644 --- a/MAINTAINERS

[Qemu-devel] [PULL v4 10/38] scripts: Add archive-source.sh

2017-09-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-4-f...@redhat.com> --- scripts/archive-source.sh | 33 + 1 file changed, 33 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh

Re: [Qemu-devel] [PATCH qemu v2 04/13] memory: Move FlatView allocation to a helper

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 10:40, Alexey Kardashevskiy wrote: > -static void flatview_init(FlatView *view) > +static FlatView *flatview_alloc(void) > { > +FlatView *view; > + > +view = g_new0(FlatView, 1); > view->ref = 1; > -view->ranges = NULL; > -view->nr = 0; > -view->nr_allocated

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Stefan Hajnoczi
On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > > On Thu, Sep 14, 2017 at 01:15:09PM +0200, Marc-André Lureau wrote: > > > There should be a limit in the number of requests the thread can > > > queue. Before the patch,

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread Auger Eric
Hi Tomasz, On 15/09/2017 12:42, tn wrote: > Hi Eric, > > On 15.09.2017 09:30, Auger Eric wrote: >> Hi Tomasz, >> >> On 14/09/2017 16:43, Tomasz Nowicki wrote: >>> On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: > Hi Eric, > >

[Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/test-and-build-pull-request for you to fetch changes up to

[Qemu-devel] [PULL v4 20/38] docker: Use archive-source.py

2017-09-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-14-f...@redhat.com> --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include

[Qemu-devel] [PULL v4 19/38] tests: Add README for vm tests

2017-09-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-13-f...@redhat.com> --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README

[Qemu-devel] [PATCH 3/6] block: Add reopen queue to bdrv_check_perm()

2017-09-15 Thread Kevin Wolf
In the context of bdrv_reopen(), we'll have to look at the state of the graph as it will be after the reopen. This interface addition is in preparation for the change. Signed-off-by: Kevin Wolf --- block.c | 34 +++--- 1 file changed, 19

[Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions before each command

2017-09-15 Thread Kevin Wolf
qemu-io provides a 'reopen' command that allows switching from writable to read-only access. We need to make sure that we don't try to keep write permissions to a BlockBackend that becomes read-only, otherwise things are going to fail. command() already makes sure to request any additional

[Qemu-devel] [PATCH 0/6] block: Fix permissions after ro/rw reopen

2017-09-15 Thread Kevin Wolf
bdrv_reopen() can switch nodes between read-only and read-write modes. This has implications for the required permissions on their child nodes. For example, a qcow2 node requests write permissions on bs->file only if it is writable itself. This means that during bdrv_reopen(), the permissions

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
On Fri, Sep 15, 2017 at 12:18:11PM +0200, Paolo Bonzini wrote: > On 15/09/2017 11:06, Eduardo Otubo wrote: > > QEMU fails when used with the following command line: > > > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > qemu-system-ppc64: hw/isa/isa-bus.c:110:

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > > On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > > > > On Thu, Sep 14, 2017 at 01:15:09PM

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > > > On Fri, Sep 15, 2017 at 11:50:57AM +0800,

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 11:49:26AM

[Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()

2017-09-15 Thread Greg Kurz
It never got used since its introduction (commit 7c43bca004af). Signed-off-by: Greg Kurz --- target/ppc/kvm.c |5 - target/ppc/kvm_ppc.h |6 -- 2 files changed, 11 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 1deaf106d2b9..00d7029b8d7a

[Qemu-devel] [PATCH 0/4] ppc/kvm: htab fd code improvements

2017-09-15 Thread Greg Kurz
This series drops unused code and consolidates some duplicated code that deals with KVM's htab fd feature. It also fixes some potential bugs. -- Greg --- Greg Kurz (4): ppc/kvm: drop kvmppc_has_cap_htab_fd() spapr: introduce helpers to migrate HPT chunks and the end marker

[Qemu-devel] [PULL v4 17/38] Makefile: Add rules to run vm tests

2017-09-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-11-f...@redhat.com> --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 10:02, Fam Zheng wrote: > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 12:40, Daniel P. Berrange wrote: > IIUC, the public part of the key gets exposed to the guest images via > cloud-init metadata. During boot the guest read this metadata and add > the public key to authorized_keys. The private key is used by the test >

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-09-15 Thread Lluís Vilanova
Peter Maydell writes: > On 13 September 2017 at 10:57, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> MAINTAINERS |6 ++ >> docs/instrument.txt | 173 >> +++ >> 2 files

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Philippe Mathieu-Daudé
Hi Daniel, On 09/15/2017 08:40 AM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: [...] So, before I commit an ssh private key to our git repo, can you explain why it's ok that this is public? The commit message for the relevant patch doesn't really

Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-09-15 Thread Gerhard Wiesinger
On 27.08.2017 20:55, Paolo Bonzini wrote: Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" > ha scritto: On 27.08.2017 14 :03, Paolo Bonzini wrote: We will revert the patch, but 4.13.0 will not have the fix.

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 01:06:44PM +0100,

Re: [Qemu-devel] [PATCH for-2.11 v3 10/16] travis: check ./configure outcome, dump config.log on failure

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > also de-duplicate 'before_script' > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .travis.yml | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute":

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 03:29:46PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 01:06:44PM

Re: [Qemu-devel] [PATCH v7 12/13] tests: Add README for vm tests

2017-09-15 Thread Fam Zheng
On Fri, 09/15 15:24, Alex Bennée wrote: > > Fam Zheng writes: > > > Signed-off-by: Fam Zheng > > --- > > tests/vm/README | 63 > > + > > 1 file changed, 63 insertions(+) > > create mode 100644

Re: [Qemu-devel] [PATCH v2 0/5] generalize parsing of cpu_model (x86/arm)

2017-09-15 Thread Igor Mammedov
On Wed, 13 Sep 2017 18:04:52 +0200 Igor Mammedov wrote: > Changelog since v1: > * fix merge conflicts with ignore_memory_transaction_failures > * fix couple merge conflicts where SoC type string where replaced by type > macro > * keep plain prefix string in:

Re: [Qemu-devel] [PATCH for-2.11 v3 08/16] travis: reorder matrix to speedup failure

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .travis.yml | 36 +++- > 1 file changed, 19 insertions(+), 17 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

2017-09-15 Thread Halil Pasic
On 09/11/2017 03:12 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

Re: [Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:13:45PM +0200, Mohammed Gamal wrote: > Instead of having the same error checks in vtd_realize() > and amdvi_realize(), move that over to the generic > x86_iommu_realize(). > > Signed-off-by: Mohammed Gamal > --- > hw/i386/amd_iommu.c | 10

[Qemu-devel] [Bug 1717414] [NEW] Sending certain keysyms results in wrong symbol input

2017-09-15 Thread Iordan Iordanov
Public bug reported: I develop bVNC, an Android VNC client. I noticed that when I connect to qemu VMs that have a VNC console, Keysyms that are usually sent over with SHIFT modifier when connecting from a PC have wrong symbols typed within the VM. A very short list of examples: exclam

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2017-09-15 Thread Thomas Huth
The patch that has been mentioned in the last comment has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=31e6a7b17b35711eb44f0e ... and has been released with QEMU v2.8 already, so marking this as "fix released" now. ** Changed in: qemu Status: New => Fix Released --

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread Auger Eric
Hi, On 15/09/2017 12:42, tn wrote: > Hi Eric, > > On 15.09.2017 09:30, Auger Eric wrote: >> Hi Tomasz, >> >> On 14/09/2017 16:43, Tomasz Nowicki wrote: >>> On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: > Hi Eric, > > On

[Qemu-devel] [PATCH v2 2/2] x86_iommu: check if machine has PCI bus

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not

[Qemu-devel] [PATCH v2 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and amdvi_realize() to the generic

[Qemu-devel] [PATCH v2 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Mohammed Gamal
Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c | 10 +- hw/i386/intel_iommu.c | 10 +- hw/i386/x86-iommu.c | 13

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Sep 13, 2017 at 01:15:32PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On Thu,

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread tn
Hi Eric, On 15.09.2017 09:30, Auger Eric wrote: Hi Tomasz, On 14/09/2017 16:43, Tomasz Nowicki wrote: On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote:

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-15 Thread Lluís Vilanova
Peter Maydell writes: > On 12 September 2017 at 22:01, Lluís Vilanova wrote: >> This series adds an API to add instrumentation events. >> >> It also provides additional APIs for: >> * Controlling tracing events. >> * Peek/poke guest memory. >> Future APIs (for later

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 14:45, Lluís Vilanova wrote: > Do you have an opinion on specific trace points, or an observation in general? > > I wanted to have the following events: > > * cpu hotplug/hotunplug > * cpu reset > * memory access translation/execution > * BBL/TB

Re: [Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 09:52:23PM +0800, Peter Xu wrote: > On Fri, Sep 15, 2017 at 01:13:45PM +0200, Mohammed Gamal wrote: > > Instead of having the same error checks in vtd_realize() > > and amdvi_realize(), move that over to the generic > > x86_iommu_realize(). > > > > Signed-off-by: Mohammed

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-09-15 Thread Thomas Huth
On 29.03.2017 16:25, Christian Borntraeger wrote: > On 03/29/2017 04:21 PM, Thomas Huth wrote: >> On 24.03.2017 10:39, Christian Borntraeger wrote: >>> On 03/24/2017 10:26 AM, Thomas Huth wrote: When running QEMU with KVM under z/VM, the memory for the guest is allocated via

  1   2   3   4   >