Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs

2017-09-21 Thread Alistair Francis
On Mon, Sep 11, 2017 at 4:56 AM, KONRAD Frederic wrote: > > > On 09/06/2017 02:12 AM, Alistair Francis wrote: >> >> Signed-off-by: Alistair Francis >> --- >> >> hw/arm/netduino2.c | 5 + >> 1 file changed, 5 insertions(+) >> >>

[Qemu-devel] [PULL 00/18] Migration PULL request

2017-09-21 Thread Juan Quintela
ff5667ed53c544c4dc88dcd7cb23cc509c9a55e0: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-09-21 10:56:09 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170921 for you to fetch changes up

Re: [Qemu-devel] [RFC v1 1/2] machine: Add a valid_cpu_types property

2017-09-21 Thread Alistair Francis
On Sat, Sep 9, 2017 at 1:16 PM, Eduardo Habkost wrote: > On Tue, Sep 05, 2017 at 05:12:01PM -0700, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> >> hw/core/machine.c | 27 +++ >>

[Qemu-devel] [PULL 02/18] migration: Teach it about G_SOURCE_REMOVE

2017-09-21 Thread Juan Quintela
As this is defined on glib 2.32, add compatibility macros for older glibs. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange Reviewed-by: Peter Xu --- include/glib-compat.h | 2 ++ migration/exec.c | 2 +-

[Qemu-devel] [PULL 10/32] memory: Remove AddressSpace pointer from AddressSpaceDispatch

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy AS in ASD is only used to pass AS from mem_begin() to register_subpage() to store it in MemoryRegionSection, we can do this directly now. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy Message-Id:

[Qemu-devel] [PULL 12/18] bitmap: provide to_le/from_le helpers

2017-09-21 Thread Juan Quintela
From: Peter Xu Provide helpers to convert bitmaps to little endian format. It can be used when we want to send one bitmap via network to some other hosts. One thing to mention is that, these helpers only solve the problem of endianess, but it does not solve the problem of

[Qemu-devel] [PULL 05/32] memory: avoid "resurrection" of dead FlatViews

2017-09-21 Thread Paolo Bonzini
It's possible for address_space_get_flatview() as it currently stands to cause a use-after-free for the returned FlatView, if the reference count is incremented after the FlatView has been replaced by a writer: thread 1 thread 2 RCU thread

[Qemu-devel] [PULL 28/32] scsi: add persistent reservation manager using qemu-pr-helper

2017-09-21 Thread Paolo Bonzini
This adds a concrete subclass of pr-manager that talks to qemu-pr-helper. Signed-off-by: Paolo Bonzini --- scsi/Makefile.objs | 2 +- scsi/pr-manager-helper.c | 302 +++ 2 files changed, 303 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 32/32] chardev: remove context in chr_update_read_handler

2017-09-21 Thread Paolo Bonzini
From: Peter Xu We had a per-chardev cache for context, then we don't need this parameter to be passed in every time when chr_update_read_handler() called. As long as we are calling chr_update_read_handler() using qemu_chr_be_update_read_handlers() we'll be fine.

Re: [Qemu-devel] [PATCH 1/1] s390x/ais: for 2.10 stable: disable ais facility

2017-09-21 Thread Michael Roth
Quoting Michael Roth (2017-09-21 11:50:28) > Quoting Cornelia Huck (2017-09-21 10:21:42) > > On Thu, 21 Sep 2017 17:14:46 +0200 > > Christian Borntraeger wrote: > > > > > The migration interface for ais was introduced with kernel 4.13 > > > but the capability itself had

[Qemu-devel] [PULL 01/18] migration: Create migration_ioc_process_incoming()

2017-09-21 Thread Juan Quintela
We pass the ioc instead of the fd. This will allow us to have more than one channel open. We also make sure that we set the from_src_file sooner, so we don't need to pass it as a parameter. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange

[Qemu-devel] [PULL 08/18] migration: Create multifd migration threads

2017-09-21 Thread Juan Quintela
Creation of the threads, nothing inside yet. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- Use pointers instead of long array names Move to use semaphores instead of conditions as paolo suggestion Put all the state inside one

[Qemu-devel] [PULL 03/18] migration: Add comments to channel functions

2017-09-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange --- migration/channel.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/channel.c b/migration/channel.c index edceebdb7b..70ec7ea3b7 100644 ---

[Qemu-devel] [PULL 02/32] kvm: drop wrong assertion creating problems with pflash

2017-09-21 Thread Paolo Bonzini
From: David Hildenbrand pflash toggles mr->romd_mode. So this assert does not always hold. 1) a device was added with !mr->romd_mode, therefore effectively not creating a kvm slot as we want to trap every access (add = false). 2) mr->romd_mode was toggled on before remove

[Qemu-devel] [PULL 11/32] memory: Switch memory from using AddressSpace to FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy FlatView's will be shared between AddressSpace's and subpage_t and MemoryRegionSection cannot store AS anymore, hence this change. In particular, for: typedef struct subpage_t { MemoryRegion iomem; -AddressSpace *as; +FlatView *fv;

[Qemu-devel] [PULL 07/32] memory: Open code FlatView rendering

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy We are going to share FlatView's between AddressSpace's and per-AS memory listeners won't suit the purpose anymore so open code the dispatch tree rendering. Since there is a good chance that dispatch_listener was the only listener, this avoids

[Qemu-devel] [PULL 12/32] memory: Cleanup after switching to FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy We store AddressSpaceDispatch* in FlatView anyway so there is no need to carry it from mem_add() to register_subpage/register_multipage. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy Message-Id:

Re: [Qemu-devel] [PULL 00/18] Migration PULL request

2017-09-21 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PULL 00/18] Migration PULL request Type: series Message-id: 20170921230812.7095-1-quint...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git

[Qemu-devel] [PULL 08/32] memory: Move FlatView allocation to a helper

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This moves a FlatView allocation and initialization to a helper. While we are nere, replace g_new with g_new0 to not to bother if we add new fields in the future. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy

[Qemu-devel] [PULL 30/32] chardev: add Chardev.gcontext field

2017-09-21 Thread Paolo Bonzini
From: Peter Xu It caches the gcontext that is used to poll the chardev IO. Before this patch, we only passed it in via chr_update_read_handlers(). However that may not be enough if the char backend is disconnected and reconnected afterward. There are chardev codes that

[Qemu-devel] [PULL 26/32] scsi: build qemu-pr-helper

2017-09-21 Thread Paolo Bonzini
Introduce a privileged helper to run persistent reservation commands. This lets virtual machines send persistent reservations without using CAP_SYS_RAWIO or out-of-tree patches. The helper uses Unix permissions and SCM_RIGHTS to restrict access to processes that can access its socket and prove

Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-21 Thread Stefano Stabellini
On Thu, 21 Sep 2017, Jan Beulich wrote: > >>> On 21.09.17 at 03:12, wrote: > > On Fri, 1 Sep 2017, Jan Beulich wrote: > >> --- a/hw/xen/xen_pt_msi.c > >> +++ b/hw/xen/xen_pt_msi.c > >> @@ -18,6 +18,11 @@ > >> > >> #define XEN_PT_AUTO_ASSIGN -1 > >> > >> +#ifndef

[Qemu-devel] [PULL 10/18] bitmap: remove BITOP_WORD()

2017-09-21 Thread Juan Quintela
From: Peter Xu We have BIT_WORD(). It's the same. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- util/bitops.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 07/18] migration: Create x-multifd-page-count parameter

2017-09-21 Thread Juan Quintela
Indicates how many pages we are going to send in each batch to a multifd thread. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Be consistent with defaults and documentation Use new

[Qemu-devel] [PULL 18/32] memory: Do not allocate FlatView in address_space_init

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This creates a new AS object without any FlatView as memory_region_transaction_commit() may want to reuse the empty FV. Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-14-...@ozlabs.ru> Signed-off-by: Paolo

[Qemu-devel] [PULL 21/32] memory: Create FlatView directly

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This avoids usual memory_region_transaction_commit() which rebuilds all FVs. On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings down the boot time from 25s to 20s and reduces the amount of temporary FVs allocated during machine

[Qemu-devel] [PULL 27/32] scsi: add multipath support to qemu-pr-helper

2017-09-21 Thread Paolo Bonzini
Proper support of persistent reservation for multipath devices requires communication with the multipath daemon, so that the reservation is registered and applied when a path comes up. The device mapper utilities provide a library to do so; this patch makes qemu-pr-helper.c detect multipath

[Qemu-devel] [PULL 09/32] memory: Move AddressSpaceDispatch from AddressSpace to FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy As we are going to share FlatView's between AddressSpace's, and AddressSpaceDispatch is a structure to perform quick lookup in FlatView, this moves ASD to FlatView. After previosly open coded ASD rendering, we can also remove as->next_dispatch as the

[Qemu-devel] [PULL 29/32] chardev: new qemu_chr_be_update_read_handlers()

2017-09-21 Thread Paolo Bonzini
From: Peter Xu Add a wrapper for the chr_update_read_handler(). Signed-off-by: Peter Xu Message-Id: <1505975754-21555-2-git-send-email-pet...@redhat.com> Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 24/32] memory: Share special empty FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This shares an cached empty FlatView among address spaces. The empty FV is used every time when a root MR renders into a FV without memory sections which happens when MR or its children are not enabled or zero-sized. The empty_view is not NULL to keep

[Qemu-devel] [RFC v2 1/2] machine: Add a valid_cpu_types property

2017-09-21 Thread Alistair Francis
Signed-off-by: Alistair Francis --- RFC v2: - Rebase on Igor's cpu_type work - Use object_class_dynamic_cast() - Use a NULL terminated cahr** list - Do the check before the machine_class init() is called hw/core/machine.c | 35

[Qemu-devel] [PATCH v1] s390x/kvm: fix and cleanup storing CPU status

2017-09-21 Thread David Hildenbrand
env->psa is a 64bit value, while we copy 4 bytes into the save area, resulting always in 0 getting stored. Let's try to reduce such errors by using a proper structure. While at it, use correct cpu->be conversion (and get_psw_mask()), as we will be reusing this code for TCG soon. Signed-off-by:

Re: [Qemu-devel] [PATCH qemu v5 16/18] memory: Get rid of address_space_init_shareable

2017-09-21 Thread Paolo Bonzini
On 21/09/2017 10:51, Alexey Kardashevskiy wrote: > Since FlatViews are shared now and ASes not, this gets rid of > address_space_init_shareable(). > > This should cause no behavioural change. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v3: > * now removes

[Qemu-devel] [PULL 00/32] Misc changes for 2017-09-22

2017-09-21 Thread Paolo Bonzini
The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-09-20 20:33:48 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL 15/18] migration: split common postcopy out of ram postcopy

2017-09-21 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy Split common postcopy staff from ram postcopy staff. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

[Qemu-devel] [PULL 13/18] migration: add has_postcopy savevm handler

2017-09-21 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy Now postcopy-able states are recognized by not NULL save_live_complete_postcopy handler. But when we have several different postcopy-able states, it is not convenient. Ram postcopy may be disabled, while some other postcopy enabled, in

[Qemu-devel] [PULL 09/18] migration: Split migration_fd_process_incoming

2017-09-21 Thread Juan Quintela
We need that on later patches. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Daniel P. Berrange --- migration/migration.c | 14 -- 1 file

[Qemu-devel] [PULL 14/32] memory: Store physical root MR in FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy Address spaces get to keep a root MR (alias or not) but FlatView stores the actual MR as this is going to be used later on to decide whether to share a particular FlatView or not. Signed-off-by: Alexey Kardashevskiy Message-Id:

[Qemu-devel] [PULL 16/32] memory: Move address_space_update_ioeventfds

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy So it is called (twice) from the same function. This is to make the next patches a bit simpler. Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-12-...@ozlabs.ru> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 04/18] migration: Create migration_has_all_channels

2017-09-21 Thread Juan Quintela
This function allows us to decide when to close the listener socket. For now, we only need one connection. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrange --- migration/migration.c | 11 +++ migration/migration.h | 2 ++

[Qemu-devel] [PULL 16/18] migration: pass MigrationIncomingState* into migration check functions

2017-09-21 Thread Juan Quintela
From: Alexey Perevalov That tiny refactoring is necessary to be able to set UFFD_FEATURE_THREAD_ID while requesting features, and then to create downtime context in case when kernel supports it. Signed-off-by: Alexey Perevalov Reviewed-by: Juan

[Qemu-devel] [PULL 11/18] bitmap: introduce bitmap_count_one()

2017-09-21 Thread Juan Quintela
From: Peter Xu Count how many bits set in the bitmap. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela ---

[Qemu-devel] [PULL 06/32] exec: Explicitly export target AS from address_space_translate_internal

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This adds an AS** parameter to address_space_do_translate() to make it easier for the next patch to share FlatViews. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy Message-Id:

[Qemu-devel] [PULL 01/32] virtio-serial: add enable_backend callback

2017-09-21 Thread Paolo Bonzini
From: Pavel Butsykin We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on source side will not be modified as

[Qemu-devel] [PULL 31/32] chardev: use per-dev context for io_add_watch_poll

2017-09-21 Thread Paolo Bonzini
From: Peter Xu It was only passed in by chr_update_read_handlers(). However when reconnect, we'll lose that context information. So if a chardev was running on another context (rather than the default context, the NULL pointer), it'll switch back to the default context if

[Qemu-devel] [PULL 15/32] memory: Alloc dispatch tree where topology is generared

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This is to make next patches simpler. Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-11-...@ozlabs.ru> Signed-off-by: Paolo Bonzini --- memory.c | 18 +- 1 file changed, 9

[Qemu-devel] [PULL 05/18] migration: Add multifd capability

2017-09-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Reviewed-by: Daniel P. Berrange -- Use new DEFINE_PROP --- migration/migration.c | 10 ++ migration/migration.h |

[Qemu-devel] [PULL 18/18] migration: split ufd_version_check onto receive/request features part

2017-09-21 Thread Juan Quintela
From: Alexey Perevalov This modification is necessary for userfault fd features which are required to be requested from userspace. UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will be introduced in the next patch. QEMU have to use separate

[Qemu-devel] [PULL 14/18] migration: fix ram_save_pending

2017-09-21 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy Fill postcopy-able pending only if ram postcopy is enabled. It is necessary because of there will be other postcopy-able states and when ram postcopy is disabled, it should not spoil common postcopy related pending. Signed-off-by:

[Qemu-devel] [PULL 17/32] memory: Share FlatView's and dispatch trees between address spaces

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This allows sharing flat views between address spaces (AS) when the same root memory region is used when creating a new address space. This is done by walking through all ASes and caching one FlatView per a physical root MR (i.e. not aliased). This

[Qemu-devel] [PULL 03/32] memory: avoid a name clash with access macro

2017-09-21 Thread Paolo Bonzini
From: KONRAD Frederic This avoids a name clash with the access macro on windows 64: make CHK version_gen.h CC aarch64-softmmu/memory.o /home/konrad/qemu/memory.c: In function 'access_with_adjusted_size': /home/konrad/qemu/memory.c:591:73: error: macro

[Qemu-devel] [PULL 19/32] memory: Rework "info mtree" to print flat views and dispatch trees

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This adds a new "-d" switch to "info mtree" to print dispatch tree internals. This changes the way "-f" is handled - it prints now flat views and associated address spaces. Signed-off-by: Alexey Kardashevskiy Message-Id:

[Qemu-devel] [RFC v2 2/2] netduino2: Specify the valid CPUs

2017-09-21 Thread Alistair Francis
Signed-off-by: Alistair Francis --- RFC v2: - Use a NULL terminated list - Add the Cortex-M4 for testing hw/arm/netduino2.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c index

[Qemu-devel] [RFC v2 0/2] Add a valid_cpu_types property

2017-09-21 Thread Alistair Francis
There are numorous QEMU machines that only have a single or a handful of valid CPU options. To simplyfy the management of specificying which CPU is/isn't valid let's create a property that can be set in the machine init. We can then check to see if the user supplied CPU is in that list or not.

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

2017-09-21 Thread Stefan Weil
Am 22.09.2017 um 05:06 schrieb Thomas Huth: > If QEMU has been compiled with the flags --enable-tcg-interpreter and > --enable-debug, the guest is running incredibly slow. The pxe boot test > can take up to 400 seconds when testing the pseries ppc64 machine. While > we should still look for ways

Re: [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image

2017-09-21 Thread Fam Zheng
On Fri, 09/22 00:17, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 09/21/2017 12:07 PM, Fam Zheng wrote: > > The image is prepared following instructions as in: > > > > https://wiki.qemu.org/Hosts/BSD > > > > Signed-off-by: Fam Zheng > > --- > > tests/vm/freebsd | 42

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"

2017-09-21 Thread Fam Zheng
On Thu, 09/21 14:02, Eduardo Habkost wrote: > The subsystem name for the "Build test automation" section is > "-", because an actual subsystem name > line is missing: > > $ ./scripts/get_maintainer.pl -f tests/docker/docker.py > "Alex Bennée"

Re: [Qemu-devel] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Fam Zheng
On Thu, 09/21 18:39, Manos Pitsidianakis wrote: > On Thu, Sep 21, 2017 at 09:29:43PM +0800, Fam Zheng wrote: > > On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > > > BlockDriverState has a bdrv_do_drain() callback but no equivalent for the > > > end > > > > s/bdrv_do_drain/bdrv_co_drain/ > > >

Re: [Qemu-devel] [PATCH 2/3] memory: seek FlatView sharing candidates among children subregions

2017-09-21 Thread Alexey Kardashevskiy
On 21/09/17 23:57, Paolo Bonzini wrote: > On 21/09/2017 15:39, Alexey Kardashevskiy wrote: >> On 21/09/17 22:07, Paolo Bonzini wrote: >>> A container can be used instead of an alias to allow switching between >>> multiple subregions. In this case we cannot directly share the >>> subregions (since

Re: [Qemu-devel] [PATCH v2] docs/devel/loads-stores.rst: Document our various load and store APIs

2017-09-21 Thread Peter Maydell
On 21 September 2017 at 20:17, Eric Blake wrote: > On 09/21/2017 12:29 PM, Peter Maydell wrote: >> QEMU has a wide selection of different functions for doing >> loads and stores; provide some overview documentation of >> what they do and how to pick which one to use. >> >>

[Qemu-devel] [PULL 06/18] migration: Create x-multifd-channels parameter

2017-09-21 Thread Juan Quintela
Indicates the number of channels that we will create. By default we create 2 channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Catch inconsistent defaults (eric). Improve comment

[Qemu-devel] [PULL 17/18] migration: fix hardcoded function name in error report

2017-09-21 Thread Juan Quintela
From: Alexey Perevalov Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Signed-off-by: Juan Quintela --- migration/postcopy-ram.c |

[Qemu-devel] [PULL 04/32] atomic: update documentation

2017-09-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/atomics.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/devel/atomics.txt b/docs/devel/atomics.txt index 3ef5d85..048e5f2 100644 --- a/docs/devel/atomics.txt +++ b/docs/devel/atomics.txt

[Qemu-devel] [PULL 20/32] memory: Get rid of address_space_init_shareable

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy Since FlatViews are shared now and ASes not, this gets rid of address_space_init_shareable(). This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-17-...@ozlabs.ru>

[Qemu-devel] [PULL 23/32] memory: seek FlatView sharing candidates among children subregions

2017-09-21 Thread Paolo Bonzini
A container can be used instead of an alias to allow switching between multiple subregions. In this case we cannot directly share the subregions (since they only belong to a single parent), but if the subregions are aliases we can in turn walk those. This is not enough to remove all source of

[Qemu-devel] [PULL 25/32] scsi, file-posix: add support for persistent reservation management

2017-09-21 Thread Paolo Bonzini
It is a common requirement for virtual machine to send persistent reservations, but this currently requires either running QEMU with CAP_SYS_RAWIO, or using out-of-tree patches that let an unprivileged QEMU bypass Linux's filter on SG_IO commands. As an alternative mechanism, the next patches

[Qemu-devel] [PULL 13/32] memory: Rename mem_begin/mem_commit/mem_add helpers

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This renames some helpers to reflect better what they do. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy Message-Id: <20170921085110.25598-9-...@ozlabs.ru> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 22/32] memory: trace FlatView creation and destruction

2017-09-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 1 - include/qemu/typedefs.h | 1 + memory.c| 3 +++ trace-events| 3 +++ 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

[Qemu-devel] [PATCH] s390x: use generic cpu_model parsing

2017-09-21 Thread Igor Mammedov
define default CPU type in generic way in machine class_init and let common machine code to handle cpu_model parsing. Signed-off-by: Igor Mammedov --- tested under TCG booting debian kernel, and compile tested on s390 host CC: Cornelia Huck CC: Christian

Re: [Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream

2017-09-21 Thread Cornelia Huck
On Thu, 21 Sep 2017 13:22:44 +0200 Halil Pasic wrote: > On 09/21/2017 11:15 AM, Cornelia Huck wrote: > >> +static inline CcwDataStream *get_cds(Terminal3270 *t) > >> +{ > >> +return &(CCW_DEVICE(>cdev)->sch->cds); > >> +} > >> + > >> +static int

Re: [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext

2017-09-21 Thread Marc-André Lureau
On Thu, Sep 21, 2017 at 8:35 AM, Peter Xu wrote: > The old chardev may not fully support non-default GMainContext. One > direct clue is that when we call io_add_watch_poll() sometimes we are > still passing in the NULL context pointer. > > IIUC we are fine during setup since

[Qemu-devel] [PATCH 2/2] ui: add tracing of VNC authentication process

2017-09-21 Thread Daniel P. Berrange
Trace anything related to authentication in the VNC protocol handshake Signed-off-by: Daniel P. Berrange --- ui/trace-events| 15 +++ ui/vnc-auth-sasl.c | 113 ++--- ui/vnc-auth-vencrypt.c | 21 -

Re: [Qemu-devel] Block Migration and CPU throttling

2017-09-21 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: > > * Peter Lieven (p...@kamp.de) wrote: > >> Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: > >>> * Peter Lieven (p...@kamp.de) wrote: > Hi, > > I just noticed that CPU throttling

Re: [Qemu-devel] [PATCH v10 10/10] migration: add postcopy total blocktime into query-migrate

2017-09-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Postcopy total blocktime is available on destination side only. > But query-migrate was possible only for source. This patch > adds ability to call query-migrate on destination. > To be able to see postcopy blocktime, need to request

Re: [Qemu-devel] Block Migration and CPU throttling

2017-09-21 Thread Peter Lieven
Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I just

[Qemu-devel] [PATCH v2 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin

2017-09-21 Thread Manos Pitsidianakis
Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis --- include/block/block_int.h | 2 +- block/io.c| 4 ++-- block/qed.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks

2017-09-21 Thread Manos Pitsidianakis
This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new bdrv_co_drain_end callback to match bdrv_drained_begin/end and drained_begin/end of BdrvChild. This is needed because the throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle

[Qemu-devel] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Manos Pitsidianakis
BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end of the drain. The throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle io_limits_disabled correctly, thus bdrv_co_drain_end is needed. Signed-off-by: Manos Pitsidianakis

Re: [Qemu-devel] need to resurrect no-lock option?

2017-09-21 Thread Daniel P. Berrange
On Thu, Sep 21, 2017 at 01:43:17PM +0100, Daniel P. Berrange wrote: > On Thu, Sep 21, 2017 at 01:33:20PM +0100, Stefan Hajnoczi wrote: > > On Wed, Sep 20, 2017 at 11:26:11AM +0200, Christian Ehrhardt wrote: > > > Hi, > > > this might have been discussed in the wake of the lock changes that took >

Re: [Qemu-devel] [PATCH v10 08/10] migration: postcopy_blocktime documentation

2017-09-21 Thread Alexey Perevalov
On 09/21/2017 03:33 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Although it does have my R-b it might be worth adding some clarification

Re: [Qemu-devel] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Fam Zheng
On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end > of the drain. The throttle driver (block/throttle.c) needs a way to mark the > end of the drain in order to toggle io_limits_disabled correctly, thus >

[Qemu-devel] nbd structured reply

2017-09-21 Thread Vladimir Sementsov-Ogievskiy via Qemu-devel
Hi all! I'm about this: "A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a possibility of detecting an error before transmission of that chunk completes" What do we mean by "possibility"? Formally, such possibility

Re: [Qemu-devel] [PATCH v3 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-09-21 Thread Aravinda Prasad
On Tuesday 22 August 2017 07:38 AM, David Gibson wrote: [ . . . ] diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index 46012b3..eee8d33 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -123,6 +123,12 @@ struct sPAPRMachineState {

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-21 Thread Halil Pasic
On 09/21/2017 12:48 PM, Cornelia Huck wrote: > On Thu, 21 Sep 2017 12:22:30 +0200 > Halil Pasic wrote: > >> On 09/21/2017 11:24 AM, Cornelia Huck wrote: >>> On Wed, 20 Sep 2017 19:23:12 +0200 >>> Halil Pasic wrote: >>> Jason found

[Qemu-devel] [PATCH 0/3] FlatView memory savings

2017-09-21 Thread Paolo Bonzini
This gets memory API consumption down to 4 FlatViews when non-virtio devices are in use. virtio still wastes memory due to the "modern_as". Alexey Kardashevskiy (1): memory: Share special empty FlatView Paolo Bonzini (2): memory: trace FlatView creation and destruction memory: seek

[Qemu-devel] [PATCH 1/3] memory: trace FlatView creation and destruction

2017-09-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 1 - include/qemu/typedefs.h | 1 + memory.c| 3 +++ trace-events| 3 +++ 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

[Qemu-devel] [PATCH 3/3] memory: Share special empty FlatView

2017-09-21 Thread Paolo Bonzini
From: Alexey Kardashevskiy This shares an cached empty FlatView among address spaces. The empty FV is used every time when a root MR would render into a FV without memory sections, which happens when MR or its children are not enabled (or zero-sized, which isn't caught yet). The

[Qemu-devel] nbd structured reply

2017-09-21 Thread Vladimir Sementsov-Ogievskiy
Hi all! I'm about this: "A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a possibility of detecting an error before transmission of that chunk completes" What do we mean by "possibility"? Formally, such possibility

[Qemu-devel] [patch 0/2] support RT_PRIO_HC hypercall

2017-09-21 Thread Marcelo Tosatti
Add the following CPU options: allow-rt-prio-hc: allow guest to execute hypercall to change vcpu thread priority. rt-prio: SCHED_FIFO priority to be used when that hypercall is invoked. Signed-off-by: Marcelo Tosatti

Re: [Qemu-devel] [PATCH v10 09/10] migration: add blocktime calculation into postcopy-test

2017-09-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch just requests blocktime calculation, but doesn't > add any facility to check or show it. > > Signed-off-by: Alexey Perevalov > --- > tests/postcopy-test.c | 12 +++- > 1 file changed, 11

[Qemu-devel] [PATCH] accel/tcg/cputlb: avoid recursive BQL (fixes #1706296)

2017-09-21 Thread Alex Bennée
The mmio path (see exec.c:prepare_mmio_access) already protects itself against recursive locking and it makes sense to do the same for io_readx/writex. Otherwise any helper running in the BQL context will assert when it attempts to write to device memory as in the case of the bug report.

Re: [Qemu-devel] [PATCH qemu v5 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView

2017-09-21 Thread Paolo Bonzini
On 21/09/2017 10:50, Alexey Kardashevskiy wrote: > * since FlatView::rcu is used now to dispose FV, call_rcu() in > address_space_update_topology() is replaced with direct call to > flatview_unref() Hmm, this is not correct, as you could have thread 1 thread 2 RCU

Re: [Qemu-devel] need to resurrect no-lock option?

2017-09-21 Thread Daniel P. Berrange
On Thu, Sep 21, 2017 at 01:33:20PM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 20, 2017 at 11:26:11AM +0200, Christian Ehrhardt wrote: > > Hi, > > this might have been discussed in the wake of the lock changes that took > > place in 2.10 but I can't find anything clear enough to follow in the > >

[Qemu-devel] [PATCH v2] s390x: use generic cpu_model parsing

2017-09-21 Thread Igor Mammedov
define default CPU type in generic way in machine class_init and let common machine code to handle cpu_model parsing. Signed-off-by: Igor Mammedov Reviewed-by: David Hildenbrand --- CC: Cornelia Huck --- target/s390x/cpu.h | 6

[Qemu-devel] [PULL 2/7] mips: introduce internal.h and cleanup cpu.h

2017-09-21 Thread Yongbok Kim
From: Philippe Mathieu-Daudé no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan Acked-by: Eduardo Habkost

[Qemu-devel] [PULL 3/7] mips: split cpu_mips_realize_env() out of cpu_mips_init()

2017-09-21 Thread Yongbok Kim
From: Philippe Mathieu-Daudé so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan Reviewed-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH 2/3] memory: seek FlatView sharing candidates among children subregions

2017-09-21 Thread Paolo Bonzini
On 21/09/2017 15:39, Alexey Kardashevskiy wrote: > On 21/09/17 22:07, Paolo Bonzini wrote: >> A container can be used instead of an alias to allow switching between >> multiple subregions. In this case we cannot directly share the >> subregions (since they only belong to a single parent), but if

Re: [Qemu-devel] [RFC PATCH v2 06/21] ppc/xive: introduce handlers for interrupt sources

2017-09-21 Thread Cédric Le Goater
On 09/20/2017 06:38 AM, David Gibson wrote: > On Tue, Sep 19, 2017 at 05:08:21PM +0200, Cédric Le Goater wrote: >> On 09/19/2017 04:48 AM, David Gibson wrote: >>> On Mon, Sep 11, 2017 at 07:12:20PM +0200, Cédric Le Goater wrote: These are very similar to the XICS handlers in a simpler form.

Re: [Qemu-devel] [RFC PATCH v2 00/21] Guest exploitation of the XIVE interrupt controller (POWER9)

2017-09-21 Thread Cédric Le Goater
On 09/21/2017 03:25 AM, David Gibson wrote: > On Wed, Sep 20, 2017 at 02:33:37PM +0200, Cédric Le Goater wrote: >> On 09/19/2017 10:46 AM, David Gibson wrote: >>> On Tue, Sep 19, 2017 at 06:20:20PM +1000, David Gibson wrote: On Mon, Sep 11, 2017 at 07:12:14PM +0200, Cédric Le Goater wrote:

Re: [Qemu-devel] [PATCH v10 06/10] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-09-21 Thread Alexey Perevalov
On 09/21/2017 01:16 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case when this feature is provided by kernel. PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, due to

  1   2   3   4   >