Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs

On 09/25/2017 07:28 AM, Kevin Wolf wrote: > We don't need to make any assumptions about the graph layout above the > top node of the commit operation any more. Remove the use of > bdrv_find_overlay() and related variables from the commit job code. > > bdrv_drop_intermediate() doesn't use the

Re: [Qemu-devel] [Qemu-stable] [PATCH] migration: disable auto-converge during bulk block migration

Quoting Peter Lieven (2017-09-21 07:32:32) > auto-converge and block migration currently do not play well together. > During block migration the auto-converge logic detects that ram > migration makes no progress and thus throttles down the vm until > it nearly stalls completely. Avoid this by

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: move registration of "host" CPU core type to machine code

On Mon, 25 Sep 2017 17:48:57 +0200 Greg Kurz wrote: > On Mon, 25 Sep 2017 15:41:34 +0200 > Igor Mammedov wrote: > > > On Mon, 25 Sep 2017 11:47:33 +0200 > > Greg Kurz wrote: > > > > > The CPU core abstraction belongs to the machine code.

Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25

On 24 September 2017 at 22:22, Michael Tokarev wrote: > This is a collection of trivial stuff collected for quite some time. > It includes various stuff, and just one series from > Philippe Mathieu-Daudé (MAINTAINERS update), - other his series are > in the works. > > Thanks, > >

Re: [Qemu-devel] [PATCH v1 14/27] s390x/kvm: factor out storing of adtl CPU status

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Called from SIGP code to be factored out, so let's move it. Add a > FIXME for TCG code in the future. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 29 + >

Re: [Qemu-devel] [PATCH v1 14/27] s390x/kvm: factor out storing of adtl CPU status

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Called from SIGP code to be factored out, so let's move it. Add a > FIXME for TCG code in the future. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 29 + >

Re: [Qemu-devel] [PATCH v1 15/27] s390x/kvm: drop two debug prints

On 09/18/2017 09:00 AM, David Hildenbrand wrote: > Preparation for moving it out of kvm.c. > > Signed-off-by: David Hildenbrand > --- > target/s390x/kvm.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 0/8] Remove some of the fprintf(stderr, "*

Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v1 0/8] Remove some of the fprintf(stderr, "* Message-id: cover.1506384414.git.alistair.fran...@xilinx.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer

On 2017-09-22 16:43, Vladimir Sementsov-Ogievskiy wrote: > Without initialization to zero dirty_bitmap field may be not zero > for a bitmap which should not be stored and > qcow2_store_persistent_dirty_bitmaps will erroneously call > store_bitmap for it which leads to SYGSEGV on

Re: [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27

Quoting Michael Roth (2017-09-19 19:45:09) > Hi everyone, > > The following new patches are queued for QEMU stable v2.10.1: > > https://github.com/mdroth/qemu/commits/stable-2.10-staging > > The release is planned for 2017-10-02: > > https://wiki.qemu.org/Planning/2.10 Thank you for the

Re: [Qemu-devel] [PATCH] accel/tcg/cputlb: avoid recursive BQL (fixes #1706296)

Quoting Alex Bennée (2017-09-21 06:06:25) > The mmio path (see exec.c:prepare_mmio_access) already protects itself > against recursive locking and it makes sense to do the same for > io_readx/writex. Otherwise any helper running in the BQL context will > assert when it attempts to write to device

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

On Mon, Sep 25, 2017 at 3:38 PM, Peter Maydell wrote: > On 25 September 2017 at 22:16, Alistair Francis wrote: >> On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell >> wrote: >>> Alistair, were you planning to provide a

[Qemu-devel] [PATCH v2 4/6] linux-user: refactor socket.h for sparc

fixes SOL_SOCKET and SO_LINGER and all other values that didn't match the default (SO_PASSSEC being the exception as it only changed base) TARGET_SOCK_{NONBLOCK,CLOEXEC} updated to match the values for the header: arch/sparc/include/uapi/asm/fcntl.h Signed-off-by: Carlo Marcelo Arenas Belón

[Qemu-devel] [PATCH v1 8/8] target: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v1 6/8] ui: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

Re: [Qemu-devel] [PATCH v10 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

On 09/25/2017 10:55 AM, Eric Blake wrote: > Now that we have adjusted the majority of the calls this function > makes to be byte-based, it is easier to read the code if it makes > passes over the image using bytes rather than sectors. > > iotests 165 was rather weak - on a default 64k-cluster

Re: [Qemu-devel] [PATCH 2/8] block/nbd-client: refactor nbd_co_receive_reply

On 09/25/2017 08:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Pass handle parameter directly, as the whole request isn't needed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH 8/8] nbd: Minimal structured read for client

On 09/25/2017 08:58 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: drop most of additional error information. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.h | 2 + > include/block/nbd.h | 15 - > block/nbd-client.c

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

On 25 September 2017 at 22:16, Alistair Francis wrote: > On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell > wrote: >> Alistair, were you planning to provide a reviewed-by: for this >> patch (or did you have more review comments on it)? > > Ah woops,

Re: [Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq after really hotplugged

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Let's move it into the machine, so we trigger the IRQ after setting > ms->possible_cpus (which SCLP uses to construct the list of > online CPUs). > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 4

[Qemu-devel] [PATCH v1 5/8] util: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

Quoting Stefan Hajnoczi (2017-09-19 10:50:25) > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least since QEMU

Re: [Qemu-devel] [PATCH v10 00/20] make dirty-bitmap byte-based

On 09/25/2017 10:55 AM, Eric Blake wrote: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the task

[Qemu-devel] [PATCH v2 5/6] linux-user: update default socket.h

enable SO_REUSEPORT as a sideeffect and add SO_GET_FILTER alias Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/socket.h | 59 +++-- 1 file changed, 48 insertions(+), 11 deletions(-) diff --git a/linux-user/socket.h

Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling of WAIT PSW into handle_wait()

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > This will now also detect crashes under TCG. We can directly use > cpu->env.psw.addr instead of kvm_run, as we do a > cpu_synchronize_state(). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.c | 28

Re: [Qemu-devel] [PATCH v1 11/27] s390x/kvm: generalize SIGP stop and restart interrupt injection

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Preparation for factoring it out into !kvm code. > > Signed-off-by: David Hildenbrand > --- > target/s390x/internal.h | 2 ++ > target/s390x/interrupt.c | 20 > target/s390x/kvm-stub.c | 8 >

Re: [Qemu-devel] [PATCH] docker: Fix test-mingw

On Mon, Sep 25, 2017 at 1:29 AM, Fam Zheng wrote: > Feature "dtc" is explicitly required by test-mingw, but is not detected > by the run script since we switched to archive-source.sh in b7f404201e4. > Since it isn't available in the Fedora image which runs this test on > patchew,

[Qemu-devel] [PATCH v1 0/8] Remove some of the fprintf(stderr, "*

Continue on improving QEMUs logging/error messages by removing more fprintf()'s. Unfortunatley my Coccinelle skills aren't that great so it's all done in some nasty regex and a little bit of manual work. Alistair Francis (8): Replace all occurances of __FUNCTION__ with __func__ tests:

[Qemu-devel] [PULL 0/1] tcg patch queue

://github.com/rth7680/qemu.git tags/pull-tcg-20170925 for you to fetch changes up to 8b81253332b5a3f3c67b6462f39caef47a00dd29: accel/tcg/cputlb: avoid recursive BQL (fixes #1706296) (2017-09-25 11:23:30 -0700) BQL bug fix

[Qemu-devel] [PULL 1/1] accel/tcg/cputlb: avoid recursive BQL (fixes #1706296)

From: Alex Bennée The mmio path (see exec.c:prepare_mmio_access) already protects itself against recursive locking and it makes sense to do the same for io_readx/writex. Otherwise any helper running in the BQL context will assert when it attempts to write to device memory

Re: [Qemu-devel] xen/disk: don't leak stack data via response ring

On Sun, 24 Sep 2017, Michael Tokarev wrote: > 23.09.2017 19:05, Michael Tokarev wrote: > > 28.06.2017 01:04, Stefano Stabellini wrote: > >> Rather than constructing a local structure instance on the stack, fill > >> the fields directly on the shared ring, just like other (Linux) > >> backends do.

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

On 25 September 2017 at 23:53, Alistair Francis wrote: > On Mon, Sep 25, 2017 at 3:38 PM, Peter Maydell > wrote: >> On 25 September 2017 at 22:16, Alistair Francis wrote: >>> On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell

Re: [Qemu-devel] [PATCH v1 05/27] s390/tcg: turn INTERRUPT_EXT into a mask

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > +} else if (env->pending_int | INTERRUPT_EXT_FLOATING) { Surely & here. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into handle_sigp()

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > No need to pass kvm_run. > > Signed-off-by: David Hildenbrand > --- > target/s390x/kvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 08/27] s390x/tcg: a CPU cannot switch state due to an interrupt

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Going to OPERATING here looks wrong. A CPU should even never be > !OPERATING at this point. Unhalting will already be done in > cpu_handle_halt() if there is work, so we can drop this statement > completely. > > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v1 16/27] s390x/kvm: factor out SIGP code into sigp.c

On 09/18/2017 09:00 AM, David Hildenbrand wrote: > We want to use the same code base for TCG, so let's cleanly factor it > out. > > The sigp mutex is currently not really needed, as everything is > protected by the iothread mutex. But this could change later, so leave > it in place and initialize

[Qemu-devel] [PATCH v1 7/8] tcg: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

[Qemu-devel] [PATCH v1 4/8] block: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,

Re: [Qemu-devel] [PATCH 11/18] hbitmap: Add @advance param to hbitmap_iter_next()

On 2017-09-25 17:38, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2017 21:19, Max Reitz wrote: >> This new parameter allows the caller to just query the next dirty >> position without moving the iterator. >> >> Signed-off-by: Max Reitz >> --- >>   include/qemu/hbitmap.h |  4

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell wrote: > On 20 September 2017 at 07:19, Michael Olbrich > wrote: >> On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: >>> On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich >>>

Re: [Qemu-devel] [PULL 0/3] slirp updates

On 24 September 2017 at 19:08, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of next_core_id

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */ > -cs->cpu_index = env->core_id; > +cs->cpu_index = cpu->env.core_id; > +#endif Any reason not to drop core_id entirely in favour of cpu_index? (Since cpu_index

Re: [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use S390_MAX_CPUS

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Will be handy in the next patches. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > target/s390x/cpu.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 12/18] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

On 2017-09-25 17:49, Vladimir Sementsov-Ogievskiy wrote: > I have a patch on list, which adds hbitmap_next_zero function, it may help > https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00809.html Hmmm. Sounds good, but (1) I would need to directly access the bitmap instead of the

Re: [Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

Quoting Felipe Franciosi (2017-09-20 13:53:06) > vhost_log_put() is called to decomission the dirty log between qemu and > a vhost device when stopping the device. Such a call can happen from > migration_completion(). > > Present code sets dev->log_size to zero too early in vhost_log_put(), >

Re: [Qemu-devel] [PATCH v10 05/20] dirty-bitmap: Avoid size query failure during truncate

On 09/25/2017 10:55 AM, Eric Blake wrote: > We've previously fixed several places where we failed to account > for possible errors from bdrv_nb_sectors(). Fix another one by > making bdrv_dirty_bitmap_truncate() take the new size from the > caller instead of querying itself; then adjust the

Re: [Qemu-devel] [PATCH] block/throttle-groups.c: allocate RestartData on the heap

Quoting Manos Pitsidianakis (2017-09-18 15:25:29) > RestartData is the opaque data of the throttle_group_restart_queue_entry > coroutine. By being stack allocated, it isn't available anymore if > aio_co_enter schedules the coroutine with a bottom halve and runs after > throttle_group_restart_queue

Re: [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer

Quoting Vladimir Sementsov-Ogievskiy (2017-09-22 09:43:53) > Without initialization to zero dirty_bitmap field may be not zero > for a bitmap which should not be stored and > qcow2_store_persistent_dirty_bitmaps will erroneously call > store_bitmap for it which leads to SYGSEGV on

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: truncate the tail of the image file after shrinking the image

On 09/22/2017 05:39 AM, Pavel Butsykin wrote: > Now after shrinking the image, at the end of the image file, there might be a > tail that probably will never be used. So we can find the last used cluster > and > cut the tail. > > Signed-off-by: Pavel Butsykin

[Qemu-devel] [PATCH v2 6/6] linux_user: consolidate sock_type

remove unnecessary sock_type enum and other unused surrounding code to allow for per arch sockbits to mirror better linux headers for maintenance Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/alpha/sockbits.h | 36

Re: [Qemu-devel] [PATCH v1 07/27] s390x/tcg: STOPPED cpus can never wake up

On 09/18/2017 08:59 AM, David Hildenbrand wrote: > Interrupts can't wake such CPUs up. SIGP from other CPUs has to be used > to toggle the state. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH 0/7] mac_dbdma: tidy-up and QOMify

On Sun, Sep 24, 2017 at 03:47:39PM +0100, Mark Cave-Ayland wrote: > Whilst looking at implementing another DBDMA device for the Mac machines > I noticed a couple of things: firstly there were some unused fields still > in DBDMAState, and secondly the existing code still used global functions > to

Re: [Qemu-devel] [PATCH v2 6/8] arm: Support Capstone in disas_set_info

Richard Henderson writes: > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Tested-by: Alex Bennée And BTW better than libvixl at least w.r.t wfi.

[Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

Replace all occurs of __FUNCTION__ except for the check in checkpatch with the non GCC specific __func__. One line in hcd-musb.c was manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: Gerd Hoffmann Cc: Andrzej Zaborowski

Re: [Qemu-devel] [PATCH 1/2] fprintf-fn.h uses GCC_FMT, but doesn't include the definition of it

I am working on getting ppc-darwin-user working again, and this was one of the many things preventing it from compiling. Your explanation sounds correct. I believe it was the lack of osdep.h in the right .c files, since I added osdep.h to the tops of all of the necessary files well after this

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

> On Sep 25, 2017, at 9:10 AM, Eric Blake wrote: > > On 09/24/2017 08:02 PM, Daniel Loffgren wrote: >> >> Signed-off-by: Daniel Loffgren > > >> --- >> include/exec/user/thunk.h | 1 + >> 1 file changed, 1 insertion(+) > >

[Qemu-devel] [PATCH v3 2/4] iothread: provide helpers for internal use

IOThread is a general framework that contains IO loop environment and a real thread behind. It's also good to be used internally inside qemu. Provide some helpers for it to create iothreads to be used internally. Put all the internal used iothreads into the internal object container.

[Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs

We have object_get_objects_root() to keep user created objects, however no place for objects that will be used internally. Create such a container for internal objects. CC: Andreas Färber CC: Markus Armbruster CC: Paolo Bonzini

[Qemu-devel] [PATCH v3 0/4] iothread: allow to create internal iothreads

v3: - pick up r-bs (one missing for Fam's on last patch) - fix patch 1 to create isolated internal container v2: - add one patch to provide object_get_internal_root() [Daniel] - patch 2: use the new object_get_internal_root() - patch 3: fix commit message, "reentrant" is wrongly used by me. it

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

On Fri, Sep 22, 2017 at 11:16:34AM +0200, Thomas Huth wrote: > Historically we've marked all devices as hotpluggable by default. However, > most devices are not hotpluggable, and you also need a HotplugHandler to > support these devices. So if the user tries to "device_add" or "device_del" > such

Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through vmstate_save

On Mon, Sep 25, 2017 at 12:29:16PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Route the errors from vsmtate_save_state back up through > vmstate_save and out to the normal device state path. > That's the normal error path done. > >

Re: [Qemu-devel] [PATCH v2 6/6] migration: Route more error paths

On Mon, Sep 25, 2017 at 12:29:17PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. vmstate_save() should have been processed with previous patch? >

Re: [Qemu-devel] [PATCH] spapr: move registration of "host" CPU core type to machine code

On Mon, Sep 25, 2017 at 11:47:33AM +0200, Greg Kurz wrote: > The CPU core abstraction belongs to the machine code. This also gets > rid of some code duplication. > > Signed-off-by: Greg Kurz > --- > > hw/ppc/spapr_cpu_core.h is also included elsewhere in target/ppc/kvm.c > but

Re: [Qemu-devel] [PATCH 6/7] mac_dbdma: change DBDMA_register_channel to a MAC_DBDMA type method

On Sun, Sep 24, 2017 at 03:47:45PM +0100, Mark Cave-Ayland wrote: > Using this we can change the MACIO_IDE instance to register the channel > itself via a type method instead of requiring a separate > DBDMA_register_channel() function. > > As a consequence of this it is now possible to remove the

Re: [Qemu-devel] [RFC PATCH v2 01/21] ppc/xive: introduce a skeleton for the sPAPR XIVE interrupt controller

On Fri, Sep 22, 2017 at 02:42:07PM +0200, Cédric Le Goater wrote: > On 09/22/2017 01:00 PM, David Gibson wrote: > > On Tue, Sep 19, 2017 at 03:15:44PM +0200, Cédric Le Goater wrote: > >> On 09/19/2017 04:27 AM, David Gibson wrote: > >>> On Mon, Sep 11, 2017 at 07:12:15PM +0200, Cédric Le Goater

Re: [Qemu-devel] [PATCH] linux-user: remove duplicate break in syscall

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170926041420.32673-1-care...@gmail.com Subject: [Qemu-devel] [PATCH] linux-user: remove duplicate

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

On Mon, Sep 25, 2017 at 12:29:12PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. > > Changed zillions of devices to make

Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr, "*\n" with error_report()

On 26.09.2017 02:08, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

I am attempting to get ppc-darwin-user in a good working state again, and this broke one of the .c files that included it. I figured this change should be made regardless of my branch, and would help reduce the size of my branch for future rebasing. > On Sep 25, 2017, at 9:37 AM, Thomas Huth

Re: [Qemu-devel] [RFC 0/6] initial plugin support

On 06.09.2017 22:28, Emilio G. Cota wrote: > Related threads: > [PATCH 00/13] instrument: Add basic event instrumentation > Date: Mon, 24 Jul 2017 20:02:24 +0300 > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07419.html > and > [PATCH v4 00/20] instrument: Add basic event

[Qemu-devel] [Bug 1354727] Re: build error with GCC 4.9

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1354727 Title: build

[Qemu-devel] [PATCH v3 4/4] iothread: delay the context release to finalize

When gcontext is used with iothread, the context will be destroyed during iothread_stop(). That's not good since sometimes we would like to keep the resources until iothread is destroyed, but we may want to stop the thread before that point. Delay the destruction of gcontext to iothread

Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr, "*\n" with error_report()

On Mon, Sep 25, 2017 at 17:08:48 -0700, Alistair Francis wrote: > diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c > index caa1e8e689..41ba1600c0 100644 > --- a/tests/atomic_add-bench.c > +++ b/tests/atomic_add-bench.c > @@ -29,7 +29,7 @@ static const char commands_string[] = >

Re: [Qemu-devel] [PATCH v10 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

On Mon, 09/25 09:55, Eric Blake wrote: > Now that we have adjusted the majority of the calls this function > makes to be byte-based, it is easier to read the code if it makes > passes over the image using bytes rather than sectors. > > iotests 165 was rather weak - on a default 64k-cluster image,

Re: [Qemu-devel] [PATCH v2 4/6] migration: wire vmstate_save_state errors up to vmstate_subsection_save

On Mon, Sep 25, 2017 at 12:29:15PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Route the errors from vmstate_subsection_save up through > vmstate_subsection_save (and back down, all rather recursive). I guess here one of the

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

On 26.09.2017 04:59, Eduardo Habkost wrote: > On Mon, Sep 25, 2017 at 07:05:26PM +0100, Peter Maydell wrote: >> On 25 September 2017 at 18:59, Eduardo Habkost wrote: >>> Finding the full list of devices that can be instantiated >>> internally at hotplug-time sounds tricky. >>

Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs

On Tue, 09/26 12:52, Peter Xu wrote: > We have object_get_objects_root() to keep user created objects, however > no place for objects that will be used internally. Create such a > container for internal objects. > > CC: Andreas Färber > CC: Markus Armbruster

Re: [Qemu-devel] [PATCH v3 2/4] iothread: provide helpers for internal use

On Tue, 09/26 12:52, Peter Xu wrote: > IOThread is a general framework that contains IO loop environment and a > real thread behind. It's also good to be used internally inside qemu. > Provide some helpers for it to create iothreads to be used internally. > > Put all the internal used iothreads

[Qemu-devel] A glib warning encountered with internal iothread

Hi, Generally speaking this is a question about glib, but I would like to see how the list sees this before throwing this question to glib community in case I made severe mistake. I encountered one glib warning when start to use internal iothread: (qemu-system-x86_64:19925): GLib-CRITICAL **:

Re: [Qemu-devel] [PATCH v1 18/27] s390x/tcg: implement SIGP SENSE RUNNING STATUS

On 25.09.2017 14:47, Thomas Huth wrote: > On 18.09.2017 18:00, David Hildenbrand wrote: >> Preparation for TCG, for KVM is this is completely handled in the >> kernel. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/cpu.h | 2 ++ >> target/s390x/sigp.c | 25

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote: > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. What does the int value signify? Why not a bool? r~

[Qemu-devel] [PATCH 6/8] nbd: Minimal structured read for server

Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 8/8] nbd: Minimal structured read for client

Minimal implementation: drop most of additional error information. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.h | 2 + include/block/nbd.h | 15 - block/nbd-client.c | 97 +- nbd/client.c| 169

[Qemu-devel] [PATCH 1/8] block/nbd-client: assert qiov len once in nbd_co_request

Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index 9d1e154feb..88fd10270e 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@

Re: [Qemu-devel] [PATCH 27/34] hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"

Hi Philippe, It seems the patch is doing much more than what is mentioned in the subject. On 22/09/2017 19:01, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/pci/pci_internal.h | 16 +++ include/hw/net/pci.h | 20 +

Re: [Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170925102302.60587-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH 0/2] s390/z14: extended TOD-clock support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2 2/2] xen: dont try setting max grants multiple times

On Fri, Sep 22, 2017 at 02:07:25PM +0200, Juergen Gross wrote: > Trying to call xengnttab_set_max_grants() with the same file handle > might fail on some kernels, as this operation is allowed only once. > > This is a problem for the qdisk backend as blk_connect() can be > called multiple times

[Qemu-devel] [PATCH v10 01/20] block: Make bdrv_img_create() size selection easier to read

All callers of bdrv_img_create() pass in a size, or -1 to read the size from the backing file. We then set that size as the QemuOpt default, which means we will reuse that default rather than the final parameter to qemu_opt_get_size() several lines later. But it is rather confusing to read

[Qemu-devel] [PATCH v10 00/20] make dirty-bitmap byte-based

There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a

[Qemu-devel] [PATCH] iotests: fix 181: enable postcopy-ram capability on target

Migration capabilities should be enabled on both source and destination qemu processes. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. After my patch commit 58110f0acb1a33e2bc60a2f1b26d2690a92e8a14 Author: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH v10 04/20] dirty-bitmap: Drop unused functions

We had several functions that no one is currently using, and which use sector-based interfaces. I'm trying to convert towards byte-based interfaces, so it's easier to just drop the unused functions: bdrv_dirty_bitmap_get_meta bdrv_dirty_bitmap_get_meta_locked bdrv_dirty_bitmap_reset_meta

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

On 09/25/2017 06:25 AM, Dr. David Alan Gilbert wrote: >> Why not a bool? > > Consistency with pre_load, post_load, put and get methods > that are already int. Fair enough, thanks. r~

[Qemu-devel] [PULL 1/4] nbd-client: Use correct macro parenthesization

If 'bs' is a complex expression, we were only casting the front half rather than the full expression. Luckily, none of the callers were passing bad arguments, but it's better to be robust up front. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 4/4] block/nbd-client: nbd_co_send_request: fix return code

From: Vladimir Sementsov-Ogievskiy It's incorrect to return success rc >= 0 if we skip qio_channel_writev_all() call due to s->quit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

Re: [Qemu-devel] [PATCH v9 05/20] dirty-bitmap: Avoid size query failure during truncate

On 09/23/2017 07:04 AM, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2017 23:18, Eric Blake wrote: >> We've previously fixed several places where we failed to account >> for possible errors from bdrv_nb_sectors().  Fix another one by >> making bdrv_dirty_bitmap_truncate() take the new size from the

[Qemu-devel] [PULL 3/4] block/nbd-client: simplify check in nbd_co_receive_reply

From: Vladimir Sementsov-Ogievskiy If we are woken up from while() loop in nbd_read_reply_entry handles must be equal. If we are woken up from nbd_recv_coroutines_wake_all s->quit must be true, so we do not need checking handles equality. Signed-off-by: Vladimir

[Qemu-devel] [PATCH 2/8] block/nbd-client: refactor nbd_co_receive_reply

Pass handle parameter directly, as the whole request isn't needed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index

[Qemu-devel] [PATCH 7/8] nbd/client: refactor nbd_receive_starttls

Split out nbd_receive_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 64 nbd/trace-events | 7 --- 2 files changed, 50

[Qemu-devel] [PATCH v10 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

We're already reporting bytes for bdrv_dirty_bitmap_granularity(); mixing bytes and sectors in our return values is a recipe for confusion. A later cleanup will convert dirty bitmap internals to be entirely byte-based, but in the meantime, we should report the bitmap size in bytes. The only

[Qemu-devel] [PATCH v10 07/20] dirty-bitmap: Track bitmap size by bytes

We are still using an internal hbitmap that tracks a size in sectors, with the granularity scaled down accordingly, because it lets us use a shortcut for our iterators which are currently sector-based. But there's no reason we can't track the dirty bitmap size in bytes, since it is (mostly) an

  1   2   3   4   >