Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-13 Thread P J P
Hello Philippe, +-- On Sun, 12 Nov 2017, Philippe Mathieu-Daudé wrote --+ | I'd rather use: | |"highbank: bad write offset 0x%" HWADDR_PRIx "\n", offset); Sent revised patch v2. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32

Re: [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global

2017-11-13 Thread Richard Henderson
On 11/10/2017 08:53 PM, Emilio G. Cota wrote: > 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24) > introduces a per-CPUClass bool that we check so that the target CPU > is initialized for TCG only once. This works well except when > we end up creating more than one CPUClass, in which

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > From: "David Hildenbrand" > > On 02.11.2017 12:08, Paolo Bonzini wrote: > > > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: > > >> From: Alex Bennée > > >> > > >> Now the only real need to hold the BQL

[Qemu-devel] [PATCH v2] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-13 Thread Ladi Prosek
The statement being removed doesn't change anything as virtio PCI devices already have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as Vendor ID. And the Virtio spec does not require the two to be equal, either: "The PCI Subsystem Vendor ID and the PCI Subsystem Device

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-13 Thread Paolo Bonzini
On 11/11/2017 19:59, Stefan Priebe - Profihost AG wrote: > Hello, > > Am 10.11.2017 um 05:18 schrieb Jason Wang: >> >> >> On 2017年11月08日 19:22, Jason Wang wrote: >>> >>> >>> On 2017年11月08日 18:46, Paolo Bonzini wrote: On 08/11/2017 09:21, Jason Wang wrote: > > On 2017年11月08日 17:05,

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 02:45, gengdongjiu wrote: > On 2017/11/10 19:32, Paolo Bonzini wrote: >> On 10/11/2017 20:19, Dongjiu Geng wrote: >>> +typedef struct HWPoisonPage { >>> +ram_addr_t ram_addr; >>> +QLIST_ENTRY(HWPoisonPage) list; >>> +} HWPoisonPage; >>> + >> >> Is this actually needed outside

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-13 Thread gengdongjiu
On 2017/11/13 16:27, Paolo Bonzini wrote: >> If you think this structure should be added in accel/kvm/kvm-all.c, I will >> move it. > It can be done later; but if you have to send a v13 series, I would be > grateful if you included this change as well. Ok, got it, thanks Paolo. > > Paolo >

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function.

Re: [Qemu-devel] [PATCH V5] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-11-13 Thread Laszlo Ersek
On 11/11/17 16:25, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with large BARs. > > Fix it

Re: [Qemu-devel] [PATCH v2] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 09:45:58AM +0100, Ladi Prosek wrote: > The statement being removed doesn't change anything as virtio PCI devices > already > have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as > Vendor > ID. And the Virtio spec does not require the two to be

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function.

Re: [Qemu-devel] [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type

2017-11-13 Thread Greg Kurz
On Mon, 13 Nov 2017 16:51:03 +1100 David Gibson wrote: > On Fri, Nov 10, 2017 at 03:20:07PM +, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater > > --- > > hw/ppc/spapr.c | 16 +++- > > 1 file changed, 15 insertions(+), 1

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Jason Wang
On 2017年11月13日 17:51, Peter Maydell wrote: On 13 November 2017 at 07:13, Jason Wang wrote: On 2017年11月06日 21:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc:

Re: [Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 10:21:45AM +0100, Thomas Huth wrote: > The pixman submodule has been removed in commit c12b6d70e384c769ca372e1, > so there is no need anymore to delete pixman/.git while building a > release tarball. > > Signed-off-by: Thomas Huth Reviewed-by: Gerd

Re: [Qemu-devel] [PATCH 3/7] s390x/pci: rework PCI LOAD

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:51, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:35 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Basically the same comments as for the previous patch (but looks good in general). thanks I will

Re: [Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Thomas Huth
On 13.11.2017 10:43, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH] scripts/make-release: No need

[Qemu-devel] [Bug 1731588] Re: qemu-system-arm black screen and keyboard not detected

2017-11-13 Thread Peter Maydell
"stm32-p103" is not a board model supported by upstream QEMU. Presumably you're using a fork of QEMU -- you should ask whoever is responsible for that fork about it. For the second command line -- is the binary you're trying to run built for the stellaris board model you're trying to run it on?

Re: [Qemu-devel] [PULL for-2.11 0/2] Capstone updates

2017-11-13 Thread Peter Maydell
On 9 November 2017 at 07:52, Richard Henderson wrote: > One build fix for mingw cross-compiling, one feature regression fix. > > > r~ > > > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

2017-11-13 Thread Ladi Prosek
On Wed, Nov 8, 2017 at 3:28 PM, Mihail Abakumov wrote: > Ladi Prosek писал 2017-11-08 16:43: > >> On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov >> wrote: >>> >>> Ladi Prosek писал 2017-11-06 18:15: >>> >>> In your case windbg does not

[Qemu-devel] [Bug 530077] Re: kvm: 16-bit code execution failure should be more friendly

2017-11-13 Thread Thomas Huth
Triaging old bug tickets... has this ever been fixed, thus could we close this ticket nowadays? Or is there something left to do here? ** Changed in: qemu Status: Confirmed => Incomplete ** Changed in: qemu Assignee: Anthony Liguori (anthony-codemonkey) => (unassigned) -- You

Re: [Qemu-devel] [PULL for-2.11-rc1 v2 0/2] Block patches

2017-11-13 Thread Peter Maydell
On 8 November 2017 at 19:20, Stefan Hajnoczi wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > >

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Cédric Le Goater
On 11/13/2017 10:53 AM, Peter Maydell wrote: > On 13 November 2017 at 07:14, Thomas Huth wrote: >> By the way, before everybody now introduces "2.12" machine types ... is >> there already a consensus that the next version will be "2.12" ? >> >> A couple of months ago, we

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 10:03, Cédric Le Goater wrote: > One of the sweeping change for 3.0 could be to stop to maintaining > migration compatibility with older versions (2.x). Even if the > feature is really a must have in some cluster environment, the > code (and the developer) is

Re: [Qemu-devel] [PATCH for-2.11] nbd: Don't crash when server reports NBD_CMD_READ failure

2017-11-13 Thread Vladimir Sementsov-Ogievskiy
12.11.2017 04:39, Eric Blake wrote: If a server fails a read, for example with EIO, but the connection is still live, then we would crash trying to print a non-existent error message. Bug introduced in commit f140e300. Signed-off-by: Eric Blake --- block/nbd-client.c | 4

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

2017-11-13 Thread Cornelia Huck
On Mon, 13 Nov 2017 10:03:37 +0100 Pierre Morel wrote: > On 09/11/2017 17:50, Cornelia Huck wrote: > > On Tue, 7 Nov 2017 18:24:34 +0100 > > Pierre Morel wrote: > >> +case PCI_ROM_SLOT: > > > > So, will this be filled in a later

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Pierre Morel
On 10/11/2017 10:51, Cornelia Huck wrote: On Fri, 10 Nov 2017 17:40:12 +0800 Yi Min Zhao wrote: 在 2017/11/10 上午3:23, Cornelia Huck 写道: On Tue, 7 Nov 2017 18:24:38 +0100 Pierre Morel wrote: Let's move the memory region write from

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Pierre Morel
On 10/11/2017 10:51, Cornelia Huck wrote: On Fri, 10 Nov 2017 17:40:12 +0800 Yi Min Zhao wrote: 在 2017/11/10 上午3:23, Cornelia Huck 写道: On Tue, 7 Nov 2017 18:24:38 +0100 Pierre Morel wrote: Let's move the memory region write from

Re: [Qemu-devel] QEMU 3.0 ? (was: [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type)

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 07:14, Thomas Huth wrote: > By the way, before everybody now introduces "2.12" machine types ... is > there already a consensus that the next version will be "2.12" ? > > A couple of months ago, we discussed that we could maybe do a 3.0 after > 2.11, e.g.

Re: [Qemu-devel] [PATCH v1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-13 Thread Daniel Henrique Barboza
Hi Peter, On 11/13/2017 01:22 AM, Peter Xu wrote: On Fri, Nov 10, 2017 at 06:35:16PM -0200, Daniel Henrique Barboza wrote: When migrating a VM with 'migrate_set_capability postcopy-ram on' a postcopy_state is set during the process, ending up with the state POSTCOPY_INCOMING_END when the

[Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Thomas Huth
The pixman submodule has been removed in commit c12b6d70e384c769ca372e1, so there is no need anymore to delete pixman/.git while building a release tarball. Signed-off-by: Thomas Huth --- scripts/make-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH for-2.12 3/3] block: Deprecate "backing": ""

2017-11-13 Thread Daniel P. Berrange
On Fri, Nov 10, 2017 at 04:21:05PM -0600, Eric Blake wrote: > On 11/10/2017 04:13 PM, Max Reitz wrote: > > We have a clear replacement, so let's deprecate it. > > > > Signed-off-by: Max Reitz > > --- > > qapi/block-core.json | 4 ++-- > > block.c | 4 > >

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Thomas Huth
On 13.11.2017 10:53, Peter Maydell wrote: > On 13 November 2017 at 07:14, Thomas Huth wrote: >> By the way, before everybody now introduces "2.12" machine types ... is >> there already a consensus that the next version will be "2.12" ? >> >> A couple of months ago, we discussed

Re: [Qemu-devel] [PATCH v2] highbank: validate register offset before access

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 06:26, P J P wrote: > From: Prasad J Pandit > > An 'offset' parameter sent to highbank register r/w functions > could be greater than number(NUM_REGS=0x200) of hb registers, > leading to an OOB access issue. Add check to avoid

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:50, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:34 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 07:13, Jason Wang wrote: > > > On 2017年11月06日 21:28, Jens Freimann wrote: >> >> This fixes coverity issue CID1005339. >> >> Make sure that saddr is not used uninitialized if the >> mcast parameter is NULL. >> >> Cc: qemu-sta...@nongnu.org >>

Re: [Qemu-devel] [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-13 Thread Wei Wang
Ping for comments, thanks. On 11/03/2017 04:13 PM, Wei Wang wrote: Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to the host via virtio-balloon. The host requests the guest to report the free pages by sending commands via

Re: [Qemu-devel] [Qemu-arm] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

2017-11-13 Thread Peter Maydell
On 8 November 2017 at 12:37, Philippe Mathieu-Daudé wrote: > On 11/07/2017 05:46 PM, Emilio G. Cota wrote: >> Fixes the following warning when compiling with gcc 5.4.0 with -O1 >> optimizations and --enable-debug: >> >> target/arm/translate-a64.c: In function

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 01/12] HACK: use objdump disas

2017-11-13 Thread Alex Bennée
Richard Henderson writes: > --- > disas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/disas.c b/disas.c > index d6a1eb9c8e..69069a85ca 100644 > --- a/disas.c > +++ b/disas.c > @@ -231,7 +231,7 @@ void target_disas(FILE *out, CPUState

Re: [Qemu-devel] [Qemu devel PATCH v2] MAINTAINERS: Add entries for Smartfusion2

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 05:55, Subbaraya Sundeep wrote: > Voluntarily add myself as maintainer for Smartfusion2 > > Signed-off-by: Subbaraya Sundeep > Reviewed-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11

2017-11-13 Thread Peter Maydell
On 10 November 2017 at 19:53, Emilio G. Cota wrote: > Some MachineClass changes to fix TCG initialization of some > ARM boards for 2.11. This was originally reported by Thomas Huth in [1], > where Peter suggested a way to fix it. Further discussion in > another thread [2] followed

Re: [Qemu-devel] [PATCH 3/7] s390x/pci: rework PCI LOAD

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:51, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:35 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Basically the same comments as for the previous patch (but looks good in general). thanks I will

Re: [Qemu-devel] [PATCH v4] throttle-groups: drain before detaching ThrottleState

2017-11-13 Thread Alberto Garcia
On Fri 10 Nov 2017 04:19:34 PM CET, Stefan Hajnoczi wrote: > I/O requests hang after stop/cont commands at least since QEMU 2.10.0 > with -drive iops=100: > > (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000 > (qemu) stop > (qemu) cont > ...I/O is stuck... > > This happens

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Liu, Yi L
On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> > From: "David Hildenbrand" >> > On 02.11.2017 12:08, Paolo Bonzini wrote: >> > > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: >> > >> From: Alex Bennée

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 11:14, Alex Bennée wrote: > > Pavel Dovgalyuk writes: > >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] From: "David Hildenbrand" On 02.11.2017 12:08, Paolo Bonzini wrote: > On 31/10/2017 12:26, Pavel Dovgalyuk wrote:

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 02/12] target/arm: Add ARM_FEATURE_V8_1_SIMD

2017-11-13 Thread Alex Bennée
Richard Henderson writes: "...and enable it for the 'any' CPUs used by linux-user"? Otherwise: Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 1 + >

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Cornelia Huck
On Mon, 13 Nov 2017 10:39:50 +0100 Pierre Morel wrote: > On 10/11/2017 10:51, Cornelia Huck wrote: > > On Fri, 10 Nov 2017 17:40:12 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/11/10 上午3:23, Cornelia Huck 写道: > >>> On Tue, 7 Nov 2017

[Qemu-devel] [PULL 3/8] colo-compare: compare the packet in a specified Connection

2017-11-13 Thread Jason Wang
From: Mao Zhongyi A package from pri_indev or sec_indev only belongs to a particular Connection, so we only need to compare the package in the specified Connection's primary_list and secondary_list, rather than for each the whole Connection list to compare. This is

[Qemu-devel] [PULL 5/8] colo: Consolidate the duplicate code chunk into a routine

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Consolidate the code that extract the ip address(src,dst) and port number(src,dst) of the packet into a separate routine extract_ip_and_port() since the same chunk of code is called from two place. Cc: Zhang Chen Cc: Li Zhijian

Re: [Qemu-devel] [PATCH v2] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-13 Thread Andrew Jeffery
On Mon, 2017-11-13 at 23:58 +1030, Joel Stanley wrote: > The ASPEED hardware contains a lock register for the SCU that disables > any writes to the SCU when it is locked. The machine comes up with the > lock enabled, but on all known hardware u-boot will unlock it and leave > it unlocked when

[Qemu-devel] [RFC 0/5] arm: Exclude reserved memory regions of iommu to avoid

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. And on certain HiSilicon platforms (hip06/hip07), the GIC ITS and PCIe RC deviates from the standard

[Qemu-devel] [RFC 4/5] hw/arm/boot: set fdt size cell of memory node from mem_list

2017-11-13 Thread zhuyijun
From: Zhu Yijun In case of accessing memory holes, we create memory fdt node by traversing mem_list and adjust memory address if the addr is not belong to RAM memory region. Signed-off-by: Zhu Yijun --- hw/arm/boot.c | 151

[Qemu-devel] [RFC 1/5] hw/vfio: Add function for getting reserved_region of device iommu group

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. However, If it falls within the Qemu default virtual memory address space, then reserved regions may get

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Peter Xu
On Tue, Nov 14, 2017 at 11:59:34AM +1100, David Gibson wrote: > On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > > > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > > > From: Peter Xu >

Re: [Qemu-devel] [PATCH for-2.11] xics/kvm: synchonize state before 'info pic'

2017-11-13 Thread David Gibson
On Mon, Nov 13, 2017 at 08:42:39PM +0100, Greg Kurz wrote: > When using the emulated XICS, the 'info pic' monitor command shows: > > CPU 0 XIRR=ff00 ((nil)) PP=ff MFRR=ff > ICS 1000..13ff 0x10040060340 > 1000 MSI 05 00 > 1001 MSI 05 00 > 1002 MSI 05 00 > 1003 MSI ff 00 > 1004 LSI ff

[Qemu-devel] [PULL 6/8] Fix eepro100 simple transmission mode

2017-11-13 Thread Jason Wang
From: Mike Nawrocki The simple transmission mode was treating the area immediately after the transmit command block (TCB) as if it were a transmit buffer descriptor, when in reality it is simply the packet data. This change simply copies the data following the

[Qemu-devel] [PULL 8/8] net/socket: fix coverity issue

2017-11-13 Thread Jason Wang
From: Jens Freimann This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 4/8] colo-compare: Fix comments

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Chen Signed-off-by: Jason Wang

[Qemu-devel] [PULL 1/8] net: fix check for number of parameters to -netdev socket

2017-11-13 Thread Jason Wang
From: Jens Freimann Since commit 0f8c289ad "net: fix -netdev socket,fd= for UDP sockets" we allow more than one parameter for -netdev socket. But now we run into an assert when no parameter at all is specified > qemu-system-x86_64 -netdev socket socket.c:729:

[Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all

Re: [Qemu-devel] [PULL 0/3] Vga 20171110 patches

2017-11-13 Thread Peter Maydell
On 10 November 2017 at 13:26, Gerd Hoffmann wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://git.kraxel.org/qemu

Re: [Qemu-devel] [PATCH v8 04/14] block/dirty-bitmap: add bdrv_dirty_bitmap_set_frozen

2017-11-13 Thread John Snow
On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > Make it possible to set bitmap 'frozen' without a successor. > This is needed to protect the bitmap during outgoing bitmap postcopy > migration. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PATCH v8.1 05/14] migration: introduce postcopy-only pending

2017-11-13 Thread John Snow
On 10/30/2017 02:19 PM, Vladimir Sementsov-Ogievskiy wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Juan

[Qemu-devel] [RFC 2/5] hw/arm/virt: Enable dynamic generation of guest RAM memory regions

2017-11-13 Thread zhuyijun
From: Zhu Yijun Register a ram_memory_region_init notify to allocate memory region from system memory and add them as subregions. Signed-off-by: Zhu Yijun --- hw/arm/virt.c | 21 - include/hw/arm/virt.h | 1 + 2 files

[Qemu-devel] [PULL 0/8] Net patches

2017-11-13 Thread Jason Wang
The following changes since commit 4ffa88c99c54d2a30f79e3dbecec50b023eff1c8: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-2017-11-08-1' into staging (2017-11-10 16:01:35 +) are available in the git repository at: https://github.com/jasowang/qemu.git

[Qemu-devel] [PULL 2/8] colo-compare: Insert packet into the suitable position of packet queue directly

2017-11-13 Thread Jason Wang
From: Mao Zhongyi Currently, a packet from pri_dev or sec_dev is fristly pushed at the tail of the primary or secondary packet queue then sorted by the tcp sequence number. Now, this patch use g_queue_insert_sorted to insert the packet directly into the suitable

Re: [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files

2017-11-13 Thread Murilo Opsfelder Araújo
On 11/13/2017 07:39 PM, Amador Pahim wrote: > To launch a VM, we need to create basically two files: the monitor > socket (if it's a UNIX socket) and the qemu log file. > > For the qemu log file, we currently just open the path, which will > create the file if it does not exist or overwrite the

[Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2017-11-13 Thread zhuyijun
From: Zhu Yijun Dig out reserved memory holes and collect scattered RAM memory regions by adding mem_list member in arm_boot_info struct. Signed-off-by: Zhu Yijun --- hw/arm/boot.c| 8 hw/arm/virt.c| 101

Re: [Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-11-13 Thread Dou Liyang
Hi Michael, [...] Seems to cause build failures: /scm/qemu/numa.c:452:13: error: too many arguments to function ‘parse_numa_node’ parse_numa_node(ms, , NULL, NULL); Yes, commit cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier") removed a argument from the function

[Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

2017-11-13 Thread Jason Wang
From: Mike Nawrocki Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. The "x-use-alt-device-id" property controls whether this new ID is to be used, and is true by default, and set to false in a compat entry. Signed-off-by: Mike Nawrocki

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5 17/29] hw/nvram: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Philippe Mathieu-Daudé
On 11/13/2017 07:35 PM, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH v8 07/14] migration: include migrate_dirty_bitmaps in migrate_postcopy

2017-11-13 Thread John Snow
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > Enable postcopy if dirty bitmap migration is endabled. > "enabled" > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Juan Quintela Reviewed-by: John Snow

Re: [Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread David Airlie
Hi Joe, > > I am developing using qemu with virglrenderer on linux systems that > do not support dmabufs or GBM. I have been successful making this > work using glx and ignoring egl/dmabuf/gbm use in qemu. > Unfortunately, there is currently no way to configure qemu to use > opengl but

Re: [Qemu-devel] 答复: Re: [PATCH v2] qga: replace GetIfEntry

2017-11-13 Thread Michael Roth
Quoting lu.zhip...@zte.com.cn (2017-11-09 05:26:15) > i think the code is better > > if (OSver.dwMajorVersion >= 6) { > MIB_IF_ROW2 aMib_ifrow; > typedef NETIOAPI_API (WINAPI *getifentry2_t)(PMIB_IF_ROW2 Row); > memset(_ifrow, 0, sizeof(aMib_ifrow)); >

[Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread Joe Kniss via Qemu-devel
Hi, I am developing using qemu with virglrenderer on linux systems that do not support dmabufs or GBM. I have been successful making this work using glx and ignoring egl/dmabuf/gbm use in qemu. Unfortunately, there is currently no way to configure qemu to use opengl but disable

Re: [Qemu-devel] [PATCH v8 09/14] migration: add is_active_iterate handler

2017-11-13 Thread John Snow
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so > to disable them and stop transporting empty sections there is a new > savevm handler. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread David Gibson
On Mon, Nov 13, 2017 at 04:28:45PM +0800, Peter Xu wrote: > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > > From: Peter Xu > > > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just

[Qemu-devel] [RFC 5/5] hw/arm/virt-acpi-build: Build srat table according to mem_list

2017-11-13 Thread zhuyijun
From: Zhu Yijun In case of accessing memory holes, we build srat table by traversing mem_list. Signed-off-by: Zhu Yijun --- hw/arm/virt-acpi-build.c | 40 +++- 1 file changed, 35 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 0/5] backup improvements part 1

2017-11-13 Thread Jeff Cody
On Mon, Nov 13, 2017 at 05:41:13PM -0500, John Snow wrote: > Jeff, I think this ought to go through your tree, but I'll sign off on it. > > Fam: Do you agree? > > (Probably -next material, but I'm sending this email because I'm taking > it out of my review queue and I don't want it to get lost.)

[Qemu-devel] QEMU abort when network serivce is restarted during live migration with vhost-user as the network backend

2017-11-13 Thread fangying
Hi all, We have a vm running migration with vhost-user as network backend, we notice that qemu will abort when openvswitch is restarted when MEMORY_LISTENER_CALL_GLOBAL(log_global_start, Forward) is called. The reasion is clear that vhost_dev_set_log returns -1 because the network connection is

Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-13 Thread Markus Armbruster
geoff--- via Qemu-devel writes: > On 2017-11-14 04:27, Markus Armbruster wrote: >> Ladi Prosek writes: >> >>> Adds a rollback path to ivshmem_enable_irqfd() and fixes >>> ivshmem_disable_irqfd() to bail if irqfd has not been enabled. >>> >>>

Re: [Qemu-devel] [PATCH v5 28/29] tcg: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/cpus.c b/cpus.c > index 114c29b6a0..d73df01659 100644

[Qemu-devel] [PULL 2/2] xics/kvm: synchonize state before 'info pic'

2017-11-13 Thread David Gibson
From: Greg Kurz When using the emulated XICS, the 'info pic' monitor command shows: CPU 0 XIRR=ff00 ((nil)) PP=ff MFRR=ff ICS 1000..13ff 0x10040060340 1000 MSI 05 00 1001 MSI 05 00 1002 MSI 05 00 1003 MSI ff 00 1004 LSI ff 00 1005 LSI ff 00 1006 LSI ff 00

[Qemu-devel] [PULL 0/2] ppc-for-2.11 queue 20171114

2017-11-13 Thread David Gibson
The following changes since commit 4e8a737c092d25fe5ff99ac7bff01c222c1c017d: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20171110-pull-request' into staging (2017-11-13 14:33:29 +) are available in the git repository at: git://github.com/dgibson/qemu.git

Re: [Qemu-devel] [PATCH v2 1/1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:35:17PM -0200, Daniel Henrique Barboza wrote: > When migrating a VM with 'migrate_set_capability postcopy-ram on' > a postcopy_state is set during the process, ending up with the > state POSTCOPY_INCOMING_END when the migration is over. This > postcopy_state is taken

Re: [Qemu-devel] [PATCH for-2.11] nbd/client: Use error_prepend() correctly

2017-11-13 Thread Markus Armbruster
Eric Blake writes: > On 11/13/2017 11:14 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> When using error prepend(), it is necessary to end with a space >>> in the format string; otherwise, messages come out incorrectly, >>> such as when

Re: [Qemu-devel] [PATCH v5 15/29] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:35, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v5 13/29] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Michael Walle
Am 2017-11-13 23:35, schrieb Alistair Francis: Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N;

[Qemu-devel] unsubscribe

2017-11-13 Thread li.shanlue
unsubscribe

Re: [Qemu-devel] [PATCH v10 0/8] scripts/qemu.py fixes and cleanups

2017-11-13 Thread Markus Armbruster
Amador Pahim writes: > Changes v1->v2: > - Style fixes to make checkpatch.pl happy. > - Rebased. > Changes v2->v3: > - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message. > Changes v3->v4: > - Squash the 2 first commits since they are co-dependant. > -

Re: [Qemu-devel] [PATCH v5 26/29] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/hw/timer/omap_gptimer.c b/hw/timer/omap_gptimer.c >

Re: [Qemu-devel] [PATCH v9 2/8] qemu.py: better control of created files

2017-11-13 Thread Amador Pahim
On Tue, Nov 14, 2017 at 1:08 AM, Murilo Opsfelder Araújo wrote: > On 11/13/2017 07:39 PM, Amador Pahim wrote: >> To launch a VM, we need to create basically two files: the monitor >> socket (if it's a UNIX socket) and the qemu log file. >> >> For the qemu log file, we

[Qemu-devel] [PULL 1/2] target/ppc: correct htab shift for hash on radix

2017-11-13 Thread David Gibson
From: Sam Bobroff KVM HV will soon support running a guest in hash mode on a POWER9 host running in radix mode (see [1]), however the guest currently fails to boot. This is because the "htab_shift" value (the size of the MMU's hash table) is added to the device tree

Re: [Qemu-devel] qemu+virgl on systems without dmabuf and/or GBM

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 04:15:30PM -0800, Joe Kniss wrote: > Hi, > > I am developing using qemu with virglrenderer on linux systems that > do not support dmabufs or GBM. I have been successful making this > work using glx and ignoring egl/dmabuf/gbm use in qemu. nvidia? Which user interface?

Re: [Qemu-devel] [PATCH v5 29/29] target: Use qemu_log() instead of fprintf(stderr, ...)

2017-11-13 Thread Thomas Huth
On 13.11.2017 23:36, Alistair Francis wrote: > Signed-off-by: Alistair Francis [...] > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > index 998fbed848..8eafe30624 100644 > --- a/target/ppc/translate.c > +++ b/target/ppc/translate.c > @@ -3945,11

Re: [Qemu-devel] [PATCH v6 4/5] crash: export paddr_vmcoreinfo_note()

2017-11-13 Thread Dave Young
On 11/13/17 at 08:29pm, Marc-André Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module, > to call the function and write the note location details in the > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > CC: Andrew Morton

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-13 Thread ChristianEhrhardt
This was blocked migrating on a autopkgtest for a known issue now resolved. TL;DR no bionic images. Resolved now, should migrate soon. While the final fix now accepted in linux-user is slightly different, the difference is only a comment. It is therefore fine if we pick this up on next merge for

[Qemu-devel] [PATCH] Document pretty parameter for mon option

2017-11-13 Thread Vicente Jimenez Aguilar
Documentation: document pretty parameter for mon option Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..f06002689d 100644 ---

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more, and

  1   2   3   4   >