Re: [Qemu-devel] [PATCH RFC 1/3] tcg: support MOV_VEC and MOVI_VEC opcodes in register allocator

On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > Signed-off-by: Kirill Batuzov > --- > tcg/tcg.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index a7854a59a1..6db7dd526a 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -3327,10 +3327,12

Re: [Qemu-devel] [PATCH for-2.12 1/2] cadence_ttc: extract CadenceTTCState to a new header file

On 11/21/2017 07:41 PM, Peter Maydell wrote: On 8 November 2017 at 11:32, KONRAD Frederic wrote: We want to add this model to the xlnx-zynqmp board so let's make CadenceTTCState available in an header file. Signed-off-by: KONRAD Frederic

[Qemu-devel] [PATCH 5/5] nbd/server: structurize option reply sending

Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 79b937d88f..975fe8efe9 100644 --- a/nbd/server.c +++

Re: [Qemu-devel] [PULL 0/2] Migration pull request

Juan Quintela wrote: > Hi > > THis has two fixes for migration, please apply. > > Later, Juan. > > The following changes since commit a15d835f00dce270fd3194e83d9910f4b5b44ac0: > > Update version for v2.11.0-rc2 release (2017-11-21 17:50:36 +) > > are available in the

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

22.11.2017 03:10, John Snow wrote: On 11/21/2017 12:23 PM, Kevin Wolf wrote: Am 17.11.2017 um 22:35 hat John Snow geschrieben: usage is like this: 1. we have dirty bitmap bitmap0 for incremental backup. 2. prepare image fleecing (create temporary image with backing=our_disk) 3. in qmp

[Qemu-devel] [PATCH] tcg: Fix complilation with TCG

This commit started use tb_unlock() and tlb_set_dirty() on non TCG code. Add the function as stubs. commit 27266271977c5a30f2f7d493e042be1897827bdd Author: Peter Maydell Date: Mon Nov 20 18:08:27 2017 + exec.c: Factor out before/after actions for notdirty

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > Quoting Christian Borntraeger (2017-11-21 15:38:32) > >> forgot to cc qemu-devel > >> > >> On 11/21/2017 10:37 PM, Christian Borntraeger wrote: > >>> a quick heads up

Re: [Qemu-devel] [PATCH RFC 3/3] tcg/optimize: handle vector loads and stores during copy propagation

On 11/22/2017 09:06 AM, Richard Henderson wrote: > On 11/09/2017 03:41 PM, Kirill Batuzov wrote: >> +} else if (re == INDEX_op_mov_vec) { >> +if (ts_are_copies(arg_temp(op->args[0]), ml->copy)) >> { >> +tcg_op_remove(s, op);

[Qemu-devel] [PATCH 1/5] nbd/server: refactor negotiation functions parameters

Instead of passing currently negotiating option and its length to many of negotiation functions let's just store them on NBDClient struct to be state-variables of negotiation phase. This unifies semantics of negotiation functions and this allows to track changes of remaining option length in

[Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid

Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 74 +--- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index c9445a89e9..79b937d88f 100644 ---

Re: [Qemu-devel] [Qemu-block] [PULL 1/4] blockjob: do not allow coroutine double entry or entry-after-completion

Am 21.11.2017 um 18:03 hat Jeff Cody geschrieben: > When block_job_sleep_ns() is called, the co-routine is scheduled for > future execution. If we allow the job to be re-entered prior to the > scheduled time, we present a race condition in which a coroutine can be > entered recursively, or even

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

On 11/22/2017 04:23 AM, Michael Roth wrote: > Quoting Christian Borntraeger (2017-11-21 15:38:32) >> forgot to cc qemu-devel >> >> On 11/21/2017 10:37 PM, Christian Borntraeger wrote: >>> a quick heads up . Rc2 now triggers >>> +qemu-img: block/block-backend.c:2088: blk_root_drained_end:

Re: [Qemu-devel] [PATCH v1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Daniel Henrique Barboza wrote: >> > When migrating a VM with 'migrate_set_capability postcopy-ram on' >> > a postcopy_state is set during the process, ending up

[Qemu-devel] [PULL 1/2] migration, xen: Fix block image lock issue on live migration

From: Anthony PERARD When doing a live migration of a Xen guest with libxl, the images for block devices are locked by the original QEMU process, and this prevent the QEMU at the destination to take the lock and the migration fail. >From QEMU point of view, once the

Re: [Qemu-devel] [PATCH RFC 2/3] tcg/optimize: do copy propagation for memory locations

On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > +typedef struct TCGMemLocation { > +/* Offset is relative to ENV. Only fields of CPUState are accounted. */ > +tcg_target_ulong offset; > +tcg_target_ulong size; > +TCGType type; > +/* Pointer to a temp containing a valid copy of

[Qemu-devel] [PULL 0/2] Migration PULL take 2

://github.com/juanquintela/qemu.git tags/migration/20171122 for you to fetch changes up to acab30b85db0885ab161aff4c83c550628f6d8ca: migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END (2017-11-22 08:50:37 +0100

Re: [Qemu-devel] "make -C roms lgplvgabios" broken

Hi, > Do we still care enough about lgplvgabios to try to fix that, or > should we just remove the lgplvgabios rules and the roms/vgabios > submodule? The last commit in our vgabios.git submodule was 7 > years ago. I plan to zap it anyway when switching to the separate firmware repo[1]. Which

Re: [Qemu-devel] [PATCH RFC 3/3] tcg/optimize: handle vector loads and stores during copy propagation

On 11/09/2017 03:41 PM, Kirill Batuzov wrote: > +} else if (re == INDEX_op_mov_vec) { > +if (ts_are_copies(arg_temp(op->args[0]), ml->copy)) { > +tcg_op_remove(s, op); > +break; > +

[Qemu-devel] [PATCH] vfio/common: init giommu_list and hostwin_list of vfio container

The init of giommu_list and hostwin_list is missed during container initialization. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 7b2924c..14c5940 100644 ---

[Qemu-devel] [PULL 2/2] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

From: Daniel Henrique Barboza When migrating a VM with 'migrate_set_capability postcopy-ram on' a postcopy_state is set during the process, ending up with the state POSTCOPY_INCOMING_END when the migration is over. This postcopy_state is taken into account inside

[Qemu-devel] [PATCH 4/5] nbd: rename nbd_option and nbd_opt_reply

Rename nbd_optino and nbd_opt_reply to NBDOption and NBDOptionReply to correspond to Qemu coding style and other structures here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 8 nbd/client.c| 12 ++-- 2 files changed,

[Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen

Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index bccc0274e7..c9445a89e9 100644 --- a/nbd/server.c +++ b/nbd/server.c @@

[Qemu-devel] [PATCH 0/5] NBD server refactoring before BLOCK_STATUS

Hi all. Here are some preliminary refactoring before implementing BLOCK_STATUS extension. Vladimir Sementsov-Ogievskiy (5): nbd/server: refactor negotiation functions parameters nbd/server: add nbd_opt_{read,drop} to track client->optlen nbd/server: add helper nbd_opt_invalid nbd: rename

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

On Wed, 11/22 04:55, Jeff Cody wrote: > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > Quoting Christian Borntraeger (2017-11-21 15:38:32) > > >> forgot to cc qemu-devel > > >> > > >> On 11/21/2017 10:37

[Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

Guest state should not be touched if VM is stopped, unfortunately we didn't check running state and tried to drain tx queue unconditionally in virtio_net_set_status(). A crash was then noticed as a migration destination when user type quit after virtqueue state is loaded but before region cache is

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On Wed, Nov 22, 2017 at 09:32:04 -0300, Philippe Mathieu-Daudé wrote: > On 11/22/2017 05:41 AM, Juan Quintela wrote: > > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > > code. Add the function as stubs. > > > > commit 27266271977c5a30f2f7d493e042be1897827bdd > > Author:

Re: [Qemu-devel] [PATCH v7 06/13] xilinx_spips: Update striping to be big-endian bit order

On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Update striping functionality to be big-endian bit order (as according to > the Zynq-7000 Technical Reference Manual). Output thereafter the even bits > into the flash memory connected to the lower QSPI bus and

[Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line

Signed-off-by: Max Reitz --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index c665bcc977..1ae47b1c2e 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1398,7 +1398,7 @@ static int vmdk_write_extent(VmdkExtent

[Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 index ecbd8ebd71..d0cfab8844 100755 --- a/tests/qemu-iotests/103 +++ b/tests/qemu-iotests/103 @@ -40,6 +40,8 @@ trap

[Qemu-devel] [PATCH 13/17] iotests: Fix 067 for compat=0.10

067 works very well with compat=0.10 once you remove format-specific information from the QMP output. Signed-off-by: Max Reitz --- tests/qemu-iotests/067 | 3 +- tests/qemu-iotests/067.out | 97 +- 2 files changed, 28

Re: [Qemu-devel] [PATCH v7 00/13] Add support for the ZynqMP Generic QSPI

On Tue, Nov 21, 2017 at 10:39 AM, Peter Maydell wrote: > On 3 November 2017 at 00:00, Francisco Iglesias > wrote: >> Hi, >> >> This patch series is an attempt to add support for the ZynqMP QSPI >> (consisting >> of the Generic QSPI and the

[Qemu-devel] [PATCH 12/17] iotests: Fix 059's reference output

As of commit 9877860e7bd1e26ee70ab9bb5ebc34c92bf23bf5, vmdk fails differently when opening the sample image. Signed-off-by: Max Reitz --- tests/qemu-iotests/059.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/059.out

[Qemu-devel] [PATCH 14/17] iotests: Make 089 compatible with compat=0.10

The only thing that is missing is a _filter_img_info after the "$QEMU_IO -c info" invocations. Signed-off-by: Max Reitz --- tests/qemu-iotests/089 | 4 ++-- tests/qemu-iotests/089.out | 10 -- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v7 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the > header for consistency (struct XilinxSPIPS is found there). Also move out > a define and remove two dubbel included headers (while

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

On Thu, Nov 23, 2017 at 08:47:47AM +0800, Fam Zheng wrote: > On Wed, 11/22 04:55, Jeff Cody wrote: > > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > > Quoting Christian Borntraeger (2017-11-21 15:38:32)

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

On Wed, Nov 22, 2017 at 04:15:52PM +1100, Alexey Kardashevskiy wrote: > The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support, > however PR KVM (a special version of KVM designed to work in > a paravirtualized system; these days used for nested virtualizaion) only > supports

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

On 23/11/17 00:39, David Gibson wrote: > On Wed, Nov 22, 2017 at 04:15:52PM +1100, Alexey Kardashevskiy wrote: >> The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support, >> however PR KVM (a special version of KVM designed to work in >> a paravirtualized system; these days used

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

On 11/23/2017 1:03, Thomas Huth wrote: On 22.11.2017 15:52, Yu Ning wrote: On 11/22/2017 20:25, Thomas Huth wrote: [...] Would it be OK to remove the qemu-debian-wheezy-gui-with-haxm.png from the blog post? Yes, I'm fine with removing it.  Sorry I haven't installed Jekyll and didn't test

[Qemu-devel] [PATCH 10/17] iotests: Fix 020 for vmdk

vmdk cannot work with anything but vmdk backing files, so make the backing file be the same format as the overlay. Reported-by: John Snow Signed-off-by: Max Reitz --- tests/qemu-iotests/020 | 9 ++--- tests/qemu-iotests/020.out | 6 -- 2 files

[Qemu-devel] [PATCH 09/17] iotests: Disable some tests for compat=0.10

Tests 080, 130, 137, and 176 simply do not work with compat=0.10 for the reasons stated there. 177 is a bit more interesting: Originally, it was actually very much intended to work with compat=0.10 (it even had a special case for that). However, it now prints the test image's map twice, and

[Qemu-devel] [PATCH 04/17] block/vmdk: Add blkdebug events

This is certainly not complete, but it includes at least write_aio and read_aio. Signed-off-by: Max Reitz --- block/vmdk.c | 16 1 file changed, 16 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 1ae47b1c2e..d71cec4f31 100644 --- a/block/vmdk.c

[Qemu-devel] [PATCH 16/17] iotests: Make 191 work with qcow2 options

In order for 191 to work with an explicit refcount_bits or compat=0.10, we should strip format-specific information from the output--and we can do so by using _filter_img_info. Signed-off-by: Max Reitz --- tests/qemu-iotests/191 | 5 +- tests/qemu-iotests/191.out | 313

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

On 2017-11-23 03:08, Max Reitz wrote: > This series fixes the qemu-iotests for qcow, vmdk, qcow2 v2 and qcow2 v3 > with refcount_bits=1. (By the way, excuse me for calling vmdk a weird format. That was supposed to be a joke. (I know explaining a joke makes it unfunny, but I now feel a bit bad

[Qemu-devel] [PATCH 15/17] iotests: Make 184 image-less

184 does not need an image, so don't use one. Signed-off-by: Max Reitz --- tests/qemu-iotests/184 | 25 -- tests/qemu-iotests/184.out | 63 +++--- 2 files changed, 14 insertions(+), 74 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v7 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. > > Signed-off-by: Francisco Iglesias Reviewed-by: Alistair Francis

[Qemu-devel] [PATCH 05/17] iotests: Fix _img_info for backslashes

read without -r eats backslashes. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index dbae7d74ba..6fa0495e10 100644 ---

[Qemu-devel] [PATCH 03/17] block/qcow: Add blkdebug events

This is not necessarily complete, but it should include the most important places. Signed-off-by: Max Reitz --- block/qcow.c | 16 1 file changed, 16 insertions(+) diff --git a/block/qcow.c b/block/qcow.c index 9569deeaf0..d552a6eba8 100644 ---

[Qemu-devel] [PATCH 11/17] iotests: Fix 051 for compat=0.10

051 has both compat=1.1 and compat=0.10 tests (once it uses lazy_refcounts, once it tests that setting them does not work). For the compat=0.10 tests, it already explicitly creates a suitable image. So let's just ignore the user-specified compat level for the lazy_refcounts test and explicitly

[Qemu-devel] [PATCH 06/17] iotests: Drop format-specific in _filter_img_info

_filter_img_info should remove format-specific information, too. We already have such a filter in _img_info, and it is very useful for query-block-named-block-nodes (etc.), too. However, in 198 we need that information (but we still want the rest of the filter), so make that filtering optional.

[Qemu-devel] [PATCH 17/17] iotests: Filter compat-dependent info in 198

There is a bit of image-specific information which depends on the qcow2 compat level. Filter it so that 198 works with compat=0.10 (and any refcount_bits value). Note that we cannot simply drop the --format-specific switch because we do need the "encrypt" information. Signed-off-by: Max Reitz

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On 11/22/2017 02:19 AM, Rik van Riel wrote: We can go with the "best" interface for what could be a relatively slow flush (fsync on a file on ssd/disk on the host), which requires that the flushing task wait on completion asynchronously. I'd like to clarify the interface of "wait on

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. You mean from unmasked "to" masked right? The way it's currently called from msix_reset(), though, may

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

* Richard Henderson (richard.hender...@linaro.org) wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: > > On 22 November 2017 at 12:01, Richard Henderson > > wrote: > >> On 11/22/2017 09:41 AM, Juan Quintela wrote: > >>> This commit started use tb_unlock() and

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

"Daniel P. Berrange" wrote: > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 25 ++--- >> migration/migration.h | 2 ++ >> migration/socket.c| 7

[Qemu-devel] postcopy test under load

Hi Peter, I was trying to reproduce the occasional travis postcopy test case failures you were seeing; I can reproduce them but only with tcg - which makes me wonder if the problem is in the test or actually in tcg. My test is: export

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: > Hi Ladi, > > On 20/11/2017 16:22, Ladi Prosek wrote: >> >> msix_mask_all() is supposed to invoke the release vector notifier if the >> state of the >> respective vector changed from unmasked or masked. > > > You mean

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> migration/migration.c | 25

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

On Tue, 21 Nov 2017 19:03:17 +0100 Pierre Morel wrote: > On 21/11/2017 15:25, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 11:38:45 +0100 > > Cornelia Huck wrote: > > > >> On Thu, 16 Nov 2017 18:51:50 +0100 > >> Pierre Morel

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 22 November 2017 at 12:01, Richard Henderson wrote: > On 11/22/2017 09:41 AM, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >>

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 22 November 2017 at 12:08, Richard Henderson wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: >> Wow, I totally do not expect "assert(tcg_enabled())" to mean >> "we rely on the compiler to be able to determine that this >> code is dead" (and in general I'm

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 11/22/2017 05:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + >

[Qemu-devel] [PATCH v4 1/1] migration: Use proper types in json

We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. This change only happens for HMP. QMP always use bytes and similars. Signed-off-by: Juan Quintela --- hmp.c | 22 +++---

[Qemu-devel] [PATCH v2 5/6] migration: make migrate uri parameter optional

Now that we have set an uri migration parameter, we can make it optional in the command line. Signed-off-by: Juan Quintela --- hmp-commands.hx | 4 ++-- hmp.c | 5 +++-- migration/migration.c | 12 +--- qapi/migration.json | 2 +- 4 files

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

On Tue 21 Nov 2017 04:18:13 PM CET, Anton Nefedov wrote: > >> keep BlockJob referenced while it is > >> paused (by block_job_pause/resume_all()). That should prevent it from > >> deleting the BB. > > looks kind of hacky; maybe referencing in block_job_pause() (and not > just pause_all) seems

Re: [Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter

On Wed, Nov 22, 2017 at 01:42:16PM +0100, Juan Quintela wrote: > It will be used to store the uri migration parameter. Right now it is > just the parameter code. > > Signed-off-by: Juan Quintela > --- > hmp.c | 7 +++ > migration/migration.c | 13

Re: [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

On Wed, 22 Nov 2017 13:15:21 +0800 Yi Min Zhao wrote: > 在 2017/11/22 上午2:07, Pierre Morel 写道: > > On 21/11/2017 11:42, Cornelia Huck wrote: > >> On Thu, 16 Nov 2017 18:51:52 +0100 > >> Pierre Morel wrote: > >> > >>> Enhance the fault

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 22 November 2017 at 08:41, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 11/22/2017 09:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + >

[Qemu-devel] [PATCH] qga-win: VSS: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error

From: Sameeh Jubran We can get VSS_E_PROVIDER_ALREADY_REGISTERED error if for some reason the uninstall of qemu-ga didn't complete successfully. In this case we can try to unregister the component service and attempt to register it again. Signed-off-by: Sameeh Jubran

Re: [Qemu-devel] [PATCH for-2.11] Fix build of console and GUI executables for Windows

On 21 November 2017 at 21:04, Stefan Weil wrote: > Am 16.11.2017 um 17:37 schrieb Stefan Weil: >> It was broken by commit 8ecc89f6e792152496eccb684d6c8c48aba8027d which >> moved the SDL linker flags from macro libs_softmmu to macro SDL_LIBS. >> >> Signed-off-by: Stefan Weil

[Qemu-devel] [PATCH v4 0/1] Use rightc parames (was Make xbzrle_cache_size a migration parameter)

Hi On v4: - Markus agreed that the change on sizes are right, so resend without RFC. Rest of patches already in, please review. Later, Juan. On v3: - rebase on top of last migration pull requset - improve comments (dave suggestion) - always return 0 in case of error - checked with

[Qemu-devel] [PATCH v2 2/6] migration: free addr in the same function that we created it

Otherwise, we can't use it after calling socket_start_incoming_migration Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/socket.c

[Qemu-devel] [PATCH v2 4/6] migration: Now set the migration uri

Signed-off-by: Juan Quintela --- migration/migration.c | 25 ++--- migration/migration.h | 2 ++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 3e48d37880..507226907b 100644 ---

Re: [Qemu-devel] [PATCH 5/6] migration: Now set the migration uri

On Wed, Nov 22, 2017 at 12:54:58PM +, Daniel P. Berrange wrote: > On Wed, Nov 22, 2017 at 01:29:57PM +0100, Juan Quintela wrote: > > "Daniel P. Berrange" wrote: > > > On Mon, Oct 30, 2017 at 12:21:11PM +0100, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

On 22/11/2017 14:32, Ladi Prosek wrote: On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

On 11/22/2017 01:03 PM, Peter Maydell wrote: > On 22 November 2017 at 12:01, Richard Henderson > wrote: >> On 11/22/2017 09:41 AM, Juan Quintela wrote: >>> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >>> code. Add the function as stubs. >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 18:05:46 +0100 Halil Pasic wrote: > On 11/21/2017 05:20 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 16:47:29 +0100 > > Halil Pasic wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>> On Tue, 21 Nov

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

On 22.11.2017 09:10, Yu Ning wrote: > From: Yu Ning > > Following my announcement of the open source release of HAXM, > I was asked to write a blog post for normal Windows users to > advertise the use of "-accel hax": > >

[Qemu-devel] [PATCH v2 6/6] migration: Set the new port/address in the uri parameter

We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela --- migration/socket.c | 37 - 1 file changed, 32 insertions(+), 5

[Qemu-devel] [PATCH v2 3/6] migration: Create uri parameter

It will be used to store the uri migration parameter. Right now it is just the parameter code. Signed-off-by: Juan Quintela --- hmp.c | 7 +++ migration/migration.c | 13 + qapi/migration.json | 18 +++--- 3 files changed, 35

[Qemu-devel] [PATCH v2 0/6] Improve info migrate output on destination

Hi For v2: - dropped the qio patch, get the address later with qio_socket_get_local_address (danp) - set the uri with all the options (danp found it) - rebase on top of latest rc Please review. Later, Juan. [v1] This series (on top of my last pull requset) do: - Make update port for address

[Qemu-devel] [PATCH v2 1/6] migration: print features as on off

Once there, do one thing for line Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v1 07/12] target/arm: Decode aa32 armv8.1 two reg and a scalar

On 11/13/2017 06:05 PM, Alex Bennée wrote: >> -default: /* 14 and 15 are RESERVED */ >> +default: >> return 1; > > I think this should now be g_assert_not_reached() as we decode the whole > op space. That said it's tricky to follow in the mega

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

Peter Maydell wrote: > On 22 November 2017 at 08:41, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >> Author:

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 19:10:15 +0100 Christian Borntraeger wrote: > On 11/21/2017 05:06 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 15:45:17 +0100 > > Christian Borntraeger wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 12:18 PM, Halil Pasic wrote: The default css 0xFE is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally

Re: [Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid

On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 74 > +--- > 1 file changed, 46 insertions(+), 28 deletions(-) > > @@ -418,8

Re: [Qemu-devel] [PATCH v7 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. after transmitting the commands > Also update interrupts after reading out the interrupt status. > > Signed-off-by: Francisco

[Qemu-devel] [PATCH 02/17] qcow2: No persistent dirty bitmaps for compat=0.10

Persistent dirty bitmaps require a properly functioning autoclear_features field, or we cannot track when an unsupporting program might overwrite them. Therefore, we cannot support them for compat=0.10 images. Signed-off-by: Max Reitz --- block/qcow2-bitmap.c | 10 ++

[Qemu-devel] [PATCH 07/17] iotests: Forbid 020 for non-file protocols

This test does funny things like TEST_IMG="TEST_IMG.base" _make_test_img that usually only work with the file protocol. More specifically, they do not work with the most interesting non-file protocols, so we might as well skip this for anything but file. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

This series fixes the qemu-iotests for qcow, vmdk, qcow2 v2 and qcow2 v3 with refcount_bits=1. Patches 1 and 2 contain real fixes (not urgent, though, so no need to hurry for 2.11--we can take them into 2.11 if we want to, but there is no absolute need for them). Patches 3 and 4 add blkdebug

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as Kevin noted, read and write were using the QEMUIOVector in BlkRwCo. To avoid changes to the callers of blk_aio_ioctl(), I’ll change blk_aio_prwv() to

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

On Thu, 11/23 03:08, Max Reitz wrote: > (I hate to write Python tests because the boilerplate seems so large and > the debugging is so hard. But there is test 194 which shows that it is > possible to write simple bash-like tests as well--and that is how I > should probably write tests from now

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

On Wed, 11/22 21:43, Jeff Cody wrote: > On Thu, Nov 23, 2017 at 08:47:47AM +0800, Fam Zheng wrote: > > On Wed, 11/22 04:55, Jeff Cody wrote: > > > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > > >

Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

On 11/22/2017 03:26 PM, Christian Borntraeger wrote: > The QEMU ELF loader does not zero the bss segment. > This resulted in several bugs, e.g. see > > commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - > initialize css) > commit 6a40fa2669d3 (s390-ccw.img: Initialize

Re: [Qemu-devel] [PATCH v7 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support

On Mon, Nov 20, 2017 at 10:55:14AM +0100, Marc-André Lureau wrote: > Hi, > > This series adds DMA operations support to the qemu fw_cfg kernel > module and populates "etc/vmcoreinfo" with vmcoreinfo location > details. > > Note: the support for this entry handling has been merged for upcoming >

[Qemu-devel] [PATCH v2] rcu: reduce more than 7MB heap memory by malloc_trim()

Since there are some issues in memory alloc/free machenism in glibc for little chunk memory, if Qemu frequently alloc/free little chunk memory, the glibc doesn't alloc little chunk memory from free list of glibc and still allocate from OS, which make the heap size bigger and bigger. This patch

[Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an undefined value for flags. Right now this is unused, but we better play safe. The same is true for SET_IRQ_STATE. While QEMU is now fixed in that regard, we should make sure to not use the flag and pad fields in the kernel. A

[Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

The QEMU ELF loader does not zero the bss segment. This resulted in several bugs, e.g. see commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css) commit 6a40fa2669d3 (s390-ccw.img: Initialize next_idx) commit 8775d91a0f42 (pc-bios/s390-ccw: Fix problem with

Re: [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter

On 22.11.2017 15:26, Christian Borntraeger wrote: > valgrind pointed out that we call KVM_S390_GET_IRQ_STATE with an > undefined value for flags. Right now this is unused, but we > better play safe. > The same is true for SET_IRQ_STATE. While QEMU is now fixed in > that regard, we should make sure

  1   2   >