Re: [Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Hailiang Zhang
On 2017/12/2 2:37, Paolo Bonzini wrote: On 01/12/2017 18:45, Gonglei (Arei) wrote: I also think it's windows bug, the problem is that it doesn't occur on xen platform. It's a race, it may just be that RTC PIO is faster in Xen because it's implemented in the hypervisor. No, In Xen, it does

[Qemu-devel] [PATCH 1/1] main loop: remove useless code

2017-12-01 Thread FelixYao
hi Paolo Bonzini: Those codes seem useless, Could it be removed? Signed-off-by: FelixYao --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c index 1ad1c04..5bed4c2 100644 --- a/vl.c +++ b/vl.c @@ -2995,10 +2995,6 @@ static void

[Qemu-devel] [PATCH 0/3] Migration patches on queue for 2.12

2017-12-01 Thread Juan Quintela
Hi Sending them because my next series are on top of this ones. Later, Juan. Juan Quintela (3): migration: Use proper types in json migration: print features as on off migration: free addr in the same function that we created it hmp.c | 22 +-

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Michael S. Tsirkin
On Fri, Dec 01, 2017 at 09:02:30AM -0800, Prasad Singamsetty wrote: > > > On 11/30/2017 8:43 PM, Peter Xu wrote: > > On Thu, Nov 30, 2017 at 11:12:48AM -0800, Prasad Singamsetty wrote: > > > > > > > > > On 11/30/2017 10:56 AM, Michael S. Tsirkin wrote: > > > > On Thu, Nov 30, 2017 at

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-12-01 Thread Peter Xu
On Fri, Dec 01, 2017 at 11:02:50AM +1100, David Gibson wrote: > On Thu, Nov 30, 2017 at 02:17:21PM +0800, Peter Xu wrote: > > On Wed, Nov 29, 2017 at 07:46:22PM +1100, David Gibson wrote: > > > pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and > > > pci_register_bus() > > > are

[Qemu-devel] [PATCH 2/3] migration: print features as on off

2017-12-01 Thread Juan Quintela
Once there, do one thing for line Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 3/7] vhost: restore avail index from vring used index on disconnection

2017-12-01 Thread Michael S. Tsirkin
From: Maxime Coquelin vhost_virtqueue_stop() gets avail index value from the backend, except if the backend is not responding. It happens when the backend crashes, and in this case, internal state of the virtio queue is inconsistent, making packets to corrupt the

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

2017-12-01 Thread Alex Williamson
On Thu, 30 Nov 2017 15:43:08 +1100 Alexey Kardashevskiy wrote: > On 30/11/17 02:26, Alex Williamson wrote: > > On Wed, 22 Nov 2017 16:15:52 +1100 > > Alexey Kardashevskiy wrote: > > > >> The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU

[Qemu-devel] [PULL 5/7] vhost: fix error check in vhost_verify_ring_mappings()

2017-12-01 Thread Michael S. Tsirkin
From: Greg Kurz Since commit f1f9e6c5 "vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout", we check the mapping of each part (descriptor table, available ring and used ring) of each virtqueue separately. The checking of a part is done by the

Re: [Qemu-devel] [PATCH for-2.12] iotests: Make 200 run on tmpfs

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 04:59:42PM +0100, Max Reitz wrote: > 200 currently fails on tmpfs because it sets cache=none. However, > without that (and aio=native), the test still works now and it fails > before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So > we can probably remove

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-12-01 Thread Halil Pasic
On 11/30/2017 02:32 PM, Cornelia Huck wrote: > On Thu, 30 Nov 2017 13:32:12 +0100 > Halil Pasic wrote: > > (...) > > Before I spend way too much time on this: > > Is the proposed machine-property interface usable from a libvirt POV? > IOW, can we go with this now

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Prasad Singamsetty
On 11/30/2017 8:43 PM, Peter Xu wrote: On Thu, Nov 30, 2017 at 11:12:48AM -0800, Prasad Singamsetty wrote: On 11/30/2017 10:56 AM, Michael S. Tsirkin wrote: On Thu, Nov 30, 2017 at 10:33:50AM -0800, Prasad Singamsetty wrote: On 11/29/2017 7:25 PM, Peter Xu wrote: On Wed, Nov 29, 2017

[Qemu-devel] [PULL 4/7] dump-guest-memory.py: fix No symbol "vmcoreinfo_find"

2017-12-01 Thread Michael S. Tsirkin
From: Marc-André Lureau When qemu is compiled without debug, the dump gdb python script can fail with: Error occurred in Python command: No symbol "vmcoreinfo_find" in current context. Because vmcoreinfo_find() is inlined and not exported. Use the underlying

[Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-01 Thread Michael S. Tsirkin
The following changes since commit c11d61271b9e6e7a1f0479ef1ca8fb55fa457a62: Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH] firmware: Use PTR_ERR_OR_ZERO()

2017-12-01 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > >

[Qemu-devel] [PULL 2/7] virtio: Add queue interface to restore avail index from vring used index

2017-12-01 Thread Michael S. Tsirkin
From: Maxime Coquelin In case of backend crash, it is not possible to restore internal avail index from the backend value as vhost_get_vring_base callback fails. This patch provides a new interface to restore internal avail index from the vring used index, as done by

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Laurent Vivier
On 01/12/2017 19:30, Eric Blake wrote: > On 12/01/2017 06:58 AM, Juan Quintela wrote: >> Hi >> >> This is on top of my info_migrate series. > > Let patchew know about it: > > Based-on: <20171201125750.1372-1-quint...@redhat.com> > ([PATCH v3 0/2] Improve info migrate output on destination) Is

Re: [Qemu-devel] [PATCH 2/2] qcow2: fix indentation after previous patch

2017-12-01 Thread Eric Blake
On 11/30/2017 10:47 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 34 +- block/qcow2.c | 16 2 files changed, 25 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [PATCH 7/7] target/arm: Implement TT instruction

2017-12-01 Thread Peter Maydell
Implement the TT instruction which queries the security state and access permissions of a memory location. Signed-off-by: Peter Maydell --- target/arm/helper.h| 2 + target/arm/helper.c| 108 +

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/9] block: Remove unused bdrv_requests_pending

2017-12-01 Thread Alberto Garcia
On Wed 29 Nov 2017 03:49:48 PM CET, Fam Zheng wrote: > Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter

2017-12-01 Thread Eric Farman
Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing virtqueue size to be set.") introduced a new parameter to virtio-scsi. Later, commit 920036106044 ("vhost-user-scsi: add missing virtqueue_size param") added that parameter to the new vhost-user-scsi interface but neglected

[Qemu-devel] [PATCH 2/7] target/arm: Allow explicit writes to CONTROL.SPSEL in Handler mode

2017-12-01 Thread Peter Maydell
In ARMv7M the CPU ignores explicit writes to CONTROL.SPSEL in Handler mode. In v8M the behaviour is slightly different: writes to the bit are permitted but will have no effect. We've already done the hard work to handle the value in CONTROL.SPSEL being out of sync with what stack pointer is

Re: [Qemu-devel] [PULL 0/7] pc, pci, virtio: fixes for rc3

2017-12-01 Thread Peter Maydell
On 1 December 2017 at 17:08, Michael S. Tsirkin wrote: > The following changes since commit c11d61271b9e6e7a1f0479ef1ca8fb55fa457a62: > > Update version for v2.11.0-rc3 release (2017-11-29 17:59:34 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH 1/2] nvic: Make nvic_sysreg_ns_ops work with any MemoryRegion

2017-12-01 Thread Peter Maydell
Generalize nvic_sysreg_ns_ops so that we can pass it an arbitrary MemoryRegion which it will use as the underlying register implementation to apply the NS-alias behaviour to. We'll want this so we can do the same with systick. Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PATCH v1 1/2] intel-iommu: Redefine macros to enable supporting 48 bit address width

2017-12-01 Thread Prasad Singamsetty
On 12/1/2017 3:23 AM, Liu, Yi L wrote: On Tue, Nov 14, 2017 at 06:13:49PM -0500, prasad.singamse...@oracle.com wrote: From: Prasad Singamsetty The current implementation of Intel IOMMU code only supports 39 bits host/iova address width so number of macros use

[Qemu-devel] [PATCH 1/7] target/arm: Handle SPSEL and current stack being out of sync in MSP/PSP reads

2017-12-01 Thread Peter Maydell
For v8M it is possible for the CONTROL.SPSEL bit value and the current stack to be out of sync. This means we need to update the checks used in reads and writes of the PSP and MSP special registers to use v7m_using_psp() rather than directly checking the SPSEL bit in the control register.

[Qemu-devel] [PATCH 0/2] v8m: make systick banked

2017-12-01 Thread Peter Maydell
This patchset makes the systick device be banked between security states for ARM v8M. It is perhaps not the absolute cleanest way to implement this banking, but the alternative (which I had an irc discussion with Paolo about some weeks back) would involve adding a feature to our IOMMU abstraction

[Qemu-devel] [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Zhanghailiang
Hi, We hit a bug in our test while run PCMark 10 in a windows 7 VM, The VM got stuck and the wallclock was hang after several minutes running PCMark 10 in it. It is quite easily to reproduce the bug with the upstream KVM and Qemu. We found that KVM can not inject any RTC irq to VM after it was

Re: [Qemu-devel] [PATCH 1/2] nbd/server: add additional assert to nbd_export_put

2017-12-01 Thread Max Reitz
On 2017-11-09 16:40, Vladimir Sementsov-Ogievskiy wrote: > This place is not obvious, nbd_export_close may theoretically reduce > refcount to 0. It may happen if someone calls nbd_export_put on named > export not through nbd_export_set_name when refcount is 1. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v3 1/2] migration: Create tcp_port parameter

2017-12-01 Thread Eric Blake
On 12/01/2017 06:57 AM, Juan Quintela wrote: It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- @@ -2422,6 +2430,8 @@ static Property

[Qemu-devel] [PATCH for 2.11 0/1] Fix guest boot with vhost-scsi

2017-12-01 Thread Eric Farman
(Apologies for not noticing this earlier in the development cycle; I have been on leave and am just getting back.) A colleague of mine noticed an inability to start a guest with the 2.11 RC's, when a vhost-scsi device is defined in the guest. The symptoms on s390 are an exception loop in the

Re: [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-01 Thread Max Reitz
On 2017-11-09 15:16, Vladimir Sementsov-Ogievskiy wrote: > This is needed to implement image-fleecing scheme, when we create > a temporary node, mark our active node to be backing for the temp, > and start backup(sync=none) from active node to the temp node. > Temp node then represents a kind of

[Qemu-devel] [PATCH 0/7] armv8m: Implement TT, and other bugfixes

2017-12-01 Thread Peter Maydell
The main aim of this patchseries is to implement the new-for-v8M TT/TTT/TTA/TTAT instructions (which take an address and do an MPU/SAU lookup and tell you the security state and access permissions for the address). The first part of the series is some smaller bugfixes that I noticed along the

[Qemu-devel] [PATCH 3/7] target/arm: Add missing M profile case to regime_is_user()

2017-12-01 Thread Peter Maydell
When we added the ARMMMUIdx_MSUser MMU index we forgot to add it to the case statement in regime_is_user(), so we weren't treating it as unprivileged when doing MPU lookups. Correct the omission. Signed-off-by: Peter Maydell --- target/arm/helper.c | 1 + 1 file

Re: [Qemu-devel] [PATCH] qemu-pr-helper: miscellaneous fixes

2017-12-01 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > 1) Return a generic sense if TEST UNIT READY does not provide one; > > 2) Fix two mistakes in copying from the spec. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Paolo Bonzini Reviewed-by: Dr.

[Qemu-devel] [PATCH 4/7] target/arm: Split M profile MNegPri mmu index into user and priv

2017-12-01 Thread Peter Maydell
For M profile, we currently have an mmu index MNegPri for "requested execution priority negative". This fails to distinguish "requested execution priority negative, privileged" from "requested execution priority negative, usermode", but the two can return different results for MPU lookups. Fix

[Qemu-devel] [PATCH v3 2/6] tests: migration test deprecated commands

2017-12-01 Thread Juan Quintela
We now test the deprecated commands everytime that we test the new commands. This makes unnecesary to add tests for deprecated commands. Signed-off-by: Juan Quintela --- tests/migration-test.c | 32 1 file changed, 28 insertions(+), 4

[Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Juan Quintela
Hi This is on top of my info_migrate series. CHanges: - No more tests for deprecated parameters. Now I only use migrate_set_parameter. If there is a deprecated command for that, we tests it there. - free "result" string, always good to return memory (Peter found it) - use the new tcp_port

[Qemu-devel] [PATCH v3 4/6] tests: Add basic migration precopy tcp test

2017-12-01 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela --- tests/migration-test.c | 59 +++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 1/3] migration: Use proper types in json

2017-12-01 Thread Juan Quintela
We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. This change only happens for HMP. QMP always use bytes and similar. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- hmp.c

[Qemu-devel] [PATCH 3/3] migration: free addr in the same function that we created it

2017-12-01 Thread Juan Quintela
Otherwise, we can't use it after calling socket_start_incoming_migration Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/socket.c

Re: [Qemu-devel] [PATCH for-2.12] hmp-commands: Remove the deprecated usb_add and usb_del

2017-12-01 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > It's easy to use device_add and device_del as replacement instead. > The usb_add and usb_del commands are deprecated since QEMU 2.10, > and nobody complained that they are still needed, so let's get rid > of them now to make the HMP interface a little bit

[Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests

2017-12-01 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 51

[Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test

2017-12-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 51f49c74e9..3f3f056be6 100644 ---

[Qemu-devel] [PATCH v3 1/6] migration: free result string

2017-12-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reported-by: Peter Xu --- tests/migration-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index be598d3257..799e24ebc6 100644 ---

[Qemu-devel] [PATCH v1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding

2017-12-01 Thread Daniel Henrique Barboza
The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is thrown if any of those pre-requirements isn't met. This

Re: [Qemu-devel] [PATCH RFC 2/9] aio: Add drain begin/end API to AioContext

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 10:49:49PM +0800, Fam Zheng wrote: > diff --git a/util/async.c b/util/async.c > index 4dd9d95a9e..cca0efd263 100644 > --- a/util/async.c > +++ b/util/async.c > @@ -402,6 +402,7 @@ AioContext *aio_context_new(Error **errp) > AioContext *ctx; > > ctx = (AioContext

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 for-2.12 02/16] s390x/tcg: get rid of runtime_exception()

2017-12-01 Thread Richard Henderson
On 11/30/2017 03:56 PM, David Hildenbrand wrote: > On 30.11.2017 10:10, Thomas Huth wrote: >> On 29.11.2017 21:26, David Hildenbrand wrote: >>> Let's use s390_program_interrupt() instead. >>> >>> Reviewed-by: Richard Henderson >>> Signed-off-by: David Hildenbrand

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Stefan Hajnoczi
On Fri, Dec 01, 2017 at 06:16:44PM +0800, Fam Zheng wrote: > On Thu, 11/30 14:19, Stefan Hajnoczi wrote: > > On Thu, Nov 30, 2017 at 05:47:09PM +0800, Fam Zheng wrote: > > > On Wed, 11/29 12:00, Stefan Hajnoczi wrote: > > > > On Wed, Nov 29, 2017 at 11:55:02AM +0800, Fam Zheng wrote: > > > > > >

Re: [Qemu-devel] [PATCH RFC 3/9] blockjob: Implement AioContext drain ops

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 10:49:50PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockjob.c | 47 ++- > 1 file changed, 30 insertions(+), 17 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Prasad Singamsetty
On 11/29/2017 7:25 PM, Peter Xu wrote: On Wed, Nov 29, 2017 at 01:05:22PM -0800, Prasad Singamsetty wrote: Thanks Michael. Some comments below. On 11/28/2017 9:32 AM, Michael S. Tsirkin wrote: On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com wrote: From: Prasad

Re: [Qemu-devel] [PATCH v4 31/32] migration, qmp: new command "migrate-pause"

2017-12-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It is used to manually trigger the postcopy pause state. It works just > like when we found the migration stream failed during postcopy, but > provide an explicit way for user in case of misterious socket hangs. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-12-01 Thread Deepa Srinivasan
Kevin, Paolo, Stefan, Are there any further comments on this patch? Can this patch be committed? Thanks Deepa > On Nov 23, 2017, at 8:55 AM, Deepa Srinivasan > wrote: > > Starting qemu with the following arguments causes qemu to segfault: > ... -device

Re: [Qemu-devel] [PATCH 1/2] hmp: block qemu-io command for device without media

2017-12-01 Thread Stefan Hajnoczi
On Tue, Nov 28, 2017 at 03:10:54PM +0300, Denis V. Lunev wrote: > In this case blk->bs == NULL and the code will just crash. Emulate error > on that path. > > Signed-off-by: Denis V. Lunev > CC: "Dr. David Alan Gilbert" > CC: Kevin Wolf >

Re: [Qemu-devel] [PATCH v4 08/32] migration: allow send_rq to fail

2017-12-01 Thread Peter Xu
On Thu, Nov 30, 2017 at 12:13:57PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We will not allow failures to happen when sending data from destination > > to source via the return path. However it is possible that there can be > > errors along the way. This

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Paolo Bonzini
Just my 2 cents on the language topic, as in general I agree completely with Stefan. On 01/12/2017 15:08, Stefan Hajnoczi wrote: > Rust's threading model is 1:1. Besides mutexes it also has channels > (looks similar to Go and communicating sequential processes-style > channels). > > It is

Re: [Qemu-devel] [PATCH v4 16/20] vdi: Switch to .bdrv_co_block_status()

2017-12-01 Thread Eric Blake
On 11/30/2017 05:26 AM, Vladimir Sementsov-Ogievskiy wrote: 12.10.2017 21:59, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the vdi driver accordingly.  Note that the TODO is already covered (the block layer guarantees bounds of its

[Qemu-devel] [PULL 1/7] i386/msi: Correct mask of destination ID in MSI address

2017-12-01 Thread Michael S. Tsirkin
From: Chao Gao According to SDM 10.11.1, only [19:12] bits of MSI address are Destination ID, change the mask to avoid ambiguity for VT-d spec has used the bit 4 to indicate a remappable interrupt request. Signed-off-by: Chao Gao Signed-off-by: Lan

Re: [Qemu-devel] RFC: Let NBD client request read-only mode

2017-12-01 Thread Wouter Verhelst
On Thu, Nov 30, 2017 at 10:00:46AM -0600, Eric Blake wrote: > On 11/30/2017 09:32 AM, Wouter Verhelst wrote: > > > A client that wants to be read-only, but which does not see server support > > > (in idea 1, the server did not advertise the bit; in idea 2, the server > > > replies with

[Qemu-devel] [PULL 7/7] pc: fix crash on attempted cpu unplug

2017-12-01 Thread Michael S. Tsirkin
From: Igor Mammedov when qemu is started with '-no-acpi' CLI option, an attempt to unplug a CPU using device_del results in null pointer dereference at: #0 object_get_class #1 pc_machine_device_unplug_request_cb #2 qmp_marshal_device_del which is caused by

Re: [Qemu-devel] [PATCH-2.12 v1 2/3] xilinx_spis: Set all of the reset values

2017-12-01 Thread Alistair Francis
On Wed, Nov 29, 2017 at 2:03 PM, francisco iglesias wrote: > > > On 28 November 2017 at 23:31, Alistair Francis > wrote: > > Dear Alistair, > > There is a typo in the commit message: > s/xilinx_spis/xilinx_spips/ > >> Following the ZynqMP

Re: [Qemu-devel] [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Paolo Bonzini
On 01/12/2017 08:08, Gonglei (Arei) wrote: > First write to 0x70, cmos_index = 0xc & 0x7f = 0xc >    CPU 0/KVM-15566 kvm_pio: pio_write at 0x70 size 1 count 1 val 0xc> > Second write to 0x70, cmos_index = 0x86 & 0x7f = 0x6>    CPU 1/KVM-15567 > kvm_pio: pio_write at 0x70 size 1 count 1

Re: [Qemu-devel] /usr/bin/m4: internal error detected

2017-12-01 Thread Andreas Schwab
On Dez 01 2017, John Paul Adrian Glaubitz wrote: > This isn't a bug in m4 or anything architecture-specific, it's a regression > that was introduced by an upstream change in glibc [1] and mainly affects > qemu-user which we are using for m68k and sh4 [2]. It's a

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2017-12-01 Thread Eric Blake
On 12/01/2017 06:58 AM, Juan Quintela wrote: Hi This is on top of my info_migrate series. Let patchew know about it: Based-on: <20171201125750.1372-1-quint...@redhat.com> ([PATCH v3 0/2] Improve info migrate output on destination) -- Eric Blake, Principal Software Engineer Red Hat, Inc.

[Qemu-devel] [Bug 1735653] [NEW] qemu aarch64 cannot boot linux kernel v4.6+

2017-12-01 Thread Joey Jiao
Public bug reported: Hi, I tested the latest qemu-system-aarch64 cannot boot linux mainline kernel since v4.6 from https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. Environment info: # host ubuntu 16.04 # qemu Master branch from git://git.qemu.org/qemu.git, and now the HEAD

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: fix 197 for vpc

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 29, 2017 at 05:44:21PM -0500, John Snow wrote: > VPC has some difficulty creating geometries of particular size. > However, we can indeed force it to use a literal one, so let's > do that for the sake of test 197, which is testing some specific > offsets. > > Signed-off-by: John Snow

Re: [Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Paolo Bonzini
On 01/12/2017 18:45, Gonglei (Arei) wrote: > I also think it's windows bug, the problem is that it doesn't occur on > xen platform. It's a race, it may just be that RTC PIO is faster in Xen because it's implemented in the hypervisor. I will try reporting it to Microsoft. Thanks, Paolo >

Re: [Qemu-devel] [Bug 1735384] Re: OpenJDK JVM segfaults on qemu-sh4 (regression)

2017-12-01 Thread John Paul Adrian Glaubitz
The offending commit is: d25f2a72272b9ffe0d06710d6217d1169bc2cc7d is the first bad commit commit d25f2a72272b9ffe0d06710d6217d1169bc2cc7d Author: Alex Bennée Date: Mon Nov 13 13:55:27 2017 + accel/tcg/translate-all: expand cpu_restore_state addr check We

Re: [Qemu-devel] [PATCH v4 28/32] migration: allow migrate_incoming for paused VM

2017-12-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > migrate_incoming command is previously only used when we were providing > "-incoming defer" in the command line, to defer the incoming migration > channel creation. > > However there is similar requirement when we are paused during postcopy > migration. The

[Qemu-devel] [PATCH 6/7] target/arm: Factor MPU lookup code out of get_phys_addr_pmsav8()

2017-12-01 Thread Peter Maydell
For the TT instruction we're going to need to do an MPU lookup that also tells us which MPU region the access hit. This requires us to do the MPU lookup without first doing the SAU security access check, so pull the MPU lookup parts of get_phys_addr_pmsav8() out into their own function. The TT

[Qemu-devel] [PATCH 5/7] target/arm: Create new arm_v7m_mmu_idx_for_secstate_and_priv()

2017-12-01 Thread Peter Maydell
The TT instruction is going to need to look up the MMU index for a specified security and privilege state. Refactor the existing arm_v7m_mmu_idx_for_secstate() into a version that lets you specify the privilege state and one that uses the current state of the CPU. Signed-off-by: Peter Maydell

[Qemu-devel] [Bug 1735576] Re: Support more than 4G memory for guest with Intel HAXM acceleration

2017-12-01 Thread Hu Jun
update: according to haxm dev, they will submit a patch for qemu side of work; -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1735576 Title: Support more than 4G memory for guest with Intel HAXM

[Qemu-devel] [PATCH 2/3] s390x/css: advertise unrestricted cssids

2017-12-01 Thread Halil Pasic
Let us advertise the changes introduced by "s390x/css: unrestrict cssids" to the management software (so it can tell are cssids unrestricted or restricted). Signed-off-by: Halil Pasic --- Boris says having the property on the virtual-css-bridge is good form Libvirt

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-12-01 Thread John Paul Adrian Glaubitz
I have verified that this patch [1] in glibc_2.25 and glibc_2.26 fixes the assert. > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=22273 ** Bug watch added: Sourceware.org Bugzilla #22273 https://sourceware.org/bugzilla/show_bug.cgi?id=22273 -- You received this bug notification

Re: [Qemu-devel] [PATCH qemu v5 1/2] memory/iommu/vfio: Define add_vfio_group() callback

2017-12-01 Thread Alexey Kardashevskiy
On 01/12/17 10:09, Alex Williamson wrote: > On Fri, 1 Dec 2017 08:56:42 +1100 > Alexey Kardashevskiy wrote: > >> On 05/10/17 16:50, Alexey Kardashevskiy wrote: >>> The new callback will be called when a new VFIO IOMMU group is added. >>> >>> This should cause no behavioral

Re: [Qemu-devel] [PATCH v7 for-2.12 03/25] block: Add BDS.backing_overridden

2017-12-01 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:42 PM CET, Max Reitz wrote: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this in > bdrv_refresh_filename(). > > Adding a new field to the BDS is not nice, but it is very simple

[Qemu-devel] 答复: [BUG] Windows 7 got stuck easily while run PCMark10 application

2017-12-01 Thread Gonglei (Arei)
I also think it's windows bug, the problem is that it doesn't occur on xen platform. And there are some other works need to be done while reading REG_C. So I wrote that patch. Thanks, Gonglei 发件人:Paolo Bonzini 收件人:龚磊,张海亮,qemu-devel,Michael S. Tsirkin 抄送:黄伟栋,王欣,谢祥有 时间:2017-12-02 01:10:08 主题:Re:

Re: [Qemu-devel] [PATCH v7 for-2.12 04/25] iotests: Drop explicit base blockdev in 191

2017-12-01 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:43 PM CET, Max Reitz wrote: > Overriding the backing image should result in a json:{} pseudo-filename. > Then, you can no longer use the commit block job with filename > parameters. Therefore, do not explicitly add the base and override the > middle image in iotest 191,

Re: [Qemu-devel] [PATCH 19/25] spapr: add hcalls support for the XIVE interrupt mode

2017-12-01 Thread Cédric Le Goater
On 12/01/2017 05:01 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:49PM +0100, Cédric Le Goater wrote: >> A set of Hypervisor's call are used to configure the interrupt sources >> and the event/notification queues of the guest: >> >> - H_INT_GET_SOURCE_INFO >> >>used to obtain the

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2017-12-01 Thread Eric Blake
[adding Dan in cc] On 11/30/2017 10:47 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 7 +-- block/qcow2-refcount.c | 12 block/qcow2.c | 6 ++ 3 files changed, 23

Re: [Qemu-devel] [PATCH v18 05/10] xbitmap: add more operations

2017-12-01 Thread Matthew Wilcox
On Fri, Dec 01, 2017 at 03:09:08PM +, Wang, Wei W wrote: > On Friday, December 1, 2017 9:02 PM, Tetsuo Handa wrote: > > If start == end is legal, > > > >for (; start < end; start = (start | (IDA_BITMAP_BITS - 1)) + 1) { > > > > makes this loop do nothing because 10 < 10 is false. > >

[Qemu-devel] [PATCH] qemu-pr-helper: miscellaneous fixes

2017-12-01 Thread Paolo Bonzini
1) Return a generic sense if TEST UNIT READY does not provide one; 2) Fix two mistakes in copying from the spec. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- include/scsi/utils.h | 6 +- scsi/qemu-pr-helper.c | 30

[Qemu-devel] [PATCH v5 13/20] raw: Switch to .bdrv_co_block_status()

2017-12-01 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the raw driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- v5: no change v4: rebase to interface tweak v3: no change v2:

[Qemu-devel] [PATCH v5 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based

2017-12-01 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the allocmap (no semantic change). Callers that already had bytes available are simpler, and callers that now scale to bytes will be easier to switch to byte-based in

[Qemu-devel] [PATCH v5 18/20] vpc: Switch to .bdrv_co_block_status()

2017-12-01 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly. Drop the now-unused get_sector_offset(). Signed-off-by: Eric Blake --- v5: fix incorrect rounding in 'map' and bad loop condition [Vladimir] v4: rebase to

Re: [Qemu-devel] [PATCH v4 0/4] Convert to realize and improve error handling

2017-12-01 Thread Stefan Hajnoczi
On Wed, Nov 22, 2017 at 11:08:42AM +0800, Mao Zhongyi wrote: > This series mainly implements the conversions of ide, floppy and nvme > device to realize. Add some error handling messages and remove the local > variable local_err, use errp to propagate the error directly. Also > fix the unusual

[Qemu-devel] [PATCH v5 07/20] iscsi: Switch to .bdrv_co_block_status()

2017-12-01 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL map and file parameter, even though the block layer passes non-NULL values, because we also call the

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

2017-12-01 Thread Michael S. Tsirkin
On Thu, Nov 30, 2017 at 10:33:50AM -0800, Prasad Singamsetty wrote: > > > On 11/29/2017 7:25 PM, Peter Xu wrote: > > On Wed, Nov 29, 2017 at 01:05:22PM -0800, Prasad Singamsetty wrote: > > > Thanks Michael. Some comments below. > > > > > > On 11/28/2017 9:32 AM, Michael S. Tsirkin wrote: > > >

Re: [Qemu-devel] [PATCH v5 01/20] block: Add .bdrv_co_block_status() callback

2017-12-01 Thread Kevin Wolf
Am 01.12.2017 um 02:42 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Now that the block layer exposes byte-based allocation, > it's time to tackle the drivers. Add a new callback that operates > on as small as byte boundaries.

[Qemu-devel] [PATCH 1/3] s390x/css: unrestrict cssids

2017-12-01 Thread Halil Pasic
The default css 0xfe is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guests can exploit multiple channel subsystems. Since current guests don't do that, the pain of the partitioned (cssid)

Re: [Qemu-devel] [PATCH for-2.12] hmp-commands: Remove the deprecated usb_add and usb_del

2017-12-01 Thread Thomas Huth
On 30.11.2017 20:32, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> It's easy to use device_add and device_del as replacement instead. >> The usb_add and usb_del commands are deprecated since QEMU 2.10, >> and nobody complained that they are still needed, so let's get

[Qemu-devel] [PATCH 1/5] ppc/xics: introduce an icp_create() helper

2017-12-01 Thread Cédric Le Goater
The sPAPR and the PowerNV core objects create the interrupt presenter object of the CPUs in a very similar way. Let's provide a common routine in which we use the presenter 'type' as a child identifier. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH v4 00/32] Migration: postcopy failure recovery

2017-12-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Tree is pushed here for better reference and testing: > github.com/xzpeter postcopy-recovery-support Hi Peter, Do you have a git with this code + your OOB world in? I'd like to play with doing recovery and see what happens; I still worry a bit about

[Qemu-devel] [PATCH 2/5] ppc/xics: assign of the CPU 'intc' pointer under the core

2017-12-01 Thread Cédric Le Goater
The 'intc' pointer of the CPU references the interrupt presenter in the XICS interrupt mode. When the XIVE interrupt mode is available and activated, the machine will need to reassign this pointer to reflect the change. Moving this assignment under the realize routine of the CPU will ease the

Re: [Qemu-devel] [PATCH RFC 0/9] block: Rewrite block drain begin/end

2017-12-01 Thread Kevin Wolf
Am 01.12.2017 um 10:51 hat Fam Zheng geschrieben: > On Thu, 11/30 17:04, Paolo Bonzini wrote: > > On 30/11/2017 16:10, Kevin Wolf wrote: > > >> Yes, I agree, but that (using CoMutex around graph change) requires > > >> everything, especially the defer_to_main_loop_bh, runs in a coroutine > > >>

[Qemu-devel] [PATCH 4/5] spapr: introduce a spapr_irq_set_lsi() helper

2017-12-01 Thread Cédric Le Goater
It will make synchronisation easier with the XIVE interrupt mode when available. The 'irq' parameter refers to the global IRQ number space. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- Changes since initial XIVE patchset: -

Re: [Qemu-devel] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter model

2017-12-01 Thread David Gibson
On Thu, Nov 30, 2017 at 01:44:51PM +, Cédric Le Goater wrote: > On 11/30/2017 04:06 AM, David Gibson wrote: > > On Wed, Nov 29, 2017 at 10:55:34AM +0100, Cédric Le Goater wrote: > >> On 11/29/2017 06:11 AM, David Gibson wrote: > >>> On Thu, Nov 23, 2017 at 02:29:42PM +0100, Cédric Le Goater

Re: [Qemu-devel] [PATCH for-2.11] spapr: Include "pre-plugged" DIMMS in ram size calculation at reset

2017-12-01 Thread Greg Kurz
On Fri, 1 Dec 2017 16:41:25 +1100 David Gibson wrote: > At guest reset time, we allocate a hash page table (HPT) for the guest > based on the guest's RAM size. If dynamic HPT resizing is not available we > use the maximum RAM size, if it is we use the current RAM

Re: [Qemu-devel] [PATCH] block: Formats don't need CONSISTENT_READ with NO_IO

2017-12-01 Thread Eric Blake
On 11/30/2017 12:27 PM, Kevin Wolf wrote: @@ -1936,7 +1938,9 @@ void bdrv_format_default_perms(BlockDriverState *bs, BdrvChild *c, /* bs->file always needs to be consistent because of the metadata. We * can never allow other users to resize or write to it. */ -

Re: [Qemu-devel] [PATCH] block: Formats don't need CONSISTENT_READ with NO_IO

2017-12-01 Thread Kevin Wolf
Am 30.11.2017 um 20:05 hat Eric Blake geschrieben: > On 11/30/2017 12:27 PM, Kevin Wolf wrote: > > > > @@ -1936,7 +1938,9 @@ void bdrv_format_default_perms(BlockDriverState > > > > *bs, BdrvChild *c, > > > >/* bs->file always needs to be consistent because of the > > > > metadata. We

  1   2   3   >