[Qemu-devel] [PATCH v2 2/8] docker: do not display deprecated images in 'make docker' help

the 'debian' base image is deprecated since 3e11974988d8 Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v2 5/8] docker: warn users to use ubuntu16.04 for the LTS Xenial image

deprecate the generic 'ubuntu' image, but stay backward incompatible Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 3 ++- tests/docker/dockerfiles/ubuntu.docker | 26 ++

[Qemu-devel] [PATCH v2 0/8] docker: update Ubuntu and Fedora images, deprecate old ones

Hi, This series is to be clearer about which upstream version we are using. All "FROM distrib:latest" entries have now been removed and replaced by explicit "FROM distrib:version" ones. To keep backward compatibility, a warning is displayed to the user, suggesting which correct base image to

[Qemu-devel] [PATCH v2 1/8] docker: sort images list displayed by 'make docker'

we can now directly see different version sort consecutively. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

On 15.01.2018 13:00, BALATON Zoltan wrote: > On Mon, 15 Jan 2018, Thomas Huth wrote: >> ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset >> of ppcemb-softmmu. But since the config files are currently independent >> from each other, we missed to define some CONFIG switches in

Re: [Qemu-devel] [PATCH] ui: deprecate use of SDL 1.2 in favour of 2.0 series

On Mon, Jan 15, 2018 at 3:25 PM, Daniel P. Berrange wrote: > The SDL 2.0 release was made in Aug, 2013: > > https://www.libsdl.org/release/ > > That will soon be 4 + 1/2 years ago, which is enough time to consider > the 2.0 series widely supported. > > Thus we deprecate the

Re: [Qemu-devel] [PATCH 0/3] input: add keys and mouse buttons to virtio input

Hi, > Miika S (3): > input: add mouse side buttons to virtio input > input: virtio: don't send mouse wheel event twice Cherry-picked these two ad the kbd update depends on the not-yet merged keycodemapdb update for virtio-keyboard. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 3/8] docker: add the Ubuntu Trusty base image

On Mon, Jan 15, 2018 at 11:34:54AM -0300, Philippe Mathieu-Daudé wrote: > based on QEMU v2.10 ubuntu.docker (ca853f0c76e3 and 2346b12fc52d) > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/ubuntu14.04.docker | 17 + > 1 file changed, 17

[Qemu-devel] [PATCH v4 06/13] qapi: ensure stable sort ordering when checking QAPI entities

Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v4 12/13] travis: improve python version test coverage

Currently travis declares ancient python 2.4 is desired. Update that to 2.6 which is the oldest version any targetted distros still needs. If we just list a python 3 version at the top level this will double the number of travis jobs we run which is unreasonable. So arbitrarily pick the clang

Re: [Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python

On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > Python2 did not validate locale correctness when reading input data, so > would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so > if you try to read UTF-8 data in the C locale, it will raise an error > for any UTF-8 bytes that

[Qemu-devel] [PATCH v4 09/13] configure: allow use of python 3

Signed-off-by: Daniel P. Berrange --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b272a0336b..60b99f45f6 100755 --- a/configure +++ b/configure @@ -1598,9 +1598,8 @@ fi # Note that if the Python

Re: [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove

On 01/15/2018 08:40 AM, Vladimir Sementsov-Ogievskiy wrote: >> And the list archives show several threads of people complaining that >> ./check failing with a diff that merely shows: >> >> -. >> +..E.. > > didn't see that. usually, for failed iotests I see > > -. > +..E.. > > + some

[Qemu-devel] [PATCH] m25p80: prevent buffer overflow during erasing

memset is not checked, so it's possible to go beyond the storage. Add checks and truncate requested length. Signed-off-by: Aleksey Kuleshov --- hw/block/m25p80.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index

Re: [Qemu-devel] [PATCH v6 0/2] Convert apple related code to keycodemapdb

On Tue, Dec 12, 2017 at 02:24:58PM +, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02047.html > v2: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02471.html > v3:

[Qemu-devel] [PATCH v3 4/8] s390-ccw: interactive boot menu for eckd dasd (menu setup)

Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/iplb.h | 3 +++ pc-bios/s390-ccw/main.c | 21 +

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 01/15/2018 06:27 AM, Peter Maydell wrote: > (may be worth mentioning > in particular how "rIM" differs from "rINK" -- I think the answer is that > we want to say "valid-immediate OR (valid-if-inverted AND valid-if-negated)", > whereas 'rINK' is "valid-immediate OR valid-if-inverted OR

Re: [Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output

On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > When the qapi schema tests fail they merely print that the expected > output didn't match the actual output. This is largely useless when > trying diagnose what went wrong. Removing the '-q' arg to diff > means that it is still silent on

Re: [Qemu-devel] [PATCH v2 05/11] target/arm: Decode aa32 armv8.1 three same

On 18 December 2017 at 17:24, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 85 > +++--- > 1 file changed, 66 insertions(+), 19 deletions(-) >

[Qemu-devel] [PATCH] ui: deprecate use of SDL 1.2 in favour of 2.0 series

The SDL 2.0 release was made in Aug, 2013: https://www.libsdl.org/release/ That will soon be 4 + 1/2 years ago, which is enough time to consider the 2.0 series widely supported. Thus we deprecate the SDL 1.2 support, which will allow us to delete it in the last release of 2018. By this time,

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

On Mon, Jan 15, 2018 at 11:47 AM, Peter Maydell wrote: > On 15 January 2018 at 14:04, Philippe Mathieu-Daudé wrote: >> On 01/15/2018 10:51 AM, Peter Maydell wrote: >>> On 13 January 2018 at 05:07, Philippe Mathieu-Daudé wrote:

[Qemu-devel] [PATCH v3 2/2] sdl: reorganize -no-frame support

Drop no_frame flag from sdl_display_init argument list, use a global variable instead. This is temporary until -no-frame support is dropped altogether when we remove sdl1 support. Remove any traces of noframe from sdl2 code. It is just dead code as sdl2 doesn't support the SDL_NOFRAME window

[Qemu-devel] [PATCH v3 0/2] sdl: hotkey updates and cleanups

Gerd Hoffmann (2): sdl: use ctrl-alt-g as grab hotkey sdl: reorganize -no-frame support include/sysemu/sysemu.h | 1 + include/ui/console.h| 5 ++--- ui/sdl.c| 39 --- ui/sdl2.c | 34 --

[Qemu-devel] [PATCH v3 1/2] sdl: use ctrl-alt-g as grab hotkey

Be consistent with gtk and cocoa. Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 30 +- ui/sdl2.c | 27 +++ 2 files changed, 24 insertions(+), 33 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 7b71a9ac58..9c664c86a0

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 15 January 2018 at 16:18, Richard Henderson wrote: > On 01/15/2018 06:27 AM, Peter Maydell wrote: >> The code looks OK to me. I'm guessing the sparc guest failure is >> just because we now generate more code for some of the comparison >> cases and that doesn't fit in the

Re: [Qemu-devel] [PATCH v2 6/8] docker: add the Fedora 27 base image

On Mon, Jan 15, 2018 at 11:34:57AM -0300, Philippe Mathieu-Daudé wrote: > straight copy on Fedora 25 base. > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/fedora27.docker | 18 ++ > 1

Re: [Qemu-devel] [PATCH] hw/pci-bridge: fix QEMU crash because of pcie-root-port

On 15/01/2018 17:54, Laszlo Ersek wrote: On 01/10/18 20:09, Marcel Apfelbaum wrote: If we try to use more pcie_root_ports then available slots and an IO hint is passed to the port, QEMU crashes because we try to init the "IO hint" capability even if the device is not created. Fix it by checking

Re: [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

On 01/15/2018 10:44 AM, Collin L. Walling wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > atoi > > Added non-C standard function: > itostr > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

On Wed, Jan 10, 2018 at 08:25:50PM +, Stefan Hajnoczi wrote: > This series improves the tracetool error messages to make them more > user-friendly. > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" >

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

On Mon, Jan 15, 2018 at 03:07:15PM +0100, Kevin Wolf wrote: > Am 15.01.2018 um 14:51 hat Daniel P. Berrange geschrieben: > > On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > > > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > > > On Thu, Jan 11, 2018 at 08:52:17PM

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Mon, Jan 15, 2018 at 03:25:18PM +0100, Jiri Denemark wrote: > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > CCing libvirt developers. > ... > > This case is slightly more problematic, however: the new feature > > is actually migratable (under very controlled circumstances)

Re: [Qemu-devel] [RFC PATCH 2/3] acpi: implement aml_lless_equal

On Fri, 12 Jan 2018 14:42:14 -0500 Stefan Berger wrote: > On 01/12/2018 10:17 AM, Marc-André Lureau wrote: > > 2018-01-10 19:35 GMT+01:00 Stefan Berger : > >> LLessEqualOp = LNotOp LGreaterOp > >> > >> Signed-off-by: Stefan Berger

Re: [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI

On 01/12/2018 09:55 AM, Marc-André Lureau wrote: Hi On Wed, Jan 10, 2018 at 7:35 PM, Stefan Berger wrote: } static void tpm_tis_class_init(ObjectClass *klass, void *data) diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h index 6d516c6..d9b7452 100644

Re: [Qemu-devel] [PATCH v6 4/4] hw: convert XenInput keyboard to keycodemapdb

On Fri, Dec 15, 2017 at 09:33:24AM +, Daniel P. Berrange wrote: > On Wed, Dec 13, 2017 at 03:01:51PM +, Anthony PERARD wrote: > > On Tue, Dec 12, 2017 at 02:10:44PM +, Daniel P. Berrange wrote: > > > Replace the scancode2linux table with an automatically > > > generated table. In doing

Re: [Qemu-devel] [PATCH v3 0/8] Interactive Boot Menu for DASD and SCSI Guests on s390x

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1516034665-27606-1-git-send-email-wall...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v3 0/8] Interactive Boot Menu for DASD and SCSI Guests on s390x === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input

On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > From: Miika S > > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > Signed-off-by: Miika S > --- > hw/input/virtio-input-hid.c | 7 +++ > qapi/ui.json| 5

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 01/15/2018 06:27 AM, Peter Maydell wrote: > We could avoid the annoying "load LE/GE immediates to tempreg" > extra code by having tcg_out_cmp2() return a flag to tell > the caller which way round to put the conditions for its two > conditional ARITH_MOV insns (for setcond2) or which condition >

Re: [Qemu-devel] [PATCH v5 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

Am 05.12.2017 um 14:35 hat Daniel Henrique Barboza geschrieben: > This patch implements a test case for the scenario that was failing > prior to the patch "migration/ram.c: do not set 'postcopy_running' in > POSTCOPY_INCOMING_END", commit acab30b85d. > > This new test file 201 was derived from

[Qemu-devel] [PATCH v2 7/8] docker: warn users to use newer fedora25/fedora27 base image

deprecate the generic 'fedora' image, but stay backward incompatible Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include| 3 ++- tests/docker/dockerfiles/fedora.docker | 29 -

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

On 15/01/2018 16:17, Philippe Mathieu-Daudé wrote: > > The only 2 properties specific to sysbus are: > > static Property sdhci_sysbus_properties[] = { > DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState, pending_insert_quirk, > false), > DEFINE_PROP_LINK("dma",

[Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling Acked-by: Christian

[Qemu-devel] [PATCH v3 6/8] s390-ccw: interactive boot menu for eckd dasd (print menu)

Prints the menu data starting from the zIPL menu banner. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 3 +-- pc-bios/s390-ccw/menu.c| 42 ++ pc-bios/s390-ccw/menu.h| 1 + 3 files changed, 44

[Qemu-devel] [PATCH v1 1/1] s390x: fix storage attributes migration for non-small guests

Fix storage attribute migration so that it does not fail for guests with more than a few GB of RAM. Migration itself was successful, but storage attributes were not migrated completely. This patch fixes the migration of all storage attributes, even when the guest have large amounts of memory.

[Qemu-devel] [PATCH v3 8/8] s390-ccw: interactive boot menu for scsi

Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling ---

[Qemu-devel] [PATCH v4 08/13] scripts: ensure signrom treats data as bytes

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- scripts/signrom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index d1dabe0240..0497a1c32e 100644 ---

[Qemu-devel] [PATCH v4 13/13] docker: change Fedora images to run with python3

Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python

On Mon, Jan 15, 2018 at 11:15:01AM -0600, Eric Blake wrote: > On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > > Python2 did not validate locale correctness when reading input data, so > > would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so > > if you try to read UTF-8 data

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 01/15/2018 09:31 AM, Richard Henderson wrote: > But we can't *not* swap the arguments to the generated comparison. Otherwise > we're computing the wrong thing. Bah. I have of course forgotten about the RSC instruction, which takes an immediate. Will fix. r~

[Qemu-devel] [PATCH v2 2/2] sdl: reorganize -no-frame support

Drop no_frame flag from sdl_display_init argument list, use a global variable instead. This is temporary until -no-frame support is dropped altogether when we remove sdl1 support. Remove any traces of noframe from sdl2 code. It is just dead code as sdl2 doesn't support the SDL_NOFRAME window

Re: [Qemu-devel] [PATCH v6 0/4] Convert frontends to use keycodemapdb

On Tue, Dec 12, 2017 at 02:04:55PM +, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02047.html > v2: https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg02471.html > v3:

Re: [Qemu-devel] [PATCH 0/3] input: add keys and mouse buttons to virtio input

On Mon, Jan 15, 2018 at 04:18:53PM +0100, Gerd Hoffmann wrote: > Hi, > > > Miika S (3): > > input: add mouse side buttons to virtio input > > input: virtio: don't send mouse wheel event twice > > Cherry-picked these two ad the kbd update depends on the not-yet merged > keycodemapdb update

Re: [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben: > Multiboot may load section headers and all sections (even those that are > not part of any segment) to target memory. > > Tested with an ELF application that uses data from strings table > section. > > Signed-off-by: Anatol Pomozov

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 01/15/2018 06:27 AM, Peter Maydell wrote: > On 10 January 2018 at 05:39, Richard Henderson wrote: >> The code sequence we were generating was only good for unsigned >> comparisons. For signed comparisions, use the sequence from gcc. >> >> Fixes booting of ppc64 firmware,

[Qemu-devel] [PATCH v3 3/8] s390-ccw: parse and set boot menu options

Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. A loadparm

[Qemu-devel] [PATCH v3 2/8] s390-ccw: ipl structs for eckd cdl/ldl

ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Also introduce structs for IPL stages 1 and 1b and for disk geometry.

[Qemu-devel] [PATCH v3 0/8] Interactive Boot Menu for DASD and SCSI Guests on s390x

--- [v3] --- In an effort to make review less overwhelming, I've split up the larger commit into 4 patches. It should be obvious how they all relate. This is for review purposes unless it makes sense to keep them this way. Patch "read input" contains the original commit message. bootmap.c

[Qemu-devel] [PATCH v3 7/8] s390-ccw: interactive boot menu for eckd dasd (read input)

When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default

[Qemu-devel] [PATCH v3 5/8] s390-ccw: interactive boot menu for eckd dasd (read stage2 data)

Read the stage2 boot loader data block-by-block. We scan the current block for the string "zIPL" to detect the start of the boot menu banner. We then load the adjacent blocks (previous block and next block) to account for the possibility of menu data spanning multiple blocks. Signed-off-by:

[Qemu-devel] [PATCH v4 00/13] Support building with py2 or py3

This is an update for my previously posted series: v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html This series enables some level of CI testing for py3 so that our CI jobs will get coverage of both py2 and py3 builds to avoid bitrot. I did a test travis build with py

[Qemu-devel] [PATCH v4 02/13] qapi: Use OrderedDict from standard library if available

The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file

[Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input

From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12

[Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output

When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful tests, but when it fails we'll see details of the

Re: [Qemu-devel] [PATCH v2 01/11] target/arm: Add ARM_FEATURE_V8_1_SIMD

On 18 December 2017 at 17:24, Richard Henderson wrote: > Enable it for the "any" CPU used by *-linux-user. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 1 + >

Re: [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target

Ping for code review? -- Happy hacking, ~ Luke Shumaker

[Qemu-devel] [PATCH v2 1/2] sdl: use ctrl-alt-g as grab hotkey

Be consistent with gtk and cocoa. Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 30 +- ui/sdl2.c | 27 +++ 2 files changed, 24 insertions(+), 33 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 7b71a9ac58..9c664c86a0

[Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups

Gerd Hoffmann (2): sdl: use ctrl-alt-g as grab hotkey sdl: reorganize -no-frame support include/sysemu/sysemu.h | 1 + include/ui/console.h| 5 ++--- ui/sdl.c| 38 +++--- ui/sdl2.c | 34 --

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > CCing libvirt developers. ... > This case is slightly more problematic, however: the new feature > is actually migratable (under very controlled circumstances) > because of patch 2/2, but it is not migration-safe[1]. This > means

Re: [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove

12.01.2018 19:54, Eric Blake wrote: On 01/12/2018 05:43 AM, Vladimir Sementsov-Ogievskiy wrote: +++ b/tests/qemu-iotests/201.out @@ -0,0 +1,5 @@ +... +-- +Ran 7 tests I'm not a fan of python tests that are difficult to

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

On 15 January 2018 at 14:04, Philippe Mathieu-Daudé wrote: > On 01/15/2018 10:51 AM, Peter Maydell wrote: >> On 13 January 2018 at 05:07, Philippe Mathieu-Daudé wrote: >>> Since v6: >>> - addressed Peter reviews >>> - do not use an unique Property[] for both

Re: [Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180115141759.11857-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 2/4] multiboot: load any machine type of ELF

Am 16.10.2017 um 20:38 hat Anatol Pomozov geschrieben: > Hi > > On Mon, Oct 16, 2017 at 1:27 AM, Kevin Wolf wrote: > > Am 14.10.2017 um 15:41 hat Peter Maydell geschrieben: > >> On 14 October 2017 at 00:21, Eduardo Habkost wrote: > >> > I don't believe the

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

On 01/12/2018 03:47 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.01.2018 22:52, Eric Blake wrote: >> On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Add command for export removing. It is needed for cases when we >>> don't want to keep export after the operation on it was

Re: [Qemu-devel] [PULL 00/27] Migration pull

3: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2018-01-15 10:39:29 +) > > are available in the Git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20180115 > > for you to fetch changes up to

Re: [Qemu-devel] [PATCH v2 6/8] docker: add the Fedora 27 base image

On 01/15/2018 01:27 PM, Daniel P. Berrange wrote: > On Mon, Jan 15, 2018 at 11:34:57AM -0300, Philippe Mathieu-Daudé wrote: >> straight copy on Fedora 25 base. >> >> Suggested-by: Paolo Bonzini >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>

[Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'maketrans' function in py3

Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514cca44bf..1fdd189c0d 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1734,7 +1734,10 @@ def

[Qemu-devel] [PATCH v4 11/13] ui: update keycodemapdb to get py3 fixes

Signed-off-by: Daniel P. Berrange --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject commit

Re: [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

On 01/15/2018 12:05 PM, Eric Blake wrote: On 01/15/2018 10:44 AM, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

On 15.01.2018 14:01, Peter Maydell wrote: > On 15 January 2018 at 09:30, Thomas Huth wrote: >> (off-topic question: Do we still need a separate ppcemb-softmmu nowadays? >> It seemed to be useful 10 years ago when everybody was doing KVM on >> embedded PPC, but these days seem to

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben: > Using C structs makes the code more readable and prevents type conversion > errors. > > Borrow multiboot1 header from GRUB project. > > Signed-off-by: Anatol Pomozov > --- > hw/i386/multiboot.c | 124

Re: [Qemu-devel] [PATCH v5 08/15] qcow2: skip writing zero buffers to empty COW areas

On Wed 01 Nov 2017 04:44:01 PM CET, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing image, > efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole > cluster instead of writing explicit zero buffers later in perform_cow(). > >

[Qemu-devel] [PATCH v4 01/13] qapi: use items()/values() intead of iteritems()/itervalues()

The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over efficiency is a net win. Reviewed-by: Philippe

[Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python

Python2 did not validate locale correctness when reading input data, so would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so if you try to read UTF-8 data in the C locale, it will raise an error for any UTF-8 bytes that aren't representable in 7-bit ascii encoding. e.g.

Re: [Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'maketrans' function in py3

On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > scripts/qapi.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index

Re: [Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

Le 2018-01-15 14:45, Jean-Christophe Dubois a écrit : Le 2018-01-15 12:09, Fabien Chouteau a écrit : On 12/01/2018 15:10, Jean-Christophe Dubois wrote: Le 2018-01-12 11:55, Fabien Chouteau a écrit : On 11/01/2018 13:35, Jean-Christophe Dubois wrote: Thanks Fabien, Now, as a side question,

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

On 15.01.2018 08:40, Jason Wang wrote: > > On 2018年01月10日 22:32, Thomas Huth wrote: >> QEMU can emulate hubs to connect NICs and netdevs. This is currently >> primarily used for the mis-named 'vlan' feature of the networking >> subsystem. Now the 'vlan' feature has been marked as deprecated,

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

On 10 January 2018 at 05:39, Richard Henderson wrote: > The code sequence we were generating was only good for unsigned > comparisons. For signed comparisions, use the sequence from gcc. > > Fixes booting of ppc64 firmware, with a patch changing the code > sequence for ppc

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

On 15.01.2018 12:05, Greg Kurz wrote: > On Mon, 15 Jan 2018 10:30:53 +0100 > Thomas Huth wrote: > >> ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset > > Hi Thomas, > > Per curiosity. I understand that a 64-bit ppc CPU is expected to support > 32-bit ppc

[Qemu-devel] [PATCH v2 4/8] docker: do not use Trusty APT source in Xenial

probably missed in 7fc581c29518 Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/ubuntu.docker | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker index dabbf2a8a4..686d90ae8c

[Qemu-devel] [PATCH v2 8/8] docker: fix typo

Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 950ef51d35..a833c68cd8 100644 --- a/tests/docker/Makefile.include +++

[Qemu-devel] [PATCH v2 3/8] docker: add the Ubuntu Trusty base image

based on QEMU v2.10 ubuntu.docker (ca853f0c76e3 and 2346b12fc52d) Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/ubuntu14.04.docker | 17 + 1 file changed, 17 insertions(+) create mode 100644 tests/docker/dockerfiles/ubuntu14.04.docker diff

[Qemu-devel] [PATCH v2 6/8] docker: add the Fedora 27 base image

straight copy on Fedora 25 base. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/fedora27.docker | 18 ++ 1 file changed, 18 insertions(+) create mode 100644

Re: [Qemu-devel] [PATCH v5 07/15] qcow2: move is_zero() up

On Wed 01 Nov 2017 04:44:00 PM CET, Anton Nefedov wrote: > To be used in the following commit without a forward declaration. > > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] hw/pci-bridge: fix QEMU crash because of pcie-root-port

On 01/10/18 20:09, Marcel Apfelbaum wrote: > If we try to use more pcie_root_ports then available slots > and an IO hint is passed to the port, QEMU crashes because > we try to init the "IO hint" capability even if the device > is not created. > Fix it by checking for error before adding the

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

On Mon, Jan 15, 2018 at 1:22 PM, Paolo Bonzini wrote: > On 15/01/2018 16:17, Philippe Mathieu-Daudé wrote: >> >> The only 2 properties specific to sysbus are: >> >> static Property sdhci_sysbus_properties[] = { >> DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState, >>

[Qemu-devel] [PATCH v4 03/13] qapi: adapt to moved location of StringIO module in py3

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514b7bb5a4..514cca44bf 100644 --- a/scripts/qapi.py

Re: [Qemu-devel] [PATCH v2 03/11] target/arm: Decode aa64 armv8.1 three same extra

On 18 December 2017 at 17:24, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper.h | 9 + > target/arm/advsimd_helper.c | 74 >

Re: [Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input

On Mon, Jan 15, 2018 at 11:17:15AM -0600, Eric Blake wrote: > On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > > From: Miika S > > > > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > > > Signed-off-by: Miika S > > --- > >

Re: [Qemu-devel] [PATCH v2 2/7] target/m68k: add MC68040 MMU

On 01/12/2018 04:43 PM, Laurent Vivier wrote: > +ret = get_physical_address(>env, , , > + address, access_type, _size); > +if (ret == 0) { > +tlb_set_page(cs, address & -page_size, > + physical & -page_size, > +

[Qemu-devel] [Bug 1743441] Re: OS/2 Warp 4.52 OS2LVM failure

** Description changed: - When I try to boot OS/2 Warp 4.51 (Merlin), 4.52 (Aurora) or eCS 1.2.5, etc. I always get an exception in OS2LVM (TRAP 000E). You can reproduce the bug using this disk image: https://drive.google.com/open?id=1zzjs9hTS0TK-Xb5hnon8SQ-2C1EmlYfy + When I try to boot OS/2

  1   2   3   4   5   >