[Qemu-devel] [PATCH 1/3] header sync

2018-01-17 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread David Hildenbrand
On 17.01.2018 15:18, Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host kernel support for this feature. Actually

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

2018-01-17 Thread Eric Blake
On 01/17/2018 08:39 AM, Daniel P. Berrange wrote: >>> >>> GCC may or may not warn you about passing NULL for the 'bar' >>> parameter, but it will none the less assume nothing passes >>> NULL, and thus remove the 'if (!bar)' conditional during >>> optimization. IOW, adding nonnull annotations can

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180117145029.28736-1-tournier.e...@gmail.com Subject: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH 02/24] alpha: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. With the later in mind set it to 'ev67', which is

[Qemu-devel] [PATCH 01/24] arm: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to replace a bunch of ifdefs *-user/main.c that set default cpu_model with cpu type. With the later in mind set it to

[Qemu-devel] [PATCH 07/24] mips: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Take defaults types from linux-user and use them as

[Qemu-devel] [PATCH 11/24] ppc: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Use default values from linux-user for

[Qemu-devel] [PATCH 14/24] sparc: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Use default values from linux-user for

[Qemu-devel] [PATCH 16/24] unicore32: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Use default value from linux-user for

[Qemu-devel] [PATCH 23/24] nios2: 10m50_devboard: replace cpu_model with cpu_type

2018-01-17 Thread Igor Mammedov
use cpu_create() instead of being removed cpu_generic_init() Signed-off-by: Igor Mammedov --- CC: Chris Wulff CC: Marek Vasut --- hw/nios2/10m50_devboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 13/24] sh4: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Use default value from linux-user for

[Qemu-devel] [PATCH 19/24] tilegx: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
It will be used to drop a bunch of ifdefs *-user/main.c that set default cpu_model in favor of using type names directly. For tilegx, *-user defaulted to bogus 'any', however tilegx_cpu_class_by_name() is ignoring invalid values and always returns TYPE_TILEGX_CPU, so use it for

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Andrey Smirnov
On Wed, Jan 17, 2018 at 7:23 AM, Marcel Apfelbaum wrote: > > Hi Peter, > > > On 16/01/2018 16:34, Peter Maydell wrote: >> >> On 16 January 2018 at 01:37, Andrey Smirnov >> wrote: >>> >>> Add code needed to get a functional PCI subsytem when

Re: [Qemu-devel] [PATCH v2 16/32] qcow2: Update l2_allocate() to support L2 slices

2018-01-17 Thread Alberto Garcia
On Wed 17 Jan 2018 05:06:04 PM CET, Eric Blake wrote: /* allocate a new entry in the l2 cache */ +slice_size = s->l2_slice_size * sizeof(uint64_t); >>> >>> Would this read any better if the earlier patch named it >>> s->l2_slice_entries? >> >> I had doubts with this.

[Qemu-devel] [PATCH v10.5 02/20] tcg: Add types and basic operations for host vectors

2018-01-17 Thread Richard Henderson
Nothing uses or enables them yet. Signed-off-by: Richard Henderson --- Makefile.target | 4 +- tcg/tcg-op.h | 30 + tcg/tcg-opc.h| 26 tcg/tcg.h| 56 + tcg/tcg-op-vec.c | 362

[Qemu-devel] [PATCH v10.5 07/20] tcg: Add generic vector ops for multiplication

2018-01-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 5 + tcg/tcg-op-gvec.h| 2 ++ tcg/tcg-op.h | 1 + tcg/tcg-opc.h| 1 + tcg/tcg.h| 1 + accel/tcg/tcg-runtime-gvec.c | 44

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread David Hildenbrand
>> And exactly for this reason I tend to nack patch nr 3 (if that is of any >> weight :) ). > > I have communicated the mistake to asll relevant parties - it will not happen > again > (famous last words). An I already saw it happen in the past. (I think I really have to dig out that one

[Qemu-devel] [PATCH 09/24] nios2: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. For the later default is set to bogus 'any', and

[Qemu-devel] [PATCH 24/24] cpu: get rid of cpu_generic_init()

2018-01-17 Thread Igor Mammedov
There aren't any users of the helper left, remove it. Signed-off-by: Igor Mammedov --- CC: Richard Henderson CC: "Emilio G. Cota" CC: Paolo Bonzini CC: Eduardo Habkost CC: "Alex

Re: [Qemu-devel] [PATCH v2 16/32] qcow2: Update l2_allocate() to support L2 slices

2018-01-17 Thread Eric Blake
On 01/17/2018 09:55 AM, Alberto Garcia wrote: > On Tue 16 Jan 2018 11:26:40 PM CET, Eric Blake wrote: >>> /* allocate a new entry in the l2 cache */ >>> >>> +slice_size = s->l2_slice_size * sizeof(uint64_t); >> >> Would this read any better if the earlier patch named it >>

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Marcel Apfelbaum
On 17/01/2018 18:12, Andrey Smirnov wrote: On Wed, Jan 17, 2018 at 7:23 AM, Marcel Apfelbaum wrote: Hi Peter, On 16/01/2018 16:34, Peter Maydell wrote: On 16 January 2018 at 01:37, Andrey Smirnov wrote: Add code needed to get a

Re: [Qemu-devel] [PATCH v2] iotests: Make 200 run on tmpfs

2018-01-17 Thread Jeff Cody
On Wed, Jan 17, 2018 at 02:50:15PM +0100, Max Reitz wrote: > 200 currently fails on tmpfs because it sets cache=none. However, > without that (and aio=native), the test still works now and it fails > before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So > we can probably remove

[Qemu-devel] [PULL 0/1] Dump patches

2018-01-17 Thread Marc-André Lureau
The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into staging (2018-01-16 17:36:39 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/dump-pull-request for

Re: [Qemu-devel] [PATCH v2 4/6] qmp: transaction support for block-dirty-bitmap-enable/disable

2018-01-17 Thread Vladimir Sementsov-Ogievskiy
16.01.2018 15:54, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/transaction.json | 4 +++ blockdev.c| 79 +++ 2 files changed, 83 insertions(+) diff --git

Re: [Qemu-devel] [RFC PATCH 0/3] add QEMU_WARN_NONNULL_ARGS() macro

2018-01-17 Thread Eric Blake
On 01/17/2018 09:36 AM, Richard Henderson wrote: > On 01/17/2018 05:18 AM, Philippe Mathieu-Daudé wrote: >> BTW another useful macro for the static analizer I used is: >> >> #define QEMU_FALLTHROUGH __attribute__((fallthrough)) >> >> It replaces the /* fall through */ comment, i.e.: > >

[Qemu-devel] [PATCH 05/24] m68k: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. With the later in mind set it to 'any', which is

[Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Igor Mammedov
Series is finishing work on generalizing cpu_model parsing and limiting parts that deal with inconsistent cpu_model naming to "-cpu" CLI option processing in vl.c/*-user.main.c and FOO_cpu_class_by_name() callbacks. It introduces TARGET_DEFAULT_CPU_TYPE which must be defined by each target and is

[Qemu-devel] [PATCH 03/24] cris: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. With the later in mind set it to 'crisv32', which is

[Qemu-devel] [PATCH 08/24] moxie: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. With the later in mind set it to 'any', which is

[Qemu-devel] [PATCH v10.5 03/20] tcg: Standardize integral arguments to expanders

2018-01-17 Thread Richard Henderson
Some functions use intN_t arguments, some use uintN_t, some just used "unsigned". To aid putting function pointers in tables, we need consistency. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 16 tcg/tcg-op.c | 42

[Qemu-devel] [PULL 1/1] dump-guest-memory.py: fix python 2 support

2018-01-17 Thread Marc-André Lureau
Python GDB support may use Python 2 or 3. Inferior.read_memory() may return a buffer with Python 2 or a memoryview with Python 3 (see also https://sourceware.org/gdb/onlinedocs/gdb/Inferiors-In-Python.html) The elf.add_vmcoreinfo_note() method expect a byte string, but Python 2 buffer doesn't

[Qemu-devel] [RFC 2/2] sdl2: gles option will create a gles context

2018-01-17 Thread Elie Tournier
Create an OpenGL ES context if the option `-display sdl,gles=on` is set. Signed-off-by: Elie Tournier --- include/sysemu/sysemu.h | 1 + include/ui/sdl2.h | 1 + ui/sdl2-gl.c| 8 ++-- ui/sdl2.c | 7 +++ vl.c

[Qemu-devel] [RFC 1/2] sdl2: Add gles options

2018-01-17 Thread Elie Tournier
This commit add an option to the sdl display: `-display sdl,gles=on` This will allow the user to create an OpenGL ES context. Signed-off-by: Elie Tournier --- qemu-options.hx | 5 - ui/sdl2.c | 1 + vl.c| 11 ++- 3 files changed, 15

Re: [Qemu-devel] [RFC PATCH 0/3] add QEMU_WARN_NONNULL_ARGS() macro

2018-01-17 Thread Richard Henderson
On 01/17/2018 05:18 AM, Philippe Mathieu-Daudé wrote: > BTW another useful macro for the static analizer I used is: > > #define QEMU_FALLTHROUGH __attribute__((fallthrough)) > > It replaces the /* fall through */ comment, i.e.: That's unfortunate. Does it help if you use the actual lint

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix python 2 support

2018-01-17 Thread Marc-André Lureau
Hi On Wed, Jan 17, 2018 at 3:59 PM, Eric Blake wrote: > On 01/17/2018 08:18 AM, Laszlo Ersek wrote: >> On 01/17/18 12:44, Marc-André Lureau wrote: >>> Python GDB support may use Python 2 or 3. >>> >>> Inferior.read_memory() may return a buffer with Python 2 or a >>> memoryview

Re: [Qemu-devel] [PATCH] s390x/tcg: fixup TEST PROTECTION

2018-01-17 Thread David Hildenbrand
On 12.01.2018 13:54, David Hildenbrand wrote: > CC == 2 can only happen due to a protection exception, not if memory is > not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to > be forwarded to the guest. > > Since the initial definition of TEST PROTECTION, we now read globals

Re: [Qemu-devel] [PATCH v2 16/32] qcow2: Update l2_allocate() to support L2 slices

2018-01-17 Thread Alberto Garcia
On Tue 16 Jan 2018 05:52:36 PM CET, Anton Nefedov wrote: >> @@ -299,42 +300,50 @@ static int l2_allocate(BlockDriverState *bs, int >> l1_index, uint64_t **table) >> > [..]> >> -/* write the l2 table to the file */ >> -BLKDBG_EVENT(bs->file, BLKDBG_L2_ALLOC_WRITE); >> +

[Qemu-devel] [PATCH v10 00/21] tcg: generic vector operations

2018-01-17 Thread Richard Henderson
Changes since v9: * Detect whether __attribute__((vector_size(16))) operations are supported by the host compiler. This includes the case affecting ppc64 where gcc-4.8.5 crashes. Note that gcc-7.2 does pass the test on ppc64. * Dropped support for vector interleaves and element

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Eric Blake
On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: >>> I have a script (for managing libvirt guest, but it can be adopted for >>> qemu or even used for qemu monitor), which allows >>> me run qmp commands on vms as easy as: >>> >>> |qmp VMNAME query-block-jobs or qmp VMNAME

[Qemu-devel] [PATCH v10 05/21] tcg: Loosen vec_gen_op* typecheck rules

2018-01-17 Thread Richard Henderson
For ARM SVE with VQ=3, we want to be able to dup a scalar into a v256, use that, and then perform a second operation with the v256 punned to a v128. Allow operands to a vector operation be wider than necessary for the output. Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2-12 13/15] s390x/tcg: STSI overhaul

2018-01-17 Thread David Hildenbrand
>> +union sysib { >> +struct sysib_111 sysib_111; >> +struct sysib_121 sysib_121; >> +struct sysib_122 sysib_122; >> +struct sysib_221 sysib_221; >> +struct sysib_222 sysib_222; >> +struct sysib_322 sysib_322; >> +}; > > Wondering whether you should add some typedefery to

[Qemu-devel] [PATCH v2] iotests: Make 200 run on tmpfs

2018-01-17 Thread Max Reitz
200 currently fails on tmpfs because it sets cache=none. However, without that (and aio=native), the test still works now and it fails before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So we can probably remove the aio=native safely, and replace cache=none by cache=$CACHEMODE.

[Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger ---

Re: [Qemu-devel] [PATCH/RFC 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180117141849.65757-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH/RFC 0/3] s390x/kvm: implement new hardware/firmware features === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [RFC PATCH 0/3] add QEMU_WARN_NONNULL_ARGS() macro

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 10:18 AM, Philippe Mathieu-Daudé wrote: > Some old PoC series I remember after reading > http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg03545.html > > I had few more changes but then I found the code was harder to read > so I didn't continue further. > Only 2 patches are

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:30 PM, David Hildenbrand wrote: > On 17.01.2018 15:18, Christian Borntraeger wrote: >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor activity). To prevent any issues we require

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix python 2 support

2018-01-17 Thread Marc-André Lureau
On Wed, Jan 17, 2018 at 12:44 PM, Marc-André Lureau wrote: > Python GDB support may use Python 2 or 3. > > Inferior.read_memory() may return a buffer with Python 2 or a > memoryview with Python 3 (see also >

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:50 PM, David Hildenbrand wrote: > On 17.01.2018 15:37, Cornelia Huck wrote: >> On Wed, 17 Jan 2018 15:18:48 +0100 >> Christian Borntraeger wrote: >> >>> We need to handle the bpb control on reset and migration. Normally >>> stfle.82 is transparent (and

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix python 2 support

2018-01-17 Thread Eric Blake
On 01/17/2018 08:18 AM, Laszlo Ersek wrote: > On 01/17/18 12:44, Marc-André Lureau wrote: >> Python GDB support may use Python 2 or 3. >> >> Inferior.read_memory() may return a buffer with Python 2 or a >> memoryview with Python 3 (see also >>

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 11:56 AM, Eric Blake wrote: > On 01/17/2018 08:39 AM, Daniel P. Berrange wrote: > GCC may or may not warn you about passing NULL for the 'bar' parameter, but it will none the less assume nothing passes NULL, and thus remove the 'if (!bar)' conditional during

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Eric Blake
On 01/17/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote: looks interesting. what about the following naming? @mode: possible values:    hide - just hide server from new clients, maintain existing connections,    remove after all

[Qemu-devel] [PATCH 04/24] lm32: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model). and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. LM32 however doesn't have working default in *-user

[Qemu-devel] [PATCH 10/24] openrisc: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Take default type from linux-user and use it as

[Qemu-devel] [PATCH v10 06/21] tcg: Add generic vector ops for constant shifts

2018-01-17 Thread Richard Henderson
Opcodes are added for scalar and vector shifts, but considering the varied semantics of these do not expose them to the front ends. Do go ahead and provide them in case they are needed for backend expansion. Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH v3 0/4] linux-user: select CPU type according ELF header values

2018-01-17 Thread Igor Mammedov
On Tue, 16 Jan 2018 23:22:08 +0100 Laurent Vivier wrote: > This idea has been suggested to me before by Philippe > Mathieu-Daudé, and recently YunQiang Su has proposed a > patch to manage the MIPS r6 case. > > Based on this, this series tries to clean-up the original > patch,

Re: [Qemu-devel] [PATCH v2 13/32] qcow2: Add l2_slice_size field to BDRVQcow2State

2018-01-17 Thread Eric Blake
On 01/17/2018 09:30 AM, Alberto Garcia wrote: > On Tue 16 Jan 2018 11:06:21 PM CET, Eric Blake wrote: > >>> typedef struct Qcow2ReopenState { >>> Qcow2Cache *l2_table_cache; >>> Qcow2Cache *refcount_block_cache; >>> +int l2_slice_size; >> >> Worth a comment? >> /* Number of entries

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Halil Pasic
On 01/17/2018 04:10 PM, David Hildenbrand wrote: >>> As soon as we enable bits for CPU models, we guarantee that migration >>> works. While introducing this change we already had one example where >>> this was not the case. Not good. (and remember having another such >>> exception) >> The point

[Qemu-devel] [PATCH v10 08/21] tcg: Add generic vector ops for multiplication

2018-01-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 5 + tcg/tcg-op-gvec.h| 2 ++ tcg/tcg-op.h | 1 + tcg/tcg-opc.h| 1 + tcg/tcg.h| 1 + accel/tcg/tcg-runtime-gvec.c | 44

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread David Hildenbrand
On 17.01.2018 17:04, Christian Borntraeger wrote: > > > On 01/17/2018 04:10 PM, David Hildenbrand wrote: >> And exactly for this reason I tend to nack patch nr 3 (if that is of any weight :) ). >>> >>> I have communicated the mistake to asll relevant parties - it will not >>> happen

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Marcel Apfelbaum
On 17/01/2018 17:35, Peter Maydell wrote: On 17 January 2018 at 15:23, Marcel Apfelbaum wrote: On 16/01/2018 16:34, Peter Maydell wrote: On 16 January 2018 at 01:37, Andrey Smirnov I'm not familiar enough with our PCI code to be able to

[Qemu-devel] [PATCH v10.5 18/20] target/arm: Use vector infrastructure for aa64 orr/bic immediate

2018-01-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e8fc4bc27e..3b113f6b7c 100644

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 07:25 AM, Daniel P. Berrange wrote: > On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: >> On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote: >>> Hi, >>> >>> This series is to be clearer about which upstream version we are using. >>> >>> All "FROM distrib:latest" entries

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 11:04 AM, Daniel P. Berrange wrote: > On Wed, Jan 17, 2018 at 10:58:21AM -0300, Philippe Mathieu-Daudé wrote: >> On 01/17/2018 07:25 AM, Daniel P. Berrange wrote: >>> On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote:

Re: [Qemu-devel] [PATCH v6 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-01-17 Thread Anton Nefedov
On 16/1/2018 7:11 PM, Alberto Garcia wrote: On Tue 16 Jan 2018 02:04:29 PM CET, Anton Nefedov wrote: iotest 060: write to the discarded cluster does not trigger COW anymore. so, break on write_aio event instead, will work for the test (but write won't fail anymore, so update reference

[Qemu-devel] [PATCH/RFC 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-17 Thread Christian Borntraeger
We want to provide more hw features to guests, namely the new bpb control as well as other transparent facilities that might be introduced by firmware updates (e.g. the stfle facility 81). See the kernel discussion for the KVM side https://www.spinics.net/lists/kernel/msg2700551.html Christian

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Cornelia Huck
On Wed, 17 Jan 2018 15:18:48 +0100 Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

2018-01-17 Thread Daniel P. Berrange
On Wed, Jan 17, 2018 at 11:33:34AM -0300, Philippe Mathieu-Daudé wrote: > On 01/17/2018 10:32 AM, Daniel P. Berrange wrote: > > On Wed, Jan 17, 2018 at 10:18:19AM -0300, Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >>

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

2018-01-17 Thread Cédric Le Goater
On 01/17/2018 12:10 PM, Benjamin Herrenschmidt wrote: > On Wed, 2018-01-17 at 10:18 +0100, Cédric Le Goater wrote: > Also, have we decided how the process of switching between XICS and > XIVE will work vs. CAS ? That's how it is described in the architecture. The current choice

[Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-17 Thread Elie Tournier
Hello everyone, At Collabora, we are working on adding an OpenGL ES backend on virglrenderer [1]. I submit these patches as an RFC because our work didn't land in virglrenderer yet. Currently, we support OpenGL ES 2.0 on the guest side and OpenGL ES 3.0 on the host side. Our plan is to

Re: [Qemu-devel] [PATCH 3/3] s390x/cpumodel: fix transparency for non-hyp STFL features

2018-01-17 Thread Cornelia Huck
On Wed, 17 Jan 2018 15:18:49 +0100 Christian Borntraeger wrote: > From: Halil Pasic > > Before cpu-models were introduced to QEMU with 2.8 the so called > non-hypervisor-managed STFL facilities (aka transparent facilities) were > handled

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-17 Thread Eric Blake
On 01/16/2018 05:18 PM, Shaun Reitan wrote: > This patch replaces the patch I sent yesturday. This one fixes > a bug in my original code as well as corrects a few styling > issues. Hopfully this one comes out correct! Sorry for the > inconvienece. This paragraph belongs... > > When currently

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 15:23, Marcel Apfelbaum wrote: > > On 16/01/2018 16:34, Peter Maydell wrote: >> On 16 January 2018 at 01:37, Andrey Smirnov >> I'm not familiar enough with our PCI code to be able to review >> this, I'm afraid. MST and

Re: [Qemu-devel] [PATCH v2] iotests: Make 200 run on tmpfs

2018-01-17 Thread Jeff Cody
On Wed, Jan 17, 2018 at 02:50:15PM +0100, Max Reitz wrote: > 200 currently fails on tmpfs because it sets cache=none. However, > without that (and aio=native), the test still works now and it fails > before Jeff's series (on fc7dbc119e0852a70dc9fa68bb41a318e49e4cd6). So > we can probably remove

[Qemu-devel] [PATCH 06/24] microblaze: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. For the later default is set to bogus 'any', and

[Qemu-devel] [PATCH 21/24] linux/bsd-user: drop cpu_init() and use cpu_create() instead

2018-01-17 Thread Igor Mammedov
*-user were the last users of cpu_init() macro, which were used to create a cpu instance using cpu_model name. Now since all targets provide TARGET_DEFAULT_CPU_TYPE, cpu_init() can be replaced with one call: cpu_type = cpu_parse_cpu_model(TARGET_DEFAULT_CPU_TYPE, cpu_model) when '-cpu' CLI

[Qemu-devel] [PATCH 18/24] hppa: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
It will be used to drop a bunch of ifdefs *-user/main.c that set default cpu_model in favor of using type names directly. Signed-off-by: Igor Mammedov --- CC: Richard Henderson --- target/hppa/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH 17/24] xtensa: cpu: rename XTENSA_DEFAULT_CPU_TYPE to TARGET_DEFAULT_CPU_TYPE

2018-01-17 Thread Igor Mammedov
so naming would be in line with other targets and null-machine.c which uses the later would compile. Later it also would be used as default for *-user targets which is currently bogus cpu model 'any', that errors out. Signed-off-by: Igor Mammedov --- CC: Max Filippov

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Vladimir Sementsov-Ogievskiy
17.01.2018 18:23, Eric Blake wrote: On 01/17/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote: looks interesting. what about the following naming? @mode: possible values:    hide - just hide server from new clients, maintain existing connections,   

[Qemu-devel] [PATCH v10 03/21] tcg: Standardize integral arguments to expanders

2018-01-17 Thread Richard Henderson
Some functions use intN_t arguments, some use uintN_t, some just used "unsigned". To aid putting function pointers in tables, we need consistency. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 16 tcg/tcg-op.c | 42

[Qemu-devel] [PATCH 22/24] cpu: get rid of unused cpu_init() defines

2018-01-17 Thread Igor Mammedov
cpu_init(cpu_model) were replaced by cpu_create(cpu_type) so no users are left, remove it. Signed-off-by: Igor Mammedov --- CC: Richard Henderson (maintainer:Alpha) CC: Peter Maydell CC: "Edgar E. Iglesias"

[Qemu-devel] [PATCH v10.5 01/20] tcg: Allow multiple word entries into the constant pool

2018-01-17 Thread Richard Henderson
This will be required for storing vector constants. Signed-off-by: Richard Henderson --- tcg/tcg-pool.inc.c | 115 +++-- 1 file changed, 93 insertions(+), 22 deletions(-) diff --git a/tcg/tcg-pool.inc.c

Re: [Qemu-devel] [PATCH v3 3/4] linux-user, m68k: select CPU according to ELF header values

2018-01-17 Thread Richard Henderson
On 01/16/2018 02:22 PM, Laurent Vivier wrote: > M680x0 doesn't support the same set of instructions > as ColdFire, so we can't use "any" CPU type to execute > m68020 instructions. > We select CPU type ("m68040" or "any" for ColdFire) > according to the ELF header. If we can't, we > use by default

[Qemu-devel] [PATCH 3/3] s390x/cpumodel: fix transparency for non-hyp STFL features

2018-01-17 Thread Christian Borntraeger
From: Halil Pasic Before cpu-models were introduced to QEMU with 2.8 the so called non-hypervisor-managed STFL facilities (aka transparent facilities) were handled transparently. With the advent cpu models, for host model (means -cpu host), we started fencing these of

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix python 2 support

2018-01-17 Thread Laszlo Ersek
On 01/17/18 12:44, Marc-André Lureau wrote: > Python GDB support may use Python 2 or 3. > > Inferior.read_memory() may return a buffer with Python 2 or a > memoryview with Python 3 (see also > https://sourceware.org/gdb/onlinedocs/gdb/Inferiors-In-Python.html) > > The elf.add_vmcoreinfo_note()

Re: [Qemu-devel] [PATCH] sun4u: implement power device

2018-01-17 Thread Marcel Apfelbaum
On 16/01/2018 22:05, Mark Cave-Ayland wrote: On 16/01/18 14:23, Marcel Apfelbaum wrote: Hi Philippe, On 16/01/2018 2:54, Philippe Mathieu-Daudé wrote: CC'ing PCI maintainers. Hi Mark, On 01/15/2018 05:58 PM, Mark Cave-Ayland wrote: This inbuilt device contains a single 4-byte register, of

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

2018-01-17 Thread Philippe Mathieu-Daudé
On 01/17/2018 10:32 AM, Daniel P. Berrange wrote: > On Wed, Jan 17, 2018 at 10:18:19AM -0300, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/qemu/compiler.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 03:37 PM, Cornelia Huck wrote: > On Wed, 17 Jan 2018 15:18:48 +0100 > Christian Borntraeger wrote: > >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread David Hildenbrand
On 17.01.2018 15:37, Cornelia Huck wrote: > On Wed, 17 Jan 2018 15:18:48 +0100 > Christian Borntraeger wrote: > >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor

Re: [Qemu-devel] [PULL 0/1] Dump patches

2018-01-17 Thread Eric Blake
On 01/17/2018 08:47 AM, Marc-André Lureau wrote: > The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into > staging (2018-01-16 17:36:39 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH 2/3] s390x/kvm: Handle bpb feature

2018-01-17 Thread Christian Borntraeger
On 01/17/2018 04:10 PM, David Hildenbrand wrote: > >>> And exactly for this reason I tend to nack patch nr 3 (if that is of any >>> weight :) ). >> >> I have communicated the mistake to asll relevant parties - it will not >> happen again >> (famous last words). > > An I already saw it happen

[Qemu-devel] [PATCH v10 01/21] tcg: Allow multiple word entries into the constant pool

2018-01-17 Thread Richard Henderson
This will be required for storing vector constants. Signed-off-by: Richard Henderson --- tcg/tcg-pool.inc.c | 115 +++-- 1 file changed, 93 insertions(+), 22 deletions(-) diff --git a/tcg/tcg-pool.inc.c

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-17 Thread Peter Maydell
On 17 January 2018 at 15:43, Igor Mammedov wrote: > Series is finishing work on generalizing cpu_model parsing > and limiting parts that deal with inconsistent cpu_model > naming to "-cpu" CLI option processing in vl.c/*-user.main.c > and FOO_cpu_class_by_name() callbacks. >

[Qemu-devel] [PATCH v10.5 11/20] target/arm: Align vector registers

2018-01-17 Thread Richard Henderson
Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h

[Qemu-devel] [PATCH v10.5 00/20] tcg: generic vector operations

2018-01-17 Thread Richard Henderson
Changes since v10: * Squashed a fixup patch which escaped my attention while preparing the patch set. Ho hum. Changes since v9: * Detect whether __attribute__((vector_size(16))) operations are supported by the host compiler. This includes the case affecting ppc64 where gcc-4.8.5

[Qemu-devel] [PATCH v10.5 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg

2018-01-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 43 ++- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index b97bc9b83c..219cc1e19d

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

2018-01-17 Thread Daniel P. Berrange
On Wed, Jan 17, 2018 at 10:58:21AM -0300, Philippe Mathieu-Daudé wrote: > On 01/17/2018 07:25 AM, Daniel P. Berrange wrote: > > On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: > >> On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote: > >>> Hi, > >>> > >>> This series is to be clearer

Re: [Qemu-devel] [PATCH 3/3] s390x/cpumodel: fix transparency for non-hyp STFL features

2018-01-17 Thread David Hildenbrand
On 17.01.2018 15:18, Christian Borntraeger wrote: > From: Halil Pasic > > Before cpu-models were introduced to QEMU with 2.8 the so called > non-hypervisor-managed STFL facilities (aka transparent facilities) were > handled transparently. > > With the advent cpu

[Qemu-devel] [PATCH 12/24] s390x: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. Use default value from linux-user for

[Qemu-devel] [PATCH 15/24] tricore: cpu: add TARGET_DEFAULT_CPU_TYPE macro

2018-01-17 Thread Igor Mammedov
it will be used for for 2 purposes, 1st is to provide to cpu name resolving class for machine 'none' cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) and later to drop a bunch of ifdefs *-user/main.c that set default cpu_model. linux-user defaults to catch all 'any' which is

  1   2   3   4   >