[Qemu-devel] [PATCH] hw: Do not include "sysemu/block-backend.h" if it is not necessary

2018-02-15 Thread Thomas Huth
After reviewing a patch from Philippe that removes block-backend.h from hw/lm32/milkymist.c, I noticed that this header is included unnecessarily in a lot of other files, too. Remove those unneeded includes to speed up the compilation process a little bit. Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH 24/30] hw/ipack: use the BYTE-based definitions

2018-02-15 Thread Alberto Garcia
On Thu 15 Feb 2018 05:28:54 AM CET, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units

2018-02-15 Thread Alberto Garcia
On Wed 14 Feb 2018 12:33:22 AM CET, Eric Blake wrote: > I mentioned this while reviewing Berto's series on L2 slice handling; > this is a first cut at patches that I think are worth doing throughout > the qcow2 code base if we like the idea. > > Eric Blake (2): > qcow2: Prefer 'entries' over

Re: [Qemu-devel] [PATCH] syscall: fix special case of write(fd, NULL, 0)

2018-02-15 Thread Laurent Vivier
Le 15/02/2018 à 00:33, Oliver Smith a écrit : > Hello there, > > I'm a little late to the party. But what is necessary to get this > upstreamed, and how can I help? > > PS: Sorry if I picked the wrong e-mail addresses, I wasn't subscribed to > the ML at that point and used the addresses I could

Re: [Qemu-devel] [PATCH V2 1/1] tests: Add migration test for aarch64

2018-02-15 Thread Andrew Jones
On Wed, Feb 14, 2018 at 02:17:34PM -0600, Wei Huang wrote: > > > On 02/12/2018 11:31 AM, Andrew Jones wrote: > > On Fri, Feb 09, 2018 at 04:42:42PM -0500, Wei Huang wrote: > >> This patch adds migration test support for aarch64. The test code, which > >> implements the same functionality as x86,

Re: [Qemu-devel] [PATCH v1 1/3] bcm2836: Make CPU type configurable

2018-02-15 Thread Pekka Enberg
On 02/15/2018 01:48 PM, Peter Maydell wrote: On 8 February 2018 at 05:50, Pekka Enberg wrote: This patch adds a "cpu-type" property to BCM2836 SoC in preparation for reusing the code for the Raspberry Pi 3, which has a different processor model. Signed-off-by: Pekka Enberg

[Qemu-devel] [PATCH 0/4] target/mips: translator loop conversion

2018-02-15 Thread Emilio G. Cota
Tested with Aurelien's debian wheezy image for mips64. The third patch is just to improve the diff--saves about 20% of diff lines in patch 4, but feel free to squash it with the latter. Thanks, Emilio

[Qemu-devel] [PATCH 1/4] target/mips: convert to DisasJumpType

2018-02-15 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 186 +++- 1 file changed, 91 insertions(+), 95 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index d05ee67..a133205 100644 ---

Re: [Qemu-devel] [PATCH 01/02] fix issue where a branch to pc+4 confuses GDB because pc and npc are set to the same value

2018-02-15 Thread Steven Seeger
All, I think that the issue I pointed out the list is not a QEMU bug at all but a GDB bug. GDB's sparc software single step implementation seems to be what is stuck. It always re-sets the breakpoint at the current instruction in this case. It calculates the breakpoint offsets by analyzing the

Re: [Qemu-devel] [PATCH v2 1/3] ppc4xx: Add device models found in PPC440 core SoCs

2018-02-15 Thread David Gibson
On Thu, Feb 15, 2018 at 10:27:06PM +0100, BALATON Zoltan wrote: > These devices are found in newer SoCs based on 440 core e.g. the 460EX > (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/ > PP460EX_DS2063.pdf) > > Signed-off-by: BALATON Zoltan Applied,

[Qemu-devel] [PATCH 2/2] target/sh4: convert to TranslatorOps

2018-02-15 Thread Emilio G. Cota
This was fairly straightforward since it had already been converted to DisasContextBase; just had to add TARGET_TOO_MANY to the switch in tb_stop. Signed-off-by: Emilio G. Cota --- target/sh4/translate.c | 175 + 1 file changed, 90

Re: [Qemu-devel] [PATCH v2 3/3] ppc: Add aCube Sam460ex board

2018-02-15 Thread David Gibson
On Thu, Feb 15, 2018 at 10:27:06PM +0100, BALATON Zoltan wrote: > Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. > This is not a complete implementation yet with a lot of components > still missing but enough for the U-Boot firmware to start and to boot > a Linux kernel or

Re: [Qemu-devel] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Pekka Enberg
Hi, On 02/15/2018 02:39 PM, Peter Maydell wrote: On 8 February 2018 at 05:50, Pekka Enberg wrote: This patch adds a "raspi3" machine type, which can now be selected as the machine to run on by users via the "-M" command line option to QEMU. The machine type does *not* ignore

[Qemu-devel] [PATCH v3 4/7] hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus

2018-02-15 Thread Philippe Mathieu-Daudé
On reset the bus will reset the card, we can now drop the device_reset() call. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/ssi-sd.c | 32 +++- 1 file changed, 19 insertions(+), 13

[Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it

2018-02-15 Thread Philippe Mathieu-Daudé
using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé --- RFC because how pl181_sdbus_create_inplace() doing class_init(SDBus) in realize(pl181) seems weird... from http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg01268.html: I think you have to change

[Qemu-devel] [PATCH v3 1/7] hw/sd/milkymist-memcard: use qemu_log_mask()

2018-02-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PULL 2/3] tests: Enable boot-serial-test for hppa

2018-02-15 Thread Thomas Huth
On 16.02.2018 00:55, Philippe Mathieu-Daudé wrote: > On 02/04/2018 07:23 PM, Richard Henderson wrote: >> Reviewed-by: Thomas Huth >> Signed-off-by: Richard Henderson >> --- >> tests/boot-serial-test.c | 1 + >> tests/Makefile.include | 2 ++ >>

[Qemu-devel] [Bug 1331334] Re: driftfix=none and migration on Win7 guest causes time to go 10 times as fast

2018-02-15 Thread Thomas Huth
OK, thanks for checking again! So I'm closing this ticket now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1331334 Title:

[Qemu-devel] [PATCH 3/4] target/mips: use *ctx for DisasContext

2018-02-15 Thread Emilio G. Cota
No changes to the logic here; this is just to make the diff that follows easier to read. While at it, remove the unnecessary 'struct' in 'struct TranslationBlock'. Note that checkpatch complains with a false positive: ERROR: space prohibited after that '&' (ctx:WxW) #75: FILE:

[Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static

2018-02-15 Thread Philippe Mathieu-Daudé
It belongs to the legacy API (the last user has been converted). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index

Re: [Qemu-devel] [QEMU-PPC] [PATCH V4 2/2] ppc/spapr-caps: For pseries-2.12 change spapr-cap defaults

2018-02-15 Thread David Gibson
On Fri, Feb 16, 2018 at 01:33:28PM +1100, Suraj Jitindar Singh wrote: > For the pseries-2.12 machine type, make the spapr-caps SPAPR_CAP_CFPC > and SPAPR_CAP_SBBC default to workaround. Thus if the host is capable > the guest will be able to take advantage of these workarounds by default. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/3] Sam460ex emulation

2018-02-15 Thread Thomas Huth
On 15.02.2018 22:27, BALATON Zoltan wrote: > Remaining patches for Sam460ex emulation. The original cover letter > with more details is here: > > http://lists.nongnu.org/archive/html/qemu-ppc/2017-08/msg00112.html > > We'll need to also add binaries for firmware (customised u-boot > version) and

[Qemu-devel] [QEMU-PPC] [PATCH V4 2/2] ppc/spapr-caps: For pseries-2.12 change spapr-cap defaults

2018-02-15 Thread Suraj Jitindar Singh
For the pseries-2.12 machine type, make the spapr-caps SPAPR_CAP_CFPC and SPAPR_CAP_SBBC default to workaround. Thus if the host is capable the guest will be able to take advantage of these workarounds by default. Otherwise if the host doesn't have these capabilities qemu will fail to start and

[Qemu-devel] [QEMU-PPC] [PATCH V4 1/2] ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs

2018-02-15 Thread Suraj Jitindar Singh
The spapr-cap cap-ibs can only have values broken or fixed as there is no explicit workaround required. Currently setting the value workaround for this cap will hit an assert if the guest makes the hcall h_get_cpu_characteristics. Report an error when attempting to apply the setting with a more

[Qemu-devel] [PATCH v3 7/7] hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h"

2018-02-15 Thread Philippe Mathieu-Daudé
omap_mmc.c is the last user left. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h| 16 -- include/hw/sd/sdcard_legacy.h | 50 +++ hw/sd/omap_mmc.c | 2 +- hw/sd/sd.c|

Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package

2018-02-15 Thread Philippe Mathieu-Daudé
What is interesting with this patch, is that, forcing use of system capstone, Travis builds ran much faster; longest build took 40min: https://travis-ci.org/philmd/qemu/builds/341979248 This revealed (without profiling yet) that compiling the capstone C++ takes some time... mingw32@i7-4600U#

[Qemu-devel] [PATCH 1/2] translator: pass max_insns to tb_start

2018-02-15 Thread Emilio G. Cota
sh4 will need it. Signed-off-by: Emilio G. Cota --- accel/tcg/translator.c | 2 +- include/exec/translator.h | 3 ++- target/alpha/translate.c | 3 ++- target/arm/translate-a64.c | 4 +++- target/arm/translate.c | 4 +++- target/hppa/translate.c| 4 +++-

[Qemu-devel] [PATCH 0/2] target/sh4: translator loop conversion

2018-02-15 Thread Emilio G. Cota
Tested on Aurelien's debian sh4 image. There's a twist in this conversion in that max_insns might be modified by .tb_start; this is what patch 1 introduces. Note that I've sent patches for converting other targets to the translation loop; those have not yet hit master so in patch 1 I am ignoring

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-15 Thread David Gibson
On Wed, Feb 14, 2018 at 08:55:41AM -0700, Alex Williamson wrote: > On Wed, 14 Feb 2018 19:09:16 +1100 > Alexey Kardashevskiy wrote: > > > On 14/02/18 12:33, David Gibson wrote: > > > On Tue, Feb 13, 2018 at 07:20:56PM +1100, Alexey Kardashevskiy wrote: > > >> On 13/02/18 16:41,

[Qemu-devel] [PATCH 4/4] target/mips: convert to TranslatorOps

2018-02-15 Thread Emilio G. Cota
Notes: - DISAS_TOO_MANY replaces the former "break" in the translation loop. However, care must be taken not to overwrite a previous condition in is_jmp; that's why in translate_insn we first check is_jmp and return if it's != DISAS_NEXT. - Added an assert in translate_insn, before exiting

[Qemu-devel] [Bug 1331334] Re: driftfix=none and migration on Win7 guest causes time to go 10 times as fast

2018-02-15 Thread Matthew Stapleton
I am unable to reproduce this with qemu 2.11.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1331334 Title: driftfix=none and migration on Win7 guest causes time to go 10 times as fast Status

[Qemu-devel] [PATCH] tests/boot-serial-test: Fix problem with timeout due to dropped characters

2018-02-15 Thread Thomas Huth
Commit 92b540dac9fc3a5 introduce a counter to handle the timeouts in a better way. But in case ccnt reaches 512, the current read character is ignored - and if that character is part of the string that we are looking for, the test fails to match the string. Almost all of the tests look for a

Re: [Qemu-devel] [PULL 00/10] migration queue

2018-02-15 Thread Thomas Huth
On 15.02.2018 21:19, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 14 February 2018 at 15:39, Dr. David Alan Gilbert (git) >> wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> The following changes since commit

[Qemu-devel] [PATCH v2 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Pekka Enberg
This patch adds a "raspi3" machine type, which can now be selected as the machine to run on by users via the "-M" command line option to QEMU. The machine type does *not* ignore memory transaction failures so we likely need to add some dummy devices later when people run something more

[Qemu-devel] [PATCH v2 2/3] raspi: Raspberry Pi 3 support

2018-02-15 Thread Pekka Enberg
This patch adds Raspberry Pi 3 support to hw/arm/raspi.c. The differences to Pi 2 are: - Firmware address - Board ID - Board revision The CPU is different too, but that's going to be configured as part of the machine default CPU when we introduce a new machine type. The patch was written

[Qemu-devel] [PATCH v2 1/3] bcm2836: Make CPU type configurable

2018-02-15 Thread Pekka Enberg
This patch adds a "cpu-type" property to BCM2836 SoC in preparation for reusing the code for the Raspberry Pi 3, which has a different processor model. Signed-off-by: Pekka Enberg --- hw/arm/bcm2836.c | 17 + hw/arm/raspi.c | 3 +++

[Qemu-devel] [PATCH v2 0/3] Raspberry Pi 3 support

2018-02-15 Thread Pekka Enberg
This patch series adds support for Raspberry Pi 3 as a new machine model "raspi3", which is an extension of the "raspi2" model with the following differences: - Default CPU type is "cortex-a53" - Firmware is at address 0x8 - Board ID is 0xc44 and board revision is 0xa02082 The patches

[Qemu-devel] [PATCH 2/4] target/mips: convert to DisasContextBase

2018-02-15 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 346 1 file changed, 175 insertions(+), 171 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index a133205..aefd729 100644 ---

Re: [Qemu-devel] [QEMU-PPC] [PATCH V4 1/2] ppc/spapr-caps: Disallow setting workaround for spapr-cap-ibs

2018-02-15 Thread David Gibson
On Fri, Feb 16, 2018 at 01:33:27PM +1100, Suraj Jitindar Singh wrote: > The spapr-cap cap-ibs can only have values broken or fixed as there is > no explicit workaround required. Currently setting the value workaround > for this cap will hit an assert if the guest makes the hcall >

[Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6)

2018-02-15 Thread Philippe Mathieu-Daudé
Hi, Since v2: - pl181: remove legacy sd_set_cb() (Peter) Since v1: - rebased on /master (Peter sdcard reset() patches) - fix milkymist-mmc from previous seris using instance_init (Michael Walle) This series convert 3 devices using the legacy SDCard API to the SDBus API: - milkymist-mmc - pl181

[Qemu-devel] [PATCH v3 2/7] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-02-15 Thread Philippe Mathieu-Daudé
Create the SDCard in the realize() function. Suggested-by: Michael Walle Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 28

[Qemu-devel] [PATCH v3 3/7] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it

2018-02-15 Thread Philippe Mathieu-Daudé
using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 38 +- 1 file changed, 21 insertions(+), 17

Re: [Qemu-devel] [PATCH 29/30] tpm: use the BYTE-based definitions

2018-02-15 Thread Marc-André Lureau
On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau > --- > include/hw/acpi/tpm.h | 2 +- > 1 file

[Qemu-devel] [PATCHv3 0/4] ] add query-cpu-fast and related s390 changes

2018-02-15 Thread Viktor Mihajlovski
This series consolidates patches around a performance issue caused by the usage of QMP query-cpus. A performance issue was found in an OpenStack environment, where ceilometer was collecting domain statistics with libvirt. The domain statistics reported by libvirt include the vCPU halted state,

[Qemu-devel] [PATCHv3 3/4] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-15 Thread Viktor Mihajlovski
The s390 CPU state can be retrieved without interrupting the VM execution. Extendend the CpuInfoFast union with architecture specific data and an implementation for s390. Return data looks like this: [ {"thread-id":64301,"props":{"core-id":0}, "arch":"s390","cpu-state":"operating",

Re: [Qemu-devel] [PATCH v3] s390x/tcg: add various alignment checks

2018-02-15 Thread David Hildenbrand
On 15.02.2018 11:38, David Hildenbrand wrote: > Let's add proper alignment checks for a handful of instructions that > require a SPECIFICATION exception in case alignment is violated. > > Introduce new wout/in functions. As we are right now only using them for > privileged instructions, we have

Re: [Qemu-devel] [PATCH 3/3] block/ssh: Add basic .bdrv_truncate()

2018-02-15 Thread Richard W.M. Jones
The series looks fine to me: Reviewed-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch

Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs

2018-02-15 Thread Philippe Mathieu-Daudé
Hi Peter, On 02/15/2018 08:29 AM, Peter Maydell wrote: > On 2 February 2018 at 00:42, Alistair Francis > wrote: >> List all possible valid CPU options. >> >> Signed-off-by: Alistair Francis >> Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v2 6/7] linux-user: Support SVE in aarch64 signal frames

2018-02-15 Thread Peter Maydell
On 11 February 2018 at 20:58, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/signal.c | 348 > ++-- > 1 file changed, 283 insertions(+), 65 deletions(-) >

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Philippe Mathieu-Daudé
On 02/15/2018 10:18 AM, Peter Maydell wrote: > On 15 February 2018 at 13:14, Philippe Mathieu-Daudé wrote: >> On 02/15/2018 09:49 AM, Philippe Mathieu-Daudé wrote: >>> On 02/15/2018 09:39 AM, Peter Maydell wrote: On 8 February 2018 at 05:50, Pekka Enberg

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-15 Thread Stefan Hajnoczi
On Wed, Feb 14, 2018 at 04:31:45PM -0600, Eric Blake wrote: > On 02/14/2018 08:06 AM, Stefan Hajnoczi wrote: > > On Tue, Feb 13, 2018 at 10:01:06AM -0600, Eric Blake wrote: > > I hope this explains things! The main issue that raised these questions > > was that aio_context_in_iothread() has a

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check

2018-02-15 Thread David Hildenbrand
On 14.02.2018 20:04, Richard Henderson wrote: > On 02/14/2018 09:31 AM, David Hildenbrand wrote: >> Let's add proper alignment checks for a handful of instructions that >> require a SPECIFICATION exception in case alignment is violated. >> >> Introduce new wout/in functions. Declare them as

Re: [Qemu-devel] [PATCH 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h"

2018-02-15 Thread Marc-André Lureau
On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé wrote: > (added in 076b35b5a56) > > Signed-off-by: Philippe Mathieu-Daudé Or osdep.h? Reviewed-by: Marc-André Lureau > --- > include/qemu/cunits.h | 11 +++ >

[Qemu-devel] [PATCH] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes

2018-02-15 Thread Stefan Hajnoczi
The libiscsi iscsi_task_mgmt_async() API documentation says: abort_task will also cancel the scsi task. The callback for the scsi task will be invoked with SCSI_STATUS_CANCELLED The libiscsi implementation does not fulfil this promise. The task's callback is not invoked and its struct

Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs

2018-02-15 Thread Peter Maydell
On 2 February 2018 at 00:42, Alistair Francis wrote: > List all possible valid CPU options. > > Signed-off-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > --- > > V5: > - Use cpu_model names > V4: > -

Re: [Qemu-devel] [PATCH v1 1/3] bcm2836: Make CPU type configurable

2018-02-15 Thread Peter Maydell
On 8 February 2018 at 05:50, Pekka Enberg wrote: > This patch adds a "cpu-type" property to BCM2836 SoC in preparation for > reusing the code for the Raspberry Pi 3, which has a different processor > model. > > Signed-off-by: Pekka Enberg > --- a/hw/arm/raspi.c >

Re: [Qemu-devel] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Peter Maydell
On 8 February 2018 at 05:50, Pekka Enberg wrote: > This patch adds a "raspi3" machine type, which can now be selected as > the machine to run on by users via the "-M" command line option to QEMU. > > The machine type does *not* ignore memory transaction failures so we > likely

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Philippe Mathieu-Daudé
On 02/15/2018 09:39 AM, Peter Maydell wrote: > On 8 February 2018 at 05:50, Pekka Enberg wrote: >> This patch adds a "raspi3" machine type, which can now be selected as >> the machine to run on by users via the "-M" command line option to QEMU. >> >> The machine type does *not*

Re: [Qemu-devel] [PATCH v5 3/6] bcm2836: Use the Cortex-A7 instead of Cortex-A15

2018-02-15 Thread Philippe Mathieu-Daudé
Hi Peter, On 02/01/2018 09:42 PM, Alistair Francis wrote: > The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use > the correct CPU. > https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf Can you add these lines with reference to the commits?

[Qemu-devel] [PULL v2 1/3] vl: pause vcpus before stopping iothreads

2018-02-15 Thread Stefan Hajnoczi
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all()

Re: [Qemu-devel] [PATCH 0/5] Block patches

2018-02-15 Thread Stefan Hajnoczi
On Wed, Feb 14, 2018 at 09:58:27PM +0800, Fam Zheng wrote: > On Wed, Feb 14, 2018 at 9:25 PM, Stefan Hajnoczi wrote: > > On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: > >> On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > >> > The following changes since commit > >>

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check

2018-02-15 Thread David Hildenbrand
On 15.02.2018 10:49, Cornelia Huck wrote: > On Thu, 15 Feb 2018 10:47:45 +0100 > David Hildenbrand wrote: > >> On 14.02.2018 20:04, Richard Henderson wrote: >>> On 02/14/2018 09:31 AM, David Hildenbrand wrote: Let's add proper alignment checks for a handful of

Re: [Qemu-devel] [PULL 00/55] Block layer patches

2018-02-15 Thread Peter Maydell
On 13 February 2018 at 17:04, Kevin Wolf wrote: > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCHv3 1/4] qmp: expose s390-specific CPU info

2018-02-15 Thread Viktor Mihajlovski
Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. With this change the output of query-cpus will look

[Qemu-devel] GSoC project idea: iSCSI target in QEMU

2018-02-15 Thread Stefan Hajnoczi
There is currently no way to test the block/iscsi.c block driver. Using a third-party iSCSI target isn't sufficient since we need fault injection and control over I/O request execution in order to exercise specific code paths in the initiator. Are you willing to co-mentor a Google Summer of Code

Re: [Qemu-devel] [PATCH] tests: add test for TPM TIS device

2018-02-15 Thread Marc-André Lureau
Hi On Thu, Feb 15, 2018 at 2:21 AM, Stefan Berger wrote: > Move the TPM TIS related register and flag #defines into > include/hw/acpi/tpm.h for access by the test case. > > Write a test case that covers the TIS functionality. > > Add the tests cases to the MAINTAINERS

[Qemu-devel] [PATCH v3] qcow2: Replace align_offset() with ROUND_UP()

2018-02-15 Thread Alberto Garcia
The align_offset() function is equivalent to the ROUND_UP() macro so there's no need to use the former. The ROUND_UP() name is also a bit more explicit. This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() because align_offset() already requires that the second parameter is a power of

Re: [Qemu-devel] [Xen-devel] [PATCH 30/30] xen: use the BYTE-based definitions

2018-02-15 Thread Alan Robinson
Hi Philippe, On Thu, Feb 15, 2018 at 01:29:00AM -0300, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > Subject: [Xen-devel] [PATCH 30/30] xen: use the BYTE-based definitions > List-Id: Xen developer discussion > > It ease code review, unit is explicit. > >

Re: [Qemu-devel] [PATCH V3 2/2] tests: Add migration test for aarch64

2018-02-15 Thread Andrew Jones
On Thu, Feb 15, 2018 at 01:07:25AM -0500, Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units

2018-02-15 Thread Kevin Wolf
Am 14.02.2018 um 00:33 hat Eric Blake geschrieben: > I mentioned this while reviewing Berto's series on L2 slice handling; > this is a first cut at patches that I think are worth doing throughout > the qcow2 code base if we like the idea. I agree it's a good change. While we're at it, something

Re: [Qemu-devel] ERROR:qom/object.c:907:object_unref: assertion failed (obj->ref > 0): (0 > 0)

2018-02-15 Thread Daniel P . Berrangé
On Wed, Feb 14, 2018 at 08:27:10PM -0500, Bandan Das wrote: > > I get the error mentioined in the subject line when using vncviewer with > commit 13e1d0e71e78a925848258391a6e616b6b5ae219: > > Author: Daniel P. Berrange > Date: Thu Feb 1 16:45:14 2018 + > > ui:

Re: [Qemu-devel] [PULL 0/1] M68k for 2.12 patches

2018-02-15 Thread Peter Maydell
On 14 February 2018 at 10:39, Laurent Vivier wrote: > The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-02-13 18:24:08 +) > > are available in the Git

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 3/3] raspi: Add "raspi3" machine type

2018-02-15 Thread Philippe Mathieu-Daudé
On 02/15/2018 09:49 AM, Philippe Mathieu-Daudé wrote: > On 02/15/2018 09:39 AM, Peter Maydell wrote: >> On 8 February 2018 at 05:50, Pekka Enberg wrote: >>> This patch adds a "raspi3" machine type, which can now be selected as >>> the machine to run on by users via the "-M"

Re: [Qemu-devel] [PATCH v3] linux-user: Fix register used for 6th and 7th syscall argument on aarch64

2018-02-15 Thread Laurent Vivier
Le 02/02/2018 à 11:02, Guido Günther a écrit : > This unbreaks the testcase from > > http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html > > Thanks to Laurent Vivier for spotting the 7th one. > > Signed-off-by: Guido Günther > Tested-by: Philippe

[Qemu-devel] [PULL v2 0/3] Block patches

2018-02-15 Thread Stefan Hajnoczi
The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-02-13 18:24:08 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you

[Qemu-devel] [PULL v2 3/3] misc: fix spelling

2018-02-15 Thread Stefan Hajnoczi
From: Marc-André Lureau s/pupulate/populate Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell Message-id: 20180208162447.10851-1-marcandre.lur...@redhat.com Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] configure: Add missing space when using --with-pkgversion

2018-02-15 Thread Daniel P . Berrangé
On Thu, Feb 15, 2018 at 07:02:40AM +0100, Thomas Huth wrote: > On 14.02.2018 21:23, Eric Blake wrote: > > On 02/14/2018 11:31 AM, Thomas Huth wrote: > >> When running configure with --with-pkgversion=foo there is no > >> space anymore between the version number and the parentheses: > >> > >> $

[Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

2018-02-15 Thread Daniel P . Berrangé
vnc_listen_io() does not own the reference on the 'cioc' parameter is it passed, so should not be unref'ing it. Reported-by: Bandan Das Signed-off-by: Daniel P. Berrangé --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c

[Qemu-devel] [PATCH v3] s390x/tcg: add various alignment checks

2018-02-15 Thread David Hildenbrand
Let's add proper alignment checks for a handful of instructions that require a SPECIFICATION exception in case alignment is violated. Introduce new wout/in functions. As we are right now only using them for privileged instructions, we have to add ugly ifdefs to silence compilers. Convert STORE

Re: [Qemu-devel] [PATCH v2 0/3] block/iscsi: fix ioctl cancel use-after-free

2018-02-15 Thread Stefan Hajnoczi
On Sat, Feb 03, 2018 at 07:16:18AM +0100, Stefan Hajnoczi wrote: > v2: > * It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this >function already protects against duplicate calls internally [Stefan] > > Patches 1 & 2 are cleanups. > > Patch 3 fixes cancellation of

Re: [Qemu-devel] [PATCH 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h"

2018-02-15 Thread Thomas Huth
On 15.02.2018 10:55, Marc-André Lureau wrote: > On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé > wrote: >> (added in 076b35b5a56) >> >> Signed-off-by: Philippe Mathieu-Daudé > > Or osdep.h? No, osdep.h is for "OS includes and handling of OS

[Qemu-devel] [Bug 1739413] Re: Hotplugged vcpu does not guarantee cpu compat mode(power8) on power9 host

2018-02-15 Thread Thomas Huth
David's patch has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=51f84465dd985fc21589b2e ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 05/30] hw/mips/r4k: constify params_size

2018-02-15 Thread Philippe Mathieu-Daudé
Hi Thomas, On 02/15/2018 03:19 AM, Thomas Huth wrote: > On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/mips/mips_r4k.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/hw/mips/mips_r4k.c

[Qemu-devel] ping Re: [PATCH v10 00/12] Dirty bitmaps postcopy migration

2018-02-15 Thread Vladimir Sementsov-Ogievskiy
ping 07.02.2018 18:58, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new version of dirty bitmap postcopy migration series. Now it is based on Max's block tree: https://github.com/XanClic/qemu/commits/block, where it needs only one patch: "block: maintain persistent disabled

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-15 Thread Kevin Wolf
Am 15.02.2018 um 10:27 hat Stefan Hajnoczi geschrieben: > On Wed, Feb 14, 2018 at 04:31:45PM -0600, Eric Blake wrote: > > On 02/14/2018 08:06 AM, Stefan Hajnoczi wrote: > > > On Tue, Feb 13, 2018 at 10:01:06AM -0600, Eric Blake wrote: > > > I hope this explains things! The main issue that raised

Re: [Qemu-devel] [PATCH v2 8/8] qapi: query-blockstat: add driver specific file-posix stats

2018-02-15 Thread Anton Nefedov
On 12/2/2018 7:38 PM, Anton Nefedov wrote: On 3/2/2018 6:59 PM, Markus Armbruster wrote: Eric Blake writes: On 01/19/2018 06:50 AM, Anton Nefedov wrote: + +## +# @BlockDriverStats: +# +# Statistics of a block driver (driver-specific) +# +# Since: 2.12 +## +{ 'union':

[Qemu-devel] [PATCHv3 4/4] qemu-doc: deprecate query-cpus and info cpus

2018-02-15 Thread Viktor Mihajlovski
Start the deprecation period for QAPI query-cpus (replaced by query-cpus-fast) and HMP 'info cpus' (replaced by 'info cpus_fast') beginning with 2.12.0. Signed-off-by: Viktor Mihajlovski --- hmp-commands-info.hx | 4 ++-- qapi-schema.json | 4

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-15 Thread Stefan Berger
On 02/14/2018 01:39 PM, Kevin O'Connor wrote: On Tue, Feb 13, 2018 at 03:29:20PM -0500, Stefan Berger wrote: [...] In these 0x400 bytes we have 256 bytes that are used for configuration flags describing the supported opcode as you previously described. This array allows us to decouple the

[Qemu-devel] [PATCH v3] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-15 Thread David Engraf
This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and afterwards by load_elf/load_uimage at the corresponding load address. In this case the region for the device tree and the

[Qemu-devel] ping Re: [PATCH v2 0/2] block latency histogram

2018-02-15 Thread Vladimir Sementsov-Ogievskiy
ping 07.02.2018 15:50, Vladimir Sementsov-Ogievskiy wrote: v2: 01: add block_latency_histogram_clear() 02: fix spelling (sorry =() some rewordings remove histogram if latency parameter unspecified Vladimir Sementsov-Ogievskiy (2): block/accounting: introduce latency histogram

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check

2018-02-15 Thread Cornelia Huck
On Thu, 15 Feb 2018 10:47:45 +0100 David Hildenbrand wrote: > On 14.02.2018 20:04, Richard Henderson wrote: > > On 02/14/2018 09:31 AM, David Hildenbrand wrote: > >> Let's add proper alignment checks for a handful of instructions that > >> require a SPECIFICATION exception in

[Qemu-devel] [Bug 1589272] Re: qemu-system-x86_64: There is no option group 'vnc'

2018-02-15 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v5 4/6] raspi: Specify the valid CPUs

2018-02-15 Thread Peter Maydell
On 15 February 2018 at 13:04, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 02/15/2018 08:29 AM, Peter Maydell wrote: >> On 2 February 2018 at 00:42, Alistair Francis >> wrote: >>> List all possible valid CPU options. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/4] block: fix blk_aio_*() segfault when blk->root == NULL

2018-02-15 Thread Stefan Hajnoczi
On Tue, Feb 13, 2018 at 02:20:58PM +, Stefan Hajnoczi wrote: > v2: > * Introduce AIO_WAIT_WHILE() since aio_poll(ctx, true) is not allowed [Paolo] > > Using bdrv_inc_in_flight(blk_bs(blk)) doesn't work since BlockBackend->root > may > be NULL. > > This patch series solves the issue by

Re: [Qemu-devel] drive-mirroring to nbd is failing with multiple parallel jobs (qemu 2.9 -> 2.11)

2018-02-15 Thread Wouter Verhelst
Hi Eric, On Wed, Feb 14, 2018 at 09:11:02AM -0600, Eric Blake wrote: [NBD and keepalive] > This is more food for thought on whether it even makes sense for NBD to > worry about assisting in keepalive matters, or whether it would just be > bloating the protocol. I'm currently leaning towards the

[Qemu-devel] [PULL v2 2/3] ratelimit: don't align wait time with slices

2018-02-15 Thread Stefan Hajnoczi
From: Wolfgang Bumiller It is possible for rate limited writes to keep overshooting a slice's quota by a tiny amount causing the slice-aligned waiting period to effectively halve the rate. Signed-off-by: Wolfgang Bumiller Reviewed-by: Alberto

Re: [Qemu-devel] [PATCH 22/30] hw/display: use the BYTE-based definitions

2018-02-15 Thread Gerd Hoffmann
On Thu, Feb 15, 2018 at 01:28:52AM -0300, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. Reviewed-by: Gerd Hoffmann

[Qemu-devel] [PATCHv3 2/4] qmp: add query-cpus-fast

2018-02-15 Thread Viktor Mihajlovski
From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the information retrieved by the ioctl

[Qemu-devel] [PATCH] Polish the version strings containing the package version

2018-02-15 Thread Thomas Huth
Since commit 67a1de0d195a there is no space anymore between the version number and the parentheses when running configure with --with-pkgversion=foo : $ qemu-system-s390x --version QEMU emulator version 2.11.50(foo) But the space is included when building without that option when building from

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2018-02-15 Thread Thomas Huth
Fix has been released with QEMU 2.11: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a8b154a637b586441b ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

  1   2   3   4   >