[Qemu-devel] [PATCH v2] qga: unset frozen state if no mount point is frozen

2018-02-22 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. So call ga_unset_frozen in this senario. Also, if we return 0 frozen fs, there is no need to call guest-fsfreeze-thaw. Cc: Michael

Re: [Qemu-devel] [PATCH v4 00/20] SDCard: bugfixes, support UHS-I (part 5)

2018-02-22 Thread Philippe Mathieu-Daudé
ping? :) On 02/15/2018 07:13 PM, Philippe Mathieu-Daudé wrote: > Some refactors, few bugfixes, better SD/SPI support. > > With this series apply, machines can use SD cards in UHS-I mode. > (mostly imported from Alistair Francis work) > > MMC mode split out for another series, > so UHS enabled

Re: [Qemu-devel] Qemu aborted in ide_restart_bh after migration

2018-02-22 Thread Wangjing (King, Euler)
This issue occurred at a very low probability, If we inject delays in address_space_write_continue like this, the issue occurred inevitably: ### diff --git a/exec.c b/exec.c index e8d7b33..b9779e0 100644 ---

[Qemu-devel] [PULL] Update OpenBIOS images

2018-02-22 Thread Mark Cave-Ayland
Hi Peter, This update for OpenBIOS contains a single fix which allows yaboot 1.3.17 to boot under qemu-system-ppc. Please pull. ATB, Mark. The following changes since commit a6e0344fa0e09413324835ae122c4cadd7890231: Merge remote-tracking branch

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-22 Thread Viktor Mihajlovski
On 22.02.2018 05:40, Thomas Huth wrote: > On 21.02.2018 20:35, Collin L. Walling wrote: >> The s390-ccw firmware needs some information in support of the >> boot process which is not available on the native machine. >> Examples are the netboot firmware load address and now the >> boot menu

[Qemu-devel] [PATCH v4] migration: change blocktime type to uint32_t

2018-02-22 Thread Alexey Perevalov
Initially int64_t was used, but on PowerPC architecture, clang doesn't have atomic_*_8 function, so it produces link time error. QEMU is working with time as with 64bit value, but by fact 32 bit is enough with CLOCK_REALTIME. In this case blocktime will keep only 1200 hours time interval.

[Qemu-devel] [PATCH v4] Fix build on ppc platform in migration/postcopy-ram.c

2018-02-22 Thread Alexey Perevalov
V4->V3 - common helper was introduced and sanity check for probable time jumps (comment from David) V2->V3 - use UINT32_MAX instead of 0x (comment from Philippe) - use lelative time to avoid milliseconds overflow in uint32 (comment from David) V2->V1 This is a second

Re: [Qemu-devel] [PATCH V4 2/3] tests/migration: Add migration-test header file

2018-02-22 Thread Andrew Jones
On Wed, Feb 21, 2018 at 10:44:16PM -0600, Wei Huang wrote: > This patch moves the settings related migration-test from the > migration-test.c file to a seperate header file. It also renames the > x86-a-b-bootblock.s file extension from .s to .S, allowing gcc > pre-processor to include the C-style

Re: [Qemu-devel] [PATCH V4 3/3] tests: Add migration test for aarch64

2018-02-22 Thread Andrew Jones
On Wed, Feb 21, 2018 at 10:44:17PM -0600, Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel

[Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c

2018-02-22 Thread Thomas Huth
The functions are only used in this single .c file, so there is no need to put all this code in a header that is included from multiple places. Signed-off-by: Thomas Huth --- hw/net/net_rx_pkt.c| 44 include/net/checksum.h | 44

Re: [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it

2018-02-22 Thread Philippe Mathieu-Daudé
ping? :) On 02/15/2018 11:29 PM, Philippe Mathieu-Daudé wrote: > using the sdbus_*() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > > RFC because how pl181_sdbus_create_inplace() doing class_init(SDBus) in > realize(pl181) seems weird... > > from

Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4)

2018-02-22 Thread Philippe Mathieu-Daudé
ping? :) On 02/15/2018 07:05 PM, Philippe Mathieu-Daudé wrote: > Since v3: > - use assert() in sd_state_name() and sd_response_name() (Alistair review) > - added sdmmc-internal.h & sdmmc-common.c to reuse helpers with hw/sd/core.c > > Since v2: > - split again in 2... this part is

Re: [Qemu-devel] [PATCH v3 2/5] keymap: use glib hash for kbd_layout_t

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 08:05:10AM +0100, Gerd Hoffmann wrote: > Drop home-grown lookup code, which is a strange mix of a lookup table > and a list. Use standard glib hash instead. > > Signed-off-by: Gerd Hoffmann > --- > ui/keymaps.c| 73 >

Re: [Qemu-devel] [PATCH v3] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-22 Thread Alberto Garcia
On Wed 21 Feb 2018 11:10:07 PM CET, Eric Blake wrote: >> This patch fixes several mistakes in the documentation of the >> compressed cluster descriptor: > > More things to consider, as followup patches: > > Note that both the L1 table, and the standard L2 descriptors, have a cap > on bit 55 as

Re: [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-02-22 Thread Peter Xu
On Wed, Feb 21, 2018 at 04:50:58PM +, Stefan Hajnoczi wrote: > On Wed, Jan 24, 2018 at 01:39:47PM +0800, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index 60bcf67b3a..76137ba2a4 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -246,6 +246,21 @@ static inline bool

Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-22 Thread Gerd Hoffmann
Hi, > Nice! Seems to be the last missing gap for local spice with cursor > dmabuf support, we'll do more testing on that for sure. Btw, another > method might be to add direct cursor dmabuf passing for spice as gl > output, is that correct way? Passing on the cursor sprite needs the hotspot

[Qemu-devel] [PATCH] hw/net: Remove unnecessary header includes

2018-02-22 Thread Thomas Huth
Headers like "hw/loader.h" and "qemu/sockets.h" are not needed in the hw/net/*.c files. And Some other headers are included via other headers already, so we can drop them, too. Signed-off-by: Thomas Huth --- hw/net/e1000.c | 1 - hw/net/lance.c | 3 --- hw/net/ne2000.c

[Qemu-devel] [PULL 8/9] keymap: record multiple keysym -> keycode mappings

2018-02-22 Thread Gerd Hoffmann
Sometimes the same keysym can be created using different key combinations. Record them all in the reverse keymap, not only the first one. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180222070513.8740-5-kra...@redhat.com ---

[Qemu-devel] [PULL 4/9] egl-helpers: add alpha channel to texture format

2018-02-22 Thread Gerd Hoffmann
Needed when rendering cursers which (unlike framebuffers) actually are transparent. Signed-off-by: Gerd Hoffmann Message-id: 20180220110433.20353-4-kra...@redhat.com --- ui/egl-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/egl-helpers.c

[Qemu-devel] [PULL 5/9] keymap: make struct kbd_layout_t private to ui/keymaps.c

2018-02-22 Thread Gerd Hoffmann
Also use kbd_layout_t pointers instead of void pointers. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180222070513.8740-2-kra...@redhat.com --- ui/keymaps.h | 29 ++--- ui/keymaps.c | 32

[Qemu-devel] [PULL 1/9] sdl2: fix hotkey keyup

2018-02-22 Thread Gerd Hoffmann
After some hotkey was pressed sdl2 doesn't forward the first modifier keyup event to the guest, resulting in stuck modifier keys. Fix the logic in handle_keyup(). Also gui_key_modifier_pressed doesn't need to be a global variable. Reported-by: Howard Spoelstra Tested-by:

[Qemu-devel] [PULL 0/9] Ui 20180222 patches

2018-02-22 Thread Gerd Hoffmann
The following changes since commit a6e0344fa0e09413324835ae122c4cadd7890231: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180220-pull-request' into staging (2018-02-20 14:05:00 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180222-pull-request

[Qemu-devel] [PULL 6/9] keymap: use glib hash for kbd_layout_t

2018-02-22 Thread Gerd Hoffmann
Drop home-grown lookup code, which is a strange mix of a lookup table and a list. Use standard glib hash instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180222070513.8740-3-kra...@redhat.com --- ui/keymaps.c| 73

Re: [Qemu-devel] [PATCH v2 2/3] qcow2: Don't allow overflow during cluster allocation

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 12:39:52 AM CET, Eric Blake wrote: > free_in_cluster = s->cluster_size - offset_into_cluster(s, offset); > do { > if (!offset || free_in_cluster < size) { > -int64_t new_cluster = alloc_clusters_noref(bs, s->cluster_size); > +int64_t

[Qemu-devel] [PULL 9/9] keymap: consider modifier state when picking a mapping

2018-02-22 Thread Gerd Hoffmann
Pass the modifier state to the keymap lookup function. In case multiple keysym -> keycode mappings exist look at the modifier state and prefer the mapping where the modifier state matches. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH V4 1/3] tests/migration: Convert the boot block compilation script into Makefile

2018-02-22 Thread Andrew Jones
On Wed, Feb 21, 2018 at 10:44:15PM -0600, Wei Huang wrote: > The x86 boot block header currently is generated with a shell script. > To better support other CPUs (e.g. aarch64), we convert the script > into Makefile. This allows us to 1) support cross-compilation easily, > and 2) avoid creating a

Re: [Qemu-devel] [PATCH v1 2/3] s390x/sclp: clean up sclp masks

2018-02-22 Thread Claudio Imbrenda
On Wed, 21 Feb 2018 18:30:12 +0100 Cornelia Huck wrote: > On Wed, 21 Feb 2018 17:42:57 +0100 > Claudio Imbrenda wrote: > > > On Wed, 21 Feb 2018 16:20:05 +0100 > > Cornelia Huck wrote: > > > > > On Tue, 20 Feb 2018 19:45:01

Re: [Qemu-devel] [PATCH v2 10/36] test-qemu-opts: Test qemu_opts_to_qdict_filtered()

2018-02-22 Thread Kevin Wolf
Am 21.02.2018 um 21:57 hat Eric Blake geschrieben: > On 02/21/2018 07:53 AM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > tests/test-qemu-opts.c | 125 > > + > > 1 file changed, 125 insertions(+) > > > > diff

[Qemu-devel] [PULL 2/9] console/opengl: split up dpy_gl_cursor ops

2018-02-22 Thread Gerd Hoffmann
Split the cursor callback into two, one for setting the dmabuf, one for setting the position. Also add hotspot information. Signed-off-by: Gerd Hoffmann Message-id: 20180220110433.20353-2-kra...@redhat.com --- include/ui/console.h | 13 - ui/console.c |

[Qemu-devel] [PULL 3/9] egl-headless: cursor_dmabuf: handle NULL cursor

2018-02-22 Thread Gerd Hoffmann
The cursor dmabuf can be NULL, in case no cursor defined by the guest. Happens for example when linux guests show the framebuffer console. Signed-off-by: Gerd Hoffmann Message-id: 20180220110433.20353-3-kra...@redhat.com --- ui/egl-headless.c | 15 +-- 1 file

Re: [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability

2018-02-22 Thread Peter Xu
On Wed, Feb 21, 2018 at 04:17:18PM +, Stefan Hajnoczi wrote: > On Wed, Jan 24, 2018 at 01:39:44PM +0800, Peter Xu wrote: > > diff --git a/qapi-schema.json b/qapi-schema.json > > index 5c06745c79..2490d5188e 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -102,21 +102,47 @@

Re: [Qemu-devel] [PATCH v2 3/3] qcow2: Avoid memory over-allocation on compressed images

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 12:39:53 AM CET, Eric Blake wrote: > +assert(!!s->cluster_data == !!s->cluster_cache); > +assert(csize < 2 * s->cluster_size + 512); > if (!s->cluster_data) { > -/* one more sector for decompressed data alignment */ > -

[Qemu-devel] block migration and MAX_IN_FLIGHT_IO

2018-02-22 Thread Peter Lieven
Hi, I stumbled across the MAX_INFLIGHT_IO field that was introduced in 2015 and was curious what was the reason to choose 512MB as readahead? The question is that I found that the source VM gets very unresponsive I/O wise while the initial 512MB are read and furthermore seems to stay

Re: [Qemu-devel] [PATCH v1 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-22 Thread Claudio Imbrenda
On Wed, 21 Feb 2018 18:06:36 +0100 Cornelia Huck wrote: > On Wed, 21 Feb 2018 17:28:49 +0100 > Claudio Imbrenda wrote: > > > On Wed, 21 Feb 2018 16:12:59 +0100 > > Cornelia Huck wrote: > > > > > On Tue, 20 Feb 2018 19:45:00

Re: [Qemu-devel] [Xen-devel] [PATCH] intel_iommu: allow updating FEADDR and FEUADDR with one 64bit write

2018-02-22 Thread Roger Pau Monné
On Wed, Jan 24, 2018 at 03:18:48PM +0100, Marek Marczykowski-Górecki wrote: > Allow updating those two adjacent 32bit fields with one 64bit write. > This fixes qemu crash when booting Xen inside. > > See discussion on Xen side of the thing here: > http://xen.markmail.org/message/6mrmemrnmhxvaxba

Re: [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing

2018-02-22 Thread Peter Xu
On Wed, Feb 21, 2018 at 04:00:07PM +, Stefan Hajnoczi wrote: > On Wed, Jan 24, 2018 at 01:39:43PM +0800, Peter Xu wrote: > > @@ -4034,12 +4044,29 @@ static void sortcmdlist(void) > > qsort((void *)info_cmds, array_num, elem_size, compare_mon_cmd); > > } > > > > +static GMainContext

[Qemu-devel] [PULL 7/9] keymap: numpad keysyms and keycodes are fixed

2018-02-22 Thread Gerd Hoffmann
No need to figure them at runtime from the keymap. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180222070513.8740-4-kra...@redhat.com --- ui/keymaps.c | 61 +--- 1 file

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Kevin Wolf
Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: > On 20/02/2018 18:04, Peter Lieven wrote: > > Hi, > > > > I remember we discussed a long time ago to limit the stack usage of all > > functions that are executed in a coroutine > > context to a very low value to be able to safely limit the

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Peter Lieven
Am 22.02.2018 um 11:57 schrieb Kevin Wolf: > Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: >> On 20/02/2018 18:04, Peter Lieven wrote: >>> Hi, >>> >>> I remember we discussed a long time ago to limit the stack usage of all >>> functions that are executed in a coroutine >>> context to a

Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support

2018-02-22 Thread Christian Borntraeger
On 02/21/2018 06:39 PM, Cornelia Huck wrote: > On Tue, 20 Feb 2018 16:05:54 +0100 > David Hildenbrand wrote: > >> On 20.02.2018 15:57, Cornelia Huck wrote: >>> On Tue, 20 Feb 2018 13:16:37 +0100 >>> David Hildenbrand wrote: >>> On 20.02.2018 13:05,

Re: [Qemu-devel] [PATCH] virtio-gpu-3d: add support for second capability set (v2)

2018-02-22 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180221015035.22964-1-airl...@gmail.com Subject: [Qemu-devel] [PATCH] virtio-gpu-3d:

Re: [Qemu-devel] [PATCH v4 08/11] sdcard: display command name when tracing CMD/ACMD

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: > put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c > As a general note, your commit messages are generally a bit shorter than I'd prefer. This is to some extent a personal style question, but if

Re: [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4)

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: > Since v3: > - use assert() in sd_state_name() and sd_response_name() (Alistair review) > - added sdmmc-internal.h & sdmmc-common.c to reuse helpers with hw/sd/core.c > > Since v2: > - split again in 2... this part is

Re: [Qemu-devel] [PATCH v3] qcow2: Replace align_offset() with ROUND_UP()

2018-02-22 Thread Alberto Garcia
ping On Thu 15 Feb 2018 02:10:08 PM CET, Alberto Garcia wrote: > The align_offset() function is equivalent to the ROUND_UP() macro so > there's no need to use the former. The ROUND_UP() name is also a bit > more explicit. > > This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() >

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Kevin Wolf
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this in > bdrv_refresh_filename(). > > Adding a new field to the BDS is not nice, but it is very simple and

Re: [Qemu-devel] [PULL 19/20] tcg/i386: Add vector operations

2018-02-22 Thread Max Reitz
On 2018-02-21 21:22, Richard Henderson wrote: > On 02/20/2018 08:44 AM, Max Reitz wrote: >> This patch makes make check with clang -m32 fail for me. (Interestingly >> enough, though, clang -m64 and gcc -m32 work fine.) > > What's really interesting is that gcc -m32 should *not* have worked, but

Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: > put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c > > Signed-off-by: Philippe Mathieu-Daudé Commit message talks about a function but the patch doesn't add any new functions ?

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-22 Thread Alberto Garcia
On Wed 21 Feb 2018 07:33:55 PM CET, Kevin Wolf wrote: [docs/qcow2-cache.txt] > While reviewing this, I read the whole document and stumbled across > these paragraphs: > >> The reason for this 1/4 ratio is to ensure that both caches cover the >> same amount of disk space. Note however that this

Re: [Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-22 Thread Alberto Garcia
On Wed 21 Feb 2018 05:59:58 PM CET, Eric Blake wrote: > But as Berto has convinced me that an externally produced image can > convince us to read up to 4M (even though we don't need that much to > decompress), A (harmless but funny) consequence of the way this works is that for any valid

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-22 Thread Peter Maydell
On 20 February 2018 at 13:26, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that

Re: [Qemu-devel] [RFC, PATCH, v1] hw/audio/opl2lpt: add support for OPL2LPT

2018-02-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180218144021.11641-1-vinc...@bernat.im Subject: [Qemu-devel] [RFC, PATCH, v1] hw/audio/opl2lpt: add support for OPL2LPT === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Kevin Wolf
Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: > Am 22.02.2018 um 11:57 schrieb Kevin Wolf: > > Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: > >> On 20/02/2018 18:04, Peter Lieven wrote: > >>> Hi, > >>> > >>> I remember we discussed a long time ago to limit the stack usage of all >

Re: [Qemu-devel] [PULL 00/22] re-factor softfloat and add fp16 functions

2018-02-22 Thread Peter Maydell
On 21 February 2018 at 11:05, Alex Bennée wrote: > The following changes since commit a6e0344fa0e09413324835ae122c4cadd7890231: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180220-pull-request' > into staging (2018-02-20 14:05:00 +) > > are available

Re: [Qemu-devel] Patch 9894dc0cdcc broke something

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 02:38:04PM +0300, Aleksey Kuleshov wrote: > Hello! > > I hit unexpected disconnections because of this patch: > > commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 > Author: Daniel P. Berrange > Date: Tue Jan 19 11:14:29 2016 + > > char:

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Peter Lieven
Am 22.02.2018 um 13:00 schrieb Daniel P. Berrangé: > On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven wrote: >> Am 22.02.2018 um 12:40 schrieb Daniel P. Berrangé: >>> On Thu, Feb 22, 2018 at 12:32:04PM +0100, Kevin Wolf wrote: Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: >

Re: [Qemu-devel] Patch 9894dc0cdcc broke something

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 02:38:04PM +0300, Aleksey Kuleshov wrote: > Hello! > > I hit unexpected disconnections because of this patch: > > commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 > Author: Daniel P. Berrange > Date: Tue Jan 19 11:14:29 2016 + > > char:

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Kevin Wolf
Am 22.02.2018 um 13:06 hat Peter Lieven geschrieben: > Am 22.02.2018 um 13:03 schrieb Daniel P. Berrangé: > > On Thu, Feb 22, 2018 at 01:02:05PM +0100, Peter Lieven wrote: > >> Am 22.02.2018 um 13:00 schrieb Daniel P. Berrangé: > >>> On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven wrote: >

Re: [Qemu-devel] [PATCH v8 02/26] block: Use children list in bdrv_refresh_filename

2018-02-22 Thread Kevin Wolf
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > bdrv_refresh_filename() should invoke itself recursively on all > children, not just on file. > > With that change, we can remove the manual invocations in blkverify, > quorum, commit, and mirror. > > Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 4/9] acpi: add build_append_gas() helper for Generic Address Structure

2018-02-22 Thread Igor Mammedov
it will help to add Generic Address Structure to ACPI tables without using packed C structures and avoid endianness issues as API doesn't need an explicit conversion. Signed-off-by: Igor Mammedov --- include/hw/acpi/aml-build.h | 20 hw/acpi/aml-build.c

[Qemu-devel] [PATCH 2/9] pc: replace pm object initialization with one-liner in acpi_get_pm_info()

2018-02-22 Thread Igor Mammedov
next patch will need it before it gets to piix4/lpc branches that initializes 'obj' now. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index

[Qemu-devel] [PATCH 0/9] generalize build_fadt()

2018-02-22 Thread Igor Mammedov
Series first cleanups ACPI code around build_fadt() and then converts current packed structure approach to a build_append_FOO() API, getting rid of error prone explicit endianness conversions in code and making build_fadt() look more like APCI table declaration from spec, which should be easier to

[Qemu-devel] [PATCH 5/9] pc: acpi: isolate FADT specific data into AcpiFadtData structure

2018-02-22 Thread Igor Mammedov
move FADT data initialization out of fadt_setup() into dedicated init_fadt_data() that will set common for pc/q35 values in AcpiFadtData structure and acpi_get_pm_info() will complement it with pc/q35 specific values initialization. That will allow to get rid of fadt_setup() and generalize

[Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-22 Thread Igor Mammedov
Extend generic build_fadt() to support rev5.1 FADT and reuse it for 'virt' board, it would allow to phase out usage of AcpiFadtDescriptorRev5_1 and later ACPI_FADT_COMMON_DEF. Signed-off-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 12 ++--

[Qemu-devel] [PATCH 9/9] tests: acpi: don't read all fields in test_acpi_fadt_table()

2018-02-22 Thread Igor Mammedov
there is no point to read fields here but not actually checking them so drop it and read only header + dsdt/facs addresses since it's needed later to fetch that tables. With this cleanup we can get rid of AcpiFadtDescriptorRev3/ ACPI_FADT_COMMON_DEF which have no users left. Signed-off-by: Igor

Re: [Qemu-devel] [PATCH v2] hw/char/stm32f2xx_usart: fix TXE/TC bit handling

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:27, Alistair Francis wrote: > On Tue, Feb 13, 2018 at 12:54 PM, Richard Braun wrote: >> I/O currently being synchronous, there is no reason to ever clear the >> SR_TXE bit. However the SR_TC bit may be cleared by software writing

Re: [Qemu-devel] [PATCH] virtio-gpu-3d: add support for second capability set (v2)

2018-02-22 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180221015035.22964-1-airl...@gmail.com Subject: [Qemu-devel] [PATCH] virtio-gpu-3d: add

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Peter Lieven
Am 22.02.2018 um 12:32 schrieb Kevin Wolf: > Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: >> Am 22.02.2018 um 11:57 schrieb Kevin Wolf: >>> Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: On 20/02/2018 18:04, Peter Lieven wrote: > Hi, > > I remember we discussed a

Re: [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6)

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 02:29, Philippe Mathieu-Daudé wrote: > Hi, > > Since v2: > - pl181: remove legacy sd_set_cb() (Peter) > > Since v1: > - rebased on /master (Peter sdcard reset() patches) > - fix milkymist-mmc from previous seris using instance_init (Michael Walle) > > This

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Peter Lieven
Am 22.02.2018 um 12:40 schrieb Daniel P. Berrangé: > On Thu, Feb 22, 2018 at 12:32:04PM +0100, Kevin Wolf wrote: >> Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: >>> Am 22.02.2018 um 11:57 schrieb Kevin Wolf: Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: > On 20/02/2018

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Christian Borntraeger
Series Acked-by: Christian Borntraeger menu on scsi and dasd bootmaps tested successfully. There is one thing that we might want to fix (can be an addon patch since this is a non-customer scenario (no libvirt)). If you start QEMU manually without a bootindex, the

Re: [Qemu-devel] Patch 9894dc0cdcc broke something

2018-02-22 Thread Aleksey Kuleshov
I'm using 2.11.0. 22.02.2018, 14:45, "Daniel P. Berrangé" : > On Thu, Feb 22, 2018 at 02:38:04PM +0300, Aleksey Kuleshov wrote: >>  Hello! >> >>  I hit unexpected disconnections because of this patch: >> >>  commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 >>  Author: Daniel

Re: [Qemu-devel] [PATCH v2 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable

2018-02-22 Thread Christian Borntraeger
On 02/21/2018 05:56 PM, Halil Pasic wrote: > The 'bit' field of the 'S390FeatDef' structure is not applicable to all > its instances. Currently this field is not applicable, and remains > unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 > specified for multiple such

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Peter Lieven
Am 22.02.2018 um 13:03 schrieb Daniel P. Berrangé: > On Thu, Feb 22, 2018 at 01:02:05PM +0100, Peter Lieven wrote: >> Am 22.02.2018 um 13:00 schrieb Daniel P. Berrangé: >>> On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven wrote: Am 22.02.2018 um 12:40 schrieb Daniel P. Berrangé: >

[Qemu-devel] [PATCH v1] chardev: fix handling of EAGAIN for TCP chardev

2018-02-22 Thread Daniel P . Berrangé
When this commit was applied commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 Author: Daniel P. Berrange Date: Tue Jan 19 11:14:29 2016 + char: convert from GIOChannel to QIOChannel The tcp_chr_recv() function was changed to return QIO_CHANNEL_ERR_BLOCK

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Viktor Mihajlovski
On 22.02.2018 12:51, Christian Borntraeger wrote: > Series > Acked-by: Christian Borntraeger > > > menu on scsi and dasd bootmaps tested successfully. > > There is one thing that we might want to fix (can be an addon patch since > this is a non-customer > scenario (no

Re: [Qemu-devel] [PATCH v1] chardev: fix handling of EAGAIN for TCP chardev

2018-02-22 Thread Marc-André Lureau
On Thu, Feb 22, 2018 at 1:13 PM, Daniel P. Berrangé wrote: > When this commit was applied > > commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 > Author: Daniel P. Berrange > Date: Tue Jan 19 11:14:29 2016 + > > char: convert from

[Qemu-devel] [PATCH 6/9] pc: acpi: use build_append_foo() API to construct FADT

2018-02-22 Thread Igor Mammedov
build_append_foo() API doesn't need explicit endianness conversions which eliminates a source of errors and it makes build_fadt() look like declarative definition of FADT table in ACPI spec, which makes it easy to review. Also it allows easily extending FADT to support other revisions which will

[Qemu-devel] [PATCH 1/9] acpi: remove unused acpi-dsdt.aml

2018-02-22 Thread Igor Mammedov
SeaBIOS blob which is currently shipped with QEMU doesn't need acpi-dsdt.aml nor is able to use it and code that loaded it QEMU was removed by (commit 9fb7aaaf4c "pc: drop external DSDT loading") in 2013. Signed-off-by: Igor Mammedov CC: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180220132627.4163-1-hlan...@devever.net Subject: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [Bug 1750229] Re: virtio-blk-pci regression: softlock in guest kernel at module loading

2018-02-22 Thread Matwey V. Kornilov
The same story with 4.15.4 host kernel. 2018-02-21 11:58 GMT+03:00 Matwey V. Kornilov : > Well, last_avail_idx equals to shadow_avail_idx and both of them are 1 > at the qemu side. So, only one request is transferred. > I wonder why, probably something is badly cached,

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 12:32:04PM +0100, Kevin Wolf wrote: > Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: > > Am 22.02.2018 um 11:57 schrieb Kevin Wolf: > > > Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: > > >> On 20/02/2018 18:04, Peter Lieven wrote: > > >>> Hi, > > >>> > > >>>

[Qemu-devel] Patch 9894dc0cdcc broke something

2018-02-22 Thread Aleksey Kuleshov
Hello! I hit unexpected disconnections because of this patch: commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 Author: Daniel P. Berrange Date: Tue Jan 19 11:14:29 2016 + char: convert from GIOChannel to QIOChannel In preparation for introducing TLS

Re: [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 02:29, Philippe Mathieu-Daudé wrote: > using the sdbus_*() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > > RFC because how pl181_sdbus_create_inplace() doing class_init(SDBus) in > realize(pl181) seems weird... In the two other

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven wrote: > Am 22.02.2018 um 12:40 schrieb Daniel P. Berrangé: > > On Thu, Feb 22, 2018 at 12:32:04PM +0100, Kevin Wolf wrote: > >> Am 22.02.2018 um 12:01 hat Peter Lieven geschrieben: > >>> Am 22.02.2018 um 11:57 schrieb Kevin Wolf: > Am

Re: [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Acked-by: Alistair Francis > --- > hw/sd/sd.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 01:02:05PM +0100, Peter Lieven wrote: > Am 22.02.2018 um 13:00 schrieb Daniel P. Berrangé: > > On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven wrote: > >> Am 22.02.2018 um 12:40 schrieb Daniel P. Berrangé: > >>> On Thu, Feb 22, 2018 at 12:32:04PM +0100, Kevin Wolf

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 01:06:33PM +0100, Peter Lieven wrote: > Am 22.02.2018 um 13:03 schrieb Daniel P. Berrangé: > > On Thu, Feb 22, 2018 at 01:02:05PM +0100, Peter Lieven wrote: > >> Am 22.02.2018 um 13:00 schrieb Daniel P. Berrangé: > >>> On Thu, Feb 22, 2018 at 12:51:58PM +0100, Peter Lieven

Re: [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths simplification

2018-02-22 Thread Kevin Wolf
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > When invoking drive-mirror in absolute-paths mode, the target's backing > BDS is assigned to it in mirror_exit(). The current logic only does so > if the target does not have that backing BDS already; but it actually > cannot have a backing BDS

[Qemu-devel] [PATCH 3/9] acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddress

2018-02-22 Thread Igor Mammedov
Drop duplicate in form of Acpi20GenericAddress and reuse AcpiGenericAddress. Signed-off-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/include/hw/acpi/acpi-defs.h

Re: [Qemu-devel] [PATCH v1] chardev: fix handling of EAGAIN for TCP chardev

2018-02-22 Thread Aleksey Kuleshov
Thank you, Daniel! 22.02.2018, 15:14, "Daniel P. Berrangé" : > When this commit was applied > >   commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 >   Author: Daniel P. Berrange >   Date: Tue Jan 19 11:14:29 2016 + > > char: convert from

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Thomas Huth
On 22.02.2018 12:51, Christian Borntraeger wrote: > Series > Acked-by: Christian Borntraeger OK, thanks. I can pick up the patches from this series and fix the comment in patch 5 and the missing break in patch 13 manually, no need to resend so far. > menu on scsi and

[Qemu-devel] [PATCH 7/9] acpi: move build_fadt() from i386 specific to generic ACPI source

2018-02-22 Thread Igor Mammedov
it will be extended and reused in follow up patch by ARM target Signed-off-by: Igor Mammedov --- include/hw/acpi/aml-build.h | 3 ++ hw/acpi/aml-build.c | 105 +++ hw/arm/virt-acpi-build.c| 6 +-- hw/i386/acpi-build.c

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger Thanks!!! menu on scsi and dasd bootmaps tested successfully. There is one thing that we might want to fix (can be an addon

[Qemu-devel] [PATCH v3 3/4] qcow2: Don't allow overflow during cluster allocation

2018-02-22 Thread Eric Blake
Our code was already checking that we did not attempt to allocate more clusters than what would fit in an INT64 (the physical maximimum if we can access a full off_t's worth of data). But this does not catch smaller limits enforced by various spots in the qcow2 image description: L1 and normal

[Qemu-devel] [PATCH] iotests: Test abnormally large size in compressed cluster descriptor

2018-02-22 Thread Alberto Garcia
L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a multiple of the sector

Re: [Qemu-devel] [PATCH v3 5/5] aarch64-linux-user: Add support for SVE signal frame records

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > Depending on the currently selected size of the SVE vector registers, > we can either store the data within the "standard" allocation, or we > may beedn to allocate additional space with an EXTRA record. > >

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-22 Thread Ciro Santilli
On Thu, Feb 22, 2018 at 7:10 AM, Pavel Dovgalyuk wrote: >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >> > From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >> > On Wed, Feb 21, 2018 at 6:41 AM, Pavel Dovgalyuk >> > wrote: >> > >> From: Ciro

[Qemu-devel] [PATCH v2 2/6] target/mips: reimplement SC instruction emulation and use cmpxchg

2018-02-22 Thread Aleksandar Markovic
From: Leon Alrae Completely rewrite conditional stores handling. Use cmpxchg. This eliminates need for separate implementations of SC instruction emulation for user and system emulation. Signed-off-by: Leon Alrae Signed-off-by: Miodrag Dinic

[Qemu-devel] [PATCH v2 3/6] hw/mips_int: hold BQL for all interrupt requests

2018-02-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Make sure BQL is held for all interrupt requests. For MTTCG-enabled configurations, handling soft and hard interrupts between vCPUs must be properly locked. By acquiring BQL, make sure all paths triggering an IRQ are synchronized.

[Qemu-devel] [PATCH v2 5/6] hw/mips_cpc: kick a VP when putting it into Run state

2018-02-22 Thread Aleksandar Markovic
From: Miodrag Dinic While testing mttcg VP0 could get stuck in a loop waiting for other VPs to come up (which never actually happens). To fix this, kick VPs while they are being powered up by Cluster Power Controller in an async task which is triggered once the host

  1   2   3   4   >