Re: [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c

2018-02-27 Thread Thomas Huth
On 27.02.2018 08:55, Jason Wang wrote: > > > On 2018年02月22日 17:04, Thomas Huth wrote: >> The functions are only used in this single .c file, so there is >> no need to put all this code in a header that is included from >> multiple places. >> >> Signed-off-by: Thomas Huth >> ---

[Qemu-devel] [PULL 12/12] curses: build as ui module

2018-02-27 Thread Gerd Hoffmann
Also drop curses libs from libs_softmmu. Add CURSES_{CFLAGS,LIBS} variables so we can use them for linking the curses module. Shared library dependencies dropped from qemu-system-*: libncursesw.so.5 => /lib64/libncursesw.so.5 libtinfo.so.5 => /lib64/libtinfo.so.5 Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 10/12] sdl: build as ui module

2018-02-27 Thread Gerd Hoffmann
Shared library dependencies dropped from qemu-system-*: libSDL2-2.0.so.0 => /lib64/libSDL2-2.0.so.0 Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-11-kra...@redhat.com --- configure| 2 +- Makefile.objs| 1 + ui/Makefile.objs | 3 ++- 3 files

[Qemu-devel] [PULL 03/12] cocoa: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-4-kra...@redhat.com --- include/ui/console.h | 12 vl.c | 3 --- ui/cocoa.m | 14 +- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PULL 01/12] console: add qemu display registry, add gtk

2018-02-27 Thread Gerd Hoffmann
Add a registry for user interfaces. Add qemu_display_init and qemu_display_early_init helper functions for display initialization. Hook up gtk ui as first user. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-2-kra...@redhat.com --- include/ui/console.h | 32

[Qemu-devel] [PULL 05/12] egl-headless: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-6-kra...@redhat.com --- include/ui/console.h | 3 --- ui/egl-headless.c| 20 +++- vl.c | 12 3 files changed, 19 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PULL 11/12] gtk: build as ui module

2018-02-27 Thread Gerd Hoffmann
Also drop gtk and vte libs from libs_softmmu, so the libs are not pulled in unless the gtk module actually gets loaded. Shared library dependencies dropped from qemu-system-*: libEGL.so.1 => /lib64/libEGL.so.1 libGL.so.1 => /lib64/libGL.so.1 libXcomposite.so.1 => /lib64/libXcomposite.so.1

[Qemu-devel] [PULL 07/12] console: add ui module loading support

2018-02-27 Thread Gerd Hoffmann
If a requested user interface is not available, try loading it as module, simliar to block layer modules. Needed to keep things working when followup patches start to build user interfaces as modules. Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PULL 00/12] Ui 20180227 patches

2018-02-27 Thread Gerd Hoffmann
The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180227-pull-request for you to fetch changes up

[Qemu-devel] [PULL 08/12] configure: add X11 vars to config-host.mak

2018-02-27 Thread Gerd Hoffmann
Simplifies handling the X11 dependency, also makes ui/Makefile.objs more readable. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-9-kra...@redhat.com --- configure| 10 -- ui/Makefile.objs | 5 - 2 files changed, 12 insertions(+), 3

[Qemu-devel] [PULL 09/12] configure: opengl doesn't depend on x11

2018-02-27 Thread Gerd Hoffmann
So remove x11 from pkg-config check and don't add x11 cflags/libs to opengl cflags/libs. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-10-kra...@redhat.com --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure

[Qemu-devel] [PULL 06/12] console: add and use qemu_display_find_default

2018-02-27 Thread Gerd Hoffmann
Using the new display registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-7-kra...@redhat.com --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files

[Qemu-devel] [PULL 04/12] curses: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-5-kra...@redhat.com --- include/ui/console.h | 12 ui/curses.c | 14 +- vl.c | 17 ++--- 3 files changed, 15 insertions(+), 28 deletions(-) diff --git

[Qemu-devel] [PULL 02/12] sdl: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-3-kra...@redhat.com --- include/ui/console.h | 19 --- ui/sdl.c | 24 +--- ui/sdl2.c| 17 +++-- vl.c | 15 +-- 4

[Qemu-devel] [PATCH 2/2] spapr: harden code that depends on VSMT

2018-02-27 Thread Greg Kurz
VSMT must be set in order to compute VCPU ids. This means that the following functions must not be called before spapr_set_vsmt_mode() was called: - spapr_vcpu_id() - spapr_is_thread0_in_vcore() - xics_max_server_number() We had a recent regression where the latter would be called before VSMT was

[Qemu-devel] [PATCH] s390-ccw: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
It is possible that certain QEMU configurations may not create an IPLB (such as when -kernel is provided). In this case, a misleading error message will be printed stating that the "boot menu is not supported for this device type". To amend this, only print this message iff boot menu=on was

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 66/67] target/arm: Implement SVE floating-point round to integral value

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 > target/arm/sve_helper.c| 8 + > target/arm/translate-sve.c | 80 >

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 65/67] target/arm: Implement SVE floating-point convert to integer

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 30 > target/arm/sve_helper.c| 16 +++ > target/arm/translate-sve.c | 70 >

[Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Tony Krowiak
A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabled by the kernel only if the AP

Re: [Qemu-devel] [RFC] qemu-img: Drop BLK_ZERO from convert

2018-02-27 Thread Stefan Hajnoczi
On Mon, Feb 26, 2018 at 06:03:13PM +0100, Max Reitz wrote: > There are filesystems (among which is tmpfs) that have a hard time > reporting allocation status. That is definitely a bug in them. > > However, there is no good reason why qemu-img convert should query the > allocation status in the

Re: [Qemu-devel] [PATCH] tests/libqos: Check for valid dev pointer when looking for PCI devices

2018-02-27 Thread Stefan Hajnoczi
On Tue, Feb 27, 2018 at 07:44:44AM +0100, Thomas Huth wrote: > dev could be NULL if the PCI device can not be found due to some > reasons, so we must not dereference the pointer in this case. > > Signed-off-by: Thomas Huth > --- > tests/libqos/virtio-pci.c | 4 +++- > 1 file

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-27 Thread Stefan Hajnoczi
On Sun, Feb 25, 2018 at 12:35:55PM +0800, Su Hang wrote: > Su Hang (3): > util/uri.c: Coding style check, Only whitespace involved. > util/uri.c: remove brackets () that wrap `return` statement's content. > util/uri.c: wrap single statement blocks with braces {} > > util/uri.c | 1753 >

[Qemu-devel] [PATCH v4 0/5] minor compression improvements

2018-02-27 Thread Eric Blake
In v4: - patch 2 has even more wording tweaks [Kevin] - patch 3 is new [Berto] - patch 5 fixes an off-by-one [Berto] Eric Blake (5): qcow2: Prefer byte-based calls into bs->file qcow2: Document some maximum size constraints qcow2: Reduce REFT_OFFSET_MASK qcow2: Don't allow overflow during

Re: [Qemu-devel] [PATCH v2] slirp: Add domainname option to slirp's DHCP server

2018-02-27 Thread Benjamin Drung
Hi, Am Freitag, den 16.02.2018, 16:23 -0300 schrieb Philippe Mathieu-Daudé: > diff --git a/slirp/slirp.c b/slirp/slirp.c > > index 1cb6b07004..4f29753444 100644 > > --- a/slirp/slirp.c > > +++ b/slirp/slirp.c > > @@ -286,7 +286,7 @@ Slirp *slirp_init(int restricted, bool > > in_enabled, struct

Re: [Qemu-devel] [PATCH v2 07/29] qapi: Turn generators into modules

2018-02-27 Thread Daniel P . Berrangé
On Tue, Feb 27, 2018 at 09:53:22AM -0600, Eric Blake wrote: > On 02/11/2018 03:35 AM, Markus Armbruster wrote: > > The next commit will introduce a common driver program for all > > generators. The generators need to be modules for that. qapi2texi.py > > already is. Make the other generators

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 17:52, Alex Bennée wrote: > > Richard Henderson writes: > >> On 02/27/2018 06:38 AM, Alex Bennée wrote: >>> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >>> uint32_t insn) >>> } >>>

Re: [Qemu-devel] [PATCH v2 62/67] target/arm: Implement SVE FP Compare with Zero Group

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 42 ++ > target/arm/sve_helper.c| 45

Re: [Qemu-devel] [Qemu-block] [PATCH] vl: introduce vm_shutdown()

2018-02-27 Thread Stefan Hajnoczi
On Fri, Feb 23, 2018 at 04:20:44PM +0800, Fam Zheng wrote: > On Tue, 02/20 13:10, Stefan Hajnoczi wrote: > > 1. virtio_scsi_handle_cmd_vq() racing with iothread_stop_all() hits the > >virtio_scsi_ctx_check() assertion failure because the BDS AioContext > >has been modified by

Re: [Qemu-devel] [PATCH v2 67/67] target/arm: Implement SVE floating-point unary operations

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 ++ > target/arm/sve_helper.c| 8 > target/arm/translate-sve.c | 28

[Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-02-27 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute file (see docs/vfio-ap.txt). The mediated matrix device will

Re: [Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-27 Thread Igor Mammedov
On Tue, 27 Feb 2018 16:07:49 +0100 Auger Eric wrote: > Hi Igor, > On 22/02/18 13:42, Igor Mammedov wrote: > > Extend generic build_fadt() to support rev5.1 FADT > > and reuse it for 'virt' board, it would allow to > > phase out usage of AcpiFadtDescriptorRev5_1 and > >

Re: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-02-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1519746259-27710-1-git-send-email-akrow...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 59/67] target/arm: Implement SVE Floating Point Multiply Indexed Group

2018-02-27 Thread Richard Henderson
On 02/27/2018 07:18 AM, Peter Maydell wrote: > On 17 February 2018 at 18:23, Richard Henderson > wrote: >> Signed-off-by: Richard Henderson >> --- >> target/arm/helper.h| 14 ++ >> target/arm/translate-sve.c | 44

[Qemu-devel] [PATCH v4 4/5] qcow2: Don't allow overflow during cluster allocation

2018-02-27 Thread Eric Blake
Our code was already checking that we did not attempt to allocate more clusters than what would fit in an INT64 (the physical maximimum if we can access a full off_t's worth of data). But this does not catch smaller limits enforced by various spots in the qcow2 image description: L1 and normal

Re: [Qemu-devel] [PATCH v3 0/9] enable numa configuration before machine_init() from QMP

2018-02-27 Thread Igor Mammedov
On Fri, 16 Feb 2018 13:37:12 +0100 Igor Mammedov wrote: Eric, Adding you to CC list (git send-mail somehow haven't noticed you in cover letter). Could you please look at QAPI/QMP parts of this series. > v1->v3: > * introduce PRECONFIG runstate with -preconfig option. >

[Qemu-devel] [PATCH v4 3/5] qcow2: Reduce REFT_OFFSET_MASK

2018-02-27 Thread Eric Blake
Match our code to the spec change in the previous patch - there's no reason for the refcount table to allow larger offsets than the L1/L2 tables. In practice, no image has more than 64PB of allocated clusters anyways, as anything beyond that can't be expressed via L2 mappings to host offsets.

Re: [Qemu-devel] QEMU GSoC 2018 Project Idea (Apply polling to QEMU NVMe)

2018-02-27 Thread Stefan Hajnoczi
On Tue, Feb 27, 2018 at 12:04:48PM +0100, Paolo Bonzini wrote: > On 27/02/2018 10:05, Huaicheng Li wrote: > > Great to know that you'd like to mentor the project! If so, can we make it > > an official project idea and put it on QEMU GSoC page? > > Submissions need not come from the QEMU GSoC

Re: [Qemu-devel] [RFC v4 02/21] blockjobs: model single jobs as transactions

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: model all independent jobs as single job transactions. It's one less case we have to worry about when we add more states to the transition machine. This way, we can just treat all job lifetimes exactly the same. This helps tighten assertions of the STM

Re: [Qemu-devel] [RFC 2/5] vhost-user: Introduce new request to send virtio device status

2018-02-27 Thread Maxime Coquelin
On 02/27/2018 04:01 PM, Michael S. Tsirkin wrote: On Fri, Feb 16, 2018 at 06:29:07PM +0100, Maxime Coquelin wrote: diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt index 9fcf48d611..daa452bd36 100644 --- a/docs/interop/vhost-user.txt +++ b/docs/interop/vhost-user.txt @@

[Qemu-devel] [PATCH v4 2/5] qcow2: Document some maximum size constraints

2018-02-27 Thread Eric Blake
Although off_t permits up to 63 bits (8EB) of file offsets, in practice, we're going to hit other limits first. Document some of those limits in the qcow2 spec, and how choice of cluster size can influence some of the limits. While at it, notice that since we cannot map any virtual cluster to

Re: [Qemu-devel] [RFC v4 03/21] blockjobs: add manual property

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: This property will be used to opt-in to the new BlockJobs workflow that allows a tighter, more explicit control over transitions from one runstate to another. While we're here, fix up the documentation for block_job_create a little bit. Signed-off-by:

Re: [Qemu-devel] [PATCH v6 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-02-27 Thread Peter Maydell
On 23 February 2018 at 17:21, Alistair Francis wrote: > Allow the guest to determine the time set from the QEMU command line. > > This includes adding a trace event to debug the new time. > > Signed-off-by: Alistair Francis Thanks for

[Qemu-devel] [PATCH v4 5/5] qcow2: Avoid memory over-allocation on compressed images

2018-02-27 Thread Eric Blake
When reading a compressed image, we were allocating s->cluster_data to 32*cluster_size + 512 (possibly over 64 megabytes, for an image with 2M clusters). Let's check out the history: Back when qcow2 was first written, we used s->cluster_data for everything, including copy_sectors() and

Re: [Qemu-devel] [RFC v4 04/21] blockjobs: add status enum

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: We're about to add several new states, and booleans are becoming unwieldly and difficult to reason about. It would help to have a more explicit bookkeeping of the state of blockjobs. To this end, add a new "status" field and add our existing states in a

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread John Snow
On 02/27/2018 11:27 AM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> The state transition table has mostly been implied. We're about to make >> it a bit more complex, so let's make the STM explicit instead. >> >> Perform state transitions with a function that for now

Re: [Qemu-devel] [RFC v4 01/21] blockjobs: fix set-speed kick

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: If speed is '0' it's not actually "less than" the previous speed. Kick the job in this case too. Signed-off-by: John Snow --- blockjob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [RFC QEMU PATCH v4 02/10] xen-hvm: create the hotplug memory region on Xen

2018-02-27 Thread Anthony PERARD
On Thu, Dec 07, 2017 at 06:18:04PM +0800, Haozhong Zhang wrote: > The guest physical address of vNVDIMM is allocated from the hotplug > memory region, which is not created when QEMU is used as Xen device > model. In order to use vNVDIMM for Xen HVM domains, this commit reuses > the code for pc

Re: [Qemu-devel] [RFC QEMU PATCH v4 05/10] xen-hvm: initialize fw_cfg interface

2018-02-27 Thread Anthony PERARD
On Thu, Dec 07, 2017 at 06:18:07PM +0800, Haozhong Zhang wrote: > Xen is going to reuse QEMU to build ACPI of some devices (e.g., NFIT > and SSDT for NVDIMM) for HVM domains. The existing QEMU ACPI build > code requires a fw_cfg interface which will also be used to pass QEMU > built ACPI to Xen.

Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches

2018-02-27 Thread Peter Maydell
ository at: > > git://git.kraxel.org/qemu tags/ui-20180227-pull-request > > for you to fetch changes up to 8742dcaf7bcfa1ef8720f34dab984f153c87c9f3: > > curses: build as ui module (2018-02-26 15:10:12 +0100) > > >

Re: [Qemu-devel] [PATCH v4 00/31] Add ARMv8.2 half-precision functions

2018-02-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180227143852.11175-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v4 00/31] Add ARMv8.2 half-precision functions === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v2 61/67] target/arm: Implement SVE Floating Point Unary Operations - Unpredicated Group

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 8 > target/arm/translate-sve.c | 43 +++ >

[Qemu-devel] [PATCH v2 1/5] s390: doc: detailed specifications for AP virtualization

2018-02-27 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- docs/vfio-ap.txt

[Qemu-devel] [PATCH] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-02-27 Thread Liran Alon
This MSR returns the number of #SMIs that occurred on CPU since boot. KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT") introduced support for emulating this MSR. This commit adds support for QEMU to save/load this MSR for migration purposes. Signed-off-by: Liran Alon

Re: [Qemu-devel] [PATCH 0/1] slirp: Add domainname option to slirp's DHCP server

2018-02-27 Thread Benjamin Drung
Am Samstag, den 17.02.2018, 22:16 +0100 schrieb Samuel Thibault: > Hello, > > Benjamin Drung, on ven. 16 févr. 2018 13:55:03 +0100, wrote: > > Or should the command line option be simpler, but how should it be > > specified > > then? Maybe > > > > -net > >

[Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update my email address

2018-02-27 Thread Alistair Francis
I am leaving Xilinx, so to avoid having an email address that bouunces update my maintainer address to point to my personal email address. Signed-off-by: Alistair Francis Signed-off-by: Alistair Francis --- MAINTAINERS | 12 ++-- 1

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread Kevin Wolf
Am 27.02.2018 um 17:45 hat John Snow geschrieben: > > > On 02/27/2018 11:27 AM, Kevin Wolf wrote: > > Am 24.02.2018 um 00:51 hat John Snow geschrieben: > >> The state transition table has mostly been implied. We're about to make > >> it a bit more complex, so let's make the STM explicit instead.

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Richard Henderson
On 02/27/2018 06:38 AM, Alex Bennée wrote: > @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, > uint32_t insn) > } > /* fall through */ > case 0x9: /* FMUL, FMULX */ > -if (!extract32(size, 1, 1)) { > +if (size == 1) { >

Re: [Qemu-devel] [PATCH 0/5] Versatile Express SiI9022 emulation

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:48, Linus Walleij wrote: > This series adds proper display bridge/connector emulation > for the Versatile Express, implementing a simple Silicon > Image 9022 emulation spawning a DDC I2C child. > > After the series the Versatile Express is

Re: [Qemu-devel] [PATCH v2 RFC] scripts/checkpatch.pl: add check for `while` and `for`

2018-02-27 Thread Stefan Hajnoczi
On Mon, Feb 26, 2018 at 10:53:18AM +0800, Su Hang wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 1b4b812e28fa..10c138344fa9 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2353,7 +2353,8 @@ sub process { > } > > # check for

Re: [Qemu-devel] [PATCH V6 3/4] tests/migration: Add migration-test header file

2018-02-27 Thread Wei Huang
On 02/27/2018 05:57 AM, Dr. David Alan Gilbert wrote: > * Wei Huang (w...@redhat.com) wrote: >> This patch moves the settings related migration-test from the >> migration-test.c file to a seperate header file. It also renames the >> x86-a-b-bootblock.s file extension from .s to .S, allowing gcc

Re: [Qemu-devel] [RFC QEMU PATCH v4 00/10] Implement vNVDIMM for Xen HVM guest

2018-02-27 Thread Anthony PERARD
On Thu, Dec 07, 2017 at 06:18:02PM +0800, Haozhong Zhang wrote: > This is the QEMU part patches that works with the associated Xen > patches to enable vNVDIMM support for Xen HVM domains. Xen relies on > QEMU to build guest NFIT and NVDIMM namespace devices, and allocate > guest address space for

Re: [Qemu-devel] [RFC v4 07/21] blockjobs: add block_job_verb permission table

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Which commands ("verbs") are appropriate for jobs in which state is > also somewhat burdensome to keep track of. > > As of this commit, it looks rather useless, but begins to look more > interesting the more states we add to the STM table. > >

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 15:50, Stef O'Rear wrote: > On Tue, Feb 27, 2018 at 6:01 AM, Peter Maydell > wrote: >> On 27 February 2018 at 00:15, Michael Clark wrote: >>> The spike_v1.9 >>> machine has been renamed to spike_v1.9.1 to

Re: [Qemu-devel] [PATCH v2 60/67] target/arm: Implement SVE FP Fast Reduction Group

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 35 ++ > target/arm/sve_helper.c| 61 >

[Qemu-devel] [PATCH 0/2] spapr: fix migration of old guests

2018-02-27 Thread Greg Kurz
Recent VSMT work broke migration of old guests as reported in this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1549087 Patch 1 fixes the issue, while patch 2 is a tentative code reorg to ensure VSMT is set before anyone tries to use spapr->vsmt. -- Greg --- Greg Kurz (2): spapr:

Re: [Qemu-devel] [PULL 0/1] Vga 20180227 patches

2018-02-27 Thread Peter Maydell
ository at: > > git://git.kraxel.org/qemu tags/vga-20180227-pull-request > > for you to fetch changes up to 5643cc94ac1cbc23e1ba6b16b6a88e1ce7b3f6a9: > > virtio-gpu-3d: add support for second capability set (v4) (2018-02-26 > 13:41:34 +0100) > > --

[Qemu-devel] [RFC PATCH 0/2] Increase usability of external snapshots

2018-02-27 Thread Richard Palethorpe
Hello, Following on from the discussion about creating savevm/loadvm QMP equivalents. I decided to take the advice given that we should use external snapshots. However reverting to a snapshot currently requires QEMU to be restarted with "-incoming". Restarting QEMU requires a fair bit of book

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Halil Pasic
On 02/27/2018 05:27 PM, Cornelia Huck wrote: > On Tue, 27 Feb 2018 10:44:19 -0500 > Tony Krowiak wrote: >> A new CPU model feature and two new CPU model facilities are >> introduced to support AP devices for a KVM guest. >> >> CPU model features: >> >> 1. The

Re: [Qemu-devel] [RFC QEMU PATCH v4 03/10] hostmem-xen: add a host memory backend for Xen

2018-02-27 Thread Anthony PERARD
On Thu, Dec 07, 2017 at 06:18:05PM +0800, Haozhong Zhang wrote: > diff --git a/backends/hostmem.c b/backends/hostmem.c > index ee2c2d5bfd..ba13a52994 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -12,6 +12,7 @@ > #include "qemu/osdep.h" > #include "sysemu/hostmem.h" >

Re: [Qemu-devel] [PATCH 5/5] arm/vexpress: Add proper display connector emulation

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:49, Linus Walleij wrote: > This adds the SiI9022 and EDID I2C devices to the ARM Versatile > Express machine, and selects the two I2C devices necessary in the > arm-softmmy.mak configuration so everything will build smoothly. > > I am

Re: [Qemu-devel] [PATCH v2 0/2] xilinx_spips: Update CS assertion when striping

2018-02-27 Thread Peter Maydell
On 23 February 2018 at 23:22, Francisco Iglesias wrote: > Hi, > > The first patch in this series attempts to correct the slave selection when > using the striping functionality in the QSPI. The second patch in the series > updates the QIOR/QIOR4 commands to use 8 dummy

Re: [Qemu-devel] [RFC v4 01/21] blockjobs: fix set-speed kick

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > If speed is '0' it's not actually "less than" the previous speed. > Kick the job in this case too. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [RFC v4 03/21] blockjobs: add manual property

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > This property will be used to opt-in to the new BlockJobs workflow > that allows a tighter, more explicit control over transitions from > one runstate to another. > > While we're here, fix up the documentation for block_job_create > a little

Re: [Qemu-devel] [RFC v4 02/21] blockjobs: model single jobs as transactions

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > model all independent jobs as single job transactions. > > It's one less case we have to worry about when we add more states to the > transition machine. This way, we can just treat all job lifetimes exactly > the same. This helps tighten

Re: [Qemu-devel] [RFC v4 06/21] iotests: add pause_wait

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Split out the pause command into the actual pause and the wait. > Not every usage presently needs to resubmit a pause request. > > The intent with the next commit will be to explicitly disallow > redundant or meaningless pause/resume requests,

Re: [Qemu-devel] [PATCH v6 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-02-27 Thread Alistair Francis
On Tue, Feb 27, 2018 at 8:36 AM, Peter Maydell wrote: > On 23 February 2018 at 17:21, Alistair Francis > wrote: >> Allow the guest to determine the time set from the QEMU command line. >> >> This includes adding a trace event to debug the

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Farhan Ali
On 02/27/2018 05:16 AM, Viktor Mihajlovski wrote: On 27.02.2018 11:05, Thomas Huth wrote: If QEMU fails to load 's390-netboot.img', the guest firmware currently loops forever and just floods the console with "Network boot device detected" messages. The code in ipl.c apparently already tried

Re: [Qemu-devel] [PATCH] simpletrace: fix timestamp argument type

2018-02-27 Thread Stefan Hajnoczi
On Thu, Feb 22, 2018 at 04:39:01PM +, Stefan Hajnoczi wrote: > The timestamp argument to a trace event method is documented as follows: > > The method can also take a timestamp argument before the trace event > arguments: > > def runstate_set(self, timestamp, new_state): >

Re: [Qemu-devel] [PATCH v4 0/2] Add git-publish config file

2018-02-27 Thread Stefan Hajnoczi
On Mon, Feb 26, 2018 at 11:03:24AM +0800, Fam Zheng wrote: > v4: Fix prefixes. [Stefan] > Keep rich profiles. [Paolo] > > v3: Fix trivial hunk placement. [Michael] > Fix PPC sub-list. [Michael] > > v2: Add README paragraph [Marc-André, Stefan] > Fix 'trivial' profile [Marc-André] >

Re: [Qemu-devel] [PATCH v2 RFC] scripts/checkpatch.pl: add check for `while` and `for`

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 17:32, Stefan Hajnoczi wrote: > On Mon, Feb 26, 2018 at 10:53:18AM +0800, Su Hang wrote: >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 1b4b812e28fa..10c138344fa9 100755 >> --- a/scripts/checkpatch.pl >> +++

Re: [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update

2018-02-27 Thread Peter Maydell
On 26 February 2018 at 10:42, Thomas Huth wrote: > > Hi Cornelia! > > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread David Hildenbrand
>> Hm, do you need this twice? > > In my opinion this has only value if we assume that HW and/or KVM is buggy and > we are running host model (or it's expansion). > The "sanity" checks in KVM sensing code don't really hurt. But I agree, sane KVM should not produce this. > And even the we would

Re: [Qemu-devel] [PATCH 1/9] acpi: remove unused acpi-dsdt.aml

2018-02-27 Thread Igor Mammedov
On Tue, 27 Feb 2018 13:42:38 +0100 Auger Eric wrote: > Hi, > > On 22/02/18 13:42, Igor Mammedov wrote: > > SeaBIOS blob which is currently shipped with QEMU > > doesn't need acpi-dsdt.aml nor is able to use it > > and code that loaded it QEMU was removed by > as code

[Qemu-devel] [PATCH v2 2/5] s390x/ap: base Adjunct Processor (AP) object

2018-02-27 Thread Tony Krowiak
This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h | 38

Re: [Qemu-devel] [PATCH v9 16/29] sev/i386: add command to encrypt guest memory region

2018-02-27 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > > > On 2/16/18 9:47 AM, Dr. David Alan Gilbert wrote: > > * Brijesh Singh (brijesh.si...@amd.com) wrote: > >> The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory > >> region using the VM Encryption Key created using

Re: [Qemu-devel] [PATCH 5/9] pc: acpi: isolate FADT specific data into AcpiFadtData structure

2018-02-27 Thread Igor Mammedov
On Tue, 27 Feb 2018 14:47:16 +0100 Auger Eric wrote: > Hi Igor, > > On 22/02/18 13:42, Igor Mammedov wrote: > > move FADT data initialization out of fadt_setup() into dedicated > > init_fadt_data() that will set common for pc/q35 values in > > AcpiFadtData structure and

Re: [Qemu-devel] [PATCH v2 07/29] qapi: Turn generators into modules

2018-02-27 Thread Eric Blake
On 02/11/2018 03:35 AM, Markus Armbruster wrote: The next commit will introduce a common driver program for all generators. The generators need to be modules for that. qapi2texi.py already is. Make the other generators follow suit. The changes are actually trivial. Obvious in the diffs once

[Qemu-devel] [RFC PATCH 1/2] migrate: Allow incoming migration without defer

2018-02-27 Thread Richard Palethorpe
Allow a QEMU instance which has been started and used without the "-incoming" flag to accept an incoming migration with the "migrate-incoming" QMP command. This allows the user to dump the VM state to an external file then revert to that state at a later time without restarting QEMU. ---

Re: [Qemu-devel] [PATCH V5 2/4] tests/migration: Convert the boot block compilation script into Makefile

2018-02-27 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 02/27/2018 05:38 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> > >> > >> On 02/26/2018 12:01 PM, Dr. David Alan Gilbert wrote: > >>> * Wei Huang (w...@redhat.com) wrote: > The x86 boot block header currently is

Re: [Qemu-devel] [PATCH V6 3/4] tests/migration: Add migration-test header file

2018-02-27 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 02/27/2018 05:57 AM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> This patch moves the settings related migration-test from the > >> migration-test.c file to a seperate header file. It also renames the > >>

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Cornelia Huck
On Tue, 27 Feb 2018 10:44:19 -0500 Tony Krowiak wrote: > A new CPU model feature and two new CPU model facilities are > introduced to support AP devices for a KVM guest. > > CPU model features: > > 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that >

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > The state transition table has mostly been implied. We're about to make > it a bit more complex, so let's make the STM explicit instead. > > Perform state transitions with a function that for now just asserts the > transition is appropriate. >

[Qemu-devel] [PATCH v4 1/5] qcow2: Prefer byte-based calls into bs->file

2018-02-27 Thread Eric Blake
We had only three sector-based stragglers left; convert them to use our preferred byte-based accesses. Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia --- v2: indentation fix --- block/qcow2-cluster.c | 5 ++--- block/qcow2-refcount.c | 6 +++--- 2

Re: [Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update my email address

2018-02-27 Thread Philippe Mathieu-Daudé
On 02/27/2018 01:47 PM, Alistair Francis wrote: > I am leaving Xilinx, so to avoid having an email address that bouunces bounces > update my maintainer address to point to my personal email address. > > Signed-off-by: Alistair Francis > Signed-off-by: Alistair

Re: [Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-02-27 Thread Cornelia Huck
On Tue, 27 Feb 2018 10:44:18 -0500 Tony Krowiak wrote: > Introduces a VFIO based AP device. The device is defined via > the QEMU command line by specifying: > > -device vfio-ap,sysfsdev= > > The mediated matrix device is created by the VFIO AP device > driver

Re: [Qemu-devel] [PATCH 4/5] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:49, Linus Walleij wrote: > This adds support for emulating the Silicon Image SII9022 DVI/HDMI > bridge. It's not very clever right now, it just acknowledges > the switch into DDC I2C mode and back. Combining this with the > existing DDC I2C

Re: [Qemu-devel] [RFC v4 04/21] blockjobs: add status enum

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > We're about to add several new states, and booleans are becoming > unwieldly and difficult to reason about. It would help to have a > more explicit bookkeeping of the state of blockjobs. To this end, > add a new "status" field and add our

[Qemu-devel] [PATCH 1/2] spapr: register dummy ICPs later

2018-02-27 Thread Greg Kurz
Some older machine types create more ICPs than needed. We hence need to register up to xics_max_server_number() dummy ICPs to accomodate the migration of these machine types. Recent VSMT rework changed xics_max_server_number() to return DIV_ROUND_UP(max_cpus * spapr->vsmt, smp_threads)

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 63/67] target/arm: Implement SVE floating-point trig multiply-add coefficient

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 4 +++ > target/arm/sve_helper.c| 70 > ++ >

[Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-02-27 Thread Tony Krowiak
This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed on the linux host. This

  1   2   3   4   5   >