Re: [Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-02 Thread Paolo Bonzini
On 01/03/2018 11:33, Liu, Yi L wrote: > +pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD); > + > pci_setup_sva_ops(pdev, _pci_sva_ops); > > return; > @@ -3134,6 +3136,7 @@ static void vfio_exitfn(PCIDevice *pdev) > { > VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);

Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

2018-03-02 Thread Laurent Vivier
On 28/02/2018 19:02, Wei Huang wrote: > This patch moves the auto detection functions for cross compilation from > roms/Makefile to rules.mak. So the functions can be shared among Makefiles > in QEMU. > > Signed-off-by: Wei Huang > Reviewed-by: Andrew Jones

Re: [Qemu-devel] [PATCH 1/2] net: add e1000e model to the "simple" -net/-nic options

2018-03-02 Thread Thomas Huth
On 02.03.2018 16:51, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/pci/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index e006b6ac71..af3c85a46f 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -1822,6

Re: [Qemu-devel] [PATCH 2/2] q35: change default NIC to e1000e

2018-03-02 Thread Thomas Huth
On 02.03.2018 16:51, Paolo Bonzini wrote: > The e1000 NIC is getting old and is not a very good default for a > PCIe machine type. Change it to e1000e, which should be supported > by a good number of guests. Basically a good idea, but you can only do that for new machine types (pc-q35-2.12 and

Re: [Qemu-devel] [PATCH v1 2/2] hw/arm: Set the core count for Xilinx's ZynqMP

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 17:06, Alistair Francis wrote: > Set the ARM CPU core count property for the A53's attached to the Xilnx > ZynqMP machine. > > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-zynqmp.c | 2 ++ > 1 file changed, 2

Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP

2018-03-02 Thread Benjamin Warren via Qemu-devel
On Fri, Mar 2, 2018 at 2:57 AM, Daniel P. Berrangé wrote: > On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote: > > From: Or Idgar > > > > This patch allow changing the Virtual Machine Generation > > ID through QMP/HMP while the vm guest is running.

Re: [Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions

2018-03-02 Thread Michael S. Tsirkin
On Thu, Mar 01, 2018 at 10:46:34PM -0500, Jason Baron wrote: > Make use of duplex definitions from net/eth.h. > > Signed-off-by: Jason Baron > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Jiri Pirko > Cc:

Re: [Qemu-devel] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote: > The new feature enables the virtio-balloon device to receive hints of > guest free pages from the free page vq. Callers call the > free_page_start API to start the reporting, which creates a thread to > poll for free page hints. The

Re: [Qemu-devel] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote: > diff --git a/include/sysemu/balloon.h b/include/sysemu/balloon.h > index af49e19..16a2aae 100644 > --- a/include/sysemu/balloon.h > +++ b/include/sysemu/balloon.h ... > +typedef void (QEMUBalloonFreePageStart)(void *opaque); > +typedef

[Qemu-devel] [RFC PATCH 0/2] change q35 default NIC to e1000e

2018-03-02 Thread Paolo Bonzini
The Intel 82574 NIC has better performance and more features than the aging e1000 (aka 82540), for example MSI-X. This patch chooses it by default for the Q35 machine type. Drivers for 82574 were added first to Linux 2.6.27 (2008) and Windows 2008 R2. This does mean that Windows 2008 will not

[Qemu-devel] [PATCH 1/2] net: add e1000e model to the "simple" -net/-nic options

2018-03-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index e006b6ac71..af3c85a46f 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1822,6 +1822,7 @@ static const char * const pci_nic_models[] = {

Re: [Qemu-devel] [PULL v3 00/30] QAPI patches for 2018-03-01

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 15:31, Eric Blake wrote: > The following changes since commit 2e7b766594e17f786a6b2e5be690bc5b43ce6036: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-03-01' into > staging (2018-03-02 12:39:13 +) > > are available in the Git

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Alistair Francis
On Fri, Mar 2, 2018 at 9:31 AM, Peter Maydell wrote: > On 2 March 2018 at 17:06, Alistair Francis > wrote: > > Subject should say "core count" rather than "cluster size" ? Yes, that was left over. I'll fix. > >> The cortex A53 TRM

[Qemu-devel] [PATCH 0/1] FOLL_NOWAIT and get_user_pages_unlocked

2018-03-02 Thread Andrea Arcangeli
Hello, KVM is hanging on postcopy live migration. David tracked it down to commit ce53053ce378c21e7ffc45241fd67d6ee79daa2b and the problem is pretty obvious then. Either we teach get_user_pages_locked/unlocked to handle FOLL_NOWAIT (so faultin_nopage works right even when the nonblocking

[Qemu-devel] [PATCH 1/1] mm: gup: teach get_user_pages_unlocked to handle FOLL_NOWAIT

2018-03-02 Thread Andrea Arcangeli
KVM is hanging during postcopy live migration with userfaultfd because get_user_pages_unlocked is not capable to handle FOLL_NOWAIT. Earlier FOLL_NOWAIT was only ever passed to get_user_pages. Specifically faultin_page (the callee of get_user_pages_unlocked caller) doesn't know that if

Re: [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions

2018-03-02 Thread Michael S. Tsirkin
On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: > Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, > and DUPLEX_FULL. > > Signed-off-by: Jason Baron > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc:

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/24] ppc-for-2.12 queue 20180302

2018-03-02 Thread BALATON Zoltan
-01 17:08:16 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180302 for you to fetch changes up to 57ae75b2e401f1d04f37a8cd26212eb3134c51a6: hw/ppc/spapr,e500: Use new property "stdout-path" for boot console (2018-03-0

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-03-02 Thread Tony Krowiak
On 03/01/2018 09:12 AM, Pierre Morel wrote: On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is enabled in KVM, ECA.28 is _always_ set (not just if

Re: [Qemu-devel] [PATCH v2 resend] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-02 Thread John Snow
On 03/02/2018 10:39 AM, Eric Blake wrote: > On 02/26/2018 08:05 PM, Liang Li wrote: >> When doing drive mirror to a low speed shared storage, if there was heavy >> BLK IO write workload in VM after the 'ready' event, drive mirror >> block job >> can't be canceled immediately, it would keep

[Qemu-devel] [PATCH v2 0/2] Add a property to set the ARM CPU core count

2018-03-02 Thread Alistair Francis
Add an ARM CPU property which allows us to set the ARM CPU core count. V2: - Fix commit message and title. - Move the core_count default setting logic to the arm_cpu_realize() function. Alistair Francis (2): target/arm: Add a core count property hw/arm: Set the core count for Xilinx's

[Qemu-devel] [PATCH v2 1/2] target/arm: Add a core count property

2018-03-02 Thread Alistair Francis
The cortex A53 TRM specifies that bits 24 and 25 of the L2CTLR register specify the number of cores in the processor, not the total number of cores in the sytem. To report this correctly on machines with multiple CPU clusters (ARM's big.LITTLE or Xilinx's ZynqMP) we need to allow the machine to

Re: [Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source}

2018-03-02 Thread Paolo Bonzini
On 02/03/2018 16:44, Daniel P. Berrangé wrote: >> Just a small thing, this is a bit inconsistent with the rest of the >> GSource API, where the g_source_attach is usually left to the caller >> when a function returns GSource *. > The APIs which return a GSource in glib typically don't even set the

[Qemu-devel] [PATCH 2/2] q35: change default NIC to e1000e

2018-03-02 Thread Paolo Bonzini
The e1000 NIC is getting old and is not a very good default for a PCIe machine type. Change it to e1000e, which should be supported by a good number of guests. Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 5 +++-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix the A53 L2CTLR typo

2018-03-02 Thread Alistair Francis
On Fri, Mar 2, 2018 at 2:35 AM, Peter Maydell wrote: > On 2 March 2018 at 10:29, Peter Maydell wrote: >> On 2 March 2018 at 04:34, Alistair Francis wrote: >>> target/arm: Report the number of cores in the cluster >>>

Re: [Qemu-devel] [PULL v3 00/30] QAPI patches for 2018-03-01

2018-03-02 Thread Eric Blake
On 03/02/2018 10:55 AM, Peter Maydell wrote: On 2 March 2018 at 15:31, Eric Blake wrote: The following changes since commit 2e7b766594e17f786a6b2e5be690bc5b43ce6036: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-03-01' into staging (2018-03-02 12:39:13

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/2] Increase usability of external snapshots

2018-03-02 Thread Roman Kagan
On Tue, Feb 27, 2018 at 12:56:49PM +0100, Richard Palethorpe wrote: > Following on from the discussion about creating savevm/loadvm QMP > equivalents. I decided to take the advice given that we should use external > snapshots. However reverting to a snapshot currently requires QEMU to be >

[Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-02 Thread Anton Nefedov
commit 947858b0 "ide: abort TRIM operation for invalid range" is incorrect for macio; just ide_dma_error() without doing a callback is not enough for that errorpath. Instead, pass -EINVAL to the callback and handle it there (see related motivation for read/write in 58ac32113). It will however

[Qemu-devel] [PATCH v3] ppc4xx: Add device models found in PPC440 core SoCs

2018-03-02 Thread BALATON Zoltan
These devices are found in newer SoCs based on 440 core e.g. the 460EX (http://www.embeddeddeveloper.com/assets/processors/amcc/datasheets/ PP460EX_DS2063.pdf) Signed-off-by: BALATON Zoltan Signed-off-by: David Gibson --- v3: Fixed warning from

Re: [Qemu-devel] [PATCH 0/3] vfio/pci: ioeventfd support

2018-03-02 Thread Alex Williamson
On Fri, 2 Mar 2018 07:08:51 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, March 1, 2018 4:15 AM > > > > A vfio ioeventfd will perform the pre-specified device write on > > triggering of an eventfd. When coupled with KVM ioeventfds, this > >

Re: [Qemu-devel] [PATCH V7 2/4] tests/migration: Convert the boot block compilation script into Makefile

2018-03-02 Thread Wei Huang
On 03/02/2018 09:25 AM, Laurent Vivier wrote: > On 28/02/2018 19:02, Wei Huang wrote: >> The x86 boot block header currently is generated with a shell script. >> To better support other CPUs (e.g. aarch64), we convert the script >> into Makefile. This allows us to 1) support cross-compilation

[Qemu-devel] [PATCH v1 0/2] Add a property to set the ARM CPU core count

2018-03-02 Thread Alistair Francis
Add an ARM CPU property which allows us to set the ARM CPU core count. Alistair Francis (2): target/arm: Add a cluster size property hw/arm: Set the core count for Xilinx's ZynqMP target/arm/cpu.h | 5 + hw/arm/xlnx-zynqmp.c | 2 ++ target/arm/cpu.c | 1 +

[Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Alistair Francis
The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register specify the number of cores present and not the number of processors. To report this correctly on machines with multiple CPU clusters (ARM's big.LITTLE or Xilinx's ZynqMP) we need to allow the machine to overwrite this value.

[Qemu-devel] [PATCH v1 2/2] hw/arm: Set the core count for Xilinx's ZynqMP

2018-03-02 Thread Alistair Francis
Set the ARM CPU core count property for the A53's attached to the Xilnx ZynqMP machine. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index

Re: [Qemu-devel] [PATCH] net: fix misaligned member access

2018-03-02 Thread Peter Maydell
On 9 February 2018 at 19:03, Marc-André Lureau wrote: > Fixes the following ASAN warnings: > > /home/elmarco/src/qemu/hw/net/net_tx_pkt.c:201:27: runtime error: member > access within misaligned address 0x63128846 for type 'struct ip_header', > which requires 4

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 17:06, Alistair Francis wrote: Subject should say "core count" rather than "cluster size" ? > The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register "specifies" > specify the number of cores present and not the number of

Re: [Qemu-devel] [PATCH 1/2] net: add e1000e model to the "simple" -net/-nic options

2018-03-02 Thread Paolo Bonzini
On 02/03/2018 18:19, Thomas Huth wrote: > On 02.03.2018 16:51, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> hw/pci/pci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c >> index e006b6ac71..af3c85a46f 100644 >> ---

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 17:35, Alistair Francis wrote: > Ok will fix. I'll send a V2 out straight away, as today is my last day > and it'd be great if I could get this done. Sure -- if there are any further nits in v2 I'll just fix them up when I put it into

[Qemu-devel] [PATCH v2 2/2] hw/arm: Set the core count for Xilinx's ZynqMP

2018-03-02 Thread Alistair Francis
Set the ARM CPU core count property for the A53's attached to the Xilnx ZynqMP machine. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/xlnx-zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: notify guest directly

2018-03-02 Thread Sergio Lopez
On Fri, Mar 02, 2018 at 01:38:52PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 1:33 PM, sochin.jiang wrote: > > Till now, we've already notify guest as a batch mostly, an > > extra BH won't decrease guest interrupts much, but cause a > > significant

Re: [Qemu-devel] [PATCH v2 3/5] target/i386: Add support for CPUID_8000_001E for AMD

2018-03-02 Thread Moger, Babu
> -Original Message- > From: Radim Krčmář [mailto:rkrc...@redhat.com] > Sent: Thursday, March 1, 2018 1:57 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; > mtosa...@redhat.com; qemu-devel@nongnu.org; k...@vger.kernel.org; >

Re: [Qemu-devel] [PATCH v2 2/5] target/i386: Populate AMD Processor Cache Information

2018-03-02 Thread Moger, Babu
> -Original Message- > From: Radim Krčmář [mailto:rkrc...@redhat.com] > Sent: Thursday, March 1, 2018 1:56 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; > mtosa...@redhat.com; qemu-devel@nongnu.org; k...@vger.kernel.org; >

Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-02 Thread Jason Baron via Qemu-devel
On 03/02/2018 02:14 AM, Jason Wang wrote: > > > On 2018年03月02日 11:46, Jason Baron wrote: >> Although linkspeed and duplex can be set in a linux guest via 'ethtool >> -s', >> this requires custom ethtool commands for virtio-net by default. >> >> Introduce a new feature flag,

Re: [Qemu-devel] [PATCH 2/2] q35: change default NIC to e1000e

2018-03-02 Thread Paolo Bonzini
On 02/03/2018 18:24, Thomas Huth wrote: > On 02.03.2018 16:51, Paolo Bonzini wrote: >> The e1000 NIC is getting old and is not a very good default for a >> PCIe machine type. Change it to e1000e, which should be supported >> by a good number of guests. > > Basically a good idea, but you can only

[Qemu-devel] [Bug 1739371] Re: qemu-system-arm snapshot loadvm core dumped

2018-03-02 Thread Peter Maydell
*** This bug is a duplicate of bug 1739378 *** https://bugs.launchpad.net/bugs/1739378 I'm going to close this bug as a duplicate of #1739378 (as noted in my earlier comment). ** This bug has been marked a duplicate of bug 1739378 migration state save/load of sdcard device is broken --

Re: [Qemu-devel] [PULL 0/4] tricore-patches

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 11:57, Bastian Koppelmann wrote: > The following changes since commit 427cbc7e4136a061628cb4315cc8182ea36d772f: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2018-03-01 18:46:41 +) > > are available in

[Qemu-devel] [PULL 10/37] parallels: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function block_status() is still sector-based, because it is still in use by other sector-based functions; but

[Qemu-devel] [PULL 27/37] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-03-02 Thread Kevin Wolf
From: Stefan Hajnoczi BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop activity while a condition evaluates to true. This is used to implement synchronous operations where it acts as a condvar between the IOThread running the operation and the main

[Qemu-devel] [PULL 21/37] block: Drop unused .bdrv_co_get_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Now that all drivers have been updated to provide the byte-based .bdrv_co_block_status(), we can delete the sector-based interface. Signed-off-by: Eric Blake

[Qemu-devel] [PULL 33/37] qemu-img: Make resize error message more general

2018-03-02 Thread Kevin Wolf
From: Max Reitz The issue: $ qemu-img resize -f qcow2 foo.qcow2 qemu-img: Expecting one image file name Try 'qemu-img --help' for more information So we gave an image file name, but we omitted the length. qemu-img thinks the last argument is always the size and

[Qemu-devel] [PULL v4 28/30] qapi: Move qapi-schema.json to qapi/, rename generated files

2018-03-02 Thread Eric Blake
From: Markus Armbruster Move qapi-schema.json to qapi/, so it's next to its modules, and all files get generated to qapi/, not just the ones generated for modules. Consistently name the generated files qapi-MODULE.EXT: qmp-commands.[ch] become qapi-commands.[ch],

[Qemu-devel] [PULL 00/37] Block layer patches

2018-03-02 Thread Kevin Wolf
The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 14:37:10 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PULL 12/37] qcow2: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow2 driver accordingly. For now, we are ignoring the 'want_zero' hint. However, it should be relatively straightforward to honor the hint as a way to return larger

[Qemu-devel] [PULL 01/37] block: Add .bdrv_co_block_status() callback

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will

[Qemu-devel] [PULL 07/37] iscsi: Switch iscsi_allocmap_update() to byte-based

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the allocmap (no semantic change). Callers that already had bytes available are simpler, and callers that now scale to bytes will

[Qemu-devel] [PULL 08/37] iscsi: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL map and file parameter, even though the block layer passes

[Qemu-devel] [PULL 18/37] vmdk: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the vmdk driver accordingly. Drop the now-unused vmdk_find_index_in_cluster(). Also, fix a pre-existing bug: if find_extent() fails (unlikely, since the block layer did a

[Qemu-devel] [PULL 24/37] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-03-02 Thread Kevin Wolf
From: Alberto Garcia This patch fixes several mistakes in the documentation of the compressed cluster descriptor: 1) the documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is

[Qemu-devel] [PULL 31/37] block: rename .bdrv_create() to .bdrv_co_create_opts()

2018-03-02 Thread Kevin Wolf
From: Stefan Hajnoczi BlockDriver->bdrv_create() has been called from coroutine context since commit 5b7e1542cfa41a281af9629d31cef03704d976e6 ("block: make bdrv_create adopt coroutine"). Make this explicit by renaming to .bdrv_co_create_opts() and add the coroutine_fn

[Qemu-devel] [PULL 36/37] block/ssh: Add basic .bdrv_truncate()

2018-03-02 Thread Kevin Wolf
From: Max Reitz libssh2 does not seem to offer real truncation support, so we can only grow files -- but that is better than nothing. Signed-off-by: Max Reitz Message-id: 20180214204915.7980-4-mre...@redhat.com Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-03-02 Thread Tony Krowiak
On 03/01/2018 09:36 AM, David Hildenbrand wrote: On 01.03.2018 15:12, Pierre Morel wrote: On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is

[Qemu-devel] [PATCH v3 1/2] target/arm: Add a core count property

2018-03-02 Thread Alistair Francis
The cortex A53 TRM specifies that bits 24 and 25 of the L2CTLR register specify the number of cores in the processor, not the total number of cores in the sytem. To report this correctly on machines with multiple CPU clusters (ARM's big.LITTLE or Xilinx's ZynqMP) we need to allow the machine to

[Qemu-devel] [PULL v4 23/30] qapi: Generate separate .h, .c for each module

2018-03-02 Thread Eric Blake
From: Markus Armbruster Our qapi-schema.json is composed of modules connected by include directives, but the generated code is monolithic all the same: one qapi-types.h with all the types, one qapi-visit.h with all the visitors, and so forth. These monolithic headers get

[Qemu-devel] [PULL v4 00/30] QAPI patches for 2018-03-01

2018-03-02 Thread Eric Blake
The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738: Merge remote-tracking branch 'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02 16:56:20 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git

Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 11:59:00AM -0500, Jason Baron wrote: > On 03/02/2018 02:14 AM, Jason Wang wrote: > > > > > > On 2018年03月02日 11:46, Jason Baron wrote: > >> Although linkspeed and duplex can be set in a linux guest via 'ethtool > >> -s', > >> this requires custom ethtool commands for

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2018-03-02 Thread Éric Hoffman
Ok, yes you are right... I have looked a bit more on the source code, and indeed, I think understand the issue with the VFORK with QEMU. Please correct me if I'm wrong... - In the syscall trap handler, it has to use the fork() function to emulate the vfork() due to restriction of the vfork()

Re: [Qemu-devel] [PULL 12/51] build-sys: compile with -Og or -O1 when --enable-debug

2018-03-02 Thread Peter Maydell
On 16 January 2018 at 14:16, Paolo Bonzini wrote: > From: Marc-André Lureau > > When --enable-debug is turned on, configure doesn't set -O level, and > uses default compiler -O0 level, which is slow. > > Instead, use -Og if supported by the

[Qemu-devel] [PULL 15/37] sheepdog: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the sheepdog driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 14/37] raw: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the raw driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 09/37] null: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the null driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 19/37] vpc: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 23/37] iotest 033: add misaligned write-zeroes test via truncate

2018-03-02 Thread Kevin Wolf
From: Anton Nefedov This new test case only makes sense for qcow2 while iotest 033 is generic; however it matches the test purpose perfectly and also 033 contains those do_test() tricks to pass the alignment, which won't look nice being duplicated in other tests or

[Qemu-devel] [PULL 16/37] vdi: Avoid bitrot of debugging code

2018-03-02 Thread Kevin Wolf
From: Eric Blake Rework the debug define so that we always get -Wformat checking, even when debugging is disabled. Signed-off-by: Eric Blake Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[Qemu-devel] [PULL 25/37] docs: document how to use the l2-cache-entry-size parameter

2018-03-02 Thread Kevin Wolf
From: Alberto Garcia This patch updates docs/qcow2-cache.txt explaining how to use the new l2-cache-entry-size parameter. Here's a more detailed technical description of this feature: https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html And here are some

[Qemu-devel] [PULL 30/37] Revert "IDE: Do not flush empty CDROM drives"

2018-03-02 Thread Kevin Wolf
From: Stefan Hajnoczi This reverts commit 4da97120d51a4383aa96d741a2b837f8c4bbcd0b. blk_aio_flush() now handles the blk->root == NULL case, so we no longer need this workaround. Cc: John Snow Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 3/3] tcg: Add choose_vector_size

2018-03-02 Thread Richard Henderson
This unifies 5 copies of checks for supported vector size, and in the process fixes a missing check in tcg_gen_gvec_2s. This lead to an assertion failure for 64-bit vector multiply, which is not available in the AVX instruction set. Suggested-by: Peter Maydell

Re: [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled

2018-03-02 Thread Richard Henderson
On 03/02/2018 01:59 AM, KONRAD Frederic wrote: > From: KONRAD Frederic > > Since the commit af7a06bac7d3abb2da48ef3277d2a415772d2ae8: > `casa [..](10), .., ..` (and probably others alternate space instructions) > triggers a data access exception when the MMU is

Re: [Qemu-devel] [PATCH 1/1] mm: gup: teach get_user_pages_unlocked to handle FOLL_NOWAIT

2018-03-02 Thread Andrew Morton
On Fri, 2 Mar 2018 18:43:43 +0100 Andrea Arcangeli wrote: > KVM is hanging during postcopy live migration with userfaultfd because > get_user_pages_unlocked is not capable to handle FOLL_NOWAIT. > > Earlier FOLL_NOWAIT was only ever passed to get_user_pages. > >

Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-02 Thread Michael S. Tsirkin
On Fri, Mar 02, 2018 at 03:14:01PM +0800, Jason Wang wrote: > > > On 2018年03月02日 11:46, Jason Baron wrote: > > Although linkspeed and duplex can be set in a linux guest via 'ethtool -s', > > this requires custom ethtool commands for virtio-net by default. > > > > Introduce a new feature flag,

[Qemu-devel] [PULL 05/37] gluster: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the gluster driver accordingly. In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when not

[Qemu-devel] [PULL 02/37] nvme: Drop pointless .bdrv_co_get_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake Commit bdd6a90 has a bug: drivers should never directly set BDRV_BLOCK_ALLOCATED, but only io.c should do that (as needed). Instead, drivers should report BDRV_BLOCK_DATA if it knows that data comes from this BDS. But let's look at the bigger picture:

[Qemu-devel] [PULL 04/37] file-posix: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the file protocol driver accordingly. In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when

[Qemu-devel] [PULL 22/37] block: fix write with zero flag set and iovector provided

2018-03-02 Thread Kevin Wolf
From: Anton Nefedov The normal bdrv_co_pwritev() use is either - BDRV_REQ_ZERO_WRITE clear and iovector provided - BDRV_REQ_ZERO_WRITE set and iovector == NULL while - the flag clear and iovector == NULL is an assertion failure in bdrv_co_do_zero_pwritev()

[Qemu-devel] [PULL 20/37] vvfat: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the vvfat driver accordingly. Note that we can rely on the block driver having already clamped limits to our block size, and simplify accordingly. Signed-off-by: Eric

Re: [Qemu-devel] [PATCH v2 0/2] Add a property to set the ARM CPU core count

2018-03-02 Thread Alistair Francis
On Fri, Mar 2, 2018 at 10:51 AM, wrote: > Hi, > > This series failed build test on ppcle host. Please find the details below. > ... > CC aarch64-softmmu/target/arm/helper-a64.o > LINKsparc64-softmmu/qemu-system-sparc64 > CC

[Qemu-devel] [PULL 34/37] block/ssh: Pull ssh_grow_file() from ssh_create()

2018-03-02 Thread Kevin Wolf
From: Max Reitz If we ever want to offer even rudimentary truncation functionality for ssh, we should put the respective code into a reusable function. Signed-off-by: Max Reitz Message-id: 20180214204915.7980-2-mre...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PULL 1/3] tcg: Improve tcg_gen_muli_i32/i64

2018-03-02 Thread Richard Henderson
Convert multiplication by power of two to left shift. Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 24 ++-- 1 file changed, 18

[Qemu-devel] [PULL 37/37] qcow2: Replace align_offset() with ROUND_UP()

2018-03-02 Thread Kevin Wolf
From: Alberto Garcia The align_offset() function is equivalent to the ROUND_UP() macro so there's no need to use the former. The ROUND_UP() name is also a bit more explicit. This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() because align_offset() already

[Qemu-devel] [PULL 35/37] block/ssh: Make ssh_grow_file() blocking

2018-03-02 Thread Kevin Wolf
From: Max Reitz At runtime (that is, during a future ssh_truncate()), the SSH session is non-blocking. However, ssh_truncate() (or rather, bdrv_truncate() in general) is not a coroutine, so this resize operation needs to block. For ssh_create(), that is fine, too; the

[Qemu-devel] [PATCH v3 2/2] hw/arm: Set the core count for Xilinx's ZynqMP

2018-03-02 Thread Alistair Francis
Set the ARM CPU core count property for the A53's attached to the Xilnx ZynqMP machine. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- hw/arm/xlnx-zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-02 Thread Jack Schwartz
Hi Kevin. On 2018-01-15 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero bss_end_addr. The Multiboot Specification, section 3.1.3 allows for kernels without a bss section, by allowing a zeroed

Re: [Qemu-devel] [PATCH v2 0/2] ipmi: Fix vmstate transfer

2018-03-02 Thread Corey Minyard
On 03/02/2018 02:02 PM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: I apologize for the resend, I left the list off the previous post. This is unchanged since the previous post, two weeks ago. I received no comments, so I guess it's ok. It's fairly broken now, so

[Qemu-devel] [PULL 06/37] iscsi: Switch cluster_sectors to byte-based

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the cluster size in sectors, along with adding assertions that we are not dividing by zero. Improve some comment grammar while in

[Qemu-devel] [PULL 03/37] block: Switch passthrough drivers to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir

[Qemu-devel] [PULL 17/37] vdi: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the vdi driver accordingly. Note that the TODO is already covered (the block layer guarantees bounds of its requests), and that we can remove the now-unused

[Qemu-devel] [PULL 0/3] tcg queued patches

2018-03-02 Thread Richard Henderson
Only three outstanding patches for now. r~ Richard Henderson (3): tcg: Improve tcg_gen_muli_i32/i64 tcg/i386: Support INDEX_op_dup2_vec for -m32 tcg: Add choose_vector_size tcg/i386/tcg-target.inc.c | 9 + tcg/tcg-op-gvec.c | 438 +++---

[Qemu-devel] [PULL 28/37] block: add BlockBackend->in_flight counter

2018-03-02 Thread Kevin Wolf
From: Stefan Hajnoczi BlockBackend currently relies on BlockDriverState->in_flight to track requests for blk_drain(). There is a corner case where BlockDriverState->in_flight cannot be used though: blk->root can be NULL when there is no medium. This results in a segfault

[Qemu-devel] [PATCH v3 0/2] Add a property to set the ARM CPU core count

2018-03-02 Thread Alistair Francis
Add an ARM CPU property which allows us to set the ARM CPU core count. V3: - Fix Linux user mode compile failure V2: - Fix commit message and title. - Move the core_count default setting logic to the arm_cpu_realize() function. Alistair Francis (2): target/arm: Add a core count

Re: [Qemu-devel] [PATCH v2 0/2] ipmi: Fix vmstate transfer

2018-03-02 Thread Dr. David Alan Gilbert
* miny...@acm.org (miny...@acm.org) wrote: > I apologize for the resend, I left the list off the previous post. > > This is unchanged since the previous post, two weeks ago. I received > no comments, so I guess it's ok. It's fairly broken now, so I would > like this fixed. Sorry, I'll look at

Re: [Qemu-devel] [PULL 12/51] build-sys: compile with -Og or -O1 when --enable-debug

2018-03-02 Thread Alex Bennée
Peter Maydell writes: > On 16 January 2018 at 14:16, Paolo Bonzini wrote: >> From: Marc-André Lureau >> >> When --enable-debug is turned on, configure doesn't set -O level, and >> uses default compiler -O0 level,

[Qemu-devel] [PULL 11/37] qcow: Switch to .bdrv_co_block_status()

2018-03-02 Thread Kevin Wolf
From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow driver accordingly. There is no intent to optimize based on the want_zero flag for this format. Signed-off-by: Eric Blake Reviewed-by:

  1   2   3   4   >