[Qemu-devel] [Bug 1753437] Re: qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

2018-03-12 Thread Thomas Huth
Looks like the mailing list <-> launchpad bridge again ignored mails to the corresponding mailing list thread. It's not a real bug, see here for details: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01142.html I'll try to remember to clean this up the next time we update the s390-ccw

[Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-12 Thread Thomas Huth
"-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it less prominent that users are not lured into using it so often anymore. So instead of starting the network chapter with "-net nic"

[Qemu-devel] [PULL 00/14] Ui 20180312 patches

2018-03-12 Thread Gerd Hoffmann
The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-09 17:28:16 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180312-pull-request

[Qemu-devel] [PULL 03/14] sdl: workaround bug in sdl 2.0.8 headers

2018-03-12 Thread Gerd Hoffmann
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892087 Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180307154258.9313-1-kra...@redhat.com --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure

[Qemu-devel] [PULL 02/14] make: switch language file build to be gtk module aware

2018-03-12 Thread Gerd Hoffmann
From: Bruce Rogers Now that gtk support builds as a module, CONFIG_GTK changed from y to m. Adjust Makefile correspondingly. Signed-off-by: Bruce Rogers Message-id: 20180307155517.32570-1-brog...@suse.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL 08/14] ui/gtk-egl: add scanout_dmabuf support

2018-03-12 Thread Gerd Hoffmann
Add support for dmabuf scanouts to gtk-egl. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-6-kra...@redhat.com --- include/ui/gtk.h | 4 ui/gtk-egl.c | 23 +++ ui/gtk.c | 2 ++ 3 files changed, 29 insertions(+) diff --git

[Qemu-devel] [PULL 09/14] ui/gtk-egl: add cursor_dmabuf support

2018-03-12 Thread Gerd Hoffmann
Add support for cursor dmabufs to gtk-egl. Just blend in the cursor (if we have one) when rendering the dmabuf. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-7-kra...@redhat.com --- include/ui/gtk.h | 8 ui/gtk-egl.c | 40

Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-12 Thread Peter Xu
On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote: > In both sides. We still don't transmit anything through them. s/In/On/? > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 52 ++-- > 1 file changed,

Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part

2018-03-12 Thread Vladimir Sementsov-Ogievskiy
16.02.2018 23:40, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Tests 140, 147 and 205 are fixed due to now server failed on searching

[Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Paolo Bonzini
Allow distributions to disable the Intel and/or AMD IOMMU devices. Signed-off-by: Paolo Bonzini --- v1->v2: don't include x86-iommu.o unconditionally default-configs/i386-softmmu.mak | 2 ++ default-configs/x86_64-softmmu.mak | 2 ++ hw/i386/Makefile.objs

Re: [Qemu-devel] [PATCH v4 08/29] libvhost-user: Open userfaultfd

2018-03-12 Thread Peter Xu
On Thu, Mar 08, 2018 at 07:57:50PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Open a userfaultfd (on a postcopy_advise) and send it back in > the reply to the qemu for it to monitor. > > Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v4 12/29] postcopy+vhost-user: Split set_mem_table for postcopy

2018-03-12 Thread Peter Xu
On Thu, Mar 08, 2018 at 07:57:54PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split the set_mem_table routines in both qemu and libvhost-user > because the postcopy versions are going to be quite different > once changes in the later

Re: [Qemu-devel] [PULL v2 0/8] M68k for 2.12 patches

2018-03-12 Thread Peter Maydell
On 9 March 2018 at 14:57, Laurent Vivier wrote: > The following changes since commit e1ee9ee139ed7091c2c592d5b784fbb7227bfc0d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180306' > into staging (2018-03-06 10:21:35 +) > > are available in the

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Gerd Hoffmann
Hi, > I don't know the hw/display code very well, but I think it's not that > easy... Putting Gerd on CC:, maybe he can describe the details of that > BiteSizeTask a little bit better. [ Side note: Is there a wiki page for this? ] Might be it actually is that easy. Historically qemu created

[Qemu-devel] [PULL 07/14] ui/gtk: use GtkGlArea on wayland only

2018-03-12 Thread Gerd Hoffmann
For dma-buf support we need a egl context. The gtk x11 backend uses glx contexts though. We can't use the GtkGlArea widget on x11 because of that, so use our own gtk-egl code instead. wayland continues to use the GtkGlArea widget. Signed-off-by: Gerd Hoffmann Message-id:

[Qemu-devel] [PULL 12/14] spice: add scanout_dmabuf support

2018-03-12 Thread Gerd Hoffmann
Add support for scanout dmabufs. Just pass them through to spice-server. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20180308090618.30147-3-kra...@redhat.com --- ui/spice-display.c | 15 +++ 1 file

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 10:48, Thomas Huth wrote: >> +obj-$(CONFIG_VTD) += x86-iommu.o intel_iommu.o >> +obj-$(CONFIG_AMD_IOMMU) += x86-iommu.o amd_iommu.o > The linker likely does not care if x86-iommu.o is included twice The linker actually cares, but rules.mak drops the duplicate: commit

Re: [Qemu-devel] [PATCH v6 2/2] qapi: add block latency histogram interface

2018-03-12 Thread Vladimir Sementsov-Ogievskiy
11.03.2018 06:20, Eric Blake wrote: On 03/09/2018 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 05/14] ui/gtk: group gtk.mo declarations in Makefile

2018-03-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-3-kra...@redhat.com --- ui/Makefile.objs | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index d1203bb80a..b560ee12c3 100644 ---

[Qemu-devel] [PULL 04/14] ui/gtk: make GtkGlArea usage a runtime option

2018-03-12 Thread Gerd Hoffmann
Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime instead of compile time which opengl variant we want use. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-2-kra...@redhat.com --- include/ui/gtk.h | 2 ++ ui/gtk.c | 53

[Qemu-devel] [PULL 01/14] build: try improve handling of clang warnings

2018-03-12 Thread Gerd Hoffmann
This patch disables the pragma diagnostic -Wunused-but-set-variable for clang in util/coroutine-ucontext.c. This in turn allows us to remove it from the configure check, so the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. With that in place clang builds (linux) will use -Werror by

[Qemu-devel] [PULL 14/14] qapi: Add device ID and head parameters to screendump

2018-03-12 Thread Gerd Hoffmann
From: Thomas Huth QEMU's screendump command can only take dumps from the primary display. When using multiple VGA cards, there is no way to get a dump from a secondary card or other display heads yet. So let's add a 'device' and a 'head' parameter to the HMP and QMP commands to

Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part

2018-03-12 Thread Vladimir Sementsov-Ogievskiy
16.02.2018 23:40, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Tests 140, 147 and 205 are fixed due to now server failed on searching

Re: [Qemu-devel] [PATCH 4/5] block/blkreplay: Remove protocol-related fields

2018-03-12 Thread Pavel Dovgalyuk
> From: Fabiano Rosas [mailto:faro...@linux.vnet.ibm.com] > The blkreplay driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. blkreplay:) will now fail gracefully: >

Re: [Qemu-devel] SSD virtio-scsi passthrough

2018-03-12 Thread Nitin Gupta
Hi Stefan Thanks for your response , i tried the the command provided by you and it did not work as well somehow i find that after changing the controller to LSI in qemu command it started working , please find command below -device lsi,id=scsi0,bus=pci.0,addr=0xa-drive

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 06:58, Thomas Huth wrote: > I don't know the hw/display code very well, but I think it's not that > easy... Putting Gerd on CC:, maybe he can describe the details of that > BiteSizeTask a little bit better. > > (When sending patches, please also always use the get_maintainers.pl >

[Qemu-devel] [PULL 06/14] ui/opengl: Makefile cleanup

2018-03-12 Thread Gerd Hoffmann
With gtk.mo bits moved away we don't need the ifeq any more. Also add missing opengl libs for some objects. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-4-kra...@redhat.com --- ui/Makefile.objs | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [Qemu-devel] [PATCH v10 20/24] migration: Delay start of migration main routines

2018-03-12 Thread Peter Xu
On Wed, Mar 07, 2018 at 12:00:06PM +0100, Juan Quintela wrote: > We need to make sure that we have started all the multifd threads. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 4 ++-- > migration/migration.h | 1 + > migration/ram.c | 3 +++ >

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 08:27, Thomas Huth wrote: > "-net" is clearly a legacy option. Yet we still use it in almost all > examples in the qemu documentation, and many other spots in the network > chapter. We should make it less prominent that users are not lured into > using it so often anymore. So instead

Re: [Qemu-devel] [PATCH v4 1/2] i386: Add Intel Processor Trace feature support

2018-03-12 Thread Kang, Luwei
> > + > > +if (!eax_0 || > > + ((ebx_0 & INTEL_PT_MINIMAL_EBX) != INTEL_PT_MINIMAL_EBX) || > > + ((ecx_0 & INTEL_PT_MINIMAL_ECX) != INTEL_PT_MINIMAL_ECX) || > > + ((eax_1 & INTEL_PT_MTC_BITMAP) != INTEL_PT_MTC_BITMAP) || > > + ((eax_1 &

[Qemu-devel] [PULL 13/14] spice: add cursor_dmabuf support

2018-03-12 Thread Gerd Hoffmann
Add support for cursor dmabufs. qemu has to render the cursor for that, so in case a cursor is present qemu allocates a new dmabuf, blits the scanout, blends in the pointer and passes on the new dmabuf to spice-server. Without cursor qemu continues to simply pass on the scanout dmabuf as-is.

Re: [Qemu-devel] [PATCH 8/9] iotests: add file_path helper

2018-03-12 Thread Vladimir Sementsov-Ogievskiy
20.02.2018 08:42, Jeff Cody wrote: On Fri, Feb 16, 2018 at 02:46:35PM -0600, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Simple way to have auto generated filenames with auto clenup. Like s/clenup/cleanup/ FilePath but without using 'with' statement and

Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

2018-03-12 Thread Thomas Huth
On 12.03.2018 08:05, Gerd Hoffmann wrote: > Hi, > >> I don't know the hw/display code very well, but I think it's not that >> easy... Putting Gerd on CC:, maybe he can describe the details of that >> BiteSizeTask a little bit better. > > [ Side note: Is there a wiki page for this? ] There is

Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part

2018-03-12 Thread Vladimir Sementsov-Ogievskiy
16.02.2018 23:40, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Tests 140, 147 and 205 are fixed due to now server failed on searching

Re: [Qemu-devel] [PATCH v4 10/29] vhost+postcopy: Register shared ufd with postcopy

2018-03-12 Thread Peter Xu
On Thu, Mar 08, 2018 at 07:57:52PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Register the UFD that comes in as the response to the 'advise' method > with the postcopy code. > > Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Thomas Huth
On 12.03.2018 10:53, Paolo Bonzini wrote: > On 12/03/2018 10:48, Thomas Huth wrote: >>> +obj-$(CONFIG_VTD) += x86-iommu.o intel_iommu.o >>> +obj-$(CONFIG_AMD_IOMMU) += x86-iommu.o amd_iommu.o >> The linker likely does not care if x86-iommu.o is included twice > > The linker actually cares, but

[Qemu-devel] [PATCH] 9p: add trace event for v9fs_setattr()

2018-03-12 Thread Greg Kurz
Don't print the tv_nsec part of atime and mtime, to stay below the 10 argument limit of trace events. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |5 + hw/9pfs/trace-events |2 ++ 2 files changed, 7 insertions(+) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Sun, 11 Mar 2018 20:12:39 + Nia Alarie wrote: > Signed-off-by: Nia Alarie > --- Applied, thanks. > hw/9pfs/9p.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index

Re: [Qemu-devel] [PATCH] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Paolo Bonzini
On 12/03/2018 06:41, Thomas Huth wrote: > On 28.02.2018 10:32, Paolo Bonzini wrote: >> Allow distributions to disable the Intel and/or AMD IOMMU devices. >> >> Signed-off-by: Paolo Bonzini >> --- >> default-configs/i386-softmmu.mak | 2 ++ >>

[Qemu-devel] BiteSIzeTasks

2018-03-12 Thread Thomas Huth
Hi all, it's great that we have https://wiki.qemu.org/BiteSizedTasks - but apparently some tasks are apparently described a little bit too scarcely. Many newcomers seem to have problems understanding the tasks that are mentioned here. To improve the experience of people willing to contribute to

[Qemu-devel] [PULL 11/14] spice: drop dprint() debug logging

2018-03-12 Thread Gerd Hoffmann
Some calls are deleted, some are converted into tracepoints. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20180308090618.30147-2-kra...@redhat.com --- ui/spice-display.c | 75

[Qemu-devel] [PULL 10/14] vnc: deal with surface NULL pointers

2018-03-12 Thread Gerd Hoffmann
Secondary displays in multihead setups are allowed to have a NULL DisplaySurface. Typically user interfaces handle this by hiding the window which shows the display in question. This isn't an option for vnc though because it simply hasn't a concept of windows or outputs. So handle the situation

Re: [Qemu-devel] [PATCH v2] hw/i386: make IOMMUs configurable via default-configs/

2018-03-12 Thread Thomas Huth
On 12.03.2018 10:43, Paolo Bonzini wrote: > Allow distributions to disable the Intel and/or AMD IOMMU devices. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: don't include x86-iommu.o unconditionally > > default-configs/i386-softmmu.mak | 2 ++ >

[Qemu-devel] [PATCH v8 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-03-12 Thread Anton Nefedov
If COW areas of the newly allocated clusters are zeroes on the backing image, efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole cluster instead of writing explicit zero buffers later in perform_cow(). iotest 060: write to the discarded cluster does not trigger COW

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-03-12 Thread Paolo Bonzini
On 12/02/2018 15:50, Paolo Bonzini wrote: > On 12/02/2018 15:48, Kevin Wolf wrote: >> Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben: >>> Okay, we are in agreement about this and you expressed very well why I >>> (at the gut feeling level) didn't like the old op blockers. But you >>>

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:08PM +0100, Kevin Wolf wrote: > The crypto driver used to create the image file in a callback from the > crypto subsystem. If we want to implement .bdrv_co_create, this needs to > go away because that callback will get a reference to an already > existing block node.

Re: [Qemu-devel] [PULL 00/56] Block layer patches

2018-03-12 Thread Peter Maydell
On 9 March 2018 at 16:18, Kevin Wolf wrote: > The following changes since commit d9bbfea646e86426d549bd612cd9f91e49aa50c2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-upstream-v8.2' > into staging (2018-03-09 10:58:57 +) > > are available in the git

Re: [Qemu-devel] [PATCH v9 11/14] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2018-03-12 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > In case the MSI is translated by an IOMMU we need to fixup the > MSI route with the translated address. > > Signed-off-by: Eric Auger > > --- > > v5 -> v6: > - use IOMMUMemoryRegionClass API > > It is

Re: [Qemu-devel] [PATCH 5/8] sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/09/2018 06:03 PM, Peter Maydell wrote: > On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: >> [based on a patch from Alistair Francis >> from qemu/xilinx tag xilinx-v2015.2] >> Signed-off-by: Philippe Mathieu-Daudé > >

Re: [Qemu-devel] [PATCH v9 13/14] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

2018-03-12 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > From: Prem Mallappa > > This patch builds the smmuv3 node in the ACPI IORT table. > > The RID space of the root complex, which spans 0x0-0x1 > maps to streamid space 0x0-0x1 in smmuv3,

[Qemu-devel] [PATCH v5 5/9] sockets: move fd_is_socket() into common sockets code

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The fd_is_socket() helper method is useful in a few places, so put it in the common sockets code. Make the code more compact while moving it. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v5 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Even if common tn3270 implementations do not support TLS, it is trivial to have them proxied over a proxy like stunnel which adds TLS at the sockets layer. We should thus not silently skip tn3270 protocol initialization when TLS is enabled.

[Qemu-devel] [PATCH v5 6/9] sockets: check that the named file descriptor is a socket

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The SocketAddress struct has an "fd" type, which references the name of a file descriptor passed over the monitor using the "getfd" command. We currently blindly assume the FD is a socket, which can lead to hard to diagnose errors later. This adds

[Qemu-devel] [PATCH v5 4/9] sockets: strengthen test suite IP protocol availability checks

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Instead of just checking whether it is possible to bind() on a socket, also check that we can successfully connect() to the socket we bound to. This more closely replicates the level of functionality that tests will actually use. Reviewed-by:

[Qemu-devel] [PATCH v8 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2018-03-12 Thread Anton Nefedov
Support the flag if the underlying BDS supports it Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/blkdebug.c | 3 ++- block/blkverify.c | 2 +- block/mirror.c | 2 +- block/quorum.c | 3 ++- block/raw-format.c | 3

[Qemu-devel] [PATCH v8 9/9] iotest 134: test cluster-misaligned encrypted write

2018-03-12 Thread Anton Nefedov
COW (even empty/zero) areas require encryption too Signed-off-by: Anton Nefedov Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- tests/qemu-iotests/134 | 9 +

Re: [Qemu-devel] [PATCH] 9p: add trace event for v9fs_setattr()

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/12/2018 10:09 AM, Greg Kurz wrote: > Don't print the tv_nsec part of atime and mtime, to stay below the 10 > argument limit of trace events. If you really need it you can print it with trace_v9fs_setattr_return(). > > Signed-off-by: Greg Kurz Reviewed-by: Philippe

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 04:18:45PM +0100, Laszlo Ersek wrote: > On 03/09/18 15:27, Gerd Hoffmann wrote: > > Hi, > > > >> For OVMF (x86), I guess the initial set of properties should come from > >> the "-D FOO[=BAR]" build flags that OVMF currently supports. (The list > >> might grow or change

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-12 Thread Daniel P . Berrangé
On Mon, Mar 12, 2018 at 12:43:47PM +0100, Kevin Wolf wrote: > Am 12.03.2018 um 12:35 hat Daniel P. Berrangé geschrieben: > > On Fri, Mar 09, 2018 at 06:27:08PM +0100, Kevin Wolf wrote: > > > The crypto driver used to create the image file in a callback from the > > > crypto subsystem. If we want

Re: [Qemu-devel] [PATCH 6/6] qemu-iotests: Test luks QMP image creation

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:13PM +0100, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/208 | 211 > +++ > tests/qemu-iotests/208.out | 136 > tests/qemu-iotests/common.rc |

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-03-12 Thread Kevin Wolf
Am 12.03.2018 um 12:10 hat Paolo Bonzini geschrieben: > On 12/02/2018 15:50, Paolo Bonzini wrote: > > On 12/02/2018 15:48, Kevin Wolf wrote: > >> Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben: > >>> Okay, we are in agreement about this and you expressed very well why I > >>> (at the gut

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-12 Thread Thomas Huth
On 12.03.2018 10:07, Paolo Bonzini wrote: > On 12/03/2018 08:27, Thomas Huth wrote: >> "-net" is clearly a legacy option. Yet we still use it in almost all >> examples in the qemu documentation, and many other spots in the network >> chapter. We should make it less prominent that users are not

[Qemu-devel] [PATCH] tests: make docker-test-debug@fedora run sanitizers

2018-03-12 Thread Marc-André Lureau
Since --enable-debug no longer enable sanitizers, we need explicit --enable-sanitizers. llvm package is required for llvm-symbolizer, to get symbols in backtraces. Add make V=1 to get details about failing tests. Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH v6 0/2] block latency histogram

2018-03-12 Thread Stefan Hajnoczi
On Fri, Mar 09, 2018 at 07:52:10PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v6: > > Use correct header qapi/qapi-builtin-types.h, to fix build again. > Sorry for spam =( > > > v5: > > Revert to v3 and just add qapi-types.h header. > > > v4: > > Move block_latency_histogram_set from

Re: [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

2018-03-12 Thread Daniel P . Berrangé
On Tue, Feb 06, 2018 at 08:48:43AM -0600, Eric Blake wrote: > On 02/06/2018 03:13 AM, Daniel P. Berrangé wrote: > > > > > +++ b/qapi/sockets.json > > > > @@ -123,6 +123,13 @@ > > > ># > > > ># @unix: Unix domain socket > > > ># > > > > +# @vsock: VMCI address > > > > +# > > > > +#

[Qemu-devel] [PATCH v5 8/9] char: refactor parsing of socket address information

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" To prepare for handling more address types, refactor the parsing of socket address information to make it more robust and extensible. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v5 9/9] char: allow passing pre-opened socket file descriptor at startup

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" When starting QEMU management apps will usually setup a monitor socket, and then open it immediately after startup. If not using QEMU's own -daemonize arg, this process can be troublesome to handle correctly. The mgmt app will need to repeatedly

[Qemu-devel] [PATCH v5 3/9] sockets: pull code for testing IP availability out of specific test

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The test-io-channel-socket.c file has some useful helper functions for checking if a specific IP protocol is available. Other tests need to perform similar kinds of checks to avoid running tests that will fail due to missing IP protocols.

Re: [Qemu-devel] [PATCH v9 00/14] ARM SMMUv3 Emulation Support

2018-03-12 Thread Peter Maydell
On 28 February 2018 at 08:44, Auger Eric wrote: > On 27/02/18 20:02, Peter Maydell wrote: >> On 17 February 2018 at 18:46, Eric Auger wrote: >>> This series implements the emulation code for ARM SMMUv3. >> What state is this series in now? Is it

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Mon, 12 Mar 2018 07:12:52 -0500 Eric Blake wrote: > On 03/11/2018 03:12 PM, Nia Alarie wrote: > > Signed-off-by: Nia Alarie > > --- > > hw/9pfs/9p.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > > } else

Re: [Qemu-devel] [PATCH v7 20/22] replay: don't drain/flush bdrv queue while RR is working

2018-03-12 Thread Paolo Bonzini
On 27/02/2018 10:53, Pavel Dovgalyuk wrote: > In record/replay mode bdrv queue is controlled by replay mechanism. > It does not allow saving or loading the snapshots > when bdrv queue is not empty. Stopping the VM is not blocked by nonempty > queue, but flushing the queue is still impossible

[Qemu-devel] [PATCH v8 1/9] mirror: inherit supported write/zero flags

2018-03-12 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- block/mirror.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index f5bf620..2fb786f 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1100,6 +1100,15 @@ static BlockDriver

[Qemu-devel] [PATCH v8 5/9] block: treat BDRV_REQ_ALLOCATE as serialising

2018-03-12 Thread Anton Nefedov
The idea is that ALLOCATE requests may overlap with other requests. Reuse the existing block layer infrastructure for serialising requests. Use the following approach: - mark ALLOCATE serialising, so subsequent requests to the area wait - ALLOCATE request itself must never wait if another

Re: [Qemu-devel] [ PATCH v7 00/22] replay additions

2018-03-12 Thread Pavel Dovgalyuk
Ping. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Tuesday, February 27, 2018 12:52 PM > To: qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; war2jor...@live.com; > boost.li...@gmail.com; >

[Qemu-devel] [PATCH v4 3/4] target/arm: Add the XML dynamic generation

2018-03-12 Thread Abdallah Bouassida
Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida --- gdbstub.c

[Qemu-devel] [PATCH v4 1/4] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

2018-03-12 Thread Abdallah Bouassida
This is a preparation for the coming feature of creating dynamically an XML description for the ARM sysregs. A register has ARM_CP_NO_GDB enabled will not be shown in the dynamic XML. This bit is enabled automatically when creating CP_ANY wildcard aliases. This bit could be enabled manually for

[Qemu-devel] [PATCH v4 0/4] Add a dynamic XML-description of the cp-registers to GDB

2018-03-12 Thread Abdallah Bouassida
The previous version: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=30973 Abdallah Bouassida (4): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm: Add the XML dynamic

[Qemu-devel] [PULL 7/8] audio/pulseaudio: build as module

2018-03-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180306074053.22856-7-kra...@redhat.com --- configure | 2 +- audio/Makefile.objs | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b9336b1808..27bc39bd4d 100755 ---

Re: [Qemu-devel] [PATCH 06/19] uninorth: alter pci_pmac_init() and pci_pmac_u3_init() to return uninorth device

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/06/2018 09:30 PM, Mark Cave-Ayland wrote: > This is in preparation for moving the device wiring into the New World > machine. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/pci-host/uninorth.c | 16

[Qemu-devel] [PULL 0/1] Vga 20180312 patches

2018-03-12 Thread Gerd Hoffmann
The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-09 17:28:16 +) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20180312-pull-request

[Qemu-devel] [PULL 1/1] vga: fix region calculation

2018-03-12 Thread Gerd Hoffmann
Typically the scanline length and the line offset are identical. But in case they are not our calculation for region_end is incorrect. Using line_offset is fine for all scanlines, except the last one where we have to use the actual scanline length. Fixes: CVE-2018-7550 Reported-by: Ross

[Qemu-devel] [PULL 0/1] Usb 20180312 patches

2018-03-12 Thread Gerd Hoffmann
The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-09 17:28:16 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180312-pull-request

[Qemu-devel] [PULL 1/1] usbredir: reorder fields in USBRedirDevice to reduce padding

2018-03-12 Thread Gerd Hoffmann
From: "zhenwei.pi" Changing the current ordering saves 8 bytes per entry in x86_64. Signed-off-by: zhenwei.pi Message-id: 1520318781-22644-1-git-send-email-zhenwei...@youruncloud.com Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH 4/6] luks: Turn invalid assertion into check

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:11PM +0100, Kevin Wolf wrote: > The .bdrv_getlength implementation of the crypto block driver asserted > that the payload offset isn't after EOF. This is an invalid assertion to > make as the image file could be corrupted. Instead, check it and return > -EIO if the

Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic()

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:09PM +0100, Kevin Wolf wrote: > Everything that refers to the protocol layer or QemuOpts is moved out of > block_crypto_create_generic(), so that the remaining function is > suitable to be called by a .bdrv_co_create implementation. > > LUKS is the only driver that

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: let blk_add/remove_aio_context_notifier() tolerate BDS changes

2018-03-12 Thread Eric Blake
On 03/12/2018 06:27 AM, Stefan Hajnoczi wrote: On Fri, Mar 09, 2018 at 09:56:44AM -0600, Eric Blake wrote: On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: Commit 2019ba0a0197 ("block: Add AioContextNotifier functions to BB") added blk_add/remove_aio_context_notifier() and implemented them by

[Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

2018-03-12 Thread Daniel P . Berrangé
An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04706.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04892.html v4:

Re: [Qemu-devel] [PATCH v7 13/22] replay: push replay_mutex_lock up the call tree

2018-03-12 Thread Paolo Bonzini
On 27/02/2018 10:52, Pavel Dovgalyuk wrote: > > +void replay_init_locks(void) > +{ > +replay_mutex_init(); > +} > + This should not be needed as a public function: until replay_mode is set, replay_lock and replay_unlock do nothing. I'm squashing this: diff --git a/include/sysemu/replay.h

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-12 Thread Eric Blake
On 03/12/2018 06:47 AM, Kevin Wolf wrote: +## +{ 'struct': 'BlockdevCreateOptionsLUKS', + 'data': { 'file': 'BlockdevRef', +'qcrypto': 'QCryptoBlockCreateOptionsLUKS', +'size': 'size' } } s/qcrypto/crypto/ in this field. I do wonder

[Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-03-12 Thread Igor Mammedov
v3->v4: * replace 'runstates' list in QMP command with a single boolean 'ption allowed-in-preconfig' like it's done with 'allow-oob'. Which allows to simplify intrusive QAPI changes quite a lot. (Eric Blake ) * Make sure HMP is disbled for real, v3 was just

[Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

2018-03-12 Thread Igor Mammedov
it will allow to reuse parse_NumaOptions() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov --- include/sysemu/numa.h | 1 + numa.c| 48 +--- 2 files changed, 30

[Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig"

2018-03-12 Thread Igor Mammedov
New option will be used to allow commands, which are prepared/need to run run in preconfig state. Other commands that should be able to run in preconfig state, should be ammeded to not expect machine in initialized state or deal with it. For compatibility reasons, commands, that don't use new

Re: [Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

2018-03-12 Thread Eric Blake
On 03/12/2018 07:49 AM, Daniel P. Berrangé wrote: An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04706.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04892.html v4:

[Qemu-devel] [PULL 1/8] modules: use gmodule-export

2018-03-12 Thread Gerd Hoffmann
As we want qemu symbols be exported to modules we should use the gmodule-export-2.0 pkg-config instead of gmodule-2.0. Cc: Marc-André Lureau Signed-off-by: Gerd Hoffmann Message-id: 20180308085301.8875-2-kra...@redhat.com --- configure | 2 +- 1

[Qemu-devel] [PULL 8/8] audio/sdl: build as module

2018-03-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180306074053.22856-8-kra...@redhat.com --- configure | 2 +- audio/Makefile.objs | 9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 27bc39bd4d..9f9ffb2cf9 100755 ---

Re: [Qemu-devel] BiteSizedTasks: API conversion

2018-03-12 Thread Su Hang
> -Original Messages- > From: "Peter Maydell" > Sent Time: 2018-03-12 19:40:22 (Monday) > To: "Su Hang" > Cc: "thomas huth" , "QEMU Developers" > > Subject: Re: [Qemu-devel] BiteSizedTasks:

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Eric Blake
On 03/11/2018 03:12 PM, Nia Alarie wrote: Signed-off-by: Nia Alarie --- hw/9pfs/9p.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) } else if (perm & P9_STAT_MODE_LINK) { -int32_t ofid = atoi(extension.data); -V9fsFidState

Re: [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

2018-03-12 Thread Max Reitz
On 2018-03-10 23:34, Eric Blake wrote: > On 02/24/2018 09:40 AM, Max Reitz wrote: >> Currently, we try to rewrite every occurrence of "backing": null into >> "backing": "" in qmp_blockdev_add().  However, that breaks using the >> same "backing": null construction in json:{} file names (which do

Re: [Qemu-devel] [PATCH 5/8] sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/09/2018 06:03 PM, Peter Maydell wrote: > On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: >> [based on a patch from Alistair Francis >> from qemu/xilinx tag xilinx-v2015.2] >> Signed-off-by: Philippe Mathieu-Daudé > >

Re: [Qemu-devel] [PATCH v9 12/14] hw/arm/virt: Add SMMUv3 to the virt board

2018-03-12 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > From: Prem Mallappa > > Add code to instantiate an smmuv3 in virt machine. A new iommu > integer member is introduced in VirtMachineState to store the type > of the iommu in use. > >

  1   2   3   4   5   6   >