Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 09:33, Thomas Huth wrote: > On 09.04.2018 18:50, Laszlo Ersek wrote: >> On 04/09/18 10:19, Gerd Hoffmann wrote: > +{ 'enum' : 'SystemFirmwareType', > + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } The naming here is quite a bad mixture between firmware interface

[Qemu-devel] [PULL 2/4] gtk: drop pointless code from gd_window_close

2018-04-10 Thread Gerd Hoffmann
Unregistering the display change listener looks like a pointless excercise given we'll exit in a moment. When exiting qemu via menu/file/quit this will not happen either. Just drop the code. Also return TRUE unconditionally. This will tell gtk to ignore the close request, so gtk will not start

[Qemu-devel] [PULL 2/2] linux-user: add microblaze/microblazeel magic numbers in qemu-binfmt-conf.sh

2018-04-10 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Message-Id: <20180409115212.875-2-laur...@vivier.eu> --- scripts/qemu-binfmt-conf.sh | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index

Re: [Qemu-devel] [PATCH for-2.12] fpu: Fix rounding mode for floatN_to_uintM_round_to_zero

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 06:59, Richard Henderson wrote: > We incorrectly passed in the current rounding mode > instead of float_round_to_zero. > > Signed-off-by: Richard Henderson > --- > > Found while runnning SVE RISU tests; it should be

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 12:09, Paolo Bonzini wrote: > On 10/04/2018 11:23, Daniel P. Berrangé wrote: >>> And, really, this seems to reinforce my point that the schema should >>> live in the libvirtd tree, not in the QEMU tree. In that case, perhaps >>> it would be a better fit to work with an XSD, and

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 06:50:12PM +0200, Laszlo Ersek wrote: > On 04/09/18 10:19, Gerd Hoffmann wrote: > >>> +{ 'enum' : 'SystemFirmwareType', > >>> + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } > >> > >> The naming here is quite a bad mixture between firmware interface > >> ('bios', 'uefi')

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Kevin Wolf
Am 10.04.2018 um 10:45 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 10.04.2018 um 09:36 hat Jiri Denemark geschrieben: > > > On Mon, Apr 09, 2018 at 15:40:03 +0200, Kevin Wolf wrote: > > > > Am 09.04.2018 um 12:27 hat Dr. David Alan Gilbert geschrieben: >

Re: [Qemu-devel] [PULL for-2.12 0/8] s390x fixes for -rc3

2018-04-10 Thread Peter Maydell
On 9 April 2018 at 16:15, Cornelia Huck wrote: > The following changes since commit 2a6bcfdebe4115993a032395d459f5e0cf27a01e: > > Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into > staging (2018-04-09 10:21:14 +0100) > > are available in the Git

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 11:16:01AM +0200, Laszlo Ersek wrote: > On 04/10/18 08:27, Gerd Hoffmann wrote: > > Hi, > > > >> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, > >> present and future, for SMM-requiring OVMF builds), but then you get > >> into version sorting

[Qemu-devel] [PULL 3/4] configure: don't warn GTK if disabled

2018-04-10 Thread Gerd Hoffmann
From: Peter Xu We don't need to detect GTK ABI if GTK is disabled in general. Otherwise we could get this warning (when host is installed with GTK ABI version 2) even when configure with "--disable-gtk": WARNING: Use of GTK 2.0 is deprecated and will be removed in

[Qemu-devel] [PULL 4/4] configure: don't warn SDL abi if disabled

2018-04-10 Thread Gerd Hoffmann
From: Peter Xu SDL has the same problem as GTK that we might get warnings on SDL ABI version even if SDL is disabled. Fix that by only probing SDL if SDL is enabled. Also this should let configure be a little bit faster since we don't really need to probe SDL stuff when it's

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 11:16:01AM +0200, Laszlo Ersek wrote: > On 04/10/18 08:27, Gerd Hoffmann wrote: > > Hi, > > > >> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, > >> present and future, for SMM-requiring OVMF builds), but then you get > >> into version sorting

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-10 Thread Balamuruhan S
On Wed, Apr 04, 2018 at 11:04:59AM +0200, Juan Quintela wrote: > Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > using ram_bytes_remaining would yeild it correct. > > > > Signed-off-by: Balamuruhan S

Re: [Qemu-devel] [PATCH v2 for-2.12] icount: fix cpu_restore_state_from_tb for non-tb-exit cases

2018-04-10 Thread Paolo Bonzini
On 10/04/2018 12:13, Richard Henderson wrote: > In most cases new parameter is true (icount should be recalculated). > But there are two cases in i386 and openrisc when the CPU state is only > queried without the need to break the TB. This patch fixes both of > these cases. > > Signed-off-by:

[Qemu-devel] [PULL 1/2] linux-user: fix microblaze get_sp_from_cpustate()

2018-04-10 Thread Laurent Vivier
get_sigframe() uses regs[1] and this is actual SP. Signed-off-by: Laurent Vivier Message-Id: <20180409115212.875-1-laur...@vivier.eu> --- linux-user/microblaze/target_signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 0/2] linux-user fixes for -rc3

2018-04-10 Thread Laurent Vivier
The following changes since commit 1e7e92e2ef874aa3a235d59b2be1da7a29b6fd29: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180409' into staging (2018-04-09 18:21:23 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 01:27:18PM +0200, Laszlo Ersek wrote: > Please go through the rest of the emails in this thread, and advise: > - if the firmware descriptor schema may perhaps live in the libvirt tree, > - accordingly, if the schema could be expressed as an XSD (and firmware > packages

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 12:34, Daniel P. Berrangé wrote: > On Tue, Apr 10, 2018 at 01:27:18PM +0200, Laszlo Ersek wrote: > >> Please go through the rest of the emails in this thread, and advise: >> - if the firmware descriptor schema may perhaps live in the libvirt tree, >> -

Re: [Qemu-devel] [PULL 0/1] linux-user: fix file offset for preadv/pwritev

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 03:17, Max Filippov wrote: > Hi Peter, > > please pull the following linux-user fix for QEMU-2.12. > > The following changes since commit 9abfc88af3ffd3b33c7fab4471da86462ee71d95: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180402-xtensa' into

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Change default cpu and gic-version setting to "max"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 09:41:33AM +0200, Andrea Bolognani wrote: > On Mon, 2018-04-09 at 11:29 -0500, Wei Huang wrote: > > > > Running mach-virt machine types (i.e. "-M virt") on different systems > > > > can > > > > result in various misleading warnings if -cpu and/or gic-version not > > > >

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-10 Thread Dr. David Alan Gilbert
* David Gibson (dgib...@redhat.com) wrote: > On Mon, 9 Apr 2018 19:57:47 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > On 2018-04-04 13:36, Peter Xu wrote: > > > > On Wed, Apr 04, 2018 at 11:55:14AM +0530,

Re: [Qemu-devel] [PATCH for-2.12] fpu: Fix rounding mode for floatN_to_uintM_round_to_zero

2018-04-10 Thread Richard Henderson
On 04/10/2018 05:40 PM, Peter Maydell wrote: > Would this be likely the fix for > https://bugs.launchpad.net/qemu/+bug/1761401 > ? Yes indeed. r~

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 13:34, Daniel P. Berrangé wrote: > On Tue, Apr 10, 2018 at 01:27:18PM +0200, Laszlo Ersek wrote: > >> Please go through the rest of the emails in this thread, and advise: >> - if the firmware descriptor schema may perhaps live in the libvirt tree, >> - accordingly, if the schema could

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:34, Daniel P. Berrangé wrote: > On Tue, Apr 10, 2018 at 11:16:01AM +0200, Laszlo Ersek wrote: >> On 04/10/18 08:27, Gerd Hoffmann wrote: >>> Hi, >>> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, present and future, for SMM-requiring OVMF

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:26, Thomas Huth wrote: > On 10.04.2018 11:16, Laszlo Ersek wrote: >> On 04/10/18 08:27, Gerd Hoffmann wrote: >>> Hi, >>> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, present and future, for SMM-requiring OVMF builds), but then you get into

[Qemu-devel] [PULL 04/12] hw/sd/bcm2835_sdhost: Add tracepoints

2018-04-10 Thread Peter Maydell
Add some tracepoints to the bcm2835_sdhost driver, to assist debugging. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Gerd Hoffmann Message-id: 20180319161556.16446-2-peter.mayd...@linaro.org ---

[Qemu-devel] [PULL 11/12] tcg: Introduce tcg_set_insn_start_param

2018-04-10 Thread Peter Maydell
From: Richard Henderson The parameters for tcg_gen_insn_start are target_ulong, which may be split into two TCGArg parameters for storage in the opcode on 32-bit hosts. Fixes the ARM target and its direct use of tcg_set_insn_param, which would set the wrong

[Qemu-devel] [PULL 10/12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-10 Thread Peter Maydell
The AArch64 signal frame design was extended for SVE in commit 8c5931de0ac77388096d79ceb, so that instead of having a fixed setup we now add various records to the frame, with some of them possibly overflowing into an extra space outside the original 4K reserved block in the target_sigcontext.

[Qemu-devel] [PULL 09/12] cpus.c: ensure running CPU recalculates icount deadlines on timer expiry

2018-04-10 Thread Peter Maydell
When we run in TCG icount mode, we calculate the number of instructions to execute using tcg_get_icount_limit(), which ensures that we stop execution at the next timer deadline. However there is a bug where currently we do not recalculate that limit if the guest reprograms a timer so that the next

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 10.04.2018 um 09:36 hat Jiri Denemark geschrieben: > > On Mon, Apr 09, 2018 at 15:40:03 +0200, Kevin Wolf wrote: > > > Am 09.04.2018 um 12:27 hat Dr. David Alan Gilbert geschrieben: > > > > It's a fairly hairy failure case they had; if I remember

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 08:27, Gerd Hoffmann wrote: > Hi, > >> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, >> present and future, for SMM-requiring OVMF builds), but then you get >> into version sorting and similar mess. I considered fnmatch() -- >> basically simple ? and *

Re: [Qemu-devel] [PATCH v3 for-2.13] vfio-ccw: introduce vfio_ccw_get_device()

2018-04-10 Thread Cornelia Huck
On Mon, 09 Apr 2018 12:15:10 +0200 Greg Kurz wrote: > A recent patch fixed leaks of the dynamically allocated vcdev->vdev.name > field in vfio_ccw_realize(), but we now have three freeing sites for it. > This is unfortunate and seems to indicate something is wrong with its > life

Re: [Qemu-devel] [Qemu-arm] Crash when running hello-world unikernel for ARM

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 09:16, Ajay Garg wrote: > On Tue, Apr 10, 2018 at 1:08 PM, Peter Maydell > wrote: >> What hardware (what CPU, board, etc) is this "rumprun" software >> expecting to run on? > > Yep, just to ensure that there are no

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Paolo Bonzini
On 10/04/2018 11:23, Daniel P. Berrangé wrote: >> And, really, this seems to reinforce my point that the schema should >> live in the libvirtd tree, not in the QEMU tree. In that case, perhaps >> it would be a better fit to work with an XSD, and firmware packages >> should install XML files?

Re: [Qemu-devel] [PULL 0/2] linux-user fixes for -rc3

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410105606.16413-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 0/2] linux-user fixes for -rc3 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Peter Xu
On Tue, Apr 10, 2018 at 04:49:50PM +0800, Fam Zheng wrote: [...] > We have had > > function_name() > { > ... > > and > > function_name() { > ... > > and > > function_name () { > ... > > finally you invent the last in the family: > > function_name () > {

[Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-10 Thread Elie Tournier
Hello everyone, I submitted the v1 of this series before kraxel's display system rework. Currently, virglrenderer [1] support OpenGL ES 2.0 on the guest side and OpenGL ES 3.0 on the host side. Thanks to this work, we are able to run QEMU on system that only support OpenGL ES. The support of

[Qemu-devel] [PATCH v2 1/2] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Elie Tournier
Signed-off-by: Elie Tournier --- qapi/ui.json | 21 - vl.c | 10 +- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 5d01ad4304..c8005867e5 100644 --- a/qapi/ui.json +++

[Qemu-devel] [PULL 07/12] hw/arm/fsl-imx: Fix introspection problem with fsl-imx6 and fsl-imx7

2018-04-10 Thread Peter Maydell
From: Thomas Huth QEMU currently exits unexpectedly when trying to introspect the fsl-imx6 and fsl-imx7 devices on systems with many SMP CPUs: $ echo "{'execute':'qmp_capabilities'}"\ "{'execute':'device-list-properties',"\ " 'arguments':{'typename':'fsl,imx6'}}"

[Qemu-devel] [PULL 08/12] target/arm: Report unsupported MPU region sizes more clearly

2018-04-10 Thread Peter Maydell
Currently our PMSAv7 and ARMv7M MPU implementation cannot handle MPU region sizes smaller than our TARGET_PAGE_SIZE. However we report that in a slightly confusing way: DRSR[3]: No support for MPU (sub)region alignment of 9 bits. Minimum is 10 The problem is not the alignment of the region, but

[Qemu-devel] [PULL 05/12] hw/sd/bcm2835_sdhost: Don't raise spurious interrupts

2018-04-10 Thread Peter Maydell
The Linux bcm2835_sdhost driver doesn't work on QEMU, because our model raises spurious data interrupts. Our function bcm2835_sdhost_fifo_run() will flag an interrupt any time it is called with s->datacnt == 0, even if the host hasn't actually issued a data read or write command yet. This means

[Qemu-devel] [PULL 12/12] fpu: Fix rounding mode for floatN_to_uintM_round_to_zero

2018-04-10 Thread Peter Maydell
From: Richard Henderson We incorrectly passed in the current rounding mode instead of float_round_to_zero. Signed-off-by: Richard Henderson Message-id: 20180410055912.934-1-richard.hender...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH] qemu-iotests: Remove _supported_fmt dmg

2018-04-10 Thread Kevin Wolf
qemu-iotests doesn't support dmg, and the dmg block driver doesn't support image creation. Two test cases declare dmg as supported, but that's obviously wrong for both reasons. Remove the declaration. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/183 | 2 +-

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Fam Zheng
On Tue, 04/10 13:40, Peter Xu wrote: > SDL has the same problem as GTK that we might get warnings on SDL ABI > version even if SDL is disabled. Fix that by only probing SDL if SDL is > enabled. Also this should let configure be a little bit faster since we > don't really need to probe SDL stuff

[Qemu-devel] [Bug 657329] Re: APIC unusable on QEMU

2018-04-10 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 06:34:41PM +0200, Laszlo Ersek wrote: > On 04/09/18 09:26, Thomas Huth wrote: > > Hi Laszlo, > > > > On 07.04.2018 02:01, Laszlo Ersek wrote: > >> Add a schema that describes the properties of virtual machine firmware. > >> > >> Each firmware executable installed on a

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Thomas Huth
On 10.04.2018 11:16, Laszlo Ersek wrote: > On 04/10/18 08:27, Gerd Hoffmann wrote: >> Hi, >> >>> - I considered adding wildcards (say, blacklist "all" i440fx machtypes, >>> present and future, for SMM-requiring OVMF builds), but then you get >>> into version sorting and similar mess. I

[Qemu-devel] [PULL 0/4] Ui 20180410 patches

2018-04-10 Thread Gerd Hoffmann
The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-04-09 17:29:10 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180410-pull-request for you

Re: [Qemu-devel] [PATCH] icount: fix cpu_restore_state_from_tb for non-tb-exit cases

2018-04-10 Thread Richard Henderson
On 04/10/2018 05:35 PM, Paolo Bonzini wrote: > This is incorrect, "cpu->can_do_io" is 1 when not in tcg_qemu_tb_exec. > In fact, in cpu_exec we have "cpu->can_do_io = 1;" immediately after > siglongjmp, so I propose adding the same "cpu->can_do_io = 1;" > assignment to cpu_exec_step_atomic. Ooo,

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Gerd Hoffmann
> > Hmm, I'm wondering whenever it is useful to model things this way. It's > > not like you can actually configure things for -bios seabios.rom or > > -kernel uboot.elf. Only pflash allows to actually configure things, and > > there are not that many useful combinations. The code needs > >

[Qemu-devel] [PATCH v2 for-2.12] icount: fix cpu_restore_state_from_tb for non-tb-exit cases

2018-04-10 Thread Richard Henderson
From: Pavel Dovgalyuk In icount mode, instructions that access io memory spaces in the middle of the translation block invoke TB recompilation. After recompilation, such instructions become last in the TB and are allowed to access io memory spaces. When the code

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-10 Thread Balamuruhan S
On 2018-04-10 15:22, Balamuruhan S wrote: On Wed, Apr 04, 2018 at 11:04:59AM +0200, Juan Quintela wrote: Balamuruhan S wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining would yeild it correct. > >

Re: [Qemu-devel] [PATCH for-2.12] tcg: Introduce tcg_set_insn_start_param

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 01:35, Richard Henderson wrote: > The parameters for tcg_gen_insn_start are target_ulong, which may be split > into two TCGArg parameters for storage in the opcode on 32-bit hosts. > > Fixes the ARM target and its direct use of tcg_set_insn_param,

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Gerd Hoffmann
Hi, > It occurs to me that we are actually over-thinking things, by making it > possible to list a choice of vars files per firmware. We could remove this > special case by just having separate tpo level firmware entries and a main > feature flag to say if it is enrolled or not - see below

[Qemu-devel] [PATCH v2 2/2] sdl: Allow OpenGL ES context creation

2018-04-10 Thread Elie Tournier
Signed-off-by: Elie Tournier --- include/ui/sdl2.h | 1 + qemu-options.hx | 2 +- ui/sdl2-gl.c | 17 +++-- ui/sdl2.c | 1 + vl.c | 4 5 files changed, 22 insertions(+), 3 deletions(-) diff --git a/include/ui/sdl2.h

Re: [Qemu-devel] [PATCH] configure: don't warn SDL abi if disabled

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 01:40:34PM +0800, Peter Xu wrote: > SDL has the same problem as GTK that we might get warnings on SDL ABI > version even if SDL is disabled. Fix that by only probing SDL if SDL is > enabled. Also this should let configure be a little bit faster since we > don't really

[Qemu-devel] [PATCH for-2.12] commit/stream: Reset delay_ns

2018-04-10 Thread Kevin Wolf
Streaming and the commit block job only want to apply throttling when they actually copied data instead of skipping it, so they made the calculation of delay_ns conditional. However, delay_ns isn't reset when skipping some sectors, so instead of not waiting, the old delay is applied again.

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 09:44, Thomas Huth wrote: > On 09.04.2018 18:34, Laszlo Ersek wrote: >> On 04/09/18 09:26, Thomas Huth wrote: >>> Hi Laszlo, >>> >>> On 07.04.2018 02:01, Laszlo Ersek wrote: Add a schema that describes the properties of virtual machine firmware. Each firmware executable

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 07:57:54PM +0200, Laszlo Ersek wrote: > On 04/09/18 10:49, Daniel P. Berrangé wrote: > > On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: > >> Add a schema that describes the properties of virtual machine firmware. > >> > >> Each firmware executable installed

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Thomas Huth
On 10.04.2018 11:05, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 06:34:41PM +0200, Laszlo Ersek wrote: >> On 04/09/18 09:26, Thomas Huth wrote: >>> Hi Laszlo, >>> >>> On 07.04.2018 02:01, Laszlo Ersek wrote: Add a schema that describes the properties of virtual machine firmware.

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Thomas Huth
On 10.04.2018 11:22, Laszlo Ersek wrote: > On 04/10/18 09:33, Thomas Huth wrote: [...] >> Alternatively, what about providing some kind of "alias" or "nickname" >> setting here, too? So the EDK2 builds would get >> SystemFirmwareType="edk2" and "SystemFirmwareAlias="uefi" for example. > > I hope

Re: [Qemu-devel] [PATCH] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-10 Thread Wanpeng Li
Hi Paolo, 2018-03-27 3:43 GMT+08:00 Eduardo Habkost : > On Sun, Mar 25, 2018 at 11:33:01AM +0800, Wanpeng Li wrote: >> 2018-03-24 4:18 GMT+08:00 Eduardo Habkost : >> > On Fri, Mar 16, 2018 at 07:36:42AM -0700, Wanpeng Li wrote: >> >> From: Wanpeng Li

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 11:51:31AM +0200, Gerd Hoffmann wrote: > > > Hmm, I'm wondering whenever it is useful to model things this way. It's > > > not like you can actually configure things for -bios seabios.rom or > > > -kernel uboot.elf. Only pflash allows to actually configure things, and > >

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: > Add a schema that describes the properties of virtual machine firmware. > > Each firmware executable installed on a host system should come with a > JSON file that conforms to this schema, and informs the management > applications

Re: [Qemu-devel] [PATCH v2 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-10 Thread Thomas Huth
On 06.04.2018 16:17, Paolo Bonzini wrote: > On 06/04/2018 15:37, Thomas Huth wrote: >> It's been marked as deprecated since QEMU v2.9.0, so that should have >> been enough time for everybody to switch to the modern -device + -netdev >> syntax for connecting guest NICs with host network backends,

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:32, Thomas Huth wrote: > On 10.04.2018 11:22, Laszlo Ersek wrote: >> On 04/10/18 09:33, Thomas Huth wrote: > [...] >>> Alternatively, what about providing some kind of "alias" or "nickname" >>> setting here, too? So the EDK2 builds would get >>> SystemFirmwareType="edk2" and

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 12:48:28PM +0100, Peter Maydell wrote: > On 10 April 2018 at 12:34, Daniel P. Berrangé wrote: > > On Tue, Apr 10, 2018 at 01:27:18PM +0200, Laszlo Ersek wrote: > > > >> Please go through the rest of the emails in this thread, and advise: > >> - if the

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 12:20, Daniel P. Berrangé wrote: > On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: >> +{ 'struct' : 'SystemFirmware', >> + 'data' : { 'executable' : 'FirmwareFile', >> + 'type' : 'SystemFirmwareType', >> +

[Qemu-devel] [Bug 1762707] [NEW] VFIO device gets DMA failures when virtio-balloon leak from highmem to lowmem

2018-04-10 Thread Pixel, Ding
Public bug reported: Is there any known conflict between VFIO passthrough device and virtio- balloon? The VM has: 1. 4GB system memory 2. one VFIO passthrough device which supports high address memory DMA and uses GFP_HIGHUSER pages. 3. Memory balloon device with 4GB target. When setting the

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 11:20:33AM +0100, Daniel P. Berrangé wrote: > On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: > > Add a schema that describes the properties of virtual machine firmware. > > > > Each firmware executable installed on a host system should come with a > > JSON

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:05, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 06:34:41PM +0200, Laszlo Ersek wrote: >> On 04/09/18 09:26, Thomas Huth wrote: >>> Hi Laszlo, >>> >>> On 07.04.2018 02:01, Laszlo Ersek wrote: Add a schema that describes the properties of virtual machine firmware.

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Daniel P . Berrangé
On Tue, Apr 10, 2018 at 01:44:13PM +0200, Laszlo Ersek wrote: > On 04/10/18 13:34, Daniel P. Berrangé wrote: > > On Tue, Apr 10, 2018 at 01:27:18PM +0200, Laszlo Ersek wrote: > > > >> Please go through the rest of the emails in this thread, and advise: > >> - if the firmware descriptor schema may

[Qemu-devel] [PULL 1/4] ui: fix keymap detection under Xwayland

2018-04-10 Thread Gerd Hoffmann
From: Daniel P. Berrangé The X11 code currently detects the keymap by looking for the keycode name property. Unfortunately due to the way Xwayland handles keyboards, this property gets unset almost immediately after the first application starts using Xwayland resulting in

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:18, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 07:57:54PM +0200, Laszlo Ersek wrote: >> On 04/09/18 10:49, Daniel P. Berrangé wrote: >>> On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: Add a schema that describes the properties of virtual machine

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 11:55, Daniel P. Berrangé wrote: > On Tue, Apr 10, 2018 at 11:51:31AM +0200, Gerd Hoffmann wrote: Hmm, I'm wondering whenever it is useful to model things this way. It's not like you can actually configure things for -bios seabios.rom or -kernel uboot.elf. Only pflash

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 07:59, Gerd Hoffmann wrote: > Hi, > >> I threw in "-kernel" because, although it also (usually?) means >> "memory", I expected people would want it separate. >> >> Regarding memory vs. pflash, I thought that these two, combined with the >> access permissions, could cover all of RAM,

Re: [Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-10 Thread Laszlo Ersek
On 04/10/18 08:18, Gerd Hoffmann wrote: > Hi, > >>> uboot for example implements uefi unterfaces too (dunno how complete, >>> but reportly recent versions can run uefi shell and grub just fine). >> >> Indeed: when I was struggling with this enum type and tried to look for >> more firmware types

Re: [Qemu-devel] [Qemu-arm] Crash when running hello-world unikernel for ARM

2018-04-10 Thread Ajay Garg
Thanks Peter .. my sincere gratitude. You pin-pointed the real issue .. On Tue, Apr 10, 2018 at 2:50 PM, Peter Maydell wrote: > On 10 April 2018 at 09:16, Ajay Garg wrote: >> On Tue, Apr 10, 2018 at 1:08 PM, Peter Maydell

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 10.04.2018 um 10:45 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 10.04.2018 um 09:36 hat Jiri Denemark geschrieben: > > > > On Mon, Apr 09, 2018 at 15:40:03 +0200, Kevin Wolf wrote: > > > > > Am 09.04.2018

[Qemu-devel] [PULL 1/7] target/ppc: Initialize lazy_tlb_flush correctly

2018-04-10 Thread David Gibson
ppc_tr_init_disas_context() correctly sets lazy_tlb_flush to true on certain CPU models. However, it leaves it uninitialized, instead of setting it to false on all others. It wasn't caught before now because we didn't have examples in the tests that exercised this path. However it can now be

[Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Peter Xu
cur_mon was only used in main loop so we don't really need that to be per-thread variable. Now it's possible that we have more than one thread to operate on it. Let's start to let it be per-thread variable. In case we'll create threads within a valid cur_mon setup, we'd better let the child

Re: [Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410120222.31845-1-tournier.e...@gmail.com Subject: [Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH] timer: fix record/replay timerlist probe

2018-04-10 Thread Pavel Dovgalyuk
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. Probing of the timerlists' clock instead of using them for the deadlines calculation is critical for the replay.

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Bastian Koppelmann
On 04/10/2018 03:03 PM, Emilio G. Cota wrote: > On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: >> On 04/10/2018 02:11 AM, Emilio G. Cota wrote: >>> On Mon, Apr 09, 2018 at 16:01:36 +0200, Bastian Koppelmann wrote: Thanks for doing this grunt work. Me and a colleague were

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Gerd Hoffmann
> # @off: Disable OpenGL (default). > > > + # 'on'Use OpenGL, pick context type automatically. > > + # Would better be named 'auto' but is called 'on' for backward > > + # compatibility with bool type. > > See below... > DisplayOptions was added in 2.12. This is a

Re: [Qemu-devel] [PATCH for-2.12] make-release: add skiboot .version file

2018-04-10 Thread Michael Roth
Quoting Peter Maydell (2018-04-10 02:31:04) > On 10 April 2018 at 01:57, Michael Roth wrote: > > This is needed to build skiboot from tarball-distributed sources > > since the git data the make_release.sh script relies on to generate > > it is not available. > > > > Cc:

[Qemu-devel] [Bug 1762707] Re: VFIO device gets DMA failures when virtio-balloon leak from highmem to lowmem

2018-04-10 Thread Alex Williamson
Ballooning is currently incompatible with device assignment. When the balloon is inflated (memory removed from the VM), the pages are zapped from the process without actually removing them from the vfio DMA mapping. The pages are still pinned from the previous mapping, making the balloon

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Kevin Wolf
Am 10.04.2018 um 16:22 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 10.04.2018 um 12:40 hat Dr. David Alan Gilbert geschrieben: > > > Hmm; having chatted to Jiri I'm OK with reverting it, on the condition > > > that I actually understand how this

[Qemu-devel] [PULL 03/12] target-arm: Check undefined opcodes for SWP in A32 decoder

2018-04-10 Thread Peter Maydell
From: Onur Sahin Make sure we are not treating architecturally Undefined instructions as a SWP, by verifying the opcodes as per section A8.8.229 of ARMv7-A specification. Bits [21:20] must be zero for this to be a SWP or SWPB. We also choose to UNDEF for the

[Qemu-devel] [PULL 2/7] hw/misc/macio: Fix crash when listing device properties of macio device

2018-04-10 Thread David Gibson
From: Thomas Huth The macio-newworld device can currently be used to abort QEMU unexpectedly: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}}

[Qemu-devel] [PULL 0/7] ppc-for-2.12 queue 20180410

2018-04-10 Thread David Gibson
The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-04-09 17:29:10 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180410

Re: [Qemu-devel] [PATCH for-2.12] fpu: Fix rounding mode for floatN_to_uintM_round_to_zero

2018-04-10 Thread Alex Bennée
Richard Henderson writes: > We incorrectly passed in the current rounding mode > instead of float_round_to_zero. > > Signed-off-by: Richard Henderson Oops, Reviewed-by: Alex Bennée > --- > > Found while

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 04:39, Jason Wang wrote: > The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-04-09 17:29:10 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-04-10 Thread Peter Maydell
On 15 March 2018 at 15:25, Laurent Vivier wrote: > Le 15/03/2018 à 16:13, James Cowgill a écrit : >> Add support for the two currently defined HWCAP bits on MIPS - R6 and >> MSA. >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 >> Signed-off-by: James Cowgill

Re: [Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 09:05:06 -0500, Eric Blake wrote: > On 04/10/2018 07:59 AM, Emilio G. Cota wrote: > > On Tue, Apr 10, 2018 at 11:24:37 +1000, Richard Henderson wrote: > >> On 04/07/2018 04:20 AM, Emilio G. Cota wrote: > >>> +next_page = (ctx->base.pc_first & TARGET_PAGE_MASK) + >

Re: [Qemu-devel] [PATCH v2 2/2] sdl: Allow OpenGL ES context creation

2018-04-10 Thread Gerd Hoffmann
On Tue, Apr 10, 2018 at 01:02:22PM +0100, Elie Tournier wrote: > Signed-off-by: Elie Tournier > --- > include/ui/sdl2.h | 1 + > qemu-options.hx | 2 +- > ui/sdl2-gl.c | 17 +++-- > ui/sdl2.c | 1 + > vl.c | 4 > 5

[Qemu-devel] [Bug 1761027] Re: Unexpected error: "AioContext polling is not implemented on Windows"

2018-04-10 Thread Peter Maydell
** Summary changed: - Unexpected error + Unexpected error: "AioContext polling is not implemented on Windows" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761027 Title: Unexpected error:

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

2018-04-10 Thread Peter Maydell
This is now fixed in master (and will be in 2.12.0) with commits 0790f8686107 and 87f963be66a32453e001. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-04-10 Thread Peter Maydell
Now fixed in master in commit a2e2d7fc46fd8be, so will be in 2.12.0. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1748434 Title:

  1   2   3   >