Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

On Tue, Apr 17, 2018 at 09:28:42AM +0530, Bharata B Rao wrote: > On Mon, Apr 16, 2018 at 07:47:29PM +0300, Serhii Popovych wrote: > > Bharata B Rao wrote: > > > On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: > > >> Now recent kernels (i.e. since linux-stable commit a346137e9142 >

[Qemu-devel] [PATCH for-2.13 09/10] target/ppc: Don't bother with MSR_EP in cpu_ppc_set_papr()

cpu_ppc_set_papr() removes the EP and HV bits from the MSR mask. While removing the HV bit makes sense (a cpu in PAPR mode should never be emulated in hypervisor mode), the EP bit is just bizarre. Although it's true that a papr mode guest shouldn't be able to change the exception prefix, the

Re: [Qemu-devel] [PATCH v3 for-2.13 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files

On Mon, Apr 16, 2018 at 08:44:40AM +0200, Thomas Huth wrote: > 'vlan' is very confusing since it does not mean something like IEEE > 802.1Q, but rather emulated hubs, so let's switch to that terminology > instead. > > Buglink: https://bugs.launchpad.net/qemu/+bug/658904 > Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523953455-28053-1-git-send-email-wanpen...@tencent.com Subject: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

On Tue, Apr 17, 2018 at 11:14:27AM +1000, David Gibson wrote: > > static void spapr_machine_2_12_class_options(MachineClass *mc) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > > index d60b7c6d7a..5e044c44af 100644 > > --- a/include/hw/ppc/spapr.h > > +++

[Qemu-devel] [PATCH for-2.13 04/10] spapr: Set compatibility mode before the rest of spapr_cpu_reset()

Although the order doesn't really matter at the moment, it's possible other initializastions could depend on the compatiblity mode, so make sure we set it first in spapr_cpu_reset(). While we're at it drop the test against first_cpu. Setting the compat mode to the value it already has is

Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

On 17.04.2018 09:21, Stefan Hajnoczi wrote: > On Mon, Apr 16, 2018 at 08:44:39AM +0200, Thomas Huth wrote: >> @@ -499,10 +497,11 @@ >> # @opts: device type specific properties (legacy) >> # >> # Since: 1.2 >> +# >> +# 'vlan' - removed with 2.12 > > Not sure how to interpret this. How about

Re: [Qemu-devel] [PATCH v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523952337-27449-1-git-send-email-wanpen...@tencent.com Subject: [Qemu-devel] [PATCH v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

Stefan Hajnoczi writes: > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: >> > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: >> > > In the future the monitor iothread may be accessing

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > > > In the future the monitor iothread may be accessing the cur_mon as > > > well (via

[Qemu-devel] [PATCH for-2.13 02/10] spapr: Remove support for PowerPC 970 with pseries machine type

Current POWER cpus allow for a VRMA, a special mapping which describes a guest's view of memory when in real mode (MMU off, from the guest's point of view). Older cpus didn't have that which meant that to support a guest a special host-contiguous region of memory was needed to give the guest its

[Qemu-devel] [PATCH for-2.13 00/10] spapr: Cleanups to PAPR mode setup

This series contains a number of cleanups to the way we set up and start a guest in PAPR mode. Applies on top of my ppc-for-2.13 branch. David Gibson (10): spapr: Avoid redundant calls to spapr_cpu_reset() spapr: Remove support for PowerPC 970 with pseries machine type target/ppc: Remove

[Qemu-devel] [PATCH for-2.13 01/10] spapr: Avoid redundant calls to spapr_cpu_reset()

af81cf323c1 "spapr: CPU hotplug support" added a direct call to spapr_cpu_reset() in spapr_cpu_init(), as well as registering it as a reset callback. That was in order to make sure that the reset function got called for a newly hotplugged cpu, which would miss the global machine reset. However,

[Qemu-devel] [PATCH for-2.13 05/10] spapr: Move PAPR mode register initialization to spapr code

cpu_ppc_set_papr() has code to make sure the LPCR and AMOR (hypervisor privileged registers) have values which will make TCG behave correctly for paravirtualized guests, where we don't emulate the cpu when in hypervisor mode. It does this by mangling the default values of the SPRs, so that they

[Qemu-devel] [PATCH for-2.13 06/10] target/ppc: Add ppc_store_lpcr() helper

There are some fields in the cpu state which need to be updated when the LPCR register is changed, which is done by ppc_hash64_update_rmls() and ppc_hash64_update_vrma(). Code which alters env->spr[SPR_LPCR] needs to call them afterwards to make sure the state is up to date. That's easy to get

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, April 17, 2018 4:38 AM > To: Zhang, Yulei > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > joonas.lahti...@linux.intel.com; zhen...@linux.intel.com;

Re: [Qemu-devel] [PATCH] tests: request access to locality 0 before sending command

Hi On Mon, Apr 16, 2018 at 7:48 PM, Stefan Berger wrote: > Recent changes to the CRB code now require that access to locality 0 > be requested before the locality can be used for sending a command. > This patch adds the request to access the locality. > >

[Qemu-devel] [PATCH for-2.13 07/10] spapr: Make a helper to set up cpu entry point state

Under PAPR, only the boot CPU is active when the system starts. Other cpus must be explicitly activated using an RTAS call. The entry state for the boot and secondary cpus isn't identical, but it has some things in common. We're going to add a bit more common setup later, too, so to simplify

Re: [Qemu-devel] Purpose of memory-backend-file.discard-data

On 04/16/2018 07:59 PM, Eduardo Habkost wrote: > (CCing Zack Cornelius) > > On Fri, Apr 13, 2018 at 08:21:26AM +0200, Michal Privoznik wrote: >> Eduardo et al, >> >> I'm looking at 11ae6ed8affdd131e and I wanted to implement libvirt >> support for that. But more I look at it less I understand it.

[Qemu-devel] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized based on on ppc64_radix_guest(). Which seems reasonable, except that ppc64_radix_guest() is based on spapr->patb_entry which is only set up in spapr_machine_reset, called much later than cpu_ppc_set_papr(). So the

[Qemu-devel] [PATCH for-2.13 10/10] spapr: Move PAPR specific cpu logic to pseries machine type

cpu_ppc_set_papr() does three things: 1) it sets up the virtual hypervisor interface, 2) it prevents the cpu from ever entering hypervisor mode and 3) it tells KVM that we're emulating a cpu in PAPR mode. (1) & (2) make sense for any virtual hypervisor (if one ever exists). (3) belongs more

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

> -Original Message- > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Monday, April 16, 2018 10:45 PM > To: Zhang, Yulei ; qemu-devel@nongnu.org > Cc: Tian, Kevin ; joonas.lahti...@linux.intel.com; > zhen...@linux.intel.com; Wang,

[Qemu-devel] [PATCH for-2.13 08/10] spapr: Clean up handling of LPCR power-saving exit bits

To prevent spurious wakeups on cpus that are supposed to be disabled, we need to clear the LPCR bits which control certain wakeup events. spapr_cpu_reset() has separate cases here for boot and non-boot (initially inactive) cpus. rtas_start_cpu() then turns the LPCR bits on when the non-boot cpus

[Qemu-devel] [PATCH v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

From: Wanpeng Li This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace with per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE in order that to improve latency in some workloads. Cc: Paolo Bonzini Cc:

Re: [Qemu-devel] qapi: [PATCH v2] Implement query-usbhost QMP command

On Mon, Apr 16, 2018 at 03:52:03PM -0700, Alexander Kappner wrote: > Hi Gerd, > > thanks for reviewing. I'll follow up with a v3 of the patch addressing your > proposed changes. > > >> This allows a QMP client to query which USB devices may be available > >> for redirection. > > > At least

Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

On Mon, Apr 16, 2018 at 08:44:39AM +0200, Thomas Huth wrote: > @@ -499,10 +497,11 @@ > # @opts: device type specific properties (legacy) > # > # Since: 1.2 > +# > +# 'vlan' - removed with 2.12 Not sure how to interpret this. How about "removed in 2.13"? > @@ -2028,10 +2028,9 @@ DEF("nic",

Re: [Qemu-devel] [PATCH v3 for-2.13 3/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files

On Mon, Apr 16, 2018 at 08:44:41AM +0200, Thomas Huth wrote: > -@subsection Connecting VLANs between QEMU instances > +@subsection Hubs > + > +QEMU can simulate several hubs. A hub can be symbolised as a virtual > connection s/symbolised/thought of/ Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

From: Wanpeng Li This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace with per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE in order that to improve latency in some workloads. Cc: Paolo Bonzini Cc:

Re: [Qemu-devel] [PATCH v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1523952337-27449-1-git-send-email-wanpen...@tencent.com Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

On 16 April 2018 at 20:39, Richard Henderson wrote: > On 04/16/2018 03:54 AM, Alex Bennée wrote: >> +/* Inf / x or 0 / x */ >> +if (a.cls == float_class_inf || a.cls == float_class_zero) { >> +a.sign = sign; >> +return a; >> +} > > 0/0

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

On 16 April 2018 at 14:54, Alex Bennée wrote: > The re-factoring of div_floats changed the order of checking meaning > an operation like -inf/0 erroneously raises the divbyzero flag. > IEEE-754 (2008) specifies this should only occur for operations on > finite operands. >

Re: [Qemu-devel] [PATCH 1/2] fpu: Check for inf/x before x/0

On 17 April 2018 at 03:53, Richard Henderson wrote: > The re-factoring of div_floats changed the order of checking meaning > an operation like -inf/0 erroneously raises the divbyzero flag. > IEEE-754 (2008) specifies this should only occur for operations > on finite

Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

On 17/04/2018 10:08, Thomas Huth wrote: >>> -"-net >>> nic[,vlan=n][,netdev=nd][,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n" >>> +"-net >>> nic[,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n" >>> "configure or create an on-board (or

Re: [Qemu-devel] [PULL 0/1] vhost: bugfix

On 16 April 2018 at 17:47, Michael S. Tsirkin wrote: > The following changes since commit 38e83a71d02e026d4a6d0ab1ef9855c4924c2c68: > > Update version for v2.12.0-rc3 release (2018-04-11 19:03:24 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 0/1] i386: Don't automatically enable FEAT_KVM_HINTS bits

On 16 April 2018 at 17:39, Eduardo Habkost wrote: > Last remaining fix for -rc4. > > The following changes since commit 042f6a31af3d38eefc6ec995cce1d762c41d4515: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2018-04-16' > into staging (2018-04-16

[Qemu-devel] [PATCH v3 1/2] qcow2: Give the refcount cache the minimum possible size by default

The L2 and refcount caches have default sizes that can be overridden using the l2-cache-size and refcount-cache-size (an additional parameter named cache-size sets the combined size of both caches). Unless forced by one of the aforementioned parameters, QEMU will set the unspecified sizes so that

Re: [Qemu-devel] [Qemu-arm] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none"

On 17 April 2018 at 13:12, Markus Armbruster wrote: > Thomas Huth writes: >> In case someone wants to help with creating some bug fix patches >> during the QEMU hard freeze phase: This test can now be used to >> trigger lots of introspection bugs that we

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

On 16 April 2018 at 19:44, Daniel P. Berrangé wrote: > On Mon, Apr 16, 2018 at 07:28:28PM +0100, Peter Maydell wrote: >> On 16 April 2018 at 19:18, Marc-André Lureau >> wrote: >> > Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed

Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

On 17 April 2018 at 03:53, Richard Henderson wrote: > Without bounding the increment, we can overflow exp either here > in scalbn_decomposed or when adding the bias in round_canonical. > This can result in e.g. underflowing to 0 instead of overflowing > to infinity.

Re: [Qemu-devel] [PATCH v11 10/17] hw/arm/smmuv3: Abort on vfio or vhost case

On 12 April 2018 at 08:38, Eric Auger wrote: > At the moment, the SMMUv3 does not support notification on > TLB invalidation. So let's log an error as soon as such notifier > gets enabled. > > Signed-off-by: Eric Auger > --- > hw/arm/smmuv3.c | 11

Re: [Qemu-devel] [prefix=PATCH for-2.12?] linux-user: check that all of AArch64 SVE extended sigframe is writable

On 16 April 2018 at 20:42, Richard Henderson wrote: > On 04/16/2018 05:19 AM, Peter Maydell wrote: >> In commit 8c5931de0ac7738809 we added support for SVE extended >> sigframe records. These mean that the signal frame might now be >> larger than the size of the

[Qemu-devel] [Bug 1639983] Re: e1000 EEPROM have bad checksum

I was able to get the e1000odi DOS driver to correctly detect the Intel e1000e once I added a PCIe bus, however the e1000 still reports a bad checksum as of this posting with the master branch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none"

Thomas Huth writes: > Many device introspection crashes only happen if you are using a > certain machine, e.g.: > > $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio > {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, > "package":

Re: [Qemu-devel] [PATCH v4 3/4] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF

Hi On Mon, Apr 16, 2018 at 10:57 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Now that we can safely call QOBJECT() on QObject * and children types, >> we can have a single macro to ref/unref the object. >> >> Change the

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On Mon, 16 Apr 2018 17:29:23 +0200 Paolo Bonzini wrote: > On 16/04/2018 16:27, Igor Mammedov wrote: > > On Mon, 16 Apr 2018 15:30:39 +0200 > > Paolo Bonzini wrote: > > > >> On 16/04/2018 15:20, Igor Mammedov wrote: > >>> Generally object doesn't

Re: [Qemu-devel] [PATCH v11 16/17] hw/arm/smmuv3: IOTLB emulation

On 12 April 2018 at 08:38, Eric Auger wrote: > We emulate a TLB cache of size SMMU_IOTLB_MAX_SIZE=256. > It is implemented as a hash table whose key is a combination > of the 16b asid and 48b IOVA. > > Entries are invalidated on TLB invalidation commands, either > globally,

[Qemu-devel] Last call for release-critical fixes for 2.12

I'm planning to tag rc4 this afternoon (UK time), which I expect to be the last rc for the 2.12 series. This is your last chance to flag up anything we absolutely must fix for this release. Please reply to this email and also update https://wiki.qemu.org/Planning/2.12#Known_issues if there's

Re: [Qemu-devel] [PATCH] tests: request access to locality 0 before sending command

On 04/17/2018 05:08 AM, Marc-André Lureau wrote: Hi On Mon, Apr 16, 2018 at 7:48 PM, Stefan Berger wrote: Recent changes to the CRB code now require that access to locality 0 be requested before the locality can be used for sending a command. This patch adds the

Re: [Qemu-devel] [PATCH v11 15/17] hw/arm/smmuv3: Cache/invalidate config data

On 12 April 2018 at 08:38, Eric Auger wrote: > Let's cache config data to avoid fetching and parsing STE/CD > structures on each translation. We invalidate them on data structure > invalidation commands. > > Signed-off-by: Eric Auger > --- >

Re: [Qemu-devel] [PATCH] dump: add Windows dump format to dump-guest-memory

On Tue, 17 Apr 2018 14:03:18 +0200 Marc-André Lureau wrote: > Hi > > On Mon, Apr 16, 2018 at 9:40 PM, Viktor Prutyanov > wrote: > > This patch adds Windows crashdumping feature. Now QEMU can produce > > crashdump file understandable

Re: [Qemu-devel] [PATCH v11 09/17] hw/arm/smmuv3: Implement translate callback

On 12 April 2018 at 08:38, Eric Auger wrote: > This patch implements the IOMMU Memory Region translate() > callback. Most of the code relates to the translation > configuration decoding and check (STE, CD). > > Signed-off-by: Eric Auger >

Re: [Qemu-devel] [PATCH] dump: add Windows dump format to dump-guest-memory

Hi On Mon, Apr 16, 2018 at 9:40 PM, Viktor Prutyanov wrote: > This patch adds Windows crashdumping feature. Now QEMU can produce crashdump > file understandable for WinDbg. The crashdump will be obtained by joining > physical memory dump and 8K header exposed

Re: [Qemu-devel] [RFC 17/18] validator.py script

Eduardo Habkost writes: > See cover letter for a description of the new test system. > > TODO: code clean up > TODO: write description. > > Signed-off-by: Eduardo Habkost > --- > scripts/validator.py | 724 >

Re: [Qemu-devel] [PATCH] dump: add Windows dump format to dump-guest-memory

Hi On Tue, Apr 17, 2018 at 2:35 PM, Viktor Prutyanov wrote: > On Tue, 17 Apr 2018 14:03:18 +0200 > Marc-André Lureau wrote: > >> Hi >> >> On Mon, Apr 16, 2018 at 9:40 PM, Viktor Prutyanov >> wrote: >> >

Re: [Qemu-devel] [PATCH V6 11/17] qapi: Add new command to query colo status

Zhang Chen writes: > Libvirt or other high level software can use this command query colo status. > You can test this command like that: > {'execute':'query-colo-status'} > > Signed-off-by: Zhang Chen > --- > migration/colo.c| 31

Re: [Qemu-devel] [RFC PATCH V4 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, April 17, 2018 4:15 AM > To: Kirti Wankhede > Cc: Zhang, Yulei ; qemu-devel@nongnu.org; Tian, > Kevin ;

Re: [Qemu-devel] [PATCH v11 11/17] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

On 12 April 2018 at 08:38, Eric Auger wrote: > In case the MSI is translated by an IOMMU we need to fixup the > MSI route with the translated address. > > Signed-off-by: Eric Auger > Signed-off-by: Bharat Bhushan > > --- > v9

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 3/4] arm: always start from first_cpu when registering loader cpu reset callback

On Mon, 16 Apr 2018 18:17:51 +0100 Peter Maydell wrote: > On 12 April 2018 at 19:29, Peter Maydell wrote: > > On 12 April 2018 at 17:40, Igor Mammedov wrote: > >> if arm_load_kernel() were passed non first_cpu, QEMU

[Qemu-devel] [PATCH v3 2/2] docs: Document the new default sizes of the qcow2 caches

We have just reduced the refcount cache size to the minimum unless the user explicitly requests a larger one, so we have to update the documentation to reflect this change. Signed-off-by: Alberto Garcia --- docs/qcow2-cache.txt | 33 - 1 file

[Qemu-devel] [PATCH v3 0/2] Give the refcount cache the minimum possible size by default

Hi, we talked about this the other day, so here are the patches to change the default cache sizes in qcow2. Without this patch: * refcount-cache-size = l2-cache-size / 4 unless otherwise specified by the user. This is wasteful, the refcount cache is accessed sequentially during normal I/O, so

Re: [Qemu-devel] Last call for release-critical fixes for 2.12

Am 17.04.2018 um 15:03 schrieb Peter Maydell: > I'm planning to tag rc4 this afternoon (UK time), which I expect > to be the last rc for the 2.12 series. This is your last chance > to flag up anything we absolutely must fix for this release. > Please reply to this email and also update >

[Qemu-devel] [PATCH v5 2/5] qobject: use a QObjectBase_ struct

By moving the base fields to a QObjectBase_, QObject can be a type which also has a 'base' field. This allows to write a generic QOBJECT() macro that will work with any QObject type, including QObject itself. The container_of() macro ensures that the object to cast has a QObjectBase_ base field,

[Qemu-devel] [PATCH v5 5/5] qobject: modify qobject_ref() to assert on NULL

While it may be convenient to accept NULL value in qobject_unref() (for similar reasons as free() accepts NULL), it is not such a good idea for qobject_ref(), assert() on NULL. One place relied on that behaviour (the monitor request id), and it's best to be explicit that NULL is accepted there.

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

Eric Blake writes: > On 03/12/2018 04:07 AM, Paolo Bonzini wrote: >> On 12/03/2018 08:27, Thomas Huth wrote: >>> "-net" is clearly a legacy option. Yet we still use it in almost all >>> examples in the qemu documentation, and many other spots in the network >>> chapter. We

Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

Richard Henderson writes: > Without bounding the increment, we can overflow exp either here > in scalbn_decomposed or when adding the bias in round_canonical. > This can result in e.g. underflowing to 0 instead of overflowing > to infinity. > > The old softfloat

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

On Tue, Apr 17, 2018 at 03:56:25PM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 03/12/2018 04:07 AM, Paolo Bonzini wrote: > >> On 12/03/2018 08:27, Thomas Huth wrote: > >>> "-net" is clearly a legacy option. Yet we still use it in almost all > >>> examples in

[Qemu-devel] [PATCH 3/4] exec: extract address_space_translate_iommu, fix page_mask corner case

This will be used to process IOMMUs in a MemoryRegionCache. This includes a small bugfix, in that the returned page_mask is now correctly -1 if the IOMMU memory region maps the entire address space directly. Previously, address_space_get_iotlb_entry would return ~TARGET_PAGE_MASK.

[Qemu-devel] [PATCH 0/4] exec: reintroduce MemoryRegion caching

MemoryRegionCache was reverted to "normal" address_space_* operations for 2.9, due to lack of support for IOMMUs. This series reinstates optimizations, caching only the IOMMU translation but not the IOMMU lookup and target AddressSpace translation. Patches 1 to 3 prepare by introducing a new

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

On 17/04/2018 16:05, Daniel P. Berrangé wrote: >> For what it's worth, my "[RFC PATCH 00/32] Command line QAPIfication" >> replaces the original parsing art by getopt_long_only(). >> >> Completing that work will take some time, but once it's done, we can >> (and I think we should) prefer

Re: [Qemu-devel] [PATCH v1] dump: add Windows dump format to dump-guest-memory

Hi On Tue, Apr 17, 2018 at 3:50 PM, Viktor Prutyanov wrote: > This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump > containing Windows crashdump header, which can help to convert to a valid > WinDbg-understandable crashdump file, or

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

On Tue, 17 Apr 2018 13:40:32 + "Zhang, Yulei" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, April 17, 2018 4:23 AM > > To: Kirti Wankhede > > Cc: Zhang, Yulei

Re: [Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks

On 17/04/18 15:15, Anthony PERARD wrote: > On Fri, Apr 06, 2018 at 10:21:23PM +0100, Igor Druzhinin wrote: >> Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced >> a subtle bug. As soon as the guest switches off Bus Mastering on the >> device it immediately causes all the BARs

Re: [Qemu-devel] [RFC PATCH V4 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

On Tue, 17 Apr 2018 10:36:53 + "Zhang, Yulei" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, April 17, 2018 4:15 AM > > To: Kirti Wankhede > > Cc: Zhang, Yulei

Re: [Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

Hi Alex On 04/16/2018 05:08 PM, Alex Bennée wrote: > Now all the build infrastructure is in place we can build tests for > each guest that we support. That support mainly depends on having > cross compilers installed or docker setup. To keep all the logic for > that together we

[Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

expected_downtime value is not accurate with dirty_pages_rate * page_size, using ram_bytes_remaining would yeild it correct. Signed-off-by: Balamuruhan S --- migration/migration.c | 6 +++--- migration/migration.h | 1 + 2 files changed, 4 insertions(+), 3

Re: [Qemu-devel] Patch for ARM memory barriers and getdent

On 16 April 2018 at 19:44, Henry Wertz wrote: > Please find submitted a patch for ARM memory barriers. This patch is > against qemu-2.12-rc2 but I do believe it should apply for anything from > 2.11.x to current. Hi Henry; thanks for these patches. Please could you provide a

[Qemu-devel] [PATCH v5 4/5] qobject: modify qobject_ref() to return obj

For convenience and clarity, make it possible to call qobject_ref() at the time when the reference is associated with a variable, or argument, by making qobject_ref() return the same pointer as given. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qnull.h

[Qemu-devel] [PATCH v5 1/5] qobject: ensure base is at offset 0

All QObject types have the base QObject as first field. This allows to simplify qobject_to() and will allow further simplification in following patch. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qobject.h | 5 ++--- qobject/qobject.c | 9 +

Re: [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

Forgot to mention: yes, I know this has been merged already. I'm merely trying to catch up with recent block layer progress.

Re: [Qemu-devel] Last call for release-critical fixes for 2.12

Am 17.04.2018 um 15:50 schrieb Peter Maydell: > On 17 April 2018 at 14:19, Stefan Weil wrote: >> Update po files? That's not a "must fix", but it would be nice to have >> those files synchronized with ui/gtk.c again. > Judging by the "POT-Creation-Date" timestamps, we haven't

[Qemu-devel] [PATCH v1 0/1] xilinx_spips dummy bytes fix

For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi. Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles.

Re: [Qemu-devel] [PATCH v2] qemu-doc: Rework the network options chapter to make "-net" less prominent

Paolo Bonzini writes: > On 17/04/2018 16:05, Daniel P. Berrangé wrote: >>> For what it's worth, my "[RFC PATCH 00/32] Command line QAPIfication" >>> replaces the original parsing art by getopt_long_only(). >>> >>> Completing that work will take some time, but once it's done,

Re: [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

John Snow writes: > This series seeks to address two distinct but closely related issues > concerning the job management API. > > (1) For jobs that complete when a monitor is not attached and receiving > events or notifications, there's no way to discern the job's final >

Re: [Qemu-devel] [PATCH 2/2] fpu: Bound increment for scalbn

On 17 April 2018 at 14:51, Alex Bennée wrote: > > Richard Henderson writes: > >> Without bounding the increment, we can overflow exp either here >> in scalbn_decomposed or when adding the bias in round_canonical. >> This can result in e.g.

Re: [Qemu-devel] nfit issue

+ linux acpi +qemu-devel > -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Monday, April 16, 2018 10:23 AM > To: Schmauss, Erik > Cc: Zhang, Haozhong ; Moore, Robert > ; He,

Re: [Qemu-devel] [PATCH v2 5/7] ACPICA: Integrate package handling with module-level code

> -Original Message- > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Dan Williams > Sent: Monday, April 16, 2018 4:22 PM > To: Schmauss, Erik > Cc: Rafael J. Wysocki ; Linux ACPI

[Qemu-devel] [PATCH 1/4] exec: move memory access declarations to a common header, inline *_phys functions

For now, this reduces the text size very slightly due to the newly-added inlining: text size before: 9301965 text size after: 9300645 Later, however, the declarations in include/exec/memory_ldst.inc.h will be reused for the MemoryRegionCache slow path functions. Signed-off-by: Paolo

[Qemu-devel] [PATCH] slirp: Send window updates to guest after window was closed

If the receive window presented to the guest closes, slirp should send a window update once the window reopens sufficiently, rather than forcing the guest to send a window probe, which can take several seconds. Signed-off-by: James Clarke --- Hi, I encountered this whilst

Re: [Qemu-devel] Last call for release-critical fixes for 2.12

On Tue, Apr 17, 2018 at 04:05:46PM +0200, Stefan Weil wrote: > Am 17.04.2018 um 15:50 schrieb Peter Maydell: > > On 17 April 2018 at 14:19, Stefan Weil wrote: > >> Update po files? That's not a "must fix", but it would be nice to have > >> those files synchronized with ui/gtk.c

Re: [Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks

On 17/04/18 15:15, Anthony PERARD wrote: > On Fri, Apr 06, 2018 at 10:21:23PM +0100, Igor Druzhinin wrote: >> Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced >> a subtle bug. As soon as the guest switches off Bus Mastering on the >> device it immediately causes all the BARs

Re: [Qemu-devel] [RFC PATCH V4 3/4] vfio: Add SaveVMHanlders for VFIO device to support live migration

On Tue, 17 Apr 2018 08:11:12 + "Zhang, Yulei" wrote: > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, April 17, 2018 4:38 AM > > To: Zhang, Yulei > > Cc: qemu-devel@nongnu.org; Tian,

Re: [Qemu-devel] [RFC 17/18] validator.py script

On Tue, Apr 17, 2018 at 02:01:53PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > See cover letter for a description of the new test system. > > > > TODO: code clean up > > TODO: write description. > > > > Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v2] xen/pt: use address_space_memory object for memory region hooks

Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced a subtle bug. As soon as the guest switches off Bus Mastering on the device it immediately causes all the BARs be unmapped due to the DMA address space of the device being changed. This is undesired behavior because the guest

[Qemu-devel] [PATCH v1] xilinx_spips dummy bytes fix

For zynq-7000 boards, we saw issues when u-boot/linux accessing the qspi. Issue is due to wrong dummy byte transfers for few of un-handled commands ex: 0x9F, 0x6, 0xe9, 0x4, 0x18, etc There are many unhandled commands which do not require dummy bytes but they can be followed by address cycles.

[Qemu-devel] [PATCH v2 0/1] migration: calculate expected_downtime with ram_bytes_remaining()

Hi, v2: There is some difference in expected_downtime value due to following reason, 1. bandwidth and expected_downtime value are calculated in migration_update_counters() during each iteration from migration_thread() 2. remaining ram is calculated in qmp_query_migrate() when we actually call

Re: [Qemu-devel] [PATCH v4 4/4] qobject: modify qobject_ref() to assert on NULL and return obj

Hi On Mon, Apr 16, 2018 at 10:26 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Following a discussion on the mailing list: > > If a reader of this commit message could profit from reading the > discussion, refer to it by URL and/or

[Qemu-devel] [PATCH v5 0/5] Simplify qobject refcount

Hi, This series aims to get rid of the distinction between QObject, that must use qobject_incref/qobject_decref and its various derived types that have to use QINCREF/QDECREF. Instead, replace it with qobject_ref/qobject_unref for all types. v5: after Markus review - various commit message &

[Qemu-devel] [PATCH v1] dump: add Windows dump format to dump-guest-memory

This patch adds Windows crashdumping feature. Now QEMU can produce ELF-dump containing Windows crashdump header, which can help to convert to a valid WinDbg-understandable crashdump file, or immediately create such file. The crashdump will be obtained by joining physical memory dump and 8K header

Re: [Qemu-devel] Last call for release-critical fixes for 2.12

On 17 April 2018 at 14:19, Stefan Weil wrote: > Update po files? That's not a "must fix", but it would be nice to have > those files synchronized with ui/gtk.c again. Judging by the "POT-Creation-Date" timestamps, we haven't done that for a year or so, so there doesn't seem to

Re: [Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks

ping?

  1   2   3   >